)]}'
{"neutronclient/common/exceptions.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9acebbccbf22c4b9a7a1dc280ba799ecbcf24356","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":65,"context_line":"        if \u0027status_code\u0027 in kwargs:"},{"line_number":66,"context_line":"            self.status_code \u003d kwargs[\u0027status_code\u0027]"},{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_9605ea46","line":66,"updated":"2016-02-02 01:39:26.000000000","message":"In addition to adding request-id to the message,\nI think it is better to have request_ids attribute.\n\n  self.request_ids \u003d kwargs.get(\u0027request_ids\u0027)\n\n(I don\u0027t think it needs to be placed inside of if-clause)","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"99611c68253ff16fe1ff1a380bceba8b78c0b0e7","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":65,"context_line":"        if \u0027status_code\u0027 in kwargs:"},{"line_number":66,"context_line":"            self.status_code \u003d kwargs[\u0027status_code\u0027]"},{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_94394d44","line":66,"in_reply_to":"7a5de9d1_9605ea46","updated":"2016-02-22 12:38:23.000000000","message":"I also think it\u0027s better to make request_ids an attribute.\nAnd we can output the request_ids in line 50 __str__() function.\nit can simplify the code.","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"deea4a3a7a2f2a675b4dc609bd5ef5e0a88c217b","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"},{"line_number":65,"context_line":"        if \u0027status_code\u0027 in kwargs:"},{"line_number":66,"context_line":"            self.status_code \u003d kwargs[\u0027status_code\u0027]"},{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_e7a6b8bf","line":66,"in_reply_to":"bae84128_94394d44","updated":"2016-02-24 10:33:11.000000000","message":"Done","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9acebbccbf22c4b9a7a1dc280ba799ecbcf24356","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if \u0027status_code\u0027 in kwargs:"},{"line_number":66,"context_line":"            self.status_code \u003d kwargs[\u0027status_code\u0027]"},{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""},{"line_number":70,"context_line":"                                        \"\u0027%s\u0027\") % kwargs[\u0027request_ids\u0027]"},{"line_number":71,"context_line":"                message +\u003d \" \" + request_ids_message"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_96708a0c","line":68,"updated":"2016-02-02 01:39:26.000000000","message":"(same question as for L.72)\nI think \u0027message\u0027 is always \u0027str\u0027, but is there a case \u0027message\u0027 is not a string?","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"d0448393097acf8605da4787ac86b1797a13fa62","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if \u0027status_code\u0027 in kwargs:"},{"line_number":66,"context_line":"            self.status_code \u003d kwargs[\u0027status_code\u0027]"},{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""},{"line_number":70,"context_line":"                                        \"\u0027%s\u0027\") % kwargs[\u0027request_ids\u0027]"},{"line_number":71,"context_line":"                message +\u003d \" \" + request_ids_message"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_d19f674e","line":68,"in_reply_to":"7a5de9d1_96708a0c","updated":"2016-02-22 12:15:58.000000000","message":"Hi Akihiro Motoki:\nI think there is a case \u0027message\u0027 is a dict:\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/v2_0/client.py#L74\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\n70            else:\n71                raise exceptions.NeutronClientException(\n72                    status_code\u003dstatus_code, message\u003derror_message)\n73        else:\n74            raise exceptions.NeutronClientException(status_code\u003dstatus_code,\n75                                                    message\u003derror_dict)\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"deea4a3a7a2f2a675b4dc609bd5ef5e0a88c217b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if \u0027status_code\u0027 in kwargs:"},{"line_number":66,"context_line":"            self.status_code \u003d kwargs[\u0027status_code\u0027]"},{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""},{"line_number":70,"context_line":"                                        \"\u0027%s\u0027\") % kwargs[\u0027request_ids\u0027]"},{"line_number":71,"context_line":"                message +\u003d \" \" + request_ids_message"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_c7757432","line":68,"in_reply_to":"bae84128_6fd4af1f","updated":"2016-02-24 10:33:11.000000000","message":"Make sense. I updated based on the patch.","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25d068e10393b9ff9bf8100e742c52530393656b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        if \u0027status_code\u0027 in kwargs:"},{"line_number":66,"context_line":"            self.status_code \u003d kwargs[\u0027status_code\u0027]"},{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""},{"line_number":70,"context_line":"                                        \"\u0027%s\u0027\") % kwargs[\u0027request_ids\u0027]"},{"line_number":71,"context_line":"                message +\u003d \" \" + request_ids_message"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_6fd4af1f","line":68,"in_reply_to":"bae84128_d19f674e","updated":"2016-02-22 15:15:11.000000000","message":"Ah.... I think it is a mistake because \u0027message\u0027 is directly returned by __str__(). I am fixing it in https://review.openstack.org/#/c/253267/2/neutronclient/v2_0/client.py but it does not attract reviewers for a long time....","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9acebbccbf22c4b9a7a1dc280ba799ecbcf24356","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""},{"line_number":70,"context_line":"                                        \"\u0027%s\u0027\") % kwargs[\u0027request_ids\u0027]"},{"line_number":71,"context_line":"                message +\u003d \" \" + request_ids_message"},{"line_number":72,"context_line":"            if isinstance(message, dict):"},{"line_number":73,"context_line":"                message[\u0027request_ids\u0027] \u003d kwargs[\u0027request_ids\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_b6526665","line":70,"updated":"2016-02-02 01:39:26.000000000","message":"I think a single quote around %s is unnecessary.\nWe already use a colon.\n\nIn addition, to avoid [u\u0027xxxx\u0027], consider:\n\n  \u0027 \u0027.join(kwargs[\u0027request_ids\u0027])","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"deea4a3a7a2f2a675b4dc609bd5ef5e0a88c217b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        if \u0027request_ids\u0027 in kwargs:"},{"line_number":68,"context_line":"            if isinstance(message, str):"},{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""},{"line_number":70,"context_line":"                                        \"\u0027%s\u0027\") % kwargs[\u0027request_ids\u0027]"},{"line_number":71,"context_line":"                message +\u003d \" \" + request_ids_message"},{"line_number":72,"context_line":"            if isinstance(message, dict):"},{"line_number":73,"context_line":"                message[\u0027request_ids\u0027] \u003d kwargs[\u0027request_ids\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_a7703041","line":70,"in_reply_to":"7a5de9d1_b6526665","updated":"2016-02-24 10:33:11.000000000","message":"Done","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9acebbccbf22c4b9a7a1dc280ba799ecbcf24356","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""},{"line_number":70,"context_line":"                                        \"\u0027%s\u0027\") % kwargs[\u0027request_ids\u0027]"},{"line_number":71,"context_line":"                message +\u003d \" \" + request_ids_message"},{"line_number":72,"context_line":"            if isinstance(message, dict):"},{"line_number":73,"context_line":"                message[\u0027request_ids\u0027] \u003d kwargs[\u0027request_ids\u0027]"},{"line_number":74,"context_line":"        super(NeutronClientException, self).__init__(message, **kwargs)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_76a70ea7","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":41},"updated":"2016-02-02 01:39:26.000000000","message":"Is there a case where \u0027message\u0027 is dict?","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"deea4a3a7a2f2a675b4dc609bd5ef5e0a88c217b","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                request_ids_message \u003d _(\"Neutron server returns request_ids: \""},{"line_number":70,"context_line":"                                        \"\u0027%s\u0027\") % kwargs[\u0027request_ids\u0027]"},{"line_number":71,"context_line":"                message +\u003d \" \" + request_ids_message"},{"line_number":72,"context_line":"            if isinstance(message, dict):"},{"line_number":73,"context_line":"                message[\u0027request_ids\u0027] \u003d kwargs[\u0027request_ids\u0027]"},{"line_number":74,"context_line":"        super(NeutronClientException, self).__init__(message, **kwargs)"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_4798446a","line":72,"range":{"start_line":72,"start_character":12,"end_line":72,"end_character":41},"in_reply_to":"7a5de9d1_76a70ea7","updated":"2016-02-24 10:33:11.000000000","message":"Removed","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"48d5526a4d1d83a9ca8c725b044a8196c64d775c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    status_code \u003d 0"},{"line_number":63,"context_line":"    req_ids_msg \u003d _(\"Neutron server returns request_ids:\")"},{"line_number":64,"context_line":"    request_ids \u003d []"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_0a0803d9","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":58},"updated":"2016-02-24 11:15:39.000000000","message":"It is better to include %s (for request_ids)\n\n  Neutron server returns request_ids: %s\n\nand change the below to:\n\n  self.req_ids_msg % self.request_ids\n\nThis is the basic guideline on i18n.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"765dca76c55ce7e55519bd1121db231a37d02d56","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    \"\"\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    status_code \u003d 0"},{"line_number":63,"context_line":"    req_ids_msg \u003d _(\"Neutron server returns request_ids:\")"},{"line_number":64,"context_line":"    request_ids \u003d []"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def __init__(self, message\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_e3c936ae","line":63,"range":{"start_line":63,"start_character":20,"end_line":63,"end_character":58},"in_reply_to":"bae84128_0a0803d9","updated":"2016-02-25 14:00:10.000000000","message":"Make sense.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"48d5526a4d1d83a9ca8c725b044a8196c64d775c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                message \u003d \u0027 \u0027.join([message,"},{"line_number":73,"context_line":"                                    self.req_ids_msg] + self.request_ids)"},{"line_number":74,"context_line":"            else:"},{"line_number":75,"context_line":"                message \u003d \u0027 \u0027.join([self.req_ids_msg] + self.request_ids)"},{"line_number":76,"context_line":"        super(NeutronClientException, self).__init__(message, **kwargs)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_cada9b16","line":75,"updated":"2016-02-24 11:15:39.000000000","message":"Yeah... there is no good pattern to handle this kind of string formatting...\n\nHow about the following? It is a bit simple.\n\n  if self.request_ids:\n      req_ids_msg \u003d self.req_ids_msg % self.request_ids\n      if message:\n          message +\u003d \u0027 \u0027 + req_ids_msg\n      else:\n          message \u003d req_ids_msg\n\nFrom the point of view of i18n, it is not good to concatenate strings, but I don\u0027t have good idea for this.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"765dca76c55ce7e55519bd1121db231a37d02d56","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                message \u003d \u0027 \u0027.join([message,"},{"line_number":73,"context_line":"                                    self.req_ids_msg] + self.request_ids)"},{"line_number":74,"context_line":"            else:"},{"line_number":75,"context_line":"                message \u003d \u0027 \u0027.join([self.req_ids_msg] + self.request_ids)"},{"line_number":76,"context_line":"        super(NeutronClientException, self).__init__(message, **kwargs)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_03e41a0b","line":75,"in_reply_to":"bae84128_cada9b16","updated":"2016-02-25 14:00:10.000000000","message":"Good suggestion. I really appreciate it.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"647b02d97721d546e76096643bf46a62491bda70","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        if self.request_ids:"},{"line_number":71,"context_line":"            req_ids_msg \u003d self.req_ids_msg % self.request_ids"},{"line_number":72,"context_line":"            if message:"},{"line_number":73,"context_line":"                message +\u003d \u0027 \u0027 + req_ids_msg"},{"line_number":74,"context_line":"            else:"},{"line_number":75,"context_line":"                message \u003d req_ids_msg"},{"line_number":76,"context_line":"        super(NeutronClientException, self).__init__(message, **kwargs)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_34cb8674","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":31},"updated":"2016-02-25 18:39:27.000000000","message":"According to my testing, \u0027\\n\u0027 looks better.\n\nhttp://paste.openstack.org/show/488242/ (with \u0027 \u0027) and\nhttp://paste.openstack.org/show/488243/ (with \u0027\\n\u0027).","commit_id":"b9820901c19335dfbb38c8e5585b017b53e4aca7"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"919921f7df9fb70034d4d98088bdc8f3a0fa0181","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        if self.request_ids:"},{"line_number":71,"context_line":"            req_ids_msg \u003d self.req_ids_msg % self.request_ids"},{"line_number":72,"context_line":"            if message:"},{"line_number":73,"context_line":"                message +\u003d \u0027 \u0027 + req_ids_msg"},{"line_number":74,"context_line":"            else:"},{"line_number":75,"context_line":"                message \u003d req_ids_msg"},{"line_number":76,"context_line":"        super(NeutronClientException, self).__init__(message, **kwargs)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9aed3d3a_ead11bfd","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":31},"in_reply_to":"9aed3d3a_34cb8674","updated":"2016-02-26 07:18:21.000000000","message":"Nice suggestion.","commit_id":"b9820901c19335dfbb38c8e5585b017b53e4aca7"}],"neutronclient/tests/unit/test_cli20.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1fc2a675cc513d6027262483ca19dd66f37ecc2f","unresolved":false,"context_lines":[{"line_number":690,"context_line":"    def test_exception_handler_v20_ip_address_in_use(self):"},{"line_number":691,"context_line":"        err_msg \u003d (\u0027Unable to complete operation for network \u0027"},{"line_number":692,"context_line":"                   \u0027fake-network-uuid. The IP address fake-ip is in use.\u0027)"},{"line_number":693,"context_line":""},{"line_number":694,"context_line":"        self._test_exception_handler_v20("},{"line_number":695,"context_line":"            exceptions.IpAddressInUseClient, 409, err_msg,"},{"line_number":696,"context_line":"            \u0027IpAddressInUse\u0027, err_msg, \u0027\u0027, REQUEST_ID)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_4cc27854","line":693,"updated":"2016-01-26 01:06:07.000000000","message":"unnecessary line ;) I will fix in next PS.","commit_id":"bdb2af472ff053c28aea1d7b678fea49b60fa97f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9acebbccbf22c4b9a7a1dc280ba799ecbcf24356","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        self.client.httpclient.auth_token \u003d encodeutils.safe_encode("},{"line_number":575,"context_line":"            unicode_text)"},{"line_number":576,"context_line":"        expected_auth_token \u003d encodeutils.safe_encode(unicode_text)"},{"line_number":577,"context_line":"        headers \u003d {\u0027x-openstack-request-id\u0027: REQUEST_ID}"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        self.client.httpclient.request("},{"line_number":580,"context_line":"            end_url(expected_action, query\u003dexpect_query, format\u003dself.format),"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_56da1218","line":577,"range":{"start_line":577,"start_character":8,"end_line":577,"end_character":15},"updated":"2016-02-02 01:39:26.000000000","message":"response_headers (or resp_headers if you prefer to a shorter name) is a better name. I first thought it is a request header....","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"deea4a3a7a2f2a675b4dc609bd5ef5e0a88c217b","unresolved":false,"context_lines":[{"line_number":574,"context_line":"        self.client.httpclient.auth_token \u003d encodeutils.safe_encode("},{"line_number":575,"context_line":"            unicode_text)"},{"line_number":576,"context_line":"        expected_auth_token \u003d encodeutils.safe_encode(unicode_text)"},{"line_number":577,"context_line":"        headers \u003d {\u0027x-openstack-request-id\u0027: REQUEST_ID}"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        self.client.httpclient.request("},{"line_number":580,"context_line":"            end_url(expected_action, query\u003dexpect_query, format\u003dself.format),"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_87a6ccab","line":577,"range":{"start_line":577,"start_character":8,"end_line":577,"end_character":15},"in_reply_to":"7a5de9d1_56da1218","updated":"2016-02-24 10:33:11.000000000","message":"Done","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9acebbccbf22c4b9a7a1dc280ba799ecbcf24356","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        self.assertEqual(body, result)"},{"line_number":654,"context_line":"        self.assertEqual([REQUEST_ID], result.request_ids)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"class CLITestV20ExceptionHandler(CLITestV20Base):"},{"line_number":658,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_d6336260","line":655,"updated":"2016-02-02 01:39:26.000000000","message":"Can you add a unit test for pagination list?","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"deea4a3a7a2f2a675b4dc609bd5ef5e0a88c217b","unresolved":false,"context_lines":[{"line_number":652,"context_line":""},{"line_number":653,"context_line":"        self.assertEqual(body, result)"},{"line_number":654,"context_line":"        self.assertEqual([REQUEST_ID], result.request_ids)"},{"line_number":655,"context_line":""},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"class CLITestV20ExceptionHandler(CLITestV20Base):"},{"line_number":658,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_67a10894","line":655,"in_reply_to":"7a5de9d1_d6336260","updated":"2016-02-24 10:33:11.000000000","message":"Done","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"298e46200afbe04a98434fc22e9cbcad480b6613","unresolved":false,"context_lines":[{"line_number":692,"context_line":"                   \u0027fake-network-uuid. The IP address fake-ip is in use.\u0027)"},{"line_number":693,"context_line":"        self._test_exception_handler_v20("},{"line_number":694,"context_line":"            exceptions.IpAddressInUseClient, 409, err_msg,"},{"line_number":695,"context_line":"            \u0027IpAddressInUse\u0027, err_msg, \u0027\u0027, REQUEST_ID)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def test_exception_handler_v20_neutron_known_error(self):"},{"line_number":698,"context_line":"        known_error_map \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_212e21a5","line":695,"range":{"start_line":695,"start_character":42,"end_line":695,"end_character":53},"updated":"2016-02-23 03:31:08.000000000","message":"Looks like this should  be \u0027request_id\u003dREQUEST_ID\u0027, or it will be treated as the 6th parameter \u0027error_detail\u0027.","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"68068422be85e43917d91930ee502340ba121821","unresolved":false,"context_lines":[{"line_number":692,"context_line":"                   \u0027fake-network-uuid. The IP address fake-ip is in use.\u0027)"},{"line_number":693,"context_line":"        self._test_exception_handler_v20("},{"line_number":694,"context_line":"            exceptions.IpAddressInUseClient, 409, err_msg,"},{"line_number":695,"context_line":"            \u0027IpAddressInUse\u0027, err_msg, \u0027\u0027, REQUEST_ID)"},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"    def test_exception_handler_v20_neutron_known_error(self):"},{"line_number":698,"context_line":"        known_error_map \u003d ["}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_8539f6a6","line":695,"range":{"start_line":695,"start_character":42,"end_line":695,"end_character":53},"in_reply_to":"bae84128_212e21a5","updated":"2016-02-23 03:33:25.000000000","message":"What I said here is wrong, sorry.","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e5709a634733ae884ea84bf8c5bd6e623379ec8a","unresolved":false,"context_lines":[{"line_number":794,"context_line":"                                                   resstr2))"},{"line_number":795,"context_line":"        self.mox.ReplayAll()"},{"line_number":796,"context_line":"        result \u003d self.client.list(resources, path, retrieve_all\u003dFalse)"},{"line_number":797,"context_line":"        result.next()"},{"line_number":798,"context_line":"        self.assertEqual([REQUEST_ID], result.request_ids)"},{"line_number":799,"context_line":"        result.next()"},{"line_number":800,"context_line":"        self.assertEqual([REQUEST_ID, REQUEST_ID], result.request_ids)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_9db9a9ef","line":797,"range":{"start_line":797,"start_character":8,"end_line":797,"end_character":21},"updated":"2016-02-25 12:55:00.000000000","message":"next(result)","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"765dca76c55ce7e55519bd1121db231a37d02d56","unresolved":false,"context_lines":[{"line_number":794,"context_line":"                                                   resstr2))"},{"line_number":795,"context_line":"        self.mox.ReplayAll()"},{"line_number":796,"context_line":"        result \u003d self.client.list(resources, path, retrieve_all\u003dFalse)"},{"line_number":797,"context_line":"        result.next()"},{"line_number":798,"context_line":"        self.assertEqual([REQUEST_ID], result.request_ids)"},{"line_number":799,"context_line":"        result.next()"},{"line_number":800,"context_line":"        self.assertEqual([REQUEST_ID, REQUEST_ID], result.request_ids)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_b8f758f4","line":797,"range":{"start_line":797,"start_character":8,"end_line":797,"end_character":21},"in_reply_to":"bae84128_9db9a9ef","updated":"2016-02-25 14:00:10.000000000","message":"Nice suggestion.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e5709a634733ae884ea84bf8c5bd6e623379ec8a","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"    def test_generator(self):"},{"line_number":1017,"context_line":"        obj \u003d client._GeneratorWithMeta(self._pagination, \u0027test_collection\u0027,"},{"line_number":1018,"context_line":"                                        \u0027test_path\u0027, test_args\u003d\u0027test_args\u0027)"},{"line_number":1019,"context_line":"        self.assertEqual(self.body, obj.next())"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        self.assertTrue(hasattr(obj, \u0027request_ids\u0027))"},{"line_number":1022,"context_line":"        self.assertEqual([REQUEST_ID], obj.request_ids)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_3d9cdd68","line":1019,"range":{"start_line":1019,"start_character":36,"end_line":1019,"end_character":46},"updated":"2016-02-25 12:55:00.000000000","message":"Need to use next(obj) to make it work for py2 and py3.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"765dca76c55ce7e55519bd1121db231a37d02d56","unresolved":false,"context_lines":[{"line_number":1016,"context_line":"    def test_generator(self):"},{"line_number":1017,"context_line":"        obj \u003d client._GeneratorWithMeta(self._pagination, \u0027test_collection\u0027,"},{"line_number":1018,"context_line":"                                        \u0027test_path\u0027, test_args\u003d\u0027test_args\u0027)"},{"line_number":1019,"context_line":"        self.assertEqual(self.body, obj.next())"},{"line_number":1020,"context_line":""},{"line_number":1021,"context_line":"        self.assertTrue(hasattr(obj, \u0027request_ids\u0027))"},{"line_number":1022,"context_line":"        self.assertEqual([REQUEST_ID], obj.request_ids)"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_18dda470","line":1019,"range":{"start_line":1019,"start_character":36,"end_line":1019,"end_character":46},"in_reply_to":"bae84128_3d9cdd68","updated":"2016-02-25 14:00:10.000000000","message":"Nice suggestion.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d6609e86c5e5675e0113c45de31c9821995c7e31","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class _RequestIdMixin(object):"},{"line_number":107,"context_line":"    \"\"\"Wrapper class to expose x-openstack-request-id to the caller.\"\"\""},{"line_number":108,"context_line":"    def request_ids_setup(self):"},{"line_number":109,"context_line":"        self._request_ids \u003d []"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_31ef0b89","line":108,"updated":"2016-01-21 14:45:48.000000000","message":"Should it be a private method?","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"aaacbbe659f3545c38750ddb1c4ef09919a5adf8","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class _RequestIdMixin(object):"},{"line_number":107,"context_line":"    \"\"\"Wrapper class to expose x-openstack-request-id to the caller.\"\"\""},{"line_number":108,"context_line":"    def request_ids_setup(self):"},{"line_number":109,"context_line":"        self._request_ids \u003d []"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_93df6439","line":108,"in_reply_to":"9a68dd71_31ef0b89","updated":"2016-01-25 10:26:07.000000000","message":"Done","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d6609e86c5e5675e0113c45de31c9821995c7e31","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class _TupleWithMeta(tuple, _RequestIdMixin):"},{"line_number":147,"context_line":"    def __new__(cls, values, resp):"},{"line_number":148,"context_line":"        return super(_TupleWithMeta, cls).__new__(cls, values)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, values, resp):"},{"line_number":151,"context_line":"        self.request_ids_setup()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_ce504e61","line":148,"updated":"2016-01-21 14:45:48.000000000","message":"why do we need to use __new__ here? I just would like to know the reason.","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"aaacbbe659f3545c38750ddb1c4ef09919a5adf8","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"class _TupleWithMeta(tuple, _RequestIdMixin):"},{"line_number":147,"context_line":"    def __new__(cls, values, resp):"},{"line_number":148,"context_line":"        return super(_TupleWithMeta, cls).__new__(cls, values)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, values, resp):"},{"line_number":151,"context_line":"        self.request_ids_setup()"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_13ecd4f1","line":148,"in_reply_to":"9a68dd71_ce504e61","updated":"2016-01-25 10:26:07.000000000","message":"Because we need it for inheritance of tuple.","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d6609e86c5e5675e0113c45de31c9821995c7e31","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, values, resp):"},{"line_number":151,"context_line":"        self.request_ids_setup()"},{"line_number":152,"context_line":"        self._append_request_ids(resp)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"class ClientBase(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_ae7dda1d","line":152,"updated":"2016-01-21 14:45:48.000000000","message":"request_ids_setup() is public and _append_request_ids is private.\nWhat\u0027s the difference between these two?","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"aaacbbe659f3545c38750ddb1c4ef09919a5adf8","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":"    def __init__(self, values, resp):"},{"line_number":151,"context_line":"        self.request_ids_setup()"},{"line_number":152,"context_line":"        self._append_request_ids(resp)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"class ClientBase(object):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_33d23829","line":152,"in_reply_to":"9a68dd71_ae7dda1d","updated":"2016-01-25 10:26:07.000000000","message":"Rights. I changed request_ids_setup() to private.","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d6609e86c5e5675e0113c45de31c9821995c7e31","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                           requests.codes.created,"},{"line_number":249,"context_line":"                           requests.codes.accepted,"},{"line_number":250,"context_line":"                           requests.codes.no_content):"},{"line_number":251,"context_line":"            return self.deserialize(replybody, status_code), resp"},{"line_number":252,"context_line":"        else:"},{"line_number":253,"context_line":"            if not replybody:"},{"line_number":254,"context_line":"                replybody \u003d resp.reason"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_2e4b2a89","line":251,"updated":"2016-01-21 14:45:48.000000000","message":"This only covers successful case. You need to cover failure cases.\nelse-clause deals with failure cases. I think we need request-id for failure cases.","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"aaacbbe659f3545c38750ddb1c4ef09919a5adf8","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                           requests.codes.created,"},{"line_number":249,"context_line":"                           requests.codes.accepted,"},{"line_number":250,"context_line":"                           requests.codes.no_content):"},{"line_number":251,"context_line":"            return self.deserialize(replybody, status_code), resp"},{"line_number":252,"context_line":"        else:"},{"line_number":253,"context_line":"            if not replybody:"},{"line_number":254,"context_line":"                replybody \u003d resp.reason"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_7382f0c9","line":251,"in_reply_to":"9a68dd71_2e4b2a89","updated":"2016-01-25 10:26:07.000000000","message":"Done","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d6609e86c5e5675e0113c45de31c9821995c7e31","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def delete(self, action, body\u003dNone, headers\u003dNone, params\u003dNone):"},{"line_number":310,"context_line":"        data, resp \u003d self.retry_request(\"DELETE\", action, body\u003dbody,"},{"line_number":311,"context_line":"                                        headers\u003dheaders, params\u003dparams)"},{"line_number":312,"context_line":"        return self._convert_into_with_meta(data, resp)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def get(self, action, body\u003dNone, headers\u003dNone, params\u003dNone):"},{"line_number":315,"context_line":"        data, resp \u003d self.retry_request(\"GET\", action, body\u003dbody,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_ee6d1205","line":312,"updated":"2016-01-21 14:45:48.000000000","message":"I think do_request returns a value after calling _convert_into_with_meta.","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"aaacbbe659f3545c38750ddb1c4ef09919a5adf8","unresolved":false,"context_lines":[{"line_number":309,"context_line":"    def delete(self, action, body\u003dNone, headers\u003dNone, params\u003dNone):"},{"line_number":310,"context_line":"        data, resp \u003d self.retry_request(\"DELETE\", action, body\u003dbody,"},{"line_number":311,"context_line":"                                        headers\u003dheaders, params\u003dparams)"},{"line_number":312,"context_line":"        return self._convert_into_with_meta(data, resp)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def get(self, action, body\u003dNone, headers\u003dNone, params\u003dNone):"},{"line_number":315,"context_line":"        data, resp \u003d self.retry_request(\"GET\", action, body\u003dbody,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a68dd71_938524d0","line":312,"in_reply_to":"9a68dd71_ee6d1205","updated":"2016-01-25 10:26:07.000000000","message":"Done","commit_id":"94539758debba90091663193b624cf6c68286449"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"d0448393097acf8605da4787ac86b1797a13fa62","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                request_ids.extend(r.request_ids)"},{"line_number":350,"context_line":"            return _DictWithMeta({collection: res}, request_ids)"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            return self._pagination(collection, path, **params)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _pagination(self, collection, path, **params):"},{"line_number":355,"context_line":"        if params.get(\u0027page_reverse\u0027, False):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_e98449d5","line":352,"range":{"start_line":352,"start_character":24,"end_line":352,"end_character":35},"updated":"2016-02-22 12:15:58.000000000","message":"Looks like this solution doesn\u0027t consistent with what the spec[1] said about \nGenerator.\nI think the result should looks like:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nresult \u003d client.list(collection,path,retrieve_all\u003dFalse)\nresult.next()\n......\nresult.next()\n......\nresult.requet_ids\n[\u0027req-xxxxxxxxxx\u0027,\u0027req-yyyyyyyyyy\u0027]\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nnot this:\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nresult \u003d client.list(collection,path,retrieve_all\u003dFalse)\nresult.next().request_ids\n[\u0027req-xxxxxxxxxx\u0027]\nresult.next().request_ids\n[\u0027req-yyyyyyyyyy\u0027]\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFor this solution, users must deal with request_ids every time next() is called,\nbut with the warpper function recommend by the spec,  user just need to deal\nwith request_ids once.\n\nWhy not implement an _GeneratorWrapper to warp this?\n\n\n[1] : http://specs.openstack.org/openstack/openstack-specs/specs/return-request-id.html#proposed-change","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"deea4a3a7a2f2a675b4dc609bd5ef5e0a88c217b","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                request_ids.extend(r.request_ids)"},{"line_number":350,"context_line":"            return _DictWithMeta({collection: res}, request_ids)"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            return self._pagination(collection, path, **params)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _pagination(self, collection, path, **params):"},{"line_number":355,"context_line":"        if params.get(\u0027page_reverse\u0027, False):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_27b260e5","line":352,"range":{"start_line":352,"start_character":24,"end_line":352,"end_character":35},"in_reply_to":"bae84128_e98449d5","updated":"2016-02-24 10:33:11.000000000","message":"Done","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a5349d324380c2eecbc7f344853de40ee95791f7","unresolved":false,"context_lines":[{"line_number":349,"context_line":"                request_ids.extend(r.request_ids)"},{"line_number":350,"context_line":"            return _DictWithMeta({collection: res}, request_ids)"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            return self._pagination(collection, path, **params)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _pagination(self, collection, path, **params):"},{"line_number":355,"context_line":"        if params.get(\u0027page_reverse\u0027, False):"}],"source_content_type":"text/x-python","patch_set":8,"id":"bae84128_586dc1ca","line":352,"range":{"start_line":352,"start_character":24,"end_line":352,"end_character":35},"in_reply_to":"bae84128_e98449d5","updated":"2016-02-24 11:14:50.000000000","message":"Hi Cao,\n\nDoes your suggestion change the type of the returned value from a list to a generator? I am afraid this breaks existing python scripts. This class is intended to be used not only by neutron CLI but also external python programs. Thus we should be very careful when changing the type of the return value.\n\nCould you check your suggestion breaks nothing?","commit_id":"9887e586bbb69e822f27bd624286a2b1a1357c60"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e5709a634733ae884ea84bf8c5bd6e623379ec8a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            self.generator \u003d self._paginate()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        try:"},{"line_number":188,"context_line":"            obj, req_id \u003d self.generator.next()"},{"line_number":189,"context_line":"            self._append_request_ids(req_id)"},{"line_number":190,"context_line":"        except StopIteration:"},{"line_number":191,"context_line":"            raise StopIteration()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_fd47151b","line":188,"range":{"start_line":188,"start_character":26,"end_line":188,"end_character":47},"updated":"2016-02-25 12:55:00.000000000","message":"next(\u003cgenerator\u003e) works for both py2 and py3.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"765dca76c55ce7e55519bd1121db231a37d02d56","unresolved":false,"context_lines":[{"line_number":185,"context_line":"            self.generator \u003d self._paginate()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"        try:"},{"line_number":188,"context_line":"            obj, req_id \u003d self.generator.next()"},{"line_number":189,"context_line":"            self._append_request_ids(req_id)"},{"line_number":190,"context_line":"        except StopIteration:"},{"line_number":191,"context_line":"            raise StopIteration()"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_78d4b046","line":188,"range":{"start_line":188,"start_character":26,"end_line":188,"end_character":47},"in_reply_to":"bae84128_fd47151b","updated":"2016-02-25 14:00:10.000000000","message":"Nice suggestion.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"48d5526a4d1d83a9ca8c725b044a8196c64d775c","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                request_ids.extend(r.request_ids)"},{"line_number":376,"context_line":"            return _DictWithMeta({collection: res}, request_ids)"},{"line_number":377,"context_line":"        else:"},{"line_number":378,"context_line":"            return _GeneratorWithMeta(self._pagination, collection,"},{"line_number":379,"context_line":"                                      path, **params)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _pagination(self, collection, path, **params):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_1802190a","line":378,"updated":"2016-02-24 11:15:39.000000000","message":"I know other reviewer suggest to use a generator, but doesn\u0027t it change the current behavior? The current implementation returns a list and it now returns a generator.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":20105,"name":"Cao ShuFeng","email":"caosf.fnst@cn.fujitsu.com","username":"caosf.fnst"},"change_message_id":"80e070ebebd9643ca515b39f3910e512b244416c","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                request_ids.extend(r.request_ids)"},{"line_number":376,"context_line":"            return _DictWithMeta({collection: res}, request_ids)"},{"line_number":377,"context_line":"        else:"},{"line_number":378,"context_line":"            return _GeneratorWithMeta(self._pagination, collection,"},{"line_number":379,"context_line":"                                      path, **params)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _pagination(self, collection, path, **params):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_417ae924","line":378,"in_reply_to":"bae84128_1802190a","updated":"2016-02-24 12:49:49.000000000","message":"What I suggested is just what the spec[1] said about a generator.\nAnd as far as I can see, it does return a generator originally.\nMay be we wait for suggestions from someone else?\nIf you hate such change deeply, than I will keep quiet,since I am a newbie and the request_ids call still be returned to users with every yield value.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"9d0448dbcefadf3761220c5419589165991e610a","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                request_ids.extend(r.request_ids)"},{"line_number":376,"context_line":"            return _DictWithMeta({collection: res}, request_ids)"},{"line_number":377,"context_line":"        else:"},{"line_number":378,"context_line":"            return _GeneratorWithMeta(self._pagination, collection,"},{"line_number":379,"context_line":"                                      path, **params)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _pagination(self, collection, path, **params):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_ece5e2db","line":378,"in_reply_to":"bae84128_417ae924","updated":"2016-02-24 17:00:44.000000000","message":"I think that current implementation returns not a list but a generator. I tried in current implementation.\n\nhttp://paste.openstack.org/show/488052/","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"02a430d30ea18542fbb32be54d72c890ecdaec54","unresolved":false,"context_lines":[{"line_number":375,"context_line":"                request_ids.extend(r.request_ids)"},{"line_number":376,"context_line":"            return _DictWithMeta({collection: res}, request_ids)"},{"line_number":377,"context_line":"        else:"},{"line_number":378,"context_line":"            return _GeneratorWithMeta(self._pagination, collection,"},{"line_number":379,"context_line":"                                      path, **params)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"    def _pagination(self, collection, path, **params):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bae84128_0940f106","line":378,"in_reply_to":"bae84128_ece5e2db","updated":"2016-02-25 02:16:04.000000000","message":"Thanks. You are correct. Sorry for bothering you.","commit_id":"cf2aee6ad880f0c3cae37e2e316abb8d7ff18b32"}]}
