)]}'
{"id":"openstack%2Fpython-neutronclient~270510","triplet_id":"openstack%2Fpython-neutronclient~master~Ifc613de1d340bafe6b391ae490fb380d06a36dbe","project":"openstack/python-neutronclient","branch":"master","topic":"rm-argparse","hashtags":[],"change_id":"Ifc613de1d340bafe6b391ae490fb380d06a36dbe","subject":"Revert \"Remove argparse from requirements\"","status":"ABANDONED","created":"2016-01-20 22:39:44.000000000","updated":"2016-01-25 15:00:52.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"30e0de4d9bf17476c8063ea43c44999137bc1e8a","_number":270510,"virtual_id_number":270510,"owner":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":1,"date":"2016-01-21 00:32:48.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-01-20 22:54:20.000000000","_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":-1,"date":"2016-01-25 07:50:02.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"value":-1,"date":"2016-01-25 11:20:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2016-01-20 22:39:53.000000000","_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-01-20 22:39:53.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2016-01-21 00:32:48.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-01-25 07:50:02.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2016-01-25 11:20:54.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"}],"messages":[{"id":"dc0876a28df2269a30fc9943ec9954ed6bb5404e","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2016-01-20 22:52:02.000000000","message":"Patch Set 1:\n\nJust to be clear - I think its up to each project to decide if they\u0027re supporting 2.6 on a best-effort basis / not at all. My point in the other reviews was to be clear that we\u0027re not \u0027fixing\u0027 everything - or really anything - by running around removing argparse.\n\nFWIW: install counts from the pypi logs for the last week for neutronclient - 2.6 is used more than 3.4, though less than 3.x combined.\n\n1 \t2.7\t20439 \t \n2 \tnull\t580 \t \n3 \t2.6\t148 \t \n4 \t3.4\t117 \t \n5 \t3.5\t80 \t \n6 \t3.3\t1","accounts_in_message":[],"_revision_number":1},{"id":"842e55570017a93c419b0b541814132eb8a6eeca","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2016-01-20 22:54:20.000000000","message":"Patch Set 1:\n\nI\u0027m going to leave the final call up to Akihiro, who does the most client stuff for neutron. But I wanted to get this review up,  before lifeless\u0027s comments disappeared into a merged review.","accounts_in_message":[],"_revision_number":1},{"id":"c56ec7685307c276b1dffe16b898e0d3c421ab47","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-01-21 00:32:48.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/10/270510/1/check/gate-python-neutronclient-pep8/a91752f/ : SUCCESS in 1m 40s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/10/270510/1/check/gate-python-neutronclient-docs/51906a0//doc/build/html/ : SUCCESS in 1m 29s\n- gate-python-neutronclient-python27 http://logs.openstack.org/10/270510/1/check/gate-python-neutronclient-python27/1c5f927/ : SUCCESS in 1m 31s\n- gate-python-neutronclient-python34 http://logs.openstack.org/10/270510/1/check/gate-python-neutronclient-python34/de57103/ : SUCCESS in 1m 55s\n- gate-python-neutronclient-requirements http://logs.openstack.org/10/270510/1/check/gate-python-neutronclient-requirements/f5f59ee/ : SUCCESS in 29s\n- gate-python-neutronclient-pypy http://logs.openstack.org/10/270510/1/check/gate-python-neutronclient-pypy/1b03269/ : SUCCESS in 1m 59s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/10/270510/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/45dd864/ : SUCCESS in 1h 45m 11s\n- gate-python-neutronclient-releasenotes http://docs-draft.openstack.org/10/270510/1/check/gate-python-neutronclient-releasenotes/d940302//releasenotes/build/html/ : SUCCESS in 1m 31s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/10/270510/1/check/gate-neutronclient-test-dsvm-functional/c480f1e/ : SUCCESS in 30m 54s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/10/270510/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/f1350b0/ : SUCCESS in 36m 35s","accounts_in_message":[],"_revision_number":1},{"id":"6c40d89ec57c70feb1c183721a5320ebbc1afddc","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-01-21 16:11:27.000000000","message":"Patch Set 1:\n\nI would like to drop argparse from requirements.txt in the same timing as other python-*client such as novaclient. I have no strong opinion on this and am looking at the situation of other clients.\n\nIn my understanding, we don\u0027t support python 2.6 now but I think most of neutronclient still works with python 2.6. Dropping argparse means an immediately drop of python 2.6, but there is no reason we prevent python 2.6 aggressively.","accounts_in_message":[],"_revision_number":1},{"id":"016ef77e98fe4f1485700fd270459bb8a1e2eee0","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2016-01-25 07:50:02.000000000","message":"Patch Set 1: Code-Review-1\n\nDoug, we\u0027re not supporting python 2.6 at all in python-neutronclient - for quite some time. There\u0027s no best-effort.","accounts_in_message":[],"_revision_number":1},{"id":"6283215be2588ee3cc8d72fae9b5a19483c91c62","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-01-25 11:20:54.000000000","message":"Patch Set 1: Code-Review-1\n\nI thought a bit more. I am okay with dropping argparse.\n\nWe are no longer testing our code against python26 and there is no guarantee neutronclient works on python26.\nIn addition, if argparse is the only requirement to make neutronclient work on python26, such users (or distributors) can install argparse manually.","accounts_in_message":[],"_revision_number":1},{"id":"44524ea21e438b5d858c2239ac09cbe74c086f8a","author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"date":"2016-01-25 15:00:52.000000000","message":"Abandoned\n\nThanks for the input, all.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"56d41a70d2cf9d04561fe0a2c324a5e9f4255d14","revisions":{"56d41a70d2cf9d04561fe0a2c324a5e9f4255d14":{"kind":"REWORK","_number":1,"created":"2016-01-20 22:39:44.000000000","uploader":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"ref":"refs/changes/10/270510/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/10/270510/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/10/270510/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/10/270510/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/10/270510/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/10/270510/1"}}},"commit":{"parents":[{"commit":"0259e03feaaaf6ed6742bd6512b00eb9f7fc16a4","subject":"Remove argparse from requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/0259e03feaaaf6ed6742bd6512b00eb9f7fc16a4"}]}],"author":{"name":"Doug Wiegley","email":"dougwig@parkside.io","date":"2016-01-20 22:39:44.000000000","tz":0},"committer":{"name":"Doug Wiegley","email":"dougwig@parkside.io","date":"2016-01-20 22:39:44.000000000","tz":0},"subject":"Revert \"Remove argparse from requirements\"","message":"Revert \"Remove argparse from requirements\"\n\nBased on lifeless\u0027s comments.\n\nThis reverts commit 0259e03feaaaf6ed6742bd6512b00eb9f7fc16a4.\n\nChange-Id: Ifc613de1d340bafe6b391ae490fb380d06a36dbe\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/56d41a70d2cf9d04561fe0a2c324a5e9f4255d14"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/56d41a70d2cf9d04561fe0a2c324a5e9f4255d14"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
