)]}'
{"neutronclient/neutron/v2_0/vpn/ikepolicy.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1fd5086eae6df9f59c307d6461dc90cadd65cd10","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutronclient.neutron.v2_0.vpn import utils as vpn_utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def add_common_args(parser, is_create\u003dTrue):"},{"line_number":26,"context_line":"    parser.add_argument("},{"line_number":27,"context_line":"        \u0027--description\u0027,"},{"line_number":28,"context_line":"        help\u003d_(\u0027Description of the IKE policy\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_4c3574f5","line":25,"updated":"2016-01-26 15:59:14.000000000","message":"Nit: Should each occurrence of add_common_args() in modules have an underscore prefix (private)?","commit_id":"ee98b139ac9465150043e579bce3ac73e0d3441f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6f0c5b7f7cecf59f2f0ae3b122d28a016fffd4b8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutronclient.neutron.v2_0.vpn import utils as vpn_utils"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def add_common_args(parser, is_create\u003dTrue):"},{"line_number":26,"context_line":"    parser.add_argument("},{"line_number":27,"context_line":"        \u0027--description\u0027,"},{"line_number":28,"context_line":"        help\u003d_(\u0027Description of the IKE policy\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_97303909","line":25,"in_reply_to":"9a68dd71_4c3574f5","updated":"2016-01-27 05:02:54.000000000","message":"I dont think its a pretty big issue, and we can proceed with this, I guess.","commit_id":"ee98b139ac9465150043e579bce3ac73e0d3441f"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"15f2e8202dabc4b3bffdd7e45b9cf5fb05c4a9a1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def add_common_args(parser, is_create\u003dTrue):"},{"line_number":26,"context_line":"    parser.add_argument("},{"line_number":27,"context_line":"        \u0027--description\u0027,"},{"line_number":28,"context_line":"        help\u003d_(\u0027Description of the IKE policy\u0027))"},{"line_number":29,"context_line":"    parser.add_argument("},{"line_number":30,"context_line":"        \u0027--auth-algorithm\u0027,"},{"line_number":31,"context_line":"        default\u003d\u0027sha1\u0027 if is_create else argparse.SUPPRESS,"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_5f3341ab","line":28,"updated":"2016-02-12 15:21:38.000000000","message":"period missing at the end.","commit_id":"d9f61bce934d00d8436a36eaa659bb2860105bb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"15f2e8202dabc4b3bffdd7e45b9cf5fb05c4a9a1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":110,"context_line":"        parser.add_argument("},{"line_number":111,"context_line":"            \u0027--name\u0027,"},{"line_number":112,"context_line":"            help\u003d_(\u0027Name of the IKE policy.\u0027))"},{"line_number":113,"context_line":"        add_common_args(parser, is_create\u003dFalse)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_bf2835e3","line":112,"updated":"2016-02-12 15:21:38.000000000","message":"nit: Please change \u0027Name of\u0027 to \u0027Updated name of\u0027.","commit_id":"d9f61bce934d00d8436a36eaa659bb2860105bb4"}],"neutronclient/neutron/v2_0/vpn/ipsec_site_connection.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5968d203b79172347c36272c7eb752328a5e1fa4","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        utils.add_boolean_argument("},{"line_number":199,"context_line":"            parser, \u0027--admin-state-up\u0027,"},{"line_number":200,"context_line":"            help\u003d_(\u0027Update the administrative state. (True meaning \"Up\")\u0027))"},{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027--mtu\u0027,"},{"line_number":203,"context_line":"            help\u003d_(\u0027MTU size for the connection, default:1500\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_9cc8a356","line":201,"updated":"2016-01-25 22:35:24.000000000","message":"can you share the logic?\ndefault\u003dargparse.SUPRESS does work for you?\nhttps://docs.python.org/2.7/library/argparse.html#default","commit_id":"83b0197ffbc918ab59f492d92ee98969b0df3c04"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cb13e6a9da03b89cbd34517446f7aa500aeb530d","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        utils.add_boolean_argument("},{"line_number":199,"context_line":"            parser, \u0027--admin-state-up\u0027,"},{"line_number":200,"context_line":"            help\u003d_(\u0027Update the administrative state. (True meaning \"Up\")\u0027))"},{"line_number":201,"context_line":"        parser.add_argument("},{"line_number":202,"context_line":"            \u0027--mtu\u0027,"},{"line_number":203,"context_line":"            help\u003d_(\u0027MTU size for the connection, default:1500\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_99cf5055","line":201,"in_reply_to":"9a68dd71_9cc8a356","updated":"2016-01-26 00:34:14.000000000","message":"I will try to create a function similar to the one in IPSecPolicy","commit_id":"83b0197ffbc918ab59f492d92ee98969b0df3c04"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1fd5086eae6df9f59c307d6461dc90cadd65cd10","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                self.get_client(), \u0027endpoint_group\u0027,"},{"line_number":119,"context_line":"                parsed_args.peer_ep_group)"},{"line_number":120,"context_line":"            body[\u0027peer_ep_group_id\u0027] \u003d _peer_epg"},{"line_number":121,"context_line":"        if hasattr(parsed_args, \u0027mtu\u0027) and int(parsed_args.mtu) \u003c 68:"},{"line_number":122,"context_line":"            message \u003d _(\"Invalid MTU value: MTU must be \""},{"line_number":123,"context_line":"                        \"greater than or equal to 68\")"},{"line_number":124,"context_line":"            raise exceptions.CommandError(message)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_8cba8c09","line":121,"updated":"2016-01-26 15:59:14.000000000","message":"Could do:\n    if int(getattr(parsed_args, \u0027mtu\u0027, 0)) \u003c 68:","commit_id":"ee98b139ac9465150043e579bce3ac73e0d3441f"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6f0c5b7f7cecf59f2f0ae3b122d28a016fffd4b8","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                self.get_client(), \u0027endpoint_group\u0027,"},{"line_number":119,"context_line":"                parsed_args.peer_ep_group)"},{"line_number":120,"context_line":"            body[\u0027peer_ep_group_id\u0027] \u003d _peer_epg"},{"line_number":121,"context_line":"        if hasattr(parsed_args, \u0027mtu\u0027) and int(parsed_args.mtu) \u003c 68:"},{"line_number":122,"context_line":"            message \u003d _(\"Invalid MTU value: MTU must be \""},{"line_number":123,"context_line":"                        \"greater than or equal to 68\")"},{"line_number":124,"context_line":"            raise exceptions.CommandError(message)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a68dd71_d780f18d","line":121,"in_reply_to":"9a68dd71_8cba8c09","updated":"2016-01-27 05:02:54.000000000","message":"I just wanted to avoid an extra catch of Attribute Error.","commit_id":"ee98b139ac9465150043e579bce3ac73e0d3441f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"53925192b9da832029ac75ef093645b10cfdaab4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import argparse"},{"line_number":18,"context_line":"from oslo_serialization import jsonutils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutronclient._i18n import _"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_5e1fc76b","line":17,"updated":"2016-02-12 14:48:19.000000000","message":"Nit: need a blank line here.","commit_id":"d9f61bce934d00d8436a36eaa659bb2860105bb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"15f2e8202dabc4b3bffdd7e45b9cf5fb05c4a9a1","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            body[\u0027peer_ep_group_id\u0027] \u003d _peer_epg"},{"line_number":122,"context_line":"        if hasattr(parsed_args, \u0027mtu\u0027) and int(parsed_args.mtu) \u003c 68:"},{"line_number":123,"context_line":"            message \u003d _(\"Invalid MTU value: MTU must be \""},{"line_number":124,"context_line":"                        \"greater than or equal to 68\")"},{"line_number":125,"context_line":"            raise exceptions.CommandError(message)"},{"line_number":126,"context_line":"        # ToDo (Reedip) : Remove below check when peer-cidr is removed"},{"line_number":127,"context_line":"        if parsed_args.peer_cidrs and parsed_args.local_ep_group:"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_bf7ef516","line":124,"updated":"2016-02-12 15:21:38.000000000","message":"nit: period missing at the end.","commit_id":"d9f61bce934d00d8436a36eaa659bb2860105bb4"}],"neutronclient/neutron/v2_0/vpn/ipsecpolicy.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5968d203b79172347c36272c7eb752328a5e1fa4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            \u0027--name\u0027,"},{"line_number":105,"context_line":"            help\u003d_(\u0027Updated name of the IPsec policy.\u0027))"},{"line_number":106,"context_line":"        parser.add_argument("},{"line_number":107,"context_line":"            \u0027--transform-protocol\u0027,"},{"line_number":108,"context_line":"            choices\u003d[\u0027esp\u0027, \u0027ah\u0027, \u0027ah-esp\u0027],"},{"line_number":109,"context_line":"            help\u003d_(\u0027Transform protocol in lowercase, default:esp\u0027))"},{"line_number":110,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_9ce5030a","line":107,"updated":"2016-01-25 22:35:24.000000000","message":"Is there any reason we cannot share option definitions between Create and Update? I know the difference is \u0027default\u0027. argparse.SUPPRESS works for you?","commit_id":"83b0197ffbc918ab59f492d92ee98969b0df3c04"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cb13e6a9da03b89cbd34517446f7aa500aeb530d","unresolved":false,"context_lines":[{"line_number":104,"context_line":"            \u0027--name\u0027,"},{"line_number":105,"context_line":"            help\u003d_(\u0027Updated name of the IPsec policy.\u0027))"},{"line_number":106,"context_line":"        parser.add_argument("},{"line_number":107,"context_line":"            \u0027--transform-protocol\u0027,"},{"line_number":108,"context_line":"            choices\u003d[\u0027esp\u0027, \u0027ah\u0027, \u0027ah-esp\u0027],"},{"line_number":109,"context_line":"            help\u003d_(\u0027Transform protocol in lowercase, default:esp\u0027))"},{"line_number":110,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_39c3c439","line":107,"in_reply_to":"9a68dd71_9ce5030a","updated":"2016-01-26 00:34:14.000000000","message":"Let me find a more decent method to combine them together","commit_id":"83b0197ffbc918ab59f492d92ee98969b0df3c04"}],"neutronclient/neutron/v2_0/vpn/vpnservice.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5968d203b79172347c36272c7eb752328a5e1fa4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        add_common_args(parser)"},{"line_number":98,"context_line":"        utils.add_boolean_argument("},{"line_number":99,"context_line":"            parser, \u0027--admin-state-up\u0027,"},{"line_number":100,"context_line":"            help\u003d_(\u0027Update the admin state for the firewall\u0027"},{"line_number":101,"context_line":"                   \u0027(True means UP)\u0027))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_5cfd4baf","line":100,"updated":"2016-01-25 22:35:24.000000000","message":"not firewall!","commit_id":"83b0197ffbc918ab59f492d92ee98969b0df3c04"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cb13e6a9da03b89cbd34517446f7aa500aeb530d","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        add_common_args(parser)"},{"line_number":98,"context_line":"        utils.add_boolean_argument("},{"line_number":99,"context_line":"            parser, \u0027--admin-state-up\u0027,"},{"line_number":100,"context_line":"            help\u003d_(\u0027Update the admin state for the firewall\u0027"},{"line_number":101,"context_line":"                   \u0027(True means UP)\u0027))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a68dd71_d9cb88a2","line":100,"in_reply_to":"9a68dd71_5cfd4baf","updated":"2016-01-26 00:34:14.000000000","message":"Silly Copy pasted mistake...","commit_id":"83b0197ffbc918ab59f492d92ee98969b0df3c04"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"15f2e8202dabc4b3bffdd7e45b9cf5fb05c4a9a1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"def add_common_args(parser):"},{"line_number":23,"context_line":"    parser.add_argument("},{"line_number":24,"context_line":"        \u0027--name\u0027,"},{"line_number":25,"context_line":"        help\u003d_(\u0027Set a name for the VPN service.\u0027))"},{"line_number":26,"context_line":"    parser.add_argument("},{"line_number":27,"context_line":"        \u0027--description\u0027,"},{"line_number":28,"context_line":"        help\u003d_(\u0027Set a description for the VPN service.\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_ff578d57","line":25,"updated":"2016-02-12 15:21:38.000000000","message":"IMO, this help is not consistent with other\u0027s help msg.","commit_id":"d9f61bce934d00d8436a36eaa659bb2860105bb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"15f2e8202dabc4b3bffdd7e45b9cf5fb05c4a9a1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        help\u003d_(\u0027Set a name for the VPN service.\u0027))"},{"line_number":26,"context_line":"    parser.add_argument("},{"line_number":27,"context_line":"        \u0027--description\u0027,"},{"line_number":28,"context_line":"        help\u003d_(\u0027Set a description for the VPN service.\u0027))"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def common_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_bf56f559","line":28,"updated":"2016-02-12 15:21:38.000000000","message":"ditto","commit_id":"d9f61bce934d00d8436a36eaa659bb2860105bb4"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"15f2e8202dabc4b3bffdd7e45b9cf5fb05c4a9a1","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        utils.add_boolean_argument("},{"line_number":101,"context_line":"            parser, \u0027--admin-state-up\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027Update the admin state for the VPN Service\u0027"},{"line_number":103,"context_line":"                   \u0027(True means UP)\u0027))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    def args2body(self, parsed_args):"},{"line_number":106,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":12,"id":"3a57f1b5_3fc9a526","line":103,"updated":"2016-02-12 15:21:38.000000000","message":"period missing at the end.","commit_id":"d9f61bce934d00d8436a36eaa659bb2860105bb4"}]}