)]}'
{"neutronclient/neutron/v2_0/address_scope.py":[{"author":{"_account_id":12999,"name":"James Arendt","email":"james.arendt@hpe.com","username":"jwarendt"},"change_message_id":"22c47348c3f52bb357637216dba581a67d5d048c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        utils.add_boolean_argument("},{"line_number":81,"context_line":"            parser, \u0027--shared\u0027,"},{"line_number":82,"context_line":"            help\u003d_(\u0027Enable/Disable sharing of address scope.\u0027"},{"line_number":83,"context_line":"                   \u0027(True means shared)\u0027))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def args2body(self, parsed_args):"},{"line_number":86,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_655b542f","line":83,"updated":"2016-02-04 18:53:49.000000000","message":"Reword the help message, as generally \u0027--enabled\u0027 is a different concept and might be confusing.  Prefer \u0027Set sharing of address scope.\u0027.\n\nWould prefer default target if option exists here, since create case is simply (--shared) so user might get annoyed that has to explicitly type longer (--shared True) here to get same behavior.","commit_id":"a6986b00b7b25f5e791d7fdfe0c936da04b67ece"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"91a1af1f4a1662c280b2854743ac14b0e6c42606","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        utils.add_boolean_argument("},{"line_number":81,"context_line":"            parser, \u0027--shared\u0027,"},{"line_number":82,"context_line":"            help\u003d_(\u0027Enable/Disable sharing of address scope.\u0027"},{"line_number":83,"context_line":"                   \u0027(True means shared)\u0027))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def args2body(self, parsed_args):"},{"line_number":86,"context_line":"        body \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_cdcb4252","line":83,"in_reply_to":"5a5ae5dd_655b542f","updated":"2016-02-05 00:41:41.000000000","message":"Hi James, for the default value, it is in sync with the behavior of admin_state_up for Update commands in other Neutron CLIs, so maybe yeah, the user would have to type a bit more, but it is consistent with the other update commands.\n\nConsidering this case, I prefer not putting a default value for shared:\n- User creates an Address scope ( shared is true)\n- User realizes that the Address scope is shared and updates the address scope with --shared False. ( shared is False)\n- User decides to change the name only ( if default is provided, address scope will again be shared , which is against the above requirement for the user)\n\n\nI will change the help message though.\n\nHope you agree with my above scenario","commit_id":"a6986b00b7b25f5e791d7fdfe0c936da04b67ece"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ff155b70c3096777faa5a1c8f582426bfbf7773","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                            help\u003d_(\u0027Name of the address scope to update.\u0027))"},{"line_number":81,"context_line":"        utils.add_boolean_argument("},{"line_number":82,"context_line":"            parser, \u0027--shared\u0027,"},{"line_number":83,"context_line":"            help\u003d_(\u0027Set sharing of address scope.\u0027"},{"line_number":84,"context_line":"                   \u0027(True means shared)\u0027))"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_43a259fe","line":83,"updated":"2016-08-10 12:20:12.000000000","message":"A space is needed after a period.","commit_id":"5d54a747a5d9fdbed9c1ce97fafed77c2f27f371"}]}
