)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"984b0c12f34fe2abe0cdf746829c402b497b3660","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- list auto-allocated-topologies"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Update CLI for:"},{"line_number":16,"context_line":"- Create/updated external network with --is-default"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a5de9d1_bf052715","line":16,"updated":"2016-02-02 20:54:43.000000000","message":"we should check with mestery/akihiro if this needs a release note. I think it does.","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"46776ad6c3621cd3e427c2bb450865650ad191d5","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- list auto-allocated-topologies"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Update CLI for:"},{"line_number":16,"context_line":"- Create/updated external network with --is-default"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_c8b96fee","line":16,"in_reply_to":"5a5ae5dd_083467dc","updated":"2016-02-02 23:48:26.000000000","message":"Yes, this needs a release note. Please add one to this patch.","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cfef9d795a677b1a70b8b67416d2181464c3b398","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- list auto-allocated-topologies"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Update CLI for:"},{"line_number":16,"context_line":"- Create/updated external network with --is-default"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_74513662","line":16,"in_reply_to":"5a5ae5dd_c8b96fee","updated":"2016-02-03 02:15:50.000000000","message":"Done","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"366bcdbaa6db680765b5bf8b68ea481635ead5b4","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- list auto-allocated-topologies"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Update CLI for:"},{"line_number":16,"context_line":"- Create/updated external network with --is-default"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_083467dc","line":16,"in_reply_to":"7a5de9d1_bf052715","updated":"2016-02-02 23:46:17.000000000","message":"+1, should be required","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e5f4797ae4e5eb72b92837a4d309a051f772431e","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Add the \u0027auto-allocated-topology-show\u0027 CLI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Expose arguments \u0027--router:external\u0027 and \u0027--is-default\u0027 for"},{"line_number":14,"context_line":"net-create and net-update commands."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a5ae5dd_6f8a3d1d","line":14,"updated":"2016-02-05 05:15:07.000000000","message":"Is there any reason they both need to be in the same patch? They seem completely unrelated unless I\u0027m missing something.","commit_id":"40b1413e280130c1f9b63fc94e82bc765df3dc71"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f864c9734664f25e9df0bfd79fcb995c63b67e49","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Add the \u0027auto-allocated-topology-show\u0027 CLI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Expose arguments \u0027--router:external\u0027 and \u0027--is-default\u0027 for"},{"line_number":14,"context_line":"net-create and net-update commands."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5a5ae5dd_6f147d9f","line":14,"in_reply_to":"5a5ae5dd_6f8a3d1d","updated":"2016-02-05 05:36:40.000000000","message":"No, you\u0027re right. It was just because it\u0027s part of the get-me-a-network workflow for the operator. I am going to leave them out until later because they are driving me nuts.","commit_id":"40b1413e280130c1f9b63fc94e82bc765df3dc71"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"352b04ae28884db33ffc95dc57771085d35393b1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add client bindings for auto-allocated-topology."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add the \u0027auto-allocated-topology-show\u0027 CLI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a5ae5dd_1f0b9f8f","line":11,"updated":"2016-02-05 16:31:47.000000000","message":"Better to make this patch dependent on it\u0027s server patch.","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"19db378f685064cb849b824fd97458d0d375b527","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add client bindings for auto-allocated-topology."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Add the \u0027auto-allocated-topology-show\u0027 CLI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5a5ae5dd_4e1ba373","line":11,"in_reply_to":"5a5ae5dd_1f0b9f8f","updated":"2016-02-05 18:20:25.000000000","message":"Done","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6dcc594d29ed0ea05490ca7ea74c1cab103cc724","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Add the \u0027auto-allocated-topology-show\u0027 CLI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: Ia35e8a946bf0ac0bb085cde46b675d17b0bb2f51"},{"line_number":16,"context_line":"Change-Id: I67a30ce552fd0310e051ac39dda0a763ee29ef6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a5ae5dd_70a2f4fe","line":14,"updated":"2016-02-06 00:23:09.000000000","message":"DocImpact ?\nAPIImpact ??","commit_id":"da57c86a53e1842e622594e269d18bb96b7cfba6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"db8afae353e7eaa5de529e4eadcfb492510322fd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Add the \u0027auto-allocated-topology-show\u0027 CLI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: Ia35e8a946bf0ac0bb085cde46b675d17b0bb2f51"},{"line_number":16,"context_line":"Change-Id: I67a30ce552fd0310e051ac39dda0a763ee29ef6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a5ae5dd_537b3d8c","line":14,"in_reply_to":"5a5ae5dd_1b440119","updated":"2016-02-06 08:02:27.000000000","message":"okay","commit_id":"da57c86a53e1842e622594e269d18bb96b7cfba6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f633e783f3dbf64fda37b635f70c5071e79c5ed2","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Add the \u0027auto-allocated-topology-show\u0027 CLI."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-implements: blueprint get-me-a-network"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: Ia35e8a946bf0ac0bb085cde46b675d17b0bb2f51"},{"line_number":16,"context_line":"Change-Id: I67a30ce552fd0310e051ac39dda0a763ee29ef6e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a5ae5dd_1b440119","line":14,"in_reply_to":"5a5ae5dd_70a2f4fe","updated":"2016-02-06 01:10:53.000000000","message":"I\u0027d say we\u0027re tracking this server side. We can use one bug report to track it all","commit_id":"da57c86a53e1842e622594e269d18bb96b7cfba6"}],"neutronclient/common/utils.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f04f15bc83bbad4e21bd3fa2ddb984641ea95767","unresolved":false,"context_lines":[{"line_number":203,"context_line":"       Support either:"},{"line_number":204,"context_line":"          neutron {command} --tenant-id \u003cID\u003e"},{"line_number":205,"context_line":"       or"},{"line_number":206,"context_line":"          neutron {command} \u003cID\u003e"},{"line_number":207,"context_line":"    \"\"\""},{"line_number":208,"context_line":"    parser.add_argument("},{"line_number":209,"context_line":"        \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_64f97fc8","line":206,"range":{"start_line":206,"start_character":29,"end_line":206,"end_character":31},"updated":"2016-02-03 05:56:18.000000000","message":"This is mostly a reshuffling of code, perhaps it can be spun out into a separate patch?","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0b5a1b41a7090a90d378b009d20a28d36d85d83f","unresolved":false,"context_lines":[{"line_number":203,"context_line":"       Support either:"},{"line_number":204,"context_line":"          neutron {command} --tenant-id \u003cID\u003e"},{"line_number":205,"context_line":"       or"},{"line_number":206,"context_line":"          neutron {command} \u003cID\u003e"},{"line_number":207,"context_line":"    \"\"\""},{"line_number":208,"context_line":"    parser.add_argument("},{"line_number":209,"context_line":"        \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_48598dfd","line":206,"range":{"start_line":206,"start_character":29,"end_line":206,"end_character":31},"in_reply_to":"5a5ae5dd_64f97fc8","updated":"2016-02-04 19:41:03.000000000","message":"Done","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"}],"neutronclient/neutron/v2_0/auto_allocated_topology.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"366bcdbaa6db680765b5bf8b68ea481635ead5b4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        parser.add_argument("},{"line_number":41,"context_line":"            \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"},{"line_number":42,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"},{"line_number":43,"context_line":"        parser.add_argument("},{"line_number":44,"context_line":"            \u0027--tenant_id\u0027,"},{"line_number":45,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":46,"context_line":"        # Allow the admin to do neutron auto-allocated-show \u003ctenant-id\u003e."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_285fe30f","line":43,"updated":"2016-02-02 23:46:17.000000000","message":"Do you really need to add this option ?\nI mean, --tenant-id would be enough.\n\nBesides, with reference to [1], IMHO there is no need to have --tenant_id\n\n[1]: https://review.openstack.org/#/c/251082/3/doc/source/devref/cli_option_guideline.rst","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cfef9d795a677b1a70b8b67416d2181464c3b398","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        parser.add_argument("},{"line_number":41,"context_line":"            \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"},{"line_number":42,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"},{"line_number":43,"context_line":"        parser.add_argument("},{"line_number":44,"context_line":"            \u0027--tenant_id\u0027,"},{"line_number":45,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":46,"context_line":"        # Allow the admin to do neutron auto-allocated-show \u003ctenant-id\u003e."}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_a848b388","line":43,"in_reply_to":"5a5ae5dd_285fe30f","updated":"2016-02-03 02:15:50.000000000","message":"I copied this from ShowQuota. In the next patch set I have created common utils used here and in ShowQuota.","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"366bcdbaa6db680765b5bf8b68ea481635ead5b4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027--tenant_id\u0027,"},{"line_number":45,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":46,"context_line":"        # Allow the admin to do neutron auto-allocated-show \u003ctenant-id\u003e."},{"line_number":47,"context_line":"        # We use a different name for this because the default will"},{"line_number":48,"context_line":"        # override whatever is in the named arg otherwise."},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027pos_tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_887b777b","line":47,"range":{"start_line":47,"start_character":38,"end_line":47,"end_character":42},"updated":"2016-02-02 23:46:17.000000000","message":"It is not clear what ¨this¨ stands for. Can you explain a bit more in the comment?","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cfef9d795a677b1a70b8b67416d2181464c3b398","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            \u0027--tenant_id\u0027,"},{"line_number":45,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":46,"context_line":"        # Allow the admin to do neutron auto-allocated-show \u003ctenant-id\u003e."},{"line_number":47,"context_line":"        # We use a different name for this because the default will"},{"line_number":48,"context_line":"        # override whatever is in the named arg otherwise."},{"line_number":49,"context_line":"        parser.add_argument("},{"line_number":50,"context_line":"            \u0027pos_tenant_id\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_485edf46","line":47,"range":{"start_line":47,"start_character":38,"end_line":47,"end_character":42},"in_reply_to":"5a5ae5dd_887b777b","updated":"2016-02-03 02:15:50.000000000","message":"I hope the new docstring in the common util clarifies it.","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f04f15bc83bbad4e21bd3fa2ddb984641ea95767","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.neutron import v2_0"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ShowAutoAllocatedTopology(v2_0.NeutronCommand, show.ShowOne):"},{"line_number":24,"context_line":"    \"\"\"Show the auto-allocated topology of a given tenant.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    resource \u003d \u0027auto_allocated_topology\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_64541f54","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":31},"updated":"2016-02-03 05:56:18.000000000","message":"do you auto-populate the tenant id on a command such as this? Because command [1] fails for me like [2] (if I call as regular user). If I call this as admin it leads to [3], where all resources have None as their tenant, which is in line with how we really handle the tenant id in Neutron.\n\n[1] neutron --debug auto-allocated-topology-show \n[2] http://paste.openstack.org/show/485801/\n[3] http://paste.openstack.org/show/485802/","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0b5a1b41a7090a90d378b009d20a28d36d85d83f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.neutron import v2_0"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class ShowAutoAllocatedTopology(v2_0.NeutronCommand, show.ShowOne):"},{"line_number":24,"context_line":"    \"\"\"Show the auto-allocated topology of a given tenant.\"\"\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    resource \u003d \u0027auto_allocated_topology\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_a80921df","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":31},"in_reply_to":"5a5ae5dd_64541f54","updated":"2016-02-04 19:41:03.000000000","message":"It seems the tenant_id is not available in the client. We\u0027d have to request keystone for it or something.","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e5f4797ae4e5eb72b92837a4d309a051f772431e","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        client \u003d self.get_client()"},{"line_number":43,"context_line":"        tenant_id \u003d parsed_args.tenant_id"},{"line_number":44,"context_line":"        obj_shower \u003d getattr(client, \"show_%s\" % self.resource)"},{"line_number":45,"context_line":"        data \u003d obj_shower(tenant_id)"},{"line_number":46,"context_line":"        if self.resource in data:"},{"line_number":47,"context_line":"            for k, v in data[self.resource].items():"},{"line_number":48,"context_line":"                if isinstance(v, list):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_cf9a516e","line":45,"updated":"2016-02-05 05:15:07.000000000","message":"The getattr stuff seems a bit unecessary, doesn\u0027 it?\n\ndata \u003d client.show_auto_allocated_topology(tenant_id)","commit_id":"40b1413e280130c1f9b63fc94e82bc765df3dc71"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f864c9734664f25e9df0bfd79fcb995c63b67e49","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        client \u003d self.get_client()"},{"line_number":43,"context_line":"        tenant_id \u003d parsed_args.tenant_id"},{"line_number":44,"context_line":"        obj_shower \u003d getattr(client, \"show_%s\" % self.resource)"},{"line_number":45,"context_line":"        data \u003d obj_shower(tenant_id)"},{"line_number":46,"context_line":"        if self.resource in data:"},{"line_number":47,"context_line":"            for k, v in data[self.resource].items():"},{"line_number":48,"context_line":"                if isinstance(v, list):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a5ae5dd_af1ef5b8","line":45,"in_reply_to":"5a5ae5dd_cf9a516e","updated":"2016-02-05 05:36:40.000000000","message":"Sorry, copy-pasted from ShowQuota. Will fix.","commit_id":"40b1413e280130c1f9b63fc94e82bc765df3dc71"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"352b04ae28884db33ffc95dc57771085d35393b1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"},{"line_number":34,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"},{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \u0027--tenant_id\u0027,"},{"line_number":37,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":38,"context_line":"        return parser"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_7ffbb3c1","line":36,"updated":"2016-02-05 16:31:47.000000000","message":"Since, it\u0027s a new CLI let\u0027s not provide the suppress option.","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"19db378f685064cb849b824fd97458d0d375b527","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"},{"line_number":34,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"},{"line_number":35,"context_line":"        parser.add_argument("},{"line_number":36,"context_line":"            \u0027--tenant_id\u0027,"},{"line_number":37,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":38,"context_line":"        return parser"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_4e6ac382","line":36,"in_reply_to":"5a5ae5dd_7ffbb3c1","updated":"2016-02-05 18:20:25.000000000","message":"Done","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"352b04ae28884db33ffc95dc57771085d35393b1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return parser"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def take_action(self, parsed_args):"},{"line_number":41,"context_line":"        self.log.debug(\u0027run(%s)\u0027, parsed_args)"},{"line_number":42,"context_line":"        client \u003d self.get_client()"},{"line_number":43,"context_line":"        data \u003d client.show_auto_allocated_topology(parsed_args.tenant_id)"},{"line_number":44,"context_line":"        if self.resource in data:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_1fa87f8c","line":41,"updated":"2016-02-05 16:31:47.000000000","message":"Explicit debugs are no more required. Changes are done via .. https://review.openstack.org/#/c/265287/","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"19db378f685064cb849b824fd97458d0d375b527","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return parser"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def take_action(self, parsed_args):"},{"line_number":41,"context_line":"        self.log.debug(\u0027run(%s)\u0027, parsed_args)"},{"line_number":42,"context_line":"        client \u003d self.get_client()"},{"line_number":43,"context_line":"        data \u003d client.show_auto_allocated_topology(parsed_args.tenant_id)"},{"line_number":44,"context_line":"        if self.resource in data:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_ce0c73ee","line":41,"in_reply_to":"5a5ae5dd_1fa87f8c","updated":"2016-02-05 18:20:25.000000000","message":"Done","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"85fb670809f2ac6fce20a52cc02b2247e5ccaff2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"},{"line_number":35,"context_line":"        # Allow people to do"},{"line_number":36,"context_line":"        #    neutron auto-allocated-topology-show \u003ctenant-id\u003e"},{"line_number":37,"context_line":"        # (Only useful to users who can look at other tenants\u0027 topologies.)"},{"line_number":38,"context_line":"        # We use a different name for this arg because the default will"},{"line_number":39,"context_line":"        # override whatever is in the named arg otherwise."},{"line_number":40,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_c67689d6","line":37,"updated":"2016-02-06 09:56:34.000000000","message":"don\u0027t tell me how to write my policy.json! ;)","commit_id":"da57c86a53e1842e622594e269d18bb96b7cfba6"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f633e783f3dbf64fda37b635f70c5071e79c5ed2","unresolved":false,"context_lines":[{"line_number":34,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"},{"line_number":35,"context_line":"        # Allow people to do"},{"line_number":36,"context_line":"        #    neutron auto-allocated-topology-show \u003ctenant-id\u003e"},{"line_number":37,"context_line":"        # (Only useful to users who can look at other tenants\u0027 topologies.)"},{"line_number":38,"context_line":"        # We use a different name for this arg because the default will"},{"line_number":39,"context_line":"        # override whatever is in the named arg otherwise."},{"line_number":40,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_5b6599b2","line":37,"updated":"2016-02-06 01:10:53.000000000","message":"only the admin can do that","commit_id":"da57c86a53e1842e622594e269d18bb96b7cfba6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6dcc594d29ed0ea05490ca7ea74c1cab103cc724","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def take_action(self, parsed_args):"},{"line_number":46,"context_line":"        client \u003d self.get_client()"},{"line_number":47,"context_line":"        tenant_id \u003d parsed_args.tenant_id or parsed_args.pos_tenant_id"},{"line_number":48,"context_line":"        data \u003d client.show_auto_allocated_topology(tenant_id)"},{"line_number":49,"context_line":"        if self.resource in data:"},{"line_number":50,"context_line":"            for k, v in data[self.resource].items():"},{"line_number":51,"context_line":"                if isinstance(v, list):"}],"source_content_type":"text/x-python","patch_set":12,"id":"5a5ae5dd_d09888c2","line":48,"updated":"2016-02-06 00:23:09.000000000","message":"cant we use self.get_client here ?","commit_id":"da57c86a53e1842e622594e269d18bb96b7cfba6"}],"neutronclient/neutron/v2_0/network.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"366bcdbaa6db680765b5bf8b68ea481635ead5b4","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        args \u003d super(UpdateExternalNetwork, self).add_known_arguments(parser)"},{"line_number":193,"context_line":"        utils.add_boolean_argument("},{"line_number":194,"context_line":"            parser, \u0027--is-default\u0027,"},{"line_number":195,"context_line":"            help\u003d_(\u0027Specify whether this should be the default external \u0027"},{"line_number":196,"context_line":"                   \u0027network (True meaning default).\u0027))"},{"line_number":197,"context_line":"        return args"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_c8364fb4","line":195,"updated":"2016-02-02 23:46:17.000000000","message":"As Armando explained in an earlier comment, can this be moved up to the net-update and net-create ?\nThat ways, a --is-default-ext option can be directly added to the net-update and net-create","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cfef9d795a677b1a70b8b67416d2181464c3b398","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        args \u003d super(UpdateExternalNetwork, self).add_known_arguments(parser)"},{"line_number":193,"context_line":"        utils.add_boolean_argument("},{"line_number":194,"context_line":"            parser, \u0027--is-default\u0027,"},{"line_number":195,"context_line":"            help\u003d_(\u0027Specify whether this should be the default external \u0027"},{"line_number":196,"context_line":"                   \u0027network (True meaning default).\u0027))"},{"line_number":197,"context_line":"        return args"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_2855a31c","line":195,"in_reply_to":"5a5ae5dd_c8364fb4","updated":"2016-02-03 02:15:50.000000000","message":"Done","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f04f15bc83bbad4e21bd3fa2ddb984641ea95767","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def _add_arguments_external_network(parser):"},{"line_number":193,"context_line":"    parser.add_argument("},{"line_number":194,"context_line":"        \u0027--router:external\u0027,"},{"line_number":195,"context_line":"        help\u003d_(\u0027Indicates this is an external network.\u0027))"},{"line_number":196,"context_line":"    utils.add_boolean_argument("},{"line_number":197,"context_line":"        parser, \u0027--is-default\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_a740d908","line":194,"range":{"start_line":194,"start_character":18,"end_line":194,"end_character":26},"updated":"2016-02-03 05:56:18.000000000","message":"I recall why these options are not advertised. With this change if I do:\n\nneutron net-create: error: argument --router:external: expected one argument\n\nWhich is a regression from how it used to work. So we either find another solution (look at router\u0027s options --distributed or --ha I have a faint recollection they handled this somehow) or we punt this for a different day).","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2da721b0dd62094a04d75f8cd625a080a7e5eb4c","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def _add_arguments_external_network(parser):"},{"line_number":193,"context_line":"    parser.add_argument("},{"line_number":194,"context_line":"        \u0027--router:external\u0027,"},{"line_number":195,"context_line":"        help\u003d_(\u0027Indicates this is an external network.\u0027))"},{"line_number":196,"context_line":"    utils.add_boolean_argument("},{"line_number":197,"context_line":"        parser, \u0027--is-default\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_e7dc911a","line":194,"range":{"start_line":194,"start_character":18,"end_line":194,"end_character":26},"in_reply_to":"5a5ae5dd_a740d908","updated":"2016-02-03 06:09:08.000000000","message":"I forgot I already have published a patch for --router:external\n\nhttps://review.openstack.org/#/c/137279/\n\nMaybe you can use this and update it accordingly, if required?","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0b5a1b41a7090a90d378b009d20a28d36d85d83f","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def _add_arguments_external_network(parser):"},{"line_number":193,"context_line":"    parser.add_argument("},{"line_number":194,"context_line":"        \u0027--router:external\u0027,"},{"line_number":195,"context_line":"        help\u003d_(\u0027Indicates this is an external network.\u0027))"},{"line_number":196,"context_line":"    utils.add_boolean_argument("},{"line_number":197,"context_line":"        parser, \u0027--is-default\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_535b822e","line":194,"range":{"start_line":194,"start_character":18,"end_line":194,"end_character":26},"in_reply_to":"5a5ae5dd_e7dc911a","updated":"2016-02-04 19:41:03.000000000","message":"I\u0027d prefer to not depend on another patch at this time. Let\u0027s sync up and come up with a plan to consolidate in follow-up patches.","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f04f15bc83bbad4e21bd3fa2ddb984641ea95767","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    utils.add_boolean_argument("},{"line_number":197,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":198,"context_line":"        help\u003d_(\u0027Specify whether this should be the default external \u0027"},{"line_number":199,"context_line":"               \u0027network (True meaning default).\u0027))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def _args2body_external_network(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_e4b9efed","line":199,"range":{"start_line":199,"start_character":38,"end_line":199,"end_character":45},"updated":"2016-02-03 05:56:18.000000000","message":"I\u0027d say \u0027--is-default\u003dFalse to disable, --is-default to enable.\u0027","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0b5a1b41a7090a90d378b009d20a28d36d85d83f","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    utils.add_boolean_argument("},{"line_number":197,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":198,"context_line":"        help\u003d_(\u0027Specify whether this should be the default external \u0027"},{"line_number":199,"context_line":"               \u0027network (True meaning default).\u0027))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"def _args2body_external_network(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_685ec977","line":199,"range":{"start_line":199,"start_character":38,"end_line":199,"end_character":45},"in_reply_to":"5a5ae5dd_e4b9efed","updated":"2016-02-04 19:41:03.000000000","message":"Done","commit_id":"b514d5f80afd1ad77d64800ca71524dad4894fa2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8588cb837844eee711d505b2f33516f4a673702f","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def _add_arguments_external_network(parser):"},{"line_number":193,"context_line":"    parser.add_argument("},{"line_number":194,"context_line":"        \u0027--router:external\u0027,"},{"line_number":195,"context_line":"        help\u003d_(\u0027Indicates this is an external network.\u0027))"},{"line_number":196,"context_line":"    utils.add_boolean_argument("},{"line_number":197,"context_line":"        parser, \u0027--is-default\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_5b062b87","line":194,"updated":"2016-02-05 02:21:52.000000000","message":"I think this breaks the old way of specifying --router:external without passing True","commit_id":"1aa9f5b269c76b189f994fea188e720c517fb2f1"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"67db65372a4560529606a126322be7d688f78061","unresolved":false,"context_lines":[{"line_number":191,"context_line":""},{"line_number":192,"context_line":"def _add_arguments_external_network(parser):"},{"line_number":193,"context_line":"    parser.add_argument("},{"line_number":194,"context_line":"        \u0027--router:external\u0027,"},{"line_number":195,"context_line":"        help\u003d_(\u0027Indicates this is an external network.\u0027))"},{"line_number":196,"context_line":"    utils.add_boolean_argument("},{"line_number":197,"context_line":"        parser, \u0027--is-default\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a5ae5dd_a4a85c21","line":194,"in_reply_to":"5a5ae5dd_5b062b87","updated":"2016-02-05 04:47:54.000000000","message":"Hopefully I have it done right in the next patch set.","commit_id":"1aa9f5b269c76b189f994fea188e720c517fb2f1"}],"neutronclient/neutron/v2_0/quota.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f04f15bc83bbad4e21bd3fa2ddb984641ea95767","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    resource \u003d \"quota\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_parser(self, prog_name):"},{"line_number":102,"context_line":"        parser \u003d super(ShowQuota, self).get_parser(prog_name)"},{"line_number":103,"context_line":"        parser.add_argument("},{"line_number":104,"context_line":"            \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"},{"line_number":105,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_0763edb2","side":"PARENT","line":102,"range":{"start_line":102,"start_character":17,"end_line":102,"end_character":22},"updated":"2016-02-03 05:56:18.000000000","message":"spin these changes elsewhere?","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"0b5a1b41a7090a90d378b009d20a28d36d85d83f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    resource \u003d \"quota\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def get_parser(self, prog_name):"},{"line_number":102,"context_line":"        parser \u003d super(ShowQuota, self).get_parser(prog_name)"},{"line_number":103,"context_line":"        parser.add_argument("},{"line_number":104,"context_line":"            \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"},{"line_number":105,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_c84fbdbb","side":"PARENT","line":102,"range":{"start_line":102,"start_character":17,"end_line":102,"end_character":22},"in_reply_to":"5a5ae5dd_0763edb2","updated":"2016-02-04 19:41:03.000000000","message":"Done","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"}],"neutronclient/shell.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"998a6edebf22684472550bc0b3d2f3c58bb02dd7","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \u0027bash-completion\u0027: BashCompletionCommand,"},{"line_number":153,"context_line":"    \u0027net-list\u0027: network.ListNetwork,"},{"line_number":154,"context_line":"    \u0027net-external-list\u0027: network.ListExternalNetwork,"},{"line_number":155,"context_line":"    \u0027net-external-update\u0027: network.UpdateExternalNetwork,"},{"line_number":156,"context_line":"    \u0027net-show\u0027: network.ShowNetwork,"},{"line_number":157,"context_line":"    \u0027net-create\u0027: network.CreateNetwork,"},{"line_number":158,"context_line":"    \u0027net-delete\u0027: network.DeleteNetwork,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_3fe7f7ad","line":155,"range":{"start_line":155,"start_character":27,"end_line":155,"end_character":34},"updated":"2016-02-02 20:53:43.000000000","message":"I don\u0027t think we should expose this command.  net-update can handle the default field just fine. That said, we may want to enhance the inline help to tell the user what fields are available on create/update.","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cfef9d795a677b1a70b8b67416d2181464c3b398","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    \u0027bash-completion\u0027: BashCompletionCommand,"},{"line_number":153,"context_line":"    \u0027net-list\u0027: network.ListNetwork,"},{"line_number":154,"context_line":"    \u0027net-external-list\u0027: network.ListExternalNetwork,"},{"line_number":155,"context_line":"    \u0027net-external-update\u0027: network.UpdateExternalNetwork,"},{"line_number":156,"context_line":"    \u0027net-show\u0027: network.ShowNetwork,"},{"line_number":157,"context_line":"    \u0027net-create\u0027: network.CreateNetwork,"},{"line_number":158,"context_line":"    \u0027net-delete\u0027: network.DeleteNetwork,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_c8308f0a","line":155,"range":{"start_line":155,"start_character":27,"end_line":155,"end_character":34},"in_reply_to":"7a5de9d1_3fe7f7ad","updated":"2016-02-03 02:15:50.000000000","message":"Done","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"}],"neutronclient/tests/unit/test_auto_allocated_topology.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"b0e357770fee3e3f16234f342af97ba5a485510b","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_show_auto_allocated_topology(self):"},{"line_number":26,"context_line":"        resource \u003d \u0027auto_allocated_topology\u0027"},{"line_number":27,"context_line":"        cmd \u003d aat.ShowAutoAllocatedTopology(test_cli20.MyApp(sys.stdout), None)"},{"line_number":28,"context_line":"        args \u003d [\u0027--tenant-id\u0027, self.test_id]"},{"line_number":29,"context_line":"        self._test_show_resource(resource, cmd, self.test_id, args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_af2bab32","line":27,"updated":"2016-01-27 01:21:30.000000000","message":"shouldnt pep8 fail here ? ( its at 80 chars)","commit_id":"9537cc9098676bd61155f56c2255ad467cff9b24"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5d5a48a9315de63783ecac81f14527e58bc44c41","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_show_auto_allocated_topology(self):"},{"line_number":26,"context_line":"        resource \u003d \u0027auto_allocated_topology\u0027"},{"line_number":27,"context_line":"        cmd \u003d aat.ShowAutoAllocatedTopology(test_cli20.MyApp(sys.stdout), None)"},{"line_number":28,"context_line":"        args \u003d [\u0027--tenant-id\u0027, self.test_id]"},{"line_number":29,"context_line":"        self._test_show_resource(resource, cmd, self.test_id, args)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a68dd71_0a8d057b","line":27,"in_reply_to":"9a68dd71_af2bab32","updated":"2016-01-27 01:48:18.000000000","message":"It\u0027s 79","commit_id":"9537cc9098676bd61155f56c2255ad467cff9b24"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"366bcdbaa6db680765b5bf8b68ea481635ead5b4","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestAutoAllocatedTopologyJSON(test_cli20.CLITestV20Base):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_show_auto_allocated_topology(self):"},{"line_number":26,"context_line":"        resource \u003d \u0027auto_allocated_topology\u0027"},{"line_number":27,"context_line":"        cmd \u003d aat.ShowAutoAllocatedTopology(test_cli20.MyApp(sys.stdout), None)"},{"line_number":28,"context_line":"        args \u003d [\u0027--tenant-id\u0027, self.test_id, self.test_id]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_a8451318","line":25,"updated":"2016-02-02 23:46:17.000000000","message":"Can we add the List TC as well??","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"cfef9d795a677b1a70b8b67416d2181464c3b398","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class TestAutoAllocatedTopologyJSON(test_cli20.CLITestV20Base):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_show_auto_allocated_topology(self):"},{"line_number":26,"context_line":"        resource \u003d \u0027auto_allocated_topology\u0027"},{"line_number":27,"context_line":"        cmd \u003d aat.ShowAutoAllocatedTopology(test_cli20.MyApp(sys.stdout), None)"},{"line_number":28,"context_line":"        args \u003d [\u0027--tenant-id\u0027, self.test_id, self.test_id]"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_54899ac9","line":25,"in_reply_to":"5a5ae5dd_a8451318","updated":"2016-02-03 02:15:50.000000000","message":"I have decided to not provide a list command at this time.","commit_id":"b737caa76880d5a056a91c122c619c63a3a95e4b"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"352b04ae28884db33ffc95dc57771085d35393b1","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    flavor_profile_binding_path \u003d flavor_path + service_profile_path"},{"line_number":411,"context_line":"    availability_zones_path \u003d \"/availability_zones\""},{"line_number":412,"context_line":"    auto_allocated_topology_path \u003d \"/auto-allocated-topology/%s\""},{"line_number":413,"context_line":"    auto_allocated_topologies_path \u003d \"/auto-allocated-topology\""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":416,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_3f321bf3","line":413,"updated":"2016-02-05 16:31:47.000000000","message":"Since, we have only show functionality so IMO, L413 not required.","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"19db378f685064cb849b824fd97458d0d375b527","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    flavor_profile_binding_path \u003d flavor_path + service_profile_path"},{"line_number":411,"context_line":"    availability_zones_path \u003d \"/availability_zones\""},{"line_number":412,"context_line":"    auto_allocated_topology_path \u003d \"/auto-allocated-topology/%s\""},{"line_number":413,"context_line":"    auto_allocated_topologies_path \u003d \"/auto-allocated-topology\""},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":416,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_6efe9faf","line":413,"in_reply_to":"5a5ae5dd_3f321bf3","updated":"2016-02-05 18:20:25.000000000","message":"Done","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"352b04ae28884db33ffc95dc57771085d35393b1","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                     \u0027bandwidth_limit_rules\u0027: \u0027bandwidth_limit_rule\u0027,"},{"line_number":449,"context_line":"                     \u0027rule_types\u0027: \u0027rule_type\u0027,"},{"line_number":450,"context_line":"                     \u0027flavors\u0027: \u0027flavor\u0027,"},{"line_number":451,"context_line":"                     \u0027auto-allocated-topologies\u0027: \u0027auto-allocated-topology\u0027,"},{"line_number":452,"context_line":"                     }"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_7f6ad3b4","line":451,"updated":"2016-02-05 16:31:47.000000000","message":"do we really need this?","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"19db378f685064cb849b824fd97458d0d375b527","unresolved":false,"context_lines":[{"line_number":448,"context_line":"                     \u0027bandwidth_limit_rules\u0027: \u0027bandwidth_limit_rule\u0027,"},{"line_number":449,"context_line":"                     \u0027rule_types\u0027: \u0027rule_type\u0027,"},{"line_number":450,"context_line":"                     \u0027flavors\u0027: \u0027flavor\u0027,"},{"line_number":451,"context_line":"                     \u0027auto-allocated-topologies\u0027: \u0027auto-allocated-topology\u0027,"},{"line_number":452,"context_line":"                     }"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    @APIParamsCall"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_ee284f35","line":451,"in_reply_to":"5a5ae5dd_7f6ad3b4","updated":"2016-02-05 18:20:25.000000000","message":"Done","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"}],"releasenotes/notes/add-external-net-is-default-f21b1ba361fed47e.yaml":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"352b04ae28884db33ffc95dc57771085d35393b1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for specifying the default external network."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * The ``net-create`` and ``net-update`` commands accept the"},{"line_number":7,"context_line":"      ``--is-default`` boolean option for setting the default external"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5a5ae5dd_5f8b5768","line":4,"updated":"2016-02-05 16:31:47.000000000","message":"I think you forgot to change this file...\n* Implementation and content doesn\u0027t match.\n* Please generate a new release notes file using reno. [http://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes]","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"19db378f685064cb849b824fd97458d0d375b527","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for specifying the default external network."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * The ``net-create`` and ``net-update`` commands accept the"},{"line_number":7,"context_line":"      ``--is-default`` boolean option for setting the default external"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5a5ae5dd_0ed5ab1a","line":4,"in_reply_to":"5a5ae5dd_5f8b5768","updated":"2016-02-05 18:20:25.000000000","message":"Done","commit_id":"4f036eecff24f89c3c26301b622bf3f9bb2d32d8"}]}