)]}'
{"neutronclient/shell.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"d0b81db31dae0a2f3c9021ce89b873821cd83e47","unresolved":false,"context_lines":[{"line_number":894,"context_line":"        Make sure the user has provided all of the authentication"},{"line_number":895,"context_line":"        info we need."},{"line_number":896,"context_line":"        \"\"\""},{"line_number":897,"context_line":"        cloud_config \u003d os_client_config.OpenStackConfig().get_one_cloud("},{"line_number":898,"context_line":"            cloud\u003dself.options.os_cloud, argparse\u003dself.options,"},{"line_number":899,"context_line":"            network_api_version\u003dself.api_version)"},{"line_number":900,"context_line":"        verify, cert \u003d cloud_config.get_requests_verify_args()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_06d8701c","line":897,"range":{"start_line":897,"start_character":58,"end_line":897,"end_character":71},"updated":"2016-03-22 22:10:48.000000000","message":"Currently, it doesn\u0027t work because os_client_config looks for a \"verify\" argument in options but neutron defines \"insecure\" argument. IMO, it\u0027s better to define: \n\n  parser.add_argument(\n      \u0027--insecure\u0027,\n      dest\u003d\"verify\",      \n      action\u003d\u0027store_false\u0027,\n      default\u003dnot env(\u0027NEUTRONCLIENT_INSECURE\u0027, default\u003dFalse),)\n\nor do:\n\n cloud_config \u003d ...get_one_cloud(..., argparse\u003dself.options, verify\u003dnot self.options.insecure)\n\ninstead of correcting verify after get_requests_verify_args call as proposed currently.","commit_id":"f91a2ca6f481d4dc70525ba2f9f916006da6cbf4"},{"author":{"_account_id":13158,"name":"Zhongcheng Lao","email":"zlao@vmware.com","username":"zlao"},"change_message_id":"117497c83e4dd79cc577226e85dab0679d03f0a6","unresolved":false,"context_lines":[{"line_number":894,"context_line":"        Make sure the user has provided all of the authentication"},{"line_number":895,"context_line":"        info we need."},{"line_number":896,"context_line":"        \"\"\""},{"line_number":897,"context_line":"        cloud_config \u003d os_client_config.OpenStackConfig().get_one_cloud("},{"line_number":898,"context_line":"            cloud\u003dself.options.os_cloud, argparse\u003dself.options,"},{"line_number":899,"context_line":"            network_api_version\u003dself.api_version)"},{"line_number":900,"context_line":"        verify, cert \u003d cloud_config.get_requests_verify_args()"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa0719c6_736c82d0","line":897,"range":{"start_line":897,"start_character":58,"end_line":897,"end_character":71},"in_reply_to":"fa0719c6_06d8701c","updated":"2016-03-23 07:08:11.000000000","message":"Thanks for your advice.\nI prefer the latter one :-)","commit_id":"f91a2ca6f481d4dc70525ba2f9f916006da6cbf4"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"9c645195403b8497f0140ae9041b2604bac54473","unresolved":false,"context_lines":[{"line_number":931,"context_line":"            service_name\u003dcloud_config.get_service_name(\u0027network\u0027),"},{"line_number":932,"context_line":"            endpoint_type\u003dinterface,"},{"line_number":933,"context_line":"            auth\u003dauth,"},{"line_number":934,"context_line":"            insecure\u003dself.options.insecure,"},{"line_number":935,"context_line":"            log_credentials\u003dTrue)"},{"line_number":936,"context_line":"        return"},{"line_number":937,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da0c15f0_6b5f7be5","line":934,"updated":"2016-03-28 14:35:28.000000000","message":"should we use \"not verify\"?","commit_id":"519e1a92ce8d959b5430aa0465f04ffc4b378e91"},{"author":{"_account_id":13158,"name":"Zhongcheng Lao","email":"zlao@vmware.com","username":"zlao"},"change_message_id":"10965622b83682f0f42e34b733a94483ec3ab260","unresolved":false,"context_lines":[{"line_number":931,"context_line":"            service_name\u003dcloud_config.get_service_name(\u0027network\u0027),"},{"line_number":932,"context_line":"            endpoint_type\u003dinterface,"},{"line_number":933,"context_line":"            auth\u003dauth,"},{"line_number":934,"context_line":"            insecure\u003dself.options.insecure,"},{"line_number":935,"context_line":"            log_credentials\u003dTrue)"},{"line_number":936,"context_line":"        return"},{"line_number":937,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"ba0121b8_51ed618a","line":934,"in_reply_to":"da0c15f0_6b5f7be5","updated":"2016-03-29 03:19:01.000000000","message":"That\u0027s a better idea.\nIt seems that ClientManager prefers boolean value.\nverify may be set to a cacert in get_requests_verify_args.\nPassing verify to insecure may still work but it does not look pretty.\n\nI changed the line to use not bool(verify) to make sure insecure is either True or False.","commit_id":"519e1a92ce8d959b5430aa0465f04ffc4b378e91"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"61ac365879052ec9c5f1d4e626a6381a781840a6","unresolved":false,"context_lines":[{"line_number":947,"context_line":"            service_name\u003dcloud_config.get_service_name(\u0027network\u0027),"},{"line_number":948,"context_line":"            endpoint_type\u003dinterface,"},{"line_number":949,"context_line":"            auth\u003dauth,"},{"line_number":950,"context_line":"            insecure\u003dnot bool(verify),"},{"line_number":951,"context_line":"            log_credentials\u003dTrue)"},{"line_number":952,"context_line":"        return"},{"line_number":953,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_ad1bd57f","line":950,"updated":"2016-04-01 22:09:30.000000000","message":"\"not verify\" is equivalent","commit_id":"593a7ee50e1053d9371203673c499eccc75472c3"},{"author":{"_account_id":13158,"name":"Zhongcheng Lao","email":"zlao@vmware.com","username":"zlao"},"change_message_id":"62eb3b308dd821c8d88a6684c3aaa5e972d82588","unresolved":false,"context_lines":[{"line_number":947,"context_line":"            service_name\u003dcloud_config.get_service_name(\u0027network\u0027),"},{"line_number":948,"context_line":"            endpoint_type\u003dinterface,"},{"line_number":949,"context_line":"            auth\u003dauth,"},{"line_number":950,"context_line":"            insecure\u003dnot bool(verify),"},{"line_number":951,"context_line":"            log_credentials\u003dTrue)"},{"line_number":952,"context_line":"        return"},{"line_number":953,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_73407736","line":950,"in_reply_to":"ba0121b8_ad1bd57f","updated":"2016-04-02 02:09:22.000000000","message":"Done","commit_id":"593a7ee50e1053d9371203673c499eccc75472c3"}],"neutronclient/tests/unit/test_shell.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ace7772740bb20bbcab909933c23f05ebc634dbd","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def tearDown(self):"},{"line_number":73,"context_line":"        super(ShellTest, self).tearDown()"},{"line_number":74,"context_line":"        self.mox.UnsetStubs()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def shell(self, argstr, check\u003dFalse, expected_val\u003d0):"},{"line_number":77,"context_line":"        # expected_val is the expected return value after executing"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_b2270bc9","line":74,"updated":"2016-02-01 00:21:24.000000000","message":"Do you need this if the UnsetStubs is being called in _tesT_authenticate_user ?","commit_id":"2630ebe7fbbf760e087495fb187ff3a37a53e413"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ace7772740bb20bbcab909933c23f05ebc634dbd","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        self.mox.ReplayAll()"},{"line_number":298,"context_line":"        shell.authenticate_user()"},{"line_number":299,"context_line":"        self.mox.VerifyAll()"},{"line_number":300,"context_line":"        self.mox.UnsetStubs()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def test_authenticate_user(self):"},{"line_number":303,"context_line":"        self._test_authenticate_user(verify\u003dTrue, insecure\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_25019305","line":300,"updated":"2016-02-01 00:21:24.000000000","message":"Reference[1]:\n¨Note: If UnsetStubs() was called after Verify() and Verify() raises an exception because it fails then the rest of your tests may end up in a strange state. You should either call it before Verify() or -- even better -- call it in tearDown() which gets executed regardless of whether Verify() fails or succeeds. (If you use mox.MoxTestBase, this is taken care of for you.)¨\n\n\nYou are calling teardown with the UnsetStubs().\nAnd here you are calling UnsetStubs() once again, but after VerifyAll()\n\nSo , maybe you can either \na) Remove teardown, and put UnsetStubs() before VerifyAll()\nb) Remove UnsetStubs() here, and keep the teardown function\n\n[1]: https://code.google.com/p/pymox/wiki/MoxDocumentation","commit_id":"2630ebe7fbbf760e087495fb187ff3a37a53e413"},{"author":{"_account_id":13158,"name":"Zhongcheng Lao","email":"zlao@vmware.com","username":"zlao"},"change_message_id":"f5ddd3d2ee2b6bc1082fa8ba3fa2864219a363df","unresolved":false,"context_lines":[{"line_number":297,"context_line":"        self.mox.ReplayAll()"},{"line_number":298,"context_line":"        shell.authenticate_user()"},{"line_number":299,"context_line":"        self.mox.VerifyAll()"},{"line_number":300,"context_line":"        self.mox.UnsetStubs()"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"    def test_authenticate_user(self):"},{"line_number":303,"context_line":"        self._test_authenticate_user(verify\u003dTrue, insecure\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_c118acd5","line":300,"in_reply_to":"7a5de9d1_25019305","updated":"2016-02-01 08:15:30.000000000","message":"Thanks.\nI think I will do a) and keep the UnsetStubs in finally block just like what MoxMetaTestBase tries to do to make sure UnsetStubs gets called.","commit_id":"2630ebe7fbbf760e087495fb187ff3a37a53e413"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"61ac365879052ec9c5f1d4e626a6381a781840a6","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            shell.options \u003d {}"},{"line_number":249,"context_line":"            self.mox.StubOutWithMock(shell, \u0027options\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            for k, v in six.iteritems(options):"},{"line_number":252,"context_line":"                setattr(shell.options, k, v)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"            auth_session \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_bf29388c","line":251,"updated":"2016-04-01 22:09:30.000000000","message":"Please, avoid six.iteritems when is not needed (typically in this case it\u0027s not needed)","commit_id":"593a7ee50e1053d9371203673c499eccc75472c3"},{"author":{"_account_id":13158,"name":"Zhongcheng Lao","email":"zlao@vmware.com","username":"zlao"},"change_message_id":"62eb3b308dd821c8d88a6684c3aaa5e972d82588","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            shell.options \u003d {}"},{"line_number":249,"context_line":"            self.mox.StubOutWithMock(shell, \u0027options\u0027)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"            for k, v in six.iteritems(options):"},{"line_number":252,"context_line":"                setattr(shell.options, k, v)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"            auth_session \u003d None"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_d377c39d","line":251,"in_reply_to":"ba0121b8_bf29388c","updated":"2016-04-02 02:09:22.000000000","message":"Changed to use items() directly","commit_id":"593a7ee50e1053d9371203673c499eccc75472c3"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"61ac365879052ec9c5f1d4e626a6381a781840a6","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            self.mox.UnsetStubs()"},{"line_number":284,"context_line":"        self.mox.VerifyAll()"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_authenticate_user(self):"},{"line_number":287,"context_line":"        base_options \u003d {\u0027os_cloud\u0027: None,"},{"line_number":288,"context_line":"                        \u0027http_timeout\u0027: DEFAULT_TIMEOUT,"},{"line_number":289,"context_line":"                        \u0027region_name\u0027: DEFAULT_REGION,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_7fba000c","line":286,"updated":"2016-04-01 22:09:30.000000000","message":"a unittest should test one thing not 12 usecases","commit_id":"593a7ee50e1053d9371203673c499eccc75472c3"},{"author":{"_account_id":13158,"name":"Zhongcheng Lao","email":"zlao@vmware.com","username":"zlao"},"change_message_id":"62eb3b308dd821c8d88a6684c3aaa5e972d82588","unresolved":false,"context_lines":[{"line_number":283,"context_line":"            self.mox.UnsetStubs()"},{"line_number":284,"context_line":"        self.mox.VerifyAll()"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_authenticate_user(self):"},{"line_number":287,"context_line":"        base_options \u003d {\u0027os_cloud\u0027: None,"},{"line_number":288,"context_line":"                        \u0027http_timeout\u0027: DEFAULT_TIMEOUT,"},{"line_number":289,"context_line":"                        \u0027region_name\u0027: DEFAULT_REGION,"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba0121b8_f372c7af","line":286,"in_reply_to":"ba0121b8_7fba000c","updated":"2016-04-02 02:09:22.000000000","message":"Divided into 12 cases.","commit_id":"593a7ee50e1053d9371203673c499eccc75472c3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8e519821816b363eda0857be7cbc26da294c9673","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import fixtures"},{"line_number":23,"context_line":"from keystoneauth1 import session"},{"line_number":24,"context_line":"from mox3 import mox"},{"line_number":25,"context_line":"from mox3.mox import IgnoreArg"},{"line_number":26,"context_line":"import six"},{"line_number":27,"context_line":"import testtools"},{"line_number":28,"context_line":"from testtools import matchers"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_15520413","line":25,"updated":"2016-06-30 19:34:06.000000000","message":"nit: In OpenStack, we usually use a module-level import. This line is unnecessary.","commit_id":"ae736c62927f715b8c2eaaf5ceec294d9bc1717a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8e519821816b363eda0857be7cbc26da294c9673","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            auth_session \u003d None"},{"line_number":265,"context_line":"            auth \u003d None"},{"line_number":266,"context_line":"            if not (options.get(\u0027os_token\u0027) and options.get(\u0027os_url\u0027)):"},{"line_number":267,"context_line":"                auth \u003d IgnoreArg()"},{"line_number":268,"context_line":"                session.Session("},{"line_number":269,"context_line":"                    auth\u003dIgnoreArg(), verify\u003dexpect_verify,"},{"line_number":270,"context_line":"                    cert\u003doptions.get(\u0027cert\u0027),"}],"source_content_type":"text/x-python","patch_set":16,"id":"3aaa91ec_b56a10b1","line":267,"updated":"2016-06-30 19:34:06.000000000","message":"Per my comment at L.25, this will be:\n\n  mox.IgnoreArg()","commit_id":"ae736c62927f715b8c2eaaf5ceec294d9bc1717a"}]}
