)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"change_message_id":"105432aeb24ee47d39a3a3023fe936fef83a0b50","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix floatingip can\u0027t associate with port name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When associate a floating ip to a port, use port name will get error."},{"line_number":10,"context_line":"This patch will fix this problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I46342d92058751bfe76866eef3ab89ea47726f27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_33da21e9","line":9,"range":{"start_line":9,"start_character":5,"end_line":9,"end_character":14},"updated":"2016-02-01 15:37:00.000000000","message":"associating*","commit_id":"ba200883a643c013c1140db1faf0cf1ef70be900"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"691e05ea6ae4134f821f6efcf0e5440454039578","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix floatingip can\u0027t associate with port name"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When associating a floating ip to a port, use port name will get error."},{"line_number":10,"context_line":"This patch will fix this problem."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I46342d92058751bfe76866eef3ab89ea47726f27"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7af24918_b85ac24e","line":9,"range":{"start_line":9,"start_character":42,"end_line":9,"end_character":45},"updated":"2016-03-07 01:05:40.000000000","message":"use -\u003e using ?","commit_id":"ee25193a55c8c4b7c3271700e73714d9cc1dd770"}],"neutronclient/neutron/v2_0/floatingip.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"691e05ea6ae4134f821f6efcf0e5440454039578","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            \u0027floatingip_id\u0027, metavar\u003d\u0027FLOATINGIP_ID\u0027,"},{"line_number":99,"context_line":"            help\u003d_(\u0027ID of the floating IP to associate.\u0027))"},{"line_number":100,"context_line":"        parser.add_argument("},{"line_number":101,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027ID or name of the port to be associated with the \u0027"},{"line_number":103,"context_line":"                   \u0027floating IP.\u0027))"},{"line_number":104,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_d824eec7","line":101,"updated":"2016-03-07 01:05:40.000000000","message":"If we are going to use Port ID or Name, then ideally, this should not be \"port_id\" but just \"port\".\nThis is not completely related but should be modified in a future version or in OSC if possible.","commit_id":"ee25193a55c8c4b7c3271700e73714d9cc1dd770"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3e4671f0fa5da0d3ae5414d332efdeeda238311","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            help\u003d_(\u0027Description of the floating IP.\u0027))"},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--port-id\u0027,"},{"line_number":57,"context_line":"            help\u003d_(\u0027ID of the port to be associated with the floating IP.\u0027))"},{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027--port_id\u0027,"},{"line_number":60,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_85706475","line":57,"updated":"2016-05-01 10:31:39.000000000","message":"Name is not allowed over here?","commit_id":"7874d8e619975d4598404bc3749b2a2510521a31"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"161a934b00081ab43201598314a0c724cf0c9fa2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            help\u003d_(\u0027Description of the floating IP.\u0027))"},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--port-id\u0027,"},{"line_number":57,"context_line":"            help\u003d_(\u0027ID of the port to be associated with the floating IP.\u0027))"},{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027--port_id\u0027,"},{"line_number":60,"context_line":"            help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_d0c4f341","line":57,"in_reply_to":"1a122d0e_85706475","updated":"2016-09-04 18:27:02.000000000","message":"Agree. For consistency, it is better to accept port name here.","commit_id":"7874d8e619975d4598404bc3749b2a2510521a31"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3e4671f0fa5da0d3ae5414d332efdeeda238311","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \u0027floatingip_id\u0027, metavar\u003d\u0027FLOATINGIP_ID\u0027,"},{"line_number":107,"context_line":"            help\u003d_(\u0027ID of the floating IP to associate.\u0027))"},{"line_number":108,"context_line":"        parser.add_argument("},{"line_number":109,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":110,"context_line":"            help\u003d_(\u0027ID or name of the port to be associated with the \u0027"},{"line_number":111,"context_line":"                   \u0027floating IP.\u0027))"},{"line_number":112,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_e50798c7","line":109,"updated":"2016-05-01 10:31:39.000000000","message":"To me \u0027port_id\u0027 conveys the idea that only port_id can be accepted and not port_name. I would have loved to name it \u0027port\u0027 instead of \u0027port_id\u0027 but can\u0027t change now :(","commit_id":"7874d8e619975d4598404bc3749b2a2510521a31"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"161a934b00081ab43201598314a0c724cf0c9fa2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \u0027floatingip_id\u0027, metavar\u003d\u0027FLOATINGIP_ID\u0027,"},{"line_number":107,"context_line":"            help\u003d_(\u0027ID of the floating IP to associate.\u0027))"},{"line_number":108,"context_line":"        parser.add_argument("},{"line_number":109,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":110,"context_line":"            help\u003d_(\u0027ID or name of the port to be associated with the \u0027"},{"line_number":111,"context_line":"                   \u0027floating IP.\u0027))"},{"line_number":112,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_90ca6b4e","line":109,"in_reply_to":"1a122d0e_e50798c7","updated":"2016-09-04 18:27:02.000000000","message":"+1 to replace \u0027port_id\u0027 with \u0027port\u0027.","commit_id":"7874d8e619975d4598404bc3749b2a2510521a31"}],"neutronclient/tests/unit/test_cli20_floatingips.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"691e05ea6ae4134f821f6efcf0e5440454039578","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        resource \u003d \u0027floatingip\u0027"},{"line_number":184,"context_line":"        cmd \u003d fip.AssociateFloatingIP(test_cli20.MyApp(sys.stdout), None)"},{"line_number":185,"context_line":"        args \u003d [\u0027myid\u0027, \u0027portid\u0027]"},{"line_number":186,"context_line":"        self.assertRaises(exceptions.ConnectionFailed,"},{"line_number":187,"context_line":"                          self._test_update_resource,"},{"line_number":188,"context_line":"                          resource, cmd, \u0027myid\u0027, args, {\"port_id\": \u0027fake-name\u0027}"},{"line_number":189,"context_line":"                          )"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_983a66e6","line":186,"updated":"2016-03-07 01:05:40.000000000","message":"The test case looks better.\nHowever, I feel that if fake-name actually exists, then this test_Case should succeed.\nAnd if fake-name does not exist, then exceptions.NotFound should ideally be raised.\nCan you just test your CLI changes with a port-name where the port-name you passed\n\n - exists\n - doesnt exist\n\nAnd what output is it providing you?\nIMO, doesn\u0027t exist should raise NotFound exception with the latest branch","commit_id":"ee25193a55c8c4b7c3271700e73714d9cc1dd770"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"161a934b00081ab43201598314a0c724cf0c9fa2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        resource \u003d \u0027floatingip\u0027"},{"line_number":201,"context_line":"        name \u003d \u0027myname\u0027"},{"line_number":202,"context_line":"        cmd \u003d fip.AssociateFloatingIP(test_cli20.MyApp(sys.stdout), None)"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            _port_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":205,"context_line":"                self.client, \u0027port\u0027, name)"},{"line_number":206,"context_line":"            args \u003d [\u0027myid\u0027, _port_id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a89bdaa_30e27fd6","line":203,"range":{"start_line":203,"start_character":8,"end_line":203,"end_character":12},"updated":"2016-09-04 18:27:02.000000000","message":"In addition to Vikram\u0027s comment, it is not recommended to use try/except in test cases. You should use more specific way like assertRaises.","commit_id":"7874d8e619975d4598404bc3749b2a2510521a31"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"b3e4671f0fa5da0d3ae5414d332efdeeda238311","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        name \u003d \u0027myname\u0027"},{"line_number":202,"context_line":"        cmd \u003d fip.AssociateFloatingIP(test_cli20.MyApp(sys.stdout), None)"},{"line_number":203,"context_line":"        try:"},{"line_number":204,"context_line":"            _port_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":205,"context_line":"                self.client, \u0027port\u0027, name)"},{"line_number":206,"context_line":"            args \u003d [\u0027myid\u0027, _port_id]"},{"line_number":207,"context_line":"            self._test_update_resource(resource, cmd, \u0027myid\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_2512300a","line":204,"updated":"2016-05-01 10:31:39.000000000","message":"Where we are stubbing the call to find_resourceid_by_name_or_id ? What actually we are trying to achieve with this test-case.","commit_id":"7874d8e619975d4598404bc3749b2a2510521a31"}]}