)]}'
{"id":"openstack%2Fpython-neutronclient~275881","triplet_id":"openstack%2Fpython-neutronclient~master~I6dc9d0bad7b2a09db9810c1a624103e575bb2222","project":"openstack/python-neutronclient","branch":"master","topic":"snat","hashtags":[],"change_id":"I6dc9d0bad7b2a09db9810c1a624103e575bb2222","subject":"Generalize the disable-snat flag","status":"ABANDONED","created":"2016-02-03 18:45:53.000000000","updated":"2016-04-14 17:23:31.000000000","total_comment_count":7,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7953745847439092d3befc0772c80bfbefe1fcc3","_number":275881,"virtual_id_number":275881,"owner":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"date":"2016-04-14 17:23:31.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},{"date":"2016-02-04 04:30:58.000000000","_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"date":"2016-02-04 04:32:04.000000000","_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":-1,"date":"2016-02-04 05:20:57.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":-1,"date":"2016-02-05 00:29:44.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"value":0,"date":"2016-02-04 06:23:18.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":-1,"date":"2016-02-15 07:16:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-02-04 02:33:05.000000000","updated_by":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"reviewer":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"state":"REVIEWER"},{"updated":"2016-02-04 04:32:04.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-02-04 05:20:57.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-02-04 06:23:18.000000000","updated_by":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"reviewer":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"state":"REVIEWER"},{"updated":"2016-02-05 00:29:44.000000000","updated_by":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"reviewer":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"state":"REVIEWER"},{"updated":"2016-04-14 17:23:31.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"}],"messages":[{"id":"bccddd4e2acf95a785de1563200094120e606bca","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-02-03 18:45:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8683630abc43e3728f33e3badd3e8deb6c5ac94a","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-02-03 19:58:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"65776f4fef9353c6e0e1bfbc01b23b3bca83087c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-03 23:13:42.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/81/275881/2/check/gate-python-neutronclient-pep8/dda009b/ : SUCCESS in 1m 14s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/81/275881/2/check/gate-python-neutronclient-docs/cbd499c//doc/build/html/ : SUCCESS in 1m 07s\n- gate-python-neutronclient-python27 http://logs.openstack.org/81/275881/2/check/gate-python-neutronclient-python27/bb15a69/ : FAILURE in 1m 30s\n- gate-python-neutronclient-python34 http://logs.openstack.org/81/275881/2/check/gate-python-neutronclient-python34/0513f9a/ : FAILURE in 1m 41s\n- gate-python-neutronclient-pypy http://logs.openstack.org/81/275881/2/check/gate-python-neutronclient-pypy/59581ed/ : FAILURE in 1m 54s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/81/275881/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/a8df1c7/ : FAILURE in 22m 45s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/81/275881/2/check/gate-neutronclient-test-dsvm-functional/ce501b9/ : FAILURE in 24m 31s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/81/275881/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/f4f8d49/ : FAILURE in 24m 52s","accounts_in_message":[],"_revision_number":2},{"id":"1a06fb095685934f0b31d60558d5116305479c3e","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 00:18:38.000000000","message":"Patch Set 2: Code-Review-1\n\nyou are removing an option...\nIt should be first marked as deprecated,so users know that this option doesnt exist any more","accounts_in_message":[],"_revision_number":2},{"id":"a3a29053e8cbe4a2fcce63e67d271d0748710484","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2016-02-04 02:33:05.000000000","message":"Patch Set 2: Code-Review-1\n\nAs was already said, you can\u0027t remove a known option like this.  At best you could add an additional --snat\u003dTrue/False and possibly deprecate the old value.","accounts_in_message":[],"_revision_number":2},{"id":"20aa6adbdf3563ebcf0c329e4b2105e6f71cb05e","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-02-04 02:56:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"a5c0783cadb9b60bc38174c9a41e7ad1b437a700","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 03:02:43.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":3},{"id":"79de9a1d6534fcf10985ac7738420f9de256c1f9","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-02-04 03:05:04.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"7c400475b97439a9a553802c26cec75036fef915","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 03:09:30.000000000","message":"Patch Set 4: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":4},{"id":"f146fefbe6bc00024cdfa4a7eedfd61f1d4825f4","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-02-04 03:12:18.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ca6b74dbca6f377e3b277fc8f21fc8abc701add7","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-02-04 03:18:39.000000000","message":"Patch Set 5:\n\nReedip, I was hoping there will be a deprecation flag in utils that will take care of mutual exclusion. But there is none. Do you think we should have a if else check to see if both are passed?","accounts_in_message":[],"_revision_number":5},{"id":"4d6cd1d9c7651a6bf95bccee5c9d497bc5711cc0","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 03:20:24.000000000","message":"Patch Set 6: Published edit on patch set 5","accounts_in_message":[],"_revision_number":6},{"id":"92296deddf21501e744591dbe852ddfb84b1ba09","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 03:20:58.000000000","message":"Patch Set 6: Code-Review+1\n\npep8 issue would have occurred, updated PS to fix it","accounts_in_message":[],"_revision_number":6},{"id":"0cbc8fffb24d3d991c3d978ca679ba020904658d","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 03:21:54.000000000","message":"Patch Set 6:\n\nWould prefer you add a test case for snat \u003d True as well , if you get comments to provide another Patch Set.","accounts_in_message":[],"_revision_number":6},{"id":"1cf6a626119df2b4c94a7beae57808c02f627cc8","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 03:32:07.000000000","message":"Patch Set 6:\n\nHi Abhishek, \nThe problem here is that parsed_args.snat will either have True or False.\nThe parsed_args.disable_snat can have either None, or True.\n\nso if the user has passed disable_snat( checked by getattr( parsed_args,\"disable_snat\")), then you can avoid the value of parsed_args.snat, for this release. You can keep a ToDo there , which can be referenced and worked upon in the future release.","accounts_in_message":[],"_revision_number":6},{"id":"9c948de8347dcd7a84ac849bb2ab1f60ca2d0967","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-02-04 04:06:23.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"d751b2ab4dfb1c7a5ffa329cd3a144541fa63b5e","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-02-04 04:28:35.000000000","message":"Patch Set 7: Code-Review-1\n\nWhy we need this flag to enable/disable snat option?we have --disable-snat to set snat is Ture or False already","accounts_in_message":[],"_revision_number":7},{"id":"aa7086d0175922988eef1e382c29548add5f00cd","author":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"date":"2016-02-04 04:30:58.000000000","message":"Patch Set 7:\n\ndisable-snat can\u0027t be used to re-enable SNAT, it does not accept a parameter. Consider this:\n1. Set a gateway on a router, SNAT is enabled by default\n2. Disable SNAT\nAt this point, how do I enable it again?","accounts_in_message":[],"_revision_number":7},{"id":"1d610f7b5b462c9212e9fea941676abae09448aa","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 04:32:04.000000000","message":"Patch Set 7:\n\nHi Jacky, IMHO, the --disable-snat flag is a bit cumbersome, because it implicitly assumes that if one user does not provide snat, it should be defaulted to True.\n\nIMO, if a user does not change the snat flag, the current value of snat should not be modified on the neutron server.\nI discussed something like this with you in https://review.openstack.org/#/c/269402/10 , and am more inclined to an --snat flag than a --disable-snat flag.","accounts_in_message":[],"_revision_number":7},{"id":"74c256f6d25364aa9db17fb660db6d4b176ce6e8","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-04 04:32:43.000000000","message":"Patch Set 7:\n\n@Abhishek, \nJust dont pass the --disable-snat flag , it will renable the snat!","accounts_in_message":[],"_revision_number":7},{"id":"9716d98b8fefd742160535adecf77076fd11a9f1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-02-04 05:20:57.000000000","message":"Patch Set 7: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/81/275881/7/check/gate-python-neutronclient-pep8/eafc81e/ : FAILURE in 1m 12s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/81/275881/7/check/gate-python-neutronclient-docs/7b487a4//doc/build/html/ : SUCCESS in 1m 05s\n- gate-python-neutronclient-python27 http://logs.openstack.org/81/275881/7/check/gate-python-neutronclient-python27/3caef22/ : FAILURE in 1m 47s\n- gate-python-neutronclient-python34 http://logs.openstack.org/81/275881/7/check/gate-python-neutronclient-python34/d4c763a/ : FAILURE in 1m 55s\n- gate-python-neutronclient-pypy http://logs.openstack.org/81/275881/7/check/gate-python-neutronclient-pypy/58f5d4e/ : FAILURE in 2m 09s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/81/275881/7/check/gate-tempest-dsvm-neutron-src-python-neutronclient/c72ec10/ : SUCCESS in 1h 00m 31s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/81/275881/7/check/gate-neutronclient-test-dsvm-functional/e950ce0/ : SUCCESS in 26m 57s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/81/275881/7/check/gate-neutronclient-test-dsvm-functional-adv-svcs/32db7ed/ : SUCCESS in 29m 23s","accounts_in_message":[],"_revision_number":7},{"id":"5593a8248baf5ad4ddd2de086d6dc4556f9652b0","author":{"_account_id":19226,"name":"Jacky_lei_zhang","email":"shleiz@cn.ibm.com","username":"lzhang"},"date":"2016-02-04 06:23:18.000000000","message":"Patch Set 7: -Code-Review\n\n\u003e Hi Jacky, IMHO, the --disable-snat flag is a bit cumbersome,\n \u003e because it implicitly assumes that if one user does not provide\n \u003e snat, it should be defaulted to True.\n \u003e \n \u003e IMO, if a user does not change the snat flag, the current value of\n \u003e snat should not be modified on the neutron server.\n \u003e I discussed something like this with you in https://review.openstack.org/#/c/269402/10\n \u003e , and am more inclined to an --snat flag than a --disable-snat\n \u003e flag.\n\n \u003e Hi Jacky, IMHO, the --disable-snat flag is a bit cumbersome,\n \u003e because it implicitly assumes that if one user does not provide\n \u003e snat, it should be defaulted to True.\n \u003e \n \u003e IMO, if a user does not change the snat flag, the current value of\n \u003e snat should not be modified on the neutron server.\n \u003e I discussed something like this with you in https://review.openstack.org/#/c/269402/10\n \u003e , and am more inclined to an --snat flag than a --disable-snat\n \u003e flag.\n\nOK,I think you are right  :)","accounts_in_message":[],"_revision_number":7},{"id":"0a546ac2355b2a383c94050d5b8b477b9d9b1fe8","author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"date":"2016-02-05 00:29:44.000000000","message":"Patch Set 7: Code-Review-1\n\n(1 comment)\n\nThis change deserves UT","accounts_in_message":[],"_revision_number":7},{"id":"ab438f4248bc691c6e9639d7b32f7b3bc975b546","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-02-15 07:16:38.000000000","message":"Patch Set 7: Code-Review-1\n\nAgree with Cedric for the UT","accounts_in_message":[],"_revision_number":7},{"id":"f50871e80916a9a102c22f6b129f84cea6dc1a3f","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-04-14 17:23:31.000000000","message":"Patch Set 7:\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":7},{"id":"b7bae8ea68fdbb22d3e1bd648c54e41ad253b3d5","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-04-14 17:23:31.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":7}],"current_revision_number":7,"current_revision":"525db14402667978f627f479c1086f4f33e6a984","revisions":{"d5565cd9a76d3736d547bcbd4d95a84c59829772":{"kind":"REWORK","_number":1,"created":"2016-02-03 18:45:53.000000000","uploader":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"ref":"refs/changes/81/275881/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/275881/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/1"}}},"commit":{"parents":[{"commit":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","subject":"Update translation setup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"}]}],"author":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-03 18:45:17.000000000","tz":-480},"committer":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-03 18:45:17.000000000","tz":-480},"subject":"Generalize the disable-snat flag","message":"Generalize the disable-snat flag\n\nThis changes the flag to enable or disable SNAT on an external\ngateway\n\nChange-Id: I6dc9d0bad7b2a09db9810c1a624103e575bb2222\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d5565cd9a76d3736d547bcbd4d95a84c59829772"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d5565cd9a76d3736d547bcbd4d95a84c59829772"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","is_merged_in_target_branch":true,"change_id":"I888808f8af291223531df799382ad0c70bf8c567","change_number":273378,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"b3ff0169aca45c0b4d43d1b6c06ff6e9fb4dbd68":{"kind":"REWORK","_number":2,"created":"2016-02-03 19:58:52.000000000","uploader":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"ref":"refs/changes/81/275881/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/275881/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/2"}}},"commit":{"parents":[{"commit":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","subject":"Update translation setup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"}]}],"author":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-03 18:45:17.000000000","tz":-480},"committer":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-03 19:58:35.000000000","tz":-480},"subject":"Generalize the disable-snat flag","message":"Generalize the disable-snat flag\n\nThis changes the flag to enable or disable SNAT on an external\ngateway\n\nChange-Id: I6dc9d0bad7b2a09db9810c1a624103e575bb2222\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/b3ff0169aca45c0b4d43d1b6c06ff6e9fb4dbd68"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/b3ff0169aca45c0b4d43d1b6c06ff6e9fb4dbd68"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","is_merged_in_target_branch":true,"change_id":"I888808f8af291223531df799382ad0c70bf8c567","change_number":273378,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"14bebbee39d5f8dcdebdb2c28b8ec1a599f50b9b":{"kind":"REWORK","_number":3,"created":"2016-02-04 02:56:43.000000000","uploader":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"ref":"refs/changes/81/275881/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/275881/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/3"}}},"commit":{"parents":[{"commit":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","subject":"Update translation setup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"}]}],"author":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-03 18:45:17.000000000","tz":-480},"committer":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-04 02:56:33.000000000","tz":-480},"subject":"Generalize the disable-snat flag","message":"Generalize the disable-snat flag\n\nThis changes the flag to enable or disable SNAT on an external\ngateway\n\nChange-Id: I6dc9d0bad7b2a09db9810c1a624103e575bb2222\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/14bebbee39d5f8dcdebdb2c28b8ec1a599f50b9b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/14bebbee39d5f8dcdebdb2c28b8ec1a599f50b9b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","is_merged_in_target_branch":true,"change_id":"I888808f8af291223531df799382ad0c70bf8c567","change_number":273378,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"77a4bf0e6e5e89a0940f6f9792c063b713f6b8a2":{"kind":"REWORK","_number":4,"created":"2016-02-04 03:05:04.000000000","uploader":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"ref":"refs/changes/81/275881/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/275881/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/4"}}},"commit":{"parents":[{"commit":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","subject":"Update translation setup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"}]}],"author":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-03 18:45:17.000000000","tz":-480},"committer":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-04 03:04:57.000000000","tz":-480},"subject":"Generalize the disable-snat flag","message":"Generalize the disable-snat flag\n\nThis changes the flag to enable or disable SNAT on an external\ngateway\n\nChange-Id: I6dc9d0bad7b2a09db9810c1a624103e575bb2222\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/77a4bf0e6e5e89a0940f6f9792c063b713f6b8a2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/77a4bf0e6e5e89a0940f6f9792c063b713f6b8a2"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","is_merged_in_target_branch":true,"change_id":"I888808f8af291223531df799382ad0c70bf8c567","change_number":273378,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"d1dbac2bd30468019ff93864b3273d2723522641":{"kind":"REWORK","_number":5,"created":"2016-02-04 03:12:18.000000000","uploader":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"ref":"refs/changes/81/275881/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/275881/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/5"}}},"commit":{"parents":[{"commit":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","subject":"Update translation setup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"}]}],"author":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-03 18:45:17.000000000","tz":-480},"committer":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-04 03:12:09.000000000","tz":-480},"subject":"Generalize the disable-snat flag","message":"Generalize the disable-snat flag\n\nThis changes the flag to enable or disable SNAT on an external\ngateway\n\nChange-Id: I6dc9d0bad7b2a09db9810c1a624103e575bb2222\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d1dbac2bd30468019ff93864b3273d2723522641"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d1dbac2bd30468019ff93864b3273d2723522641"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","is_merged_in_target_branch":true,"change_id":"I888808f8af291223531df799382ad0c70bf8c567","change_number":273378,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"c91228ce48af081822981ed2bcb69e693c6c0d98":{"kind":"REWORK","_number":6,"created":"2016-02-04 03:20:24.000000000","uploader":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"ref":"refs/changes/81/275881/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/275881/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/6"}}},"commit":{"parents":[{"commit":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","subject":"Update translation setup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"}]}],"author":{"name":"abhishek.becs@gmail.com","email":"abhishek.chanda@emc.com","date":"2016-02-03 18:45:17.000000000","tz":-480},"committer":{"name":"Reedip","email":"reedip.banerjee@nectechnologies.in","date":"2016-02-04 03:20:22.000000000","tz":0},"subject":"Generalize the disable-snat flag","message":"Generalize the disable-snat flag\n\nThis changes the flag to enable or disable SNAT on an external\ngateway\n\nChange-Id: I6dc9d0bad7b2a09db9810c1a624103e575bb2222\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/c91228ce48af081822981ed2bcb69e693c6c0d98"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/c91228ce48af081822981ed2bcb69e693c6c0d98"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","is_merged_in_target_branch":true,"change_id":"I888808f8af291223531df799382ad0c70bf8c567","change_number":273378,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"},"525db14402667978f627f479c1086f4f33e6a984":{"kind":"REWORK","_number":7,"created":"2016-02-04 04:06:23.000000000","uploader":{"_account_id":7770,"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","username":"abhishek"},"ref":"refs/changes/81/275881/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/81/275881/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/81/275881/7"}}},"commit":{"parents":[{"commit":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","subject":"Update translation setup","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d"}]}],"author":{"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","date":"2016-02-03 18:45:17.000000000","tz":-480},"committer":{"name":"Abhishek Chanda","email":"abhishek.becs@gmail.com","date":"2016-02-04 04:06:08.000000000","tz":-480},"subject":"Generalize the disable-snat flag","message":"Generalize the disable-snat flag\n\nThis changes the flag to enable or disable SNAT on an external\ngateway\n\nChange-Id: I6dc9d0bad7b2a09db9810c1a624103e575bb2222\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/525db14402667978f627f479c1086f4f33e6a984"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/525db14402667978f627f479c1086f4f33e6a984"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9f792d0b9c6ed86cea0f7efaf65817ff32e5d72d","is_merged_in_target_branch":true,"change_id":"I888808f8af291223531df799382ad0c70bf8c567","change_number":273378,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}