)]}'
{"neutronclient/neutron/v2_0/network.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"135666dc3533497ccb3e4d550847bd7dce8e27c6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return \u0027\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _add_external_args(parser):"},{"line_number":37,"context_line":"    utils.add_boolean_argument("},{"line_number":38,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":39,"context_line":"        help\u003d_(\u0027Specify if this network should be used as\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_7882e253","line":36,"updated":"2016-04-05 08:58:10.000000000","message":"could you make the name more specific so it\u0027d be obvious to the reader?\n\ndoes _add_external_net_args (for example), sound reasonable?","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"75cf5f5056532e7ab28ef529f5071d050665d543","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        return \u0027\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _add_external_args(parser):"},{"line_number":37,"context_line":"    utils.add_boolean_argument("},{"line_number":38,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":39,"context_line":"        help\u003d_(\u0027Specify if this network should be used as\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_ec51dcd9","line":36,"in_reply_to":"9a061dce_7882e253","updated":"2016-04-06 07:22:05.000000000","message":"Yes, has a better ring to it..","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f90be41b4cc4c09b858276026c9a0f03c625a15","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _add_external_args(parser):"},{"line_number":37,"context_line":"    utils.add_boolean_argument("},{"line_number":38,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":39,"context_line":"        help\u003d_(\u0027Specify if this network should be used as\u0027"},{"line_number":40,"context_line":"               \u0027the default external network.\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_f6b52b31","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":31},"updated":"2016-04-06 07:06:20.000000000","message":"This is a headache.\n\nWe shipped Mitaka version of neutornclient 4.2.x.\nIn 4.2.x we can use\n\n  neutron net-create external --router:external --is-default\n\nbut this change prevents it....","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"358a2bf706313b1bfbb6b2be09137ede826e2f70","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _add_external_args(parser):"},{"line_number":37,"context_line":"    utils.add_boolean_argument("},{"line_number":38,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":39,"context_line":"        help\u003d_(\u0027Specify if this network should be used as\u0027"},{"line_number":40,"context_line":"               \u0027the default external network.\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_ef1c2ec3","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":31},"in_reply_to":"9a061dce_2c863465","updated":"2016-04-06 07:56:47.000000000","message":"How does this change prevent it?, I\u0027m missing something. (/me reads the linked patch).","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9d6e5e6c7ce91ba910261e8630320d182d99ed4e","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _add_external_args(parser):"},{"line_number":37,"context_line":"    utils.add_boolean_argument("},{"line_number":38,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":39,"context_line":"        help\u003d_(\u0027Specify if this network should be used as\u0027"},{"line_number":40,"context_line":"               \u0027the default external network.\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_cad2f8ff","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":31},"in_reply_to":"9a061dce_ef1c2ec3","updated":"2016-04-06 08:13:06.000000000","message":"Hi Miguel, \nThe linked patch consists of those options which are handled as extra arguments and have a wider possible input values\n( example: --router:external, --router:external\u003dTrue, --router:external True).\nSame is the case with --is-default now...","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"75cf5f5056532e7ab28ef529f5071d050665d543","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _add_external_args(parser):"},{"line_number":37,"context_line":"    utils.add_boolean_argument("},{"line_number":38,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":39,"context_line":"        help\u003d_(\u0027Specify if this network should be used as\u0027"},{"line_number":40,"context_line":"               \u0027the default external network.\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_2c863465","line":37,"range":{"start_line":37,"start_character":4,"end_line":37,"end_character":31},"in_reply_to":"9a061dce_f6b52b31","updated":"2016-04-06 07:22:05.000000000","message":"Mitaka 4.2.x also allows --is-default:True as --is-default is an extra argument.\nThis was exactly the reason why I created this patch in Mataka itself when Henry\u0027s patch was at works, to avoid the headache in the upcoming releases, but it failed to get the attention of reviewers I guess!\nNow adding --is-default would not be beneficial. I will handle it separately in the discussion https://review.openstack.org/#/c/137279/","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f90be41b4cc4c09b858276026c9a0f03c625a15","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":39,"context_line":"        help\u003d_(\u0027Specify if this network should be used as\u0027"},{"line_number":40,"context_line":"               \u0027the default external network.\u0027"},{"line_number":41,"context_line":"               \u0027(True sets it as the default external network).\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def parse_common_args(parsed_args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_a2a09244","line":41,"range":{"start_line":41,"start_character":17,"end_line":41,"end_character":61},"updated":"2016-04-06 07:06:20.000000000","message":"How about \"True means the default external network\".","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"75cf5f5056532e7ab28ef529f5071d050665d543","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        parser, \u0027--is-default\u0027,"},{"line_number":39,"context_line":"        help\u003d_(\u0027Specify if this network should be used as\u0027"},{"line_number":40,"context_line":"               \u0027the default external network.\u0027"},{"line_number":41,"context_line":"               \u0027(True sets it as the default external network).\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def parse_common_args(parsed_args):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_8ca6600e","line":41,"range":{"start_line":41,"start_character":17,"end_line":41,"end_character":61},"in_reply_to":"9a061dce_a2a09244","updated":"2016-04-06 07:22:05.000000000","message":"I think this help message also portrays the same meaning","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"135666dc3533497ccb3e4d550847bd7dce8e27c6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               \u0027(True sets it as the default external network).\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def parse_common_args(parsed_args):"},{"line_number":45,"context_line":"    body \u003d {}"},{"line_number":46,"context_line":"    neutronV20.update_dict(parsed_args, body,"},{"line_number":47,"context_line":"                           [\u0027name\u0027, \u0027is_default\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_98cff6af","line":44,"updated":"2016-04-05 08:58:10.000000000","message":"this does not seem to \"parse\" any args, just put them on a dictionary from an already parsed result.\n\nsuggestion for function name: args2body_common (to follow the other args2body pattern)","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f90be41b4cc4c09b858276026c9a0f03c625a15","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               \u0027(True sets it as the default external network).\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def parse_common_args(parsed_args):"},{"line_number":45,"context_line":"    body \u003d {}"},{"line_number":46,"context_line":"    neutronV20.update_dict(parsed_args, body,"},{"line_number":47,"context_line":"                           [\u0027name\u0027, \u0027is_default\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_e2b1ea90","line":44,"in_reply_to":"9a061dce_98cff6af","updated":"2016-04-06 07:06:20.000000000","message":"+1\n\nIn addition, as I commented in other reviews, please pass body as an argument. we don\u0027t want to care the order of calling various args2body related methods.","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"75cf5f5056532e7ab28ef529f5071d050665d543","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               \u0027(True sets it as the default external network).\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def parse_common_args(parsed_args):"},{"line_number":45,"context_line":"    body \u003d {}"},{"line_number":46,"context_line":"    neutronV20.update_dict(parsed_args, body,"},{"line_number":47,"context_line":"                           [\u0027name\u0027, \u0027is_default\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_ecb55c31","line":44,"in_reply_to":"9a061dce_e2b1ea90","updated":"2016-04-06 07:22:05.000000000","message":"Ok, I will rename the function and pass Body as an argument","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"358a2bf706313b1bfbb6b2be09137ede826e2f70","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               \u0027(True sets it as the default external network).\u0027))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"def parse_common_args(parsed_args):"},{"line_number":45,"context_line":"    body \u003d {}"},{"line_number":46,"context_line":"    neutronV20.update_dict(parsed_args, body,"},{"line_number":47,"context_line":"                           [\u0027name\u0027, \u0027is_default\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_8f0db292","line":44,"in_reply_to":"9a061dce_ecb55c31","updated":"2016-04-06 07:56:47.000000000","message":"+1 to passing body, makes sense.","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f90be41b4cc4c09b858276026c9a0f03c625a15","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def parse_common_args(parsed_args):"},{"line_number":45,"context_line":"    body \u003d {}"},{"line_number":46,"context_line":"    neutronV20.update_dict(parsed_args, body,"},{"line_number":47,"context_line":"                           [\u0027name\u0027, \u0027is_default\u0027,"},{"line_number":48,"context_line":"                            \u0027description\u0027])"},{"line_number":49,"context_line":"    return body"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_7680fb46","line":47,"range":{"start_line":47,"start_character":48,"end_line":47,"end_character":49},"updated":"2016-04-06 07:06:20.000000000","message":"No need to wrap lines.","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"75cf5f5056532e7ab28ef529f5071d050665d543","unresolved":false,"context_lines":[{"line_number":44,"context_line":"def parse_common_args(parsed_args):"},{"line_number":45,"context_line":"    body \u003d {}"},{"line_number":46,"context_line":"    neutronV20.update_dict(parsed_args, body,"},{"line_number":47,"context_line":"                           [\u0027name\u0027, \u0027is_default\u0027,"},{"line_number":48,"context_line":"                            \u0027description\u0027])"},{"line_number":49,"context_line":"    return body"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_4c83a856","line":47,"range":{"start_line":47,"start_character":48,"end_line":47,"end_character":49},"in_reply_to":"9a061dce_7680fb46","updated":"2016-04-06 07:22:05.000000000","message":"Sure","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"575f87a50e1314ff2259389f6e8cc0a753901546","unresolved":false,"context_lines":[{"line_number":227,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":228,"context_line":"        parser.add_argument("},{"line_number":229,"context_line":"            \u0027--name\u0027,"},{"line_number":230,"context_line":"            help\u003d_(\u0027Updated name of the network.\u0027))"},{"line_number":231,"context_line":"        parser.add_argument("},{"line_number":232,"context_line":"            \u0027--description\u0027,"},{"line_number":233,"context_line":"            help\u003d_(\u0027Description of this network.\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"3aaa91ec_fc5b8352","line":230,"range":{"start_line":230,"start_character":20,"end_line":230,"end_character":48},"updated":"2016-06-22 12:18:26.000000000","message":"IMO , \"Name of the network\" looks more readable , It can\u0027t be updated name, since help message to refer before update operation","commit_id":"fc9b9abc635b782bea40bdfe0fab85ee06483f5f"}],"neutronclient/tests/unit/test_cli20_network.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"135666dc3533497ccb3e4d550847bd7dce8e27c6","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def test_create_network_with_dns_domain(self):"},{"line_number":180,"context_line":"        # Create net: --dns-domain my-domain.org."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        resource \u003d \u0027network\u0027"},{"line_number":183,"context_line":"        cmd \u003d network.CreateNetwork(test_cli20.MyApp(sys.stdout), None)"},{"line_number":184,"context_line":"        name \u003d \u0027myname\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_98b096f6","line":181,"updated":"2016-04-05 08:58:10.000000000","message":"unrelated","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2f90be41b4cc4c09b858276026c9a0f03c625a15","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                                   {\u0027name\u0027: \u0027myname\u0027, \u0027tags\u0027: [\u0027a\u0027, \u0027b\u0027],"},{"line_number":555,"context_line":"                                    \u0027description\u0027: \u0027This network takes the \u0027"},{"line_number":556,"context_line":"                                                   \u0027scenic route\u0027})"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        # Update net: myid --is-default \u003cTrue|False\u003e"},{"line_number":559,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"},{"line_number":560,"context_line":"                                   [\u0027myid\u0027, \u0027--is-default\u0027, \u0027True\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_79874cd7","line":557,"updated":"2016-04-06 07:06:20.000000000","message":"Could you add new tests as separate tests?\nIt is not a good idea to test many in one test.","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"358a2bf706313b1bfbb6b2be09137ede826e2f70","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                                   {\u0027name\u0027: \u0027myname\u0027, \u0027tags\u0027: [\u0027a\u0027, \u0027b\u0027],"},{"line_number":555,"context_line":"                                    \u0027description\u0027: \u0027This network takes the \u0027"},{"line_number":556,"context_line":"                                                   \u0027scenic route\u0027})"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        # Update net: myid --is-default \u003cTrue|False\u003e"},{"line_number":559,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"},{"line_number":560,"context_line":"                                   [\u0027myid\u0027, \u0027--is-default\u0027, \u0027True\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_4fc8ba22","line":557,"in_reply_to":"9a061dce_79874cd7","updated":"2016-04-06 07:56:47.000000000","message":"+1 I didn\u0027t notice this wasn\u0027t a separate test function.","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"135666dc3533497ccb3e4d550847bd7dce8e27c6","unresolved":false,"context_lines":[{"line_number":555,"context_line":"                                    \u0027description\u0027: \u0027This network takes the \u0027"},{"line_number":556,"context_line":"                                                   \u0027scenic route\u0027})"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        # Update net: myid --is-default \u003cTrue|False\u003e"},{"line_number":559,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"},{"line_number":560,"context_line":"                                   [\u0027myid\u0027, \u0027--is-default\u0027, \u0027True\u0027],"},{"line_number":561,"context_line":"                                   {\u0027is_default\u0027: \"True\"}"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a061dce_18abe675","line":558,"range":{"start_line":558,"start_character":32,"end_line":558,"end_character":39},"updated":"2016-04-05 08:58:10.000000000","message":"nit:you could save a few lines by:\n\n  for is_default in [True, False]:\n    ....","commit_id":"6297e3241e7277e0c15332a4a01a1408eb37b1c7"}]}