)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"27b1b8b281ac383b688f51d2e086ee4ea9d94e3d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1335640"},{"line_number":22,"context_line":"Change-Id: Ic11796889075b2a0e589b70398fc4d4ed6f3ef7c"},{"line_number":23,"context_line":"Depends-On: I7b11e6264bebeae3665ed195539e10e837ced1d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab17558_fa314b5b","line":23,"updated":"2016-05-10 20:54:59.000000000","message":"is this the right dependency? I am befuddled","commit_id":"b5ace3e528f8e55b8ae5e1678d26d58d7e23937b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"75c665fda7f669365a6d1bf0d46346246682e50d","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #1335640"},{"line_number":22,"context_line":"Change-Id: Ic11796889075b2a0e589b70398fc4d4ed6f3ef7c"},{"line_number":23,"context_line":"Depends-On: I7b11e6264bebeae3665ed195539e10e837ced1d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dab17558_85c38088","line":23,"in_reply_to":"dab17558_fa314b5b","updated":"2016-05-10 21:11:03.000000000","message":"No, it is not... it is there only until the devstack-gate change merges...","commit_id":"b5ace3e528f8e55b8ae5e1678d26d58d7e23937b"}],"neutronclient/client.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e12c0f7e2f0229f3beb3002032bc605e6e0b1b46","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutronclient.common import exceptions"},{"line_number":31,"context_line":"from neutronclient.common import utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"osprofiler_web \u003d importutils.try_import(\"osprofiler.web\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_logger \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_733c5893","line":33,"updated":"2016-05-17 06:11:13.000000000","message":"Can we change this to uppercase?","commit_id":"fb570970746e5d22891a33c16ab7a43fa0d397ab"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a3a2ac06ae53b88c7108c83b11aa3cd842582a5b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutronclient.common import exceptions"},{"line_number":31,"context_line":"from neutronclient.common import utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"osprofiler_web \u003d importutils.try_import(\"osprofiler.web\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_logger \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_e8222ca2","line":33,"in_reply_to":"bab6814e_e04bee29","updated":"2016-05-20 17:54:25.000000000","message":"it\u0027s a module, not a constant.","commit_id":"fb570970746e5d22891a33c16ab7a43fa0d397ab"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"4b8ff35452fa746d49317323cf170b8ab88e99bb","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutronclient.common import exceptions"},{"line_number":31,"context_line":"from neutronclient.common import utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"osprofiler_web \u003d importutils.try_import(\"osprofiler.web\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_logger \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_6e014f6a","line":33,"in_reply_to":"bab6814e_e8222ca2","updated":"2016-05-31 10:37:58.000000000","message":"agree with Armando - it\u0027s not a constant, so I see no reason for uppercasing here.","commit_id":"fb570970746e5d22891a33c16ab7a43fa0d397ab"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"ac4d8aa6711a0f77b1b265941f2ac4bf7bf022b9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutronclient.common import exceptions"},{"line_number":31,"context_line":"from neutronclient.common import utils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"osprofiler_web \u003d importutils.try_import(\"osprofiler.web\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"_logger \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_e04bee29","line":33,"in_reply_to":"dab17558_733c5893","updated":"2016-05-18 14:10:04.000000000","message":"garyk, what are you wanting to uppercase - I\u0027m unclear","commit_id":"fb570970746e5d22891a33c16ab7a43fa0d397ab"}],"neutronclient/shell.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f7f460d2a7417f1938ec724c6954d0a172772c26","unresolved":false,"context_lines":[{"line_number":828,"context_line":"            _argv \u003d [sys.argv[0]]"},{"line_number":829,"context_line":"            sys.argv \u003d _argv"},{"line_number":830,"context_line":"            return self.interact()"},{"line_number":831,"context_line":"        return self.run_subcommand(remainder), profile"},{"line_number":832,"context_line":""},{"line_number":833,"context_line":"    def run_subcommand(self, argv):"},{"line_number":834,"context_line":"        subcommand \u003d self.command_manager.find_command(argv)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_1497c3ec","line":831,"updated":"2016-05-10 22:26:30.000000000","message":"The probes and neutron-debug is a red herring and there\u0027s nothing wrong with them. The nature of neutron-debug (as a server side block that builds a superset of the client) ends up being screwed because profile here will be None.\n\nIn reality you\u0027re breaking the contract of this API returning a tuple. We should try and figure out some other mechanism. Preserving the return value when profile is None would suffice getting past the tests but I doubt this is the right path forward.","commit_id":"1efb8db61cd0549254407cbbd40889172f23a999"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a70161a5e95c2ea76bd9d6227ba1df55938c1be6","unresolved":false,"context_lines":[{"line_number":939,"context_line":""},{"line_number":940,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":941,"context_line":"    try:"},{"line_number":942,"context_line":"        shell \u003d NeutronShell(NEUTRON_API_VERSION)"},{"line_number":943,"context_line":"        res \u003d shell.run(list(map(encodeutils.safe_decode, argv)))"},{"line_number":944,"context_line":"        if shell.profile:"},{"line_number":945,"context_line":"            trace_id \u003d osprofiler_profiler.get().get_base_id()"}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_c1feae37","line":942,"updated":"2016-05-12 17:44:09.000000000","message":"this should do it, but I wonder if we should try and pull the server side patch (with depends-on) and add a functional test that ties everything together?","commit_id":"fb570970746e5d22891a33c16ab7a43fa0d397ab"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"74cb059d5fd4de062e17ca4e67478ec68b4413c8","unresolved":false,"context_lines":[{"line_number":939,"context_line":""},{"line_number":940,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":941,"context_line":"    try:"},{"line_number":942,"context_line":"        shell \u003d NeutronShell(NEUTRON_API_VERSION)"},{"line_number":943,"context_line":"        res \u003d shell.run(list(map(encodeutils.safe_decode, argv)))"},{"line_number":944,"context_line":"        if shell.profile:"},{"line_number":945,"context_line":"            trace_id \u003d osprofiler_profiler.get().get_base_id()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9abb7d3a_4e972bec","line":942,"in_reply_to":"dab17558_c1feae37","updated":"2016-05-31 10:41:31.000000000","message":"Armando, server patch was already merged to master, so all jobs should use this code already.","commit_id":"fb570970746e5d22891a33c16ab7a43fa0d397ab"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"edd55d52d2d9921ecffd855ff530e63cf35ad66f","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                                \u0027data for performance profiling of operation. \u0027"},{"line_number":790,"context_line":"                                \u0027This key should be the value of the HMAC key \u0027"},{"line_number":791,"context_line":"                                \u0027configured for the OSprofiler middleware in \u0027"},{"line_number":792,"context_line":"                                \u0027nova; it is specified in the Nova \u0027"},{"line_number":793,"context_line":"                                \u0027configuration file at /etc/nova/nova.conf \u0027"},{"line_number":794,"context_line":"                                \u0027Without the key, profiling will not be \u0027"},{"line_number":795,"context_line":"                                \u0027triggered even if OSprofiler is enabled on \u0027"},{"line_number":796,"context_line":"                                \u0027the server side.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_05806af6","line":793,"range":{"start_line":792,"start_character":32,"end_line":793,"end_character":76},"updated":"2017-02-07 18:16:08.000000000","message":"Nova?","commit_id":"36379a5d5c4e55761a47f442781a23e3a1ed8750"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"cd31d462efb0d670f7099aac1c7cb2f6e58e52bb","unresolved":false,"context_lines":[{"line_number":789,"context_line":"                                \u0027data for performance profiling of operation. \u0027"},{"line_number":790,"context_line":"                                \u0027This key should be the value of the HMAC key \u0027"},{"line_number":791,"context_line":"                                \u0027configured for the OSprofiler middleware in \u0027"},{"line_number":792,"context_line":"                                \u0027nova; it is specified in the Nova \u0027"},{"line_number":793,"context_line":"                                \u0027configuration file at /etc/nova/nova.conf \u0027"},{"line_number":794,"context_line":"                                \u0027Without the key, profiling will not be \u0027"},{"line_number":795,"context_line":"                                \u0027triggered even if OSprofiler is enabled on \u0027"},{"line_number":796,"context_line":"                                \u0027the server side.\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a430d35_6eb2d495","line":793,"range":{"start_line":792,"start_character":32,"end_line":793,"end_character":76},"in_reply_to":"1a430d35_05806af6","updated":"2017-02-08 10:15:05.000000000","message":"LOL, good catch :)","commit_id":"36379a5d5c4e55761a47f442781a23e3a1ed8750"}]}
