)]}'
{"neutronclient/tests/unit/test_cli20.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a1cf5ff0aae376f0541b0645bc36214dff5a6dd1","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        exception \u003d self.assertRaises(exceptions.RequestURITooLong,"},{"line_number":619,"context_line":"                                      self.client.do_request,"},{"line_number":620,"context_line":"                                      \u0027GET\u0027, \u0027/test\u0027, body\u003d\u0027\u0027, params\u003dparams)"},{"line_number":621,"context_line":"        self.assertNotEqual(exception.excess, 0,"},{"line_number":622,"context_line":"                            \u0027Expected exception NOT raised\u0027)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_5599dc6d","line":621,"range":{"start_line":621,"start_character":28,"end_line":621,"end_character":47},"updated":"2016-02-19 13:50:40.000000000","message":"Consider the order (expected, actual)","commit_id":"3d34ec941217737ccc2d7003928c9e400d1ad49c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"29dd6c4d6829ed0a995ee6dcc04a02c925f8a811","unresolved":false,"context_lines":[{"line_number":618,"context_line":"        exception \u003d self.assertRaises(exceptions.RequestURITooLong,"},{"line_number":619,"context_line":"                                      self.client.do_request,"},{"line_number":620,"context_line":"                                      \u0027GET\u0027, \u0027/test\u0027, body\u003d\u0027\u0027, params\u003dparams)"},{"line_number":621,"context_line":"        self.assertNotEqual(exception.excess, 0,"},{"line_number":622,"context_line":"                            \u0027Expected exception NOT raised\u0027)"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a466f826","line":621,"range":{"start_line":621,"start_character":28,"end_line":621,"end_character":47},"in_reply_to":"bae84128_5599dc6d","updated":"2016-02-23 06:41:09.000000000","message":"My fault... fixed it!","commit_id":"3d34ec941217737ccc2d7003928c9e400d1ad49c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d17e769d048f71f0c649e623ed506aa50b8355aa","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                                      self.client.do_request,"},{"line_number":695,"context_line":"                                      \u0027GET\u0027, \u0027/test\u0027, body\u003d\u0027\u0027, params\u003dparams)"},{"line_number":696,"context_line":"        self.assertNotEqual(0, exception.excess,"},{"line_number":697,"context_line":"                            \u0027Expected exception NOT raised\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class CLITestV20ExceptionHandler(CLITestV20Base):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_c9160958","line":697,"range":{"start_line":697,"start_character":28,"end_line":697,"end_character":60},"updated":"2016-02-25 02:39:44.000000000","message":"This is not correct.\n\nIn try/except/else clause, \u0027else\u0027 clause is executed only when no \u0027except\u0027 clause is executed.\n\nIn this case, you use self.assertRaises.\nThis means \u0027else\u0027 clause in the original code is unnecessary.","commit_id":"2b9500d369e0f2e7115796416db13c8c37799e6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d4092055ec8bc062ab040a03f7835f8856c08bc5","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                                      self.client.do_request,"},{"line_number":695,"context_line":"                                      \u0027GET\u0027, \u0027/test\u0027, body\u003d\u0027\u0027, params\u003dparams)"},{"line_number":696,"context_line":"        self.assertNotEqual(0, exception.excess,"},{"line_number":697,"context_line":"                            \u0027Expected exception NOT raised\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class CLITestV20ExceptionHandler(CLITestV20Base):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_c606e21f","line":697,"range":{"start_line":697,"start_character":28,"end_line":697,"end_character":60},"in_reply_to":"9aed3d3a_c681c291","updated":"2016-02-26 00:36:21.000000000","message":"I actually removed it everywhere but here...","commit_id":"2b9500d369e0f2e7115796416db13c8c37799e6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"217ad2c4063e56c38afa6ba36f726e65de993f05","unresolved":false,"context_lines":[{"line_number":694,"context_line":"                                      self.client.do_request,"},{"line_number":695,"context_line":"                                      \u0027GET\u0027, \u0027/test\u0027, body\u003d\u0027\u0027, params\u003dparams)"},{"line_number":696,"context_line":"        self.assertNotEqual(0, exception.excess,"},{"line_number":697,"context_line":"                            \u0027Expected exception NOT raised\u0027)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":""},{"line_number":700,"context_line":"class CLITestV20ExceptionHandler(CLITestV20Base):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_c681c291","line":697,"range":{"start_line":697,"start_character":28,"end_line":697,"end_character":60},"in_reply_to":"bae84128_c9160958","updated":"2016-02-26 00:33:24.000000000","message":"Hmm, yeah right, the message wont ever be displayed!","commit_id":"2b9500d369e0f2e7115796416db13c8c37799e6a"}],"neutronclient/tests/unit/test_cli20_subnet.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ab009802487711b4ea737073470d573abb83985f","unresolved":false,"context_lines":[{"line_number":651,"context_line":"        self.assertRaises(exceptions.CommandError,"},{"line_number":652,"context_line":"                          self._test_update_resource,"},{"line_number":653,"context_line":"                          resource, cmd, \u0027myid\u0027,"},{"line_number":654,"context_line":"                          [\u0027myid\u0027, \u0027--name\u0027, \u0027myname\u0027, \u0027--enable-dhcp\u0027,"},{"line_number":655,"context_line":"                           \u0027--disable-dhcp\u0027], {\u0027name\u0027: \u0027myname\u0027, })"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"    def test_show_subnet(self):"},{"line_number":658,"context_line":"        # Show subnet: --fields id --fields name myid."}],"source_content_type":"text/x-python","patch_set":9,"id":"7a1b2928_8c69b08e","line":655,"range":{"start_line":654,"start_character":26,"end_line":655,"end_character":66},"updated":"2016-04-11 08:20:39.000000000","message":"nit: I don\u0027t think the place of wrapping lines is natural.\nI prefer to the previous style.","commit_id":"fc2950c2bb6ababef650e20ebefa2c3f1b46fa1a"}],"neutronclient/tests/unit/test_name_or_id.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"df6763dfa67b1080c7e31f64a6d5234b1e39f36e","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.mox.ReplayAll()"},{"line_number":191,"context_line":"        observed_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":192,"context_line":"            self.client, \u0027security_group\u0027, name, project)"},{"line_number":193,"context_line":"        self.assertEqual(expected_id, observed_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_3e57e0cb","line":193,"updated":"2016-02-19 06:06:33.000000000","message":"I know this is assertEqual.\nThe previous test case was not working properly( that is it was passing, returning the ID successfully).\nSo had to fix the test.","commit_id":"3d34ec941217737ccc2d7003928c9e400d1ad49c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"29dd6c4d6829ed0a995ee6dcc04a02c925f8a811","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.mox.ReplayAll()"},{"line_number":191,"context_line":"        observed_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":192,"context_line":"            self.client, \u0027security_group\u0027, name, project)"},{"line_number":193,"context_line":"        self.assertEqual(expected_id, observed_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_df0ca53d","line":193,"in_reply_to":"bae84128_75098031","updated":"2016-02-23 06:41:09.000000000","message":"I worked upon it...\nfind_resource_by_id should raise an error when the searched information is not in UUID format.","commit_id":"3d34ec941217737ccc2d7003928c9e400d1ad49c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"a1cf5ff0aae376f0541b0645bc36214dff5a6dd1","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.mox.ReplayAll()"},{"line_number":191,"context_line":"        observed_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":192,"context_line":"            self.client, \u0027security_group\u0027, name, project)"},{"line_number":193,"context_line":"        self.assertEqual(expected_id, observed_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_75098031","line":193,"in_reply_to":"dae33548_3e57e0cb","updated":"2016-02-19 13:50:40.000000000","message":"you are correct.\n\nHowever, find_resourceid_by_name_or_id first tries to find ID (find_resource_by_id). L.184 only mocks find_resource_by_name.\nI am afraid something is wrong.","commit_id":"3d34ec941217737ccc2d7003928c9e400d1ad49c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d17e769d048f71f0c649e623ed506aa50b8355aa","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        project \u003d str(uuid.uuid4())"},{"line_number":152,"context_line":"        expect_id \u003d str(uuid.uuid4())"},{"line_number":153,"context_line":"        reses \u003d {\u0027security_groups\u0027:"},{"line_number":154,"context_line":"                 [{\u0027id\u0027: expect_id, \u0027tenant_id\u0027: project}]}"},{"line_number":155,"context_line":"        resstr \u003d self.client.serialize(reses)"},{"line_number":156,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"},{"line_number":157,"context_line":"        path \u003d getattr(self.client, \"security_groups_path\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_327383b6","line":154,"range":{"start_line":154,"start_character":36,"end_line":154,"end_character":56},"updated":"2016-02-25 02:39:44.000000000","message":"This return value looks unnecessary because L.160 only requests \u0027id\u0027.","commit_id":"2b9500d369e0f2e7115796416db13c8c37799e6a"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9593d95c524c18e6352f655e1a58f6760962b2ea","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    def test_get_id_from_name_multiple_with_project_not_found(self):"},{"line_number":174,"context_line":"        name \u003d \u0027web_server\u0027"},{"line_number":175,"context_line":"        project \u003d str(uuid.uuid4())"},{"line_number":176,"context_line":"        resstr_notfound \u003d self.client.serialize({\u0027security_groups\u0027: []})"},{"line_number":177,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"},{"line_number":178,"context_line":"        path \u003d getattr(self.client, \"security_groups_path\")"},{"line_number":179,"context_line":"        self.client.httpclient.request("}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_a2eb4512","line":176,"updated":"2016-02-23 09:18:57.000000000","message":"When the project is not found, then the returned body would be blank...","commit_id":"2b9500d369e0f2e7115796416db13c8c37799e6a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d17e769d048f71f0c649e623ed506aa50b8355aa","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    def test_get_id_from_name_multiple_with_project_not_found(self):"},{"line_number":174,"context_line":"        name \u003d \u0027web_server\u0027"},{"line_number":175,"context_line":"        project \u003d str(uuid.uuid4())"},{"line_number":176,"context_line":"        resstr_notfound \u003d self.client.serialize({\u0027security_groups\u0027: []})"},{"line_number":177,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"},{"line_number":178,"context_line":"        path \u003d getattr(self.client, \"security_groups_path\")"},{"line_number":179,"context_line":"        self.client.httpclient.request("}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_b26793e9","line":176,"in_reply_to":"bae84128_a2eb4512","updated":"2016-02-25 02:39:44.000000000","message":"Your change looks correct.","commit_id":"2b9500d369e0f2e7115796416db13c8c37799e6a"},{"author":{"_account_id":10765,"name":"Andre Aranha","email":"afaranha@lsd.ufcg.edu.br","username":"afaranha"},"change_message_id":"efcfb48456bcefc5543e086aef66dab08f39ae8e","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.mox.ReplayAll()"},{"line_number":188,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":189,"context_line":"                          neutronV20.find_resourceid_by_name_or_id,"},{"line_number":190,"context_line":"                          self.client, \u0027security_group\u0027, name, project)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5aef4532_3f88ac70","line":190,"updated":"2016-03-10 13:44:01.000000000","message":"I think this should also test:\nex \u003d self.assertRaises(...)\nself.assertIn(\u0027Unable to find\u0027, ex.message)\nself.assertEqual(404, ex.status_code)","commit_id":"7af974fcff71373efb3a5ac8f8e3fedc72834ba9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"5ee6b61e27785d62c5d8c5d903a15c7234be4019","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        self.mox.ReplayAll()"},{"line_number":188,"context_line":"        self.assertRaises(exceptions.NotFound,"},{"line_number":189,"context_line":"                          neutronV20.find_resourceid_by_name_or_id,"},{"line_number":190,"context_line":"                          self.client, \u0027security_group\u0027, name, project)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa0719c6_f089ebcb","line":190,"in_reply_to":"5aef4532_3f88ac70","updated":"2016-03-22 01:20:31.000000000","message":"Done","commit_id":"7af974fcff71373efb3a5ac8f8e3fedc72834ba9"}],"neutronclient/tests/unit/vpn/test_cli20_ikepolicy.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d17e769d048f71f0c649e623ed506aa50b8355aa","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                           auth_algorithm, encryption_algorithm,"},{"line_number":136,"context_line":"                           phase1_negotiation_mode, ike_version, pfs,"},{"line_number":137,"context_line":"                           tenant_id]"},{"line_number":138,"context_line":"        self.assertRaises(exceptions.CommandError, self._test_create_resource,"},{"line_number":139,"context_line":"                          resource, cmd, name, my_id, args,"},{"line_number":140,"context_line":"                          position_names, position_values)"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_743070e9","line":138,"range":{"start_line":138,"start_character":51,"end_line":138,"end_character":78},"updated":"2016-02-25 02:39:44.000000000","message":"nit: I think it is easier to read the code if a called method is placed in a new line.","commit_id":"2b9500d369e0f2e7115796416db13c8c37799e6a"}]}
