)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cf03ced89d92c3278de080052848227e0f2f83ed","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tags support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the tag support for CLI."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia84b873e3916e7b9668181fe14c1448ef608bf1d"},{"line_number":12,"context_line":"Implements: blueprint add-tags-to-core-resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bae84128_7db5297c","line":9,"updated":"2016-02-24 04:47:26.000000000","message":"is this change complete? It looks like it\u0027s missing other commands like list of tags?","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f58c4066c834fefe05f2fe704ed608989950cf5f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add tags support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds the tag support for CLI."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ia84b873e3916e7b9668181fe14c1448ef608bf1d"},{"line_number":12,"context_line":"Implements: blueprint add-tags-to-core-resources"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_b8e4840d","line":9,"in_reply_to":"bae84128_7db5297c","updated":"2016-02-26 09:33:33.000000000","message":"We have a plan in spec: tag-create, tag-delete, net-list --tags. Now I added \"tag-update\" but not tag-list because neutron server doesn\u0027t have API like tag-list. Maybe, this is discussion about model as well.","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"}],"neutronclient/neutron/v2_0/__init__.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cf03ced89d92c3278de080052848227e0f2f83ed","unresolved":false,"context_lines":[{"line_number":36,"context_line":"UUID_PATTERN \u003d \u0027-\u0027.join([HEX_ELEM + \u0027{8}\u0027, HEX_ELEM + \u0027{4}\u0027,"},{"line_number":37,"context_line":"                         HEX_ELEM + \u0027{4}\u0027, HEX_ELEM + \u0027{4}\u0027,"},{"line_number":38,"context_line":"                         HEX_ELEM + \u0027{12}\u0027])"},{"line_number":39,"context_line":"HYPHEN_OPTS \u003d [\u0027tags-any\u0027, \u0027not-tags\u0027, \u0027not-tags-any\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_resource_plural(resource, client):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_8056c403","line":39,"updated":"2016-02-24 04:47:26.000000000","message":"what about the query\n\nneutron net-list --tag-any \u003cfoo\u003e?\n\nThat doesn\u0027t seem to work for me.","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f58c4066c834fefe05f2fe704ed608989950cf5f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"UUID_PATTERN \u003d \u0027-\u0027.join([HEX_ELEM + \u0027{8}\u0027, HEX_ELEM + \u0027{4}\u0027,"},{"line_number":37,"context_line":"                         HEX_ELEM + \u0027{4}\u0027, HEX_ELEM + \u0027{4}\u0027,"},{"line_number":38,"context_line":"                         HEX_ELEM + \u0027{12}\u0027])"},{"line_number":39,"context_line":"HYPHEN_OPTS \u003d [\u0027tags-any\u0027, \u0027not-tags\u0027, \u0027not-tags-any\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_resource_plural(resource, client):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_3d7986fd","line":39,"in_reply_to":"bae84128_8056c403","updated":"2016-02-26 09:33:33.000000000","message":"Can you try \"neutron net-list --tags-any \u003cfoo\u003e\"?","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"UUID_PATTERN \u003d \u0027-\u0027.join([HEX_ELEM + \u0027{8}\u0027, HEX_ELEM + \u0027{4}\u0027,"},{"line_number":37,"context_line":"                         HEX_ELEM + \u0027{4}\u0027, HEX_ELEM + \u0027{4}\u0027,"},{"line_number":38,"context_line":"                         HEX_ELEM + \u0027{12}\u0027])"},{"line_number":39,"context_line":"HYPHEN_OPTS \u003d [\u0027tags-any\u0027, \u0027not-tags\u0027, \u0027not-tags-any\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_resource_plural(resource, client):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_a614cb4c","line":39,"updated":"2016-03-01 06:31:36.000000000","message":"It is better to define these + \u0027tags\u0027 as net-list options.","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":36,"context_line":"UUID_PATTERN \u003d \u0027-\u0027.join([HEX_ELEM + \u0027{8}\u0027, HEX_ELEM + \u0027{4}\u0027,"},{"line_number":37,"context_line":"                         HEX_ELEM + \u0027{4}\u0027, HEX_ELEM + \u0027{4}\u0027,"},{"line_number":38,"context_line":"                         HEX_ELEM + \u0027{12}\u0027])"},{"line_number":39,"context_line":"HYPHEN_OPTS \u003d [\u0027tags-any\u0027, \u0027not-tags\u0027, \u0027not-tags-any\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def _get_resource_plural(resource, client):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_89b69e88","line":39,"in_reply_to":"9aed3d3a_a614cb4c","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"}],"neutronclient/neutron/v2_0/tag.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cf03ced89d92c3278de080052848227e0f2f83ed","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        parser \u003d super(TagApiCommon, self).get_parser(prog_name)"},{"line_number":21,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"},{"line_number":22,"context_line":"                            dest\u003d\u0027resource_type\u0027,"},{"line_number":23,"context_line":"                            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":24,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":25,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":26,"context_line":"                            metavar\u003d\u0027\u003cresource\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_1d37bdff","line":23,"updated":"2016-02-24 04:47:26.000000000","message":"If the resource type is invalid the error message is not very user friendly. Consider  sanitizing this client side or wrap the exception returned from the server side?","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f58c4066c834fefe05f2fe704ed608989950cf5f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"        parser \u003d super(TagApiCommon, self).get_parser(prog_name)"},{"line_number":21,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"},{"line_number":22,"context_line":"                            dest\u003d\u0027resource_type\u0027,"},{"line_number":23,"context_line":"                            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":24,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":25,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":26,"context_line":"                            metavar\u003d\u0027\u003cresource\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_1d948235","line":23,"in_reply_to":"bae84128_1d37bdff","updated":"2016-02-26 09:33:33.000000000","message":"Done","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cf03ced89d92c3278de080052848227e0f2f83ed","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        client.create_tag(resource_type, resource_id, parsed_args.tag)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class DeleteTag(TagApiCommon):"},{"line_number":64,"context_line":"    \"\"\"Delete a tag of the resource.\"\"\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e0451043","line":63,"updated":"2016-02-24 04:47:26.000000000","message":"the fact that we must specify the tuple (resource type, resource id, tag value) to remove a tag made me look back at the model because it doesn\u0027t seem like it\u0027s super user friendly. I am having second thoughts on whether we nailed the right model. I\u0027ll provide more feedback on the server side patch.","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"TAG_RESOURCES \u003d [\u0027network\u0027]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TagApiBase(neutronv20.NeutronCommand):"},{"line_number":23,"context_line":"    def get_parser(self, prog_name):"},{"line_number":24,"context_line":"        parser \u003d super(TagApiBase, self).get_parser(prog_name)"},{"line_number":25,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_04400f33","line":22,"updated":"2016-03-01 06:31:36.000000000","message":"Now I don\u0027t see any reason you define options for creating and deleting tags in one place. I think it is easier to understand to define them separately.","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":19,"context_line":"TAG_RESOURCES \u003d [\u0027network\u0027]"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class TagApiBase(neutronv20.NeutronCommand):"},{"line_number":23,"context_line":"    def get_parser(self, prog_name):"},{"line_number":24,"context_line":"        parser \u003d super(TagApiBase, self).get_parser(prog_name)"},{"line_number":25,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_58262c69","line":22,"in_reply_to":"9aed3d3a_04400f33","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        parser \u003d super(TagApiBase, self).get_parser(prog_name)"},{"line_number":25,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"},{"line_number":26,"context_line":"                            dest\u003d\u0027resource_type\u0027,"},{"line_number":27,"context_line":"                            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":28,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":29,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":30,"context_line":"                            metavar\u003d\u0027\u003cresource\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_b00ec189","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":54},"updated":"2016-03-01 06:31:36.000000000","message":"unnecessary","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":24,"context_line":"        parser \u003d super(TagApiBase, self).get_parser(prog_name)"},{"line_number":25,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"},{"line_number":26,"context_line":"                            dest\u003d\u0027resource_type\u0027,"},{"line_number":27,"context_line":"                            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":28,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":29,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":30,"context_line":"                            metavar\u003d\u0027\u003cresource\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_a7774fd3","line":27,"range":{"start_line":27,"start_character":28,"end_line":27,"end_character":54},"in_reply_to":"9aed3d3a_b00ec189","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"},{"line_number":26,"context_line":"                            dest\u003d\u0027resource_type\u0027,"},{"line_number":27,"context_line":"                            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":28,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":29,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":30,"context_line":"                            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":31,"context_line":"                            help\u003d_(\u0027Resource name or id.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_29d6ccf0","line":28,"updated":"2016-03-01 06:31:36.000000000","message":"It is better to show the supported resource type (as rbac-create does).","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"},{"line_number":26,"context_line":"                            dest\u003d\u0027resource_type\u0027,"},{"line_number":27,"context_line":"                            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":28,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":29,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":30,"context_line":"                            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":31,"context_line":"                            help\u003d_(\u0027Resource name or id.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_62d1b5cd","line":28,"in_reply_to":"9aed3d3a_29d6ccf0","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":28,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":29,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":30,"context_line":"                            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":31,"context_line":"                            help\u003d_(\u0027Resource name or id.\u0027))"},{"line_number":32,"context_line":"        if self.has_all_opt:"},{"line_number":33,"context_line":"            tag_opt \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_102a0ddb","line":30,"range":{"start_line":30,"start_character":28,"end_line":30,"end_character":49},"updated":"2016-03-01 06:31:36.000000000","message":"unnecessary","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":28,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":29,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":30,"context_line":"                            metavar\u003d\u0027\u003cresource\u003e\u0027,"},{"line_number":31,"context_line":"                            help\u003d_(\u0027Resource name or id.\u0027))"},{"line_number":32,"context_line":"        if self.has_all_opt:"},{"line_number":33,"context_line":"            tag_opt \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_274a1f84","line":30,"range":{"start_line":30,"start_character":28,"end_line":30,"end_character":49},"in_reply_to":"9aed3d3a_102a0ddb","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            tag_opt \u003d parser.add_mutually_exclusive_group()"},{"line_number":34,"context_line":"            tag_opt.add_argument(\u0027--all\u0027,"},{"line_number":35,"context_line":"                                 action\u003d\u0027store_true\u0027,"},{"line_number":36,"context_line":"                                 help\u003d_(\u0027All tags.\u0027))"},{"line_number":37,"context_line":"            tag_opt.add_argument(\u0027--tag\u0027,"},{"line_number":38,"context_line":"                                 metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":39,"context_line":"                                 help\u003d_(\u0027Tag.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_29724c11","line":36,"range":{"start_line":36,"start_character":40,"end_line":36,"end_character":51},"updated":"2016-03-01 06:31:36.000000000","message":"I would like to see more user-friendly help message.\n\n  tag-delete\n      --all   Delete all tags on the resource","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":33,"context_line":"            tag_opt \u003d parser.add_mutually_exclusive_group()"},{"line_number":34,"context_line":"            tag_opt.add_argument(\u0027--all\u0027,"},{"line_number":35,"context_line":"                                 action\u003d\u0027store_true\u0027,"},{"line_number":36,"context_line":"                                 help\u003d_(\u0027All tags.\u0027))"},{"line_number":37,"context_line":"            tag_opt.add_argument(\u0027--tag\u0027,"},{"line_number":38,"context_line":"                                 metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":39,"context_line":"                                 help\u003d_(\u0027Tag.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_420e3935","line":36,"range":{"start_line":36,"start_character":40,"end_line":36,"end_character":51},"in_reply_to":"9aed3d3a_29724c11","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                 action\u003d\u0027store_true\u0027,"},{"line_number":36,"context_line":"                                 help\u003d_(\u0027All tags.\u0027))"},{"line_number":37,"context_line":"            tag_opt.add_argument(\u0027--tag\u0027,"},{"line_number":38,"context_line":"                                 metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":39,"context_line":"                                 help\u003d_(\u0027Tag.\u0027))"},{"line_number":40,"context_line":"        elif self.multi_tags:"},{"line_number":41,"context_line":"            parser.add_argument(\u0027--tag\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_502015f7","line":38,"range":{"start_line":38,"start_character":33,"end_line":38,"end_character":49},"updated":"2016-03-01 06:31:36.000000000","message":"unnecessary","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":35,"context_line":"                                 action\u003d\u0027store_true\u0027,"},{"line_number":36,"context_line":"                                 help\u003d_(\u0027All tags.\u0027))"},{"line_number":37,"context_line":"            tag_opt.add_argument(\u0027--tag\u0027,"},{"line_number":38,"context_line":"                                 metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":39,"context_line":"                                 help\u003d_(\u0027Tag.\u0027))"},{"line_number":40,"context_line":"        elif self.multi_tags:"},{"line_number":41,"context_line":"            parser.add_argument(\u0027--tag\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_8237a1e2","line":38,"range":{"start_line":38,"start_character":33,"end_line":38,"end_character":49},"in_reply_to":"9aed3d3a_502015f7","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                 help\u003d_(\u0027All tags.\u0027))"},{"line_number":37,"context_line":"            tag_opt.add_argument(\u0027--tag\u0027,"},{"line_number":38,"context_line":"                                 metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":39,"context_line":"                                 help\u003d_(\u0027Tag.\u0027))"},{"line_number":40,"context_line":"        elif self.multi_tags:"},{"line_number":41,"context_line":"            parser.add_argument(\u0027--tag\u0027,"},{"line_number":42,"context_line":"                                metavar\u003d\u0027\u003cTAG\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_49fcf03d","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":48},"updated":"2016-03-01 06:31:36.000000000","message":"I would like to see more user-friendly message.\n\nFor tag-remove:  Tag to be removed","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                                 help\u003d_(\u0027All tags.\u0027))"},{"line_number":37,"context_line":"            tag_opt.add_argument(\u0027--tag\u0027,"},{"line_number":38,"context_line":"                                 metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":39,"context_line":"                                 help\u003d_(\u0027Tag.\u0027))"},{"line_number":40,"context_line":"        elif self.multi_tags:"},{"line_number":41,"context_line":"            parser.add_argument(\u0027--tag\u0027,"},{"line_number":42,"context_line":"                                metavar\u003d\u0027\u003cTAG\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c248895e","line":39,"range":{"start_line":39,"start_character":33,"end_line":39,"end_character":48},"in_reply_to":"9aed3d3a_49fcf03d","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                 help\u003d_(\u0027Tag.\u0027))"},{"line_number":40,"context_line":"        elif self.multi_tags:"},{"line_number":41,"context_line":"            parser.add_argument(\u0027--tag\u0027,"},{"line_number":42,"context_line":"                                metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":43,"context_line":"                                action\u003d\u0027append\u0027,"},{"line_number":44,"context_line":"                                dest\u003d\u0027tags\u0027,"},{"line_number":45,"context_line":"                                help\u003d_(\u0027Tag (This option can be repeated).\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_707f19e0","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":48},"updated":"2016-03-01 06:31:36.000000000","message":"\u003cTAG\u003e -\u003e TAG","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                                 help\u003d_(\u0027Tag.\u0027))"},{"line_number":40,"context_line":"        elif self.multi_tags:"},{"line_number":41,"context_line":"            parser.add_argument(\u0027--tag\u0027,"},{"line_number":42,"context_line":"                                metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":43,"context_line":"                                action\u003d\u0027append\u0027,"},{"line_number":44,"context_line":"                                dest\u003d\u0027tags\u0027,"},{"line_number":45,"context_line":"                                help\u003d_(\u0027Tag (This option can be repeated).\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_02a0b1f3","line":42,"range":{"start_line":42,"start_character":32,"end_line":42,"end_character":48},"in_reply_to":"9aed3d3a_707f19e0","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                help\u003d_(\u0027Tag (This option can be repeated).\u0027))"},{"line_number":46,"context_line":"        else:"},{"line_number":47,"context_line":"            parser.add_argument(\u0027--tag\u0027,"},{"line_number":48,"context_line":"                                metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":49,"context_line":"                                help\u003d_(\u0027Tag.\u0027))"},{"line_number":50,"context_line":"        return parser"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_d08265c7","line":48,"range":{"start_line":48,"start_character":32,"end_line":48,"end_character":48},"updated":"2016-03-01 06:31:36.000000000","message":"unnecessary","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                help\u003d_(\u0027Tag (This option can be repeated).\u0027))"},{"line_number":46,"context_line":"        else:"},{"line_number":47,"context_line":"            parser.add_argument(\u0027--tag\u0027,"},{"line_number":48,"context_line":"                                metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":49,"context_line":"                                help\u003d_(\u0027Tag.\u0027))"},{"line_number":50,"context_line":"        return parser"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_229b2dcb","line":48,"range":{"start_line":48,"start_character":32,"end_line":48,"end_character":48},"in_reply_to":"9aed3d3a_d08265c7","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        else:"},{"line_number":47,"context_line":"            parser.add_argument(\u0027--tag\u0027,"},{"line_number":48,"context_line":"                                metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":49,"context_line":"                                help\u003d_(\u0027Tag.\u0027))"},{"line_number":50,"context_line":"        return parser"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _check_args(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_a9b81c76","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":46},"updated":"2016-03-01 06:31:36.000000000","message":"I think it is only used in tag-create, so we can change this to \"Tag to be added.\"","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        else:"},{"line_number":47,"context_line":"            parser.add_argument(\u0027--tag\u0027,"},{"line_number":48,"context_line":"                                metavar\u003d\u0027\u003cTAG\u003e\u0027,"},{"line_number":49,"context_line":"                                help\u003d_(\u0027Tag.\u0027))"},{"line_number":50,"context_line":"        return parser"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _check_args(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c25fe90c","line":49,"range":{"start_line":49,"start_character":37,"end_line":49,"end_character":46},"in_reply_to":"9aed3d3a_a9b81c76","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _check_args(self, parsed_args):"},{"line_number":53,"context_line":"        if not parsed_args.resource_type:"},{"line_number":54,"context_line":"            raise exceptions.CommandError("},{"line_number":55,"context_line":"                _(\"--resource-type must be specified\"))"},{"line_number":56,"context_line":"        if parsed_args.resource_type not in TAG_RESOURCES:"},{"line_number":57,"context_line":"            msg \u003d _(\"resource-type %s is invalid\") % parsed_args.resource_type"},{"line_number":58,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_49aa301a","line":55,"range":{"start_line":54,"start_character":12,"end_line":55,"end_character":55},"updated":"2016-03-01 06:31:36.000000000","message":"Use required\u003dTrue instead.","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def _check_args(self, parsed_args):"},{"line_number":53,"context_line":"        if not parsed_args.resource_type:"},{"line_number":54,"context_line":"            raise exceptions.CommandError("},{"line_number":55,"context_line":"                _(\"--resource-type must be specified\"))"},{"line_number":56,"context_line":"        if parsed_args.resource_type not in TAG_RESOURCES:"},{"line_number":57,"context_line":"            msg \u003d _(\"resource-type %s is invalid\") % parsed_args.resource_type"},{"line_number":58,"context_line":"            raise exceptions.CommandError(msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_c269a98d","line":55,"range":{"start_line":54,"start_character":12,"end_line":55,"end_character":55},"in_reply_to":"9aed3d3a_49aa301a","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            raise exceptions.CommandError("},{"line_number":55,"context_line":"                _(\"--resource-type must be specified\"))"},{"line_number":56,"context_line":"        if parsed_args.resource_type not in TAG_RESOURCES:"},{"line_number":57,"context_line":"            msg \u003d _(\"resource-type %s is invalid\") % parsed_args.resource_type"},{"line_number":58,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":59,"context_line":"        if not parsed_args.resource:"},{"line_number":60,"context_line":"            raise exceptions.CommandError(_(\"--resource must be specified\"))"},{"line_number":61,"context_line":"        if self.has_all_opt:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_097b08c2","line":58,"range":{"start_line":57,"start_character":12,"end_line":58,"end_character":46},"updated":"2016-03-01 06:31:36.000000000","message":"Use choices\u003dTAG_RESOURCES instead.","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            raise exceptions.CommandError("},{"line_number":55,"context_line":"                _(\"--resource-type must be specified\"))"},{"line_number":56,"context_line":"        if parsed_args.resource_type not in TAG_RESOURCES:"},{"line_number":57,"context_line":"            msg \u003d _(\"resource-type %s is invalid\") % parsed_args.resource_type"},{"line_number":58,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":59,"context_line":"        if not parsed_args.resource:"},{"line_number":60,"context_line":"            raise exceptions.CommandError(_(\"--resource must be specified\"))"},{"line_number":61,"context_line":"        if self.has_all_opt:"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_62e8957d","line":58,"range":{"start_line":57,"start_character":12,"end_line":58,"end_character":46},"in_reply_to":"9aed3d3a_097b08c2","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            msg \u003d _(\"resource-type %s is invalid\") % parsed_args.resource_type"},{"line_number":58,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":59,"context_line":"        if not parsed_args.resource:"},{"line_number":60,"context_line":"            raise exceptions.CommandError(_(\"--resource must be specified\"))"},{"line_number":61,"context_line":"        if self.has_all_opt:"},{"line_number":62,"context_line":"            if not parsed_args.all and not parsed_args.tag:"},{"line_number":63,"context_line":"                raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_e97504cb","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":76},"updated":"2016-03-01 06:31:36.000000000","message":"Consider using required\u003dTrue.","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            msg \u003d _(\"resource-type %s is invalid\") % parsed_args.resource_type"},{"line_number":58,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":59,"context_line":"        if not parsed_args.resource:"},{"line_number":60,"context_line":"            raise exceptions.CommandError(_(\"--resource must be specified\"))"},{"line_number":61,"context_line":"        if self.has_all_opt:"},{"line_number":62,"context_line":"            if not parsed_args.all and not parsed_args.tag:"},{"line_number":63,"context_line":"                raise exceptions.CommandError("}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_2205edc1","line":60,"range":{"start_line":60,"start_character":12,"end_line":60,"end_character":76},"in_reply_to":"9aed3d3a_e97504cb","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    _(\"--all or --tag must be specified\"))"},{"line_number":65,"context_line":"        elif self.multi_tags:"},{"line_number":66,"context_line":"            if not parsed_args.tags:"},{"line_number":67,"context_line":"                raise exceptions.CommandError(_(\"--tag must be specified\"))"},{"line_number":68,"context_line":"        elif not parsed_args.tag:"},{"line_number":69,"context_line":"            raise exceptions.CommandError(_(\"--tag must be specified\"))"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_09102856","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":75},"updated":"2016-03-01 06:31:36.000000000","message":"Can\u0027t we required\u003dTrue?","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                    _(\"--all or --tag must be specified\"))"},{"line_number":65,"context_line":"        elif self.multi_tags:"},{"line_number":66,"context_line":"            if not parsed_args.tags:"},{"line_number":67,"context_line":"                raise exceptions.CommandError(_(\"--tag must be specified\"))"},{"line_number":68,"context_line":"        elif not parsed_args.tag:"},{"line_number":69,"context_line":"            raise exceptions.CommandError(_(\"--tag must be specified\"))"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_028d5131","line":67,"range":{"start_line":67,"start_character":16,"end_line":67,"end_character":75},"in_reply_to":"9aed3d3a_09102856","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            if not parsed_args.tags:"},{"line_number":67,"context_line":"                raise exceptions.CommandError(_(\"--tag must be specified\"))"},{"line_number":68,"context_line":"        elif not parsed_args.tag:"},{"line_number":69,"context_line":"            raise exceptions.CommandError(_(\"--tag must be specified\"))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _convert_resource_args(self, client, parsed_args):"},{"line_number":72,"context_line":"        resource_type \u003d neutronv20._get_resource_plural("}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_4906b020","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":71},"updated":"2016-03-01 06:31:36.000000000","message":"Can\u0027t we required\u003dTrue?","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            if not parsed_args.tags:"},{"line_number":67,"context_line":"                raise exceptions.CommandError(_(\"--tag must be specified\"))"},{"line_number":68,"context_line":"        elif not parsed_args.tag:"},{"line_number":69,"context_line":"            raise exceptions.CommandError(_(\"--tag must be specified\"))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _convert_resource_args(self, client, parsed_args):"},{"line_number":72,"context_line":"        resource_type \u003d neutronv20._get_resource_plural("}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_4287590f","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":71},"in_reply_to":"9aed3d3a_4906b020","updated":"2016-03-01 20:08:00.000000000","message":"Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ed9883e9c6b4164eff17f9cc0e5631715e20696e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Add a tag into the resource.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"},{"line_number":34,"context_line":"        parser \u003d super(AddTag, self).get_parser(prog_name)"},{"line_number":35,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"},{"line_number":36,"context_line":"                            choices\u003dTAG_RESOURCES,"},{"line_number":37,"context_line":"                            dest\u003d\u0027resource_type\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_c4822452","line":34,"updated":"2016-03-02 10:58:41.000000000","message":"--resource-type and --resource are common to all tag commands.\nIt seems better to use a common method.","commit_id":"d63e28929c958dccef111464346fe976afa38ef2"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b2a2e3027795a4188a02edd9908e4d1176b728ad","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Add a tag into the resource.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"},{"line_number":34,"context_line":"        parser \u003d super(AddTag, self).get_parser(prog_name)"},{"line_number":35,"context_line":"        parser.add_argument(\u0027--resource-type\u0027,"},{"line_number":36,"context_line":"                            choices\u003dTAG_RESOURCES,"},{"line_number":37,"context_line":"                            dest\u003d\u0027resource_type\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_d8b327e8","line":34,"in_reply_to":"7af24918_c4822452","updated":"2016-03-02 12:16:32.000000000","message":"Done","commit_id":"d63e28929c958dccef111464346fe976afa38ef2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ed9883e9c6b4164eff17f9cc0e5631715e20696e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":40,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":41,"context_line":"                            required\u003dTrue,"},{"line_number":42,"context_line":"                            help\u003d_(\u0027Resource name or id.\u0027))"},{"line_number":43,"context_line":"        parser.add_argument(\u0027--tag\u0027,"},{"line_number":44,"context_line":"                            required\u003dTrue,"},{"line_number":45,"context_line":"                            help\u003d_(\u0027Tag to be added.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_04a6cc0f","line":42,"range":{"start_line":42,"start_character":53,"end_line":42,"end_character":55},"updated":"2016-03-02 10:58:41.000000000","message":"I think we use \"ID\" everywhere.","commit_id":"d63e28929c958dccef111464346fe976afa38ef2"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b2a2e3027795a4188a02edd9908e4d1176b728ad","unresolved":false,"context_lines":[{"line_number":39,"context_line":"                            help\u003d_(\u0027Resource Type.\u0027))"},{"line_number":40,"context_line":"        parser.add_argument(\u0027--resource\u0027,"},{"line_number":41,"context_line":"                            required\u003dTrue,"},{"line_number":42,"context_line":"                            help\u003d_(\u0027Resource name or id.\u0027))"},{"line_number":43,"context_line":"        parser.add_argument(\u0027--tag\u0027,"},{"line_number":44,"context_line":"                            required\u003dTrue,"},{"line_number":45,"context_line":"                            help\u003d_(\u0027Tag to be added.\u0027))"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_78abf31d","line":42,"range":{"start_line":42,"start_character":53,"end_line":42,"end_character":55},"in_reply_to":"7af24918_04a6cc0f","updated":"2016-03-02 12:16:32.000000000","message":"Done","commit_id":"d63e28929c958dccef111464346fe976afa38ef2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ed9883e9c6b4164eff17f9cc0e5631715e20696e","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class ReplaceTag(neutronv20.NeutronCommand):"},{"line_number":56,"context_line":"    \"\"\"Replace tags on the resource.\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_parser(self, prog_name):"},{"line_number":59,"context_line":"        parser \u003d super(ReplaceTag, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_e45ac029","line":56,"updated":"2016-03-02 10:58:41.000000000","message":"How about \"Replace all tags\" ?","commit_id":"d63e28929c958dccef111464346fe976afa38ef2"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b2a2e3027795a4188a02edd9908e4d1176b728ad","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class ReplaceTag(neutronv20.NeutronCommand):"},{"line_number":56,"context_line":"    \"\"\"Replace tags on the resource.\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_parser(self, prog_name):"},{"line_number":59,"context_line":"        parser \u003d super(ReplaceTag, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_58a6f753","line":56,"in_reply_to":"7af24918_e45ac029","updated":"2016-03-02 12:16:32.000000000","message":"Done","commit_id":"d63e28929c958dccef111464346fe976afa38ef2"}],"neutronclient/shell.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8641a5c2a15ee13c0a085bd73483781b9756951d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"    \u0027availability-zone-list\u0027: availability_zone.ListAvailabilityZone,"},{"line_number":397,"context_line":"    \u0027auto-allocated-topology-show\u0027: ("},{"line_number":398,"context_line":"        auto_allocated_topology.ShowAutoAllocatedTopology),"},{"line_number":399,"context_line":"    \u0027tag-create\u0027: tag.CreateTag,"},{"line_number":400,"context_line":"    \u0027tag-delete\u0027: tag.DeleteTag,"},{"line_number":401,"context_line":"}"},{"line_number":402,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_23054210","line":399,"updated":"2016-02-24 05:16:16.000000000","message":"I wonder if tag-associate and tag-disassociate are more apt names based on what the commands do.","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8641a5c2a15ee13c0a085bd73483781b9756951d","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    \u0027auto-allocated-topology-show\u0027: ("},{"line_number":398,"context_line":"        auto_allocated_topology.ShowAutoAllocatedTopology),"},{"line_number":399,"context_line":"    \u0027tag-create\u0027: tag.CreateTag,"},{"line_number":400,"context_line":"    \u0027tag-delete\u0027: tag.DeleteTag,"},{"line_number":401,"context_line":"}"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"COMMANDS \u003d {\u00272.0\u0027: COMMAND_V2}"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c316164b","line":400,"updated":"2016-02-24 05:16:16.000000000","message":"are you going to allow tag-delete with \u0027missing parameters\u0027? E.g. to shortcut the ability to remove the same tag to all the resources it applies?","commit_id":"708c3d4312556163289eeda2bc7a83c5a1936a8b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ca28016d1f29d5a9bae2b4e94fc491f3e2bac92b","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    \u0027bgp-peer-delete\u0027: bgp_peer.DeletePeer,"},{"line_number":431,"context_line":"    \u0027tag-create\u0027: tag.CreateTag,"},{"line_number":432,"context_line":"    \u0027tag-update\u0027: tag.UpdateTag,"},{"line_number":433,"context_line":"    \u0027tag-delete\u0027: tag.DeleteTag,"},{"line_number":434,"context_line":"}"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"COMMANDS \u003d {\u00272.0\u0027: COMMAND_V2}"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_89ec382b","line":433,"updated":"2016-03-01 06:31:36.000000000","message":"When I tried \u0027tag\u0027 patch in my local env, I feel \u0027tag-add/remove\u0027 better rather than \u0027tag-create/delete\u0027. Perhaps it is because \u0027tag\u0027 is not a top resource and it is not what we create.a\n\nRegarding tag-update, another option is \u0027tag-replace\u0027 (as it replaces all existing tags (including empty tag).","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"7e1ee07f61163d25767511db14221ce10c808009","unresolved":false,"context_lines":[{"line_number":430,"context_line":"    \u0027bgp-peer-delete\u0027: bgp_peer.DeletePeer,"},{"line_number":431,"context_line":"    \u0027tag-create\u0027: tag.CreateTag,"},{"line_number":432,"context_line":"    \u0027tag-update\u0027: tag.UpdateTag,"},{"line_number":433,"context_line":"    \u0027tag-delete\u0027: tag.DeleteTag,"},{"line_number":434,"context_line":"}"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"COMMANDS \u003d {\u00272.0\u0027: COMMAND_V2}"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_09828e94","line":433,"in_reply_to":"9aed3d3a_89ec382b","updated":"2016-03-01 20:08:00.000000000","message":"I agree. Done","commit_id":"c9f724e0bc4f6b4f3b4c1a0b1192c636ebde9aae"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ed9883e9c6b4164eff17f9cc0e5631715e20696e","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    \u0027net-ip-availability-list\u0027: network_ip_availability.ListIpAvailability,"},{"line_number":447,"context_line":"    \u0027net-ip-availability-show\u0027: network_ip_availability.ShowIpAvailability,"},{"line_number":448,"context_line":"    \u0027tag-add\u0027: tag.AddTag,"},{"line_number":449,"context_line":"    \u0027tag-replace\u0027: tag.ReplaceTag,"},{"line_number":450,"context_line":"    \u0027tag-remove\u0027: tag.RemoveTag,"},{"line_number":451,"context_line":"}"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_c4634419","line":449,"range":{"start_line":449,"start_character":4,"end_line":449,"end_character":17},"updated":"2016-03-02 10:58:41.000000000","message":"[Some note]\n\nI suggested \u0027tag-replace\u0027. It is because \u0027replace\u0027 associates all tags are replaced. Others might prefer to different names. Another option is \u0027tag-set\u0027.\n\nNote that \u0027tag\u0027 is not a top level resource at now.\nSo I think it is better to avoid xxx-create/delete/update.","commit_id":"d63e28929c958dccef111464346fe976afa38ef2"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b2a2e3027795a4188a02edd9908e4d1176b728ad","unresolved":false,"context_lines":[{"line_number":446,"context_line":"    \u0027net-ip-availability-list\u0027: network_ip_availability.ListIpAvailability,"},{"line_number":447,"context_line":"    \u0027net-ip-availability-show\u0027: network_ip_availability.ShowIpAvailability,"},{"line_number":448,"context_line":"    \u0027tag-add\u0027: tag.AddTag,"},{"line_number":449,"context_line":"    \u0027tag-replace\u0027: tag.ReplaceTag,"},{"line_number":450,"context_line":"    \u0027tag-remove\u0027: tag.RemoveTag,"},{"line_number":451,"context_line":"}"},{"line_number":452,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7af24918_b3375caf","line":449,"range":{"start_line":449,"start_character":4,"end_line":449,"end_character":17},"in_reply_to":"7af24918_c4634419","updated":"2016-03-02 12:16:32.000000000","message":"I agree. It\u0027s difficult to define perfect name because tag isn\u0027t general resource for OpenStack.","commit_id":"d63e28929c958dccef111464346fe976afa38ef2"}],"neutronclient/tests/unit/test_cli20_tag.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1fa2475edcdd6f96fb396e5c0aa96d990350db96","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                \u0027--all\u0027]"},{"line_number":109,"context_line":"        self._test_tag_operation(cmd, path, \u0027DELETE\u0027, args, \"tag-remove\")"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_no_resoure_type(self):"},{"line_number":112,"context_line":"        cmd \u003d tag.AddTag(test_cli20.MyApp(sys.stdout), None)"},{"line_number":113,"context_line":"        path \u003d self._make_tag_path(\u0027network\u0027, \u0027myid\u0027, \u0027red\u0027)"},{"line_number":114,"context_line":"        args \u003d [\u0027--resource\u0027, \u0027myid\u0027, \u0027--tag\u0027, \u0027red\u0027]"},{"line_number":115,"context_line":"        self.assertRaises(exceptions.CommandError, self._test_tag_operation,"},{"line_number":116,"context_line":"                          cmd, path, \u0027PUT\u0027, args, \"tag-add\")"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"    def test_invalid_resoure_type(self):"},{"line_number":119,"context_line":"        cmd \u003d tag.AddTag(test_cli20.MyApp(sys.stdout), None)"},{"line_number":120,"context_line":"        path \u003d self._make_tag_path(\u0027network\u0027, \u0027myid\u0027, \u0027red\u0027)"},{"line_number":121,"context_line":"        args \u003d [\u0027--resource-type\u0027, \u0027test\u0027, \u0027--resource\u0027,"},{"line_number":122,"context_line":"                \u0027myid\u0027, \u0027--tag\u0027, \u0027red\u0027]"},{"line_number":123,"context_line":"        self.assertRaises(exceptions.CommandError, self._test_tag_operation,"},{"line_number":124,"context_line":"                          cmd, path, \u0027PUT\u0027, args, \"tag-add\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def test_no_resoure(self):"},{"line_number":127,"context_line":"        cmd \u003d tag.RemoveTag(test_cli20.MyApp(sys.stdout), None)"},{"line_number":128,"context_line":"        path \u003d self._make_tag_path(\u0027network\u0027, \u0027myid\u0027, \u0027red\u0027)"},{"line_number":129,"context_line":"        args \u003d [\u0027--resource-type\u0027, \u0027network\u0027, \u0027--tag\u0027, \u0027red\u0027]"},{"line_number":130,"context_line":"        self.assertRaises(exceptions.CommandError, self._test_tag_operation,"},{"line_number":131,"context_line":"                          cmd, path, \u0027DELETE\u0027, args, \"tag-remove\")"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_no_tag(self):"},{"line_number":134,"context_line":"        cmd \u003d tag.AddTag(test_cli20.MyApp(sys.stdout), None)"},{"line_number":135,"context_line":"        path \u003d self._make_tag_path(\u0027network\u0027, \u0027myid\u0027, \u0027red\u0027)"},{"line_number":136,"context_line":"        args \u003d [\u0027--resource-type\u0027, \u0027network\u0027, \u0027--resource\u0027, \u0027myid\u0027]"},{"line_number":137,"context_line":"        self.assertRaises(exceptions.CommandError, self._test_tag_operation,"},{"line_number":138,"context_line":"                          cmd, path, \u0027PUT\u0027, args, \"tag-add\")"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_no_tags(self):"},{"line_number":141,"context_line":"        cmd \u003d tag.ReplaceTag(test_cli20.MyApp(sys.stdout), None)"},{"line_number":142,"context_line":"        path \u003d self._make_tags_path(\u0027network\u0027, \u0027myid\u0027)"},{"line_number":143,"context_line":"        args \u003d [\u0027--resource-type\u0027, \u0027network\u0027, \u0027--resource\u0027, \u0027myid\u0027]"},{"line_number":144,"context_line":"        body \u003d {\u0027tags\u0027: [\u0027red\u0027, \u0027blue\u0027]}"},{"line_number":145,"context_line":"        self.assertRaises(exceptions.CommandError, self._test_tag_operation,"},{"line_number":146,"context_line":"                          cmd, path, \u0027PUT\u0027, args, \"tag-replace\", body)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def test_no_tag_nor_all(self):"},{"line_number":149,"context_line":"        cmd \u003d tag.RemoveTag(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":6,"id":"7af24918_2da8241f","line":146,"range":{"start_line":111,"start_character":0,"end_line":146,"end_character":70},"updated":"2016-03-02 02:31:21.000000000","message":"The tests are unnecessary because these options use \"choices\" and \"required\".","commit_id":"6fdf40ac1b1c2f76ee99abb17296e86135e11191"}]}
