)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds trunk api for neutronclient."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a patch for vlan-aware-vms api for neutron-client."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: blueprint vlan-aware-vms"},{"line_number":12,"context_line":"Signed-off-by: SongmingYan \u003cneutron@zte.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9aed3d3a_f6129861","line":9,"updated":"2016-02-26 11:56:12.000000000","message":"Please add release-notes and DocImpact tag","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This contains the create, delete, update, show, and list client APIs for"},{"line_number":12,"context_line":"the new Trunk and Subport API."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    The API syntax is:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"    trunk-create"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_79089d28","line":14,"updated":"2016-03-01 08:27:45.000000000","message":"IMO, no need mentioning these cmds","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"    trunk-list"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    trunk-show"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    subport-create"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_d511af5e","line":20,"updated":"2016-03-01 08:27:45.000000000","message":"update and delete missing.","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    subport-show"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    subport-delete"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"Note: Use trunk-create to create a trunk before use subport-ceate"},{"line_number":33,"context_line":"      to create a bubport. Subport in the same trunk must have"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_951ba780","line":30,"updated":"2016-03-01 08:27:45.000000000","message":"mentioned twice..","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      to create a bubport. Subport in the same trunk must have"},{"line_number":34,"context_line":"      different segment-id."},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DocImpact"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implements: blueprint vlan-aware-vms"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_7956dd06","line":36,"updated":"2016-03-01 08:27:45.000000000","message":"Write a word about the change. This is required..http://osdir.com/ml/openstack-dev/2016-03/msg00000.html","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"DocImpact"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implements: blueprint vlan-aware-vms"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Change-Id: I126885eb71d44f4e6727be113818c5b0841773dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_19cd1131","line":38,"updated":"2016-03-01 08:27:45.000000000","message":"Please add a release notes..\nhttp://docs.openstack.org/developer/reno/usage.html#creating-new-release-notes","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e1482820f9d330e3a0dfbebd9496123cde543881","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Implements: blueprint vlan-aware-vms"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"Change-Id: I126885eb71d44f4e6727be113818c5b0841773dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aed3d3a_79b53d7c","line":40,"updated":"2016-03-01 08:29:57.000000000","message":"Can you please also make this patch \u0027Depands-On: I22fe24c72169b6a401519637aab81dba36921d9a\u0027","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     SongmingYan \u003cyan.songming@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-03-23 06:00:08 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Adds trunk api for neutronclient."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is a patch for vlan-aware-vms api for neutron-client."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba0121b8_7359c534","line":7,"updated":"2016-04-01 07:18:47.000000000","message":"As the patch adds the support for both trunk and subport API\u0027s it\u0027s better to add \u0027subport\u0027 in the commit msg as well Or you can just say \"Adding neutronclient support for vlan-aware-vms functionality\"","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"the new Trunk and Subport API."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: Use trunk-create to create a trunk before use subport-ceate"},{"line_number":15,"context_line":"      to create a bubport. Subport in the same trunk must have"},{"line_number":16,"context_line":"      different segment-id."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact: Add neutron trunk and subport api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba0121b8_f345d542","line":15,"updated":"2016-04-01 07:18:47.000000000","message":"nit: %s/bubport/subport/g","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact: Add neutron trunk and subport api."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Implements: blueprint vlan-aware-vms"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I126885eb71d44f4e6727be113818c5b0841773dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"ba0121b8_d3b2514b","line":20,"updated":"2016-04-01 07:18:47.000000000","message":"Please add Depends-On: Server\u0027s Patch Change-ID.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"}],"neutronclient/neutron/v2_0/trunk.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_bc7a4f75","line":1,"updated":"2016-02-23 07:01:07.000000000","message":"2012? \n2016!","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"ffae9f75fc6a3a2b22e0007c1b554e4a8e1d6743","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_dc1cf0c3","line":1,"in_reply_to":"bae84128_bc7a4f75","updated":"2016-02-25 02:16:16.000000000","message":"Done","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"9acf9eabc745df64fdeca0a12587ebb342c47acf","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"from neutronclient.i18n import _"},{"line_number":17,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_8576b203","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":18},"updated":"2016-02-24 15:27:52.000000000","message":"from neutronclient._i18n import _","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"ffae9f75fc6a3a2b22e0007c1b554e4a8e1d6743","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"from neutronclient.i18n import _"},{"line_number":17,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_5c8740d7","line":16,"range":{"start_line":16,"start_character":5,"end_line":16,"end_character":18},"in_reply_to":"bae84128_8576b203","updated":"2016-02-25 02:16:16.000000000","message":"Done","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Show information of a given trunk.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    resource \u003d \u0027trunk\u0027"},{"line_number":33,"context_line":"    allow_names \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class UpdateTrunk(neutronV20.UpdateCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_7165901c","line":33,"updated":"2016-02-23 07:01:07.000000000","message":"why is the allow_names False, cant the user search the trunk using the name, when user has the option to specify the Name attribute in Create/Update","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20000,"name":"Songming Yan","email":"yan.songming@zte.com.cn","username":"SonmingYan.zte"},"change_message_id":"12426ac7ec4623861b120cb635ef6306869c45c9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    \"\"\"Show information of a given trunk.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    resource \u003d \u0027trunk\u0027"},{"line_number":33,"context_line":"    allow_names \u003d False"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"class UpdateTrunk(neutronV20.UpdateCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_6941a20b","line":33,"in_reply_to":"bae84128_7165901c","updated":"2016-02-26 05:59:37.000000000","message":"Done","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"            \u0027name\u0027: parsed_args.name}}"},{"line_number":49,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":50,"context_line":"                               [\u0027name\u0027])"},{"line_number":51,"context_line":"        return body"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class CreateTrunk(neutronV20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_312e68a5","line":51,"updated":"2016-02-23 07:01:07.000000000","message":"although it is not an issue, but ideally, you can change the above code to a more neutronclient standard:\n\n\n body \u003d {\u0027name\u0027: parsed_args.name}\n return {self.resource:body}\n\nAnd you do not need to call update_dict here.\nupdate_dict updates the value of name in Line #49-50 into the \"body\" variable.\nHowever, you have already done it in Line#48.","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"            help\u003d_(\u0027Name of trunk to create.\u0027))"},{"line_number":63,"context_line":"        parser.add_argument("},{"line_number":64,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":65,"context_line":"            help\u003d_(\u0027Port ID or name this trunk belongs to.\u0027))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def args2body(self, parsed_args):"},{"line_number":68,"context_line":"        body \u003d {\u0027trunk\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_51516c35","line":65,"updated":"2016-02-23 07:01:07.000000000","message":"change it to \"ID or name of the port this trunk belongs to.\"","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    def args2body(self, parsed_args):"},{"line_number":68,"context_line":"        body \u003d {\u0027trunk\u0027: {"},{"line_number":69,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":70,"context_line":"            \u0027port_id\u0027: parsed_args.port_id}}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        return body"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_511fac6b","line":70,"updated":"2016-02-23 07:01:07.000000000","message":"Same as the comment given in Line#51","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"9acf9eabc745df64fdeca0a12587ebb342c47acf","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    resource \u003d \u0027trunk\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class ListSubport(neutronV20.ListCommand):"},{"line_number":82,"context_line":"    \"\"\"List trunks that belong to a given tenant.\"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    resource \u003d \u0027subport\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_2587e6b5","line":81,"updated":"2016-02-24 15:27:52.000000000","message":"Suggest to create separate file for the \u0027subport\u0027 functionality.","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"afab3ed8f5fa75a590f606d926ab478ef61faf1d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    resource \u003d \u0027trunk\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class ListSubport(neutronV20.ListCommand):"},{"line_number":82,"context_line":"    \"\"\"List trunks that belong to a given tenant.\"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    resource \u003d \u0027subport\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_65b540cf","line":81,"in_reply_to":"bae84128_0f629cad","updated":"2016-02-25 07:52:02.000000000","message":"I would suggest you can have 2 separate files in a folder...like qos..","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"ffae9f75fc6a3a2b22e0007c1b554e4a8e1d6743","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    resource \u003d \u0027trunk\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"class ListSubport(neutronV20.ListCommand):"},{"line_number":82,"context_line":"    \"\"\"List trunks that belong to a given tenant.\"\"\""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    resource \u003d \u0027subport\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_0f629cad","line":81,"in_reply_to":"bae84128_2587e6b5","updated":"2016-02-25 02:16:16.000000000","message":"Because trunk and subport are different part of a whole function, I think it\u0027s OK to set them in same file.","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    sorting_support \u003d True"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"class ShowSubport(neutronV20.ShowCommand):"},{"line_number":92,"context_line":"    \"\"\"Show information of a given trunk.\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    resource \u003d \u0027subport\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_f10ec039","line":91,"updated":"2016-02-23 07:01:07.000000000","message":"Ideally this should be a separate file","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    \"\"\"Show information of a given trunk.\"\"\""},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":95,"context_line":"    allow_names \u003d False"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class CreateSubport(neutronV20.CreateCommand):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_3105c813","line":95,"updated":"2016-02-23 07:01:07.000000000","message":"same comment","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"ffae9f75fc6a3a2b22e0007c1b554e4a8e1d6743","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class CreateSubport(neutronV20.CreateCommand):"},{"line_number":99,"context_line":"    \"\"\"Create a trunk for a given tenant.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_7c6cc408","line":99,"updated":"2016-02-25 02:16:16.000000000","message":"\"\"\"Create a subport for a given trunk.\"\"\"","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20000,"name":"Songming Yan","email":"yan.songming@zte.com.cn","username":"SonmingYan.zte"},"change_message_id":"12426ac7ec4623861b120cb635ef6306869c45c9","unresolved":false,"context_lines":[{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"class CreateSubport(neutronV20.CreateCommand):"},{"line_number":99,"context_line":"    \"\"\"Create a trunk for a given tenant.\"\"\""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":102,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_695882fb","line":99,"in_reply_to":"bae84128_7c6cc408","updated":"2016-02-26 05:59:37.000000000","message":"Done","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            help\u003d_(\u0027segmentation ID of this subport.\u0027))"},{"line_number":116,"context_line":"        parser.add_argument("},{"line_number":117,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION TYPE\u0027,"},{"line_number":118,"context_line":"            help\u003d_(\u0027segmentation Type of this subport.\u0027))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def args2body(self, parsed_args):"},{"line_number":121,"context_line":"        body \u003d {\u0027subport\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_9c230ba7","line":118,"updated":"2016-02-23 07:01:07.000000000","message":"Lets capitalize the S of segmentation in Line #115, 118 and 121","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20000,"name":"Songming Yan","email":"yan.songming@zte.com.cn","username":"SonmingYan.zte"},"change_message_id":"12426ac7ec4623861b120cb635ef6306869c45c9","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            help\u003d_(\u0027segmentation ID of this subport.\u0027))"},{"line_number":116,"context_line":"        parser.add_argument("},{"line_number":117,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION TYPE\u0027,"},{"line_number":118,"context_line":"            help\u003d_(\u0027segmentation Type of this subport.\u0027))"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def args2body(self, parsed_args):"},{"line_number":121,"context_line":"        body \u003d {\u0027subport\u0027: {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_e96c929e","line":118,"in_reply_to":"bae84128_9c230ba7","updated":"2016-02-26 05:59:37.000000000","message":"Done","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def args2body(self, parsed_args):"},{"line_number":121,"context_line":"        body \u003d {\u0027subport\u0027: {"},{"line_number":122,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":123,"context_line":"            \u0027port_id\u0027: parsed_args.port_id,"},{"line_number":124,"context_line":"            \u0027trunk_id\u0027: parsed_args.trunk_id,"},{"line_number":125,"context_line":"            \u0027segmentation_id\u0027: parsed_args.segmentation_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_bc6c0fd1","line":122,"updated":"2016-02-23 07:01:07.000000000","message":"Better use this, to save some lines\n\n\n body \u003d {}\n neutronV20.update_dict(parsed_args, body[self.resource],\n                        [\u0027name\u0027, \u0027port_id\u0027, \u0027trunk_id\u0027,\n                         \u0027segmentation_id\u0027, \u0027segmentation_type\u0027 ])","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20000,"name":"Songming Yan","email":"yan.songming@zte.com.cn","username":"SonmingYan.zte"},"change_message_id":"12426ac7ec4623861b120cb635ef6306869c45c9","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def args2body(self, parsed_args):"},{"line_number":121,"context_line":"        body \u003d {\u0027subport\u0027: {"},{"line_number":122,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":123,"context_line":"            \u0027port_id\u0027: parsed_args.port_id,"},{"line_number":124,"context_line":"            \u0027trunk_id\u0027: parsed_args.trunk_id,"},{"line_number":125,"context_line":"            \u0027segmentation_id\u0027: parsed_args.segmentation_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_090a96d2","line":122,"in_reply_to":"bae84128_bc6c0fd1","updated":"2016-02-26 05:59:37.000000000","message":"Done","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def args2body(self, parsed_args):"},{"line_number":142,"context_line":"        body \u003d {\u0027subport\u0027: {"},{"line_number":143,"context_line":"            \u0027name\u0027: parsed_args.name}}"},{"line_number":144,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":145,"context_line":"                               [\u0027name\u0027])"},{"line_number":146,"context_line":"        return body"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_1cb53b30","line":144,"updated":"2016-02-23 07:01:07.000000000","message":"Same comment as given for UpdateTrunk","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20000,"name":"Songming Yan","email":"yan.songming@zte.com.cn","username":"SonmingYan.zte"},"change_message_id":"12426ac7ec4623861b120cb635ef6306869c45c9","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    def args2body(self, parsed_args):"},{"line_number":142,"context_line":"        body \u003d {\u0027subport\u0027: {"},{"line_number":143,"context_line":"            \u0027name\u0027: parsed_args.name}}"},{"line_number":144,"context_line":"        neutronV20.update_dict(parsed_args, body[self.resource],"},{"line_number":145,"context_line":"                               [\u0027name\u0027])"},{"line_number":146,"context_line":"        return body"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_49149ef4","line":144,"in_reply_to":"bae84128_1cb53b30","updated":"2016-02-26 05:59:37.000000000","message":"Done","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"}],"neutronclient/neutron/v2_0/trunk/subport.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_dcf33309","line":1,"updated":"2016-02-26 11:56:12.000000000","message":"plz use your company details","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class ListSubport(neutronV20.ListCommand):"},{"line_number":20,"context_line":"    \"\"\"List trunks that belong to a given tenant.\"\"\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":23,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027name\u0027, \u0027port_id\u0027, \u0027trunk_id\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_3c321ff2","line":20,"updated":"2016-02-26 11:56:12.000000000","message":"nit: plz use subport instead of trunk.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class ShowSubport(neutronV20.ShowCommand):"},{"line_number":30,"context_line":"    \"\"\"Show information of a given trunk.\"\"\""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_5c3563d8","line":30,"updated":"2016-02-26 11:56:12.000000000","message":"nit: plz use subport instead of trunk.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class CreateSubport(neutronV20.CreateCommand):"},{"line_number":36,"context_line":"    \"\"\"Create a trunk for a given tenant.\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_1c3bdbd2","line":36,"updated":"2016-02-26 11:56:12.000000000","message":"nit: plz use subport instead of trunk.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            help\u003d_(\u0027Name of subport to create.\u0027))"},{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":46,"context_line":"            help\u003d_(\u0027Port ID or name this subport refereced.\u0027))"},{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027trunk_id\u0027, metavar\u003d\u0027TRUNK\u0027,"},{"line_number":49,"context_line":"            help\u003d_(\u0027Trunk ID or name this subport belongs to.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_61e6c4b5","line":46,"updated":"2016-02-26 11:56:12.000000000","message":"How about \"ID or name of the port reference by the subport.\"?","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            help\u003d_(\u0027Port ID or name this subport refereced.\u0027))"},{"line_number":47,"context_line":"        parser.add_argument("},{"line_number":48,"context_line":"            \u0027trunk_id\u0027, metavar\u003d\u0027TRUNK\u0027,"},{"line_number":49,"context_line":"            help\u003d_(\u0027Trunk ID or name this subport belongs to.\u0027))"},{"line_number":50,"context_line":"        parser.add_argument("},{"line_number":51,"context_line":"            \u0027segmentation_id\u0027, metavar\u003d\u0027SEGMENTATION ID\u0027,"},{"line_number":52,"context_line":"            help\u003d_(\u0027Segmentation ID of this subport.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_01009833","line":49,"updated":"2016-02-26 11:56:12.000000000","message":"How about \"ID or name of the trunk to which the subport belongs.\"?","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            help\u003d_(\u0027Segmentation ID of this subport.\u0027))"},{"line_number":53,"context_line":"        parser.add_argument("},{"line_number":54,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION TYPE\u0027,"},{"line_number":55,"context_line":"            help\u003d_(\u0027Segmentation Type of this subport.\u0027))"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def args2body(self, parsed_args):"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_c1bb5071","line":55,"updated":"2016-02-26 11:56:12.000000000","message":"How about \"Segmentation-type of the subport.\"?","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        body \u003d {"},{"line_number":60,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":61,"context_line":"            \u0027port_id\u0027: parsed_args.port_id,"},{"line_number":62,"context_line":"            \u0027trunk_id\u0027: parsed_args.trunk_id,"},{"line_number":63,"context_line":"            \u0027segmentation_id\u0027: parsed_args.segmentation_id,"},{"line_number":64,"context_line":"            \u0027segmentation_type\u0027: parsed_args.segmentation_type}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_21783cc4","line":61,"updated":"2016-02-26 11:56:12.000000000","message":"plz note we got do name to id conversion for port_id param.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        body \u003d {"},{"line_number":60,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":61,"context_line":"            \u0027port_id\u0027: parsed_args.port_id,"},{"line_number":62,"context_line":"            \u0027trunk_id\u0027: parsed_args.trunk_id,"},{"line_number":63,"context_line":"            \u0027segmentation_id\u0027: parsed_args.segmentation_id,"},{"line_number":64,"context_line":"            \u0027segmentation_type\u0027: parsed_args.segmentation_type}"},{"line_number":65,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_417f40aa","line":62,"updated":"2016-02-26 11:56:12.000000000","message":"ditto","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class UpdateSubport(neutronV20.UpdateCommand):"},{"line_number":69,"context_line":"    \"\"\"Updates the admin status and description for a specified Trunk.\"\"\""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_9cffeb00","line":69,"updated":"2016-02-26 11:56:12.000000000","message":"Doc string doesn\u0027t match implementation. Plz recheck.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":74,"context_line":"        parser.add_argument("},{"line_number":75,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Name of subport to create.\u0027))"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def args2body(self, parsed_args):"},{"line_number":79,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_015c184a","line":76,"updated":"2016-02-26 11:56:12.000000000","message":"nit: \u0027create\u0027 \u003d\u003d\u003e \u0027update\u0027","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class DeleteSubport(neutronV20.DeleteCommand):"},{"line_number":84,"context_line":"    \"\"\"Delete a given trunk.\"\"\""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    resource \u003d \u0027subport\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_dc20539e","line":84,"updated":"2016-02-26 11:56:12.000000000","message":"nit: plz use subport instead of trunk.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":42,"context_line":"        parser.add_argument("},{"line_number":43,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":44,"context_line":"            help\u003d_(\u0027Name of subport to create.\u0027))"},{"line_number":45,"context_line":"        parser.add_argument("},{"line_number":46,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":47,"context_line":"            help\u003d_(\u0027ID or name of the port reference by the subport.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_59ccb9ba","line":44,"updated":"2016-03-01 08:27:45.000000000","message":"nit: how about adding \u0027the\u0027 before subport?","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        body \u003d {"},{"line_number":61,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":62,"context_line":"            \u0027port_id\u0027: parsed_args.port_id,"},{"line_number":63,"context_line":"            \u0027trunk_id\u0027: parsed_args.trunk_id,"},{"line_number":64,"context_line":"            \u0027segmentation_id\u0027: parsed_args.segmentation_id,"},{"line_number":65,"context_line":"            \u0027segmentation_type\u0027: parsed_args.segmentation_type}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_193231a7","line":62,"updated":"2016-03-01 08:27:45.000000000","message":"You need to get the port-id.. Please note user may enter port name as well..\n\nif parsed_args.port_id:\n    port-id \u003d neutronv20.find_resourceid_by_name_or_id(client,\u0027port\u0027, parsed_args.port_id)","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        body \u003d {"},{"line_number":61,"context_line":"            \u0027name\u0027: parsed_args.name,"},{"line_number":62,"context_line":"            \u0027port_id\u0027: parsed_args.port_id,"},{"line_number":63,"context_line":"            \u0027trunk_id\u0027: parsed_args.trunk_id,"},{"line_number":64,"context_line":"            \u0027segmentation_id\u0027: parsed_args.segmentation_id,"},{"line_number":65,"context_line":"            \u0027segmentation_type\u0027: parsed_args.segmentation_type}"},{"line_number":66,"context_line":"        return {self.resource: body}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_b94225ac","line":63,"updated":"2016-03-01 08:27:45.000000000","message":"ditto","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":75,"context_line":"        parser.add_argument("},{"line_number":76,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":77,"context_line":"            help\u003d_(\u0027Name of subport to update.\u0027))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def args2body(self, parsed_args):"},{"line_number":80,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_b9d18525","line":77,"updated":"2016-03-01 08:27:45.000000000","message":"nit: how about adding \u0027the\u0027 before subport?","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":44,"context_line":"            help\u003d_(\u0027Name of the subport to create.\u0027))"},{"line_number":45,"context_line":"        parser.add_argument("},{"line_number":46,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":47,"context_line":"            help\u003d_(\u0027ID or name of the port reference by the subport.\u0027))"},{"line_number":48,"context_line":"        parser.add_argument("},{"line_number":49,"context_line":"            \u0027trunk_id\u0027, metavar\u003d\u0027TRUNK\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_aee5b609","line":46,"updated":"2016-04-01 07:18:47.000000000","message":"Let\u0027s just say \u0027port\u0027 instead of \u0027port_id as this parameter can take ID \u0026 name both.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":47,"context_line":"            help\u003d_(\u0027ID or name of the port reference by the subport.\u0027))"},{"line_number":48,"context_line":"        parser.add_argument("},{"line_number":49,"context_line":"            \u0027trunk_id\u0027, metavar\u003d\u0027TRUNK\u0027,"},{"line_number":50,"context_line":"            help\u003d_(\u0027ID or name of the trunk to which the subport belongs.\u0027))"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027segmentation_id\u0027, metavar\u003d\u0027SEGMENTATION ID\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_4ebdfad6","line":49,"updated":"2016-04-01 07:18:47.000000000","message":"Let\u0027s just say \u0027trunk\u0027 instead of \u0027trunk_id as this parameter can take ID \u0026 name both.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027trunk_id\u0027, metavar\u003d\u0027TRUNK\u0027,"},{"line_number":50,"context_line":"            help\u003d_(\u0027ID or name of the trunk to which the subport belongs.\u0027))"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027segmentation_id\u0027, metavar\u003d\u0027SEGMENTATION ID\u0027,"},{"line_number":53,"context_line":"            help\u003d_(\u0027Segmentation ID of this subport.\u0027))"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION TYPE\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_b3707d73","line":52,"updated":"2016-04-01 07:18:47.000000000","message":"Would you like to use \u0027-\u0027 in the metavar as well?","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            help\u003d_(\u0027ID or name of the trunk to which the subport belongs.\u0027))"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027segmentation_id\u0027, metavar\u003d\u0027SEGMENTATION ID\u0027,"},{"line_number":53,"context_line":"            help\u003d_(\u0027Segmentation ID of this subport.\u0027))"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION TYPE\u0027,"},{"line_number":56,"context_line":"            help\u003d_(\u0027Segmentation-Type of this subport.\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_935739c9","line":53,"updated":"2016-04-01 07:18:47.000000000","message":"How about \u0027Segmentation-ID\u0027? It will make it consistent with \u0027Segmentation-Type\u0027 help information.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027segmentation_id\u0027, metavar\u003d\u0027SEGMENTATION ID\u0027,"},{"line_number":53,"context_line":"            help\u003d_(\u0027Segmentation ID of this subport.\u0027))"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION TYPE\u0027,"},{"line_number":56,"context_line":"            help\u003d_(\u0027Segmentation-Type of this subport.\u0027))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_b3f7ddd1","line":55,"updated":"2016-04-01 07:18:47.000000000","message":"Better to use \u0027-\u0027 between 2 words in the metavar. This will make it consistent throughout.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            help\u003d_(\u0027Segmentation ID of this subport.\u0027))"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION TYPE\u0027,"},{"line_number":56,"context_line":"            help\u003d_(\u0027Segmentation-Type of this subport.\u0027))"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def args2body(self, parsed_args):"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_d3237154","line":56,"updated":"2016-04-01 07:18:47.000000000","message":"Few of the help msg says \u0027the subport\u0027 while other says \u0027this subport\u0027. Let\u0027s be consistent.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class UpdateSubport(neutronV20.UpdateCommand):"},{"line_number":80,"context_line":"    \"\"\"Updates the name for a specified Subport.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_eee16e2b","line":80,"updated":"2016-04-01 07:18:47.000000000","message":"Lets modify the Doc String as \"Update Subport\u0027s information\". Let\u0027s not say \u0027name\u0027 in the Doc string. We might need to extend it in the future.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"948592f86a366abf865731301c758eeac0fc47b2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                                                           )"},{"line_number":65,"context_line":"        trunk_id \u003d neutronV20.find_resourceid_by_name_or_id(neutron_client,"},{"line_number":66,"context_line":"                                                            \u0027trunk\u0027,"},{"line_number":67,"context_line":"                                                            parsed_args."},{"line_number":68,"context_line":"                                                            trunk"},{"line_number":69,"context_line":"                                                            )"},{"line_number":70,"context_line":"        body \u003d {"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_e4ba8d09","line":67,"updated":"2016-04-19 10:34:00.000000000","message":"improper alignment. plz have \"parsed_args.trunk\" on the same line.","commit_id":"ac237ad8b5ab0fdcf07f31c2d9aa6d03c7688e43"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"948592f86a366abf865731301c758eeac0fc47b2","unresolved":false,"context_lines":[{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"class UpdateSubport(neutronV20.UpdateCommand):"},{"line_number":80,"context_line":"    \"\"\"Updates the name for a specified Subport.\"\"\""},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_a46415e5","line":80,"updated":"2016-04-19 10:34:00.000000000","message":"Address PS4 comment.","commit_id":"ac237ad8b5ab0fdcf07f31c2d9aa6d03c7688e43"},{"author":{"_account_id":20566,"name":"BaiLinZhang","email":"bailin.zhang@hotmail.com","username":"bailin.zhang"},"change_message_id":"f134f71890539974eebdd5b74322df7e90eab602","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027trunk\u0027, metavar\u003d\u0027TRUNK\u0027,"},{"line_number":50,"context_line":"            help\u003d_(\u0027ID or name of the trunk to which the subport belongs.\u0027))"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027segmentation_id\u0027, metavar\u003d\u0027SEGMENTATIO-ID\u0027,"},{"line_number":53,"context_line":"            help\u003d_(\u0027Segmentation-ID of the subport.\u0027))"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION-TYPE\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_64f819c4","line":52,"range":{"start_line":52,"start_character":40,"end_line":52,"end_character":51},"updated":"2016-05-21 04:53:33.000000000","message":"metavar\u003d\u0027SEGMENTATIO-ID\u0027 change to metavar\u003d\u0027SEGMENTATION-ID\u0027?","commit_id":"35b5fc07e1a354b8978d5425445fc08c77dc7b68"},{"author":{"_account_id":20000,"name":"Songming Yan","email":"yan.songming@zte.com.cn","username":"SonmingYan.zte"},"change_message_id":"8515c98518547ad0a05e82820adc5b2b06b67b49","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            \u0027trunk\u0027, metavar\u003d\u0027TRUNK\u0027,"},{"line_number":50,"context_line":"            help\u003d_(\u0027ID or name of the trunk to which the subport belongs.\u0027))"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027segmentation_id\u0027, metavar\u003d\u0027SEGMENTATIO-ID\u0027,"},{"line_number":53,"context_line":"            help\u003d_(\u0027Segmentation-ID of the subport.\u0027))"},{"line_number":54,"context_line":"        parser.add_argument("},{"line_number":55,"context_line":"            \u0027segmentation_type\u0027, metavar\u003d\u0027SEGMENTATION-TYPE\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_169a516e","line":52,"range":{"start_line":52,"start_character":40,"end_line":52,"end_character":51},"in_reply_to":"bab6814e_64f819c4","updated":"2016-05-26 03:25:54.000000000","message":"Done","commit_id":"35b5fc07e1a354b8978d5425445fc08c77dc7b68"},{"author":{"_account_id":20566,"name":"BaiLinZhang","email":"bailin.zhang@hotmail.com","username":"bailin.zhang"},"change_message_id":"f134f71890539974eebdd5b74322df7e90eab602","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class UpdateSubport(neutronV20.UpdateCommand):"},{"line_number":79,"context_line":"    \"\"\"Updates the name for a specified Subport.\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_042e6d42","line":79,"range":{"start_line":79,"start_character":7,"end_line":79,"end_character":14},"updated":"2016-05-21 04:53:33.000000000","message":"updates take out“s”","commit_id":"35b5fc07e1a354b8978d5425445fc08c77dc7b68"},{"author":{"_account_id":20000,"name":"Songming Yan","email":"yan.songming@zte.com.cn","username":"SonmingYan.zte"},"change_message_id":"8515c98518547ad0a05e82820adc5b2b06b67b49","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class UpdateSubport(neutronV20.UpdateCommand):"},{"line_number":79,"context_line":"    \"\"\"Updates the name for a specified Subport.\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    resource \u003d \u0027subport\u0027"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_b67f0516","line":79,"range":{"start_line":79,"start_character":7,"end_line":79,"end_character":14},"in_reply_to":"bab6814e_042e6d42","updated":"2016-05-26 03:25:54.000000000","message":"Done","commit_id":"35b5fc07e1a354b8978d5425445fc08c77dc7b68"}],"neutronclient/neutron/v2_0/trunk/trunk.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_fcda7777","line":1,"updated":"2016-02-26 11:56:12.000000000","message":"ditto","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":41,"context_line":"        parser.add_argument("},{"line_number":42,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"            help\u003d_(\u0027Name of trunk to create.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def args2body(self, parsed_args):"},{"line_number":46,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_5c4c4370","line":43,"updated":"2016-02-26 11:56:12.000000000","message":"nit: should be \u0027update\u0027 instead of \u0027create\u0027.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            help\u003d_(\u0027Name of trunk to create.\u0027))"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":61,"context_line":"            help\u003d_(\u0027Port ID or name of port this trunk belongs to.\u0027))"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def args2body(self, parsed_args):"},{"line_number":64,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name, \u0027port_id\u0027: parsed_args.port_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_3cb7bf3a","line":61,"updated":"2016-02-26 11:56:12.000000000","message":"How about \"ID or name of the port to which the trunk belongs.\"?","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            help\u003d_(\u0027Port ID or name of port this trunk belongs to.\u0027))"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def args2body(self, parsed_args):"},{"line_number":64,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name, \u0027port_id\u0027: parsed_args.port_id}"},{"line_number":65,"context_line":"        return {self.resource: body}"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_bc810f4d","line":64,"updated":"2016-02-26 11:56:12.000000000","message":"plz move \"\u0027port_id\u0027: parsed_args.port_id\" to the next line for better readability.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 ZTE Corporation.."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_f5d953f4","line":1,"updated":"2016-03-01 08:27:45.000000000","message":"nit: extra period at the end","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":41,"context_line":"        parser.add_argument("},{"line_number":42,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":43,"context_line":"            help\u003d_(\u0027Name of trunk to update.\u0027))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def args2body(self, parsed_args):"},{"line_number":46,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_997ac122","line":43,"updated":"2016-03-01 08:27:45.000000000","message":"nit: how about adding \u0027the\u0027 before trunk?","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return {self.resource: body}"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class CreateTrunk(neutronV20.CreateCommand):"},{"line_number":51,"context_line":"    \"\"\"Create a trunk for a given tenant.\"\"\""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    resource \u003d \u0027trunk\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_39b9f5cc","line":50,"updated":"2016-03-01 08:27:45.000000000","message":"super nit: Let\u0027s place create functionality above update..","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":56,"context_line":"        parser.add_argument("},{"line_number":57,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":58,"context_line":"            help\u003d_(\u0027Name of trunk to create.\u0027))"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":61,"context_line":"            help\u003d_(\u0027ID or name of the port to which the trunk belongs\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_198eb12d","line":58,"updated":"2016-03-01 08:27:45.000000000","message":"nit: how about adding \u0027the\u0027 before trunk?","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            help\u003d_(\u0027Name of trunk to create.\u0027))"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":61,"context_line":"            help\u003d_(\u0027ID or name of the port to which the trunk belongs\u0027))"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def args2body(self, parsed_args):"},{"line_number":64,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_190a318a","line":61,"updated":"2016-03-01 08:27:45.000000000","message":"How about \u0027ID or name of the port belonging to this trunk.\u0027?\n\nCan we associate multiple ports to a trunk? If yes, then why we are not accepting list of ports as input?","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"350dac1587297be014637ae99677a7ecff141c09","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def args2body(self, parsed_args):"},{"line_number":64,"context_line":"        body \u003d {\u0027name\u0027: parsed_args.name,"},{"line_number":65,"context_line":"                \u0027port_id\u0027: parsed_args.port_id}"},{"line_number":66,"context_line":"        return {self.resource: body}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_191871d2","line":65,"updated":"2016-03-01 08:27:45.000000000","message":"You need to get the port-id.. Please note user may enter port name as well..\n\nif parsed_args.port_id:\n    port-id \u003d neutronv20.find_resourceid_by_name_or_id(client,\u0027port\u0027, parsed_args.port_id)","commit_id":"5011b4370cf0ef1c3f5bb34fdff8637a5602f6d7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class UpdateTrunk(neutronV20.UpdateCommand):"},{"line_number":36,"context_line":"    \"\"\"Updates the admin status and description for a specified Trunk.\"\"\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    resource \u003d \u0027trunk\u0027"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_0e55c2c4","line":36,"updated":"2016-04-01 07:18:47.000000000","message":"Lets modify the Doc String as \"Update Trunk\u0027s information\". Let\u0027s not be specific.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            \u0027name\u0027, metavar\u003d\u0027NAME\u0027,"},{"line_number":58,"context_line":"            help\u003d_(\u0027Name of the trunk to create.\u0027))"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027port_id\u0027, metavar\u003d\u0027PORT\u0027,"},{"line_number":61,"context_line":"            help\u003d_(\u0027ID or name of the port belonging to this trunk.\u0027))"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_4ed69a28","line":60,"updated":"2016-04-01 07:18:47.000000000","message":"Let\u0027s just say \u0027port\u0027 instead of \u0027port_id as this parameter can take ID \u0026 name both.","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"}],"neutronclient/shell.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    \u0027trunk-update\u0027: trunk.UpdateTrunk,"},{"line_number":173,"context_line":"    \u0027trunk-create\u0027: trunk.CreateTrunk,"},{"line_number":174,"context_line":"    \u0027trunk-delete\u0027: trunk.DeleteTrunk,"},{"line_number":175,"context_line":"    \u0027subport-list\u0027: trunk.ListSubport,"},{"line_number":176,"context_line":"    \u0027subport-show\u0027: trunk.ShowSubport,"},{"line_number":177,"context_line":"    \u0027subport-update\u0027: trunk.UpdateSubport,"},{"line_number":178,"context_line":"    \u0027subport-create\u0027: trunk.CreateSubport,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_fcdfb766","line":175,"updated":"2016-02-23 07:01:07.000000000","message":"Ideally trunk should not be related to subport.Subport code can be provided in a new file","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"}],"neutronclient/tests/unit/test_cli20_trunk.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"6350dd6305be1088329bdc979e9df91d4664c78a","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        args \u003d [myid]\r"},{"line_number":81,"context_line":"        self._test_delete_resource(resource, cmd, myid, args)\r"},{"line_number":82,"context_line":"\r"},{"line_number":83,"context_line":"    def test_list_subports(self):\r"},{"line_number":84,"context_line":"        contents \u003d {\u0027subports\u0027: [{\u0027id\u0027: \u0027myid\u0027}]}\r"},{"line_number":85,"context_line":"        args \u003d [\u0027-f\u0027, \u0027json\u0027]\r"},{"line_number":86,"context_line":"        resources \u003d \"subports\"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_bcc88fa9","line":83,"updated":"2016-02-23 07:01:07.000000000","message":"no test for update_subport?","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"},{"author":{"_account_id":20000,"name":"Songming Yan","email":"yan.songming@zte.com.cn","username":"SonmingYan.zte"},"change_message_id":"12426ac7ec4623861b120cb635ef6306869c45c9","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        args \u003d [myid]\r"},{"line_number":81,"context_line":"        self._test_delete_resource(resource, cmd, myid, args)\r"},{"line_number":82,"context_line":"\r"},{"line_number":83,"context_line":"    def test_list_subports(self):\r"},{"line_number":84,"context_line":"        contents \u003d {\u0027subports\u0027: [{\u0027id\u0027: \u0027myid\u0027}]}\r"},{"line_number":85,"context_line":"        args \u003d [\u0027-f\u0027, \u0027json\u0027]\r"},{"line_number":86,"context_line":"        resources \u003d \"subports\"\r"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_c1c7e243","line":83,"in_reply_to":"bae84128_bcc88fa9","updated":"2016-02-26 05:59:37.000000000","message":"i don\u0027t this this subport needto update","commit_id":"b3d3abd549924cc80f573a62314363032f34d352"}],"neutronclient/tests/unit/trunk/__init__.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"__author__ \u003d \u0027root\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_1cc59b8d","line":1,"updated":"2016-02-26 11:56:12.000000000","message":"why \"__author__ \u003d \u0027root\u0027\" is required?","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"}],"neutronclient/tests/unit/trunk/test_cli20_subport.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"__author__ \u003d \u0027root\u0027"},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_bc462f21","line":1,"updated":"2016-02-26 11:56:12.000000000","message":"No needed plz remove and add copyright section.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        args \u003d [myid]"},{"line_number":68,"context_line":"        self._test_delete_resource(resource, cmd, myid, args)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def test_create_subport(self):"},{"line_number":71,"context_line":"        # Create subport:trunkid."},{"line_number":72,"context_line":"        resource \u003d \u0027subport\u0027"},{"line_number":73,"context_line":"        cmd \u003d subport.CreateSubport(test_cli20.MyApp(sys.stdout), None)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_5c5603d3","line":70,"updated":"2016-02-26 11:56:12.000000000","message":"I would suggest to re-arrange the test as create, update, list, show and delete.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"                           segmentationtype]"},{"line_number":85,"context_line":"        self._test_create_resource(resource, cmd, name, myid, args,"},{"line_number":86,"context_line":"                                   position_names, position_values,"},{"line_number":87,"context_line":"                                   )"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_7c6307b2","line":87,"updated":"2016-02-26 11:56:12.000000000","message":"\u0027)\u0027 can be placed in the above line. IMO, newline is not required.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"}],"neutronclient/tests/unit/trunk/test_cli20_trunk.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved\r"},{"line_number":2,"context_line":"#\r"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_9c052bc4","line":1,"updated":"2016-02-26 11:56:12.000000000","message":"plz add copyright","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"c7c8c56e4b251704d1e3f366f9231711b0e55fd1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutronclient.tests.unit import test_cli20\r"},{"line_number":21,"context_line":"\r"},{"line_number":22,"context_line":"\r"},{"line_number":23,"context_line":"class CLITestV20Trunk(test_cli20.CLITestV20Base):\r"},{"line_number":24,"context_line":"\r"},{"line_number":25,"context_line":"    def setUp(self):\r"},{"line_number":26,"context_line":"        \"\"\"Prepare test environment.\"\"\"\r"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_bc2bcf2f","line":23,"updated":"2016-02-26 11:56:12.000000000","message":"I would suggest to re-arrange the test as create, update, list, show and delete.","commit_id":"a6148e6bddfd4e20d76e4632d7217246acd7a2e9"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"948592f86a366abf865731301c758eeac0fc47b2","unresolved":false,"context_lines":[{"line_number":663,"context_line":""},{"line_number":664,"context_line":"    def list_trunks(self, retrieve_all\u003dTrue, **_params):"},{"line_number":665,"context_line":"        \"\"\"Fetches a list of all trunk for a tenant.\"\"\""},{"line_number":666,"context_line":"        # Pass filters in \"params\" argument to do_request"},{"line_number":667,"context_line":"        return self.list(\u0027trunks\u0027, self.trunks_path, retrieve_all,"},{"line_number":668,"context_line":"                         **_params)"},{"line_number":669,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_e49bad70","line":666,"updated":"2016-04-19 10:34:00.000000000","message":"Is this comment is relevant?","commit_id":"ac237ad8b5ab0fdcf07f31c2d9aa6d03c7688e43"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"948592f86a366abf865731301c758eeac0fc47b2","unresolved":false,"context_lines":[{"line_number":685,"context_line":""},{"line_number":686,"context_line":"    def list_subports(self, retrieve_all\u003dTrue, **_params):"},{"line_number":687,"context_line":"        \"\"\"Fetches a list of all subport for a tenant.\"\"\""},{"line_number":688,"context_line":"        # Pass filters in \"params\" argument to do_request"},{"line_number":689,"context_line":"        return self.list(\u0027subports\u0027, self.subports_path, retrieve_all,"},{"line_number":690,"context_line":"                         **_params)"},{"line_number":691,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_24a5a5b4","line":688,"updated":"2016-04-19 10:34:00.000000000","message":"Is this comment relevant?","commit_id":"ac237ad8b5ab0fdcf07f31c2d9aa6d03c7688e43"}],"releasenotes/notes/add-trunk-suport-2ee2767c277e2093.yaml":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"5d224adb11d56e20f61f6069bc931d732fb558dc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for trunk and port."},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ba0121b8_ae24960c","line":2,"updated":"2016-04-01 07:18:47.000000000","message":"IMO, let\u0027s be precise here.. A typical example would be:\n\n---\nfeatures:\n  - New create, update, list, show, and delete commands are added for VLAN aware VM\u0027s functionality.\n\nFor more ref\u0027s, you can look @https://github.com/openstack/python-neutronclient/blob/master/releasenotes/notes","commit_id":"c68c1fe2a9a2507cfcd2e066e1bfe4127b4d444c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"948592f86a366abf865731301c758eeac0fc47b2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for trunk and port."},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * The ``trunk-create`` command create a trunk port"},{"line_number":7,"context_line":"      with a port."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a122d0e_c47dd11d","line":4,"updated":"2016-04-19 10:34:00.000000000","message":"Plz address PS4 comment","commit_id":"ac237ad8b5ab0fdcf07f31c2d9aa6d03c7688e43"}]}
