)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fe33e6bf3c095b3fbeee0b982eda8a7c8e543fbc","unresolved":false,"context_lines":[{"line_number":11,"context_line":"dry-run validation option of the API."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partially-Implements: blueprint get-me-a-network"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Depends-On: I9fb26e752650569fc5692ff8afda82a077647f7a"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ieba6f3cde23a8a93067b8239b096d5103f6a3128"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aed3d3a_701ef970","line":14,"updated":"2016-03-01 04:43:19.000000000","message":"would this work with the client binding [1]. I must admit I haven\u0027t tried it. If so, couldn\u0027t we return a slightly cleaner response body?\n\n[1] https://review.openstack.org/#/c/272842/12/neutronclient/v2_0/client.py@1698","commit_id":"44fe772473adb981a487c49f968afe8750dbd5b9"}],"neutronclient/neutron/v2_0/auto_allocated_topology.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"21f3c0a812ac03a9412e43eb8882946a836180a1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser \u003d super(ShowAutoAllocatedTopology, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \u0027--fields\u0027,"},{"line_number":34,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":35,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":36,"context_line":"            default\u003d[])"},{"line_number":37,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_45be3cd5","line":34,"updated":"2016-02-25 07:50:10.000000000","message":"Why we would like to add a suppress arg?","commit_id":"44fe772473adb981a487c49f968afe8750dbd5b9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5b0dc39f879fabc013a50f7050a37e710a06ec23","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser \u003d super(ShowAutoAllocatedTopology, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \u0027--fields\u0027,"},{"line_number":34,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":35,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":36,"context_line":"            default\u003d[])"},{"line_number":37,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_ce3a56e7","line":34,"in_reply_to":"bae84128_45be3cd5","updated":"2016-02-25 14:36:15.000000000","message":"I am not sure we need --fields now. For ShowCommand, --field is preferred and --fields was previously used.","commit_id":"44fe772473adb981a487c49f968afe8750dbd5b9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"412ab8b567dba35d539f65eafc58ed675c3803c1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        parser \u003d super(ShowAutoAllocatedTopology, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \u0027--fields\u0027,"},{"line_number":34,"context_line":"            help\u003dargparse.SUPPRESS,"},{"line_number":35,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":36,"context_line":"            default\u003d[])"},{"line_number":37,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_47358044","line":34,"in_reply_to":"bae84128_ce3a56e7","updated":"2016-02-25 16:48:59.000000000","message":"I copied the field(s) arg from neutronclient.neutron.v2_0.add_show_list_common_argument [1] to be consistent with other show commands.\n\n- [1] https://github.com/openstack/python-neutronclient/blob/master/neutronclient/neutron/v2_0/__init__.py#L144-L155","commit_id":"44fe772473adb981a487c49f968afe8750dbd5b9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"21f3c0a812ac03a9412e43eb8882946a836180a1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":36,"context_line":"            default\u003d[])"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027-F\u0027, \u0027--field\u0027,"},{"line_number":39,"context_line":"            dest\u003d\u0027fields\u0027, metavar\u003d\u0027FIELD\u0027,"},{"line_number":40,"context_line":"            help\u003d_(\u0027Specify the field(s) to be returned by server. You can \u0027"},{"line_number":41,"context_line":"                   \u0027repeat this option.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_65a0a0a6","line":38,"updated":"2016-02-25 07:50:10.000000000","message":"How about defining \u0027--fields\u0027 instead of \u0027--field\u0027 over here?","commit_id":"44fe772473adb981a487c49f968afe8750dbd5b9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"412ab8b567dba35d539f65eafc58ed675c3803c1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":36,"context_line":"            default\u003d[])"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027-F\u0027, \u0027--field\u0027,"},{"line_number":39,"context_line":"            dest\u003d\u0027fields\u0027, metavar\u003d\u0027FIELD\u0027,"},{"line_number":40,"context_line":"            help\u003d_(\u0027Specify the field(s) to be returned by server. You can \u0027"},{"line_number":41,"context_line":"                   \u0027repeat this option.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_87266814","line":38,"in_reply_to":"bae84128_247e81ae","updated":"2016-02-25 16:48:59.000000000","message":"Ditto","commit_id":"44fe772473adb981a487c49f968afe8750dbd5b9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5b0dc39f879fabc013a50f7050a37e710a06ec23","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":36,"context_line":"            default\u003d[])"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027-F\u0027, \u0027--field\u0027,"},{"line_number":39,"context_line":"            dest\u003d\u0027fields\u0027, metavar\u003d\u0027FIELD\u0027,"},{"line_number":40,"context_line":"            help\u003d_(\u0027Specify the field(s) to be returned by server. You can \u0027"},{"line_number":41,"context_line":"                   \u0027repeat this option.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_ee08fa2f","line":38,"in_reply_to":"bae84128_65a0a0a6","updated":"2016-02-25 14:36:15.000000000","message":"It is consistent with other ShowCommand/CreateCommand.\nI think --field is good.","commit_id":"44fe772473adb981a487c49f968afe8750dbd5b9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"59e1e92ec2dd56924b3bbfd4019e24947775a83b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":36,"context_line":"            default\u003d[])"},{"line_number":37,"context_line":"        parser.add_argument("},{"line_number":38,"context_line":"            \u0027-F\u0027, \u0027--field\u0027,"},{"line_number":39,"context_line":"            dest\u003d\u0027fields\u0027, metavar\u003d\u0027FIELD\u0027,"},{"line_number":40,"context_line":"            help\u003d_(\u0027Specify the field(s) to be returned by server. You can \u0027"},{"line_number":41,"context_line":"                   \u0027repeat this option.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_247e81ae","line":38,"in_reply_to":"bae84128_ee08fa2f","updated":"2016-02-25 15:03:09.000000000","message":"ok","commit_id":"44fe772473adb981a487c49f968afe8750dbd5b9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f68266ab81bc0658f5bd4dedbe8a7d9d46b6c42","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            help\u003d_(\u0027Specify the field(s) to be returned by server. You can \u0027"},{"line_number":41,"context_line":"                   \u0027repeat this option.\u0027),"},{"line_number":42,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":43,"context_line":"            default\u003d[])"},{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"},{"line_number":46,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_19bac76e","line":43,"updated":"2016-03-02 06:05:38.000000000","message":"dry-run is the only field currently supported.\nIf so, why don\u0027t you add --dry-run option (or --validate) instead?\n\nAt least it is better to mention value \u0027dry-run\u0027.\nIt is completely different from usual fields. \nIn usual cases we can know field names from API response, but in this case we cannot.","commit_id":"597e92b606baa20bc0422288c993de2835d96493"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"abb3af8412de32c2ca41d7a9a373d9719b5e3833","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            help\u003d_(\u0027Specify the field(s) to be returned by server. You can \u0027"},{"line_number":41,"context_line":"                   \u0027repeat this option.\u0027),"},{"line_number":42,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":43,"context_line":"            default\u003d[])"},{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--tenant-id\u0027, metavar\u003d\u0027tenant-id\u0027,"},{"line_number":46,"context_line":"            help\u003d_(\u0027The owner tenant ID.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_f173807e","line":43,"in_reply_to":"7af24918_19bac76e","updated":"2016-03-02 17:55:26.000000000","message":"Done","commit_id":"597e92b606baa20bc0422288c993de2835d96493"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7f68266ab81bc0658f5bd4dedbe8a7d9d46b6c42","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        params \u003d {}"},{"line_number":61,"context_line":"        if parsed_args.fields:"},{"line_number":62,"context_line":"            params[\u0027fields\u0027] \u003d parsed_args.fields"},{"line_number":63,"context_line":"        data \u003d client.get_auto_allocated_topology(tenant_id, **params)"},{"line_number":64,"context_line":"        if self.resource in data:"},{"line_number":65,"context_line":"            for k, v in data[self.resource].items():"},{"line_number":66,"context_line":"                if isinstance(v, list):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_f94a7b82","line":63,"updated":"2016-03-02 06:05:38.000000000","message":"If we have --dry-run option, we can call client.validate_auto_allocated_topology here.","commit_id":"597e92b606baa20bc0422288c993de2835d96493"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"abb3af8412de32c2ca41d7a9a373d9719b5e3833","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        params \u003d {}"},{"line_number":61,"context_line":"        if parsed_args.fields:"},{"line_number":62,"context_line":"            params[\u0027fields\u0027] \u003d parsed_args.fields"},{"line_number":63,"context_line":"        data \u003d client.get_auto_allocated_topology(tenant_id, **params)"},{"line_number":64,"context_line":"        if self.resource in data:"},{"line_number":65,"context_line":"            for k, v in data[self.resource].items():"},{"line_number":66,"context_line":"                if isinstance(v, list):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_316e8895","line":63,"in_reply_to":"7af24918_f94a7b82","updated":"2016-03-02 17:55:26.000000000","message":"Done","commit_id":"597e92b606baa20bc0422288c993de2835d96493"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3a3ff5a0051efbe2a29098975d09a36ec4a4c41f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def get_parser(self, prog_name):"},{"line_number":31,"context_line":"        parser \u003d super(ShowAutoAllocatedTopology, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \u0027--dry-run\u0027, \u0027--dryrun\u0027, dest\u003d\u0027dryrun\u0027,"},{"line_number":34,"context_line":"            help\u003d_(\u0027Validate the requirements for auto-allocated-topology. \u0027"},{"line_number":35,"context_line":"                   \u0027(Does not return a topology.)\u0027),"},{"line_number":36,"context_line":"            action\u003d\u0027store_true\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_5c640b21","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":35},"updated":"2016-03-02 21:11:46.000000000","message":"Is there any reason we need two options? how about --dry-run only?\n\nIf so, dest\u003d\u0027dryrun\u0027 is no longer need and L.53 will be \u0027if parsed_args.dry_run\u0027.","commit_id":"d42b892f19765fb40b60f277d3db9dfeb4d1d3dc"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2c866466e1dd19f1703c3fb0aad24dc8bef98169","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def get_parser(self, prog_name):"},{"line_number":31,"context_line":"        parser \u003d super(ShowAutoAllocatedTopology, self).get_parser(prog_name)"},{"line_number":32,"context_line":"        parser.add_argument("},{"line_number":33,"context_line":"            \u0027--dry-run\u0027, \u0027--dryrun\u0027, dest\u003d\u0027dryrun\u0027,"},{"line_number":34,"context_line":"            help\u003d_(\u0027Validate the requirements for auto-allocated-topology. \u0027"},{"line_number":35,"context_line":"                   \u0027(Does not return a topology.)\u0027),"},{"line_number":36,"context_line":"            action\u003d\u0027store_true\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1da26ffd","line":33,"range":{"start_line":33,"start_character":11,"end_line":33,"end_character":35},"in_reply_to":"7af24918_5c640b21","updated":"2016-03-02 23:05:54.000000000","message":"I was trying to be nice to users who forget whether this is a dash in the command. Anyway, I\u0027ll take it out.","commit_id":"d42b892f19765fb40b60f277d3db9dfeb4d1d3dc"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2c866466e1dd19f1703c3fb0aad24dc8bef98169","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def take_action(self, parsed_args):"},{"line_number":51,"context_line":"        client \u003d self.get_client()"},{"line_number":52,"context_line":"        tenant_id \u003d parsed_args.tenant_id or parsed_args.pos_tenant_id"},{"line_number":53,"context_line":"        if parsed_args.dryrun:"},{"line_number":54,"context_line":"            data \u003d client.validate_auto_allocated_topology_requirements("},{"line_number":55,"context_line":"                tenant_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_bddffb67","line":52,"updated":"2016-03-02 23:05:54.000000000","message":"There is some code missing here for checking the extra values. Added in next patch set.","commit_id":"d42b892f19765fb40b60f277d3db9dfeb4d1d3dc"}],"neutronclient/tests/unit/test_auto_allocated_topology.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d0fe08caf21d3066702834906a267b150c96e49","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        self._test_show_resource(resource, cmd, \"None\", args,"},{"line_number":48,"context_line":"                                 fields\u003d(\u0027dry-run\u0027,))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def test_show_auto_allocated_topology_dry_run_as_admin(self):"},{"line_number":51,"context_line":"        resource \u003d \u0027auto_allocated_topology\u0027"},{"line_number":52,"context_line":"        cmd \u003d aat.ShowAutoAllocatedTopology(test_cli20.MyApp(sys.stdout), None)"},{"line_number":53,"context_line":"        args \u003d [\u0027--dry-run\u0027, \u0027some-tenant\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"7af24918_63cdd0b6","line":50,"updated":"2016-03-02 23:50:42.000000000","message":"(Sorry for being late) This could add a Unit test for the extra options.","commit_id":"d3f13f4c20eba725fa8228a25cdfd77d47b7569d"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"811c8936abe3901f8417456e3b26c7e90fd2c7ea","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"        result \u003d self.get("},{"line_number":1903,"context_line":"            self.auto_allocated_topology_path % tenant_id,"},{"line_number":1904,"context_line":"            params\u003d_params)"},{"line_number":1905,"context_line":"        if _params and \"dry-run\" in _params.get(\u0027fields\u0027):"},{"line_number":1906,"context_line":"            topology \u003d result[\u0027auto_allocated_topology\u0027]"},{"line_number":1907,"context_line":"            validated \u003d topology.pop(\u0027id\u0027) \u003d\u003d \"dry-run\u003dpass\""},{"line_number":1908,"context_line":"            topology[\u0027validated\u0027] \u003d validated"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_97eea989","line":1905,"updated":"2016-03-02 01:35:39.000000000","message":"I don\u0027t think this belongs here, but rather in the validate_auto_allocated_topology_requirements","commit_id":"0e2a8c7f8f91c750252cd66a23b281673f888f9c"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"11579a230a9b0bb01d154aa83eedd18cd11c41ea","unresolved":false,"context_lines":[{"line_number":1902,"context_line":"        result \u003d self.get("},{"line_number":1903,"context_line":"            self.auto_allocated_topology_path % tenant_id,"},{"line_number":1904,"context_line":"            params\u003d_params)"},{"line_number":1905,"context_line":"        if _params and \"dry-run\" in _params.get(\u0027fields\u0027):"},{"line_number":1906,"context_line":"            topology \u003d result[\u0027auto_allocated_topology\u0027]"},{"line_number":1907,"context_line":"            validated \u003d topology.pop(\u0027id\u0027) \u003d\u003d \"dry-run\u003dpass\""},{"line_number":1908,"context_line":"            topology[\u0027validated\u0027] \u003d validated"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_ebc10482","line":1905,"in_reply_to":"7af24918_97eea989","updated":"2016-03-02 03:16:31.000000000","message":"I think we agreed on IRC that we shouldn\u0027t be altering the result body anywhere.","commit_id":"0e2a8c7f8f91c750252cd66a23b281673f888f9c"}]}
