)]}'
{"neutronclient/neutron/v2_0/lb/v2/pool.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"423cde3476d4a427d7b02cc3d3021a9d436b3c3b","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            parser, \u0027--admin-state-up\u0027,"},{"line_number":158,"context_line":"            help\u003d_(\u0027Update the administrative state of \u0027"},{"line_number":159,"context_line":"                   \u0027the pool (True meaning \"Up\").\u0027))"},{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--clear-session-persistence\u0027,"},{"line_number":162,"context_line":"            dest\u003d\u0027clear_session\u0027,"},{"line_number":163,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_600d0390","line":160,"updated":"2016-03-02 09:01:58.000000000","message":"How about using \"add_mutually_exclusive_group()\" for \u0027session_persistence\u0027 and \u0027clear-session-persistence\u0027..\n\nGenerally, we use \u0027no-xxx\u0027 to nullify the effect of \u0027xxx\u0027 param. Ex: \u0027qos-policy\u0027 and \u0027no-qos-policy\u0027","commit_id":"2e55945b8acb0f3c87c48c6960d6fbf1ea85498e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"91607621808052518878bc2be3266aefd35bd61c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            parser, \u0027--admin-state-up\u0027,"},{"line_number":158,"context_line":"            help\u003d_(\u0027Update the administrative state of \u0027"},{"line_number":159,"context_line":"                   \u0027the pool (True meaning \"Up\").\u0027))"},{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--clear-session-persistence\u0027,"},{"line_number":162,"context_line":"            dest\u003d\u0027clear_session\u0027,"},{"line_number":163,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_9314eb44","line":160,"in_reply_to":"7af24918_600d0390","updated":"2016-03-02 09:11:35.000000000","message":"Yeah, I had it in my mind, but wanted to avoid a rework of this patch\u0027s parent  :P\nAnyways, I had this nagging feeling, and will fix it in the next PS.","commit_id":"2e55945b8acb0f3c87c48c6960d6fbf1ea85498e"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d5be063688ef93748183350c0984e3e09da77ffa","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                   \u0027cookie name.\u0027))"},{"line_number":168,"context_line":"        session_group.add_argument("},{"line_number":169,"context_line":"            \u0027--no-session-persistence\u0027,"},{"line_number":170,"context_line":"            dest\u003d\u0027clear_session\u0027,"},{"line_number":171,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":172,"context_line":"            help\u003d_(\u0027Clear session persistence for the pool.\u0027))"},{"line_number":173,"context_line":"        _add_common_args(parser, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_2a22b101","line":170,"updated":"2016-03-02 11:31:24.000000000","message":"why you want to use \"dest\u003d\u0027clear_session\u0027\"? can\u0027t we just use \u0027no_session_persistence\u0027?","commit_id":"a09bf85f79fea946c80d29bcf311cc92f0ab544c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cb9d64b9a56e5f20c0749299c04d375b159b89ff","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                   \u0027cookie name.\u0027))"},{"line_number":168,"context_line":"        session_group.add_argument("},{"line_number":169,"context_line":"            \u0027--no-session-persistence\u0027,"},{"line_number":170,"context_line":"            dest\u003d\u0027clear_session\u0027,"},{"line_number":171,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":172,"context_line":"            help\u003d_(\u0027Clear session persistence for the pool.\u0027))"},{"line_number":173,"context_line":"        _add_common_args(parser, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_a22348a6","line":170,"in_reply_to":"7af24918_1f4539b2","updated":"2016-03-03 04:39:59.000000000","message":"Yeah, but its longer to type :)","commit_id":"a09bf85f79fea946c80d29bcf311cc92f0ab544c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7017216dec0993f4f038b8ebf869d74c2b3a0edd","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                   \u0027cookie name.\u0027))"},{"line_number":168,"context_line":"        session_group.add_argument("},{"line_number":169,"context_line":"            \u0027--no-session-persistence\u0027,"},{"line_number":170,"context_line":"            dest\u003d\u0027clear_session\u0027,"},{"line_number":171,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":172,"context_line":"            help\u003d_(\u0027Clear session persistence for the pool.\u0027))"},{"line_number":173,"context_line":"        _add_common_args(parser, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_95e67db2","line":170,"in_reply_to":"7af24918_2a22b101","updated":"2016-03-02 14:24:47.000000000","message":"Destination is a temporary variable where the value is being stored.\nThe function of this attribute is to clear the session information saved in the DB. In order to follow previous convention, I used no_session_persistence, but to make it clear to other readers of the code as to what exactly this variable is doing, I used this variable.","commit_id":"a09bf85f79fea946c80d29bcf311cc92f0ab544c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"07a3b9fc812e00995dc77352def0531968f4ddd0","unresolved":false,"context_lines":[{"line_number":167,"context_line":"                   \u0027cookie name.\u0027))"},{"line_number":168,"context_line":"        session_group.add_argument("},{"line_number":169,"context_line":"            \u0027--no-session-persistence\u0027,"},{"line_number":170,"context_line":"            dest\u003d\u0027clear_session\u0027,"},{"line_number":171,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":172,"context_line":"            help\u003d_(\u0027Clear session persistence for the pool.\u0027))"},{"line_number":173,"context_line":"        _add_common_args(parser, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_1f4539b2","line":170,"in_reply_to":"7af24918_95e67db2","updated":"2016-03-03 04:25:16.000000000","message":"i think option \u0027no-session-persistence\u0027 also convey the same idea of clearing the session.","commit_id":"a09bf85f79fea946c80d29bcf311cc92f0ab544c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ab483f990f3d5efb8dd1f91f448fca6c3b8cbf35","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            help\u003d_(\u0027The type of session persistence to use and associated \u0027"},{"line_number":167,"context_line":"                   \u0027cookie name.\u0027))"},{"line_number":168,"context_line":"        session_group.add_argument("},{"line_number":169,"context_line":"            \u0027--no-session-persistence\u0027,"},{"line_number":170,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":171,"context_line":"            help\u003d_(\u0027Clear session persistence for the pool.\u0027))"},{"line_number":172,"context_line":"        _add_common_args(parser, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_e9984a7a","line":169,"updated":"2016-04-20 18:13:51.000000000","message":"I think we can define --no-session-persistence to create-pool.\nNo session persistence is the default value, but I think it is worth we can specify no-session-persistence when create-pool. Thought?","commit_id":"4466b373a865d3be08b11f829f57fbb5b713c835"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"30ea22c313e128b078edce85816ccacb98a4fae9","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            help\u003d_(\u0027The type of session persistence to use and associated \u0027"},{"line_number":167,"context_line":"                   \u0027cookie name.\u0027))"},{"line_number":168,"context_line":"        session_group.add_argument("},{"line_number":169,"context_line":"            \u0027--no-session-persistence\u0027,"},{"line_number":170,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":171,"context_line":"            help\u003d_(\u0027Clear session persistence for the pool.\u0027))"},{"line_number":172,"context_line":"        _add_common_args(parser, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_6aa33650","line":169,"in_reply_to":"1a122d0e_d494b145","updated":"2016-04-22 09:29:36.000000000","message":"I agree, but we have differences in several of the NeutronClient CLIs.\nBut I agree with your point.\nLets see what others have to say.\nI can pull this back after the summit","commit_id":"4466b373a865d3be08b11f829f57fbb5b713c835"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"97d1184805559622b6944fc64f4a3bca68dce2ea","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            help\u003d_(\u0027The type of session persistence to use and associated \u0027"},{"line_number":167,"context_line":"                   \u0027cookie name.\u0027))"},{"line_number":168,"context_line":"        session_group.add_argument("},{"line_number":169,"context_line":"            \u0027--no-session-persistence\u0027,"},{"line_number":170,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":171,"context_line":"            help\u003d_(\u0027Clear session persistence for the pool.\u0027))"},{"line_number":172,"context_line":"        _add_common_args(parser, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_d494b145","line":169,"in_reply_to":"1a122d0e_e6882cc9","updated":"2016-04-22 08:47:27.000000000","message":"IMHO options of create and update should be symmetric as possible as we can. This is the background of my comment.","commit_id":"4466b373a865d3be08b11f829f57fbb5b713c835"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2dfe943069c557760807a94b57b09c952680f09e","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            help\u003d_(\u0027The type of session persistence to use and associated \u0027"},{"line_number":167,"context_line":"                   \u0027cookie name.\u0027))"},{"line_number":168,"context_line":"        session_group.add_argument("},{"line_number":169,"context_line":"            \u0027--no-session-persistence\u0027,"},{"line_number":170,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":171,"context_line":"            help\u003d_(\u0027Clear session persistence for the pool.\u0027))"},{"line_number":172,"context_line":"        _add_common_args(parser, False)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_e6882cc9","line":169,"in_reply_to":"1a122d0e_e9984a7a","updated":"2016-04-22 03:28:11.000000000","message":"I am not against the option being added to Create-Pool but not specifying session persistence in create-pool is similar to no-session-persistence, so maybe we can skip it in CreatePool.\nThats my observation.","commit_id":"4466b373a865d3be08b11f829f57fbb5b713c835"}],"neutronclient/tests/unit/lb/v2/test_cli20_pool.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d5be063688ef93748183350c0984e3e09da77ffa","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027, args, body,"},{"line_number":181,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":182,"context_line":"        # lbaas-pool-update myid --name Name"},{"line_number":183,"context_line":"        # --clear-session-persistence"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        resource \u003d \u0027pool\u0027"},{"line_number":186,"context_line":"        cmd_resource \u003d \u0027lbaas_pool\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_2acd915d","line":183,"updated":"2016-03-02 11:31:24.000000000","message":"nit: should be \u0027--no-session-persistence\u0027","commit_id":"a09bf85f79fea946c80d29bcf311cc92f0ab544c"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"7017216dec0993f4f038b8ebf869d74c2b3a0edd","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027, args, body,"},{"line_number":181,"context_line":"                                   cmd_resource\u003dcmd_resource)"},{"line_number":182,"context_line":"        # lbaas-pool-update myid --name Name"},{"line_number":183,"context_line":"        # --clear-session-persistence"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        resource \u003d \u0027pool\u0027"},{"line_number":186,"context_line":"        cmd_resource \u003d \u0027lbaas_pool\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_558a35c0","line":183,"in_reply_to":"7af24918_2acd915d","updated":"2016-03-02 14:24:47.000000000","message":"Oops... will change this in the next PS","commit_id":"a09bf85f79fea946c80d29bcf311cc92f0ab544c"}]}