)]}'
{"neutronclient/neutron/v2_0/floatingip.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a8c6d854d4ab77b62a4f305a8873376048d288dc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            help\u003d_(\u0027Network name or ID to allocate floating IP from.\u0027))"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--description\u0027,"},{"line_number":54,"context_line":"            help\u003d_(\u0027Description of the floating IP.\u0027))"},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--port-id\u0027,"},{"line_number":57,"context_line":"            help\u003d_(\u0027ID of the port to be associated with the floating IP.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_a8f9ae82","line":54,"updated":"2016-03-08 13:06:37.000000000","message":"Let\u0027s be consistent..\n\nSome places use \u0027this\u0027 and others we don\u0027t.. help\u003d_(\u0027Description of this floating IP.\u0027))","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"8b752d4299c5f671bb76b3b3b158ab3bd69f7468","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            help\u003d_(\u0027Network name or ID to allocate floating IP from.\u0027))"},{"line_number":52,"context_line":"        parser.add_argument("},{"line_number":53,"context_line":"            \u0027--description\u0027,"},{"line_number":54,"context_line":"            help\u003d_(\u0027Description of the floating IP.\u0027))"},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--port-id\u0027,"},{"line_number":57,"context_line":"            help\u003d_(\u0027ID of the port to be associated with the floating IP.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_5fac0f34","line":54,"updated":"2016-03-08 19:05:29.000000000","message":"This matches the context of the other help items for floating IP (e.g. the port-id right below).","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"}],"neutronclient/neutron/v2_0/network.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"23c08f87fd70e17a16e0605078384dccc2daa32c","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    resource \u003d \u0027network\u0027"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":225,"context_line":"        self.add_arguments_qos_policy(parser)"},{"line_number":226,"context_line":"        dns.add_dns_argument_update(parser, self.resource, \u0027domain\u0027)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_08d8cf1c","line":224,"updated":"2016-03-06 01:35:14.000000000","message":"You should add it here too for consistency.","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2ba2dbce971d58e907892dc68f4b0813ed10f888","unresolved":false,"context_lines":[{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    resource \u003d \u0027network\u0027"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":225,"context_line":"        self.add_arguments_qos_policy(parser)"},{"line_number":226,"context_line":"        dns.add_dns_argument_update(parser, self.resource, \u0027domain\u0027)"},{"line_number":227,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_d6715ae2","line":224,"in_reply_to":"7af24918_08d8cf1c","updated":"2016-03-07 06:31:57.000000000","message":"I left it out since the other updatables aren\u0027t included here. I think reedip\u0027s patch is already going to address this (and he included \u0027description\u0027).","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"09c3b4bede9198bcfeb54b2342e4fb2623a8fd72","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    resource \u003d \u0027network\u0027"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":225,"context_line":"        self.add_arguments_qos_policy(parser)"},{"line_number":226,"context_line":"        dns.add_dns_argument_update(parser, self.resource, \u0027domain\u0027)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_80f0cc68","line":225,"updated":"2016-03-30 21:20:13.000000000","message":"What about update?","commit_id":"2db432fbf5be5c307b82117200649379859450e5"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"188eb4eab70307f9766d41015dda4164c7104c88","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    resource \u003d \u0027network\u0027"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":225,"context_line":"        self.add_arguments_qos_policy(parser)"},{"line_number":226,"context_line":"        dns.add_dns_argument_update(parser, self.resource, \u0027domain\u0027)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":"    def args2body(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_8fa2b749","line":225,"in_reply_to":"ba0121b8_80f0cc68","updated":"2016-03-30 23:37:29.000000000","message":"handled here : https://review.openstack.org/#/c/280521/....","commit_id":"2db432fbf5be5c307b82117200649379859450e5"}],"neutronclient/neutron/v2_0/router.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a8c6d854d4ab77b62a4f305a8873376048d288dc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            help\u003d_(\u0027Name of router to create.\u0027))"},{"line_number":71,"context_line":"        parser.add_argument("},{"line_number":72,"context_line":"            \u0027--description\u0027,"},{"line_number":73,"context_line":"            help\u003d_(\u0027Description of router.\u0027))"},{"line_number":74,"context_line":"        utils.add_boolean_argument("},{"line_number":75,"context_line":"            parser, \u0027--distributed\u0027, dest\u003d\u0027distributed\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027Create a distributed router.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_4802aa70","line":73,"updated":"2016-03-08 13:06:37.000000000","message":"Let\u0027s be consistent..\n\nSome places use \u0027this\u0027 and others we don\u0027t.. help\u003d_(\u0027Description of this router.\u0027))","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"}],"neutronclient/neutron/v2_0/securitygroup.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a8c6d854d4ab77b62a4f305a8873376048d288dc","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    def add_known_arguments(self, parser):"},{"line_number":308,"context_line":"        parser.add_argument("},{"line_number":309,"context_line":"            \u0027--description\u0027,"},{"line_number":310,"context_line":"            help\u003d_(\u0027Description of security group rule.\u0027))"},{"line_number":311,"context_line":"        parser.add_argument("},{"line_number":312,"context_line":"            \u0027security_group_id\u0027, metavar\u003d\u0027SECURITY_GROUP\u0027,"},{"line_number":313,"context_line":"            help\u003d_(\u0027Security group name or ID to add rule.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_c8a6ba52","line":310,"updated":"2016-03-08 13:06:37.000000000","message":"help\u003d_(\u0027Description of this Security group rule.\u0027))","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"}],"neutronclient/neutron/v2_0/subnetpool.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e1d019882b02489c5da25ce6c6f37cfdcb7297de","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def add_updatable_arguments(parser):"},{"line_number":30,"context_line":"    parser.add_argument("},{"line_number":31,"context_line":"        \u0027--description\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Description of this subnetpool.\u0027))"},{"line_number":33,"context_line":"    parser.add_argument("},{"line_number":34,"context_line":"        \u0027--min-prefixlen\u0027, type\u003dint,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool minimum prefix length.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_65a82a8e","line":32,"updated":"2016-03-03 05:37:03.000000000","message":"\u0027this \u0027 is not required , if we follow previous implementations( like router.py)","commit_id":"b98109c080eb1f9853aa2b6dbdb7df2ef070d036"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"655e453fbcaf8025bea29e992ceb69c43aa7ec7e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def add_updatable_arguments(parser):"},{"line_number":30,"context_line":"    parser.add_argument("},{"line_number":31,"context_line":"        \u0027--description\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Description of this subnetpool.\u0027))"},{"line_number":33,"context_line":"    parser.add_argument("},{"line_number":34,"context_line":"        \u0027--min-prefixlen\u0027, type\u003dint,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool minimum prefix length.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_eb288be4","line":32,"in_reply_to":"7af24918_65a82a8e","updated":"2016-03-03 06:47:24.000000000","message":"Done","commit_id":"b98109c080eb1f9853aa2b6dbdb7df2ef070d036"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"a8c6d854d4ab77b62a4f305a8873376048d288dc","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def add_updatable_arguments(parser):"},{"line_number":30,"context_line":"    parser.add_argument("},{"line_number":31,"context_line":"        \u0027--description\u0027,"},{"line_number":32,"context_line":"        help\u003d_(\u0027Description of subnetpool.\u0027))"},{"line_number":33,"context_line":"    parser.add_argument("},{"line_number":34,"context_line":"        \u0027--min-prefixlen\u0027, type\u003dint,"},{"line_number":35,"context_line":"        help\u003d_(\u0027Subnetpool minimum prefix length.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_28611e3a","line":32,"updated":"2016-03-08 13:06:37.000000000","message":"help\u003d_(\u0027Description of this subnetpool.\u0027))","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"}],"neutronclient/tests/unit/test_cli20_network.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"23c08f87fd70e17a16e0605078384dccc2daa32c","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        # Update net: myid --name myname --tags a b."},{"line_number":522,"context_line":"        resource \u003d \u0027network\u0027"},{"line_number":523,"context_line":"        cmd \u003d network.UpdateNetwork(test_cli20.MyApp(sys.stdout), None)"},{"line_number":524,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"},{"line_number":525,"context_line":"                                   [\u0027myid\u0027, \u0027--name\u0027, \u0027myname\u0027,"},{"line_number":526,"context_line":"                                    \u0027--tags\u0027, \u0027a\u0027, \u0027b\u0027, \u0027--description\u0027,"},{"line_number":527,"context_line":"                                    \u0027This network takes the scenic route\u0027],"},{"line_number":528,"context_line":"                                   {\u0027name\u0027: \u0027myname\u0027, \u0027tags\u0027: [\u0027a\u0027, \u0027b\u0027],"},{"line_number":529,"context_line":"                                    \u0027description\u0027: \u0027This network takes the \u0027"},{"line_number":530,"context_line":"                                                   \u0027scenic route\u0027})"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    def test_update_network_with_unicode(self):"},{"line_number":533,"context_line":"        # Update net: myid --name u\u0027\\u7f51\\u7edc\u0027 --tags a b."}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_0bee09ec","line":530,"range":{"start_line":524,"start_character":57,"end_line":530,"end_character":67},"updated":"2016-03-06 01:35:14.000000000","message":"Note that none of these fields (name, tags, description) are \"official\" arguments for net-update. They work because unknown arguments are passed by default in the request body.","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2ba2dbce971d58e907892dc68f4b0813ed10f888","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        # Update net: myid --name myname --tags a b."},{"line_number":522,"context_line":"        resource \u003d \u0027network\u0027"},{"line_number":523,"context_line":"        cmd \u003d network.UpdateNetwork(test_cli20.MyApp(sys.stdout), None)"},{"line_number":524,"context_line":"        self._test_update_resource(resource, cmd, \u0027myid\u0027,"},{"line_number":525,"context_line":"                                   [\u0027myid\u0027, \u0027--name\u0027, \u0027myname\u0027,"},{"line_number":526,"context_line":"                                    \u0027--tags\u0027, \u0027a\u0027, \u0027b\u0027, \u0027--description\u0027,"},{"line_number":527,"context_line":"                                    \u0027This network takes the scenic route\u0027],"},{"line_number":528,"context_line":"                                   {\u0027name\u0027: \u0027myname\u0027, \u0027tags\u0027: [\u0027a\u0027, \u0027b\u0027],"},{"line_number":529,"context_line":"                                    \u0027description\u0027: \u0027This network takes the \u0027"},{"line_number":530,"context_line":"                                                   \u0027scenic route\u0027})"},{"line_number":531,"context_line":""},{"line_number":532,"context_line":"    def test_update_network_with_unicode(self):"},{"line_number":533,"context_line":"        # Update net: myid --name u\u0027\\u7f51\\u7edc\u0027 --tags a b."}],"source_content_type":"text/x-python","patch_set":3,"id":"7af24918_76584657","line":530,"range":{"start_line":524,"start_character":57,"end_line":530,"end_character":67},"in_reply_to":"7af24918_0bee09ec","updated":"2016-03-07 06:31:57.000000000","message":"Right. I think this is the patch that this is being fixed in: I69aa284ee4a217f6627bb7120a0fc63b856bd6cc","commit_id":"d10985459927c61f71fabd8aa1b98531c2564aaa"}]}