)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"29ed741bf7f5dcd089801815eba559c0860dc88f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace null in output of security-group-show with \u0027\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the output of \"neutron security-group-show\" will contain null"},{"line_number":10,"context_line":"in the \"security_group_rules\" field. It is not user friendly and not"},{"line_number":11,"context_line":"consistent with \"neutron security-group-rule-show\" and"},{"line_number":12,"context_line":"\"neutron security-group-rule-list\". This is demonstrated in [1]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_f8728a48","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":72},"updated":"2016-03-07 00:41:05.000000000","message":"Limit the number of characters in git body to 72 ( so bring this to the next line)","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"16662ebc880fb9ce48c773cf362c336d7f61d18a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Replace null in output of security-group-show with \u0027\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, the output of \"neutron security-group-show\" will contain null"},{"line_number":10,"context_line":"in the \"security_group_rules\" field. It is not user friendly and not"},{"line_number":11,"context_line":"consistent with \"neutron security-group-rule-show\" and"},{"line_number":12,"context_line":"\"neutron security-group-rule-list\". This is demonstrated in [1]"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_cca0d7a8","line":9,"range":{"start_line":9,"start_character":55,"end_line":9,"end_character":72},"in_reply_to":"7af24918_f8728a48","updated":"2016-03-07 09:12:53.000000000","message":"Done","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"29ed741bf7f5dcd089801815eba559c0860dc88f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, the output of \"neutron security-group-show\" will contain null"},{"line_number":10,"context_line":"in the \"security_group_rules\" field. It is not user friendly and not"},{"line_number":11,"context_line":"consistent with \"neutron security-group-rule-show\" and"},{"line_number":12,"context_line":"\"neutron security-group-rule-list\". This is demonstrated in [1]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch replace the null with an empty string \u0027\u0027. This is demonstrated"},{"line_number":15,"context_line":"in [2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_78867a14","line":12,"updated":"2016-03-07 00:41:05.000000000","message":"Period/Full stop","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"16662ebc880fb9ce48c773cf362c336d7f61d18a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, the output of \"neutron security-group-show\" will contain null"},{"line_number":10,"context_line":"in the \"security_group_rules\" field. It is not user friendly and not"},{"line_number":11,"context_line":"consistent with \"neutron security-group-rule-show\" and"},{"line_number":12,"context_line":"\"neutron security-group-rule-list\". This is demonstrated in [1]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch replace the null with an empty string \u0027\u0027. This is demonstrated"},{"line_number":15,"context_line":"in [2]."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_ac8c6b36","line":12,"in_reply_to":"7af24918_78867a14","updated":"2016-03-07 09:12:53.000000000","message":"I think I don\u0027t get your point here.","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"29ed741bf7f5dcd089801815eba559c0860dc88f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"consistent with \"neutron security-group-rule-show\" and"},{"line_number":12,"context_line":"\"neutron security-group-rule-list\". This is demonstrated in [1]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch replace the null with an empty string \u0027\u0027. This is demonstrated"},{"line_number":15,"context_line":"in [2]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] http://paste.openstack.org/show/486190/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7af24918_58873e12","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":53},"updated":"2016-03-07 00:41:05.000000000","message":"Lets add a newline here","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"16662ebc880fb9ce48c773cf362c336d7f61d18a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"consistent with \"neutron security-group-rule-show\" and"},{"line_number":12,"context_line":"\"neutron security-group-rule-list\". This is demonstrated in [1]"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch replace the null with an empty string \u0027\u0027. This is demonstrated"},{"line_number":15,"context_line":"in [2]."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"[1] http://paste.openstack.org/show/486190/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_0cabdf8a","line":14,"range":{"start_line":14,"start_character":52,"end_line":14,"end_character":53},"in_reply_to":"7af24918_58873e12","updated":"2016-03-07 09:12:53.000000000","message":"Done","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"}],"neutronclient/neutron/v2_0/securitygroup.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d443849768455d66d08fb63ebb22ab60428101f1","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        for rule in security_group_rules:"},{"line_number":121,"context_line":"            for k, v in rule.items():"},{"line_number":122,"context_line":"                if v is None:"},{"line_number":123,"context_line":"                    rule[k] \u003d \u0027\u0027"},{"line_number":124,"context_line":"        super(ShowSecurityGroup, self).format_output_data(data)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_bfaf4c2a","line":123,"updated":"2016-03-06 18:14:55.000000000","message":"You modify a returned value from the original data.\nIf so, do we need to use JSON dump itself?\nHow about using _format_sg_rules used by security-group-list?","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"29ed741bf7f5dcd089801815eba559c0860dc88f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        for rule in security_group_rules:"},{"line_number":121,"context_line":"            for k, v in rule.items():"},{"line_number":122,"context_line":"                if v is None:"},{"line_number":123,"context_line":"                    rule[k] \u003d \u0027\u0027"},{"line_number":124,"context_line":"        super(ShowSecurityGroup, self).format_output_data(data)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_785e7a77","line":123,"in_reply_to":"7af24918_bfaf4c2a","updated":"2016-03-07 00:41:05.000000000","message":"I agree that the function may require a little change, but can be used here","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"16662ebc880fb9ce48c773cf362c336d7f61d18a","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        for rule in security_group_rules:"},{"line_number":121,"context_line":"            for k, v in rule.items():"},{"line_number":122,"context_line":"                if v is None:"},{"line_number":123,"context_line":"                    rule[k] \u003d \u0027\u0027"},{"line_number":124,"context_line":"        super(ShowSecurityGroup, self).format_output_data(data)"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_2cf69bd7","line":123,"in_reply_to":"7af24918_bfaf4c2a","updated":"2016-03-07 09:12:53.000000000","message":"I think the necessary json dump is done at [1]. Using _format_sg_rules will hide the \"null\" field. That is my first intention for the fix of this bug. But Nate posted this comment [2], which I think is meaningful. So, the change here is just convert null to \"\". \n\n[1] https://github.com/openstack/python-neutronclient/blob/8460b0dbb354a304a112be13c63cb933ebe1927a/neutronclient/neutron/v2_0/__init__.py#L437\n\n[2] https://bugs.launchpad.net/python-neutronclient/+bug/1542819/comments/1","commit_id":"d20825e73061b00e23ab45a7987784a68f4376d6"}]}
