)]}'
{"id":"openstack%2Fpython-neutronclient~288302","triplet_id":"openstack%2Fpython-neutronclient~master~I403b65b1ba8d2e0c8beb20fff88a20e225601618","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1542819","hashtags":[],"change_id":"I403b65b1ba8d2e0c8beb20fff88a20e225601618","subject":"Replace null in output of security-group-show with \u0027\u0027","status":"ABANDONED","created":"2016-03-04 08:24:45.000000000","updated":"2016-05-04 07:40:07.000000000","total_comment_count":9,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"39cac7a38510c23f1a63e59d4cf49fab28c3bda6","_number":288302,"virtual_id_number":288302,"owner":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":1,"date":"2016-03-07 10:11:03.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2016-03-07 21:17:43.000000000","_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},{"value":-1,"date":"2016-04-20 22:29:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-06 18:14:55.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2016-03-07 00:41:05.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-03-07 10:11:03.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-03-07 21:17:43.000000000","updated_by":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"reviewer":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"state":"REVIEWER"},{"updated":"2016-04-20 22:29:13.000000000","updated_by":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"reviewer":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"state":"REVIEWER"}],"messages":[{"id":"911d96359475162b1aff6d083c39398be957b146","author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"date":"2016-03-04 08:24:45.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e6ae4055cb7c159103dd9ee4f215e4c49b072bf7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-04 09:20:13.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-pep8/a02f65c/ : SUCCESS in 42s\n- gate-python-neutronclient-docs http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-docs/7f6dd74/ : FAILURE in 30m 10s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-python27/3afd470/ : SUCCESS in 2m 56s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-python34/5038f57/ : SUCCESS in 2m 02s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-pypy/243e497/ : SUCCESS in 1m 46s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/288302/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/c4310fc/ : SUCCESS in 54m 22s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/288302/1/check/gate-neutronclient-test-dsvm-functional/1a01edc/ : SUCCESS in 22m 45s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/288302/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/fe6ff7b/ : SUCCESS in 20m 20s","accounts_in_message":[],"_revision_number":1},{"id":"42ed4264035952ddf62a606a18b9ef24337a5133","author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"date":"2016-03-04 09:22:09.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"887c5187e107a935aaddb5fd39d5f7bca3d1105d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-04 10:16:52.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-pep8/b8ed0c9/ : SUCCESS in 37s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/288302/1/check/gate-python-neutronclient-docs/9ae3567//doc/build/html/ : SUCCESS in 50s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-python27/fe191e2/ : SUCCESS in 53s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-python34/d2da955/ : SUCCESS in 1m 42s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/288302/1/check/gate-python-neutronclient-pypy/3f3cc5c/ : SUCCESS in 1m 46s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/288302/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/d7821a5/ : SUCCESS in 53m 26s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/288302/1/check/gate-neutronclient-test-dsvm-functional/676eed3/ : SUCCESS in 23m 06s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/288302/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/2606623/ : SUCCESS in 19m 16s","accounts_in_message":[],"_revision_number":1},{"id":"d443849768455d66d08fb63ebb22ab60428101f1","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-03-06 18:14:55.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"29ed741bf7f5dcd089801815eba559c0860dc88f","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-03-07 00:41:05.000000000","message":"Patch Set 1: Code-Review-1\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"16662ebc880fb9ce48c773cf362c336d7f61d18a","author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"date":"2016-03-07 09:12:53.000000000","message":"Patch Set 1:\n\n(4 comments)","accounts_in_message":[],"_revision_number":1},{"id":"ebe0e4d7ab32b99b6c6cc8bc2d426601be9108a4","author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"date":"2016-03-07 09:13:24.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"b9b5f4ae83708d58f7496634ad7693e36b8317cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-07 10:11:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/02/288302/2/check/gate-python-neutronclient-pep8/6e35e46/ : SUCCESS in 3m 28s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/02/288302/2/check/gate-python-neutronclient-docs/4793051//doc/build/html/ : SUCCESS in 3m 11s\n- gate-python-neutronclient-python27 http://logs.openstack.org/02/288302/2/check/gate-python-neutronclient-python27/2cb77c0/ : SUCCESS in 1m 48s\n- gate-python-neutronclient-python34 http://logs.openstack.org/02/288302/2/check/gate-python-neutronclient-python34/a0ac28b/ : SUCCESS in 2m 13s\n- gate-python-neutronclient-pypy http://logs.openstack.org/02/288302/2/check/gate-python-neutronclient-pypy/57b4660/ : SUCCESS in 2m 58s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/02/288302/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/23eaed8/ : SUCCESS in 56m 58s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/02/288302/2/check/gate-neutronclient-test-dsvm-functional/cc5ab5d/ : SUCCESS in 21m 42s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/02/288302/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/f41138e/ : SUCCESS in 22m 17s","accounts_in_message":[],"_revision_number":2},{"id":"1728db48e4f643d4474c567b0171c999ac92a417","author":{"_account_id":17211,"name":"Brandon Palm","email":"bapalm@us.ibm.com","username":"bapalm"},"date":"2016-03-07 21:17:43.000000000","message":"Patch Set 2:\n\nI kind of prefer it saying null honestly.  :)","accounts_in_message":[],"_revision_number":2},{"id":"68727e3f1c3aa15ed684b34f0efd9f8a593e69fa","author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"date":"2016-04-20 22:29:13.000000000","message":"Patch Set 2: Code-Review-1\n\nI prefer null as @Brandon stated (though I was about to provide that feedback anyway before I read his response).  It is json afterall which already isn\u0027t the most user-friendly.  Given that it is json, I think it is less user friendly to \"format\" the null value as an empty string because there is a big semantic difference between \"\" and null.\n\nMy $0.02.","accounts_in_message":[],"_revision_number":2},{"id":"f00fe0a1d87dde2369ef63615aeebd4a54376678","author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"date":"2016-05-04 07:40:07.000000000","message":"Abandoned\n\nAbandon this based on the discussion.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"fbad9fbdc1dd50f44277eaea90dca4542f7b7375","revisions":{"d20825e73061b00e23ab45a7987784a68f4376d6":{"kind":"REWORK","_number":1,"created":"2016-03-04 08:24:45.000000000","uploader":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"ref":"refs/changes/02/288302/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/288302/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/288302/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/288302/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/288302/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/288302/1"}}},"commit":{"parents":[{"commit":"937826c46ac8dad2b2ae8703632ec02357bc2bde","subject":"Merge \"Update relnote on fix of bug 1450414\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/937826c46ac8dad2b2ae8703632ec02357bc2bde"}]}],"author":{"name":"Hong Hui Xiao","email":"xiaohhui@cn.ibm.com","date":"2016-03-04 08:22:53.000000000","tz":-300},"committer":{"name":"Hong Hui Xiao","email":"xiaohhui@cn.ibm.com","date":"2016-03-04 08:22:53.000000000","tz":-300},"subject":"Replace null in output of security-group-show with \u0027\u0027","message":"Replace null in output of security-group-show with \u0027\u0027\n\nCurrently, the output of \"neutron security-group-show\" will contain null\nin the \"security_group_rules\" field. It is not user friendly and not\nconsistent with \"neutron security-group-rule-show\" and\n\"neutron security-group-rule-list\". This is demonstrated in [1]\n\nThis patch replace the null with an empty string \u0027\u0027. This is demonstrated\nin [2].\n\n[1] http://paste.openstack.org/show/486190/\n[2] http://paste.openstack.org/show/489272/\n\nChange-Id: I403b65b1ba8d2e0c8beb20fff88a20e225601618\nCloses-Bug: #1542819\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d20825e73061b00e23ab45a7987784a68f4376d6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d20825e73061b00e23ab45a7987784a68f4376d6"}]},"branch":"refs/heads/master"},"fbad9fbdc1dd50f44277eaea90dca4542f7b7375":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-03-07 09:13:24.000000000","uploader":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"ref":"refs/changes/02/288302/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/02/288302/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/288302/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/288302/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/02/288302/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/02/288302/2"}}},"commit":{"parents":[{"commit":"937826c46ac8dad2b2ae8703632ec02357bc2bde","subject":"Merge \"Update relnote on fix of bug 1450414\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/937826c46ac8dad2b2ae8703632ec02357bc2bde"}]}],"author":{"name":"Hong Hui Xiao","email":"xiaohhui@cn.ibm.com","date":"2016-03-04 08:22:53.000000000","tz":-300},"committer":{"name":"Hong Hui Xiao","email":"xiaohhui@cn.ibm.com","date":"2016-03-07 09:13:03.000000000","tz":-300},"subject":"Replace null in output of security-group-show with \u0027\u0027","message":"Replace null in output of security-group-show with \u0027\u0027\n\nCurrently, the output of \"neutron security-group-show\" will contain\nnull in the \"security_group_rules\" field. It is not user friendly,\nwhich is demonstrated in [1].\n\nThis patch replace the null with an empty string \u0027\u0027. This is\ndemonstrated in [2].\n\n[1] http://paste.openstack.org/show/486190/\n[2] http://paste.openstack.org/show/489272/\n\nChange-Id: I403b65b1ba8d2e0c8beb20fff88a20e225601618\nCloses-Bug: #1542819\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/fbad9fbdc1dd50f44277eaea90dca4542f7b7375"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/fbad9fbdc1dd50f44277eaea90dca4542f7b7375"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
