)]}'
{"id":"openstack%2Fpython-neutronclient~289205","triplet_id":"openstack%2Fpython-neutronclient~master~I644ca6f4797b7c7564e0d62da44126957177de78","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1552721","hashtags":[],"change_id":"I644ca6f4797b7c7564e0d62da44126957177de78","subject":"Add --router:external to net-create arguments","status":"ABANDONED","created":"2016-03-07 07:50:52.000000000","updated":"2016-04-14 17:23:08.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fd6bd98eabd462b0ced6e4724d59700df254f519","_number":289205,"virtual_id_number":289205,"owner":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":-1,"date":"2016-03-07 08:52:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-03-07 07:56:21.000000000","_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2016-04-14 17:23:08.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"date":"2016-03-09 06:05:02.000000000","_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"all":[{"value":-1,"date":"2016-03-07 07:51:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},{"value":-1,"date":"2016-03-09 09:50:26.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-07 07:51:54.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-03-07 08:52:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-03-09 06:05:02.000000000","updated_by":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"reviewer":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"state":"REVIEWER"},{"updated":"2016-03-09 09:50:26.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2016-04-14 17:23:08.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"}],"messages":[{"id":"15e209703899e92bbf9911fc81f81b2e6ed966c6","author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"date":"2016-03-07 07:50:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"f565661dad8332ec55b1af71e5d301091c6afe71","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-03-07 07:51:54.000000000","message":"Patch Set 1: Code-Review-1\n\nPatch already in works:https://review.openstack.org/#/c/137279/","accounts_in_message":[],"_revision_number":1},{"id":"2416417201f884d706f98ed8e5005207ac2856c4","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-03-07 07:52:14.000000000","message":"Patch Set 1:\n\nIn fact, for a long time :(","accounts_in_message":[],"_revision_number":1},{"id":"45c2d5625efbfc05de3a0c7bc815a69c89be2577","author":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"date":"2016-03-07 07:56:21.000000000","message":"Patch Set 1:\n\nHi Reedip, this patch is limited to fix router:external of net-create","accounts_in_message":[],"_revision_number":1},{"id":"06903d45a4a8bc0fa6b560c31fb4448f8d55cca1","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-03-07 08:05:02.000000000","message":"Patch Set 1:\n\nYeah, that is also being discussed in the above mentioned patch.\nYou can see the discussion in that patch, and its sister patch :https://review.openstack.org/#/c/280521/4","accounts_in_message":[],"_revision_number":1},{"id":"c3cc6940787074273eadf1342d4f9398bea7eef9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-07 08:52:55.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-pep8 http://logs.openstack.org/05/289205/1/check/gate-python-neutronclient-pep8/92428d9/ : SUCCESS in 1m 36s\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/05/289205/1/check/gate-python-neutronclient-docs/fb5c4d2//doc/build/html/ : SUCCESS in 1m 37s\n- gate-python-neutronclient-python27 http://logs.openstack.org/05/289205/1/check/gate-python-neutronclient-python27/7c694d4/ : SUCCESS in 2m 13s\n- gate-python-neutronclient-python34 http://logs.openstack.org/05/289205/1/check/gate-python-neutronclient-python34/07a0a1c/ : SUCCESS in 2m 57s\n- gate-python-neutronclient-pypy http://logs.openstack.org/05/289205/1/check/gate-python-neutronclient-pypy/0f698a4/ : SUCCESS in 3m 23s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/05/289205/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/61de521/ : SUCCESS in 56m 26s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/05/289205/1/check/gate-neutronclient-test-dsvm-functional/22dee53/ : FAILURE in 24m 38s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/05/289205/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/b449e3a/ : SUCCESS in 13m 00s","accounts_in_message":[],"_revision_number":1},{"id":"8aff5119fa730c207fa2fcc83072d6fa508612f1","author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"date":"2016-03-09 06:05:02.000000000","message":"Patch Set 1:\n\nI\u0027m agree with Reedip and the comments on the mentioned patch.","accounts_in_message":[],"_revision_number":1},{"id":"b9990d64835b3448ee45e42712b48d104e6d5d56","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-03-09 09:50:26.000000000","message":"Patch Set 1: Code-Review-1\n\nWe are in the complicated situation:\n\nyou need to support all of three below:\n\n* --router:external\n* --router:external\u003dTrue (or --router:external True)\n* --router:external\u003dFalse (or --router:external False)\n\nAll of them work now.\n\nI agree with other reviewers that we are already working on but we haven\u0027t reached a consensus.","accounts_in_message":[],"_revision_number":1},{"id":"3dfee68e7aec8c4a3462090c02a4de6e15cef816","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-04-14 17:23:08.000000000","message":"Patch Set 1:\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1},{"id":"5a0924cae2121bff094d16ac6c15fbf4739a616e","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-04-14 17:23:08.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a \u0027recheck\u0027 comment to get fresh test results.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"f7ceee83bc759da81692526a37dccaa4b5f5fa9d","revisions":{"f7ceee83bc759da81692526a37dccaa4b5f5fa9d":{"kind":"REWORK","_number":1,"created":"2016-03-07 07:50:52.000000000","uploader":{"_account_id":17523,"name":"yaowei","email":"yaowei@unitedstack.com","username":"yaowei"},"ref":"refs/changes/05/289205/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/05/289205/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/289205/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/289205/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/05/289205/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/05/289205/1"}}},"commit":{"parents":[{"commit":"8460b0dbb354a304a112be13c63cb933ebe1927a","subject":"Merge \"Do not print \u0027Created\u0027 message when using non-table formatter\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8460b0dbb354a304a112be13c63cb933ebe1927a"}]}],"author":{"name":"yaowei","email":"yaowei@unitedstack.com","date":"2016-03-07 07:40:33.000000000","tz":480},"committer":{"name":"yaowei","email":"yaowei@unitedstack.com","date":"2016-03-07 07:50:37.000000000","tz":480},"subject":"Add --router:external to net-create arguments","message":"Add --router:external to net-create arguments\n\nrouter:external is not in CreateNetwork known_arguments. This allows\nhelp message of router:external to output when creating a network through\ncli.\n\nChange-Id: I644ca6f4797b7c7564e0d62da44126957177de78\nCloses-Bug: #1552721\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/f7ceee83bc759da81692526a37dccaa4b5f5fa9d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/f7ceee83bc759da81692526a37dccaa4b5f5fa9d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
