)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stanislaw Pitucha \u003cstanislaw.pitucha@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-06-18 13:35:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t log the credentials by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Even in case of DEBUG level logging credentials (especially those that"},{"line_number":10,"context_line":"give admin level access) should not be saved into log files."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAPn%2F%2FiNY%3D","line":7,"updated":"2013-06-28 10:48:07.000000000","message":"please add reference to bug/blueprint","commit_id":"b7af939d12f9f93e1ce4418d2066cbfc42b590b5"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"1980521127af60bdd06dff79076a6895fd752e40","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Stanislaw Pitucha \u003cstanislaw.pitucha@hp.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-06-18 13:35:22 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t log the credentials by default"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Even in case of DEBUG level logging credentials (especially those that"},{"line_number":10,"context_line":"give admin level access) should not be saved into log files."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"AAAAPn%2F%2FiL8%3D","line":7,"in_reply_to":"AAAAPn%2F%2FiNY%3D","updated":"2013-06-28 10:55:17.000000000","message":"sure","commit_id":"b7af939d12f9f93e1ce4418d2066cbfc42b590b5"}],"quantumclient/client.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"2bbe8f8fee3d6f9995c9c32732a384545921d829","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":126,"context_line":"            kargs[\u0027body\u0027] \u003d kwargs[\u0027body\u0027]"},{"line_number":127,"context_line":"            print kwargs[\u0027body\u0027]"},{"line_number":128,"context_line":"        args \u003d utils.safe_encode_list(args)"},{"line_number":129,"context_line":"        kargs \u003d utils.safe_encode_dict(kargs)"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPH%2F%2F9tU%3D","line":127,"updated":"2013-05-17 16:38:10.000000000","message":"Was this meant to be left in here?  It looks like a print statement that was meant to be removed before commit maybe?","commit_id":"9886adebb03be12d71a99eafd67559bc71610fb1"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.auth_url \u003d auth_url.rstrip(\u0027/\u0027) if auth_url else None"},{"line_number":107,"context_line":"        self.endpoint_type \u003d endpoint_type"},{"line_number":108,"context_line":"        self.region_name \u003d region_name"},{"line_number":109,"context_line":"        self.auth_token \u003d token"},{"line_number":110,"context_line":"        self.content_type \u003d \u0027application/json\u0027"},{"line_number":111,"context_line":"        self.endpoint_url \u003d endpoint_url"},{"line_number":112,"context_line":"        self.auth_strategy \u003d auth_strategy"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FiNk%3D","line":109,"updated":"2013-06-28 10:47:02.000000000","message":"Do you reckon we can apply this logic to the auth_token too?","commit_id":"b7af939d12f9f93e1ce4418d2066cbfc42b590b5"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"1980521127af60bdd06dff79076a6895fd752e40","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.auth_url \u003d auth_url.rstrip(\u0027/\u0027) if auth_url else None"},{"line_number":107,"context_line":"        self.endpoint_type \u003d endpoint_type"},{"line_number":108,"context_line":"        self.region_name \u003d region_name"},{"line_number":109,"context_line":"        self.auth_token \u003d token"},{"line_number":110,"context_line":"        self.content_type \u003d \u0027application/json\u0027"},{"line_number":111,"context_line":"        self.endpoint_url \u003d endpoint_url"},{"line_number":112,"context_line":"        self.auth_strategy \u003d auth_strategy"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPn%2F%2FiMA%3D","line":109,"in_reply_to":"AAAAPn%2F%2FiNk%3D","updated":"2013-06-28 10:55:17.000000000","message":"It was partially done before and I decided to remove it after comments. Auth token needs a lot more work that will probably need to be applied across all openstack projects. One of the problems is that it\u0027s passed to many other components which may not redact it yet. Another is that responses are very often logged before parsing, so we don\u0027t even know what kind of data they contain. Then there are rpc messages in services which are logged in places that aren\u0027t really aware of authentication or contents at all.\n\nThis patch is a first reasonable step - get rid of credentials that never / rarely change. Auth tokens will have to be dealt with later.","commit_id":"b7af939d12f9f93e1ce4418d2066cbfc42b590b5"}],"tests/unit/test_auth.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"188299ac4f1e3995f752b39528789b689fd11a14","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from quantumclient.client import exceptions"},{"line_number":28,"context_line":"from quantumclient.client import HTTPClient"},{"line_number":29,"context_line":"from quantumclient.client import ServiceCatalog"},{"line_number":30,"context_line":"import quantumclient.common.utils"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"USERNAME \u003d \u0027testuser\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fkyw%3D","line":30,"updated":"2013-05-30 06:34:49.000000000","message":"nit: from quantum.common import utils","commit_id":"31c4190a3331a60641d6497f8b8c5325f7cfd9e2"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"1980521127af60bdd06dff79076a6895fd752e40","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from quantumclient.client import exceptions"},{"line_number":28,"context_line":"from quantumclient.client import HTTPClient"},{"line_number":29,"context_line":"from quantumclient.client import ServiceCatalog"},{"line_number":30,"context_line":"import quantumclient.common.utils"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"USERNAME \u003d \u0027testuser\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FkT4%3D","line":30,"in_reply_to":"AAAAPH%2F%2Fkyw%3D","updated":"2013-05-30 12:05:22.000000000","message":"Done","commit_id":"31c4190a3331a60641d6497f8b8c5325f7cfd9e2"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"188299ac4f1e3995f752b39528789b689fd11a14","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        quantumclient.common.utils.http_log_req(mox.IgnoreArg(),"},{"line_number":343,"context_line":"                                                mox.IgnoreArg(),"},{"line_number":344,"context_line":"                                                mox.Func(verify_no_token))"},{"line_number":345,"context_line":"        self.client.request(IsA(str), IsA(str),"},{"line_number":346,"context_line":"                            headers\u003dContainsKeyValue(\u0027X-Auth-Token\u0027, TOKEN)).\\"},{"line_number":347,"context_line":"            AndReturn((res200, \u0027\u0027))"},{"line_number":348,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2Fkyo%3D","line":345,"updated":"2013-05-30 06:34:49.000000000","message":"nit place use ( ) instead of \\","commit_id":"31c4190a3331a60641d6497f8b8c5325f7cfd9e2"},{"author":{"_account_id":1528,"name":"Stanislaw Pitucha","email":"viraptor@gmail.com","username":"stanislaw-pitucha"},"change_message_id":"1980521127af60bdd06dff79076a6895fd752e40","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        quantumclient.common.utils.http_log_req(mox.IgnoreArg(),"},{"line_number":343,"context_line":"                                                mox.IgnoreArg(),"},{"line_number":344,"context_line":"                                                mox.Func(verify_no_token))"},{"line_number":345,"context_line":"        self.client.request(IsA(str), IsA(str),"},{"line_number":346,"context_line":"                            headers\u003dContainsKeyValue(\u0027X-Auth-Token\u0027, TOKEN)).\\"},{"line_number":347,"context_line":"            AndReturn((res200, \u0027\u0027))"},{"line_number":348,"context_line":"        self.mox.ReplayAll()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPH%2F%2FkT8%3D","line":345,"in_reply_to":"AAAAPH%2F%2Fkyo%3D","updated":"2013-05-30 12:05:22.000000000","message":"I\u0027m not sure how this can be applied here without messing up indent levels. The rest of the authors of this file didn\u0027t know either it seems ;) (this pattern is all over the place)","commit_id":"31c4190a3331a60641d6497f8b8c5325f7cfd9e2"}]}