)]}'
{"id":"openstack%2Fpython-neutronclient~302046","triplet_id":"openstack%2Fpython-neutronclient~master~I6b0b9ef869033ae77c81052d74affa97c267813d","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1566656","hashtags":[],"change_id":"I6b0b9ef869033ae77c81052d74affa97c267813d","subject":"Do not delete dhcp port when purge tenant\u0027s resource","status":"ABANDONED","created":"2016-04-06 06:28:10.000000000","updated":"2016-07-05 15:35:58.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"74c7a732e6b5d160e79a4b283fa87ebb0e08cfe5","_number":302046,"virtual_id_number":302046,"owner":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":1,"date":"2016-04-07 04:14:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"date":"2016-04-22 00:42:14.000000000","_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"recommended":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"all":[{"value":1,"date":"2016-04-07 04:58:41.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-2,"date":"2016-04-21 20:23:20.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-07 04:14:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-04-07 04:58:41.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-04-21 20:23:20.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"}],"messages":[{"id":"8e5f7a945c3b03100b2188a6e020f44117eba6bb","author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"date":"2016-04-06 06:28:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8140dd9ed48a08ec04bcd49c97baa36b03b156e6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-06 07:25:58.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/46/302046/1/check/gate-python-neutronclient-docs/cffbdad//doc/build/html/ : SUCCESS in 1m 35s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/46/302046/1/check/gate-python-neutronclient-pep8/ed7fb0b/ : SUCCESS in 1m 33s\n- gate-python-neutronclient-python27 http://logs.openstack.org/46/302046/1/check/gate-python-neutronclient-python27/5b5a5c4/ : SUCCESS in 3m 10s\n- gate-python-neutronclient-python34 http://logs.openstack.org/46/302046/1/check/gate-python-neutronclient-python34/f8fa4fb/ : SUCCESS in 3m 36s\n- gate-python-neutronclient-pypy http://logs.openstack.org/46/302046/1/check/gate-python-neutronclient-pypy/bf7ed6e/ : SUCCESS in 3m 53s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/46/302046/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/9765fcb/ : SUCCESS in 55m 42s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/46/302046/1/check/gate-neutronclient-test-dsvm-functional/11d5bb5/ : FAILURE in 24m 28s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/46/302046/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/7915648/ : SUCCESS in 26m 50s","accounts_in_message":[],"_revision_number":1},{"id":"852491964f77debdde0af66636b6bef6d26c026d","author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"date":"2016-04-07 01:32:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"97e55594de9c8b56cc327570ef4709bec46c346b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-07 02:29:08.000000000","message":"Patch Set 2: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/46/302046/2/check/gate-python-neutronclient-docs/8b8efaf//doc/build/html/ : SUCCESS in 1m 28s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/46/302046/2/check/gate-python-neutronclient-pep8/8ba2538/ : SUCCESS in 2m 58s\n- gate-python-neutronclient-python27 http://logs.openstack.org/46/302046/2/check/gate-python-neutronclient-python27/23c62fe/ : SUCCESS in 3m 20s\n- gate-python-neutronclient-python34 http://logs.openstack.org/46/302046/2/check/gate-python-neutronclient-python34/c8f4d3f/ : SUCCESS in 4m 49s\n- gate-python-neutronclient-pypy http://logs.openstack.org/46/302046/2/check/gate-python-neutronclient-pypy/ad46d10/ : SUCCESS in 3m 52s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/46/302046/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/a69ed87/ : SUCCESS in 55m 46s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/46/302046/2/check/gate-neutronclient-test-dsvm-functional/6698024/ : FAILURE in 26m 45s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/46/302046/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/d7c0205/ : SUCCESS in 24m 27s","accounts_in_message":[],"_revision_number":2},{"id":"1aaef36fddd6a09ae144dee2e09d716a541266c5","author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"date":"2016-04-07 03:23:36.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"036cbea85fee4906faffa346a286d58b118e1735","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-07 04:14:05.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/46/302046/3/check/gate-python-neutronclient-docs/fd07096//doc/build/html/ : SUCCESS in 2m 46s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/46/302046/3/check/gate-python-neutronclient-pep8/be53f26/ : SUCCESS in 1m 29s\n- gate-python-neutronclient-python27 http://logs.openstack.org/46/302046/3/check/gate-python-neutronclient-python27/02d34d8/ : SUCCESS in 1m 35s\n- gate-python-neutronclient-python34 http://logs.openstack.org/46/302046/3/check/gate-python-neutronclient-python34/467c64d/ : SUCCESS in 4m 11s\n- gate-python-neutronclient-pypy http://logs.openstack.org/46/302046/3/check/gate-python-neutronclient-pypy/e3afe9a/ : SUCCESS in 4m 15s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/46/302046/3/check/gate-tempest-dsvm-neutron-src-python-neutronclient/41505e9/ : SUCCESS in 49m 19s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/46/302046/3/check/gate-neutronclient-test-dsvm-functional/67392a2/ : SUCCESS in 21m 59s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/46/302046/3/check/gate-neutronclient-test-dsvm-functional-adv-svcs/4fa42ef/ : SUCCESS in 23m 45s","accounts_in_message":[],"_revision_number":3},{"id":"43b64aed8c77320befd6b634a2f01b39a743d316","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-04-07 04:58:41.000000000","message":"Patch Set 3: Code-Review+1\n\nlooks ok to me...","accounts_in_message":[],"_revision_number":3},{"id":"866ed2f26189b88e1382dd1b83521f9071c9c576","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-04-21 20:23:20.000000000","message":"Patch Set 3: Code-Review-2","accounts_in_message":[],"_revision_number":3},{"id":"5ccc702dbb1633dd774da249ba30ecda32133578","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-04-21 20:24:48.000000000","message":"Patch Set 3:\n\nThe network will be deleted and thus even if the port gets rebuilt the system knows how to deal with a concurrent delete. Not sure what the problem is?","accounts_in_message":[],"_revision_number":3},{"id":"c4ee170df0e3b1612d663b254ec50e5f5149dcda","author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"date":"2016-04-22 00:42:14.000000000","message":"Patch Set 3:\n\n@Armando,","accounts_in_message":[],"_revision_number":3},{"id":"c52d8c66266e56bfea330974752132da46e3741a","author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"date":"2016-04-22 00:48:30.000000000","message":"Patch Set 3:\n\n\u003e @Armando,\n\nBut it is true that purge cmd delete the dhcp port, if the network and subnets belong with the tenants who want to delete their resources, they just delete the subnet or network directly. The cmd should not delete the dhcp port which is used by other tenant subnet, even if the network\u0027s tenant exec purge operation.","accounts_in_message":[],"_revision_number":3},{"id":"f4fc90c2c2f3ca01e8e0a08e125304314864a821","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-07-05 15:35:58.000000000","message":"Abandoned\n\nThis review is \u003e 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.","accounts_in_message":[],"_revision_number":3},{"id":"b5fc60015d9df5adf2334c490429dd7146300de5","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-07-05 15:35:58.000000000","message":"Patch Set 3:\n\nThis review is \u003e 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"8019750fa9a85c2a0d984e235fb07173680a5cff","revisions":{"36403556b4b023317d190e43cca21d49a4f2e93d":{"kind":"REWORK","_number":1,"created":"2016-04-06 06:28:10.000000000","uploader":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"ref":"refs/changes/46/302046/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/46/302046/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/1"}}},"commit":{"parents":[{"commit":"939981891df75841ab632635861b01d3e9a9f086","subject":"Merge \"Log SHA1 hash of X-Auth-Token value\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/939981891df75841ab632635861b01d3e9a9f086"}]}],"author":{"name":"ZhaoBo","email":"zhaobo6@huawei.com","date":"2016-04-06 04:03:24.000000000","tz":480},"committer":{"name":"ZhaoBo","email":"zhaobo6@huawei.com","date":"2016-04-06 06:26:49.000000000","tz":480},"subject":"Do not delete dhcp port when purge tenant\u0027s resource","message":"Do not delete dhcp port when purge tenant\u0027s resource\n\nThe original purge logic will delete all ports which are owned by\nspecified tenant. So it will delete the dhcp port, it will cause new port\ncan not get ip addr during rebuilding dhcp port, and the new dhcp port\u0027s\ntenant is still the same as network\u0027s tenant. dhcp port will be deleted\nthrough net-delete or subnet-delete. So we should ignore this unnecessary\nand risky operation when purge.\n\nThis patch ignore the device_owner is \u0027network:dhcp\u0027. Purge operation\nwon\u0027t delete dhcp port.\n\nCloses-Bug: #1566656\nChange-Id: I6b0b9ef869033ae77c81052d74affa97c267813d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/36403556b4b023317d190e43cca21d49a4f2e93d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/36403556b4b023317d190e43cca21d49a4f2e93d"}]},"branch":"refs/heads/master"},"4053f6241689a743def5c17aa99f46f8c8f6ab0f":{"kind":"REWORK","_number":2,"created":"2016-04-07 01:32:02.000000000","uploader":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"ref":"refs/changes/46/302046/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/46/302046/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/2"}}},"commit":{"parents":[{"commit":"939981891df75841ab632635861b01d3e9a9f086","subject":"Merge \"Log SHA1 hash of X-Auth-Token value\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/939981891df75841ab632635861b01d3e9a9f086"}]}],"author":{"name":"ZhaoBo","email":"zhaobo6@huawei.com","date":"2016-04-06 04:03:24.000000000","tz":480},"committer":{"name":"ZhaoBo","email":"zhaobo6@huawei.com","date":"2016-04-07 01:31:12.000000000","tz":480},"subject":"Do not delete dhcp port when purge tenant\u0027s resource","message":"Do not delete dhcp port when purge tenant\u0027s resource\n\nThe original purge logic will delete all ports which are owned by\nspecified tenant. So it will delete the dhcp port, it will cause new port\ncan not get ip addr during rebuilding dhcp port, and the new dhcp port\u0027s\ntenant is still the same as network\u0027s tenant. dhcp port will be deleted\nthrough net-delete or subnet-delete. So we should ignore this unnecessary\nand risky operation when purge.\n\nThis patch ignore the device_owner is \u0027network:dhcp\u0027. Purge operation\nwon\u0027t delete dhcp port.\n\nCloses-Bug: #1566656\nChange-Id: I6b0b9ef869033ae77c81052d74affa97c267813d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/4053f6241689a743def5c17aa99f46f8c8f6ab0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/4053f6241689a743def5c17aa99f46f8c8f6ab0f"}]},"branch":"refs/heads/master"},"8019750fa9a85c2a0d984e235fb07173680a5cff":{"kind":"REWORK","_number":3,"created":"2016-04-07 03:23:36.000000000","uploader":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"ref":"refs/changes/46/302046/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/46/302046/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/46/302046/3"}}},"commit":{"parents":[{"commit":"939981891df75841ab632635861b01d3e9a9f086","subject":"Merge \"Log SHA1 hash of X-Auth-Token value\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/939981891df75841ab632635861b01d3e9a9f086"}]}],"author":{"name":"ZhaoBo","email":"zhaobo6@huawei.com","date":"2016-04-06 04:03:24.000000000","tz":480},"committer":{"name":"ZhaoBo","email":"zhaobo6@huawei.com","date":"2016-04-07 03:18:24.000000000","tz":480},"subject":"Do not delete dhcp port when purge tenant\u0027s resource","message":"Do not delete dhcp port when purge tenant\u0027s resource\n\nThe original purge logic will delete all ports which are owned by\nspecified tenant. So it will delete the dhcp port, it will cause new port\ncan not get ip addr during rebuilding dhcp port, and the new dhcp port\u0027s\ntenant is still the same as network\u0027s tenant. dhcp port will be deleted\nthrough net-delete or subnet-delete. So we should ignore this unnecessary\nand risky operation when purge.\n\nThis patch ignore the device_owner is \u0027network:dhcp\u0027. Purge operation\nwon\u0027t delete dhcp port.\n\nCloses-Bug: #1566656\nChange-Id: I6b0b9ef869033ae77c81052d74affa97c267813d\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8019750fa9a85c2a0d984e235fb07173680a5cff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8019750fa9a85c2a0d984e235fb07173680a5cff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}