)]}'
{"neutronclient/neutron/v2_0/subnet.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c980e7fc4ced53d86510b37d9a364152a78aee07","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            \u0027--prefixlen\u0027, metavar\u003d\u0027PREFIX_LENGTH\u0027,"},{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment-id\u0027, metavar\u003d\u0027SEGMENT_ID\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027ID of segment with which this subnet will be \u0027"},{"line_number":207,"context_line":"                   \u0027associated.\u0027))"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_a7470076","line":205,"range":{"start_line":205,"start_character":37,"end_line":205,"end_character":47},"updated":"2016-05-25 11:14:39.000000000","message":"Again, I suggest using SEGMENT here.","commit_id":"b21c5e91262189e9d76209d1b34148c785615c14"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"c980e7fc4ced53d86510b37d9a364152a78aee07","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            \u0027--prefixlen\u0027, metavar\u003d\u0027PREFIX_LENGTH\u0027,"},{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment-id\u0027, metavar\u003d\u0027SEGMENT_ID\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027ID of segment with which this subnet will be \u0027"},{"line_number":207,"context_line":"                   \u0027associated.\u0027))"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c744c475","line":205,"range":{"start_line":205,"start_character":13,"end_line":205,"end_character":25},"updated":"2016-05-25 11:14:39.000000000","message":"I suggestion using --segment in case name is support in the future.","commit_id":"b21c5e91262189e9d76209d1b34148c785615c14"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"33b811b923ea496be43eb3e997c6fe90e245817a","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            \u0027--prefixlen\u0027, metavar\u003d\u0027PREFIX_LENGTH\u0027,"},{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment-id\u0027, metavar\u003d\u0027SEGMENT_ID\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027ID of segment with which this subnet will be \u0027"},{"line_number":207,"context_line":"                   \u0027associated.\u0027))"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_4c49ed5f","line":205,"range":{"start_line":205,"start_character":13,"end_line":205,"end_character":25},"in_reply_to":"7aa08908_a6ab9e1c","updated":"2016-06-13 08:57:56.000000000","message":"will change it to --segment in next PS","commit_id":"b21c5e91262189e9d76209d1b34148c785615c14"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"9627c77badd009333d973f254863277534f1b7c5","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            \u0027--prefixlen\u0027, metavar\u003d\u0027PREFIX_LENGTH\u0027,"},{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment-id\u0027, metavar\u003d\u0027SEGMENT_ID\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027ID of segment with which this subnet will be \u0027"},{"line_number":207,"context_line":"                   \u0027associated.\u0027))"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_a6ab9e1c","line":205,"range":{"start_line":205,"start_character":13,"end_line":205,"end_character":25},"in_reply_to":"9abb7d3a_7811c35c","updated":"2016-06-06 16:24:15.000000000","message":"We do plan to have a name in the future.  Also, for consistency, I think --segment is better.  It is much easier to change this now than after this merges.","commit_id":"b21c5e91262189e9d76209d1b34148c785615c14"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ccd3783bc14c56720bc5e25ec283ba02c4aa02f8","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            \u0027--prefixlen\u0027, metavar\u003d\u0027PREFIX_LENGTH\u0027,"},{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment-id\u0027, metavar\u003d\u0027SEGMENT_ID\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027ID of segment with which this subnet will be \u0027"},{"line_number":207,"context_line":"                   \u0027associated.\u0027))"},{"line_number":208,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_7811c35c","line":205,"range":{"start_line":205,"start_character":13,"end_line":205,"end_character":25},"in_reply_to":"bab6814e_c744c475","updated":"2016-06-01 14:40:56.000000000","message":"Segments don\u0027t currently have names so this probably isn\u0027t necessary, but it\u0027s a sensible suggestion for future-proofing.","commit_id":"b21c5e91262189e9d76209d1b34148c785615c14"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"7e146aaefede1083d56661e4c16a589a0faf0be9","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment\u0027, metavar\u003d\u0027SEGMENT\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027Segment with which this subnet will be associated.\u0027))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def args2body(self, parsed_args):"},{"line_number":209,"context_line":"        _network_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_9b282935","line":206,"updated":"2016-06-13 11:48:02.000000000","message":"\"ID of segment with which...\" would make it clear that we only accept ID for now.","commit_id":"27871831fbf713738a85085c98ed1ad89e6bdc5b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"2db9d550ee7a97bbc3059c3e76a35b0caff4737e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment\u0027, metavar\u003d\u0027SEGMENT\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027Segment with which this subnet will be associated.\u0027))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def args2body(self, parsed_args):"},{"line_number":209,"context_line":"        _network_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_61062787","line":206,"in_reply_to":"7aa08908_0cc84854","updated":"2016-06-14 14:36:13.000000000","message":"Done","commit_id":"27871831fbf713738a85085c98ed1ad89e6bdc5b"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"9c54767ee172e834ef7066411c31be334acdfb44","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment\u0027, metavar\u003d\u0027SEGMENT\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027Segment with which this subnet will be associated.\u0027))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def args2body(self, parsed_args):"},{"line_number":209,"context_line":"        _network_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_ec07bc15","line":206,"in_reply_to":"7aa08908_46c7dd97","updated":"2016-06-14 11:01:18.000000000","message":"The help text should accurately reflect the usage of the argument at all times, and it will be simple to update if/when the name is added as a valid input.","commit_id":"27871831fbf713738a85085c98ed1ad89e6bdc5b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"6af4917801d86b9d2e3196d57a7efa1bcf59e732","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment\u0027, metavar\u003d\u0027SEGMENT\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027Segment with which this subnet will be associated.\u0027))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def args2body(self, parsed_args):"},{"line_number":209,"context_line":"        _network_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_46c7dd97","line":206,"in_reply_to":"7aa08908_9b282935","updated":"2016-06-14 05:12:37.000000000","message":"I add the help text like this intentionally. Although it only supports id now, name will be support in future. I don\u0027t want to add another patch to change the help text. But I am not 100% sure this is appropriate, I will see others comments. If more voice say it should be changed, I will modify it.","commit_id":"27871831fbf713738a85085c98ed1ad89e6bdc5b"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6b2fb5a4c0a043384e5baeba2181b22a950da27d","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            help\u003d_(\u0027Prefix length for subnet allocation from subnetpool.\u0027))"},{"line_number":204,"context_line":"        parser.add_argument("},{"line_number":205,"context_line":"            \u0027--segment\u0027, metavar\u003d\u0027SEGMENT\u0027,"},{"line_number":206,"context_line":"            help\u003d_(\u0027Segment with which this subnet will be associated.\u0027))"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def args2body(self, parsed_args):"},{"line_number":209,"context_line":"        _network_id \u003d neutronV20.find_resourceid_by_name_or_id("}],"source_content_type":"text/x-python","patch_set":3,"id":"7aa08908_0cc84854","line":206,"in_reply_to":"7aa08908_ec07bc15","updated":"2016-06-14 11:13:27.000000000","message":"I agree.","commit_id":"27871831fbf713738a85085c98ed1ad89e6bdc5b"}]}