)]}'
{"tools/tox_install.sh":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e56cc2ce30348d9b06f910e4b37c00c7eb4af0ca","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    mydir\u003d$(mktemp -dt \"$CLIENT_NAME-tox_install-XXXXXXX\")"},{"line_number":21,"context_line":"    localfile\u003d$mydir/upper-constraints.txt"},{"line_number":22,"context_line":"    if [ $CONSTRAINTS_FILE !\u003d http* ]; then"},{"line_number":23,"context_line":"        CONSTRAINTS_FILE\u003dfile://$CONSTRAINTS_FILE"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"    curl $CONSTRAINTS_FILE -k -o $localfile"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bab6814e_c1cfc2ae","line":22,"range":{"start_line":22,"start_character":3,"end_line":22,"end_character":43},"updated":"2016-05-18 17:14:19.000000000","message":"In my local env, this expression does not work.\nbash specific condition works:\n\n  if [[ ... ]]; then","commit_id":"90f4b2034fd28a145b02dfbf485d1829ba5072d2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5167cf88ee904b17cea6041f5603d595d904aae","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    mydir\u003d$(mktemp -dt \"$CLIENT_NAME-tox_install-XXXXXXX\")"},{"line_number":21,"context_line":"    localfile\u003d$mydir/upper-constraints.txt"},{"line_number":22,"context_line":"    if [ $CONSTRAINTS_FILE !\u003d http* ]; then"},{"line_number":23,"context_line":"        CONSTRAINTS_FILE\u003dfile://$CONSTRAINTS_FILE"},{"line_number":24,"context_line":"    fi"},{"line_number":25,"context_line":"    curl $CONSTRAINTS_FILE -k -o $localfile"}],"source_content_type":"text/x-sh","patch_set":4,"id":"bab6814e_037d2e6e","line":22,"range":{"start_line":22,"start_character":3,"end_line":22,"end_character":43},"in_reply_to":"bab6814e_c1cfc2ae","updated":"2016-05-19 09:49:51.000000000","message":"Done","commit_id":"90f4b2034fd28a145b02dfbf485d1829ba5072d2"}],"tox.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"639f9318b03d76119bfa77411252759f3454d94c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"         LC_ALL\u003dC"},{"line_number":12,"context_line":"usedevelop \u003d True"},{"line_number":13,"context_line":"install_command \u003d"},{"line_number":14,"context_line":"    {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"# Delete bytecodes from normal directories before running tests."}],"source_content_type":"text/x-properties","patch_set":4,"id":"bab6814e_f849dad1","line":14,"updated":"2016-05-18 16:51:31.000000000","message":"Do we really need tox_isntall.sh to support the constrainted env?\nIn my understanding, tox_install.sh was introduced to handle neutron dependency in neutron subproject. I think we can simply use \u0027pip install -c \u003cconstraint-file\u003e\u0027 as nova does [1].\n\n[1] http://git.openstack.org/cgit/openstack/nova/tree/tox.ini#n12","commit_id":"90f4b2034fd28a145b02dfbf485d1829ba5072d2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5167cf88ee904b17cea6041f5603d595d904aae","unresolved":false,"context_lines":[{"line_number":11,"context_line":"         LC_ALL\u003dC"},{"line_number":12,"context_line":"usedevelop \u003d True"},{"line_number":13,"context_line":"install_command \u003d"},{"line_number":14,"context_line":"    {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"# Delete bytecodes from normal directories before running tests."}],"source_content_type":"text/x-properties","patch_set":4,"id":"bab6814e_030a4e21","line":14,"in_reply_to":"bab6814e_f23e12b7","updated":"2016-05-19 09:49:51.000000000","message":"The commit message already describe why tox_install.sh is required.  Thanks. I forgot to comment this here and commented in the cover comment.","commit_id":"90f4b2034fd28a145b02dfbf485d1829ba5072d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3c9424811075b13023fe6adc612ebe56d52b2f24","unresolved":false,"context_lines":[{"line_number":11,"context_line":"         LC_ALL\u003dC"},{"line_number":12,"context_line":"usedevelop \u003d True"},{"line_number":13,"context_line":"install_command \u003d"},{"line_number":14,"context_line":"    {toxinidir}/tools/tox_install.sh {env:UPPER_CONSTRAINTS_FILE:https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt} {opts} {packages}"},{"line_number":15,"context_line":"deps \u003d -r{toxinidir}/requirements.txt"},{"line_number":16,"context_line":"       -r{toxinidir}/test-requirements.txt"},{"line_number":17,"context_line":"# Delete bytecodes from normal directories before running tests."}],"source_content_type":"text/x-properties","patch_set":4,"id":"bab6814e_f23e12b7","line":14,"in_reply_to":"bab6814e_f849dad1","updated":"2016-05-18 18:13:52.000000000","message":"Yes, as per commit message.","commit_id":"90f4b2034fd28a145b02dfbf485d1829ba5072d2"}]}