)]}'
{"id":"openstack%2Fpython-neutronclient~320889","triplet_id":"openstack%2Fpython-neutronclient~master~Ic9e02b80a4f1ed5a6f2dc0abaa9662d6e53ce42e","project":"openstack/python-neutronclient","branch":"master","topic":"zlatan","hashtags":[],"change_id":"Ic9e02b80a4f1ed5a6f2dc0abaa9662d6e53ce42e","subject":"Minor tweaks about remove useless returns","status":"ABANDONED","created":"2016-05-25 10:45:16.000000000","updated":"2016-09-07 06:41:14.000000000","total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2bb76e46ee0df311a87d14ff9646c468669a6378","_number":320889,"virtual_id_number":320889,"owner":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":-1,"date":"2016-08-11 21:55:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"all":[{"value":1,"date":"2016-06-14 05:24:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-06-14 05:24:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":1,"date":"2016-06-14 05:24:21.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-26 18:52:49.000000000","updated_by":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"reviewer":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"state":"REVIEWER"},{"updated":"2016-05-27 05:31:57.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2016-05-27 09:19:13.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-08-11 21:55:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ce6d092496bd31265e663b0fa1a4bdb6aeb3081f","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2016-05-25 10:45:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5954fd33e3b804d552aedf82adbdaa34c8e464ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-25 11:52:00.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/89/320889/1/check/gate-python-neutronclient-docs/152fb8f//doc/build/html/ : SUCCESS in 1m 53s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/89/320889/1/check/gate-python-neutronclient-pep8/995814e/ : SUCCESS in 2m 50s\n- gate-python-neutronclient-python27 http://logs.openstack.org/89/320889/1/check/gate-python-neutronclient-python27/62ef87e/ : SUCCESS in 2m 57s\n- gate-python-neutronclient-python34 http://logs.openstack.org/89/320889/1/check/gate-python-neutronclient-python34/5ff80bd/ : SUCCESS in 4m 28s\n- gate-python-neutronclient-pypy http://logs.openstack.org/89/320889/1/check/gate-python-neutronclient-pypy/d670a1f/ : FAILURE in 2m 16s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/89/320889/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/a45f271/ : SUCCESS in 1h 00m 20s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/89/320889/1/check/gate-neutronclient-test-dsvm-functional/75c35e1/ : SUCCESS in 18m 47s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/89/320889/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/d5c06a1/ : SUCCESS in 24m 44s","accounts_in_message":[],"_revision_number":1},{"id":"e2fd962fc26ea4e9b17534141f9abb63202fd05a","author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"date":"2016-05-25 23:33:43.000000000","message":"Patch Set 1: Code-Review-1\n\nMight as well cleanup all the way\n\nneutronclient/v2_0/client.py:            return None\nneutronclient/neutron/v2_0/lb/pool.py:            return None\nneutronclient/neutron/v2_0/__init__.py:            return None\nneutronclient/neutron/v2_0/network_ip_availability.py:            return None\nneutronclient/neutron/v2_0/auto_allocated_topology.py:            return None\nneutronclient/common/utils.py:        return None","accounts_in_message":[],"_revision_number":1},{"id":"57ab3bb99b2c9a32699b4f388c11b7fcca7e66c6","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2016-05-26 04:45:01.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0756c4024ae53a528289cf5bb704bc5793620ca5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-26 05:49:21.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/89/320889/2/check/gate-python-neutronclient-docs/afe366c//doc/build/html/ : SUCCESS in 1m 46s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/89/320889/2/check/gate-python-neutronclient-pep8/bc657ed/ : SUCCESS in 2m 23s\n- gate-python-neutronclient-python27 http://logs.openstack.org/89/320889/2/check/gate-python-neutronclient-python27/307aa95/ : SUCCESS in 2m 10s\n- gate-python-neutronclient-python34 http://logs.openstack.org/89/320889/2/check/gate-python-neutronclient-python34/20a4df9/ : SUCCESS in 2m 53s\n- gate-python-neutronclient-pypy http://logs.openstack.org/89/320889/2/check/gate-python-neutronclient-pypy/d1f09f8/ : FAILURE in 2m 12s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/89/320889/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/53d5d8a/ : SUCCESS in 1h 01m 42s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/89/320889/2/check/gate-neutronclient-test-dsvm-functional/9f40a52/ : SUCCESS in 23m 39s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/89/320889/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/1a70b57/ : SUCCESS in 21m 48s","accounts_in_message":[],"_revision_number":2},{"id":"42f832d3b54f2fdc8d7312fa2eeb15a8f321ec2d","author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"date":"2016-05-26 18:52:49.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"e9c29d504b54219523fa5b73457baaa9a640469b","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2016-05-27 05:31:57.000000000","message":"Patch Set 2: Code-Review+1\n\ni feel an explicit \"return None\" more readable for some cases but it\u0027s probably a matter of preference.","accounts_in_message":[],"_revision_number":2},{"id":"b649c908e4cb4d63d7b5131f4e70f5a113a7c835","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-05-27 09:19:13.000000000","message":"Patch Set 2: Code-Review+1\n\nI am FOR this patch, but just a point which I mentioned ...","accounts_in_message":[],"_revision_number":2},{"id":"5cff9db58134317893c55dd1c14fefa67d76c6b3","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-05-27 09:19:41.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"537834d66bfbd244be8764a0bdd1fad3e92780a9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-11 07:56:12.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"772ca1d804976ff05c968704a4c08282975f31b3","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2016-06-14 05:24:21.000000000","message":"Uploaded patch set 3: Patch Set 2 was rebased.","accounts_in_message":[],"_revision_number":3},{"id":"c83c9bdfc78389ed23f588ad6a79929308c52f26","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-14 06:39:18.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/89/320889/3/check/gate-python-neutronclient-docs/04c907a//doc/build/html/ : SUCCESS in 2m 58s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/89/320889/3/check/gate-python-neutronclient-pep8/d42be0a/ : SUCCESS in 2m 38s\n- gate-python-neutronclient-python27 http://logs.openstack.org/89/320889/3/check/gate-python-neutronclient-python27/0ef3c0d/ : SUCCESS in 2m 43s\n- gate-python-neutronclient-python34 http://logs.openstack.org/89/320889/3/check/gate-python-neutronclient-python34/9935aa2/ : SUCCESS in 3m 34s\n- gate-python-neutronclient-pypy http://logs.openstack.org/89/320889/3/check/gate-python-neutronclient-pypy/43a7f2b/ : FAILURE in 4m 40s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/89/320889/3/check/gate-tempest-dsvm-neutron-src-python-neutronclient/15c207f/ : SUCCESS in 1h 13m 22s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/89/320889/3/check/gate-neutronclient-test-dsvm-functional/39d4b86/ : SUCCESS in 23m 21s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/89/320889/3/check/gate-neutronclient-test-dsvm-functional-adv-svcs/5efca7c/ : SUCCESS in 17m 18s","accounts_in_message":[],"_revision_number":3},{"id":"db8894510e2dbb73db60d7fff2e65626b79a7365","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-11 21:55:09.000000000","message":"Patch Set 3: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":3},{"id":"36ea298d11b4fa55dc610b5bc3ef51089a5973db","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2016-09-07 06:41:14.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e983b8a48b1ceb2ab9a4af4e2f015457c4030674","revisions":{"6511510116121727707b4f446de46fae228dfdb7":{"kind":"REWORK","_number":1,"created":"2016-05-25 10:45:16.000000000","uploader":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"ref":"refs/changes/89/320889/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/89/320889/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/1"}}},"commit":{"parents":[{"commit":"53a59e5aa2e838612852328f0cf3e4eb4f65ed43","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/53a59e5aa2e838612852328f0cf3e4eb4f65ed43"}]}],"author":{"name":"Gary Kotton","email":"gkotton@vmware.com","date":"2016-05-25 10:44:06.000000000","tz":-420},"committer":{"name":"Gary Kotton","email":"gkotton@vmware.com","date":"2016-05-25 10:44:06.000000000","tz":-420},"subject":"Minor tweaks about remove useless returns","message":"Minor tweaks about remove useless returns\n\n- Remove \u0027return\u0027 where it is not needed\n- Use return instead of return None. None is returned by default\n\nTrivialFix\n\nChange-Id: Ic9e02b80a4f1ed5a6f2dc0abaa9662d6e53ce42e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/6511510116121727707b4f446de46fae228dfdb7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/6511510116121727707b4f446de46fae228dfdb7"}]},"branch":"refs/heads/master"},"2a07fa94d3f5f9913ec3116216c61f59e8acbb90":{"kind":"REWORK","_number":2,"created":"2016-05-26 04:45:01.000000000","uploader":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"ref":"refs/changes/89/320889/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/89/320889/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/2"}}},"commit":{"parents":[{"commit":"53a59e5aa2e838612852328f0cf3e4eb4f65ed43","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/53a59e5aa2e838612852328f0cf3e4eb4f65ed43"}]}],"author":{"name":"Gary Kotton","email":"gkotton@vmware.com","date":"2016-05-25 10:44:06.000000000","tz":-420},"committer":{"name":"Gary Kotton","email":"gkotton@vmware.com","date":"2016-05-26 04:44:42.000000000","tz":-420},"subject":"Minor tweaks about remove useless returns","message":"Minor tweaks about remove useless returns\n\n- Remove \u0027return\u0027 where it is not needed\n- Use return instead of return None. None is returned by default\n\nTrivialFix\n\nChange-Id: Ic9e02b80a4f1ed5a6f2dc0abaa9662d6e53ce42e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/2a07fa94d3f5f9913ec3116216c61f59e8acbb90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/2a07fa94d3f5f9913ec3116216c61f59e8acbb90"}]},"branch":"refs/heads/master"},"e983b8a48b1ceb2ab9a4af4e2f015457c4030674":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-06-14 05:24:21.000000000","uploader":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"ref":"refs/changes/89/320889/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/89/320889/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/89/320889/3"}}},"commit":{"parents":[{"commit":"521ff7cee562df5105c6404fadb261092af7e342","subject":"Add no-shared option to qos-policy-update command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/521ff7cee562df5105c6404fadb261092af7e342"}]}],"author":{"name":"Gary Kotton","email":"gkotton@vmware.com","date":"2016-05-25 10:44:06.000000000","tz":-420},"committer":{"name":"Gary Kotton","email":"gkotton@vmware.com","date":"2016-06-14 05:24:03.000000000","tz":-420},"subject":"Minor tweaks about remove useless returns","message":"Minor tweaks about remove useless returns\n\n- Remove \u0027return\u0027 where it is not needed\n- Use return instead of return None. None is returned by default\n\nTrivialFix\n\nChange-Id: Ic9e02b80a4f1ed5a6f2dc0abaa9662d6e53ce42e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/e983b8a48b1ceb2ab9a4af4e2f015457c4030674"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/e983b8a48b1ceb2ab9a4af4e2f015457c4030674"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}