)]}'
{"id":"openstack%2Fpython-neutronclient~323182","triplet_id":"openstack%2Fpython-neutronclient~master~I0a4e35d4741ac3fb33e0e05b2b0702d5f773e08c","project":"openstack/python-neutronclient","branch":"master","topic":"bgp_speaker_create","hashtags":[],"change_id":"I0a4e35d4741ac3fb33e0e05b2b0702d5f773e08c","subject":"Update the bgp-peer-create CLI","status":"ABANDONED","created":"2016-05-31 07:54:53.000000000","updated":"2017-02-20 15:57:14.000000000","total_comment_count":14,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"835cf9b12618db67bcb43051e7c7f561f863c4a7","_number":323182,"virtual_id_number":323182,"owner":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":1,"date":"2016-07-08 10:19:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-07-08 09:22:39.000000000","_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"disliked":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":-1,"date":"2016-07-08 09:19:38.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":-1,"date":"2017-02-16 01:42:37.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":1,"date":"2016-07-08 08:53:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-05-31 07:57:06.000000000","updated_by":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"reviewer":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"state":"REVIEWER"},{"updated":"2016-05-31 07:57:25.000000000","updated_by":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"reviewer":{"_account_id":17455,"name":"Na Zhu","email":"juno.zhu@huawei.com","username":"Na"},"state":"REVIEWER"},{"updated":"2016-05-31 07:58:37.000000000","updated_by":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"reviewer":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"state":"REVIEWER"},{"updated":"2016-05-31 08:51:50.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-05-31 09:01:47.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2016-06-01 15:04:58.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2016-06-07 05:51:08.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2016-06-16 16:18:59.000000000","updated_by":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"reviewer":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"state":"REVIEWER"},{"updated":"2016-07-08 09:19:38.000000000","updated_by":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"reviewer":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"state":"REVIEWER"},{"updated":"2016-07-08 10:19:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-02-16 01:42:37.000000000","updated_by":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"reviewer":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"state":"REVIEWER"}],"messages":[{"id":"4fc0a0276e78fcc682ebef0f76cc097791b80adf","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-05-31 07:54:53.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2bc9d5561d1e61d0461cf6b1ff9867c42d4df8eb","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-05-31 08:51:50.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM for now....","accounts_in_message":[],"_revision_number":1},{"id":"fbe047f0a7ba1433932a2c6b526835bf7399493e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-31 09:00:44.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/82/323182/1/check/gate-python-neutronclient-docs/9f465a1//doc/build/html/ : SUCCESS in 3m 08s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/82/323182/1/check/gate-python-neutronclient-pep8/60e9e62/ : SUCCESS in 1m 36s\n- gate-python-neutronclient-python27 http://logs.openstack.org/82/323182/1/check/gate-python-neutronclient-python27/6fa9e04/ : SUCCESS in 2m 22s\n- gate-python-neutronclient-python34 http://logs.openstack.org/82/323182/1/check/gate-python-neutronclient-python34/35ccc31/ : SUCCESS in 3m 51s\n- gate-python-neutronclient-pypy http://logs.openstack.org/82/323182/1/check/gate-python-neutronclient-pypy/4d6c27d/ : FAILURE in 3m 12s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/82/323182/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/a37f0da/ : SUCCESS in 1h 04m 35s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/82/323182/1/check/gate-neutronclient-test-dsvm-functional/9930c8e/ : SUCCESS in 23m 48s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/82/323182/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/2223916/ : SUCCESS in 13m 06s","accounts_in_message":[],"_revision_number":1},{"id":"66c8d455ac6a244882cfa51a210d18733e134357","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2016-06-01 07:50:59.000000000","message":"Patch Set 1: Code-Review-1\n\nLet\u0027s not do this as we already support these option for Mitaka and backward compatibility will be lost..","accounts_in_message":[],"_revision_number":1},{"id":"c863feda1347291d5d45f57f991b77e764ff8fd1","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-01 08:07:31.000000000","message":"Patch Set 1:\n\nHi Vikram,\n\nBut it is wrong, how do we address it? keep it in wrong way? I am not sure why we can not break the backward compatibility for this CLI, it is not a blocker like migration script. It does not break anything.","accounts_in_message":[],"_revision_number":1},{"id":"0f3cc773bc6791da63a2ca8f697e66b10f47e8f6","author":{"_account_id":15309,"name":"zhaobo","email":"bzhaojyathousandy@gmail.com","username":"ZhaoBo"},"date":"2016-06-01 08:15:03.000000000","message":"Patch Set 1:\n\nHi， I think the --option should be supported. I feel it so strange if we use the CLI like:\ncmd Aparam Bparam \nIn this way I must make these params in the right order.\nAnd I found lbaasv2 CLI also maintains --option if the param is required.","accounts_in_message":[],"_revision_number":1},{"id":"dae95f60a0c39176c4be3cec4dc89a137a28e254","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-01 09:36:33.000000000","message":"Patch Set 1:\n\nOkay, so I think we should find a good way to address it. If we want to keep \u0027--\u0027 for backward compatibility, we\u0027d better find a way move the required attribute outside the \u0027Optional arguments\u0027 section","accounts_in_message":[],"_revision_number":1},{"id":"17293080a7e53f59bbdfe80f5348ea45c4ca370c","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2016-06-01 12:09:27.000000000","message":"Patch Set 1:\n\nI am not sure about this.. I can find lot of CLI\u0027s does like this.. \n\nhttps://github.com/openstack/python-neutronclient/search?utf8\u003d%E2%9C%93\u0026q\u003drequired%3DTrue","accounts_in_message":[],"_revision_number":1},{"id":"db8af5914afe7b98c8515bda690d4eb03421dd5d","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-06-01 15:04:58.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nAs other reviewers mentioned, this change is not backward-compatible.\nIMO we should keep the current one from various reasons.\n\n- We can use \u0027--xxx\u0027 style option for required option.\n- It is difficult to support both positional and optional arguments for same parameters.\n- by using \u0027--xxx\u0027 style option we can easily know what an option means and we do not need to take care of the order.\n\nIMHO it is not user friendly to have multiple positional arguments and I tend to like \u0027--xxx\u0027 style options. Can you remember the order of peer-id and remote-as? I believe I cannot.\n\nFinally, it is a good idea to move required options to clarify which are optional and which are required.","accounts_in_message":[],"_revision_number":1},{"id":"6e03372282b391a5cfd1ce55922af4638c98cf29","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-03 08:38:54.000000000","message":"Patch Set 1:\n\n(2 comments)\n\nHi vikram and Akihiro,\n\nThanks for your kindly review and comments, I will update the patch to add a new argument group name \u0027required arguments\u0027, thanks again.","accounts_in_message":[],"_revision_number":1},{"id":"a5112a4163623ff0c739ac911dadee7dcdf50a28","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2016-06-05 05:43:09.000000000","message":"Patch Set 1:\n\nLet\u0027s abandon this change for now ...","accounts_in_message":[],"_revision_number":1},{"id":"708811fde7a9e569264473b1dae93e3557ee43ac","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-07 01:56:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"96004aafa660f7a1d05b7f5dd636fc52e4c4f726","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-07 01:59:18.000000000","message":"Patch Set 2:\n\n@vikram, I have updated the patch and open a new bug, please review it. After patching it, the response would add a new group named \u0027required arguments\u0027, and I put the required parameters into this new group.","accounts_in_message":[],"_revision_number":2},{"id":"07057d3cf604c296bd1acc9594734d17d06a933c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-07 03:04:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/82/323182/2/check/gate-python-neutronclient-docs/2a932d4//doc/build/html/ : SUCCESS in 7m 38s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/82/323182/2/check/gate-python-neutronclient-pep8/d289721/ : SUCCESS in 2m 54s\n- gate-python-neutronclient-python27 http://logs.openstack.org/82/323182/2/check/gate-python-neutronclient-python27/02b4c8d/ : SUCCESS in 7m 46s\n- gate-python-neutronclient-python34 http://logs.openstack.org/82/323182/2/check/gate-python-neutronclient-python34/269b006/ : SUCCESS in 4m 02s\n- gate-python-neutronclient-pypy http://logs.openstack.org/82/323182/2/check/gate-python-neutronclient-pypy/666b14b/ : FAILURE in 2m 15s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/82/323182/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/0a18086/ : SUCCESS in 1h 02m 28s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/82/323182/2/check/gate-neutronclient-test-dsvm-functional/6b5769b/ : SUCCESS in 22m 40s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/82/323182/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/97157ba/ : SUCCESS in 22m 11s","accounts_in_message":[],"_revision_number":2},{"id":"d05e2dc13a453ca9ea4a396f209e43c716ea2e10","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-11 07:56:12.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"f3f7035d80e34987dab930f53d6923776e6b9de2","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-13 02:25:47.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"198796f6b81f997bfa37b9963c1e607e4c4c0c0e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-13 03:19:11.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/82/323182/3/check/gate-python-neutronclient-docs/890f07a//doc/build/html/ : SUCCESS in 2m 01s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/82/323182/3/check/gate-python-neutronclient-pep8/be2d0ce/ : SUCCESS in 2m 12s\n- gate-python-neutronclient-python27 http://logs.openstack.org/82/323182/3/check/gate-python-neutronclient-python27/f5f3a7c/ : SUCCESS in 2m 21s\n- gate-python-neutronclient-python34 http://logs.openstack.org/82/323182/3/check/gate-python-neutronclient-python34/7afee91/ : SUCCESS in 3m 14s\n- gate-python-neutronclient-pypy http://logs.openstack.org/82/323182/3/check/gate-python-neutronclient-pypy/2a24561/ : FAILURE in 2m 23s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/82/323182/3/check/gate-tempest-dsvm-neutron-src-python-neutronclient/7407116/ : SUCCESS in 53m 17s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/82/323182/3/check/gate-neutronclient-test-dsvm-functional/f369014/ : SUCCESS in 24m 27s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/82/323182/3/check/gate-neutronclient-test-dsvm-functional-adv-svcs/7409b4b/ : SUCCESS in 26m 02s","accounts_in_message":[],"_revision_number":3},{"id":"6e30afe810bc55328e339d778b3e2c2e6ae816b7","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2016-06-15 06:37:41.000000000","message":"Patch Set 3: Code-Review-1\n\n(3 comments)\n\nCan you please provide output snippet for this change ?","accounts_in_message":[],"_revision_number":3},{"id":"a214e6eef0b35a5ebb73d77f1e327857d4b96b33","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-15 08:35:20.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"c40f9cea44e949dc37f0e5f3b67573db92789daa","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-15 08:36:03.000000000","message":"Patch Set 3:\n\n(2 comments)\n\n@Vikram, really thanks for your review, I have replied your questions and paste the updated result. please review it again.","accounts_in_message":[],"_revision_number":3},{"id":"32813c926dea19247fa41c8f4fd4e5f46eaf9519","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-06-15 09:53:17.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/82/323182/4/check/gate-python-neutronclient-docs/8c6c04f//doc/build/html/ : SUCCESS in 2m 18s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/82/323182/4/check/gate-python-neutronclient-pep8/fccc623/ : SUCCESS in 3m 06s\n- gate-python-neutronclient-python27 http://logs.openstack.org/82/323182/4/check/gate-python-neutronclient-python27/a6a1c4f/ : SUCCESS in 2m 16s\n- gate-python-neutronclient-python34 http://logs.openstack.org/82/323182/4/check/gate-python-neutronclient-python34/ab21da5/ : SUCCESS in 4m 36s\n- gate-python-neutronclient-pypy http://logs.openstack.org/82/323182/4/check/gate-python-neutronclient-pypy/d24700a/ : FAILURE in 2m 29s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/82/323182/4/check/gate-tempest-dsvm-neutron-src-python-neutronclient/deb2b07/ : SUCCESS in 1h 15m 44s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/82/323182/4/check/gate-neutronclient-test-dsvm-functional/9d84e2a/ : SUCCESS in 38m 57s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/82/323182/4/check/gate-neutronclient-test-dsvm-functional-adv-svcs/c7dba08/ : SUCCESS in 26m 04s","accounts_in_message":[],"_revision_number":4},{"id":"737a53a5d0c997d9bc3e1d5709510e409aea9854","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2016-06-15 14:56:25.000000000","message":"Patch Set 3:\n\n(2 comments)","accounts_in_message":[],"_revision_number":3},{"id":"7a2b0522a5948bdca0459412c0878954a8257339","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2016-06-15 14:57:05.000000000","message":"Patch Set 4:\n\nHow about showing the \u0027required\u0027 section before the \u0027optional\u0027 section?","accounts_in_message":[],"_revision_number":4},{"id":"210f4c560c52b6673b773aa479e169a846307b98","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-06-16 07:58:13.000000000","message":"Patch Set 4:\n\n@Vikram,\n\nLooks like it is difficult to address the order. I found there is a python bug opened for this problem. http://bugs.python.org/issue9694.","accounts_in_message":[],"_revision_number":4},{"id":"22b575abfd8545c8ccd49381fd1ed8296f3452ce","author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"date":"2016-06-16 16:18:59.000000000","message":"Patch Set 4: Code-Review+1\n\nOh I see..","accounts_in_message":[],"_revision_number":4},{"id":"f5aee8bd9a302b883ded8800d82a66441b7b378c","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-07-08 08:53:13.000000000","message":"Patch Set 5: Patch Set 4 was rebased","accounts_in_message":[],"_revision_number":4},{"id":"ebf590fd0a315f7beb970624ad3ed445aed75303","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2016-07-08 09:19:38.000000000","message":"Patch Set 5: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"25ec773d7e67cce0962951ad05820d580a00198e","author":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"date":"2016-07-08 09:22:39.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"3734d068f1bb6f86eaf2f695b53220671b4d5587","author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"date":"2016-07-08 09:41:35.000000000","message":"Patch Set 5:\n\n(1 comment)","accounts_in_message":[],"_revision_number":5},{"id":"36f6a7cbb6893feb147393d95d3586a36b514868","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-08 10:19:46.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs http://docs-draft.openstack.org/82/323182/5/check/gate-python-neutronclient-docs/970bdd4//doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-neutronclient-pep8 http://logs.openstack.org/82/323182/5/check/gate-python-neutronclient-pep8/3738d6c/ : SUCCESS in 3m 44s\n- gate-python-neutronclient-python27 http://logs.openstack.org/82/323182/5/check/gate-python-neutronclient-python27/6336b92/ : SUCCESS in 3m 23s\n- gate-python-neutronclient-python34 http://logs.openstack.org/82/323182/5/check/gate-python-neutronclient-python34/09a1be9/ : SUCCESS in 3m 43s\n- gate-python-neutronclient-python35-nv http://logs.openstack.org/82/323182/5/check/gate-python-neutronclient-python35-nv/6c99f46/ : SUCCESS in 3m 20s (non-voting)\n- gate-python-neutronclient-pypy http://logs.openstack.org/82/323182/5/check/gate-python-neutronclient-pypy/39a59e9/ : SUCCESS in 3m 07s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/82/323182/5/check/gate-tempest-dsvm-neutron-src-python-neutronclient/bd57179/ : SUCCESS in 1h 10m 10s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/82/323182/5/check/gate-neutronclient-test-dsvm-functional/6ca92fa/ : SUCCESS in 25m 24s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/82/323182/5/check/gate-neutronclient-test-dsvm-functional-adv-svcs/bf8486f/ : SUCCESS in 26m 09s","accounts_in_message":[],"_revision_number":5},{"id":"95c282c6d17425895c788722f122712ecf2d6916","author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"date":"2017-02-16 01:42:37.000000000","message":"Patch Set 5: Code-Review-1\n\nI guess we can abandon this change in favor of OSC implementation","accounts_in_message":[],"_revision_number":5},{"id":"b99869045e72ed3d4f8e44f6900be38f8c2e4d2f","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-02-20 15:57:14.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"e9b934d11f56623fb8dd2cf2a2388a240b1a8130","revisions":{"d21fe198573ecc4eb3ce37d451baa8c6bd67fef0":{"kind":"REWORK","_number":1,"created":"2016-05-31 07:54:53.000000000","uploader":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"ref":"refs/changes/82/323182/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/82/323182/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/1"}}},"commit":{"parents":[{"commit":"53a59e5aa2e838612852328f0cf3e4eb4f65ed43","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/53a59e5aa2e838612852328f0cf3e4eb4f65ed43"}]}],"author":{"name":"yuyangbj","email":"yangyu@vmware.com","date":"2016-05-31 07:48:49.000000000","tz":480},"committer":{"name":"yuyangbj","email":"yangyu@vmware.com","date":"2016-05-31 07:51:43.000000000","tz":480},"subject":"Update the bgp-peer-create CLI","message":"Update the bgp-peer-create CLI\n\nFor bgp peer, the peer-ip and remote-as are required arguments, but\nthey are set into the optional arguments list by argparser lib. So\nchanging the CLI usage to make sure the peer-ip and remote-as are\nset to positional arguments.\n\nChange-Id: I0a4e35d4741ac3fb33e0e05b2b0702d5f773e08c\nPartially-Implements: blueprint bgp-spinout\nPartial-Bug: #156000\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d21fe198573ecc4eb3ce37d451baa8c6bd67fef0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/d21fe198573ecc4eb3ce37d451baa8c6bd67fef0"}]},"branch":"refs/heads/master"},"35251c32e4f0fd4be779b82bf628ffaf494915b6":{"kind":"REWORK","_number":2,"created":"2016-06-07 01:56:36.000000000","uploader":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"ref":"refs/changes/82/323182/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/82/323182/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/2"}}},"commit":{"parents":[{"commit":"b41ce4b7831e6bfee4c856c80c7ed2e2f28c142a","subject":"Merge \"Add in missing translations\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/b41ce4b7831e6bfee4c856c80c7ed2e2f28c142a"}]}],"author":{"name":"yuyangbj","email":"yangyu@vmware.com","date":"2016-06-07 01:42:51.000000000","tz":480},"committer":{"name":"yuyangbj","email":"yangyu@vmware.com","date":"2016-06-07 01:42:56.000000000","tz":480},"subject":"Update the bgp-peer-create CLI","message":"Update the bgp-peer-create CLI\n\nFor bgp peer, the peer-ip and remote-as are required arguments, but\nthey are set into the optional arguments list by argparser lib. So\nchanging the CLI usage to make sure the peer-ip and remote-as are\nset to positional arguments.\n\nCloses-Bug: #1589754\nChange-Id: I0a4e35d4741ac3fb33e0e05b2b0702d5f773e08c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/35251c32e4f0fd4be779b82bf628ffaf494915b6"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/35251c32e4f0fd4be779b82bf628ffaf494915b6"}]},"branch":"refs/heads/master"},"9da2ebeb755c0a9394774dbc4ff35cd42c7d56c7":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-06-13 02:25:47.000000000","uploader":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"ref":"refs/changes/82/323182/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/82/323182/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/3"}}},"commit":{"parents":[{"commit":"7099f6e0ba511209dab6b89a5c3951b3b6336e1e","subject":"Merge \"Remove unnecessary executable permissions\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/7099f6e0ba511209dab6b89a5c3951b3b6336e1e"}]}],"author":{"name":"yuyangbj","email":"yangyu@vmware.com","date":"2016-06-07 01:42:51.000000000","tz":480},"committer":{"name":"Yang Yu","email":"yangyu@vmware.com","date":"2016-06-13 02:25:47.000000000","tz":0},"subject":"Update the bgp-peer-create CLI","message":"Update the bgp-peer-create CLI\n\nFor bgp peer, the peer-ip and remote-as are required arguments, but\nthey are set into the optional arguments list by argparser lib. So\nchanging the CLI usage to make sure the peer-ip and remote-as are\nset to positional arguments.\n\nCloses-Bug: #1589754\nChange-Id: I0a4e35d4741ac3fb33e0e05b2b0702d5f773e08c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9da2ebeb755c0a9394774dbc4ff35cd42c7d56c7"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9da2ebeb755c0a9394774dbc4ff35cd42c7d56c7"}]},"branch":"refs/heads/master"},"6303996b3676df7f92a7c8af188f2b2ae12729e2":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":4,"created":"2016-06-15 08:35:20.000000000","uploader":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"ref":"refs/changes/82/323182/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/82/323182/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/4"}}},"commit":{"parents":[{"commit":"521ff7cee562df5105c6404fadb261092af7e342","subject":"Add no-shared option to qos-policy-update command","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/521ff7cee562df5105c6404fadb261092af7e342"}]}],"author":{"name":"yuyangbj","email":"yangyu@vmware.com","date":"2016-06-07 01:42:51.000000000","tz":480},"committer":{"name":"yuyangbj","email":"yangyu@vmware.com","date":"2016-06-15 08:33:12.000000000","tz":480},"subject":"Update the bgp-peer-create CLI","message":"Update the bgp-peer-create CLI\n\nFor bgp peer, the peer-ip and remote-as are required arguments, but\nthey are set into the optional arguments list by argparser lib. So\nchanging the CLI usage to make sure the peer-ip and remote-as are\nset to required arguments. See below:\n\npositional arguments:\n  NAME                  Name of the BGP peer to create.\n\noptional arguments:\n  -h, --help            show this help message and exit\n  --request-format {json}\n                        DEPRECATED! Only JSON request format is supported.\n  --tenant-id TENANT_ID\n                        The owner tenant ID.\n  --auth-type PEER_AUTH_TYPE\n                        Authentication algorithm. Supported algorithms:\n                        none(default), md5\n  --password AUTH_PASSWORD\n                        Authentication password.\n\nrequired arguments:\n  --peer-ip PEER_IP_ADDRESS\n                        Peer IP address.\n  --remote-as PEER_REMOTE_AS\n                        Peer AS number. (Integer in [1, 65535] is allowed.)\n\nCloses-Bug: #1589754\nChange-Id: I0a4e35d4741ac3fb33e0e05b2b0702d5f773e08c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/6303996b3676df7f92a7c8af188f2b2ae12729e2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/6303996b3676df7f92a7c8af188f2b2ae12729e2"}]},"branch":"refs/heads/master"},"e9b934d11f56623fb8dd2cf2a2388a240b1a8130":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2016-07-08 08:53:13.000000000","uploader":{"_account_id":6981,"name":"Yang Yu","email":"yangyu@vmware.com","username":"yuyangbj"},"ref":"refs/changes/82/323182/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/82/323182/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/82/323182/5"}}},"commit":{"parents":[{"commit":"3832d5342f9b61d5ddce22d00863026064b257f4","subject":"Trivial: missing comma in the docs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/3832d5342f9b61d5ddce22d00863026064b257f4"}]}],"author":{"name":"yuyangbj","email":"yangyu@vmware.com","date":"2016-06-07 01:42:51.000000000","tz":480},"committer":{"name":"Yang Yu","email":"yangyu@vmware.com","date":"2016-07-08 08:53:13.000000000","tz":0},"subject":"Update the bgp-peer-create CLI","message":"Update the bgp-peer-create CLI\n\nFor bgp peer, the peer-ip and remote-as are required arguments, but\nthey are set into the optional arguments list by argparser lib. So\nchanging the CLI usage to make sure the peer-ip and remote-as are\nset to required arguments. See below:\n\npositional arguments:\n  NAME                  Name of the BGP peer to create.\n\noptional arguments:\n  -h, --help            show this help message and exit\n  --request-format {json}\n                        DEPRECATED! Only JSON request format is supported.\n  --tenant-id TENANT_ID\n                        The owner tenant ID.\n  --auth-type PEER_AUTH_TYPE\n                        Authentication algorithm. Supported algorithms:\n                        none(default), md5\n  --password AUTH_PASSWORD\n                        Authentication password.\n\nrequired arguments:\n  --peer-ip PEER_IP_ADDRESS\n                        Peer IP address.\n  --remote-as PEER_REMOTE_AS\n                        Peer AS number. (Integer in [1, 65535] is allowed.)\n\nCloses-Bug: #1589754\nChange-Id: I0a4e35d4741ac3fb33e0e05b2b0702d5f773e08c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/e9b934d11f56623fb8dd2cf2a2388a240b1a8130"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/e9b934d11f56623fb8dd2cf2a2388a240b1a8130"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
