)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e4ba026e7c035c92dd05438f584541347a39bd2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add QoS egress minimum bandwidth rule to neutronclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following patch implements the QoS egress minimum"},{"line_number":10,"context_line":"bandwidth assured in neutronclient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I025522f73a9a8e3a9f69f097cedaeba330b9914a"},{"line_number":13,"context_line":"Depends-On: I7115c5732a44e3f85a8da2897052a152a34bbed7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_ebecbfbc","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":17},"updated":"2016-07-07 08:25:09.000000000","message":"s/assured/assurance","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add QoS egress minimum bandwidth rule to neutronclient"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The following patch implements the QoS egress minimum"},{"line_number":10,"context_line":"bandwidth assured in neutronclient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I025522f73a9a8e3a9f69f097cedaeba330b9914a"},{"line_number":13,"context_line":"Depends-On: I7115c5732a44e3f85a8da2897052a152a34bbed7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_a362533b","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":17},"in_reply_to":"1aa78d24_ebecbfbc","updated":"2016-07-11 09:18:07.000000000","message":"Done","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7395bd5d303e136ca86c7d7cd64c733a13aed766","unresolved":false,"context_lines":[{"line_number":10,"context_line":"bandwidth assurance in neutronclient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I025522f73a9a8e3a9f69f097cedaeba330b9914a"},{"line_number":13,"context_line":"Depends-On: I7115c5732a44e3f85a8da2897052a152a34bbed7"},{"line_number":14,"context_line":"Partial-Bug: #1560963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_d5bedaac","line":13,"updated":"2016-08-30 15:33:05.000000000","message":"I think this should point to the patch adding API, not ovs driver. The right ID is: I6b619a96a2bfde164646c71409b671352bc6ce7d","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"84e1add54e169fd6ab790237daa23a8199627883","unresolved":false,"context_lines":[{"line_number":10,"context_line":"bandwidth assurance in neutronclient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I025522f73a9a8e3a9f69f097cedaeba330b9914a"},{"line_number":13,"context_line":"Depends-On: I7115c5732a44e3f85a8da2897052a152a34bbed7"},{"line_number":14,"context_line":"Partial-Bug: #1560963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa7ab95a_ae1ad57a","line":13,"in_reply_to":"fa7ab95a_d5bedaac","updated":"2016-08-30 19:40:56.000000000","message":"Done","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b9cfdf82e3314a8265693df63a47165db6143210","unresolved":false,"context_lines":[{"line_number":10,"context_line":"bandwidth assurance in neutronclient."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I025522f73a9a8e3a9f69f097cedaeba330b9914a"},{"line_number":13,"context_line":"Depends-On: I6b619a96a2bfde164646c71409b671352bc6ce7d"},{"line_number":14,"context_line":"Depends-On: I13c54be22f35ac7eb5835d8424a919d0b61a8e95"},{"line_number":15,"context_line":"Partial-Bug: #1560963"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_6b192d79","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":53},"updated":"2016-09-01 10:41:43.000000000","message":"This was merged, so it is actually unnecessary.","commit_id":"a6cdd1daced1080c42caabfcd9cb0ee509d8a269"}],"neutronclient/neutron/v2_0/qos/minimum_bandwidth_rule.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7395bd5d303e136ca86c7d7cd64c733a13aed766","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u0027--min-kbps\u0027,"},{"line_number":30,"context_line":"        required\u003dTrue,"},{"line_number":31,"context_line":"        type\u003dstr,"},{"line_number":32,"context_line":"        help\u003d_(\u0027QoS minimum bandwidth assurance, expressed in kilobits\u0027"},{"line_number":33,"context_line":"               \u0027per second.\u0027))"},{"line_number":34,"context_line":"    # NOTE(ralonsoh): the unique direction implemented is \"egress\". Please,"},{"line_number":35,"context_line":"    # refer to the spec (https://review.openstack.org/#/c/316082/)."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_75d42eeb","line":32,"updated":"2016-08-30 15:33:05.000000000","message":"missing space after kilobits.","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"84e1add54e169fd6ab790237daa23a8199627883","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u0027--min-kbps\u0027,"},{"line_number":30,"context_line":"        required\u003dTrue,"},{"line_number":31,"context_line":"        type\u003dstr,"},{"line_number":32,"context_line":"        help\u003d_(\u0027QoS minimum bandwidth assurance, expressed in kilobits\u0027"},{"line_number":33,"context_line":"               \u0027per second.\u0027))"},{"line_number":34,"context_line":"    # NOTE(ralonsoh): the unique direction implemented is \"egress\". Please,"},{"line_number":35,"context_line":"    # refer to the spec (https://review.openstack.org/#/c/316082/)."}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_2d7eda69","line":32,"in_reply_to":"fa7ab95a_75d42eeb","updated":"2016-08-30 19:40:56.000000000","message":"Done","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7395bd5d303e136ca86c7d7cd64c733a13aed766","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        type\u003dstr,"},{"line_number":32,"context_line":"        help\u003d_(\u0027QoS minimum bandwidth assurance, expressed in kilobits\u0027"},{"line_number":33,"context_line":"               \u0027per second.\u0027))"},{"line_number":34,"context_line":"    # NOTE(ralonsoh): the unique direction implemented is \"egress\". Please,"},{"line_number":35,"context_line":"    # refer to the spec (https://review.openstack.org/#/c/316082/)."},{"line_number":36,"context_line":"    parser.add_argument("},{"line_number":37,"context_line":"        \u0027--direction\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_55000a66","line":34,"updated":"2016-08-30 15:33:05.000000000","message":"unique -\u003e only","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"84e1add54e169fd6ab790237daa23a8199627883","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        type\u003dstr,"},{"line_number":32,"context_line":"        help\u003d_(\u0027QoS minimum bandwidth assurance, expressed in kilobits\u0027"},{"line_number":33,"context_line":"               \u0027per second.\u0027))"},{"line_number":34,"context_line":"    # NOTE(ralonsoh): the unique direction implemented is \"egress\". Please,"},{"line_number":35,"context_line":"    # refer to the spec (https://review.openstack.org/#/c/316082/)."},{"line_number":36,"context_line":"    parser.add_argument("},{"line_number":37,"context_line":"        \u0027--direction\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_4d995ec3","line":34,"in_reply_to":"fa7ab95a_55000a66","updated":"2016-08-30 19:40:56.000000000","message":"Done","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"79d476c3e1e82a4423423d9d218409cfc7927cc0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"def add_minimum_bandwidth_arguments(parser):"},{"line_number":28,"context_line":"    parser.add_argument("},{"line_number":29,"context_line":"        \u0027--min-kbps\u0027,"},{"line_number":30,"context_line":"        required\u003dFalse,"},{"line_number":31,"context_line":"        type\u003dstr,"},{"line_number":32,"context_line":"        help\u003d_(\u0027QoS minimum bandwidth assurance, expressed in kilobits \u0027"},{"line_number":33,"context_line":"               \u0027per second.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_01db681c","line":30,"updated":"2016-08-31 11:54:25.000000000","message":"Ouch. I now realize that we allowed it in API. But what does it mean, to have a rule like that without actual limit set? Should we change it server side and reflect here?","commit_id":"af69e3377e01f45fca91ffe2be54ff52427449e9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"db322dbe5971fc03511f10d478c14e7d6742d99c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"def add_minimum_bandwidth_arguments(parser):"},{"line_number":28,"context_line":"    parser.add_argument("},{"line_number":29,"context_line":"        \u0027--min-kbps\u0027,"},{"line_number":30,"context_line":"        required\u003dFalse,"},{"line_number":31,"context_line":"        type\u003dstr,"},{"line_number":32,"context_line":"        help\u003d_(\u0027QoS minimum bandwidth assurance, expressed in kilobits \u0027"},{"line_number":33,"context_line":"               \u0027per second.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_0a27bf12","line":30,"in_reply_to":"fa7ab95a_01db681c","updated":"2016-09-01 10:09:58.000000000","message":"I will switch back to required.","commit_id":"af69e3377e01f45fca91ffe2be54ff52427449e9"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"ef576d0ff95f6d7a3d8adfea09eeb4f918004d94","unresolved":false,"context_lines":[{"line_number":27,"context_line":"def add_minimum_bandwidth_arguments(parser):"},{"line_number":28,"context_line":"    parser.add_argument("},{"line_number":29,"context_line":"        \u0027--min-kbps\u0027,"},{"line_number":30,"context_line":"        required\u003dFalse,"},{"line_number":31,"context_line":"        type\u003dstr,"},{"line_number":32,"context_line":"        help\u003d_(\u0027QoS minimum bandwidth assurance, expressed in kilobits \u0027"},{"line_number":33,"context_line":"               \u0027per second.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_456d3897","line":30,"in_reply_to":"fa7ab95a_0a27bf12","updated":"2016-09-01 10:12:14.000000000","message":"I can do this, the unit tests will need to be changed also.","commit_id":"af69e3377e01f45fca91ffe2be54ff52427449e9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b716c440fd581f0196eb8b35d7c758918368cc2a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"def add_minimum_bandwidth_arguments(parser):"},{"line_number":28,"context_line":"    parser.add_argument("},{"line_number":29,"context_line":"        \u0027--min-kbps\u0027,"},{"line_number":30,"context_line":"        required\u003dFalse,"},{"line_number":31,"context_line":"        type\u003dstr,"},{"line_number":32,"context_line":"        help\u003d_(\u0027QoS minimum bandwidth assurance, expressed in kilobits \u0027"},{"line_number":33,"context_line":"               \u0027per second.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_a5928449","line":30,"in_reply_to":"fa7ab95a_456d3897","updated":"2016-09-01 10:15:13.000000000","message":"I already have a patch, stay tuned, I will post shortly.","commit_id":"af69e3377e01f45fca91ffe2be54ff52427449e9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ac67316202f661eb15d730a7eaae59c5802e1308","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    # refer to the spec (https://review.openstack.org/#/c/316082/)."},{"line_number":36,"context_line":"    parser.add_argument("},{"line_number":37,"context_line":"        \u0027--direction\u0027,"},{"line_number":38,"context_line":"        required\u003dFalse,"},{"line_number":39,"context_line":"        type\u003dutils.convert_to_lowercase,"},{"line_number":40,"context_line":"        choices\u003d[\u0027egress\u0027],"},{"line_number":41,"context_line":"        help\u003d_(\u0027Traffic direction.\u0027))"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_b3a9477e","line":38,"updated":"2016-08-31 07:07:03.000000000","message":"If it is not mandatory then we can remove it off..","commit_id":"af69e3377e01f45fca91ffe2be54ff52427449e9"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b9cfdf82e3314a8265693df63a47165db6143210","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    # refer to the spec (https://review.openstack.org/#/c/316082/)."},{"line_number":35,"context_line":"    parser.add_argument("},{"line_number":36,"context_line":"        \u0027--direction\u0027,"},{"line_number":37,"context_line":"        # NOTE(ihrachys): though server picks the default for us (egress), it\u0027s"},{"line_number":38,"context_line":"        # better to require the argument to make the UI more explicit and the"},{"line_number":39,"context_line":"        # intentions more clear in the future when we add other values for the"},{"line_number":40,"context_line":"        # attribute on server side."},{"line_number":41,"context_line":"        required\u003dTrue,"},{"line_number":42,"context_line":"        type\u003dutils.convert_to_lowercase,"},{"line_number":43,"context_line":"        choices\u003d[\u0027egress\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_b0664427","line":40,"range":{"start_line":37,"start_character":8,"end_line":40,"end_character":35},"updated":"2016-09-01 10:41:43.000000000","message":"Nice idea. Good from UI perspective.","commit_id":"a6cdd1daced1080c42caabfcd9cb0ee509d8a269"}],"neutronclient/neutron/v2_0/qos/qos_min_bw_rule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"1ee367849838ac48b7fc99b97179f96928dcaa8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_23e7d5ad","line":1,"updated":"2016-07-08 04:27:47.000000000","message":"can we rename this file to \"minimum_ \tbandwidth_limit_rule.py\", to me \u0027qos\u0027 is not required as we are already inside qos folder..","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Intel Corporation."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_43dbafed","line":1,"in_reply_to":"1aa78d24_23e7d5ad","updated":"2016-07-11 09:18:07.000000000","message":"I\u0027ll change it to \"minimum_bandwidth_rule.py\", beacuse this is the name of the new feature.","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"30c59d2462b71adbf1e9c739cf68a4e6b70c8b18","unresolved":false,"context_lines":[{"line_number":32,"context_line":"               \u0027per second.\u0027))"},{"line_number":33,"context_line":"    parser.add_argument("},{"line_number":34,"context_line":"        \u0027--direction\u0027,"},{"line_number":35,"context_line":"        required\u003dTrue,"},{"line_number":36,"context_line":"        type\u003dstr,"},{"line_number":37,"context_line":"        help\u003d_(\u0027Traffic direction.\u0027))"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_5e12b459","line":35,"updated":"2016-07-08 04:33:35.000000000","message":"Could you please provide the available options to the user? As an end user, I don\u0027t understand what should be provided as an input for this parameter.","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"               \u0027per second.\u0027))"},{"line_number":33,"context_line":"    parser.add_argument("},{"line_number":34,"context_line":"        \u0027--direction\u0027,"},{"line_number":35,"context_line":"        required\u003dTrue,"},{"line_number":36,"context_line":"        type\u003dstr,"},{"line_number":37,"context_line":"        help\u003d_(\u0027Traffic direction.\u0027))"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e73c66c1","line":35,"in_reply_to":"1aa78d24_5e12b459","updated":"2016-07-11 09:18:07.000000000","message":"Yes, I missed that.","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e4ba026e7c035c92dd05438f584541347a39bd2","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class ListQoSMinimumBandwidthRules(qos_rule.QosRuleMixin,"},{"line_number":68,"context_line":"                                   neutronv20.ListCommand):"},{"line_number":69,"context_line":"    \"\"\"List all qos minimum bw rules belonging to the specified policy.\"\"\""},{"line_number":70,"context_line":"    resource \u003d MINIMUM_BANDWIDTH_RULE_RESOURCE"},{"line_number":71,"context_line":"    _formatters \u003d {}"},{"line_number":72,"context_line":"    pagination_support \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_4b635342","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":30},"updated":"2016-07-07 08:25:09.000000000","message":"In all other comments you use \"bandwidth\" instead of \"bw\", might be better to keep it that way for consistency.","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"class ListQoSMinimumBandwidthRules(qos_rule.QosRuleMixin,"},{"line_number":68,"context_line":"                                   neutronv20.ListCommand):"},{"line_number":69,"context_line":"    \"\"\"List all qos minimum bw rules belonging to the specified policy.\"\"\""},{"line_number":70,"context_line":"    resource \u003d MINIMUM_BANDWIDTH_RULE_RESOURCE"},{"line_number":71,"context_line":"    _formatters \u003d {}"},{"line_number":72,"context_line":"    pagination_support \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_47829a95","line":69,"range":{"start_line":69,"start_character":28,"end_line":69,"end_character":30},"in_reply_to":"1aa78d24_4b635342","updated":"2016-07-11 09:18:07.000000000","message":"Done","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e4ba026e7c035c92dd05438f584541347a39bd2","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    sorting_support \u003d True"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class ShowQoSMinimumBandwidthMinimumRule(qos_rule.QosRuleMixin,"},{"line_number":77,"context_line":"                                         neutronv20.ShowCommand):"},{"line_number":78,"context_line":"    \"\"\"Show information about the given qos minimum bandwidth rule.\"\"\""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_cb058346","line":76,"range":{"start_line":76,"start_character":29,"end_line":76,"end_character":36},"updated":"2016-07-07 08:25:09.000000000","message":"Typo?","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    sorting_support \u003d True"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class ShowQoSMinimumBandwidthMinimumRule(qos_rule.QosRuleMixin,"},{"line_number":77,"context_line":"                                         neutronv20.ShowCommand):"},{"line_number":78,"context_line":"    \"\"\"Show information about the given qos minimum bandwidth rule.\"\"\""},{"line_number":79,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_4759fa59","line":76,"range":{"start_line":76,"start_character":29,"end_line":76,"end_character":36},"in_reply_to":"1aa78d24_cb058346","updated":"2016-07-11 09:18:07.000000000","message":"Done","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"}],"neutronclient/shell.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e4ba026e7c035c92dd05438f584541347a39bd2","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        qos_min_bw_rule.CreateQoSMinimumBandwidthRule"},{"line_number":402,"context_line":"    ),"},{"line_number":403,"context_line":"    \u0027qos-minimum-bandwidth-rule-show\u0027: ("},{"line_number":404,"context_line":"        qos_min_bw_rule.ShowQoSMinimumBandwidthMinimumRule"},{"line_number":405,"context_line":"    ),"},{"line_number":406,"context_line":"    \u0027qos-minimum-bandwidth-rule-list\u0027: ("},{"line_number":407,"context_line":"        qos_min_bw_rule.ListQoSMinimumBandwidthRules"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ebdf9fd3","line":404,"range":{"start_line":404,"start_character":24,"end_line":404,"end_character":58},"updated":"2016-07-07 08:25:09.000000000","message":"Typo?","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":401,"context_line":"        qos_min_bw_rule.CreateQoSMinimumBandwidthRule"},{"line_number":402,"context_line":"    ),"},{"line_number":403,"context_line":"    \u0027qos-minimum-bandwidth-rule-show\u0027: ("},{"line_number":404,"context_line":"        qos_min_bw_rule.ShowQoSMinimumBandwidthMinimumRule"},{"line_number":405,"context_line":"    ),"},{"line_number":406,"context_line":"    \u0027qos-minimum-bandwidth-rule-list\u0027: ("},{"line_number":407,"context_line":"        qos_min_bw_rule.ListQoSMinimumBandwidthRules"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_87180286","line":404,"range":{"start_line":404,"start_character":24,"end_line":404,"end_character":58},"in_reply_to":"1aa78d24_ebdf9fd3","updated":"2016-07-11 09:18:07.000000000","message":"Done","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"}],"neutronclient/tests/unit/qos/test_cli20_minimum_bandwidth_rule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"1ee367849838ac48b7fc99b97179f96928dcaa8a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt Ltd."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_6388bdc7","line":1,"updated":"2016-07-08 04:27:47.000000000","message":"2016 \u0026 I believe you got to change company name ;)","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Huawei Technologies India Pvt Ltd."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e707461b","line":1,"in_reply_to":"1aa78d24_6388bdc7","updated":"2016-07-11 09:18:07.000000000","message":"ctrl-c ctrl-v is very dangerous.","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"1ee367849838ac48b7fc99b97179f96928dcaa8a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                   cmd_resource\u003dself.cmd_res,"},{"line_number":75,"context_line":"                                   parent_id\u003dpolicy_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_show_minimum_bandwidth_rule(self):"},{"line_number":78,"context_line":"        cmd \u003d bw_rule.ShowQoSMinimumBandwidthMinimumRule("},{"line_number":79,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":80,"context_line":"        policy_id \u003d \u0027policy_id\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_838fa9cb","line":77,"updated":"2016-07-08 04:27:47.000000000","message":"Please add the test-case for validating the \u0027list\u0027 functionality..","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                   cmd_resource\u003dself.cmd_res,"},{"line_number":75,"context_line":"                                   parent_id\u003dpolicy_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_show_minimum_bandwidth_rule(self):"},{"line_number":78,"context_line":"        cmd \u003d bw_rule.ShowQoSMinimumBandwidthMinimumRule("},{"line_number":79,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":80,"context_line":"        policy_id \u003d \u0027policy_id\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_2a8c737e","line":77,"in_reply_to":"1aa78d24_838fa9cb","updated":"2016-07-11 09:18:07.000000000","message":"Done","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e4ba026e7c035c92dd05438f584541347a39bd2","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                   parent_id\u003dpolicy_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_show_minimum_bandwidth_rule(self):"},{"line_number":78,"context_line":"        cmd \u003d bw_rule.ShowQoSMinimumBandwidthMinimumRule("},{"line_number":79,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":80,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":81,"context_line":"        args \u003d [self.test_id, policy_id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_4bbfd360","line":78,"range":{"start_line":78,"start_character":22,"end_line":78,"end_character":56},"updated":"2016-07-07 08:25:09.000000000","message":"Typo?","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                                   parent_id\u003dpolicy_id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_show_minimum_bandwidth_rule(self):"},{"line_number":78,"context_line":"        cmd \u003d bw_rule.ShowQoSMinimumBandwidthMinimumRule("},{"line_number":79,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":80,"context_line":"        policy_id \u003d \u0027policy_id\u0027"},{"line_number":81,"context_line":"        args \u003d [self.test_id, policy_id]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_8a4da774","line":78,"range":{"start_line":78,"start_character":22,"end_line":78,"end_character":56},"in_reply_to":"1aa78d24_4bbfd360","updated":"2016-07-11 09:18:07.000000000","message":"Done","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7395bd5d303e136ca86c7d7cd64c733a13aed766","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        args \u003d [policy_id]"},{"line_number":91,"context_line":"        contents \u003d [{\u0027name\u0027: \u0027rule1\u0027, \u0027min-kbps\u0027: 1000, \u0027direction\u0027: \u0027egress\u0027}]"},{"line_number":92,"context_line":"        self._test_list_resources(self.cmd_ress, cmd, parent_id\u003dpolicy_id,"},{"line_number":93,"context_line":"                                  base_args\u003dargs, response_contents\u003dcontents)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_f5c91e27","line":93,"updated":"2016-08-30 15:33:05.000000000","message":"would probably make sense to add some negative tests, like when required args are not passed.","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"84e1add54e169fd6ab790237daa23a8199627883","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        args \u003d [policy_id]"},{"line_number":91,"context_line":"        contents \u003d [{\u0027name\u0027: \u0027rule1\u0027, \u0027min-kbps\u0027: 1000, \u0027direction\u0027: \u0027egress\u0027}]"},{"line_number":92,"context_line":"        self._test_list_resources(self.cmd_ress, cmd, parent_id\u003dpolicy_id,"},{"line_number":93,"context_line":"                                  base_args\u003dargs, response_contents\u003dcontents)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_0ead819a","line":93,"in_reply_to":"fa7ab95a_f5c91e27","updated":"2016-08-30 19:40:56.000000000","message":"Done","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"}],"neutronclient/tests/unit/qos/test_cli20_rule.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"1ee367849838ac48b7fc99b97179f96928dcaa8a","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    non_admin_status_resources \u003d [\u0027bandwidth_limit_rule\u0027,"},{"line_number":26,"context_line":"                                  \u0027dscp_marking_rule\u0027,"},{"line_number":27,"context_line":"                                  \u0027minimum_bandwidth_rule\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(CLITestV20QoSRuleJSON, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_a3a90527","line":27,"updated":"2016-07-08 04:27:47.000000000","message":"I would prefer \u0027minimum_bandwidth_limit_rule\" than \u0027minimum_bandwidth_rule\u0027 to make it consistent with the existing nomenclature.. Any thoughts?","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    non_admin_status_resources \u003d [\u0027bandwidth_limit_rule\u0027,"},{"line_number":26,"context_line":"                                  \u0027dscp_marking_rule\u0027,"},{"line_number":27,"context_line":"                                  \u0027minimum_bandwidth_rule\u0027]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(CLITestV20QoSRuleJSON, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_ca0ccf96","line":27,"in_reply_to":"1aa78d24_a3a90527","updated":"2016-07-11 09:18:07.000000000","message":"As I told before, \"minimum_bandwidth_rule\" doesn\u0027t limit the traffic and that\u0027s why I didn\u0027t use it.\nhttps://bugs.launchpad.net/neutron/+bug/1560963 --\u003e first paragraph","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"30c59d2462b71adbf1e9c739cf68a4e6b70c8b18","unresolved":false,"context_lines":[{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"    def list_minimum_bandwidth_rules(self, policy_id, retrieve_all\u003dTrue,"},{"line_number":1641,"context_line":"                                     **_params):"},{"line_number":1642,"context_line":"        \"\"\"Fetches a list of all minimum bw rules for the given policy.\"\"\""},{"line_number":1643,"context_line":"        return self.list(\u0027minimum_bandwidth_rules\u0027,"},{"line_number":1644,"context_line":"                         self.qos_minimum_bandwidth_rules_path %"},{"line_number":1645,"context_line":"                         policy_id, retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_432141b4","line":1642,"updated":"2016-07-08 04:33:35.000000000","message":"%s/bw/bandwidth/g","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"    def list_minimum_bandwidth_rules(self, policy_id, retrieve_all\u003dTrue,"},{"line_number":1641,"context_line":"                                     **_params):"},{"line_number":1642,"context_line":"        \"\"\"Fetches a list of all minimum bw rules for the given policy.\"\"\""},{"line_number":1643,"context_line":"        return self.list(\u0027minimum_bandwidth_rules\u0027,"},{"line_number":1644,"context_line":"                         self.qos_minimum_bandwidth_rules_path %"},{"line_number":1645,"context_line":"                         policy_id, retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_2ae1139b","line":1642,"in_reply_to":"1aa78d24_432141b4","updated":"2016-07-11 09:18:07.000000000","message":"Done","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"30c59d2462b71adbf1e9c739cf68a4e6b70c8b18","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"    def create_minimum_bandwidth_rule(self, policy, body\u003dNone):"},{"line_number":1653,"context_line":"        \"\"\"Creates a new minimum bandwidth rule.\"\"\""},{"line_number":1654,"context_line":"        return self.post(self.qos_minimum_bandwidth_rules_path % policy,"},{"line_number":1655,"context_line":"                         body\u003dbody)"},{"line_number":1656,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e3166d57","line":1653,"updated":"2016-07-08 04:33:35.000000000","message":"Would you like to add \u0027egress\u0027 for better clarity?","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":1650,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1651,"context_line":""},{"line_number":1652,"context_line":"    def create_minimum_bandwidth_rule(self, policy, body\u003dNone):"},{"line_number":1653,"context_line":"        \"\"\"Creates a new minimum bandwidth rule.\"\"\""},{"line_number":1654,"context_line":"        return self.post(self.qos_minimum_bandwidth_rules_path % policy,"},{"line_number":1655,"context_line":"                         body\u003dbody)"},{"line_number":1656,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_cab68f89","line":1653,"in_reply_to":"1aa78d24_e3166d57","updated":"2016-07-11 09:18:07.000000000","message":"No, the rule can have both directions. Of course, not at the same time, but these commands shouldn\u0027t have any directionality indication.","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ff92a92cbe0be33045da7cd198c195ff224edc7b","unresolved":false,"context_lines":[{"line_number":1657,"context_line":"                         body\u003dbody)"},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"    def update_minimum_bandwidth_rule(self, rule, policy, body\u003dNone):"},{"line_number":1660,"context_line":"        \"\"\"Updates an minimum bandwidth rule.\"\"\""},{"line_number":1661,"context_line":"        return self.put(self.qos_minimum_bandwidth_rule_path %"},{"line_number":1662,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1663,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_5f7dff1a","line":1660,"updated":"2016-07-12 08:23:23.000000000","message":"How about \"Updates an existing minimum bandwidth rule.\"?","commit_id":"86f93c4eba85d8eaa229aa9782d2e530e62a1934"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"26d9e84a1fe716f7666ed374220d7ae3f7899a50","unresolved":false,"context_lines":[{"line_number":1657,"context_line":"                         body\u003dbody)"},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"    def update_minimum_bandwidth_rule(self, rule, policy, body\u003dNone):"},{"line_number":1660,"context_line":"        \"\"\"Updates an minimum bandwidth rule.\"\"\""},{"line_number":1661,"context_line":"        return self.put(self.qos_minimum_bandwidth_rule_path %"},{"line_number":1662,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1663,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_25f0e6fc","line":1660,"range":{"start_line":1660,"start_character":19,"end_line":1660,"end_character":21},"updated":"2016-07-12 08:52:07.000000000","message":"s/an/a","commit_id":"86f93c4eba85d8eaa229aa9782d2e530e62a1934"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e33909cafe32386d21a38b9320dfec59bd7cfc57","unresolved":false,"context_lines":[{"line_number":1657,"context_line":"                         body\u003dbody)"},{"line_number":1658,"context_line":""},{"line_number":1659,"context_line":"    def update_minimum_bandwidth_rule(self, rule, policy, body\u003dNone):"},{"line_number":1660,"context_line":"        \"\"\"Updates an minimum bandwidth rule.\"\"\""},{"line_number":1661,"context_line":"        return self.put(self.qos_minimum_bandwidth_rule_path %"},{"line_number":1662,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1663,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_533df829","line":1660,"range":{"start_line":1660,"start_character":19,"end_line":1660,"end_character":21},"in_reply_to":"1aa78d24_25f0e6fc","updated":"2016-07-12 09:27:32.000000000","message":"Sorry, I forgot that!","commit_id":"86f93c4eba85d8eaa229aa9782d2e530e62a1934"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"ff92a92cbe0be33045da7cd198c195ff224edc7b","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1663,"context_line":""},{"line_number":1664,"context_line":"    def delete_minimum_bandwidth_rule(self, rule, policy):"},{"line_number":1665,"context_line":"        \"\"\"Deletes an minimum bandwidth rule.\"\"\""},{"line_number":1666,"context_line":"        return self.delete(self.qos_minimum_bandwidth_rule_path %"},{"line_number":1667,"context_line":"                           (policy, rule))"},{"line_number":1668,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_3f7ab324","line":1665,"updated":"2016-07-12 08:23:23.000000000","message":"ditto","commit_id":"86f93c4eba85d8eaa229aa9782d2e530e62a1934"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"26d9e84a1fe716f7666ed374220d7ae3f7899a50","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1663,"context_line":""},{"line_number":1664,"context_line":"    def delete_minimum_bandwidth_rule(self, rule, policy):"},{"line_number":1665,"context_line":"        \"\"\"Deletes an minimum bandwidth rule.\"\"\""},{"line_number":1666,"context_line":"        return self.delete(self.qos_minimum_bandwidth_rule_path %"},{"line_number":1667,"context_line":"                           (policy, rule))"},{"line_number":1668,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_c5d5a243","line":1665,"range":{"start_line":1665,"start_character":19,"end_line":1665,"end_character":21},"updated":"2016-07-12 08:52:07.000000000","message":"s/an/a","commit_id":"86f93c4eba85d8eaa229aa9782d2e530e62a1934"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e33909cafe32386d21a38b9320dfec59bd7cfc57","unresolved":false,"context_lines":[{"line_number":1662,"context_line":"                        (policy, rule), body\u003dbody)"},{"line_number":1663,"context_line":""},{"line_number":1664,"context_line":"    def delete_minimum_bandwidth_rule(self, rule, policy):"},{"line_number":1665,"context_line":"        \"\"\"Deletes an minimum bandwidth rule.\"\"\""},{"line_number":1666,"context_line":"        return self.delete(self.qos_minimum_bandwidth_rule_path %"},{"line_number":1667,"context_line":"                           (policy, rule))"},{"line_number":1668,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1aa78d24_1337f04d","line":1665,"range":{"start_line":1665,"start_character":19,"end_line":1665,"end_character":21},"in_reply_to":"1aa78d24_c5d5a243","updated":"2016-07-12 09:27:32.000000000","message":"Thanks","commit_id":"86f93c4eba85d8eaa229aa9782d2e530e62a1934"}],"releasenotes/notes/qos_minimum_bandwidth-dc4adb23c51de30b.yaml":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e4ba026e7c035c92dd05438f584541347a39bd2","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule functionality."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_4b4d1399","line":5,"range":{"start_line":5,"start_character":66,"end_line":5,"end_character":73},"updated":"2016-07-07 08:25:09.000000000","message":"s/for QoS/for the QoS","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"4e4ba026e7c035c92dd05438f584541347a39bd2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule functionality."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_cb28e39c","line":6,"range":{"start_line":6,"start_character":26,"end_line":6,"end_character":40},"updated":"2016-07-07 08:25:09.000000000","message":"Maybe leave out functionality, this doesn\u0027t actually provide the functionality it just uses the API.","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c2c67450c73a0283a55e4068e302f5e8941c83d8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule functionality."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1aa78d24_aa298339","line":6,"range":{"start_line":6,"start_character":26,"end_line":6,"end_character":40},"in_reply_to":"1aa78d24_cb28e39c","updated":"2016-07-11 09:18:07.000000000","message":"Good clarification.\n\nBut I was talking about the functionality in Neutron; at the begining of the sentence I talk about what is new here in the python client, the commands.","commit_id":"de277f5eb3e47a363111abf0d5efecafcc6b744c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7395bd5d303e136ca86c7d7cd64c733a13aed766","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for the QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_95ae122c","line":3,"updated":"2016-08-30 15:33:05.000000000","message":"I don\u0027t think prelude is due here. \u0027Features\u0027 section is enough.","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"84e1add54e169fd6ab790237daa23a8199627883","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for the QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_ce8d5932","line":3,"in_reply_to":"fa7ab95a_95ae122c","updated":"2016-08-30 19:40:56.000000000","message":"Done","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"9621eb84d6463c8f8275ea2527142552d18732e4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for the QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_f9c7a30f","line":5,"updated":"2016-07-13 09:07:03.000000000","message":"Have we considered OpenstackClient migration?","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7395bd5d303e136ca86c7d7cd64c733a13aed766","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for the QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_b59236f4","line":5,"in_reply_to":"1aa78d24_eb182d20","updated":"2016-08-30 15:33:05.000000000","message":"I don\u0027t think QoS goes in OSC this cycle, due to different priorities of OSC team.","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c9411746f37d6600483dfa4061e2cf24c80c52d7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for the QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_eb182d20","line":5,"in_reply_to":"1aa78d24_f9c7a30f","updated":"2016-07-13 09:54:31.000000000","message":"Yes, of couse. All new features are required to be in OpenStack Client and QoS features are being tracked to be there.\n\nThank you for the notice.","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"84e1add54e169fd6ab790237daa23a8199627883","unresolved":false,"context_lines":[{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"    Adding new QoS minimum bandwidth rule commands."},{"line_number":4,"context_line":"features:"},{"line_number":5,"context_line":"  - New create, update, list, show, and delete commands are added for the QoS"},{"line_number":6,"context_line":"    minimum bandwidth rule."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa7ab95a_ee805df9","line":5,"in_reply_to":"fa7ab95a_b59236f4","updated":"2016-08-30 19:40:56.000000000","message":"Done","commit_id":"c52014c4b7c8a3048b4f61af4c5bb2ddcd5b0638"}]}