)]}'
{"neutronclient/client.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5e44f368a1d3f00d7e6fd7337dcd632969f37f90","unresolved":false,"context_lines":[{"line_number":359,"context_line":"                          project_name\u003dNone,"},{"line_number":360,"context_line":"                          project_id\u003dNone,"},{"line_number":361,"context_line":"                          project_domain_id\u003dNone,"},{"line_number":362,"context_line":"                          user_domain_id\u003dNone,"},{"line_number":363,"context_line":"                          password\u003dNone,"},{"line_number":364,"context_line":"                          auth_url\u003dNone,"},{"line_number":365,"context_line":"                          token\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_5cea0175","line":362,"updated":"2017-03-05 22:43:34.000000000","message":"Could you add project/user_domain_name too?","commit_id":"e2f792fa6ab998b4ac76125cba1d605916244592"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5e44f368a1d3f00d7e6fd7337dcd632969f37f90","unresolved":false,"context_lines":[{"line_number":365,"context_line":"                          token\u003dNone,"},{"line_number":366,"context_line":"                          region_name\u003dNone,"},{"line_number":367,"context_line":"                          timeout\u003dNone,"},{"line_number":368,"context_line":"                          endpoint_url\u003dNone,"},{"line_number":369,"context_line":"                          insecure\u003dFalse,"},{"line_number":370,"context_line":"                          endpoint_type\u003d\u0027public\u0027,"},{"line_number":371,"context_line":"                          log_credentials\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_bca93d26","line":368,"range":{"start_line":368,"start_character":26,"end_line":368,"end_character":44},"updated":"2017-03-05 22:43:34.000000000","message":"endpoint_url is not referred anymore?\nkeystoneauth simple plugin (token_endpoint plugin) can be used.\n\nhttps://docs.openstack.org/developer/keystoneauth/authentication-plugins.html#simple-plugins","commit_id":"e2f792fa6ab998b4ac76125cba1d605916244592"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5e44f368a1d3f00d7e6fd7337dcd632969f37f90","unresolved":false,"context_lines":[{"line_number":381,"context_line":"        auth_plugin \u003d kwargs.get(\u0027auth\u0027)"},{"line_number":382,"context_line":"        if auth_plugin is None:"},{"line_number":383,"context_line":"            if token and auth_url:"},{"line_number":384,"context_line":"                auth \u003d {\u0027auth_url\u0027: auth_url,"},{"line_number":385,"context_line":"                        \u0027token\u0027: token}"},{"line_number":386,"context_line":"                auth_plugin \u003d identity.Token(**auth)"},{"line_number":387,"context_line":"            elif auth_url and username and password:"},{"line_number":388,"context_line":"                auth \u003d {\u0027auth_url\u0027: auth_url,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_bce4ddab","line":385,"range":{"start_line":384,"start_character":23,"end_line":385,"end_character":39},"updated":"2017-03-05 22:43:34.000000000","message":"Could you pass more parameters like project_id and project_name as well?\nv3 token plugin takes parameters shown at [1].\nv2 token plugin takes [2] (and parameter names are converted here [3]).\n\n[1] https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/identity/v3/token.py#L35\n\n[2] https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/identity/v2.py#L152\n[3] https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/identity/generic/base.py#L94","commit_id":"e2f792fa6ab998b4ac76125cba1d605916244592"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5e44f368a1d3f00d7e6fd7337dcd632969f37f90","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                        \u0027token\u0027: token}"},{"line_number":386,"context_line":"                auth_plugin \u003d identity.Token(**auth)"},{"line_number":387,"context_line":"            elif auth_url and username and password:"},{"line_number":388,"context_line":"                auth \u003d {\u0027auth_url\u0027: auth_url,"},{"line_number":389,"context_line":"                        \u0027username\u0027: username,"},{"line_number":390,"context_line":"                        \u0027password\u0027: password,"},{"line_number":391,"context_line":"                        \u0027project_name\u0027: project_name,"},{"line_number":392,"context_line":"                        \u0027project_id\u0027: project_id,"},{"line_number":393,"context_line":"                        \u0027project_domain_id\u0027: project_domain_id,"},{"line_number":394,"context_line":"                        \u0027user_domain_id\u0027: user_domain_id}"},{"line_number":395,"context_line":"                auth_plugin \u003d identity.Password(**auth)"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"        if auth_plugin is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_7c050544","line":394,"range":{"start_line":388,"start_character":23,"end_line":394,"end_character":57},"updated":"2017-03-05 22:43:34.000000000","message":"Similar comment as for token plugin.","commit_id":"e2f792fa6ab998b4ac76125cba1d605916244592"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5e44f368a1d3f00d7e6fd7337dcd632969f37f90","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                             service_type\u003dservice_type,"},{"line_number":412,"context_line":"                             region_name\u003dregion_name,"},{"line_number":413,"context_line":"                             **kwargs)"},{"line_number":414,"context_line":"    else:"},{"line_number":415,"context_line":"        # FIXME(bklei): username and password are now optional. Need"},{"line_number":416,"context_line":"        # to test that they were provided in this mode.  Should also"},{"line_number":417,"context_line":"        # refactor to use kwargs."}],"source_content_type":"text/x-python","patch_set":5,"id":"ba2be162_1c37a9ff","line":414,"range":{"start_line":414,"start_character":4,"end_line":414,"end_character":9},"updated":"2017-03-05 22:43:34.000000000","message":"Now, is there a case where we come here?\n\nI think if we fail to get session object it means some authentication failure and even if we try HTTPClient we will get nothing.\n\nThought?\n\n(Note that we can drop HTTPClient later)","commit_id":"e2f792fa6ab998b4ac76125cba1d605916244592"}]}