)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"94dbe52d1c35cea106a451967b55140f659cc4e2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wengjiangang \u003cweng.jiangang@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-19 21:55:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the problem of mox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use mock instead of mox in test file test_name_or_id.py"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bacf61ea_4d56a206","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"updated":"2016-08-02 05:18:54.000000000","message":"The summary line is confusing. What is the real problem of mox?\nThe bug just says let\u0027s replace mox with mock. I think \u0027use mock instead of mox\u0027 is enough.","commit_id":"3fd1a2d49e0d6a7819bd17abe09daf0f63966ba1"},{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"747c53549e69b2607001bb6c2646bfccade8db0b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     wengjiangang \u003cweng.jiangang@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-19 21:55:04 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix the problem of mox"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use mock instead of mox in test file test_name_or_id.py"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_3118a784","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":22},"in_reply_to":"bacf61ea_4d56a206","updated":"2016-08-09 02:03:08.000000000","message":"Done","commit_id":"3fd1a2d49e0d6a7819bd17abe09daf0f63966ba1"}],"neutronclient/tests/unit/test_name_or_id.py":[{"author":{"_account_id":7002,"name":"Yatin Kumbhare","email":"yatinkumbhare@gmail.com","username":"yatin.kumbhare"},"change_message_id":"be8d59dc2f45c09c7bcdaaa79d6c1e4a97d80d35","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from mock import call"},{"line_number":19,"context_line":"from mox3 import mox"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":"import uuid"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_056c6f06","line":19,"updated":"2016-06-27 11:08:03.000000000","message":"remove mox","commit_id":"87cb661e2c50e7c5c03e94f100fca36022c6963b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d2d536d867904b9812501173f92dec224bc0131","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from mock import call"},{"line_number":19,"context_line":"from mox3 import mox"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":"import uuid"},{"line_number":22,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_315a7684","line":19,"in_reply_to":"3aaa91ec_056c6f06","updated":"2016-07-03 12:22:11.000000000","message":"yeah, thats right ...","commit_id":"87cb661e2c50e7c5c03e94f100fca36022c6963b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"0d2d536d867904b9812501173f92dec224bc0131","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def setUp(self):"},{"line_number":32,"context_line":"        \"\"\"Prepare the test environment.\"\"\""},{"line_number":33,"context_line":"        super(CLITestNameorID, self).setUp()"},{"line_number":34,"context_line":"        self.mox \u003d mox.Mox()"},{"line_number":35,"context_line":"        self.endurl \u003d test_cli20.ENDURL"},{"line_number":36,"context_line":"        self.client \u003d client.Client(token\u003dtest_cli20.TOKEN,"},{"line_number":37,"context_line":"                                    endpoint_url\u003dself.endurl)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_115f7a73","line":34,"updated":"2016-07-03 12:22:11.000000000","message":"You need to change this as well , I suppose.\nThere are a lot of places where mox is used( in this file), so you may need to take care of that as well","commit_id":"87cb661e2c50e7c5c03e94f100fca36022c6963b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"94dbe52d1c35cea106a451967b55140f659cc4e2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from mock import call"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":"import uuid"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_2d708ea3","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":21},"updated":"2016-08-02 05:18:54.000000000","message":"We use module-level import. This line is unnecessary.","commit_id":"3fd1a2d49e0d6a7819bd17abe09daf0f63966ba1"},{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"747c53549e69b2607001bb6c2646bfccade8db0b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from mock import call"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":"import uuid"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_3131c70c","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":21},"in_reply_to":"bacf61ea_2d708ea3","updated":"2016-08-09 02:03:08.000000000","message":"Done","commit_id":"3fd1a2d49e0d6a7819bd17abe09daf0f63966ba1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"94dbe52d1c35cea106a451967b55140f659cc4e2","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from mock import call"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":"import uuid"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutronclient.common import exceptions"},{"line_number":23,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_0d778aa0","line":20,"updated":"2016-08-02 05:18:54.000000000","message":"uuid is a standard module. Follow the import grouping guideline.","commit_id":"3fd1a2d49e0d6a7819bd17abe09daf0f63966ba1"},{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"747c53549e69b2607001bb6c2646bfccade8db0b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from mock import call"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":"import uuid"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutronclient.common import exceptions"},{"line_number":23,"context_line":"from neutronclient.neutron import v2_0 as neutronV20"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_11364303","line":20,"in_reply_to":"bacf61ea_0d778aa0","updated":"2016-08-09 02:03:08.000000000","message":"Done","commit_id":"3fd1a2d49e0d6a7819bd17abe09daf0f63966ba1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"94dbe52d1c35cea106a451967b55140f659cc4e2","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            returned_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":71,"context_line":"                self.client, \u0027network\u0027, _id)"},{"line_number":72,"context_line":"            calls \u003d ["},{"line_number":73,"context_line":"                call("},{"line_number":74,"context_line":"                    test_cli20.MyUrlComparator("},{"line_number":75,"context_line":"                        test_cli20.end_url(path, \"fields\u003did\u0026id\u003d\" + _id),"},{"line_number":76,"context_line":"                        self.client),"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_6d6606ee","line":73,"range":{"start_line":73,"start_character":16,"end_line":73,"end_character":20},"updated":"2016-08-02 05:18:54.000000000","message":"call -\u003e mock.call","commit_id":"3fd1a2d49e0d6a7819bd17abe09daf0f63966ba1"},{"author":{"_account_id":20082,"name":"JianGang Weng","email":"weng.jiangang@zte.com.cn","username":"wengjiangang"},"change_message_id":"747c53549e69b2607001bb6c2646bfccade8db0b","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            returned_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":71,"context_line":"                self.client, \u0027network\u0027, _id)"},{"line_number":72,"context_line":"            calls \u003d ["},{"line_number":73,"context_line":"                call("},{"line_number":74,"context_line":"                    test_cli20.MyUrlComparator("},{"line_number":75,"context_line":"                        test_cli20.end_url(path, \"fields\u003did\u0026id\u003d\" + _id),"},{"line_number":76,"context_line":"                        self.client),"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_5140bb56","line":73,"range":{"start_line":73,"start_character":16,"end_line":73,"end_character":20},"in_reply_to":"bacf61ea_6d6606ee","updated":"2016-08-09 02:03:08.000000000","message":"Done","commit_id":"3fd1a2d49e0d6a7819bd17abe09daf0f63966ba1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4cf652f34cb283e6955dddb488f642b2b128a42b","unresolved":false,"context_lines":[{"line_number":44,"context_line":"            mock_request.return_value \u003d (test_cli20.MyResp(200), resstr)"},{"line_number":45,"context_line":"            returned_id \u003d neutronV20.find_resourceid_by_name_or_id("},{"line_number":46,"context_line":"                self.client, \u0027network\u0027, _id)"},{"line_number":47,"context_line":"            mock_request.assert_called_once_with("},{"line_number":48,"context_line":"                test_cli20.MyUrlComparator("},{"line_number":49,"context_line":"                    test_cli20.end_url(path, \"fields\u003did\u0026id\u003d\" + _id),"},{"line_number":50,"context_line":"                    self.client),"}],"source_content_type":"text/x-python","patch_set":7,"id":"9ad45d7e_17926e9e","line":47,"range":{"start_line":47,"start_character":12,"end_line":47,"end_character":48},"updated":"2016-08-10 06:17:31.000000000","message":"It is better to move this out of with-statement.\nInside the with-statement mock patch is applied and out side of the with statement mock patch is not applied, but you can still call the assert method.\n\nThis comment applies to all other similar codes.","commit_id":"b884cea190187f6fbb4dffbb5e59ca83987d010a"}]}
