)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c523b58e93ab29d9d0b72a0fbf03b9748d4ccc8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anindita Das \u003canindita.das@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-07 17:00:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for neutron quota-update returns a list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If no arguments are provided while executing neutron quota-update"},{"line_number":10,"context_line":"instead of printing the current quota values it will throw an error"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_1c2326be","line":7,"updated":"2016-07-07 20:19:01.000000000","message":"The summary line should describe what is fixed more briefly.","commit_id":"0dd90184e80e4a9a5a7b5859301f9aa5884131bd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"09613fcf3bb1a4f2fa5d3936dd714b50aca96b79","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anindita Das \u003canindita.das@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-07 17:00:19 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for neutron quota-update returns a list"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If no arguments are provided while executing neutron quota-update"},{"line_number":10,"context_line":"instead of printing the current quota values it will throw an error"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_0b9f5d51","line":7,"in_reply_to":"1aa78d24_1c2326be","updated":"2016-07-07 21:23:24.000000000","message":"Done","commit_id":"0dd90184e80e4a9a5a7b5859301f9aa5884131bd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c523b58e93ab29d9d0b72a0fbf03b9748d4ccc8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If no arguments are provided while executing neutron quota-update"},{"line_number":10,"context_line":"instead of printing the current quota values it will throw an error"},{"line_number":11,"context_line":"message \"Must specify new values to update quota\" similar to the"},{"line_number":12,"context_line":"one thrown when we execute neutron net-update public"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I476991c39eafa16148f0cc3252ae5c26b9c8cbfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_dca07e44","line":12,"updated":"2016-07-07 20:19:01.000000000","message":"Most *-update commands do not show any new values.\nWhat do you think about making the similar change to quota-update?","commit_id":"0dd90184e80e4a9a5a7b5859301f9aa5884131bd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"09613fcf3bb1a4f2fa5d3936dd714b50aca96b79","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If no arguments are provided while executing neutron quota-update"},{"line_number":10,"context_line":"instead of printing the current quota values it will throw an error"},{"line_number":11,"context_line":"message \"Must specify new values to update quota\" similar to the"},{"line_number":12,"context_line":"one thrown when we execute neutron net-update public"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I476991c39eafa16148f0cc3252ae5c26b9c8cbfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_4ba9657b","line":12,"in_reply_to":"1aa78d24_dca07e44","updated":"2016-07-07 21:23:24.000000000","message":"Done","commit_id":"0dd90184e80e4a9a5a7b5859301f9aa5884131bd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c523b58e93ab29d9d0b72a0fbf03b9748d4ccc8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"message \"Must specify new values to update quota\" similar to the"},{"line_number":12,"context_line":"one thrown when we execute neutron net-update public"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I476991c39eafa16148f0cc3252ae5c26b9c8cbfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_1cd966f3","line":14,"updated":"2016-07-07 20:19:01.000000000","message":"Could you add \u0027Closes-Bug: nnn\u0027 line to link the commit to the bug report?","commit_id":"0dd90184e80e4a9a5a7b5859301f9aa5884131bd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"09613fcf3bb1a4f2fa5d3936dd714b50aca96b79","unresolved":false,"context_lines":[{"line_number":11,"context_line":"message \"Must specify new values to update quota\" similar to the"},{"line_number":12,"context_line":"one thrown when we execute neutron net-update public"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I476991c39eafa16148f0cc3252ae5c26b9c8cbfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aa78d24_abb449d4","line":14,"in_reply_to":"1aa78d24_1cd966f3","updated":"2016-07-07 21:23:24.000000000","message":"Done","commit_id":"0dd90184e80e4a9a5a7b5859301f9aa5884131bd"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"05c60195b348278fbcc46b73efb49e25a94ea8cb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"instead of printing the current quota values it will throw an error"},{"line_number":11,"context_line":"message \"Must specify new values to update quota\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug:https://bugs.launchpad.net/python-neutronclient/+bug/1597552"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I476991c39eafa16148f0cc3252ae5c26b9c8cbfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_31cd6887","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":71},"updated":"2016-07-07 21:28:37.000000000","message":"need to just link ticket number not whole url for bug\n\nCloses-Bug: #1597552","commit_id":"a5dd0f7e81040f9b6fc5078c74cd8a1d1285fdc8"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"659d673612f4f28df4ee540b696e74e6d5b96c10","unresolved":false,"context_lines":[{"line_number":10,"context_line":"instead of printing the current quota values it will throw an error"},{"line_number":11,"context_line":"message \"Must specify new values to update quota\""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug:https://bugs.launchpad.net/python-neutronclient/+bug/1597552"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I476991c39eafa16148f0cc3252ae5c26b9c8cbfc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1aa78d24_54c4625e","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":71},"in_reply_to":"1aa78d24_31cd6887","updated":"2016-07-07 21:58:05.000000000","message":"Done","commit_id":"a5dd0f7e81040f9b6fc5078c74cd8a1d1285fdc8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5299a46bef9ba6a9014400244031be1a8bf3ef3b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Includes release notes."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1597552"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"fa7ab95a_08e1ebfe","line":18,"updated":"2016-08-31 00:07:06.000000000","message":"DocImpact requires a one line explaination of what the change is about, however the commit message is pretty explanatory","commit_id":"98110501e024547dfdc3c3c441ced3f91fe8462c"}],"neutronclient/neutron/v2_0/quota.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0b3258e31d6ba3528287af5c78389cd44424fd42","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                quota[resource] \u003d self._validate_int("},{"line_number":210,"context_line":"                    resource,"},{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"\t\tnoarg \u003d False"},{"line_number":213,"context_line":"\tif noarg:"},{"line_number":214,"context_line":"\t    message \u003d (_(\u0027Must specify new values to update quota\u0027))"},{"line_number":215,"context_line":"            raise exceptions.NeutronClientException(message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_8c709541","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":2},"updated":"2016-07-07 16:16:30.000000000","message":"you need to clean this up, pep8 is gonna complain about it.","commit_id":"b101d22c450378195313a34ac3f1753338a00496"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"0cee9a217866983ab3455f31d4d31958c2139d36","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                quota[resource] \u003d self._validate_int("},{"line_number":210,"context_line":"                    resource,"},{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"\t\tnoarg \u003d False"},{"line_number":213,"context_line":"\tif noarg:"},{"line_number":214,"context_line":"\t    message \u003d (_(\u0027Must specify new values to update quota\u0027))"},{"line_number":215,"context_line":"            raise exceptions.NeutronClientException(message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1aa78d24_fd7d816d","line":212,"range":{"start_line":212,"start_character":0,"end_line":212,"end_character":2},"in_reply_to":"1aa78d24_8c709541","updated":"2016-07-07 21:00:09.000000000","message":"Done","commit_id":"b101d22c450378195313a34ac3f1753338a00496"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c523b58e93ab29d9d0b72a0fbf03b9748d4ccc8","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                noarg \u003d False"},{"line_number":212,"context_line":"        if noarg:"},{"line_number":213,"context_line":"            message \u003d (_(\u0027Must specify new values to update quota\u0027))"},{"line_number":214,"context_line":"            raise exceptions.NeutronClientException(message\u003dmessage)"},{"line_number":215,"context_line":"        return {self.resource: quota}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_dc6ebefe","line":214,"range":{"start_line":214,"start_character":29,"end_line":214,"end_character":52},"updated":"2016-07-07 20:19:01.000000000","message":"NeutronCLIError should be used.\n\nneutronclient/common/exceptions.py says:\n\n* Exceptions from client library:\n  This type of exceptions should inherit NeutronClientException.\n* Exceptions from CLI code:\n  This type of exceptions should inherit NeutronCLIError.","commit_id":"0dd90184e80e4a9a5a7b5859301f9aa5884131bd"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"09613fcf3bb1a4f2fa5d3936dd714b50aca96b79","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                noarg \u003d False"},{"line_number":212,"context_line":"        if noarg:"},{"line_number":213,"context_line":"            message \u003d (_(\u0027Must specify new values to update quota\u0027))"},{"line_number":214,"context_line":"            raise exceptions.NeutronClientException(message\u003dmessage)"},{"line_number":215,"context_line":"        return {self.resource: quota}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aa78d24_4bd7a5ed","line":214,"range":{"start_line":214,"start_character":29,"end_line":214,"end_character":52},"in_reply_to":"1aa78d24_dc6ebefe","updated":"2016-07-07 21:23:24.000000000","message":"Used CommandError as you suggested in IRC instead of NeutronClientException","commit_id":"0dd90184e80e4a9a5a7b5859301f9aa5884131bd"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"05c60195b348278fbcc46b73efb49e25a94ea8cb","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        parser.add_argument("},{"line_number":188,"context_line":"            \u0027pos_tenant_id\u0027,"},{"line_number":189,"context_line":"            help\u003dargparse.SUPPRESS, nargs\u003d\u0027?\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return parser"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _validate_int(self, name, value):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_918b7c1e","side":"PARENT","line":190,"updated":"2016-07-07 21:28:37.000000000","message":"dont remove existing line spaces","commit_id":"1828552b9c6fada3f51a9fd9896737c1cd2ed6e7"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"659d673612f4f28df4ee540b696e74e6d5b96c10","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        parser.add_argument("},{"line_number":188,"context_line":"            \u0027pos_tenant_id\u0027,"},{"line_number":189,"context_line":"            help\u003dargparse.SUPPRESS, nargs\u003d\u0027?\u0027)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        return parser"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    def _validate_int(self, name, value):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_d4ae9297","side":"PARENT","line":190,"in_reply_to":"1aa78d24_918b7c1e","updated":"2016-07-07 21:58:05.000000000","message":"Done","commit_id":"1828552b9c6fada3f51a9fd9896737c1cd2ed6e7"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b625f3a464f4510ee2245e0aec501cfc68ea211f","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"                noarg \u003d False"},{"line_number":213,"context_line":"        if noarg:"},{"line_number":214,"context_line":"            message \u003d (_(\u0027Must specify new values to update quota\u0027))"},{"line_number":215,"context_line":"            raise exceptions.CommandError(message\u003dmessage)"},{"line_number":216,"context_line":"        return {self.resource: quota}"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_a411eab1","line":214,"range":{"start_line":214,"start_character":12,"end_line":214,"end_character":19},"updated":"2016-07-08 16:39:27.000000000","message":"nit:  I\u0027m not sure if you need to create a variable for this or at least the extra parenthesis.\n\n            raise exceptions.CommandError(\n                message\u003d_(\u0027Must specify new values to update quota\u0027))","commit_id":"f9bba53b2cba998e0c7d6b1eb8d22a318373b7af"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e73f37d42d37dba6d6a668c2eccc2221cd75a69a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"                noarg \u003d False"},{"line_number":213,"context_line":"        if noarg:"},{"line_number":214,"context_line":"            message \u003d (_(\u0027Must specify new values to update quota\u0027))"},{"line_number":215,"context_line":"            raise exceptions.CommandError(message\u003dmessage)"},{"line_number":216,"context_line":"        return {self.resource: quota}"},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_95305609","line":214,"range":{"start_line":214,"start_character":12,"end_line":214,"end_character":19},"in_reply_to":"1aa78d24_a411eab1","updated":"2016-07-08 17:54:55.000000000","message":"Done","commit_id":"f9bba53b2cba998e0c7d6b1eb8d22a318373b7af"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0e87bdd04936f91f2d752cf7e759d6fc256f78fe","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                    resource,"},{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"                noarg \u003d False"},{"line_number":213,"context_line":"        if noarg:"},{"line_number":214,"context_line":"            raise exceptions.CommandError("},{"line_number":215,"context_line":"                message\u003d_(\u0027Must specify new values to update quota\u0027))"},{"line_number":216,"context_line":"        return {self.resource: quota}"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_8816a1ef","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":17},"updated":"2016-08-12 14:30:52.000000000","message":"If no argument is specified, quota would be an empty dict when the code reaches here. So there is no need to use \u0027noarg\u0027 value. Consider:\n\n  if not quota:","commit_id":"781f4edb511882656af4fe33024ab51cb3252c67"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"579bc87d04e8993a75ac65d207b2573b35f77c8c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                    resource,"},{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"                noarg \u003d False"},{"line_number":213,"context_line":"        if noarg:"},{"line_number":214,"context_line":"            raise exceptions.CommandError("},{"line_number":215,"context_line":"                message\u003d_(\u0027Must specify new values to update quota\u0027))"},{"line_number":216,"context_line":"        return {self.resource: quota}"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_7ca3cb4f","line":213,"range":{"start_line":213,"start_character":8,"end_line":213,"end_character":17},"in_reply_to":"9ad45d7e_8816a1ef","updated":"2016-08-16 19:09:47.000000000","message":"Done","commit_id":"781f4edb511882656af4fe33024ab51cb3252c67"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0983593d1f1388313bbb3fe6d34bdf8cdf5c92e9","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                quota[resource] \u003d self._validate_int("},{"line_number":210,"context_line":"                    resource,"},{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"        if not quota:"},{"line_number":213,"context_line":"            raise exceptions.CommandError("},{"line_number":214,"context_line":"                message\u003d_(\u0027Must specify new values to update quota\u0027))"},{"line_number":215,"context_line":"        return {self.resource: quota}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_eb547622","line":214,"range":{"start_line":212,"start_character":7,"end_line":214,"end_character":69},"updated":"2016-08-26 22:07:45.000000000","message":"this need update with this condition no matter if some one gives argument or not it will emit same message, incase of wrong argument it could be misleading, for example http://paste.openstack.org/show/564087/, it does not say resource does not exists and possible options.","commit_id":"c806304ecb10ba8ba1792cef8d78151de4ef48fe"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"fc9a8e60adb734d65a1d006ce9251854b1ff4561","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                quota[resource] \u003d self._validate_int("},{"line_number":210,"context_line":"                    resource,"},{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"        if not quota:"},{"line_number":213,"context_line":"            raise exceptions.CommandError("},{"line_number":214,"context_line":"                message\u003d_(\u0027Must specify new values to update quota\u0027))"},{"line_number":215,"context_line":"        return {self.resource: quota}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_f495f286","line":214,"range":{"start_line":212,"start_character":7,"end_line":214,"end_character":69},"in_reply_to":"fa7ab95a_4fcf247f","updated":"2016-08-29 14:55:27.000000000","message":"Done","commit_id":"c806304ecb10ba8ba1792cef8d78151de4ef48fe"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"fc9a8e60adb734d65a1d006ce9251854b1ff4561","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                quota[resource] \u003d self._validate_int("},{"line_number":210,"context_line":"                    resource,"},{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"        if not quota:"},{"line_number":213,"context_line":"            raise exceptions.CommandError("},{"line_number":214,"context_line":"                message\u003d_(\u0027Must specify new values to update quota\u0027))"},{"line_number":215,"context_line":"        return {self.resource: quota}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_b47fea64","line":214,"range":{"start_line":212,"start_character":7,"end_line":214,"end_character":69},"in_reply_to":"fa7ab95a_eb547622","updated":"2016-08-29 14:55:27.000000000","message":"Done","commit_id":"c806304ecb10ba8ba1792cef8d78151de4ef48fe"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"4e477abe1e5bf858f34ee79090754a697b8be516","unresolved":false,"context_lines":[{"line_number":209,"context_line":"                quota[resource] \u003d self._validate_int("},{"line_number":210,"context_line":"                    resource,"},{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"        if not quota:"},{"line_number":213,"context_line":"            raise exceptions.CommandError("},{"line_number":214,"context_line":"                message\u003d_(\u0027Must specify new values to update quota\u0027))"},{"line_number":215,"context_line":"        return {self.resource: quota}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_4fcf247f","line":214,"range":{"start_line":212,"start_character":7,"end_line":214,"end_character":69},"in_reply_to":"fa7ab95a_eb547622","updated":"2016-08-27 06:05:50.000000000","message":"Hmmm.. Nice catch.. IMO, we need to handle such scenario as well.. How about \"message\u003d_(\u0027Must specify a valid resource with new quota value\u0027))\"?","commit_id":"c806304ecb10ba8ba1792cef8d78151de4ef48fe"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b5248a88c5f45b9231570aec522b27fe77da1043","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"        if not quota:"},{"line_number":213,"context_line":"            raise exceptions.CommandError("},{"line_number":214,"context_line":"                message\u003d_(\u0027Must specify a valid resource with new quota value\u0027))"},{"line_number":215,"context_line":"        return {self.resource: quota}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_a0f07dff","line":214,"updated":"2016-08-29 16:25:31.000000000","message":"The line length reaches 80 chars and pep8 complains. Could you wrap lines?\n\nNotes for reviewers: As far as I investigated, the existing behavior of extra args for quota-update does not work, so this change breaks nothing except the point mentioned in the release note.","commit_id":"3314c4a0029ecd190c366b6d3587426c9c97fdf2"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"310e189cd6fd303c0f614e1de660ae07e0f362bf","unresolved":false,"context_lines":[{"line_number":211,"context_line":"                    getattr(parsed_args, resource))"},{"line_number":212,"context_line":"        if not quota:"},{"line_number":213,"context_line":"            raise exceptions.CommandError("},{"line_number":214,"context_line":"                message\u003d_(\u0027Must specify a valid resource with new quota value\u0027))"},{"line_number":215,"context_line":"        return {self.resource: quota}"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_d1e0f5fc","line":214,"in_reply_to":"fa7ab95a_a0f07dff","updated":"2016-08-29 17:01:46.000000000","message":"Fixed. Sorry missed that somehow :(","commit_id":"3314c4a0029ecd190c366b6d3587426c9c97fdf2"}],"neutronclient/tests/unit/test_quota.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b625f3a464f4510ee2245e0aec501cfc68ea211f","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_update_quota_noargs(self):"},{"line_number":64,"context_line":"        resource \u003d \u0027quota\u0027"},{"line_number":65,"context_line":"        cmd \u003d test_quota.UpdateQuota("},{"line_number":66,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":67,"context_line":"        args \u003d [self.test_id]"},{"line_number":68,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_84930e4f","line":65,"range":{"start_line":65,"start_character":36,"end_line":65,"end_character":37},"updated":"2016-07-08 16:39:27.000000000","message":"nit: This break line is not needed\n\ncmd \u003d test_quota.UpdateQuota(test_cli20.MyApp(sys.stdout), None)","commit_id":"f9bba53b2cba998e0c7d6b1eb8d22a318373b7af"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e73f37d42d37dba6d6a668c2eccc2221cd75a69a","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_update_quota_noargs(self):"},{"line_number":64,"context_line":"        resource \u003d \u0027quota\u0027"},{"line_number":65,"context_line":"        cmd \u003d test_quota.UpdateQuota("},{"line_number":66,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":67,"context_line":"        args \u003d [self.test_id]"},{"line_number":68,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_70cb381f","line":65,"range":{"start_line":65,"start_character":36,"end_line":65,"end_character":37},"in_reply_to":"1aa78d24_84930e4f","updated":"2016-07-08 17:54:55.000000000","message":"Done","commit_id":"f9bba53b2cba998e0c7d6b1eb8d22a318373b7af"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b625f3a464f4510ee2245e0aec501cfc68ea211f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        cmd \u003d test_quota.UpdateQuota("},{"line_number":66,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":67,"context_line":"        args \u003d [self.test_id]"},{"line_number":68,"context_line":"        self.assertRaises("},{"line_number":69,"context_line":"            exceptions.CommandError, self._test_update_resource, resource,"},{"line_number":70,"context_line":"            cmd, self.test_id, args\u003dargs, extrafields\u003dNone)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_04cefe59","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":59},"updated":"2016-07-08 16:39:27.000000000","message":"ditto:\n\n        self.assertRaises(exceptions.CommandError, self._test_update_resource,\n                          resource, cmd, self.test_id, args\u003dargs,\n                          extrafields\u003dNone)","commit_id":"f9bba53b2cba998e0c7d6b1eb8d22a318373b7af"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"e73f37d42d37dba6d6a668c2eccc2221cd75a69a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        cmd \u003d test_quota.UpdateQuota("},{"line_number":66,"context_line":"            test_cli20.MyApp(sys.stdout), None)"},{"line_number":67,"context_line":"        args \u003d [self.test_id]"},{"line_number":68,"context_line":"        self.assertRaises("},{"line_number":69,"context_line":"            exceptions.CommandError, self._test_update_resource, resource,"},{"line_number":70,"context_line":"            cmd, self.test_id, args\u003dargs, extrafields\u003dNone)"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_f0d728bd","line":70,"range":{"start_line":68,"start_character":0,"end_line":70,"end_character":59},"in_reply_to":"1aa78d24_04cefe59","updated":"2016-07-08 17:54:55.000000000","message":"Done","commit_id":"f9bba53b2cba998e0c7d6b1eb8d22a318373b7af"}],"releasenotes/notes/fix-quota-update-zero-args-d596c4169c2d2e30.yaml":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e6469976975096dd4c8e8f9d68c216d8917337f1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix CLI quota-update to return an error message for no args"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``quota-update`` CLI will return an error message "},{"line_number":7,"context_line":"      ``Must specify new values to update quota`` if no argument"},{"line_number":8,"context_line":"      is provided while executing it. If arguments are provided "},{"line_number":9,"context_line":"      with the CLI it will behave as expected."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_64f8d07d","line":6,"updated":"2016-08-26 06:21:56.000000000","message":"Plz remove whitespaces.","commit_id":"1eff9c566e9fb9babeb2b1f3dec5031871f61a26"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c8f82c6b377d2ca3e2c9ea373cdd47705866f983","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fix CLI quota-update to return an error message for no args"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``quota-update`` CLI will return an error message "},{"line_number":7,"context_line":"      ``Must specify new values to update quota`` if no argument"},{"line_number":8,"context_line":"      is provided while executing it. If arguments are provided "},{"line_number":9,"context_line":"      with the CLI it will behave as expected."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_3aeb19b2","line":6,"in_reply_to":"fa7ab95a_64f8d07d","updated":"2016-08-26 17:22:47.000000000","message":"Done","commit_id":"1eff9c566e9fb9babeb2b1f3dec5031871f61a26"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"e6469976975096dd4c8e8f9d68c216d8917337f1","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``quota-update`` CLI will return an error message "},{"line_number":7,"context_line":"      ``Must specify new values to update quota`` if no argument"},{"line_number":8,"context_line":"      is provided while executing it. If arguments are provided "},{"line_number":9,"context_line":"      with the CLI it will behave as expected."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_a4f2d898","line":9,"range":{"start_line":8,"start_character":38,"end_line":9,"end_character":46},"updated":"2016-08-26 06:21:56.000000000","message":"Is this really required to mention?","commit_id":"1eff9c566e9fb9babeb2b1f3dec5031871f61a26"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c8f82c6b377d2ca3e2c9ea373cdd47705866f983","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``quota-update`` CLI will return an error message "},{"line_number":7,"context_line":"      ``Must specify new values to update quota`` if no argument"},{"line_number":8,"context_line":"      is provided while executing it. If arguments are provided "},{"line_number":9,"context_line":"      with the CLI it will behave as expected."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_1a5bb588","line":9,"range":{"start_line":8,"start_character":38,"end_line":9,"end_character":46},"in_reply_to":"fa7ab95a_a4f2d898","updated":"2016-08-26 17:22:47.000000000","message":"Added the text Akihiro Motoki specified","commit_id":"1eff9c566e9fb9babeb2b1f3dec5031871f61a26"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"441399055f7016118aa8cc85ae328854225596a6","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``quota-update`` CLI will return an error message "},{"line_number":7,"context_line":"      ``Must specify new values to update quota`` if no argument"},{"line_number":8,"context_line":"      is provided while executing it. If arguments are provided "},{"line_number":9,"context_line":"      with the CLI it will behave as expected."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_ba93d0a2","line":9,"range":{"start_line":8,"start_character":38,"end_line":9,"end_character":46},"in_reply_to":"fa7ab95a_a4f2d898","updated":"2016-08-26 08:22:11.000000000","message":"Tend to agree with vikram.\n\nIf you would like to mention the behavior with arguments, I would suggest:\n\n  If arguments are provided with CLI, no existing behavior is changed.","commit_id":"1eff9c566e9fb9babeb2b1f3dec5031871f61a26"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"c8f82c6b377d2ca3e2c9ea373cdd47705866f983","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"    * ``quota-update`` CLI will return an error message "},{"line_number":7,"context_line":"      ``Must specify new values to update quota`` if no argument"},{"line_number":8,"context_line":"      is provided while executing it. If arguments are provided "},{"line_number":9,"context_line":"      with the CLI it will behave as expected."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"fa7ab95a_ba1c89c2","line":9,"range":{"start_line":8,"start_character":38,"end_line":9,"end_character":46},"in_reply_to":"fa7ab95a_ba93d0a2","updated":"2016-08-26 17:22:47.000000000","message":"Done","commit_id":"1eff9c566e9fb9babeb2b1f3dec5031871f61a26"}]}