)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cf3a64a338d8843c0e2d95fe336e1061d2496bd0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shihanzhang \u003cshihanzhang@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-08 19:05:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not send request to neutron-server if tags are None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is no need to send request to neutron-server if we set network"},{"line_number":10,"context_line":"tags with None, this patch add a check for it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_0d22d501","line":7,"range":{"start_line":7,"start_character":50,"end_line":7,"end_character":54},"updated":"2016-08-12 09:15:52.000000000","message":"I think, instead of None, you can say \" if tags are not provided\" or \"if tags are blank\"","commit_id":"bdb222262f278f998e358a38fff799b526a5fe81"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"0c3ccc525a76d07757c5458d5fa991a906c96764","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shihanzhang \u003cshihanzhang@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-08 19:05:10 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Do not send request to neutron-server if tags are None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is no need to send request to neutron-server if we set network"},{"line_number":10,"context_line":"tags with None, this patch add a check for it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"9ad45d7e_305d6e49","line":7,"range":{"start_line":7,"start_character":50,"end_line":7,"end_character":54},"in_reply_to":"9ad45d7e_0d22d501","updated":"2016-08-12 09:34:08.000000000","message":"agree","commit_id":"bdb222262f278f998e358a38fff799b526a5fe81"}],"neutronclient/neutron/v2_0/tag.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"cf3a64a338d8843c0e2d95fe336e1061d2496bd0","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        client \u003d self.get_client()"},{"line_number":53,"context_line":"        resource_type, resource_id \u003d _convert_resource_args(client,"},{"line_number":54,"context_line":"                                                            parsed_args)"},{"line_number":55,"context_line":"        if parsed_args.tag:"},{"line_number":56,"context_line":"            client.add_tag(resource_type, resource_id, parsed_args.tag)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_0d693526","line":55,"updated":"2016-08-12 09:15:52.000000000","message":"if tags are none, then should there be a message displayed to the user???","commit_id":"bdb222262f278f998e358a38fff799b526a5fe81"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"0c3ccc525a76d07757c5458d5fa991a906c96764","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        client \u003d self.get_client()"},{"line_number":53,"context_line":"        resource_type, resource_id \u003d _convert_resource_args(client,"},{"line_number":54,"context_line":"                                                            parsed_args)"},{"line_number":55,"context_line":"        if parsed_args.tag:"},{"line_number":56,"context_line":"            client.add_tag(resource_type, resource_id, parsed_args.tag)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_b0483e8c","line":55,"in_reply_to":"9ad45d7e_0d693526","updated":"2016-08-12 09:34:08.000000000","message":"adding tag to network is a PUT method, even if tag is not None, it does not return message, so do you think there need a message?","commit_id":"bdb222262f278f998e358a38fff799b526a5fe81"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"7eb6d846436c74cf7bd5c8977f9d2bbce77bf7a2","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        client \u003d self.get_client()"},{"line_number":75,"context_line":"        resource_type, resource_id \u003d _convert_resource_args(client,"},{"line_number":76,"context_line":"                                                            parsed_args)"},{"line_number":77,"context_line":"        body \u003d {\u0027tags\u0027: parsed_args.tags}"},{"line_number":78,"context_line":"        client.replace_tag(resource_type, resource_id, body)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7a77a97e_e5a81d7a","line":77,"updated":"2016-11-22 13:08:54.000000000","message":"In case of replace, if a user execute following command, None is set as a tag:\n\n* neutron tag-replace --resource-type network --resource mynetwork --tag \"\"\n\nAfter that, we cannot delete only this tag.  Therefore, could you add the same logic on #55?  In addition, I think \"\" is invalid input for CLI and it\u0027s better to notify to a user with some message.","commit_id":"bdb222262f278f998e358a38fff799b526a5fe81"}]}