)]}'
{"neutronclient/tests/unit/test_cli20.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"09355e4a081a52bff72b9c0701c9f64204091312","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class MyResp(requests.Response):"},{"line_number":70,"context_line":"    def __init__(self, status_code, headers\u003dNone, reason\u003dNone):"},{"line_number":71,"context_line":"        self.status_code \u003d status_code"},{"line_number":72,"context_line":"        self.headers \u003d headers or {}"},{"line_number":73,"context_line":"        self.reason \u003d reason"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_b2774b9e","side":"PARENT","line":70,"updated":"2016-07-19 13:56:01.000000000","message":"Not a critique of your patch, but why is there no super call here?","commit_id":"20047f2ad04dfcb4bc8d481fcb8c5b3f96157a60"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"1d455271e2c82ce3f6dae991977da18b6cdc54f1","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"class MyResp(requests.Response):"},{"line_number":70,"context_line":"    def __init__(self, status_code, headers\u003dNone, reason\u003dNone):"},{"line_number":71,"context_line":"        self.status_code \u003d status_code"},{"line_number":72,"context_line":"        self.headers \u003d headers or {}"},{"line_number":73,"context_line":"        self.reason \u003d reason"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_5c4d3d6b","side":"PARENT","line":70,"in_reply_to":"dada55a8_b2774b9e","updated":"2016-07-19 15:45:57.000000000","message":"It\u0027s a critique of my old patch![1] Because the super call isn\u0027t useful here[2].\n\n[1]: https://review.openstack.org/#/c/270118/13/neutronclient/tests/unit/test_cli20.py\n[2]: https://github.com/kennethreitz/requests/blob/master/requests/models.py#L550-L596","commit_id":"20047f2ad04dfcb4bc8d481fcb8c5b3f96157a60"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"66174d0f52fd2675d94485e6e939881f47a77b2b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            request_id \u003d resp.headers.get(\u0027x-openstack-request-id\u0027)"},{"line_number":115,"context_line":"            # log request-id for each api call"},{"line_number":116,"context_line":"            _logger.debug(\u0027%(method)s call to neutron for \u0027"},{"line_number":117,"context_line":"                          \u0027%(url)s used request id \u0027"},{"line_number":118,"context_line":"                          \u0027%(response_request_id)s\u0027,"},{"line_number":119,"context_line":"                          {\u0027method\u0027: resp.request.method,"},{"line_number":120,"context_line":"                           \u0027url\u0027: resp.url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_7dbeadae","line":117,"range":{"start_line":117,"start_character":35,"end_line":117,"end_character":50},"updated":"2016-08-02 08:51:10.000000000","message":"Request ID is assigned by the server. \u0027used\u0027 sounds a bit odd.\nHow about \"%(method)s call is tracked by request ID %(id)s\"?","commit_id":"53e2ad1ba964bade5ebc2cb2b74113b46adc3f19"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"cc730cf8482ec842604c679a5c7eb775e5772f8f","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            request_id \u003d resp.headers.get(\u0027x-openstack-request-id\u0027)"},{"line_number":115,"context_line":"            # log request-id for each api call"},{"line_number":116,"context_line":"            _logger.debug(\u0027%(method)s call to neutron for \u0027"},{"line_number":117,"context_line":"                          \u0027%(url)s used request id \u0027"},{"line_number":118,"context_line":"                          \u0027%(response_request_id)s\u0027,"},{"line_number":119,"context_line":"                          {\u0027method\u0027: resp.request.method,"},{"line_number":120,"context_line":"                           \u0027url\u0027: resp.url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_c3637aaf","line":117,"range":{"start_line":117,"start_character":35,"end_line":117,"end_character":50},"in_reply_to":"bacf61ea_7dbeadae","updated":"2016-08-02 09:22:39.000000000","message":"I don\u0027t disagree your suggestion but I would make it consitent in other clients[1, 2, 3] if you will not oppose it strongly.\n\n[1]: https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L80-L85\n[2]: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/client.py#L91-L95\n[3]: https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/http.py#L98-L103","commit_id":"53e2ad1ba964bade5ebc2cb2b74113b46adc3f19"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"df201255e9b3f395ecfc66d479640daf699d915c","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            request_id \u003d resp.headers.get(\u0027x-openstack-request-id\u0027)"},{"line_number":115,"context_line":"            # log request-id for each api call"},{"line_number":116,"context_line":"            _logger.debug(\u0027%(method)s call to neutron for \u0027"},{"line_number":117,"context_line":"                          \u0027%(url)s used request id \u0027"},{"line_number":118,"context_line":"                          \u0027%(response_request_id)s\u0027,"},{"line_number":119,"context_line":"                          {\u0027method\u0027: resp.request.method,"},{"line_number":120,"context_line":"                           \u0027url\u0027: resp.url,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_abcc5c35","line":117,"range":{"start_line":117,"start_character":35,"end_line":117,"end_character":50},"in_reply_to":"bacf61ea_c3637aaf","updated":"2016-08-02 10:22:43.000000000","message":"Okay. The consistency is another good point. The current one is not confusing, so I am okay with it.","commit_id":"53e2ad1ba964bade5ebc2cb2b74113b46adc3f19"}]}