)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6fbe78ed64fc5fae13143d61be3ac6633c91dace","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hirofumi Ichihara \u003cichihara.hirofumi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-21 16:31:17 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t load non json body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some neutron POST and PUT APIs don\u0027t return response body,"},{"line_number":10,"context_line":"for instance, dhcp-agent-network-add and l3-agent-router-add."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_55c81474","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":24},"updated":"2016-07-21 08:04:06.000000000","message":"\"decode empty response body\"?","commit_id":"4d9e93d9ace92243ceef61ed6b0e80b85869d9a4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc05efb1e55da77d5ccb3aa0c1180db6f6be246","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hirofumi Ichihara \u003cichihara.hirofumi@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-21 16:31:17 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t load non json body"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Some neutron POST and PUT APIs don\u0027t return response body,"},{"line_number":10,"context_line":"for instance, dhcp-agent-network-add and l3-agent-router-add."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_8f7f0cdf","line":7,"range":{"start_line":7,"start_character":6,"end_line":7,"end_character":24},"in_reply_to":"dada55a8_55c81474","updated":"2016-07-21 11:17:15.000000000","message":"Done","commit_id":"4d9e93d9ace92243ceef61ed6b0e80b85869d9a4"}],"neutronclient/tests/unit/test_cli20.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6fbe78ed64fc5fae13143d61be3ac6633c91dace","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        self.mox.VerifyAll()"},{"line_number":794,"context_line":"        self.mox.UnsetStubs()"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def test_deserialize(self):"},{"line_number":797,"context_line":"        data \u003d u\u0027\u0027"},{"line_number":798,"context_line":"        result \u003d self.client.deserialize(data, 200)"},{"line_number":799,"context_line":"        self.assertEqual(data, result)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_35ec80f2","line":796,"range":{"start_line":796,"start_character":8,"end_line":796,"end_character":24},"updated":"2016-07-21 08:04:06.000000000","message":"More descriptive method name is preferred.\nFor example, test_deserialize_without_data_for_non_204.","commit_id":"4d9e93d9ace92243ceef61ed6b0e80b85869d9a4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5dc05efb1e55da77d5ccb3aa0c1180db6f6be246","unresolved":false,"context_lines":[{"line_number":793,"context_line":"        self.mox.VerifyAll()"},{"line_number":794,"context_line":"        self.mox.UnsetStubs()"},{"line_number":795,"context_line":""},{"line_number":796,"context_line":"    def test_deserialize(self):"},{"line_number":797,"context_line":"        data \u003d u\u0027\u0027"},{"line_number":798,"context_line":"        result \u003d self.client.deserialize(data, 200)"},{"line_number":799,"context_line":"        self.assertEqual(data, result)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_8f0a6c88","line":796,"range":{"start_line":796,"start_character":8,"end_line":796,"end_character":24},"in_reply_to":"dada55a8_35ec80f2","updated":"2016-07-21 11:17:15.000000000","message":"Done","commit_id":"4d9e93d9ace92243ceef61ed6b0e80b85869d9a4"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"959a47d6ad518a63e51c4e741661d9fd0973c544","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def deserialize(self, data, status_code):"},{"line_number":307,"context_line":"        \"\"\"Deserializes a JSON string into a dictionary.\"\"\""},{"line_number":308,"context_line":"        if status_code \u003d\u003d 204 or not data:"},{"line_number":309,"context_line":"            return data"},{"line_number":310,"context_line":"        return serializer.Serializer().deserialize("},{"line_number":311,"context_line":"            data)[\u0027body\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_c6e6f742","line":308,"updated":"2016-07-21 17:45:07.000000000","message":"With 204 we should not send any content. I might argue that this be fixed server side (i.e. drop response body in case of 204)","commit_id":"c447a0f55ea48d05614dfa263343d22065272774"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"858c82f01114e1857b4a57268dd5b457b45bf051","unresolved":false,"context_lines":[{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    def deserialize(self, data, status_code):"},{"line_number":307,"context_line":"        \"\"\"Deserializes a JSON string into a dictionary.\"\"\""},{"line_number":308,"context_line":"        if status_code \u003d\u003d 204 or not data:"},{"line_number":309,"context_line":"            return data"},{"line_number":310,"context_line":"        return serializer.Serializer().deserialize("},{"line_number":311,"context_line":"            data)[\u0027body\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_afed62f1","line":308,"in_reply_to":"dada55a8_c6e6f742","updated":"2016-07-22 15:50:36.000000000","message":"You\u0027re right. It\u0027s better to just change the code like the following because a response with 204 doesn\u0027t have body.\n\n\n if status_code \u003d\u003d 204: --\u003e if not data:","commit_id":"c447a0f55ea48d05614dfa263343d22065272774"}]}