)]}'
{"neutronclient/tests/unit/test_utils.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"46014025982f8cb4b4cf7b5c6b90d9df0e265caf","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                          utils.str2dict, input_str)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_string_with_comma_value_to_dictionary(self):"},{"line_number":53,"context_line":"        input_str \u003d \u0027key1\u003dvalue1,key2\u003dval,ue2,key3\u003dvalue3\u0027"},{"line_number":54,"context_line":"        expected \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027val,ue2\u0027, \u0027key3\u0027: \u0027value3\u0027}"},{"line_number":55,"context_line":"        self.assertEqual(expected, utils.str2dict(input_str))"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_f0e60d43","line":53,"range":{"start_line":53,"start_character":38,"end_line":53,"end_character":45},"updated":"2016-08-24 21:39:50.000000000","message":"I\u0027m not sure how I feel about generally parsing this kind of value like this. Is there a precedent for this? Shouldn\u0027t we quote the value or something or provide a different way of expressing this?","commit_id":"c9161d13685fd9abf7d4d5441ad9580b1595071e"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"86905100f81ee5a985c5a9a3a69fad6dad1f66e3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                          utils.str2dict, input_str)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_string_with_comma_value_to_dictionary(self):"},{"line_number":53,"context_line":"        input_str \u003d \u0027key1\u003dvalue1,key2\u003dval,ue2,key3\u003dvalue3\u0027"},{"line_number":54,"context_line":"        expected \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027val,ue2\u0027, \u0027key3\u0027: \u0027value3\u0027}"},{"line_number":55,"context_line":"        self.assertEqual(expected, utils.str2dict(input_str))"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_134e5396","line":53,"range":{"start_line":53,"start_character":38,"end_line":53,"end_character":45},"in_reply_to":"1ac06dbe_709e9d08","updated":"2016-08-24 22:15:19.000000000","message":"Just to clarify, without this patch\n\n  opt_name\u003d\"classless-static-route\",opt_value\u003d\"169.254.169.254/32,20.20.20.1\"\n\nwill break because when utils.str2dict() is called, the double-quotes in the string have already been stripped away. So it will be like\n\n  opt_name\u003dclassless-static-route,opt_value\u003d169.254.169.254/32,20.20.20.1\n\nThen the parser just uses \",\" as a delimiter. So it fails.","commit_id":"c9161d13685fd9abf7d4d5441ad9580b1595071e"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"6609e112725b715a3cc9f87be7b22309b008ff0d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                          utils.str2dict, input_str)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def test_string_with_comma_value_to_dictionary(self):"},{"line_number":53,"context_line":"        input_str \u003d \u0027key1\u003dvalue1,key2\u003dval,ue2,key3\u003dvalue3\u0027"},{"line_number":54,"context_line":"        expected \u003d {\u0027key1\u0027: \u0027value1\u0027, \u0027key2\u0027: \u0027val,ue2\u0027, \u0027key3\u0027: \u0027value3\u0027}"},{"line_number":55,"context_line":"        self.assertEqual(expected, utils.str2dict(input_str))"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_709e9d08","line":53,"range":{"start_line":53,"start_character":38,"end_line":53,"end_character":45},"in_reply_to":"1ac06dbe_f0e60d43","updated":"2016-08-24 21:51:39.000000000","message":"In real-world example, people would do\n\n  neutron port-update --extra-dhcp-opt opt_name\u003d\"classless-static-route\",opt_value\u003d\"169.254.169.254/32,20.20.20.1\" port1\n\nSince I am using the same method utils.str2dict as other tests here, which doesn\u0027t take double quotes inside the string. So I have to take out double quotes in the test case. But I will update the value to be more realistic.","commit_id":"c9161d13685fd9abf7d4d5441ad9580b1595071e"}]}