)]}'
{"neutronclient/neutron/v2_0/lb/v2/pool.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"53ed5abdf2861d3e270dc098a47c184dbc7e0c46","unresolved":false,"context_lines":[{"line_number":57,"context_line":"def _parse_common_args(parsed_args):"},{"line_number":58,"context_line":"    body \u003d {}"},{"line_number":59,"context_line":"    neutronV20.update_dict(parsed_args,"},{"line_number":60,"context_line":"                           body, [\u0027description\u0027, \u0027lb_algorithm\u0027, \u0027name\u0027,"},{"line_number":61,"context_line":"                                  \u0027session_persistence\u0027])"},{"line_number":62,"context_line":"    return body"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_857f3565","line":60,"updated":"2016-08-17 07:25:35.000000000","message":"IIUC, \u0027lb_algorithm\u0027 should not be here as we have removed the same from the above function..","commit_id":"b61a2438d29e171b26390cd2387b3f6c6aa7d2a1"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"35aa88b0f9048a791fdead12c68eeb004a2db6f8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"def _parse_common_args(parsed_args):"},{"line_number":58,"context_line":"    body \u003d {}"},{"line_number":59,"context_line":"    neutronV20.update_dict(parsed_args,"},{"line_number":60,"context_line":"                           body, [\u0027description\u0027, \u0027lb_algorithm\u0027, \u0027name\u0027,"},{"line_number":61,"context_line":"                                  \u0027session_persistence\u0027])"},{"line_number":62,"context_line":"    return body"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_a03fbf85","line":60,"in_reply_to":"3ac371cc_65f03968","updated":"2016-08-17 07:51:02.000000000","message":"My only concern here is .. function \"def _add_common_args(parser):\" doesn\u0027t adds \u0027lb_algorithm\u0027 but we parse it in \"def _parse_common_args(parsed_args):\".. which looks little odd.. \n\nI agree what we want to achieve is accomplished but the code looks little cryptic..","commit_id":"b61a2438d29e171b26390cd2387b3f6c6aa7d2a1"},{"author":{"_account_id":6116,"name":"li,chen","email":"shchenli@cn.ibm.com","username":"chen-li"},"change_message_id":"15ac0a9d6ac826a5b0190cac94ec2d27f2f2f90d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"def _parse_common_args(parsed_args):"},{"line_number":58,"context_line":"    body \u003d {}"},{"line_number":59,"context_line":"    neutronV20.update_dict(parsed_args,"},{"line_number":60,"context_line":"                           body, [\u0027description\u0027, \u0027lb_algorithm\u0027, \u0027name\u0027,"},{"line_number":61,"context_line":"                                  \u0027session_persistence\u0027])"},{"line_number":62,"context_line":"    return body"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3ac371cc_65f03968","line":60,"in_reply_to":"3ac371cc_857f3565","updated":"2016-08-17 07:41:04.000000000","message":"No, I don\u0027t think so.\n\nThe reason we removed the \u0027lb_algorithm\u0027 from _add_common_args is we need to set required\u003dTrue for create, but required\u003dFalse for update. We didn\u0027t remove it. So it still need to be updated into body for both create and update commands.","commit_id":"b61a2438d29e171b26390cd2387b3f6c6aa7d2a1"}]}