)]}'
{"neutronclient/osc/v2/trunk/network_trunk.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"f817300e6a16ec967f9fe9c9e380959da837b4aa","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def get_parser(self, prog_name):"},{"line_number":130,"context_line":"        parser \u003d super(ListNetworkTrunk, self).get_parser(prog_name)"},{"line_number":131,"context_line":"        parser.add_argument("},{"line_number":132,"context_line":"            \u0027--long\u0027,"},{"line_number":133,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":134,"context_line":"            default\u003dFalse,"},{"line_number":135,"context_line":"            help\u003d_(\"List additional fields in output\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_c07f8264","line":132,"updated":"2016-08-04 01:30:55.000000000","message":"is --verbose or --all more appropriate? Is there an OSC written rule?","commit_id":"312b1b812834dfb56d26cccd91f092688c381347"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5467d452495a11f85356eeb81e2cb5dafa17edab","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def get_parser(self, prog_name):"},{"line_number":130,"context_line":"        parser \u003d super(ListNetworkTrunk, self).get_parser(prog_name)"},{"line_number":131,"context_line":"        parser.add_argument("},{"line_number":132,"context_line":"            \u0027--long\u0027,"},{"line_number":133,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":134,"context_line":"            default\u003dFalse,"},{"line_number":135,"context_line":"            help\u003d_(\"List additional fields in output\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e0aba687","line":132,"in_reply_to":"bacf61ea_c07f8264","updated":"2016-08-04 01:32:48.000000000","message":"long is commonly used all over OSC commands including the network v2 commands","commit_id":"312b1b812834dfb56d26cccd91f092688c381347"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"86b11de12fd43bc92351c4c8b0676c6cb9eff752","unresolved":false,"context_lines":[{"line_number":186,"context_line":"            action\u003dparseractions.MultiKeyValueAction, dest\u003d\u0027set_subports\u0027,"},{"line_number":187,"context_line":"            help\u003d_(\"Subport to add. Subport is of form \""},{"line_number":188,"context_line":"                   \"\\\u0027port\u003d\u003cname or ID\u003e,segmentation-type\u003d,segmentation-ID\u003d\\\u0027\""},{"line_number":189,"context_line":"                   \"(--subport) option can be repeated)\")"},{"line_number":190,"context_line":"        )"},{"line_number":191,"context_line":"        admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":192,"context_line":"        admin_group.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_9595cae5","line":189,"range":{"start_line":189,"start_character":54,"end_line":189,"end_character":55},"updated":"2016-08-04 01:11:51.000000000","message":"remove this in next patch","commit_id":"312b1b812834dfb56d26cccd91f092688c381347"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ec9409c5bfe3589b1e6fa16b02dc82816bd30ad5","unresolved":false,"context_lines":[{"line_number":129,"context_line":"    def get_parser(self, prog_name):"},{"line_number":130,"context_line":"        parser \u003d super(ListNetworkTrunk, self).get_parser(prog_name)"},{"line_number":131,"context_line":"        parser.add_argument("},{"line_number":132,"context_line":"            \u0027--long\u0027,"},{"line_number":133,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":134,"context_line":"            default\u003dFalse,"},{"line_number":135,"context_line":"            help\u003d_(\"List additional fields in output\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_601b361c","line":132,"updated":"2016-08-04 01:31:21.000000000","message":"see comment on PS1","commit_id":"5266813747144fb8fb7f42fe1944632c8928f523"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a39407fc1d6344eeaa9f3930cb74b1ea40b3bad1","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            LOG.error(_LE(\"Failed to set trunk with name or ID \u0027%(t)s\u0027: %(e)s\")"},{"line_number":214,"context_line":"                      % {\u0027t\u0027: parsed_args.trunk, \u0027e\u0027: e})"},{"line_number":215,"context_line":"            failed \u003d True"},{"line_number":216,"context_line":"        if parsed_args.set_subports:"},{"line_number":217,"context_line":"            subport_attrs \u003d _get_attrs_for_subports(self.app.client_manager,"},{"line_number":218,"context_line":"                                                    parsed_args)"},{"line_number":219,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_b637fb4b","line":216,"updated":"2016-08-04 23:45:27.000000000","message":"should we stop here if we fail to update basic stuff?","commit_id":"400031483a5059025ea7e1e2e75ebeadee664008"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"340e02f5eb2fa389f4428a1fa3f86823ad8d065b","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            LOG.error(_LE(\"Failed to set trunk with name or ID \u0027%(t)s\u0027: %(e)s\")"},{"line_number":214,"context_line":"                      % {\u0027t\u0027: parsed_args.trunk, \u0027e\u0027: e})"},{"line_number":215,"context_line":"            failed \u003d True"},{"line_number":216,"context_line":"        if parsed_args.set_subports:"},{"line_number":217,"context_line":"            subport_attrs \u003d _get_attrs_for_subports(self.app.client_manager,"},{"line_number":218,"context_line":"                                                    parsed_args)"},{"line_number":219,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_129ea262","line":216,"in_reply_to":"bacf61ea_b637fb4b","updated":"2016-08-05 22:28:47.000000000","message":"cant think of a reason why not. Done","commit_id":"400031483a5059025ea7e1e2e75ebeadee664008"}],"neutronclient/tests/unit/osc/v2/trunk/test_network_trunk.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e0debeb5d2297bf611e3c56a1982ab35c3225e0c","unresolved":false,"context_lines":[{"line_number":499,"context_line":"            mock.MagicMock(side_effect\u003dexceptions.CommandError)"},{"line_number":500,"context_line":"        )"},{"line_number":501,"context_line":"        try:"},{"line_number":502,"context_line":"            self.cmd.take_action(parsed_args)"},{"line_number":503,"context_line":"            self.fail(\u0027CommandError should be raised.\u0027)"},{"line_number":504,"context_line":"        except exceptions.CommandError as e:"},{"line_number":505,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_3c6bb486","line":502,"updated":"2016-08-05 22:52:29.000000000","message":"why don\u0027t you use testtools.ExceptedExceptions? It should lead to a more compat assert:\n\n   with testtools.ExpectedException(exceptions.CommandError) as myexc:\n    self.cmd.take_action(parsed_args)\n    # assert myexc condition","commit_id":"40d73b35b2790f18e7919a37a54699a654a15bc3"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"b083c7a7742806228cb31bb95af109db02422970","unresolved":false,"context_lines":[{"line_number":499,"context_line":"            mock.MagicMock(side_effect\u003dexceptions.CommandError)"},{"line_number":500,"context_line":"        )"},{"line_number":501,"context_line":"        try:"},{"line_number":502,"context_line":"            self.cmd.take_action(parsed_args)"},{"line_number":503,"context_line":"            self.fail(\u0027CommandError should be raised.\u0027)"},{"line_number":504,"context_line":"        except exceptions.CommandError as e:"},{"line_number":505,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_3248fbcb","line":502,"in_reply_to":"bacf61ea_3c6bb486","updated":"2016-08-06 00:36:20.000000000","message":"Done","commit_id":"40d73b35b2790f18e7919a37a54699a654a15bc3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e0debeb5d2297bf611e3c56a1982ab35c3225e0c","unresolved":false,"context_lines":[{"line_number":525,"context_line":"            mock.MagicMock(side_effect\u003dexceptions.CommandError)"},{"line_number":526,"context_line":"        )"},{"line_number":527,"context_line":"        try:"},{"line_number":528,"context_line":"            self.cmd.take_action(parsed_args)"},{"line_number":529,"context_line":"            self.fail(\u0027CommandError should be raised.\u0027)"},{"line_number":530,"context_line":"        except exceptions.CommandError as e:"},{"line_number":531,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_bc0de4e9","line":528,"updated":"2016-08-05 22:52:29.000000000","message":"ditto.","commit_id":"40d73b35b2790f18e7919a37a54699a654a15bc3"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"b083c7a7742806228cb31bb95af109db02422970","unresolved":false,"context_lines":[{"line_number":525,"context_line":"            mock.MagicMock(side_effect\u003dexceptions.CommandError)"},{"line_number":526,"context_line":"        )"},{"line_number":527,"context_line":"        try:"},{"line_number":528,"context_line":"            self.cmd.take_action(parsed_args)"},{"line_number":529,"context_line":"            self.fail(\u0027CommandError should be raised.\u0027)"},{"line_number":530,"context_line":"        except exceptions.CommandError as e:"},{"line_number":531,"context_line":"            self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_12dfb7d6","line":528,"in_reply_to":"bacf61ea_bc0de4e9","updated":"2016-08-06 00:36:20.000000000","message":"done.. done in some other places as well","commit_id":"40d73b35b2790f18e7919a37a54699a654a15bc3"}]}