)]}'
{"neutronclient/tests/unit/test_cli20.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"28f03160bd17a96a08e4abf4c264bad958b3e34a","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        self.assertIn(myid, _str)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def _test_update_resource_action(self, resource, cmd, myid, action, args,"},{"line_number":534,"context_line":"                                     body, expected_code\u003d204, retval\u003dNone,"},{"line_number":535,"context_line":"                                     cmd_resource\u003dNone):"},{"line_number":536,"context_line":"        self.mox.StubOutWithMock(cmd, \"get_client\")"},{"line_number":537,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_49592f5a","line":534,"updated":"2016-08-09 05:07:29.000000000","message":"Can we keep the expected output at the end of the arg_list?\nThat would just avoid changing the functions everywhere, isnt it?","commit_id":"31d3ad914c6da193e5e8dea718483b4fdadaa5a4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f1f21cef7335dd1bf5bbf7b344e673d0466790a1","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        self.assertIn(myid, _str)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def _test_update_resource_action(self, resource, cmd, myid, action, args,"},{"line_number":534,"context_line":"                                     body, expected_code\u003d204, retval\u003dNone,"},{"line_number":535,"context_line":"                                     cmd_resource\u003dNone):"},{"line_number":536,"context_line":"        self.mox.StubOutWithMock(cmd, \"get_client\")"},{"line_number":537,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_7f7deab0","line":534,"in_reply_to":"9ad45d7e_44e636b5","updated":"2016-08-12 12:29:55.000000000","message":"This is a private method and used in only a few places. I am okay with the order of argument.\n\nBTW, what is the reason you chose 204 for the default value?\nI think 200 is an usual response code of PUT operation (at least in Neutron API).","commit_id":"31d3ad914c6da193e5e8dea718483b4fdadaa5a4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"94488f4c0b4cba04d88ace72e9c4da1e7e3f999a","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        self.assertIn(myid, _str)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def _test_update_resource_action(self, resource, cmd, myid, action, args,"},{"line_number":534,"context_line":"                                     body, expected_code\u003d204, retval\u003dNone,"},{"line_number":535,"context_line":"                                     cmd_resource\u003dNone):"},{"line_number":536,"context_line":"        self.mox.StubOutWithMock(cmd, \"get_client\")"},{"line_number":537,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_44e636b5","line":534,"in_reply_to":"9ad45d7e_49592f5a","updated":"2016-08-09 05:52:11.000000000","message":"You says the following?\n\n\n def _test_update_resource_action(self, ********, expected_code\u003dNone):\n     expected_code \u003d expected_code or 204\n\n\nI thought so too but actually _test_update_resource_action() is called in two places only (that is, test_cli20_router.py and test_cli20_speaker.py) and they don\u0027t use cmd_resource. And also \"expected_code\" is not None as default so I think that the fix is currently the best.\n\nIf \"expected_code\" was None as default and the method was called from other places, I would make it like you said.","commit_id":"31d3ad914c6da193e5e8dea718483b4fdadaa5a4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"740a8e026645e057e8c4a92bc05c9f914a56533b","unresolved":false,"context_lines":[{"line_number":531,"context_line":"        self.assertIn(myid, _str)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def _test_update_resource_action(self, resource, cmd, myid, action, args,"},{"line_number":534,"context_line":"                                     body, expected_code\u003d204, retval\u003dNone,"},{"line_number":535,"context_line":"                                     cmd_resource\u003dNone):"},{"line_number":536,"context_line":"        self.mox.StubOutWithMock(cmd, \"get_client\")"},{"line_number":537,"context_line":"        self.mox.StubOutWithMock(self.client.httpclient, \"request\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_1553e217","line":534,"in_reply_to":"9ad45d7e_7f7deab0","updated":"2016-08-30 15:24:15.000000000","message":"Done","commit_id":"31d3ad914c6da193e5e8dea718483b4fdadaa5a4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f1f21cef7335dd1bf5bbf7b344e673d0466790a1","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                \u0027X-Auth-Token\u0027, TOKEN)).AndReturn((MyResp(expected_code),"},{"line_number":548,"context_line":"                                                   retval))"},{"line_number":549,"context_line":"        self.mox.ReplayAll()"},{"line_number":550,"context_line":"        cmd_parser \u003d cmd.get_parser(\"delete_\" + cmd_resource)"},{"line_number":551,"context_line":"        shell.run_command(cmd, cmd_parser, args)"},{"line_number":552,"context_line":"        self.mox.VerifyAll()"},{"line_number":553,"context_line":"        self.mox.UnsetStubs()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_dfba1671","line":550,"range":{"start_line":550,"start_character":36,"end_line":550,"end_character":45},"updated":"2016-08-12 12:29:55.000000000","message":"It is not related to this change, but \u0027delete_\u0027 looks odd... This is the update operation.","commit_id":"31d3ad914c6da193e5e8dea718483b4fdadaa5a4"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"740a8e026645e057e8c4a92bc05c9f914a56533b","unresolved":false,"context_lines":[{"line_number":547,"context_line":"                \u0027X-Auth-Token\u0027, TOKEN)).AndReturn((MyResp(expected_code),"},{"line_number":548,"context_line":"                                                   retval))"},{"line_number":549,"context_line":"        self.mox.ReplayAll()"},{"line_number":550,"context_line":"        cmd_parser \u003d cmd.get_parser(\"delete_\" + cmd_resource)"},{"line_number":551,"context_line":"        shell.run_command(cmd, cmd_parser, args)"},{"line_number":552,"context_line":"        self.mox.VerifyAll()"},{"line_number":553,"context_line":"        self.mox.UnsetStubs()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa7ab95a_55700aa4","line":550,"range":{"start_line":550,"start_character":36,"end_line":550,"end_character":45},"in_reply_to":"9ad45d7e_dfba1671","updated":"2016-08-30 15:24:15.000000000","message":"I pushed new patch for it.\n\nhttps://review.openstack.org/#/c/362955/","commit_id":"31d3ad914c6da193e5e8dea718483b4fdadaa5a4"}]}