)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"32ccb611283fb2578873e1337bd32a416fc6a147","unresolved":false,"context_lines":[{"line_number":10,"context_line":"However, the current patch provides the ability to create"},{"line_number":11,"context_line":"multiple floating IP addresses."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Please note that only Floating IP addresses can be assigned."},{"line_number":14,"context_line":"Fixed IP addresses cannot be associated with the Floating IP"},{"line_number":15,"context_line":"addresses in the Bulk allocation method.( For now )"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I3913530a8a62b50bec6ed4133b7cf9d3d5a02113"},{"line_number":18,"context_line":"Partially-Closes: #1552631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_9576753c","line":15,"range":{"start_line":13,"start_character":1,"end_line":15,"end_character":51},"updated":"2016-08-25 14:27:17.000000000","message":"I don\u0027t think it is a reasonable assumption at least in the python binding layer. This kind of limitation should not be enforced in the python binding layer and I don\u0027t see any reason not to support it.\n\nIn the CLI layer, we can support only one floating IP creation at once.\nAs a minimum requirement, there is no need to change in CLI.","commit_id":"35fe265c2e25466954cf2637a2f481adea631dca"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"32ccb611283fb2578873e1337bd32a416fc6a147","unresolved":false,"context_lines":[{"line_number":15,"context_line":"addresses in the Bulk allocation method.( For now )"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I3913530a8a62b50bec6ed4133b7cf9d3d5a02113"},{"line_number":18,"context_line":"Partially-Closes: #1552631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1ac06dbe_d5b58dd0","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":26},"updated":"2016-08-25 14:27:17.000000000","message":"\u0027Partially-Closes\u0027 is not a valid tag. If you want to do this, use \u0027Partial-Bug: #1552631\u0027.\n\nIn this case, you can use Closes-Bug as this patch can close a bug in neutronclient.","commit_id":"35fe265c2e25466954cf2637a2f481adea631dca"}],"neutronclient/neutron/v2_0/floatingip.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"32ccb611283fb2578873e1337bd32a416fc6a147","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            help\u003dargparse.SUPPRESS)"},{"line_number":69,"context_line":"        parser.add_argument("},{"line_number":70,"context_line":"            \u0027--floating-ip-address\u0027,"},{"line_number":71,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":72,"context_line":"            help\u003d_(\u0027IP address of the floating IP\u0027"},{"line_number":73,"context_line":"                   \u0027(repeat option to specify multiple floating IP)\u0027))"},{"line_number":74,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_35f341a1","line":71,"range":{"start_line":71,"start_character":11,"end_line":71,"end_character":28},"updated":"2016-08-25 14:27:17.000000000","message":"This provide an incomplete and confusing interface. If it is incomplete, I don\u0027t think you need to support bulk creation in CLI.","commit_id":"35fe265c2e25466954cf2637a2f481adea631dca"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"32ccb611283fb2578873e1337bd32a416fc6a147","unresolved":false,"context_lines":[{"line_number":892,"context_line":"        return self.get(self.floatingip_path % (floatingip), params\u003d_params)"},{"line_number":893,"context_line":""},{"line_number":894,"context_line":"    def create_floatingip(self, body\u003dNone):"},{"line_number":895,"context_line":"        \"\"\"Creates a new floatingip.\"\"\""},{"line_number":896,"context_line":"        temp_body \u003d copy.deepcopy(body)"},{"line_number":897,"context_line":"        output \u003d []"},{"line_number":898,"context_line":"        if (\"floating_ip_address\" in body[\"floatingip\"]):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_95e7953f","line":895,"updated":"2016-08-25 14:27:17.000000000","message":"I don\u0027t understand the interface of this method. What does a user need to pass if he/she wants bulk creation of floating IPs. Could you clarify the interface?\n\nThe following is my opinion.\n\n\nIMHO, when {\u0027floationgip\u0027: \u003cfloating IP definition\u003e} is passed as body a single floating IP is created and when {\u0027floatingips\u0027: [\u003cfloating IP definition\u003e, \u003cfloating IP definition\u003e, ...]} is passed as body bulk creation will be executed.\n\nBy doing so, we can support floating IP association in bulk create too (at least in the python binding layer).\n\nI don\u0027t think we need to specify extra limitation in bulk creation.","commit_id":"35fe265c2e25466954cf2637a2f481adea631dca"}]}