)]}'
{"id":"openstack%2Fpython-neutronclient~356326","triplet_id":"openstack%2Fpython-neutronclient~master~Ibeabf474194b2d38273d76117a3a2f3bee5f7286","project":"openstack/python-neutronclient","branch":"master","topic":"no-check-stderr","hashtags":[],"change_id":"Ibeabf474194b2d38273d76117a3a2f3bee5f7286","subject":"Do not check stderr output from shell","status":"MERGED","created":"2016-08-17 09:10:15.000000000","updated":"2016-08-19 17:18:10.000000000","submitted":"2016-08-19 17:18:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"e49397f1071a6fd20df72daecfe23848f659b173","_number":356326,"virtual_id_number":356326,"owner":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":2,"date":"2016-08-19 17:18:10.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},{"value":0,"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"recommended":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"all":[{"value":1,"date":"2016-08-17 09:23:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-08-19 15:21:30.000000000","_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"value":2,"date":"2016-08-17 11:47:50.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":1,"date":"2016-08-17 16:11:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},{"value":1,"date":"2016-08-17 09:17:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-08-19 15:21:30.000000000","_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},{"value":0,"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-17 09:17:52.000000000","updated_by":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"reviewer":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"state":"REVIEWER"},{"updated":"2016-08-17 09:23:56.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-08-17 11:47:50.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2016-08-17 16:11:44.000000000","updated_by":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"reviewer":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"state":"REVIEWER"},{"updated":"2016-08-19 15:21:30.000000000","updated_by":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"reviewer":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"state":"REVIEWER"},{"updated":"2016-08-19 17:18:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"741feacd00ee1dca79e395f2157ebd1477eb97c0","author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"date":"2016-08-17 09:10:15.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bc3865eeceb03ba3ee005e781a20147a0b8afb34","author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"date":"2016-08-17 09:17:52.000000000","message":"Patch Set 1: Code-Review+1\n\nSeems reasonable, I\u0027m a bit concerned that without a test coverage the number of warnings output to stderr will increase. Under normal circumstances stderr should not return any output. That being said, it is correct that stderr should contain warning and error messages, and the exit code should be non-zero in the case of an error.","accounts_in_message":[],"_revision_number":1},{"id":"5cb202c7b1c484cd1ed8693a7eca3de0e9538314","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-08-17 09:23:56.000000000","message":"Patch Set 1: Code-Review+1\n\nI feel the stderr are sometimes pretty necessary.\nHowever, the amount of data populated during tox is pretty high sometimes, so I agree to this change","accounts_in_message":[],"_revision_number":1},{"id":"6f6cdabd8fbedf492f769bb860898db17ca30bc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-17 10:55:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/26/356326/1/check/gate-python-neutronclient-docs-ubuntu-xenial/45409ba//doc/build/html/ : SUCCESS in 5m 06s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/26/356326/1/check/gate-python-neutronclient-pep8-ubuntu-xenial/25c7883/ : SUCCESS in 4m 39s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/26/356326/1/check/gate-python-neutronclient-python27-ubuntu-xenial/720d65e/ : SUCCESS in 4m 05s\n- gate-python-neutronclient-python34 http://logs.openstack.org/26/356326/1/check/gate-python-neutronclient-python34/96e3c34/ : SUCCESS in 5m 09s\n- gate-python-neutronclient-python35 http://logs.openstack.org/26/356326/1/check/gate-python-neutronclient-python35/c221890/ : SUCCESS in 4m 44s\n- gate-python-neutronclient-pypy http://logs.openstack.org/26/356326/1/check/gate-python-neutronclient-pypy/6383a3c/ : SUCCESS in 7m 02s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/26/356326/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/55a4980/ : SUCCESS in 1h 11m 19s\n- check-osc-plugins http://logs.openstack.org/26/356326/1/check/check-osc-plugins/b57a08e/ : SUCCESS in 4m 41s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/26/356326/1/check/gate-neutronclient-test-dsvm-functional/0065617/ : SUCCESS in 34m 52s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/26/356326/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/c61b860/ : SUCCESS in 34m 24s","accounts_in_message":[],"_revision_number":1},{"id":"faef590d23bc80e492eb5d5dc5ef509793abf912","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2016-08-17 11:47:50.000000000","message":"Patch Set 1: Code-Review+2\n\nI am fine with this change. As the commit message says, deprecation warning or some stderr message can be emitted by dependent python libraries and there is nothing to do in neutronclient. When we need to check some message, we should check the message explicitly rather than checking if stderr is empty.","accounts_in_message":[],"_revision_number":1},{"id":"3efc0da9b2d7a0fb62e81415e5bf441a22325160","author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"date":"2016-08-17 16:11:44.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"ad752032e5af2c7e79b82afbd2119b41564b28d7","author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"date":"2016-08-19 15:21:30.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ca8eddaa10383f541c07c542ab2c5d382625f352","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-19 15:21:41.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"ce61cf8d9aafe0d45aa32f2166c7ffccdf315785","date":"2016-08-19 17:18:10.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"7cbb47b97cdc61f804873b9cf65ba1e9cbe67cd0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-19 17:18:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/26/356326/1/gate/gate-python-neutronclient-docs-ubuntu-xenial/1561478//doc/build/html/ : SUCCESS in 3m 22s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/26/356326/1/gate/gate-python-neutronclient-pep8-ubuntu-xenial/6a267d1/ : SUCCESS in 3m 42s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/26/356326/1/gate/gate-python-neutronclient-python27-ubuntu-xenial/87c678d/ : SUCCESS in 3m 59s\n- gate-python-neutronclient-python34 http://logs.openstack.org/26/356326/1/gate/gate-python-neutronclient-python34/12dd129/ : SUCCESS in 2m 53s\n- gate-python-neutronclient-python35 http://logs.openstack.org/26/356326/1/gate/gate-python-neutronclient-python35/dd4e1fc/ : SUCCESS in 7m 11s\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/26/356326/1/gate/gate-tempest-dsvm-neutron-src-python-neutronclient/de0b377/ : SUCCESS in 1h 14m 43s\n- check-osc-plugins http://logs.openstack.org/26/356326/1/gate/check-osc-plugins/eea7722/ : SUCCESS in 3m 35s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/26/356326/1/gate/gate-neutronclient-test-dsvm-functional/2bc11aa/ : SUCCESS in 35m 27s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/26/356326/1/gate/gate-neutronclient-test-dsvm-functional-adv-svcs/e4d20a4/ : SUCCESS in 34m 28s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a16135029a404eff7db4833d3b511afdd7a78ec9","revisions":{"a16135029a404eff7db4833d3b511afdd7a78ec9":{"kind":"REWORK","_number":1,"created":"2016-08-17 09:10:15.000000000","uploader":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"ref":"refs/changes/26/356326/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/26/356326/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/356326/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/356326/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/26/356326/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/26/356326/1"}}},"commit":{"parents":[{"commit":"618bc69660f33f358be70cadc9a4033880fec94e","subject":"Merge \"Add quota support for LB and Listeners\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/618bc69660f33f358be70cadc9a4033880fec94e"}]}],"author":{"name":"Henry Gessau","email":"gessau@gmail.com","date":"2016-08-17 08:44:32.000000000","tz":-240},"committer":{"name":"Henry Gessau","email":"gessau@gmail.com","date":"2016-08-17 09:05:55.000000000","tz":-240},"subject":"Do not check stderr output from shell","message":"Do not check stderr output from shell\n\nThe output from shell commands may contain warning messages which are\nnot errors. There are cases where there is nothing neutronclient can\ndo to avoid, for example, depecration messages.\n\nThe ShellTest.shell() already checks for SystemExit result codes, so\nasserting that stderr is empty is not needed.\n\nChange-Id: Ibeabf474194b2d38273d76117a3a2f3bee5f7286\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a16135029a404eff7db4833d3b511afdd7a78ec9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/a16135029a404eff7db4833d3b511afdd7a78ec9"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
