)]}'
{"neutronclient/neutron/v2_0/qos/bandwidth_limit_rule.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"08437aa64fe990cdb598a4b96b97df7ca702989b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027--max-burst-kbps\u0027,"},{"line_number":33,"context_line":"        help\u003d_(\u0027max burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from port point of view.\u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_82af9293","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":22},"updated":"2016-08-19 08:59:38.000000000","message":"This is a required option. I think previously \u0027egress\u0027 is assumed.\nHow about adding the default parameter?\nBy doing so, existing users need not to change their comamand lines.","commit_id":"0ced2419e9b1c5ccd091df8579082750f943be15"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7489e6d2780d78e72fc23dd05baac3dd8045d0d3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027--max-burst-kbps\u0027,"},{"line_number":33,"context_line":"        help\u003d_(\u0027max burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from port point of view.\u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_83933e4f","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":22},"in_reply_to":"1ac06dbe_a3047ac6","updated":"2016-08-19 10:11:22.000000000","message":"thx :)","commit_id":"0ced2419e9b1c5ccd091df8579082750f943be15"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"87371b9be1440cbb07d2f994ddcc4c223d81a91a","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027--max-burst-kbps\u0027,"},{"line_number":33,"context_line":"        help\u003d_(\u0027max burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from port point of view.\u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_857319e7","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":22},"in_reply_to":"3ac371cc_82af9293","updated":"2016-08-19 10:04:50.000000000","message":"In neutron server default value is \"egress\" so it\u0027s not required in client. If I will add default value here then it will be set also in update rule command so if user will not specify it during update rule, than it will be changed to \"egress\" always.\nI can move this from \"add_bandwidth_limit_arguments\" function to specify it with default value for add command and without default for update command but I\u0027m not sure if it is really neccessary.\nWhat You think?","commit_id":"0ced2419e9b1c5ccd091df8579082750f943be15"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bb37d14c2773801e4d3dc0296c9a0e7ff8cc70fc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u0027--max-burst-kbps\u0027,"},{"line_number":33,"context_line":"        help\u003d_(\u0027max burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from port point of view.\u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_a3047ac6","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":22},"in_reply_to":"3ac371cc_857319e7","updated":"2016-08-19 10:10:00.000000000","message":"Sorry it seem I was confused. you are right.\nNow I think there is no need to specify the default value.","commit_id":"0ced2419e9b1c5ccd091df8579082750f943be15"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"08437aa64fe990cdb598a4b96b97df7ca702989b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from port point of view.\u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3ac371cc_22be9eff","line":37,"range":{"start_line":37,"start_character":68,"end_line":37,"end_character":69},"updated":"2016-08-19 08:59:38.000000000","message":"A space is needed after a period.","commit_id":"0ced2419e9b1c5ccd091df8579082750f943be15"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"87371b9be1440cbb07d2f994ddcc4c223d81a91a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from port point of view.\u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1ac06dbe_634ba25a","line":37,"range":{"start_line":37,"start_character":68,"end_line":37,"end_character":69},"in_reply_to":"3ac371cc_22be9eff","updated":"2016-08-19 10:04:50.000000000","message":"Done","commit_id":"0ced2419e9b1c5ccd091df8579082750f943be15"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b339a738da39bf760cb1e522e47dbdd8fab22a4b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from port point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_26db78ef","line":37,"range":{"start_line":37,"start_character":45,"end_line":37,"end_character":68},"updated":"2016-08-19 10:29:31.000000000","message":"In my opinion, the port is only the conection point between the tenant and the backend. Maybe you should use \"from tenant point of view\"","commit_id":"a267651f3f27a15e769519e8fd4b9d5e0d56eae8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"23644f3763bd63021861058964d6e0879832947c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from port point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_c95c35f0","line":37,"range":{"start_line":37,"start_character":45,"end_line":37,"end_character":68},"in_reply_to":"1ac06dbe_26db78ef","updated":"2016-08-19 10:37:11.000000000","message":"changed","commit_id":"a267651f3f27a15e769519e8fd4b9d5e0d56eae8"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6632c5ec0e6613efa114a52970139def58a193f9","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        help\u003d_(\u0027max burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from tenant point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_74f5ff81","line":36,"updated":"2016-08-19 16:04:05.000000000","message":"default\u003d\u0027egress\u0027, choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],","commit_id":"4edefb5e398d23421383464110e58d4c50879b85"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f8fddc0641ac91f85aecd42f0015d29faf9522fb","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        help\u003d_(\u0027max burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from tenant point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_81b032f6","line":36,"in_reply_to":"1ac06dbe_74f5ff81","updated":"2016-08-19 20:04:45.000000000","message":"See my comment in PS1. amotoki was asking about it also.","commit_id":"4edefb5e398d23421383464110e58d4c50879b85"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d68c84121ef84352095c25e068c7669c6f16787f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        help\u003d_(\u0027max burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from tenant point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_bfc9e77a","line":36,"in_reply_to":"1ac06dbe_81b032f6","updated":"2016-08-21 06:26:23.000000000","message":"Sounds good!","commit_id":"4edefb5e398d23421383464110e58d4c50879b85"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"6632c5ec0e6613efa114a52970139def58a193f9","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from tenant point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_b4c5b75c","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":36},"updated":"2016-08-19 16:04:05.000000000","message":"What does \u0027limited\u0027 conveys here?","commit_id":"4edefb5e398d23421383464110e58d4c50879b85"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d20af070d5d99d695fb7ec5568495c2b0e8c183b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from tenant point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_a881df4f","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":36},"in_reply_to":"1ac06dbe_9fa98b7e","updated":"2016-08-25 20:38:59.000000000","message":"Done","commit_id":"4edefb5e398d23421383464110e58d4c50879b85"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d68c84121ef84352095c25e068c7669c6f16787f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from tenant point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_9fa98b7e","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":36},"in_reply_to":"1ac06dbe_a1b44ef2","updated":"2016-08-21 06:26:23.000000000","message":"How about just saying \"traffic direction to which the rule needs to be applied. The rule can either be applied to ingress or egress flowing traffic. By default, egress traffic is considered.\"","commit_id":"4edefb5e398d23421383464110e58d4c50879b85"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f8fddc0641ac91f85aecd42f0015d29faf9522fb","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027direction of limited traffic from tenant point of view. \u0027"},{"line_number":38,"context_line":"               \u0027Default value: egress\u0027))"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_a1b44ef2","line":37,"range":{"start_line":37,"start_character":29,"end_line":37,"end_character":36},"in_reply_to":"1ac06dbe_b4c5b75c","updated":"2016-08-19 20:04:45.000000000","message":"I wanted to say here that it is direction of traffic to which bandwidth limit is applied (so traffic which is limited to some value).\nDo You have any idea how it could be better?","commit_id":"4edefb5e398d23421383464110e58d4c50879b85"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bbc7436f5a4c89daba856a73e755671f1cd85fb8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    parser.add_argument("},{"line_number":32,"context_line":"        \u0027--max-burst-kbps\u0027,"},{"line_number":33,"context_line":"        help\u003d_(\u0027Maximum burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027traffic direction to which the rule needs to be applied. \u0027"},{"line_number":38,"context_line":"               \u0027The rule can either be applied to ingress or egress flowing \u0027"},{"line_number":39,"context_line":"               \u0027traffic. Default value: egress.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def update_bandwidth_limit_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_abfe3903","line":39,"range":{"start_line":34,"start_character":4,"end_line":39,"end_character":50},"updated":"2016-08-25 20:46:40.000000000","message":"would it a list of direction ? suppose I want rule to be followed for both direction, do i need to separate rule for each direction or one rule with both directions would be fine ?","commit_id":"679136d2db8723b568cd0dd1b36d04ec7aff3d88"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"22be3a87684fe3fb89bb9826eb1b5de5e944cb6b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    parser.add_argument("},{"line_number":32,"context_line":"        \u0027--max-burst-kbps\u0027,"},{"line_number":33,"context_line":"        help\u003d_(\u0027Maximum burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027traffic direction to which the rule needs to be applied. \u0027"},{"line_number":38,"context_line":"               \u0027The rule can either be applied to ingress or egress flowing \u0027"},{"line_number":39,"context_line":"               \u0027traffic. Default value: egress.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def update_bandwidth_limit_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_1cf9dfc8","line":39,"range":{"start_line":34,"start_character":4,"end_line":39,"end_character":50},"in_reply_to":"fa7ab95a_6b2fd1a1","updated":"2016-09-01 03:45:24.000000000","message":"I would prefer if you can \n\n    type\u003dadd utils.convert_to_lowercase here\n\n\n, so that user can add the Ingress/Egress in any capitalisation possible.","commit_id":"679136d2db8723b568cd0dd1b36d04ec7aff3d88"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"5df1a57ee75a5c1c25650023c8e255cc12565751","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    parser.add_argument("},{"line_number":32,"context_line":"        \u0027--max-burst-kbps\u0027,"},{"line_number":33,"context_line":"        help\u003d_(\u0027Maximum burst bandwidth in kbps.\u0027))"},{"line_number":34,"context_line":"    parser.add_argument("},{"line_number":35,"context_line":"        \u0027--direction\u0027,"},{"line_number":36,"context_line":"        choices\u003d[\u0027ingress\u0027, \u0027egress\u0027],"},{"line_number":37,"context_line":"        help\u003d_(\u0027traffic direction to which the rule needs to be applied. \u0027"},{"line_number":38,"context_line":"               \u0027The rule can either be applied to ingress or egress flowing \u0027"},{"line_number":39,"context_line":"               \u0027traffic. Default value: egress.\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"def update_bandwidth_limit_args2body(parsed_args, body):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_6b2fd1a1","line":39,"range":{"start_line":34,"start_character":4,"end_line":39,"end_character":50},"in_reply_to":"fa7ab95a_abfe3903","updated":"2016-08-25 21:05:51.000000000","message":"You will need separate rules for each direction in such case.","commit_id":"679136d2db8723b568cd0dd1b36d04ec7aff3d88"}]}
