)]}'
{"id":"openstack%2Fpython-neutronclient~360303","triplet_id":"openstack%2Fpython-neutronclient~master~I22cb3fed9dc442eb90d54b876f7443522709e846","project":"openstack/python-neutronclient","branch":"master","topic":"cleancode","hashtags":[],"change_id":"I22cb3fed9dc442eb90d54b876f7443522709e846","subject":"Clean imports in code","status":"MERGED","created":"2016-08-25 07:46:58.000000000","updated":"2016-09-01 22:57:56.000000000","submitted":"2016-09-01 22:57:56.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9ada326b22898304c8f6405164733a473033a848","_number":360303,"virtual_id_number":360303,"owner":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":2,"date":"2016-09-01 22:57:55.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"recommended":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"all":[{"value":1,"date":"2016-08-25 08:22:54.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-01 10:51:07.000000000","_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"value":2,"date":"2016-09-01 21:46:33.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"all":[{"value":0,"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"value":1,"date":"2016-09-01 21:46:33.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-08-25 08:22:54.000000000","updated_by":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"reviewer":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"state":"REVIEWER"},{"updated":"2016-09-01 10:51:07.000000000","updated_by":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"reviewer":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"state":"REVIEWER"},{"updated":"2016-09-01 21:46:33.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2016-09-01 22:57:55.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"bc795dc6d21dc11e64379acd141058c2483cc5ec","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-08-25 07:46:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"05db7265fbd7192a4808d57cdbed6b88669e317f","author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"date":"2016-08-25 08:22:54.000000000","message":"Patch Set 1: Code-Review+1\n\nDoes a cleanup, but not sure if it is actually required to be done...","accounts_in_message":[],"_revision_number":1},{"id":"801465e00de498a4614dee24929f20abc1555168","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-08-25 08:27:38.000000000","message":"Patch Set 1:\n\n\u003e Does a cleanup, but not sure if it is actually required to be\n \u003e done...\n\nThanks! You can refer the following example: https://review.openstack.org/355303","accounts_in_message":[],"_revision_number":1},{"id":"a773d3d01d56ddbb3a1435ee985e4b49094678cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-25 09:00:33.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/03/360303/1/check/gate-python-neutronclient-docs-ubuntu-xenial/bf6750d//doc/build/html/ : SUCCESS in 2m 20s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-pep8-ubuntu-xenial/032ed86/ : SUCCESS in 4m 02s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-python27-ubuntu-xenial/5b6caf2/ : SUCCESS in 3m 42s\n- gate-python-neutronclient-python34 http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-python34/0908816/ : SUCCESS in 3m 04s\n- gate-python-neutronclient-python35 http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-python35/3ac2218/ : SUCCESS in 4m 24s\n- gate-python-neutronclient-pypy http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-pypy/6a1f317/ : SUCCESS in 2m 57s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/03/360303/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/d325421/ : SUCCESS in 1h 09m 08s\n- check-osc-plugins http://logs.openstack.org/03/360303/1/check/check-osc-plugins/813bd59/ : SUCCESS in 3m 10s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/03/360303/1/check/gate-neutronclient-test-dsvm-functional/9145551/ : FAILURE in 38m 05s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/03/360303/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/9079a1a/ : SUCCESS in 24m 16s","accounts_in_message":[],"_revision_number":1},{"id":"76bf6a4ae4465c708f8c64547230b3cb3d09e1e2","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2016-08-26 01:13:20.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"0c18946f00836bc878bf9f5485d19ca4ae0e721a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-26 02:24:22.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/03/360303/1/check/gate-python-neutronclient-docs-ubuntu-xenial/d9f0311//doc/build/html/ : SUCCESS in 2m 16s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-pep8-ubuntu-xenial/7fcc70e/ : SUCCESS in 2m 21s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-python27-ubuntu-xenial/590118e/ : SUCCESS in 5m 04s\n- gate-python-neutronclient-python34 http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-python34/fd9612d/ : SUCCESS in 2m 16s\n- gate-python-neutronclient-python35 http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-python35/7a9b359/ : SUCCESS in 2m 51s\n- gate-python-neutronclient-pypy http://logs.openstack.org/03/360303/1/check/gate-python-neutronclient-pypy/7c4481a/ : SUCCESS in 2m 59s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/03/360303/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/6ebe882/ : SUCCESS in 1h 10m 47s\n- check-osc-plugins http://logs.openstack.org/03/360303/1/check/check-osc-plugins/68ed9b0/ : SUCCESS in 2m 59s (non-voting)\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/03/360303/1/check/gate-neutronclient-test-dsvm-functional/5197147/ : SUCCESS in 24m 36s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/03/360303/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/ea088d2/ : SUCCESS in 39m 39s","accounts_in_message":[],"_revision_number":1},{"id":"4b168a6b2b47f402b1a8697a1bb8c676f6cdc951","author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"date":"2016-09-01 10:51:07.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3d5fc5fb097a16b53a9c7c9a3d5d5810c1c9d5e7","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-09-01 17:58:17.000000000","message":"Patch Set 1: Code-Review-2\n\nProcedural -2 for release purposes.","accounts_in_message":[],"_revision_number":1},{"id":"f4a0f8644e58779c97998c8f9f70552edff25cad","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-09-01 21:45:51.000000000","message":"Patch Set 1: -Code-Review","accounts_in_message":[],"_revision_number":1},{"id":"4c6003ae8a15324a1b63cd256fe90fc3da71fcf5","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-09-01 21:46:33.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"32296859527ac682f73635b8b3f764c133b6e5e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-01 21:46:44.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"bb73b4142bbc4ffc558172b0990661a4e5901ee7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-01 22:57:55.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/03/360303/1/gate/gate-python-neutronclient-docs-ubuntu-xenial/6bb9205//doc/build/html/ : SUCCESS in 5m 01s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/03/360303/1/gate/gate-python-neutronclient-pep8-ubuntu-xenial/14ee2d1/ : SUCCESS in 4m 23s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/03/360303/1/gate/gate-python-neutronclient-python27-ubuntu-xenial/0af0694/ : SUCCESS in 3m 35s\n- gate-python-neutronclient-python34 http://logs.openstack.org/03/360303/1/gate/gate-python-neutronclient-python34/07034c7/ : SUCCESS in 2m 46s\n- gate-python-neutronclient-python35 http://logs.openstack.org/03/360303/1/gate/gate-python-neutronclient-python35/d0db49b/ : SUCCESS in 4m 35s\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/03/360303/1/gate/gate-tempest-dsvm-neutron-src-python-neutronclient/f0a586c/ : SUCCESS in 1h 11m 00s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/03/360303/1/gate/gate-neutronclient-test-dsvm-functional/6eac28a/ : SUCCESS in 24m 29s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/03/360303/1/gate/gate-neutronclient-test-dsvm-functional-adv-svcs/b7fd35b/ : SUCCESS in 23m 17s","accounts_in_message":[],"_revision_number":1},{"id":"4df1dccba4ac354a20b82650c04330d85ea9b85c","date":"2016-09-01 22:57:56.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"368af6c72f656f4bdcc9594020cc14145ffe6234","revisions":{"368af6c72f656f4bdcc9594020cc14145ffe6234":{"kind":"REWORK","_number":1,"created":"2016-08-25 07:46:58.000000000","uploader":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"ref":"refs/changes/03/360303/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/03/360303/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/03/360303/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/03/360303/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/03/360303/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/03/360303/1"}}},"commit":{"parents":[{"commit":"64e8c3e21a4b75bbcd177d70e93c916068f5308e","subject":"Merge \"Fix prompt message for qos-bandwidth-limit-rule-create\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/64e8c3e21a4b75bbcd177d70e93c916068f5308e"}]}],"author":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-08-25 07:43:48.000000000","tz":420},"committer":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2016-08-25 07:43:48.000000000","tz":420},"subject":"Clean imports in code","message":"Clean imports in code\n\nIn some part in the code we import objects.\nIn the Openstack style guidelines they recommend to import only modules.\n\nhttp://docs.openstack.org/developer/hacking/#imports\n\nChange-Id: I22cb3fed9dc442eb90d54b876f7443522709e846\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/368af6c72f656f4bdcc9594020cc14145ffe6234"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/368af6c72f656f4bdcc9594020cc14145ffe6234"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
