)]}'
{"quantum/common/config.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"3802d689fe60072a8d2772b1596616c92c614220","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    log_date_format \u003d options.get(\u0027log_date_format\u0027, DEFAULT_LOG_DATE_FORMAT)"},{"line_number":160,"context_line":"    formatter \u003d logging.Formatter(log_format, log_date_format)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    facility \u003d logging.handlers.SysLogHandler.LOG_SYSLOG"},{"line_number":163,"context_line":"    try:"},{"line_number":164,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/var/run/syslog\u0027,"},{"line_number":165,"context_line":"                                                 facility\u003dfacility)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F8aY%3D","line":162,"updated":"2012-02-01 16:52:33.000000000","message":"Should we make syslog enabled by default or do we want to control it with a command-line flag / option in quantum.conf?","commit_id":"1ef3a1e0c1babf94e9198b85d103b2d53ff45e90"},{"author":{"_account_id":2487,"name":"Thiago Morello","email":"morellon@gmail.com","username":"morellon"},"change_message_id":"98220ed14a00411ecc403f8fd63a8e493b6cf713","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    log_date_format \u003d options.get(\u0027log_date_format\u0027, DEFAULT_LOG_DATE_FORMAT)"},{"line_number":160,"context_line":"    formatter \u003d logging.Formatter(log_format, log_date_format)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    facility \u003d logging.handlers.SysLogHandler.LOG_SYSLOG"},{"line_number":163,"context_line":"    try:"},{"line_number":164,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/var/run/syslog\u0027,"},{"line_number":165,"context_line":"                                                 facility\u003dfacility)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F8V0%3D","line":162,"in_reply_to":"AAAAEH%2F%2F8aY%3D","updated":"2012-02-01 18:49:33.000000000","message":"I agree that we should use a flag like nova\u0027s use-syslog for this one.","commit_id":"1ef3a1e0c1babf94e9198b85d103b2d53ff45e90"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"3802d689fe60072a8d2772b1596616c92c614220","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    facility \u003d logging.handlers.SysLogHandler.LOG_SYSLOG"},{"line_number":163,"context_line":"    try:"},{"line_number":164,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/var/run/syslog\u0027,"},{"line_number":165,"context_line":"                                                 facility\u003dfacility)"},{"line_number":166,"context_line":"    except:"},{"line_number":167,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/dev/log\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F8as%3D","line":164,"updated":"2012-02-01 16:52:33.000000000","message":"Don\u0027t we even try for getting the handler working on the default socket (UDP 514 I think)?","commit_id":"1ef3a1e0c1babf94e9198b85d103b2d53ff45e90"},{"author":{"_account_id":2487,"name":"Thiago Morello","email":"morellon@gmail.com","username":"morellon"},"change_message_id":"98220ed14a00411ecc403f8fd63a8e493b6cf713","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    facility \u003d logging.handlers.SysLogHandler.LOG_SYSLOG"},{"line_number":163,"context_line":"    try:"},{"line_number":164,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/var/run/syslog\u0027,"},{"line_number":165,"context_line":"                                                 facility\u003dfacility)"},{"line_number":166,"context_line":"    except:"},{"line_number":167,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/dev/log\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F8Vs%3D","line":164,"in_reply_to":"AAAAEH%2F%2F8as%3D","updated":"2012-02-01 18:49:33.000000000","message":"I don\u0027t think that would work well for us. When there is no syslogd running, the handler fails silently. Nova\u0027s project uses only the /dev/log socket. I added the /var/run/syslog due to Mac OS X, as it\u0027s my development environment, but I can remove this if you think it\u0027s better.","commit_id":"1ef3a1e0c1babf94e9198b85d103b2d53ff45e90"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"3802d689fe60072a8d2772b1596616c92c614220","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    try:"},{"line_number":164,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/var/run/syslog\u0027,"},{"line_number":165,"context_line":"                                                 facility\u003dfacility)"},{"line_number":166,"context_line":"    except:"},{"line_number":167,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/dev/log\u0027,"},{"line_number":168,"context_line":"                                                 facility\u003dfacility)"},{"line_number":169,"context_line":"    handler.setFormatter(formatter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F8aw%3D","line":166,"updated":"2012-02-01 16:52:33.000000000","message":"in general we try to avoid \"blanket\" exceptions. In this case the exact exception class (socket.error I guess) should be qualified.","commit_id":"1ef3a1e0c1babf94e9198b85d103b2d53ff45e90"},{"author":{"_account_id":2487,"name":"Thiago Morello","email":"morellon@gmail.com","username":"morellon"},"change_message_id":"98220ed14a00411ecc403f8fd63a8e493b6cf713","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    try:"},{"line_number":164,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/var/run/syslog\u0027,"},{"line_number":165,"context_line":"                                                 facility\u003dfacility)"},{"line_number":166,"context_line":"    except:"},{"line_number":167,"context_line":"        handler \u003d logging.handlers.SysLogHandler(address\u003d\u0027/dev/log\u0027,"},{"line_number":168,"context_line":"                                                 facility\u003dfacility)"},{"line_number":169,"context_line":"    handler.setFormatter(formatter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAEH%2F%2F8Vk%3D","line":166,"in_reply_to":"AAAAEH%2F%2F8aw%3D","updated":"2012-02-01 18:49:33.000000000","message":"agreed","commit_id":"1ef3a1e0c1babf94e9198b85d103b2d53ff45e90"}]}