)]}'
{"id":"openstack%2Fpython-neutronclient~373620","triplet_id":"openstack%2Fpython-neutronclient~master~I3f14a7932de5ce1586a9900d5d9801d1fe54c71c","project":"openstack/python-neutronclient","branch":"master","topic":"magic","hashtags":[],"change_id":"I3f14a7932de5ce1586a9900d5d9801d1fe54c71c","subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","status":"MERGED","created":"2016-09-21 03:33:04.000000000","updated":"2016-09-22 16:33:39.000000000","submitted":"2016-09-22 16:33:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bc6b388c1266354fcf9749bfd2795880e69c4a03","_number":373620,"virtual_id_number":373620,"owner":{"_account_id":22574,"name":"lilintan","email":"lintan.li@easystack.cn","username":"lilintan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},{"value":2,"date":"2016-09-22 16:33:39.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"recommended":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"all":[{"value":0,"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-22 14:04:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},{"value":2,"date":"2016-09-22 15:38:34.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":2,"date":"2016-09-22 15:06:10.000000000","_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"all":[{"value":0,"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},{"value":1,"date":"2016-09-22 15:38:34.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-21 05:19:19.000000000","updated_by":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"reviewer":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"state":"REVIEWER"},{"updated":"2016-09-22 14:04:53.000000000","updated_by":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"reviewer":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"state":"REVIEWER"},{"updated":"2016-09-22 15:06:10.000000000","updated_by":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"reviewer":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"state":"REVIEWER"},{"updated":"2016-09-22 15:38:34.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2016-09-22 16:33:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4aaa7e8e005f4cae5cd48e4a765dc2d31459a440","author":{"_account_id":22574,"name":"lilintan","email":"lintan.li@easystack.cn","username":"lilintan"},"date":"2016-09-21 03:33:04.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6e1505d67dd589b962a01128d456a0709107f2ae","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-09-21 03:36:43.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"19443cc19f5efb1de33d0b48ca8fdb1363cf119c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-21 04:35:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/20/373620/1/check/gate-python-neutronclient-docs-ubuntu-xenial/1638059//doc/build/html/ : SUCCESS in 3m 52s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/20/373620/1/check/gate-python-neutronclient-pep8-ubuntu-xenial/e16afc2/ : SUCCESS in 2m 16s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/20/373620/1/check/gate-python-neutronclient-python27-ubuntu-xenial/7311249/ : SUCCESS in 2m 22s\n- gate-python-neutronclient-python34 http://logs.openstack.org/20/373620/1/check/gate-python-neutronclient-python34/d107c1f/ : SUCCESS in 2m 25s\n- gate-python-neutronclient-python35 http://logs.openstack.org/20/373620/1/check/gate-python-neutronclient-python35/9b9d98c/ : SUCCESS in 3m 58s\n- gate-python-neutronclient-pypy http://logs.openstack.org/20/373620/1/check/gate-python-neutronclient-pypy/9b4e383/ : SUCCESS in 5m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/20/373620/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient/c351d7f/ : SUCCESS in 1h 02m 14s\n- check-osc-plugins http://logs.openstack.org/20/373620/1/check/check-osc-plugins/b0eed82/ : SUCCESS in 5m 01s (non-voting)\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/20/373620/1/check/gate-neutronclient-test-dsvm-functional/4ebe9a0/ : SUCCESS in 26m 20s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/20/373620/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs/e03113c/ : SUCCESS in 14m 53s","accounts_in_message":[],"_revision_number":1},{"id":"3291152db40d639392bc27eb4b7ef8ddeede10f7","author":{"_account_id":19136,"name":"Nanke_Liu (lnk)","email":"nanke.liu@easystack.cn","username":"LNK"},"date":"2016-09-21 05:19:19.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"3f13583e01092a6079afe1717c228cb4f0ec7d4b","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-21 21:46:37.000000000","message":"Patch Set 1: Code-Review-1\n\nMissed file \nneutronclient/tests/unit/osc/v2/trunk/test_network_trunk.py\n\nLines 225 525 549\n\nSee link for details:\nhttp://codesearch.openstack.org/?q\u003dMagicMock\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dpython-neutronclient","accounts_in_message":[],"_revision_number":1},{"id":"4204ad9637a3b31882e25bbcec56cdd2ae639e93","author":{"_account_id":22574,"name":"lilintan","email":"lintan.li@easystack.cn","username":"lilintan"},"date":"2016-09-22 10:49:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"8a6feef68414cef6a6c5cf7ca22ab422fd6699db","author":{"_account_id":22574,"name":"lilintan","email":"lintan.li@easystack.cn","username":"lilintan"},"date":"2016-09-22 10:50:27.000000000","message":"Patch Set 2:\n\n\u003e Missed file\n \u003e neutronclient/tests/unit/osc/v2/trunk/test_network_trunk.py\n \u003e \n \u003e Lines 225 525 549\n \u003e \n \u003e See link for details:\n \u003e http://codesearch.openstack.org/?q\u003dMagicMock\u0026i\u003dnope\u0026files\u003d\u0026repos\u003dpython-neutronclient\n\ndone","accounts_in_message":[],"_revision_number":2},{"id":"a8b41a3961e198829c3b21623f07a552c8bf8da8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-22 11:50:54.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/20/373620/2/check/gate-python-neutronclient-docs-ubuntu-xenial/4d37172//doc/build/html/ : SUCCESS in 2m 19s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/20/373620/2/check/gate-python-neutronclient-pep8-ubuntu-xenial/5bb1d32/ : SUCCESS in 3m 28s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/20/373620/2/check/gate-python-neutronclient-python27-ubuntu-xenial/5678f82/ : SUCCESS in 6m 15s\n- gate-python-neutronclient-python34 http://logs.openstack.org/20/373620/2/check/gate-python-neutronclient-python34/b15d9be/ : SUCCESS in 2m 28s\n- gate-python-neutronclient-python35 http://logs.openstack.org/20/373620/2/check/gate-python-neutronclient-python35/a952f25/ : SUCCESS in 4m 00s\n- gate-python-neutronclient-pypy http://logs.openstack.org/20/373620/2/check/gate-python-neutronclient-pypy/38d85e2/ : SUCCESS in 4m 33s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/20/373620/2/check/gate-tempest-dsvm-neutron-src-python-neutronclient/939714f/ : SUCCESS in 1h 00m 02s\n- check-osc-plugins http://logs.openstack.org/20/373620/2/check/check-osc-plugins/c332ce6/ : SUCCESS in 3m 23s (non-voting)\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/20/373620/2/check/gate-neutronclient-test-dsvm-functional/c66f999/ : SUCCESS in 15m 42s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/20/373620/2/check/gate-neutronclient-test-dsvm-functional-adv-svcs/f109327/ : SUCCESS in 20m 56s","accounts_in_message":[],"_revision_number":2},{"id":"75f3653d563ec92be5d3deeeae3ed031726b6f2c","author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"date":"2016-09-22 14:04:53.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"ca424e4d530203ed9c973f9c44eb2827d9eb68a8","author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"date":"2016-09-22 15:06:10.000000000","message":"Patch Set 2: Code-Review+2\n\nI disagree with the way the bug is worded because MagicMock has valid use cases. However, it is obvious from this change that neutronclient does not need to use MagicMock.","accounts_in_message":[],"_revision_number":2},{"id":"95e740c25ad0e4b98f2e8490834827f775ff295e","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-09-22 15:38:34.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"01e2c71c2841d9a2258a926de93dea1d3d0ef3b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-22 15:38:45.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"55c856b3e77fa1e19debe334ef95d05ed586a997","date":"2016-09-22 16:33:39.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"bfa1084d2fb2264adf33bf352ec45ea9c81abbec","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-22 16:33:39.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/20/373620/2/gate/gate-python-neutronclient-docs-ubuntu-xenial/1b34790//doc/build/html/ : SUCCESS in 3m 52s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/20/373620/2/gate/gate-python-neutronclient-pep8-ubuntu-xenial/496bf23/ : SUCCESS in 3m 50s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/20/373620/2/gate/gate-python-neutronclient-python27-ubuntu-xenial/54a8998/ : SUCCESS in 3m 50s\n- gate-python-neutronclient-python34 http://logs.openstack.org/20/373620/2/gate/gate-python-neutronclient-python34/9c95f08/ : SUCCESS in 4m 08s\n- gate-python-neutronclient-python35 http://logs.openstack.org/20/373620/2/gate/gate-python-neutronclient-python35/d04c335/ : SUCCESS in 4m 18s\n- gate-tempest-dsvm-neutron-src-python-neutronclient http://logs.openstack.org/20/373620/2/gate/gate-tempest-dsvm-neutron-src-python-neutronclient/c2bce34/ : SUCCESS in 49m 00s\n- gate-neutronclient-test-dsvm-functional http://logs.openstack.org/20/373620/2/gate/gate-neutronclient-test-dsvm-functional/9b57f7f/ : SUCCESS in 22m 35s\n- gate-neutronclient-test-dsvm-functional-adv-svcs http://logs.openstack.org/20/373620/2/gate/gate-neutronclient-test-dsvm-functional-adv-svcs/317e0c8/ : SUCCESS in 22m 44s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"291b31e0e5eed01cbbe917a644e38c2cedafae3e","revisions":{"1580e6421503d473f0363d3e50ddf7517163354c":{"kind":"REWORK","_number":1,"created":"2016-09-21 03:33:04.000000000","uploader":{"_account_id":22574,"name":"lilintan","email":"lintan.li@easystack.cn","username":"lilintan"},"ref":"refs/changes/20/373620/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/20/373620/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/20/373620/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/20/373620/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/20/373620/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/20/373620/1"}}},"commit":{"parents":[{"commit":"3c2925a4de8f79edd2135a2e0d99082230583e32","subject":"Merge \"Simplify clearing session-persistence\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/3c2925a4de8f79edd2135a2e0d99082230583e32"}]}],"author":{"name":"lilintan","email":"lintan.li@easystack.cn","date":"2016-09-21 03:27:06.000000000","tz":480},"committer":{"name":"lilintan","email":"lintan.li@easystack.cn","date":"2016-09-21 03:27:06.000000000","tz":480},"subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","message":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027\n\nChange-Id: I3f14a7932de5ce1586a9900d5d9801d1fe54c71c\nCloses-Bug: #1475722\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/1580e6421503d473f0363d3e50ddf7517163354c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/1580e6421503d473f0363d3e50ddf7517163354c"}]},"branch":"refs/heads/master"},"291b31e0e5eed01cbbe917a644e38c2cedafae3e":{"kind":"REWORK","_number":2,"created":"2016-09-22 10:49:50.000000000","uploader":{"_account_id":22574,"name":"lilintan","email":"lintan.li@easystack.cn","username":"lilintan"},"ref":"refs/changes/20/373620/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/20/373620/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/20/373620/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/20/373620/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/20/373620/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/20/373620/2"}}},"commit":{"parents":[{"commit":"791e6c984e67c3c9b06ca43250b5816a527583e2","subject":"Merge \"Handle keystoneauth exceptions in retry logic\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/791e6c984e67c3c9b06ca43250b5816a527583e2"}]}],"author":{"name":"lilintan","email":"lintan.li@easystack.cn","date":"2016-09-22 10:48:57.000000000","tz":480},"committer":{"name":"lilintan","email":"lintan.li@easystack.cn","date":"2016-09-22 10:48:57.000000000","tz":480},"subject":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027","message":"Replace \u0027MagicMock\u0027 with \u0027Mock\u0027\n\nChange-Id: I3f14a7932de5ce1586a9900d5d9801d1fe54c71c\nCloses-Bug: #1475722\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/291b31e0e5eed01cbbe917a644e38c2cedafae3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/291b31e0e5eed01cbbe917a644e38c2cedafae3e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}