)]}'
{"neutronclient/neutron/v2_0/agentscheduler.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"dfd3a0ffcdf21d74ce8533225b9c86e322000ef2","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    resource \u003d \u0027agent\u0027"},{"line_number":267,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.GetLbaasAgentHostingPool\u0027)"},{"line_number":268,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027host\u0027, \u0027admin_state_up\u0027, \u0027alive\u0027, \u0027default\u0027]"},{"line_number":269,"context_line":"    unknown_parts_flag \u003d False"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FnIY%3D","line":268,"updated":"2013-07-26 15:17:20.000000000","message":"what is the \u0027default\u0027 coming from?","commit_id":"b45b42330ff256cae7d44483c06b3622970d0253"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"60b1fc0ea622af1ffd5cad7ebca2247b9e58efd4","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    resource \u003d \u0027agent\u0027"},{"line_number":267,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.GetLbaasAgentHostingPool\u0027)"},{"line_number":268,"context_line":"    list_columns \u003d [\u0027id\u0027, \u0027host\u0027, \u0027admin_state_up\u0027, \u0027alive\u0027, \u0027default\u0027]"},{"line_number":269,"context_line":"    unknown_parts_flag \u003d False"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FnH0%3D","line":268,"in_reply_to":"AAAAQn%2F%2FnIY%3D","updated":"2013-07-26 15:18:54.000000000","message":"it\u0027s me copy-paste fool :) it has come from ListL3AgentsHostingRouter. will remove","commit_id":"b45b42330ff256cae7d44483c06b3622970d0253"}],"neutronclient/shell.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"15b6891ecf36146a04dcc2a24e7acfd003b3c23e","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    \u0027l3-agent-router-remove\u0027: agentscheduler.RemoveRouterFromL3Agent,"},{"line_number":178,"context_line":"    \u0027router-list-on-l3-agent\u0027: agentscheduler.ListRoutersOnL3Agent,"},{"line_number":179,"context_line":"    \u0027l3-agent-list-hosting-router\u0027: agentscheduler.ListL3AgentsHostingRouter,"},{"line_number":180,"context_line":"    \u0027pool-list-on-lb-agent\u0027: agentscheduler.ListPoolsOnLbaasAgent,"},{"line_number":181,"context_line":"    \u0027lb-agent-hosting-pool\u0027: agentscheduler.GetLbaasAgentHostingPool,"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F4%2F0%3D","line":180,"updated":"2013-07-19 18:07:21.000000000","message":"IMO, all other lbaas subcommands have \"lb-\" prefix. It is easier to understand if it has \"lb-\"\u0027 prefix:\n\"lb-pool-list-on-agent\" or \"lb-pool-list-on-lb-agent\". The latter has two \"lb\" and it may be too verbose :-)","commit_id":"472652b00c16ca0bdd119f6b167acbee30d59a25"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b1bd21e90c26c1913fe0103220e383e43380606c","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    \u0027l3-agent-router-remove\u0027: agentscheduler.RemoveRouterFromL3Agent,"},{"line_number":178,"context_line":"    \u0027router-list-on-l3-agent\u0027: agentscheduler.ListRoutersOnL3Agent,"},{"line_number":179,"context_line":"    \u0027l3-agent-list-hosting-router\u0027: agentscheduler.ListL3AgentsHostingRouter,"},{"line_number":180,"context_line":"    \u0027pool-list-on-lb-agent\u0027: agentscheduler.ListPoolsOnLbaasAgent,"},{"line_number":181,"context_line":"    \u0027lb-agent-hosting-pool\u0027: agentscheduler.GetLbaasAgentHostingPool,"},{"line_number":182,"context_line":"}"},{"line_number":183,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2F2CM%3D","line":180,"in_reply_to":"AAAAQn%2F%2F4%2F0%3D","updated":"2013-07-22 08:54:30.000000000","message":"Agree, will rename to lb-pool-list-on-agent","commit_id":"472652b00c16ca0bdd119f6b167acbee30d59a25"}],"tests/unit/test_cli20_agenschedulers.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bfe771e6b60d203c3cb58dc8a347f70c954ca790","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # url method body"},{"line_number":45,"context_line":"        query \u003d \"\""},{"line_number":46,"context_line":"        agent_id \u003d \u0027agent_id1\u0027"},{"line_number":47,"context_line":"        args \u003d [agent_id]"},{"line_number":48,"context_line":"        args.extend([\u0027--request-format\u0027, self.format])"},{"line_number":49,"context_line":"        path \u003d ((self.client.agent_path + self.client.LOADBALANCER_POOLS) %"},{"line_number":50,"context_line":"                agent_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FjHw%3D","line":47,"updated":"2013-07-29 13:40:37.000000000","message":"The differences from test_cli20._test_list_resources are L.47 and L.49-50. How about adding new parameters (base_args, path) to _test_list_resources?\n\ndef _test_list_resources(....., base_args\u003dNone, path\u003dNone, ....):\n    ...\n    args \u003d base_args if base_args is not None else []\n    if detail:\n         args.append(\u0027-D\u0027)\n    ...\n    if path is None:\n        path \u003d getattr(self.client, resources + \"_path\")\n\nIf so, we can write here:\n\n  self._test_list_resources(self.resources, cmd,\n      base_args\u003d[agent_id],\n      path\u003d\u003cL.49-50\u003e)","commit_id":"19e92c8716249967591db1c191a15f368e0d11a1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c647a05b7656ffb17da39c11ecd25cff9f40b2b6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        # url method body"},{"line_number":45,"context_line":"        query \u003d \"\""},{"line_number":46,"context_line":"        agent_id \u003d \u0027agent_id1\u0027"},{"line_number":47,"context_line":"        args \u003d [agent_id]"},{"line_number":48,"context_line":"        args.extend([\u0027--request-format\u0027, self.format])"},{"line_number":49,"context_line":"        path \u003d ((self.client.agent_path + self.client.LOADBALANCER_POOLS) %"},{"line_number":50,"context_line":"                agent_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2Fi8E%3D","line":47,"in_reply_to":"AAAAQn%2F%2FjHw%3D","updated":"2013-07-29 14:11:29.000000000","message":"yeah, makes sence, thanks for details!","commit_id":"19e92c8716249967591db1c191a15f368e0d11a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"bfe771e6b60d203c3cb58dc8a347f70c954ca790","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        args \u003d [pool_id]"},{"line_number":84,"context_line":"        args.extend([\u0027--request-format\u0027, self.format])"},{"line_number":85,"context_line":"        path \u003d ((self.client.pool_path + self.client.LOADBALANCER_AGENT) %"},{"line_number":86,"context_line":"                pool_id)"},{"line_number":87,"context_line":"        self.client.httpclient.request("},{"line_number":88,"context_line":"            test_cli20.MyUrlComparator(test_cli20.end_url(path, query,"},{"line_number":89,"context_line":"                                                          format\u003dself.format),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2FjG0%3D","line":86,"updated":"2013-07-29 13:40:37.000000000","message":"The same thing applies to here.","commit_id":"19e92c8716249967591db1c191a15f368e0d11a1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"c647a05b7656ffb17da39c11ecd25cff9f40b2b6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        args \u003d [pool_id]"},{"line_number":84,"context_line":"        args.extend([\u0027--request-format\u0027, self.format])"},{"line_number":85,"context_line":"        path \u003d ((self.client.pool_path + self.client.LOADBALANCER_AGENT) %"},{"line_number":86,"context_line":"                pool_id)"},{"line_number":87,"context_line":"        self.client.httpclient.request("},{"line_number":88,"context_line":"            test_cli20.MyUrlComparator(test_cli20.end_url(path, query,"},{"line_number":89,"context_line":"                                                          format\u003dself.format),"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQn%2F%2Fi8A%3D","line":86,"in_reply_to":"AAAAQn%2F%2FjG0%3D","updated":"2013-07-29 14:11:29.000000000","message":"Done","commit_id":"19e92c8716249967591db1c191a15f368e0d11a1"}]}