)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"33f91880b6b659f1af6f7b60dd13dffd0058546e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mohankumar \u003cnmohankumar1011@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-12-12 17:46:22 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add SFC cli for OSC plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Pending Items:"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a6eadb0_56e8c97c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":3},"updated":"2016-12-13 10:31:19.000000000","message":"Request to tag it as [WIP] until unit tests are ready.","commit_id":"8621144f22b4406ff3088e000fd915a749222cdb"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"34123187ed4378278e0f271d4275d38c8f3d81d7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint openstackclient-cli-porting"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I241521299b8b73b8fa2f48c4498409524b715442"},{"line_number":12,"context_line":"Change-Id: Ifeb62bad26ffeb0bb8b548c56d2d6a620a922f78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"df140735_092a5e8f","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"updated":"2017-06-07 10:06:57.000000000","message":"Maybe you missed something here.\nThis patch need to be merged first. And then the document patch.\nI mean this patch is depended by the other one. So, just remove this line.","commit_id":"2f732dcadda100a8600e163679fd209ed4719cb7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"302e986f664350d6cfe0d85bdc971cf28d0d3e9e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint openstackclient-cli-porting"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Depends-On: I241521299b8b73b8fa2f48c4498409524b715442"},{"line_number":12,"context_line":"Change-Id: Ifeb62bad26ffeb0bb8b548c56d2d6a620a922f78"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":37,"id":"df140735_a420399d","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":53},"in_reply_to":"df140735_092a5e8f","updated":"2017-06-07 10:08:03.000000000","message":"okay :)","commit_id":"2f732dcadda100a8600e163679fd209ed4719cb7"}],"doc/source/cli/osc/v2/networking-sfc.rst":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"9829100e2530be05f614a94bf95c1eb5d1513249","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. autoprogram-cliff:: openstack.neutronclient.v2"},{"line_number":15,"context_line":"   :command: sfc flow classifier *"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".. autoprogram-cliff:: openstack.neutronclient.v2"},{"line_number":18,"context_line":"   :command: sfc port chain *"}],"source_content_type":"text/x-rst","patch_set":43,"id":"1f1a1f67_f05cd04b","line":15,"range":{"start_line":15,"start_character":33,"end_line":15,"end_character":34},"updated":"2017-07-19 19:27:08.000000000","message":"sfc flow classifier does not have a unset command","commit_id":"e1c98e1b7ad35c1846f0af18d3e9c72ab11eab3e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e827374abf2b92c57f91b81ccd67d56b76093dfc","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. autoprogram-cliff:: openstack.neutronclient.v2"},{"line_number":15,"context_line":"   :command: sfc flow classifier *"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".. autoprogram-cliff:: openstack.neutronclient.v2"},{"line_number":18,"context_line":"   :command: sfc port chain *"}],"source_content_type":"text/x-rst","patch_set":43,"id":"ff346bd7_c29d4e5a","line":15,"range":{"start_line":15,"start_character":33,"end_line":15,"end_character":34},"in_reply_to":"1f1a1f67_2b463f23","updated":"2017-07-24 09:35:44.000000000","message":"unset command for flow classifier is unnecessary. I believe it is fine and this is what we do in OSC side as well.","commit_id":"e1c98e1b7ad35c1846f0af18d3e9c72ab11eab3e"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b0cdba673bf35eccd49c0ce0eb6db4d7345458e8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":".. autoprogram-cliff:: openstack.neutronclient.v2"},{"line_number":15,"context_line":"   :command: sfc flow classifier *"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":".. autoprogram-cliff:: openstack.neutronclient.v2"},{"line_number":18,"context_line":"   :command: sfc port chain *"}],"source_content_type":"text/x-rst","patch_set":43,"id":"1f1a1f67_2b463f23","line":15,"range":{"start_line":15,"start_character":33,"end_line":15,"end_character":34},"in_reply_to":"1f1a1f67_f05cd04b","updated":"2017-07-20 13:45:28.000000000","message":"For flow classifier, we don\u0027t require unset command as we only can set name and description. Same applicable for sfc port pair commands as well, Since \"sfc port pair *\" will also match \"sfc port pair group ...\" I haven\u0027t used \"sfc port pair *\"","commit_id":"e1c98e1b7ad35c1846f0af18d3e9c72ab11eab3e"}],"doc/source/usage/osc/v2/networking-sfc.rst":[{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Neutron Networking SFC"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_bb8a2662","line":1,"updated":"2016-12-16 16:50:46.000000000","message":"I think the commands should be \n\"os network sfc ....\"\n\nAlso think it would be good to split out sft port pair, sfc chain, and sfc flow into seperate rsts since they are different base commands.","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"2822f235c87463d2b877e7962686b2c8bf39d889","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Neutron Networking SFC"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_5d0c463b","line":1,"in_reply_to":"1a6eadb0_bb8a2662","updated":"2016-12-20 06:14:28.000000000","message":"+1 for keeping all the commands in the same file. IMO, it\u0027s better to have all the related commands in one file.","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"ee354d195ee669a41f1a9fd67376c702cf4f493f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Neutron Networking SFC"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_f906f883","line":1,"in_reply_to":"1a6eadb0_bb8a2662","updated":"2016-12-20 11:26:39.000000000","message":"Will change to os \n\nIMO  keeping all the commands same file for easy reference.","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"OpenStack Networking SFC CLIs"},{"line_number":47,"context_line":"-----------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"sfc port pair create"},{"line_number":50,"context_line":"--------------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Create a Port Pair"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_5b6bd2b6","line":49,"updated":"2016-12-16 16:50:46.000000000","message":"slightly off. \nPlease use the formatting similar to \n\nhttps://raw.githubusercontent.com/openstack/python-neutronclient/master/doc/source/usage/osc/v2/network-trunk.rst","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"ee354d195ee669a41f1a9fd67376c702cf4f493f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"OpenStack Networking SFC CLIs"},{"line_number":47,"context_line":"-----------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"sfc port pair create"},{"line_number":50,"context_line":"--------------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Create a Port Pair"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_4c13ac5c","line":49,"in_reply_to":"1a6eadb0_5b6bd2b6","updated":"2016-12-20 11:26:39.000000000","message":"Ankur, why it needs to be in the same format. I tried that style but somehow I couldn\u0027t get. \n\nPlease refer HTML file @ http://docs-draft.openstack.org/59/409759/6/check/gate-python-neutronclient-docs-ubuntu-xenial/43c59cf//doc/build/html/usage/osc/v2/networking-sfc.html\n\nand let me know it\u0027s not advised to be this format?","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    openstack sfc port pair create"},{"line_number":57,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":58,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":59,"context_line":"       --egress \u003cegress\u003e"},{"line_number":60,"context_line":"       [--service-function-parameters \u003c[correlation\u003dCORRELATION_TYPE, weight\u003dWEIGHT]\u003e]"},{"line_number":61,"context_line":"       \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_f81d8473","line":58,"updated":"2016-12-16 16:50:46.000000000","message":"[--ingress \u003cingress\u003e | --egress \u003cegress\u003e]\nneed to make these two a mutually exclusive pair (so user cannot specify both options)","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"ee354d195ee669a41f1a9fd67376c702cf4f493f","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    openstack sfc port pair create"},{"line_number":57,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":58,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":59,"context_line":"       --egress \u003cegress\u003e"},{"line_number":60,"context_line":"       [--service-function-parameters \u003c[correlation\u003dCORRELATION_TYPE, weight\u003dWEIGHT]\u003e]"},{"line_number":61,"context_line":"       \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_4c3accce","line":58,"in_reply_to":"1a6eadb0_1d772ea0","updated":"2016-12-20 11:26:39.000000000","message":"vikram: +1","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"2822f235c87463d2b877e7962686b2c8bf39d889","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    openstack sfc port pair create"},{"line_number":57,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":58,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":59,"context_line":"       --egress \u003cegress\u003e"},{"line_number":60,"context_line":"       [--service-function-parameters \u003c[correlation\u003dCORRELATION_TYPE, weight\u003dWEIGHT]\u003e]"},{"line_number":61,"context_line":"       \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_1d772ea0","line":58,"in_reply_to":"1a6eadb0_f81d8473","updated":"2016-12-20 06:14:28.000000000","message":"User can specify both the option.","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":58,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":59,"context_line":"       --egress \u003cegress\u003e"},{"line_number":60,"context_line":"       [--service-function-parameters \u003c[correlation\u003dCORRELATION_TYPE, weight\u003dWEIGHT]\u003e]"},{"line_number":61,"context_line":"       \u003cname\u003e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"sfc port pair delete"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_780a5427","line":60,"updated":"2016-12-16 16:50:46.000000000","message":"metavars should be lower case","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"05f16a0f507d68d8873e78f1f1805b50d3ad1b88","unresolved":false,"context_lines":[{"line_number":57,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":58,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":59,"context_line":"       --egress \u003cegress\u003e"},{"line_number":60,"context_line":"       [--service-function-parameters \u003c[correlation\u003dCORRELATION_TYPE, weight\u003dWEIGHT]\u003e]"},{"line_number":61,"context_line":"       \u003cname\u003e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"sfc port pair delete"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_f29d810b","line":60,"in_reply_to":"1a6eadb0_780a5427","updated":"2016-12-18 19:50:33.000000000","message":"Upper case in neutron cli reference: http://docs.openstack.org/cli-reference/neutron.html","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"ee354d195ee669a41f1a9fd67376c702cf4f493f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":58,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":59,"context_line":"       --egress \u003cegress\u003e"},{"line_number":60,"context_line":"       [--service-function-parameters \u003c[correlation\u003dCORRELATION_TYPE, weight\u003dWEIGHT]\u003e]"},{"line_number":61,"context_line":"       \u003cname\u003e"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"sfc port pair delete"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_8ce7843f","line":60,"in_reply_to":"1a6eadb0_f29d810b","updated":"2016-12-20 11:26:39.000000000","message":"Louis: +1 , OpenStack clis having matavar in uppercase","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":87,"context_line":".. code-block:: ini"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    openstack sfc port pair show"},{"line_number":90,"context_line":"       \u003cport_pair\u003e"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"sfc port pair update"},{"line_number":93,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_5be03229","line":90,"updated":"2016-12-16 16:50:46.000000000","message":"\u003cport-pair\u003e","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"ee354d195ee669a41f1a9fd67376c702cf4f493f","unresolved":false,"context_lines":[{"line_number":87,"context_line":".. code-block:: ini"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    openstack sfc port pair show"},{"line_number":90,"context_line":"       \u003cport_pair\u003e"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"sfc port pair update"},{"line_number":93,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_2c44b019","line":90,"in_reply_to":"1a6eadb0_5be03229","updated":"2016-12-20 11:26:39.000000000","message":"will correct","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    openstack sfc port pair show"},{"line_number":90,"context_line":"       \u003cport_pair\u003e"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"sfc port pair update"},{"line_number":93,"context_line":"--------------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Update Port Pair\u0027s information"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_3bcc56ba","line":92,"updated":"2016-12-16 16:50:46.000000000","message":"OSC uses \"set\" instead of \"update\"","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"ee354d195ee669a41f1a9fd67376c702cf4f493f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    openstack sfc port pair show"},{"line_number":90,"context_line":"       \u003cport_pair\u003e"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"sfc port pair update"},{"line_number":93,"context_line":"--------------------"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"Update Port Pair\u0027s information"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_ec8ab819","line":92,"in_reply_to":"1a6eadb0_3bcc56ba","updated":"2016-12-20 11:26:39.000000000","message":"will change","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    openstack sfc port pair group create"},{"line_number":112,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":113,"context_line":"       [--port-pair \u003cport-pair\u003e]"},{"line_number":114,"context_line":"       [--port-pair-group-parameters \u003c[lb_fields\u003dLB_FIELDS]\u003e]"},{"line_number":115,"context_line":"       \u003cname\u003e"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"sfc port pair group delete"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_bbb86612","line":114,"updated":"2016-12-16 16:50:46.000000000","message":"Lowercase metavar","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"05f16a0f507d68d8873e78f1f1805b50d3ad1b88","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    openstack sfc port pair group create"},{"line_number":112,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":113,"context_line":"       [--port-pair \u003cport-pair\u003e]"},{"line_number":114,"context_line":"       [--port-pair-group-parameters \u003c[lb_fields\u003dLB_FIELDS]\u003e]"},{"line_number":115,"context_line":"       \u003cname\u003e"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"sfc port pair group delete"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_528555ab","line":114,"in_reply_to":"1a6eadb0_bbb86612","updated":"2016-12-18 19:50:33.000000000","message":"upper-case in neutron cli reference: http://docs.openstack.org/cli-reference/neutron.html","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":122,"context_line":".. code-block:: ini"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    openstack sfc port pair group delete"},{"line_number":125,"context_line":"       \u003cport-pair-group\u003e"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"sfc port pair group list"},{"line_number":128,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_5b4e723b","line":125,"updated":"2016-12-16 16:50:46.000000000","message":"Should also be able to take in multiple port-pair-groups","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"ee354d195ee669a41f1a9fd67376c702cf4f493f","unresolved":false,"context_lines":[{"line_number":122,"context_line":".. code-block:: ini"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    openstack sfc port pair group delete"},{"line_number":125,"context_line":"       \u003cport-pair-group\u003e"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"sfc port pair group list"},{"line_number":128,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_acd600ef","line":125,"in_reply_to":"1a6eadb0_5b4e723b","updated":"2016-12-20 11:26:39.000000000","message":"NO","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"20f51a4fe56ba27434d7676280bef6bc16280e35","unresolved":false,"context_lines":[{"line_number":122,"context_line":".. code-block:: ini"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    openstack sfc port pair group delete"},{"line_number":125,"context_line":"       \u003cport-pair-group\u003e"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"sfc port pair group list"},{"line_number":128,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":6,"id":"da4df55a_6488bd23","line":125,"in_reply_to":"1a6eadb0_acd600ef","updated":"2016-12-22 20:36:11.000000000","message":"Does not support multiple port-pair-groups","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"059cc28b471dcc4b996784f3fec68fc26e85d5cb","unresolved":false,"context_lines":[{"line_number":164,"context_line":".. code-block:: ini"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    openstack sfc port chain create"},{"line_number":167,"context_line":"       [--chain-parameters \u003c[correlation\u003dCORRELATION_TYPE, symmetric\u003dBOOLEAN_TYPE]\u003e]"},{"line_number":168,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":169,"context_line":"       [--flow-classifier \u003cflow-classifier\u003e]"},{"line_number":170,"context_line":"       [--port-pair-group \u003cport-pair-group\u003e]"}],"source_content_type":"text/x-rst","patch_set":6,"id":"1a6eadb0_db60c2a7","line":167,"updated":"2016-12-16 16:50:46.000000000","message":"ditto","commit_id":"1ae7ba7f6e4961b5ce1e1b825ffaa19e6298b0e0"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"f0564056fe6cb1cf1e0de72281dc7b8102dd9bcb","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. code-block:: ini"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    os sfc port pair create"},{"line_number":57,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":58,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":59,"context_line":"       --egress \u003cegress\u003e"}],"source_content_type":"text/x-rst","patch_set":8,"id":"da4df55a_24ab151f","line":56,"updated":"2016-12-22 20:51:25.000000000","message":"for each option write out what the option means.\n\nShould match the text found for all the help\u003d_(\"\u003cblurb\u003e\") in the python files implementing the commands.","commit_id":"506938b38774cfe58a15aec6e579e443bd987ccb"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"5ecb8c27a621c328699d72f890627803590b2b21","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Description for the Port Pair"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. option:: --ingress \u003cingress\u003e"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba5201f7_ba92a749","line":65,"range":{"start_line":65,"start_character":29,"end_line":65,"end_character":33},"updated":"2017-01-03 17:56:29.000000000","message":"nit: add period at end and elsewhere.","commit_id":"5acf8c92421934886ee306aacb1aca68d55e5ca9"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"4c8621ecb5ad7b8fa3e80e9df552fa9df408ab35","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Description for the Port Pair"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. option:: --ingress \u003cingress\u003e"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba5201f7_47923b4d","line":65,"range":{"start_line":65,"start_character":29,"end_line":65,"end_character":33},"in_reply_to":"ba5201f7_0195c63d","updated":"2017-01-06 19:09:10.000000000","message":"ok","commit_id":"5acf8c92421934886ee306aacb1aca68d55e5ca9"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"69584f78076b1f0703c24593c1fea5cb2c5d0f5e","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":".. option:: --description \u003cdescription\u003e"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    Description for the Port Pair"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":".. option:: --ingress \u003cingress\u003e"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba5201f7_0195c63d","line":65,"range":{"start_line":65,"start_character":29,"end_line":65,"end_character":33},"in_reply_to":"ba5201f7_ba92a749","updated":"2017-01-06 06:44:30.000000000","message":"Louis, OpenStack client devref suggesting not to add period at end :)","commit_id":"5acf8c92421934886ee306aacb1aca68d55e5ca9"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"5ecb8c27a621c328699d72f890627803590b2b21","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. option:: --service-function-parameter \u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    Dictionary of Service function parameters.Currently, only correlation\u003dNone and weight"},{"line_number":78,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"},{"line_number":79,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":80,"context_line":"    The default weight is 1"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba5201f7_5af29bd3","line":77,"range":{"start_line":77,"start_character":46,"end_line":77,"end_character":55},"updated":"2017-01-03 17:56:29.000000000","message":"nit: space","commit_id":"5acf8c92421934886ee306aacb1aca68d55e5ca9"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"69584f78076b1f0703c24593c1fea5cb2c5d0f5e","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":".. option:: --service-function-parameter \u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    Dictionary of Service function parameters.Currently, only correlation\u003dNone and weight"},{"line_number":78,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"},{"line_number":79,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":80,"context_line":"    The default weight is 1"}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba5201f7_7e3281a8","line":77,"range":{"start_line":77,"start_character":46,"end_line":77,"end_character":55},"in_reply_to":"ba5201f7_5af29bd3","updated":"2017-01-06 06:44:30.000000000","message":"will add","commit_id":"5acf8c92421934886ee306aacb1aca68d55e5ca9"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"5ecb8c27a621c328699d72f890627803590b2b21","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    Dictionary of Service function parameters.Currently, only correlation\u003dNone and weight"},{"line_number":78,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"},{"line_number":79,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":80,"context_line":"    The default weight is 1"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":".. option:: \u003cname\u003e"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"ba5201f7_faaeef96","line":80,"range":{"start_line":80,"start_character":26,"end_line":80,"end_character":27},"updated":"2017-01-03 17:56:29.000000000","message":"nit: add period at end","commit_id":"5acf8c92421934886ee306aacb1aca68d55e5ca9"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"79342c1b6c3028381158cfc58bc42fd67af8c9da","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Flow classifiers are used to select the traffic that can access the chain. Traffic that matches any"},{"line_number":34,"context_line":"flow classifier will be directed to the first port in the chain. The flow classifier will a generic"},{"line_number":35,"context_line":"module and may be used by different projects like fw, QOS, etc."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The flow classifiers define the source and destination endpoints of the traffic that can enter a"},{"line_number":38,"context_line":"port chain."}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_a6bca9dc","line":35,"range":{"start_line":35,"start_character":50,"end_line":35,"end_character":52},"updated":"2017-01-09 07:31:57.000000000","message":"FW","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"384ba083177707943e69732714bbc686d3223bba","unresolved":false,"context_lines":[{"line_number":54,"context_line":".. program:: sfc port pair create"},{"line_number":55,"context_line":".. code:: bash"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    os sfc port pair create"},{"line_number":58,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":59,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":60,"context_line":"       --egress \u003cegress\u003e"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_6eb62ffa","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":6},"updated":"2017-01-07 06:26:12.000000000","message":"You should replace from \u0027os\u0027 to \u0027openstack\u0027 for all command examples.  Please refer following comment:\n\nhttps://review.openstack.org/#/c/380146/8/doc/source/usage/osc/v2/firewall-group.rst","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"f3143a2e9f6b523aafd2716cab136666bb6a8af0","unresolved":false,"context_lines":[{"line_number":54,"context_line":".. program:: sfc port pair create"},{"line_number":55,"context_line":".. code:: bash"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    os sfc port pair create"},{"line_number":58,"context_line":"       [--description \u003cdescription\u003e]"},{"line_number":59,"context_line":"       --ingress \u003cingress\u003e"},{"line_number":60,"context_line":"       --egress \u003cegress\u003e"}],"source_content_type":"text/x-rst","patch_set":11,"id":"ba5201f7_06b655f8","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":6},"in_reply_to":"ba5201f7_6eb62ffa","updated":"2017-01-09 06:22:09.000000000","message":"agree, will change. I followed Ankur comments \n\nhttps://review.openstack.org/#/c/409759/6/doc/source/usage/osc/v2/networking-sfc.rst (Line 1) \nAnkur\nDec 16 10:20 PM\nI think the commands should be \n\"os network sfc ....\"","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e882f8f605b66aa2a4c0e7b3ef089973d3489a0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Neutron Networking SFC"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"All Neutron network services and VMs are connected to a Neutron network via Neutron ports. This"},{"line_number":6,"context_line":"makes it possible to create a traffic steering model for service chaining that uses only Neutron"},{"line_number":7,"context_line":"ports. This traffic steering model has no notion of the actual services attached to these Neutron"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_19a64153","line":4,"updated":"2017-01-11 11:26:29.000000000","message":"I don\u0027t think we need a description of SFC itself. what we need is only CLI stuff. L.5-44 looks unnecessary. Instead some point to SFC introduction would be appreciated.","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Neutron Networking SFC"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"All Neutron network services and VMs are connected to a Neutron network via Neutron ports. This"},{"line_number":6,"context_line":"makes it possible to create a traffic steering model for service chaining that uses only Neutron"},{"line_number":7,"context_line":"ports. This traffic steering model has no notion of the actual services attached to these Neutron"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_1b1c5969","line":4,"in_reply_to":"ba5201f7_19a64153","updated":"2017-01-17 07:08:36.000000000","message":"sure, will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b11b4d1110286d173dac8d741de6aabf8360f788","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Flow classifiers are used to select the traffic that can access the chain. Traffic that matches any"},{"line_number":34,"context_line":"flow classifier will be directed to the first port in the chain. The flow classifier will a generic"},{"line_number":35,"context_line":"module and may be used by different projects like fw, QOS, etc."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The flow classifiers define the source and destination endpoints of the traffic that can enter a"},{"line_number":38,"context_line":"port chain."}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_041c2a12","line":35,"range":{"start_line":35,"start_character":54,"end_line":35,"end_character":57},"updated":"2017-01-11 01:25:00.000000000","message":"nit: QoS\n\nIn my understanding, QoS is \"Quality of Service\".","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Flow classifiers are used to select the traffic that can access the chain. Traffic that matches any"},{"line_number":34,"context_line":"flow classifier will be directed to the first port in the chain. The flow classifier will a generic"},{"line_number":35,"context_line":"module and may be used by different projects like fw, QOS, etc."},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"The flow classifiers define the source and destination endpoints of the traffic that can enter a"},{"line_number":38,"context_line":"port chain."}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_7b2d5d94","line":35,"range":{"start_line":35,"start_character":54,"end_line":35,"end_character":57},"in_reply_to":"ba5201f7_041c2a12","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b11b4d1110286d173dac8d741de6aabf8360f788","unresolved":false,"context_lines":[{"line_number":44,"context_line":"port chain."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"OpenStack Networking SFC CLIs"},{"line_number":47,"context_line":"-----------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"sfc port pair create"},{"line_number":50,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_24c92e79","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":29},"updated":"2017-01-11 01:25:00.000000000","message":"nit: Underline length should align with an above strings.  Please check all underlines.","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e882f8f605b66aa2a4c0e7b3ef089973d3489a0a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"port chain."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"OpenStack Networking SFC CLIs"},{"line_number":47,"context_line":"-----------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"sfc port pair create"},{"line_number":50,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_7f3badeb","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":29},"in_reply_to":"ba5201f7_24c92e79","updated":"2017-01-11 11:26:29.000000000","message":"Currently L.46 and L.49 are the same level. The section level of L.46 should be higher than the level of L.49.","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"port chain."},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"OpenStack Networking SFC CLIs"},{"line_number":47,"context_line":"-----------------------------"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"sfc port pair create"},{"line_number":50,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_fb394dd8","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":29},"in_reply_to":"ba5201f7_7f3badeb","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e882f8f605b66aa2a4c0e7b3ef089973d3489a0a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"sfc port pair create"},{"line_number":50,"context_line":"--------------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Create a Port Pair"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. program:: sfc port pair create"},{"line_number":55,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_ea77ddff","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":18},"updated":"2017-01-11 11:26:29.000000000","message":"I don\u0027t think we need to capitalize each word.\n\n  Create a port pair\n\nThis applies to all related stuffs.","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"sfc port pair create"},{"line_number":50,"context_line":"--------------------"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"Create a Port Pair"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":".. program:: sfc port pair create"},{"line_number":55,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_9b55a9fb","line":52,"range":{"start_line":52,"start_character":9,"end_line":52,"end_character":18},"in_reply_to":"ba5201f7_ea77ddff","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e882f8f605b66aa2a4c0e7b3ef089973d3489a0a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"sfc port pair set"},{"line_number":131,"context_line":"-----------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Update Port Pair\u0027s information"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. program:: sfc port pair set"},{"line_number":136,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_6ad12dcd","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":30},"updated":"2017-01-11 11:26:29.000000000","message":"-\u003e Set port pair properties","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":130,"context_line":"sfc port pair set"},{"line_number":131,"context_line":"-----------------"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"Update Port Pair\u0027s information"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":".. program:: sfc port pair set"},{"line_number":136,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_bb5a6528","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":30},"in_reply_to":"ba5201f7_6ad12dcd","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e882f8f605b66aa2a4c0e7b3ef089973d3489a0a","unresolved":false,"context_lines":[{"line_number":156,"context_line":"sfc port pair group create"},{"line_number":157,"context_line":"--------------------------"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Create a Port Pair Group"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":".. program:: sfc port pair group create"},{"line_number":162,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_cad699c2","line":159,"range":{"start_line":159,"start_character":9,"end_line":159,"end_character":24},"updated":"2017-01-11 11:26:29.000000000","message":"-\u003e port pair group","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"sfc port pair group create"},{"line_number":157,"context_line":"--------------------------"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"Create a Port Pair Group"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":".. program:: sfc port pair group create"},{"line_number":162,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_1b4a9955","line":159,"range":{"start_line":159,"start_character":9,"end_line":159,"end_character":24},"in_reply_to":"ba5201f7_cad699c2","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b11b4d1110286d173dac8d741de6aabf8360f788","unresolved":false,"context_lines":[{"line_number":194,"context_line":".. code:: bash"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    openstack sfc port pair group delete"},{"line_number":197,"context_line":"       \u003cport-pair-group\u003e"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":".. _sfc_port_pair_group_delete-port-pair-group:"},{"line_number":200,"context_line":".. describe:: \u003cport-pair-group\u003e"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_0478aa2a","line":197,"updated":"2017-01-11 01:25:00.000000000","message":"Can we specify multiple \u003cport-pair-group\u003e?  If so, you should change the description as follows:\n\nopenstack sfc port pair group delete\n    \u003cport-pair-group\u003e [\u003cport-pair-group\u003e ...]","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":194,"context_line":".. code:: bash"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    openstack sfc port pair group delete"},{"line_number":197,"context_line":"       \u003cport-pair-group\u003e"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":".. _sfc_port_pair_group_delete-port-pair-group:"},{"line_number":200,"context_line":".. describe:: \u003cport-pair-group\u003e"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_db157140","line":197,"in_reply_to":"ba5201f7_0478aa2a","updated":"2017-01-17 07:08:36.000000000","message":"No Yushiro , we can\u0027t specify like this","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b11b4d1110286d173dac8d741de6aabf8360f788","unresolved":false,"context_lines":[{"line_number":199,"context_line":".. _sfc_port_pair_group_delete-port-pair-group:"},{"line_number":200,"context_line":".. describe:: \u003cport-pair-group\u003e"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    ID or name of the Port Pair Group to delete"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"sfc port pair group list"},{"line_number":205,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_24a04e9f","line":202,"range":{"start_line":202,"start_character":4,"end_line":202,"end_character":47},"updated":"2017-01-11 01:25:00.000000000","message":"It\u0027s better to align \"(name of ID)\" with other description.","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":199,"context_line":".. _sfc_port_pair_group_delete-port-pair-group:"},{"line_number":200,"context_line":".. describe:: \u003cport-pair-group\u003e"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    ID or name of the Port Pair Group to delete"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"sfc port pair group list"},{"line_number":205,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"7a3c09a3_3b47554c","line":202,"range":{"start_line":202,"start_character":4,"end_line":202,"end_character":47},"in_reply_to":"ba5201f7_24a04e9f","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b11b4d1110286d173dac8d741de6aabf8360f788","unresolved":false,"context_lines":[{"line_number":297,"context_line":".. program:: sfc port chain delete"},{"line_number":298,"context_line":".. code:: bash"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"    openstack sfc port chain delete"},{"line_number":301,"context_line":"       \u003cport-chain\u003e"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":".. _sfc_port_chain_delete-port-chain:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_c49ce25f","line":300,"updated":"2017-01-11 01:25:00.000000000","message":"ditto #197","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b11b4d1110286d173dac8d741de6aabf8360f788","unresolved":false,"context_lines":[{"line_number":303,"context_line":".. _sfc_port_chain_delete-port-chain:"},{"line_number":304,"context_line":".. describe:: \u003cport-chain\u003e"},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"    ID or name of the Port Chain to delete"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"sfc port chain list"},{"line_number":309,"context_line":"-------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_049fca50","line":306,"updated":"2017-01-11 01:25:00.000000000","message":"ditto #202","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b11b4d1110286d173dac8d741de6aabf8360f788","unresolved":false,"context_lines":[{"line_number":448,"context_line":".. code:: bash"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    openstack sfc flow classifier delete"},{"line_number":451,"context_line":"       \u003cflow-classifier\u003e"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":".. _sfc_flow_classifier_delete-flow-classifier:"},{"line_number":454,"context_line":".. describe:: \u003cflow-classifier\u003e"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_24ae8e85","line":451,"updated":"2017-01-11 01:25:00.000000000","message":"ditto #197","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b11b4d1110286d173dac8d741de6aabf8360f788","unresolved":false,"context_lines":[{"line_number":453,"context_line":".. _sfc_flow_classifier_delete-flow-classifier:"},{"line_number":454,"context_line":".. describe:: \u003cflow-classifier\u003e"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"    ID or name of the Flow Classifier to delete"},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"sfc flow classifier list"},{"line_number":459,"context_line":"------------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"ba5201f7_64b6d6dd","line":456,"updated":"2017-01-11 01:25:00.000000000","message":"ditto #202","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"af686ce135fd6779282f5396a71a509e9ec77ba1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"},{"line_number":6,"context_line":"that is typical of IP networks.Service Function Chains consisting of an ordered"},{"line_number":7,"context_line":"sequence of Service Functions. SFs are virtual machines (or potentially physical devices) that perform a network"},{"line_number":8,"context_line":"function such as firewall, content cache, packet inspection, or any other function that requires processing of packets"},{"line_number":9,"context_line":"in a flow from point A to point B even though the SFs  are not literally betweenpoint A and B from a routing table"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5a3905b3_dcb0628e","line":6,"range":{"start_line":6,"start_character":31,"end_line":6,"end_character":38},"updated":"2017-01-19 23:34:43.000000000","message":"missing space in the beginning.","commit_id":"647dcc39087d74a793aa103c2c9091e96bfb9511"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"af686ce135fd6779282f5396a71a509e9ec77ba1","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"},{"line_number":6,"context_line":"that is typical of IP networks.Service Function Chains consisting of an ordered"},{"line_number":7,"context_line":"sequence of Service Functions. SFs are virtual machines (or potentially physical devices) that perform a network"},{"line_number":8,"context_line":"function such as firewall, content cache, packet inspection, or any other function that requires processing of packets"},{"line_number":9,"context_line":"in a flow from point A to point B even though the SFs  are not literally betweenpoint A and B from a routing table"},{"line_number":10,"context_line":"perspective."}],"source_content_type":"text/x-rst","patch_set":16,"id":"5a3905b3_7c684ef6","line":7,"range":{"start_line":7,"start_character":12,"end_line":7,"end_character":29},"updated":"2017-01-19 23:34:43.000000000","message":"Service Functions (SF) if you intend to abbreviate going forward.","commit_id":"647dcc39087d74a793aa103c2c9091e96bfb9511"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"af686ce135fd6779282f5396a71a509e9ec77ba1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"that is typical of IP networks.Service Function Chains consisting of an ordered"},{"line_number":7,"context_line":"sequence of Service Functions. SFs are virtual machines (or potentially physical devices) that perform a network"},{"line_number":8,"context_line":"function such as firewall, content cache, packet inspection, or any other function that requires processing of packets"},{"line_number":9,"context_line":"in a flow from point A to point B even though the SFs  are not literally betweenpoint A and B from a routing table"},{"line_number":10,"context_line":"perspective."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5a3905b3_3c7fa6ab","line":9,"range":{"start_line":9,"start_character":53,"end_line":9,"end_character":55},"updated":"2017-01-19 23:34:43.000000000","message":"extra space","commit_id":"647dcc39087d74a793aa103c2c9091e96bfb9511"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"af686ce135fd6779282f5396a71a509e9ec77ba1","unresolved":false,"context_lines":[{"line_number":6,"context_line":"that is typical of IP networks.Service Function Chains consisting of an ordered"},{"line_number":7,"context_line":"sequence of Service Functions. SFs are virtual machines (or potentially physical devices) that perform a network"},{"line_number":8,"context_line":"function such as firewall, content cache, packet inspection, or any other function that requires processing of packets"},{"line_number":9,"context_line":"in a flow from point A to point B even though the SFs  are not literally betweenpoint A and B from a routing table"},{"line_number":10,"context_line":"perspective."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":16,"id":"5a3905b3_7c4f6e92","line":9,"range":{"start_line":9,"start_character":73,"end_line":9,"end_character":85},"updated":"2017-01-19 23:34:43.000000000","message":"missing space","commit_id":"647dcc39087d74a793aa103c2c9091e96bfb9511"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"e1bce668cd184dd5487f107a2fc81bae2b0b8fc8","unresolved":false,"context_lines":[{"line_number":221,"context_line":".. _sfc_port_pair_group_set-port-pair-group:"},{"line_number":222,"context_line":".. describe:: \u003cport-pair-group\u003e"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    port pair group to modify (name or ID)"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"sfc port chain create"}],"source_content_type":"text/x-rst","patch_set":16,"id":"7a3c09a3_ebf04269","line":224,"range":{"start_line":224,"start_character":4,"end_line":224,"end_character":5},"updated":"2017-01-18 14:27:49.000000000","message":"Port pair group","commit_id":"647dcc39087d74a793aa103c2c9091e96bfb9511"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"d468d095702638497b4430d921d0a5781ae9c941","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Create a port pair"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. program:: sfc port pair create"},{"line_number":19,"context_line":".. code:: bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    openstack sfc port pair create"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_85022db3","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":26},"updated":"2017-01-24 22:03:03.000000000","message":"Did you intend to write \"port\" separate from \"pair\"? Or perhaps portpair/port-pair?","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"824c9f8ccfb74d858b32736ba73a54a3888a0dc7","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Create a port pair"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":".. program:: sfc port pair create"},{"line_number":19,"context_line":".. code:: bash"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    openstack sfc port pair create"}],"source_content_type":"text/x-rst","patch_set":17,"id":"5a3905b3_388192fc","line":18,"range":{"start_line":18,"start_character":17,"end_line":18,"end_character":26},"in_reply_to":"5a3905b3_85022db3","updated":"2017-01-25 06:02:33.000000000","message":"yes , no - in openstack commands \n\nCommand will like \"openstack sfc port pair create\"","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"5168e53f0842bc502758a89dc1bf672988343e20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Networking SFC"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_bac58f5c","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":14},"updated":"2017-02-19 11:16:00.000000000","message":"All other neutronclient entries are lower case atm: http://docs-draft.openstack.org/59/409759/23/check/gate-python-neutronclient-docs-ubuntu-xenial/c22877c//doc/build/html/ Consider changing this to \"networking-sfc\"?","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fef1a095332d973657431dd0701717a1b8e6a6b9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Networking SFC"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_e6e0c9fc","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":14},"in_reply_to":"da36d5c6_bac58f5c","updated":"2017-02-24 11:26:52.000000000","message":"agree","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"5168e53f0842bc502758a89dc1bf672988343e20","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"},{"line_number":6,"context_line":"that is typical of IP networks. Service Function Chains consisting of an ordered sequence of Service Functions (SFs)."},{"line_number":7,"context_line":"SFs are virtual machines (or potentially physical devices) that perform a network function such as firewall,"},{"line_number":8,"context_line":"content cache, packet inspection, or any other function that requires processing of packets in a flow from point A to"},{"line_number":9,"context_line":"point B even though the SFs are not literally between point A and B from a routing table perspective."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Network v2"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_fad70721","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":101},"updated":"2017-02-19 11:16:00.000000000","message":"Rest of the text seems to be aligned up to 100 chars.","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fef1a095332d973657431dd0701717a1b8e6a6b9","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"},{"line_number":6,"context_line":"that is typical of IP networks. Service Function Chains consisting of an ordered sequence of Service Functions (SFs)."},{"line_number":7,"context_line":"SFs are virtual machines (or potentially physical devices) that perform a network function such as firewall,"},{"line_number":8,"context_line":"content cache, packet inspection, or any other function that requires processing of packets in a flow from point A to"},{"line_number":9,"context_line":"point B even though the SFs are not literally between point A and B from a routing table perspective."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Network v2"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_46f0b5c9","line":9,"range":{"start_line":6,"start_character":0,"end_line":9,"end_character":101},"in_reply_to":"da36d5c6_fad70721","updated":"2017-02-24 11:26:52.000000000","message":"ok","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"fac86bea415a3a9a9cde08fd6e3eb8d671738c21","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Description for the port pair"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. option:: --ingress \u003cingress\u003e"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Ingress neutron port (name or ID)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_8c9a67c4","line":32,"updated":"2017-02-17 20:02:52.000000000","message":"should be --ingress-port \u003cport-id\u003e and --egress-port \u003cport-id\u003e\nIn my opinion.","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"aade691bede742a9f5003094a2d94c920cbc3d21","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Description for the port pair"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. option:: --ingress \u003cingress\u003e"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Ingress neutron port (name or ID)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_b4767b3c","line":32,"in_reply_to":"da36d5c6_8c9a67c4","updated":"2017-02-20 08:53:02.000000000","message":"IMO, let\u0027s not change this, as it will create backward compability issues.","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":11313,"name":"Louis Fourie","email":"fouriehl70@gmail.com","username":"lfourie"},"change_message_id":"1b5ac281488ca8125b374268842816cb936a2f76","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    Description for the port pair"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":".. option:: --ingress \u003cingress\u003e"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    Ingress neutron port (name or ID)"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_e2c49a93","line":32,"in_reply_to":"da36d5c6_b4767b3c","updated":"2017-02-20 21:59:51.000000000","message":"agree with Vikram","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"5168e53f0842bc502758a89dc1bf672988343e20","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    Egress neutron port (name or ID)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. option:: --service-function-parameter \u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    Dictionary of Service function parameters. Currently, only correlation\u003dNone and weight"},{"line_number":43,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_1addbb42","line":40,"range":{"start_line":40,"start_character":31,"end_line":40,"end_character":40},"updated":"2017-02-19 11:16:00.000000000","message":"parameters","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"aade691bede742a9f5003094a2d94c920cbc3d21","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    Egress neutron port (name or ID)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. option:: --service-function-parameter \u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    Dictionary of Service function parameters. Currently, only correlation\u003dNone and weight"},{"line_number":43,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_f4b553d0","line":40,"range":{"start_line":40,"start_character":31,"end_line":40,"end_character":40},"in_reply_to":"da36d5c6_1addbb42","updated":"2017-02-20 08:53:02.000000000","message":"+1","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fef1a095332d973657431dd0701717a1b8e6a6b9","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    Egress neutron port (name or ID)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":".. option:: --service-function-parameter \u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    Dictionary of Service function parameters. Currently, only correlation\u003dNone and weight"},{"line_number":43,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_86bc6ddd","line":40,"range":{"start_line":40,"start_character":31,"end_line":40,"end_character":40},"in_reply_to":"da36d5c6_f4b553d0","updated":"2017-02-24 11:26:52.000000000","message":"ok","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"5168e53f0842bc502758a89dc1bf672988343e20","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    Dictionary of Service function parameters. Currently, only correlation\u003dNone and weight"},{"line_number":43,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"},{"line_number":44,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":45,"context_line":"    The default weight is 1"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. _sfc_port_pair_create-name:"},{"line_number":48,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_5ae73312","line":45,"updated":"2017-02-19 11:16:00.000000000","message":".","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fef1a095332d973657431dd0701717a1b8e6a6b9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    Dictionary of Service function parameters. Currently, only correlation\u003dNone and weight"},{"line_number":43,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"},{"line_number":44,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":45,"context_line":"    The default weight is 1"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. _sfc_port_pair_create-name:"},{"line_number":48,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":23,"id":"da36d5c6_26ce6182","line":45,"in_reply_to":"da36d5c6_5ae73312","updated":"2017-02-24 11:26:52.000000000","message":"periods not allowed at end of description","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a7ab1a935900c24d8677ca0958546bfac2bf7bf9","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"},{"line_number":6,"context_line":"that is typical of IP networks. Service Function Chains consisting of an ordered sequence of"},{"line_number":7,"context_line":"ServiceFunctions (SFs). SFs are virtual machines (or potentially physical devices) that perform a"},{"line_number":8,"context_line":"network function such as firewall, content cache, packet inspection, or any other function that"},{"line_number":9,"context_line":"requires processing of packets in a flow from point A to point B even though the SFs are not"},{"line_number":10,"context_line":"literally between point A and B from a routing table perspective."}],"source_content_type":"text/x-rst","patch_set":25,"id":"da36d5c6_cdb5747e","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":16},"updated":"2017-02-24 14:29:33.000000000","message":"Service Functions","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2b94e995fbdf1f5b3fdc7f764b0ee956c0f851ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"},{"line_number":6,"context_line":"that is typical of IP networks. Service Function Chains consisting of an ordered sequence of"},{"line_number":7,"context_line":"ServiceFunctions (SFs). SFs are virtual machines (or potentially physical devices) that perform a"},{"line_number":8,"context_line":"network function such as firewall, content cache, packet inspection, or any other function that"},{"line_number":9,"context_line":"requires processing of packets in a flow from point A to point B even though the SFs are not"},{"line_number":10,"context_line":"literally between point A and B from a routing table perspective."}],"source_content_type":"text/x-rst","patch_set":25,"id":"da36d5c6_a301ff06","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":16},"in_reply_to":"da36d5c6_cdb5747e","updated":"2017-02-27 15:01:07.000000000","message":"yes :)","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"04af7b918c0849d21ceed8afbc9e67647a37749a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"networking sfc"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"}],"source_content_type":"text/x-rst","patch_set":26,"id":"da36d5c6_0bb494cf","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":14},"updated":"2017-02-27 17:37:08.000000000","message":"Inconsistent with releasenotes/notes/add-sfc-commands.yaml","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"82392762fb68c16576f453cb4b73ab9aa4ebb2ae","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"networking sfc"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a1ced50_d70c9a96","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":14},"in_reply_to":"1a1ced50_a331a80d","updated":"2017-03-20 10:50:52.000000000","message":"FWaaS seems to be split per resource, so not a direct comparison, but no problem I had already +1d this.","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"6c6c42e10367602a0c796ed3cae66ddc817268d5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"networking sfc"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a1ced50_a331a80d","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":14},"in_reply_to":"da36d5c6_0bb494cf","updated":"2017-03-20 09:26:07.000000000","message":"Igor , don\u0027t think it should exactly match. \n\nhttps://github.com/openstack/python-neutronclient/blob/master/releasenotes/notes/support-fwaasv2-cli-7f21676c551f8ae0.yaml#L3\n\n\nhttps://github.com/openstack/python-neutronclient/blob/master/doc/source/usage/osc/v2/firewall-group.rst","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"93786da90b4a36b173d938b56addf39ab1373262","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":46,"context_line":"    The default weight is 1"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. _sfc_port_pair_create-name:"},{"line_number":49,"context_line":".. describe:: \u003cname\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    Name of the port pair"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba2be162_a85e3077","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":30},"updated":"2017-03-06 20:10:34.000000000","message":"The location of this sphinx reference looks odd. It should be moved before L14 (i.e before the command is described). Same is applicable for all the other commands.","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"5e6cf226514b0294b5d244d8773ce1a27c83a8da","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":46,"context_line":"    The default weight is 1"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. _sfc_port_pair_create-name:"},{"line_number":49,"context_line":".. describe:: \u003cname\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    Name of the port pair"}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a1ced50_113ba2d2","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":30},"in_reply_to":"1a1ced50_46c0027d","updated":"2017-03-20 09:39:14.000000000","message":"http://docs-draft.openstack.org/59/409759/26/check/gate-python-neutronclient-docs-ubuntu-xenial/9649e07//doc/build/html/usage/osc/v2/firewall-policy.html","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"6c6c42e10367602a0c796ed3cae66ddc817268d5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":46,"context_line":"    The default weight is 1"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. _sfc_port_pair_create-name:"},{"line_number":49,"context_line":".. describe:: \u003cname\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    Name of the port pair"}],"source_content_type":"text/x-rst","patch_set":26,"id":"1a1ced50_46c0027d","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":30},"in_reply_to":"ba2be162_a85e3077","updated":"2017-03-20 09:26:07.000000000","message":"HI Anindita, same style followed  in other documentation as well, The command description in L21. Please correct me if I misunderstood\n\nhttps://github.com/openstack/python-neutronclient/blob/master/doc/source/usage/osc/v2/firewall-group.rst","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"93786da90b4a36b173d938b56addf39ab1373262","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    openstack sfc port pair delete"},{"line_number":62,"context_line":"        \u003cport-pair\u003e"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":".. _sfc_port_pair_delete-port-pair:"},{"line_number":65,"context_line":".. describe:: \u003cport-pair\u003e"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Port pair to delete (name or ID)"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba2be162_e858288d","line":64,"range":{"start_line":64,"start_character":0,"end_line":64,"end_character":35},"updated":"2017-03-06 20:10:34.000000000","message":"ditto","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"93786da90b4a36b173d938b56addf39ab1373262","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    openstack sfc port pair show"},{"line_number":89,"context_line":"        \u003cport-pair\u003e"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":".. _sfc_port_pair_show-port-pair:"},{"line_number":92,"context_line":".. describe:: \u003cport-pair\u003e"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    Port pair to display (name or ID)"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba2be162_2853206e","line":91,"range":{"start_line":91,"start_character":0,"end_line":91,"end_character":33},"updated":"2017-03-06 20:10:34.000000000","message":"ditto","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"93786da90b4a36b173d938b56addf39ab1373262","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    Description for the port pair"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":".. _sfc_port_pair_set-port-pair:"},{"line_number":118,"context_line":".. describe:: \u003cport-pair\u003e"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    Port pair to modify (name or ID)"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba2be162_4850545f","line":117,"range":{"start_line":117,"start_character":0,"end_line":117,"end_character":32},"updated":"2017-03-06 20:10:34.000000000","message":"ditto","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"93786da90b4a36b173d938b56addf39ab1373262","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    Dictionary of port pair group parameters. Currently, only \\\u0027\u0026\\\u0027 separated"},{"line_number":147,"context_line":"    string of the lb_fields are supported"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":".. _sfc_port_pair_group_create-name:"},{"line_number":150,"context_line":".. describe:: \u003cname\u003e"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    Name of the port pair group"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba2be162_a8c5500b","line":149,"range":{"start_line":149,"start_character":0,"end_line":149,"end_character":36},"updated":"2017-03-06 20:10:34.000000000","message":"ditto","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"93786da90b4a36b173d938b56addf39ab1373262","unresolved":false,"context_lines":[{"line_number":162,"context_line":"    openstack sfc port pair group delete"},{"line_number":163,"context_line":"        \u003cport-pair-group\u003e"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":".. _sfc_port_pair_group_delete-port-pair-group:"},{"line_number":166,"context_line":".. describe:: \u003cport-pair-group\u003e"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    Port pair group to delete (name or ID)"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba2be162_28da40ea","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":47},"updated":"2017-03-06 20:10:34.000000000","message":"ditto","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"93786da90b4a36b173d938b56addf39ab1373262","unresolved":false,"context_lines":[{"line_number":189,"context_line":"    openstack sfc port pair group show"},{"line_number":190,"context_line":"        \u003cport-pair-group\u003e"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":".. _sfc_port_pair_group_show-port-pair-group:"},{"line_number":193,"context_line":".. describe:: \u003cport-pair-group\u003e"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    Port pair group to display (name or ID)"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba2be162_e8e668af","line":192,"range":{"start_line":192,"start_character":0,"end_line":192,"end_character":45},"updated":"2017-03-06 20:10:34.000000000","message":"ditto","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"93786da90b4a36b173d938b56addf39ab1373262","unresolved":false,"context_lines":[{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    Port pair (name or ID). This option can be repeated"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":".. _sfc_port_pair_group_set-port-pair-group:"},{"line_number":224,"context_line":".. describe:: \u003cport-pair-group\u003e"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"    Port pair group to modify (name or ID)"}],"source_content_type":"text/x-rst","patch_set":26,"id":"ba2be162_28afa02c","line":223,"range":{"start_line":223,"start_character":0,"end_line":223,"end_character":44},"updated":"2017-03-06 20:10:34.000000000","message":"ditto","commit_id":"52205dc19f881a1af4d2c1c6fde3474a595a461a"},{"author":{"_account_id":7776,"name":"Paul Carver","email":"pcarver@att.com","username":"pcarver"},"change_message_id":"f040154f97d0763eb43a43a0bc9bb2acf54acb10","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"**Service Function Chaining** is a mechanism for overriding the basic destination based forwarding"},{"line_number":6,"context_line":"that is typical of IP networks. Service Function Chains consisting of an ordered sequence of"},{"line_number":7,"context_line":"Service Functions (SFs). SFs are virtual machines (or potentially physical devices) that perform a"},{"line_number":8,"context_line":"network function such as firewall, content cache, packet inspection, or any other function that"},{"line_number":9,"context_line":"requires processing of packets in a flow from point A to point B even though the SFs are not"}],"source_content_type":"text/x-rst","patch_set":27,"id":"1a1ced50_43397dd6","line":6,"range":{"start_line":6,"start_character":56,"end_line":6,"end_character":66},"updated":"2017-03-21 22:16:16.000000000","message":"consisting -\u003e consist","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf99333ea0d0a83ca74e599ea76842c200773bf0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"requires processing of packets in a flow from point A to point B even though the SFs are not"},{"line_number":10,"context_line":"literally between point A and B from a routing table perspective."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_b2f4005d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"updated":"2017-03-31 03:56:52.000000000","message":"Isnt this tag to differentiate between neutron and nova-net CLIs?\nIf so , this would not be useful here","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"febdaf73fcc6bd5cde2e894a459bc3c6ed1b43f7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"requires processing of packets in a flow from point A to point B even though the SFs are not"},{"line_number":10,"context_line":"literally between point A and B from a routing table perspective."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_38c56a3d","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"dfeb2761_44ae0ae8","updated":"2017-03-31 08:56:20.000000000","message":"Agreed, but its not required for commands which are only network specific.\nThese are necessary for differentiating Nova and Neutron based commands.\nBut this can be taken care in another iteration.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"01ada35d9b8e6e47799cc4d2439009ef2daa8509","unresolved":false,"context_lines":[{"line_number":9,"context_line":"requires processing of packets in a flow from point A to point B even though the SFs are not"},{"line_number":10,"context_line":"literally between point A and B from a routing table perspective."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_44ae0ae8","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":10},"in_reply_to":"dfeb2761_b2f4005d","updated":"2017-03-31 08:23:12.000000000","message":"the same doc format is being used in other neutron client codes.\n\nhttps://github.com/openstack/python-neutronclient/blob/master/doc/source/usage/osc/v2/networking-bgpvpn.rst","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf99333ea0d0a83ca74e599ea76842c200773bf0","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create a port pair"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_12fdec39","line":14,"updated":"2017-03-31 03:56:52.000000000","message":"Shouldnt this be \n\n  openstack sfc port pair create","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"01ada35d9b8e6e47799cc4d2439009ef2daa8509","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create a port pair"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_e4bbde0b","line":14,"in_reply_to":"dfeb2761_12fdec39","updated":"2017-03-31 08:23:12.000000000","message":"openstack keyword will parse automatically I got followed other docs been merged.\n\nhttps://github.com/openstack/python-neutronclient/tree/master/doc/source/usage/osc/v2","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"febdaf73fcc6bd5cde2e894a459bc3c6ed1b43f7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Network v2"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create a port pair"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_38da0a17","line":14,"in_reply_to":"dfeb2761_e4bbde0b","updated":"2017-03-31 08:56:20.000000000","message":"Ok, saw that..","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf99333ea0d0a83ca74e599ea76842c200773bf0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create a port pair"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. program:: sfc port pair create"},{"line_number":20,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_d29424eb","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":8},"updated":"2017-03-31 03:56:52.000000000","message":"a -\u003e an sfc","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"febdaf73fcc6bd5cde2e894a459bc3c6ed1b43f7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create a port pair"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. program:: sfc port pair create"},{"line_number":20,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_583b8e37","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":8},"in_reply_to":"dfeb2761_64b6aedc","updated":"2017-03-31 08:56:20.000000000","message":"Actually it makes sense here , just as it is followed in the firewall RST given above","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"01ada35d9b8e6e47799cc4d2439009ef2daa8509","unresolved":false,"context_lines":[{"line_number":14,"context_line":"sfc port pair create"},{"line_number":15,"context_line":"--------------------"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Create a port pair"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":".. program:: sfc port pair create"},{"line_number":20,"context_line":".. code:: bash"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_64b6aedc","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":8},"in_reply_to":"dfeb2761_d29424eb","updated":"2017-03-31 08:23:12.000000000","message":"IMO sfc keyword is not needed","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf99333ea0d0a83ca74e599ea76842c200773bf0","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    openstack sfc port pair create"},{"line_number":23,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":24,"context_line":"        --ingress \u003cingress\u003e"},{"line_number":25,"context_line":"        --egress \u003cegress\u003e"},{"line_number":26,"context_line":"        [--service-function-parameters \u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e]"},{"line_number":27,"context_line":"        \u003cname\u003e"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_929e9c05","line":25,"range":{"start_line":24,"start_character":1,"end_line":25,"end_character":25},"updated":"2017-03-31 03:56:52.000000000","message":"These seem necessary optional parameters, but would look great if you change them into positional parameters\nCan you add them after [ --service-function-parameters] ?\nThe Look and Feel would be better","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"febdaf73fcc6bd5cde2e894a459bc3c6ed1b43f7","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    openstack sfc port pair create"},{"line_number":23,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":24,"context_line":"        --ingress \u003cingress\u003e"},{"line_number":25,"context_line":"        --egress \u003cegress\u003e"},{"line_number":26,"context_line":"        [--service-function-parameters \u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e]"},{"line_number":27,"context_line":"        \u003cname\u003e"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_78277214","line":25,"range":{"start_line":24,"start_character":1,"end_line":25,"end_character":25},"in_reply_to":"dfeb2761_04f362a0","updated":"2017-03-31 08:56:20.000000000","message":"And chances are they may not be in the correct order. I mean its not necessary to follow the exact pattern. If we have a scope to change, then we should.\nEither ways, the --ingress and --egress seem like necessary parameters, so making them optional seems to be a better call for now","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"01ada35d9b8e6e47799cc4d2439009ef2daa8509","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    openstack sfc port pair create"},{"line_number":23,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":24,"context_line":"        --ingress \u003cingress\u003e"},{"line_number":25,"context_line":"        --egress \u003cegress\u003e"},{"line_number":26,"context_line":"        [--service-function-parameters \u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e]"},{"line_number":27,"context_line":"        \u003cname\u003e"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_04f362a0","line":25,"range":{"start_line":24,"start_character":1,"end_line":25,"end_character":25},"in_reply_to":"dfeb2761_929e9c05","updated":"2017-03-31 08:23:12.000000000","message":"Followed the actual help message output :)","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf99333ea0d0a83ca74e599ea76842c200773bf0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    Dictionary of Service function parameters. Currently, only correlation\u003dNone and weight"},{"line_number":44,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"},{"line_number":45,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":46,"context_line":"    The default weight is 1"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. _sfc_port_pair_create-name:"},{"line_number":49,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_328590ae","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":27},"updated":"2017-03-31 03:56:52.000000000","message":"Full stop","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"01ada35d9b8e6e47799cc4d2439009ef2daa8509","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    Dictionary of Service function parameters. Currently, only correlation\u003dNone and weight"},{"line_number":44,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"},{"line_number":45,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":46,"context_line":"    The default weight is 1"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. _sfc_port_pair_create-name:"},{"line_number":49,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_840e52e3","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":27},"in_reply_to":"dfeb2761_328590ae","updated":"2017-03-31 08:23:12.000000000","message":"Full stop not followed in openstack convention","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"febdaf73fcc6bd5cde2e894a459bc3c6ed1b43f7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    Dictionary of Service function parameters. Currently, only correlation\u003dNone and weight"},{"line_number":44,"context_line":"    is supported. Weight is an integer that influences the selection of a port pair within"},{"line_number":45,"context_line":"    a port pair group for a flow. The higher the weight, the more flows will hash to the port pair."},{"line_number":46,"context_line":"    The default weight is 1"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":".. _sfc_port_pair_create-name:"},{"line_number":49,"context_line":".. describe:: \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_d87d5ee8","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":27},"in_reply_to":"dfeb2761_840e52e3","updated":"2017-03-31 08:56:20.000000000","message":"On the contrary, it is if the help message is a Paragraph","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf99333ea0d0a83ca74e599ea76842c200773bf0","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    Name of the port pair"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"sfc port pair delete"},{"line_number":54,"context_line":"--------------------"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"Delete a given port pair"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_b2c2c0e8","line":53,"range":{"start_line":53,"start_character":0,"end_line":53,"end_character":3},"updated":"2017-03-31 03:56:52.000000000","message":"openstack sfc \n\nPlease repeat for other CLIs","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"bf99333ea0d0a83ca74e599ea76842c200773bf0","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    openstack sfc port pair set"},{"line_number":105,"context_line":"        [--name \u003cname\u003e]"},{"line_number":106,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":107,"context_line":"        \u003cport-pair\u003e"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_d24b0485","line":106,"updated":"2017-03-31 03:56:52.000000000","message":"cant we change the weights?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"01ada35d9b8e6e47799cc4d2439009ef2daa8509","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    openstack sfc port pair set"},{"line_number":105,"context_line":"        [--name \u003cname\u003e]"},{"line_number":106,"context_line":"        [--description \u003cdescription\u003e]"},{"line_number":107,"context_line":"        \u003cport-pair\u003e"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":".. option:: --name \u003cname\u003e"}],"source_content_type":"text/x-rst","patch_set":29,"id":"dfeb2761_241e660c","line":106,"in_reply_to":"dfeb2761_d24b0485","updated":"2017-03-31 08:23:12.000000000","message":"what you referring here as weights? AFIK port pairs not have any weight property.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3ab1c4aa46fc5e085409b9416ddba65c7b1000a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"df140735_fa82a5ff","updated":"2017-06-05 01:45:37.000000000","message":"All the change from implementation should sync with this documentation as you included in this patch also (We usually make doc follow up with implementation later. Since it will save time for us).","commit_id":"9b62881fe1b0d91520b481972fe62fe9a1835a26"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"1e450de7a9bc60def7db5c759baf921e63768971","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"df140735_895f8e71","in_reply_to":"df140735_1684c4b0","updated":"2017-06-07 10:02:10.000000000","message":"new patch raised as : https://review.openstack.org/#/c/471695/","commit_id":"9b62881fe1b0d91520b481972fe62fe9a1835a26"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"988be0c297bb87ab132d928655f9e45c188c5946","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":36,"id":"df140735_1684c4b0","in_reply_to":"df140735_fa82a5ff","updated":"2017-06-07 07:21:05.000000000","message":"Hi Cao, okay sure . will raise this doc as separate patch!","commit_id":"9b62881fe1b0d91520b481972fe62fe9a1835a26"}],"neutronclient/osc/v2/networking_sfc/flow_classifier/flow_classifier.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"33f91880b6b659f1af6f7b60dd13dffd0058546e","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class CreateFlowClassifier(command.ShowOne):"},{"line_number":29,"context_line":"    \"\"\"Create an Flow Classifier.\"\"\""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def get_parser(self, prog_name):"},{"line_number":32,"context_line":"        parser \u003d super(CreateFlowClassifier, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_56828901","line":29,"range":{"start_line":29,"start_character":14,"end_line":29,"end_character":16},"updated":"2016-12-13 10:31:19.000000000","message":"a","commit_id":"8621144f22b4406ff3088e000fd915a749222cdb"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"b4ec01dd13ada7f7a0a041e0abb05626e9029f4f","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \u0027--protocol\u0027,"},{"line_number":42,"context_line":"            help\u003d_(\u0027IP protocol name. Protocol name should be as per \u0027"},{"line_number":43,"context_line":"                   \u0027IANA standard.\u0027))"},{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--ethertype\u0027,"},{"line_number":46,"context_line":"            default\u003d\u0027IPv4\u0027, choices\u003d[\u0027IPv4\u0027, \u0027IPv6\u0027],"},{"line_number":47,"context_line":"            help\u003d_(\u0027L2 ethertype, default is IPv4.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_2a5e5076","line":44,"updated":"2016-12-14 08:02:06.000000000","message":"all these will need to be stored in respective metavars","commit_id":"13cc4cd2f4cdfbf923d59bd2818346cfa47bb9f7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"d93e7b0aed04f3b77274a2c12015d1c3fcf18971","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            \u0027--protocol\u0027,"},{"line_number":42,"context_line":"            help\u003d_(\u0027IP protocol name. Protocol name should be as per \u0027"},{"line_number":43,"context_line":"                   \u0027IANA standard.\u0027))"},{"line_number":44,"context_line":"        parser.add_argument("},{"line_number":45,"context_line":"            \u0027--ethertype\u0027,"},{"line_number":46,"context_line":"            default\u003d\u0027IPv4\u0027, choices\u003d[\u0027IPv4\u0027, \u0027IPv6\u0027],"},{"line_number":47,"context_line":"            help\u003d_(\u0027L2 ethertype, default is IPv4.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_41e4453a","line":44,"in_reply_to":"1a6eadb0_2a5e5076","updated":"2016-12-14 12:41:55.000000000","message":"will add","commit_id":"13cc4cd2f4cdfbf923d59bd2818346cfa47bb9f7"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"79342c1b6c3028381158cfc58bc42fd67af8c9da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_41004734","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2017-01-09 07:31:57.000000000","message":"2017","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"79342c1b6c3028381158cfc58bc42fd67af8c9da","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"def _fill_protocol_port_info(attrs, port_type, port_val):"},{"line_number":235,"context_line":"        min_port, sep, max_port \u003d port_val.partition(\":\")"},{"line_number":236,"context_line":"        if not max_port:"},{"line_number":237,"context_line":"            max_port \u003d min_port"},{"line_number":238,"context_line":"        attrs[port_type + \u0027_port_range_min\u0027] \u003d int(min_port)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_21050345","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":57},"updated":"2017-01-09 07:31:57.000000000","message":"What if the user input is qaz:wsx? Do we need to ensure the input MUST be an integer?","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e882f8f605b66aa2a4c0e7b3ef089973d3489a0a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"ba5201f7_aa7795d2","updated":"2017-01-11 11:26:29.000000000","message":"The directory networking_sfc/flow_classifier looks verbose.\nHow about the following?\n\n  sfc/flow_classifier.py\n  sfc/port_chain.py\n  ....\n\nI know the historical reason why networking-sfc has a separate extension for flow classifier, but in neutron CLI context it looks completely redundant.","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"7a3c09a3_bb7fc564","in_reply_to":"ba5201f7_aa7795d2","updated":"2017-01-17 07:08:36.000000000","message":"Looks good , will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e882f8f605b66aa2a4c0e7b3ef089973d3489a0a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from osc_lib import exceptions"},{"line_number":19,"context_line":"from osc_lib import utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutronclient._i18n import _"},{"line_number":23,"context_line":"from neutronclient.common import utils as nc_utils"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_2a4ac583","line":21,"updated":"2017-01-11 11:26:29.000000000","message":"two blank lines -\u003e one blank line","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from osc_lib import exceptions"},{"line_number":19,"context_line":"from osc_lib import utils"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutronclient._i18n import _"},{"line_number":23,"context_line":"from neutronclient.common import utils as nc_utils"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_fb95cd86","line":21,"in_reply_to":"ba5201f7_2a4ac583","updated":"2017-01-17 07:08:36.000000000","message":"yes , thanks","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        parser.add_argument("},{"line_number":70,"context_line":"            \u0027--logical-source-port\u0027,"},{"line_number":71,"context_line":"            metavar\u003d\u0027\u003clogical-source-port\u003e\u0027,"},{"line_number":72,"context_line":"            help\u003d_(\u0027ID or name of the neutron source port\u0027))"},{"line_number":73,"context_line":"        parser.add_argument("},{"line_number":74,"context_line":"            \u0027--logical-destination-port\u0027,"},{"line_number":75,"context_line":"            metavar\u003d\u0027\u003clogical-destination-port\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_7ebd4467","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":57},"updated":"2017-01-12 02:01:42.000000000","message":"nit: \"Neutron source port (name or ID)\"","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        parser.add_argument("},{"line_number":70,"context_line":"            \u0027--logical-source-port\u0027,"},{"line_number":71,"context_line":"            metavar\u003d\u0027\u003clogical-source-port\u003e\u0027,"},{"line_number":72,"context_line":"            help\u003d_(\u0027ID or name of the neutron source port\u0027))"},{"line_number":73,"context_line":"        parser.add_argument("},{"line_number":74,"context_line":"            \u0027--logical-destination-port\u0027,"},{"line_number":75,"context_line":"            metavar\u003d\u0027\u003clogical-destination-port\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_5beb4113","line":72,"range":{"start_line":72,"start_character":20,"end_line":72,"end_character":57},"in_reply_to":"ba5201f7_7ebd4467","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        parser.add_argument("},{"line_number":74,"context_line":"            \u0027--logical-destination-port\u0027,"},{"line_number":75,"context_line":"            metavar\u003d\u0027\u003clogical-destination-port\u003e\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027ID or name of the neutron destination port\u0027))"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003ctype\u003dtype[,url\u003durl_path]\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_dee9d0b8","line":76,"range":{"start_line":76,"start_character":19,"end_line":76,"end_character":62},"updated":"2017-01-12 02:01:42.000000000","message":"nit:\n\u0027Neutron destination port (name or ID)\u0027","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        parser.add_argument("},{"line_number":74,"context_line":"            \u0027--logical-destination-port\u0027,"},{"line_number":75,"context_line":"            metavar\u003d\u0027\u003clogical-destination-port\u003e\u0027,"},{"line_number":76,"context_line":"            help\u003d_(\u0027ID or name of the neutron destination port\u0027))"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027\u003ctype\u003dtype[,url\u003durl_path]\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_9bf12904","line":76,"range":{"start_line":76,"start_character":19,"end_line":76,"end_character":62},"in_reply_to":"ba5201f7_dee9d0b8","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":108,"context_line":"            help\u003d_(\u0027Description for the Flow Classifier\u0027))"},{"line_number":109,"context_line":"        parser.add_argument("},{"line_number":110,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":112,"context_line":"            help\u003d_(\"Flow Classifier to modify (name or ID)\")"},{"line_number":113,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_5ea5e044","line":110,"range":{"start_line":110,"start_character":13,"end_line":110,"end_character":28},"updated":"2017-01-12 02:01:42.000000000","message":"flow-classifier","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":108,"context_line":"            help\u003d_(\u0027Description for the Flow Classifier\u0027))"},{"line_number":109,"context_line":"        parser.add_argument("},{"line_number":110,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":112,"context_line":"            help\u003d_(\"Flow Classifier to modify (name or ID)\")"},{"line_number":113,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_dbdf3167","line":110,"range":{"start_line":110,"start_character":13,"end_line":110,"end_character":28},"in_reply_to":"ba5201f7_5ea5e044","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":137,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":138,"context_line":"            help\u003d_(\"ID or name of the Flow Classifier to delete\")"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        return parser"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_fe6e942d","line":138,"range":{"start_line":138,"start_character":20,"end_line":138,"end_character":63},"updated":"2017-01-12 02:01:42.000000000","message":"nit: \n\n\"Flow Classifier to delete (name or ID)\"","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":137,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":138,"context_line":"            help\u003d_(\"ID or name of the Flow Classifier to delete\")"},{"line_number":139,"context_line":"        )"},{"line_number":140,"context_line":"        return parser"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_fbdced74","line":138,"range":{"start_line":138,"start_character":20,"end_line":138,"end_character":63},"in_reply_to":"ba5201f7_fe6e942d","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            client.delete_flow_classifier(fc_id)"},{"line_number":147,"context_line":"        except Exception as e:"},{"line_number":148,"context_line":"            msg \u003d (_(\"Failed to delete Flow Classifier with name \""},{"line_number":149,"context_line":"                   \"or ID \u0027%(fc)s\u0027: %(e)s\")"},{"line_number":150,"context_line":"                   % {\u0027fc\u0027: parsed_args.flow_classifier, \u0027e\u0027: e})"},{"line_number":151,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_fe55b44f","line":149,"range":{"start_line":149,"start_character":19,"end_line":149,"end_character":25},"updated":"2017-01-12 02:01:42.000000000","message":"indentation","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            client.delete_flow_classifier(fc_id)"},{"line_number":147,"context_line":"        except Exception as e:"},{"line_number":148,"context_line":"            msg \u003d (_(\"Failed to delete Flow Classifier with name \""},{"line_number":149,"context_line":"                   \"or ID \u0027%(fc)s\u0027: %(e)s\")"},{"line_number":150,"context_line":"                   % {\u0027fc\u0027: parsed_args.flow_classifier, \u0027e\u0027: e})"},{"line_number":151,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":152,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_1be61944","line":149,"range":{"start_line":149,"start_character":19,"end_line":149,"end_character":25},"in_reply_to":"ba5201f7_fe55b44f","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def get_parser(self, prog_name):"},{"line_number":175,"context_line":"        parser \u003d super(ShowFlowClassifier, self).get_parser(prog_name)"},{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":178,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":179,"context_line":"            help\u003d_(\" ID or name of the Flow Classifier to display\")"},{"line_number":180,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_3ee3bca5","line":177,"range":{"start_line":177,"start_character":13,"end_line":177,"end_character":28},"updated":"2017-01-12 02:01:42.000000000","message":"flow-classifier","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"    def get_parser(self, prog_name):"},{"line_number":175,"context_line":"        parser \u003d super(ShowFlowClassifier, self).get_parser(prog_name)"},{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":178,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":179,"context_line":"            help\u003d_(\" ID or name of the Flow Classifier to display\")"},{"line_number":180,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_3be3d534","line":177,"range":{"start_line":177,"start_character":13,"end_line":177,"end_character":28},"in_reply_to":"ba5201f7_3ee3bca5","updated":"2017-01-17 07:08:36.000000000","message":"will change","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":178,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":179,"context_line":"            help\u003d_(\" ID or name of the Flow Classifier to display\")"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"        return parser"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_7eef0487","line":179,"range":{"start_line":179,"start_character":20,"end_line":179,"end_character":21},"updated":"2017-01-12 02:01:42.000000000","message":"extra space\n\nnit: \"Flow Classifier to display (name or ID)\"","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        parser.add_argument("},{"line_number":177,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":178,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":179,"context_line":"            help\u003d_(\" ID or name of the Flow Classifier to display\")"},{"line_number":180,"context_line":"        )"},{"line_number":181,"context_line":"        return parser"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_7bd71d4b","line":179,"range":{"start_line":179,"start_character":20,"end_line":179,"end_character":21},"in_reply_to":"ba5201f7_7eef0487","updated":"2017-01-17 07:08:36.000000000","message":"yes , will remove","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"}],"neutronclient/osc/v2/networking_sfc/sfc/port_chain.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"33f91880b6b659f1af6f7b60dd13dffd0058546e","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"class ShowPortChain(command.ShowOne):"},{"line_number":171,"context_line":"    \"\"\"Show information of a given Port Pair Groups.\"\"\""},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def get_parser(self, prog_name):"},{"line_number":174,"context_line":"        parser \u003d super(ShowPortChain, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a6eadb0_56e7e9e3","line":171,"range":{"start_line":171,"start_character":35,"end_line":171,"end_character":51},"updated":"2016-12-13 10:31:19.000000000","message":"Port Chain","commit_id":"8621144f22b4406ff3088e000fd915a749222cdb"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"79342c1b6c3028381158cfc58bc42fd67af8c9da","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        return columns, data"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"def _get_columns(item):"},{"line_number":194,"context_line":"    return tuple(sorted(list(item.keys())))"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"def _get_common_attrs(client_manager, parsed_args, is_create\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_6192abf7","line":194,"range":{"start_line":193,"start_character":0,"end_line":194,"end_character":43},"updated":"2017-01-09 07:31:57.000000000","message":"I think this can be a common function.","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"79342c1b6c3028381158cfc58bc42fd67af8c9da","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    return attrs"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"def _get_attrs(attrs, parsed_args):"},{"line_number":219,"context_line":"    if \u0027chain_parameters\u0027 in parsed_args:"},{"line_number":220,"context_line":"        attrs[\u0027chain_parameters\u0027] \u003d parsed_args.chain_parameters"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"def _get_id(client, id_or_name, resource):"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_4175a7c8","line":220,"range":{"start_line":218,"start_character":0,"end_line":220,"end_character":64},"updated":"2017-01-09 07:31:57.000000000","message":"This function get and set attrs.. It\u0027s not just get... Moreover, I believe this function can be put in common file.","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"79342c1b6c3028381158cfc58bc42fd67af8c9da","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        attrs[\u0027chain_parameters\u0027] \u003d parsed_args.chain_parameters"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"def _get_id(client, id_or_name, resource):"},{"line_number":224,"context_line":"    return client.find_resource(resource, str(id_or_name))[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_a1be5362","line":224,"range":{"start_line":223,"start_character":0,"end_line":224,"end_character":64},"updated":"2017-01-09 07:31:57.000000000","message":"I think this can be a common function.","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":47,"context_line":"            required\u003dTrue,"},{"line_number":48,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":49,"context_line":"            help\u003d_(\u0027ID or name of the Port Pair Group. \u0027"},{"line_number":50,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--flow-classifier\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_bc74159c","line":49,"range":{"start_line":49,"start_character":20,"end_line":49,"end_character":53},"updated":"2017-01-12 02:01:42.000000000","message":"nit: \"Port pair group (name or ID)\"\n\nSimilarly elsewhere in all modules for consistency wherein help text consists of \"name or ID\"","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":47,"context_line":"            required\u003dTrue,"},{"line_number":48,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":49,"context_line":"            help\u003d_(\u0027ID or name of the Port Pair Group. \u0027"},{"line_number":50,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":51,"context_line":"        parser.add_argument("},{"line_number":52,"context_line":"            \u0027--flow-classifier\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_fbc30d87","line":49,"range":{"start_line":49,"start_character":20,"end_line":49,"end_character":53},"in_reply_to":"ba5201f7_bc74159c","updated":"2017-01-17 07:08:36.000000000","message":"okay","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            help\u003d_(\u0027ID or name of the port pair group. \u0027"},{"line_number":109,"context_line":"                    \u0027This option can be repeated\u0027))"},{"line_number":110,"context_line":"        parser.add_argument("},{"line_number":111,"context_line":"            \u0027port_chain\u0027,"},{"line_number":112,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"},{"line_number":113,"context_line":"            help\u003d_(\"Port Chain to modify (name or ID)\"))"},{"line_number":114,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_1ca7e10b","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":23},"updated":"2017-01-12 02:01:42.000000000","message":"port-chain","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"f85678639a2b5edd7ac26d2de3f745850051f69b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            help\u003d_(\u0027ID or name of the port pair group. \u0027"},{"line_number":109,"context_line":"                    \u0027This option can be repeated\u0027))"},{"line_number":110,"context_line":"        parser.add_argument("},{"line_number":111,"context_line":"            \u0027port_chain\u0027,"},{"line_number":112,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"},{"line_number":113,"context_line":"            help\u003d_(\"Port Chain to modify (name or ID)\"))"},{"line_number":114,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_c65c5b1b","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":23},"in_reply_to":"ba5201f7_1ca7e10b","updated":"2017-01-18 14:28:37.000000000","message":"Abhishek, for positional argument , it will be \"port_chain\" only. \n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/address_scope.py#L237","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            help\u003d_(\u0027ID or name of the port pair group. \u0027"},{"line_number":109,"context_line":"                    \u0027This option can be repeated\u0027))"},{"line_number":110,"context_line":"        parser.add_argument("},{"line_number":111,"context_line":"            \u0027port_chain\u0027,"},{"line_number":112,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"},{"line_number":113,"context_line":"            help\u003d_(\"Port Chain to modify (name or ID)\"))"},{"line_number":114,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_9b3f6986","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":23},"in_reply_to":"ba5201f7_1ca7e10b","updated":"2017-01-17 07:08:36.000000000","message":"will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def get_parser(self, prog_name):"},{"line_number":136,"context_line":"        parser \u003d super(DeletePortChain, self).get_parser(prog_name)"},{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027port_chain\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\"\u003cport-chain\u003e\","},{"line_number":140,"context_line":"            help\u003d_(\"ID or name of the Port Chain to delete\")"},{"line_number":141,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_7cb62d3f","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":23},"updated":"2017-01-12 02:01:42.000000000","message":"port-chain","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def get_parser(self, prog_name):"},{"line_number":136,"context_line":"        parser \u003d super(DeletePortChain, self).get_parser(prog_name)"},{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027port_chain\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\"\u003cport-chain\u003e\","},{"line_number":140,"context_line":"            help\u003d_(\"ID or name of the Port Chain to delete\")"},{"line_number":141,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_bb44251b","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":23},"in_reply_to":"ba5201f7_7cb62d3f","updated":"2017-01-17 07:08:36.000000000","message":"will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def get_parser(self, prog_name):"},{"line_number":176,"context_line":"        parser \u003d super(ShowPortChain, self).get_parser(prog_name)"},{"line_number":177,"context_line":"        parser.add_argument("},{"line_number":178,"context_line":"            \u0027port_chain\u0027,"},{"line_number":179,"context_line":"            metavar\u003d\"\u003cport-chain\u003e\","},{"line_number":180,"context_line":"            help\u003d_(\"ID or name of the Port Chain to display\")"},{"line_number":181,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_dc87195f","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":23},"updated":"2017-01-12 02:01:42.000000000","message":"ditto","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":175,"context_line":"    def get_parser(self, prog_name):"},{"line_number":176,"context_line":"        parser \u003d super(ShowPortChain, self).get_parser(prog_name)"},{"line_number":177,"context_line":"        parser.add_argument("},{"line_number":178,"context_line":"            \u0027port_chain\u0027,"},{"line_number":179,"context_line":"            metavar\u003d\"\u003cport-chain\u003e\","},{"line_number":180,"context_line":"            help\u003d_(\"ID or name of the Port Chain to display\")"},{"line_number":181,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_fb4a2d25","line":178,"range":{"start_line":178,"start_character":13,"end_line":178,"end_character":23},"in_reply_to":"ba5201f7_dc87195f","updated":"2017-01-17 07:08:36.000000000","message":"will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"}],"neutronclient/osc/v2/networking_sfc/sfc/port_pair_group.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            help\u003d_(\u0027ID or name of the Port Pair.\u0027"},{"line_number":92,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":93,"context_line":"        parser.add_argument("},{"line_number":94,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":95,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\"Port Pair Group to modify (name or ID)\"))"},{"line_number":97,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_dcee3921","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":28},"updated":"2017-01-12 02:01:42.000000000","message":"port-pair-group","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            help\u003d_(\u0027ID or name of the Port Pair.\u0027"},{"line_number":92,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":93,"context_line":"        parser.add_argument("},{"line_number":94,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":95,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\"Port Pair Group to modify (name or ID)\"))"},{"line_number":97,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_1b5459c8","line":94,"range":{"start_line":94,"start_character":13,"end_line":94,"end_character":28},"in_reply_to":"ba5201f7_dcee3921","updated":"2017-01-17 07:08:36.000000000","message":"will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def get_parser(self, prog_name):"},{"line_number":117,"context_line":"        parser \u003d super(DeletePortPairGroup, self).get_parser(prog_name)"},{"line_number":118,"context_line":"        parser.add_argument("},{"line_number":119,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":120,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":121,"context_line":"            help\u003d_(\"ID or name of the Port Pair Group to delete\")"},{"line_number":122,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_3cde656d","line":119,"range":{"start_line":119,"start_character":13,"end_line":119,"end_character":28},"updated":"2017-01-12 02:01:42.000000000","message":"ditto","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    def get_parser(self, prog_name):"},{"line_number":117,"context_line":"        parser \u003d super(DeletePortPairGroup, self).get_parser(prog_name)"},{"line_number":118,"context_line":"        parser.add_argument("},{"line_number":119,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":120,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":121,"context_line":"            help\u003d_(\"ID or name of the Port Pair Group to delete\")"},{"line_number":122,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_3b5115d9","line":119,"range":{"start_line":119,"start_character":13,"end_line":119,"end_character":28},"in_reply_to":"ba5201f7_3cde656d","updated":"2017-01-17 07:08:36.000000000","message":"will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            client.delete_port_pair_group(ppg_id)"},{"line_number":130,"context_line":"        except Exception as e:"},{"line_number":131,"context_line":"            msg \u003d (_(\"Failed to delete Port Pair Group with name \""},{"line_number":132,"context_line":"                   \"or ID \u0027%(ppg)s\u0027: %(e)s\")"},{"line_number":133,"context_line":"                   % {\u0027ppg\u0027: parsed_args.port_pair_group, \u0027e\u0027: e})"},{"line_number":134,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_bcd09554","line":132,"range":{"start_line":132,"start_character":19,"end_line":132,"end_character":20},"updated":"2017-01-12 02:01:42.000000000","message":"indendtaion","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            client.delete_port_pair_group(ppg_id)"},{"line_number":130,"context_line":"        except Exception as e:"},{"line_number":131,"context_line":"            msg \u003d (_(\"Failed to delete Port Pair Group with name \""},{"line_number":132,"context_line":"                   \"or ID \u0027%(ppg)s\u0027: %(e)s\")"},{"line_number":133,"context_line":"                   % {\u0027ppg\u0027: parsed_args.port_pair_group, \u0027e\u0027: e})"},{"line_number":134,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_5b60a1a5","line":132,"range":{"start_line":132,"start_character":19,"end_line":132,"end_character":20},"in_reply_to":"ba5201f7_bcd09554","updated":"2017-01-17 07:08:36.000000000","message":"will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    def get_parser(self, prog_name):"},{"line_number":155,"context_line":"        parser \u003d super(ShowPortPairGroup, self).get_parser(prog_name)"},{"line_number":156,"context_line":"        parser.add_argument("},{"line_number":157,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":158,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":159,"context_line":"            help\u003d_(\"ID or name of the Port Pair Group to display)\")"},{"line_number":160,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"ba5201f7_7cbb8d0f","line":157,"range":{"start_line":157,"start_character":13,"end_line":157,"end_character":28},"updated":"2017-01-12 02:01:42.000000000","message":"ditto","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":154,"context_line":"    def get_parser(self, prog_name):"},{"line_number":155,"context_line":"        parser \u003d super(ShowPortPairGroup, self).get_parser(prog_name)"},{"line_number":156,"context_line":"        parser.add_argument("},{"line_number":157,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":158,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":159,"context_line":"            help\u003d_(\"ID or name of the Port Pair Group to display)\")"},{"line_number":160,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a3c09a3_7b655db3","line":157,"range":{"start_line":157,"start_character":13,"end_line":157,"end_character":28},"in_reply_to":"ba5201f7_7cbb8d0f","updated":"2017-01-17 07:08:36.000000000","message":"will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"}],"neutronclient/osc/v2/sfc/flow_classifier.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"039f82155e8ca04d9797d9573a0a38062f1a3d67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a3905b3_a791b19b","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2017-01-20 06:02:45.000000000","message":"2017","commit_id":"647dcc39087d74a793aa103c2c9091e96bfb9511"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"50acabeed116ed6071247c38681d062f4110ee3e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from osc_lib.command import command"},{"line_number":18,"context_line":"from osc_lib import exceptions"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_f6689f89","line":15,"updated":"2017-01-20 22:27:40.000000000","message":"OSC dictates that the module name be same as the command name.\nSo in this case please change the file name from flow_classifier.py to sfc_flow_classifier.py\n\n\u003cGeneral Comment\u003e","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"80821f928b2a3c224859dd9c23fba1abaaa7885e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from osc_lib.command import command"},{"line_number":18,"context_line":"from osc_lib import exceptions"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_416fc62a","line":15,"in_reply_to":"5a3905b3_f6689f89","updated":"2017-01-23 06:27:31.000000000","message":"ok , sure","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class SetFlowClassifier(command.Command):"},{"line_number":96,"context_line":"    _description \u003d _(\"Set Flow Classifier properties\")"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_parser(self, prog_name):"},{"line_number":99,"context_line":"        parser \u003d super(SetFlowClassifier, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_04fcec70","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":41},"updated":"2017-01-23 07:22:41.000000000","message":"-\u003e flow classifier (for consistency)","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4ccff31c786932f687cf38a00914fcb1d1267d19","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class SetFlowClassifier(command.Command):"},{"line_number":96,"context_line":"    _description \u003d _(\"Set Flow Classifier properties\")"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_parser(self, prog_name):"},{"line_number":99,"context_line":"        parser \u003d super(SetFlowClassifier, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_398bc6c4","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":41},"in_reply_to":"5a3905b3_04fcec70","updated":"2017-01-23 12:18:06.000000000","message":"Done","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"986b7b7cf7c735e997a26addb4257c78f85ab742","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class SetFlowClassifier(command.Command):"},{"line_number":96,"context_line":"    _description \u003d _(\"Set Flow Classifier properties\")"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_parser(self, prog_name):"},{"line_number":99,"context_line":"        parser \u003d super(SetFlowClassifier, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_98ca866d","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":41},"in_reply_to":"5a3905b3_2a13060f","updated":"2017-01-25 05:56:34.000000000","message":"yes ..","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"4933b4997eab9ea3d3367547b07860c3be36cbeb","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class SetFlowClassifier(command.Command):"},{"line_number":96,"context_line":"    _description \u003d _(\"Set Flow Classifier properties\")"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def get_parser(self, prog_name):"},{"line_number":99,"context_line":"        parser \u003d super(SetFlowClassifier, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_2a13060f","line":96,"range":{"start_line":96,"start_character":26,"end_line":96,"end_character":41},"in_reply_to":"5a3905b3_398bc6c4","updated":"2017-01-24 21:28:20.000000000","message":"new PS coming soon?","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def take_action(self, parsed_args):"},{"line_number":157,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":158,"context_line":"        data \u003d client.list_flow_classifier()"},{"line_number":159,"context_line":"        headers \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Protocol\u0027, \u0027Source-IP\u0027, \u0027Destination-IP\u0027,"},{"line_number":160,"context_line":"                   \u0027Logical-Source-Port\u0027, \u0027Logical-Destination-Port\u0027)"},{"line_number":161,"context_line":"        columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027protocol\u0027, \u0027source_ip_prefix\u0027,"},{"line_number":162,"context_line":"                   \u0027destination_ip_prefix\u0027, \u0027logical_source_port\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_87329ef0","line":159,"range":{"start_line":159,"start_character":45,"end_line":159,"end_character":56},"updated":"2017-01-23 07:22:41.000000000","message":"Hyphen looks unnecessary. \"Source IP\"","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4ccff31c786932f687cf38a00914fcb1d1267d19","unresolved":false,"context_lines":[{"line_number":156,"context_line":"    def take_action(self, parsed_args):"},{"line_number":157,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":158,"context_line":"        data \u003d client.list_flow_classifier()"},{"line_number":159,"context_line":"        headers \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Protocol\u0027, \u0027Source-IP\u0027, \u0027Destination-IP\u0027,"},{"line_number":160,"context_line":"                   \u0027Logical-Source-Port\u0027, \u0027Logical-Destination-Port\u0027)"},{"line_number":161,"context_line":"        columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027protocol\u0027, \u0027source_ip_prefix\u0027,"},{"line_number":162,"context_line":"                   \u0027destination_ip_prefix\u0027, \u0027logical_source_port\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_7991cef0","line":159,"range":{"start_line":159,"start_character":45,"end_line":159,"end_character":56},"in_reply_to":"5a3905b3_87329ef0","updated":"2017-01-23 12:18:06.000000000","message":"Done","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                   \u0027Logical-Source-Port\u0027, \u0027Logical-Destination-Port\u0027)"},{"line_number":161,"context_line":"        columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027protocol\u0027, \u0027source_ip_prefix\u0027,"},{"line_number":162,"context_line":"                   \u0027destination_ip_prefix\u0027, \u0027logical_source_port\u0027,"},{"line_number":163,"context_line":"                   \u0027logical_destination_port\u0027)"},{"line_number":164,"context_line":"        return (headers,"},{"line_number":165,"context_line":"                (utils.get_dict_properties("},{"line_number":166,"context_line":"                    s, columns,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_64f7708b","line":163,"updated":"2017-01-23 07:22:41.000000000","message":"No --long option?","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4ccff31c786932f687cf38a00914fcb1d1267d19","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                   \u0027Logical-Source-Port\u0027, \u0027Logical-Destination-Port\u0027)"},{"line_number":161,"context_line":"        columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027protocol\u0027, \u0027source_ip_prefix\u0027,"},{"line_number":162,"context_line":"                   \u0027destination_ip_prefix\u0027, \u0027logical_source_port\u0027,"},{"line_number":163,"context_line":"                   \u0027logical_destination_port\u0027)"},{"line_number":164,"context_line":"        return (headers,"},{"line_number":165,"context_line":"                (utils.get_dict_properties("},{"line_number":166,"context_line":"                    s, columns,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_f9b3fe97","line":163,"in_reply_to":"5a3905b3_64f7708b","updated":"2017-01-23 12:18:06.000000000","message":"will add","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"}],"neutronclient/osc/v2/sfc/port_chain.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"039f82155e8ca04d9797d9573a0a38062f1a3d67","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":97,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID). \u0027"},{"line_number":98,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":99,"context_line":"        fw_args.add_argument("},{"line_number":100,"context_line":"            \u0027--no-flow-classifier\u0027,"},{"line_number":101,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027Associate no flow classifier with the port chain\u0027))"},{"line_number":103,"context_line":"        parser.add_argument("},{"line_number":104,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":105,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a3905b3_275941ff","line":102,"range":{"start_line":99,"start_character":8,"end_line":102,"end_character":71},"updated":"2017-01-20 06:02:45.000000000","message":"Whether we really need this option? Why we can\u0027t use \u0027--flow-classifier\u0027 with no parameters? Just a Query..","commit_id":"647dcc39087d74a793aa103c2c9091e96bfb9511"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"521707298071840277608b85da13c9902696ad23","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":97,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID). \u0027"},{"line_number":98,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":99,"context_line":"        fw_args.add_argument("},{"line_number":100,"context_line":"            \u0027--no-flow-classifier\u0027,"},{"line_number":101,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":102,"context_line":"            help\u003d_(\u0027Associate no flow classifier with the port chain\u0027))"},{"line_number":103,"context_line":"        parser.add_argument("},{"line_number":104,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":105,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a3905b3_3db5d2ed","line":102,"range":{"start_line":99,"start_character":8,"end_line":102,"end_character":71},"in_reply_to":"5a3905b3_275941ff","updated":"2017-01-20 06:54:44.000000000","message":"Yes, you can do that too. But It really handy to use. My thought is lets not deviate from existing clis.\n\nhttps://github.com/openstack/networking-sfc/blob/master/networking_sfc/cli/port_chain.py#L108","commit_id":"647dcc39087d74a793aa103c2c9091e96bfb9511"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class SetPortChain(command.Command):"},{"line_number":79,"context_line":"    _description \u003d _(\"Set port chain Properties\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(SetPortChain, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_2438083d","line":79,"range":{"start_line":79,"start_character":37,"end_line":79,"end_character":47},"updated":"2017-01-23 07:22:41.000000000","message":"-\u003e properties","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4ccff31c786932f687cf38a00914fcb1d1267d19","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class SetPortChain(command.Command):"},{"line_number":79,"context_line":"    _description \u003d _(\"Set port chain Properties\")"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def get_parser(self, prog_name):"},{"line_number":82,"context_line":"        parser \u003d super(SetPortChain, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_b9641622","line":79,"range":{"start_line":79,"start_character":37,"end_line":79,"end_character":47},"in_reply_to":"5a3905b3_2438083d","updated":"2017-01-23 12:18:06.000000000","message":"Done","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"}],"neutronclient/osc/v2/sfc/port_pair.py":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"d468d095702638497b4430d921d0a5781ae9c941","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            required\u003dTrue,"},{"line_number":52,"context_line":"            help\u003d_(\u0027Egress neutron port (name or ID)\u0027))"},{"line_number":53,"context_line":"        parser.add_argument("},{"line_number":54,"context_line":"            \u0027--service-function-parameter\u0027,"},{"line_number":55,"context_line":"            metavar\u003d\u0027\u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e\u0027,"},{"line_number":56,"context_line":"            type\u003dnc_utils.str2dict_type(optional_keys\u003d[\u0027correlation\u0027,"},{"line_number":57,"context_line":"                                                       \u0027weight\u0027]),"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_45c9255a","line":54,"range":{"start_line":54,"start_character":32,"end_line":54,"end_character":41},"updated":"2017-01-24 22:03:03.000000000","message":"parameters","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"824c9f8ccfb74d858b32736ba73a54a3888a0dc7","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            required\u003dTrue,"},{"line_number":52,"context_line":"            help\u003d_(\u0027Egress neutron port (name or ID)\u0027))"},{"line_number":53,"context_line":"        parser.add_argument("},{"line_number":54,"context_line":"            \u0027--service-function-parameter\u0027,"},{"line_number":55,"context_line":"            metavar\u003d\u0027\u003c[correlation\u003dcorrelation_type, weight\u003dweight]\u003e\u0027,"},{"line_number":56,"context_line":"            type\u003dnc_utils.str2dict_type(optional_keys\u003d[\u0027correlation\u0027,"},{"line_number":57,"context_line":"                                                       \u0027weight\u0027]),"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_38fd126f","line":54,"range":{"start_line":54,"start_character":32,"end_line":54,"end_character":41},"in_reply_to":"5a3905b3_45c9255a","updated":"2017-01-25 06:02:33.000000000","message":"will modify","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":139,"context_line":"        data \u003d client.list_port_pair()"},{"line_number":140,"context_line":"        headers \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Ingress Logical Port\u0027, \u0027Egress Logical Port\u0027)"},{"line_number":141,"context_line":"        columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027ingress\u0027, \u0027egress\u0027)"},{"line_number":142,"context_line":"        return (headers,"},{"line_number":143,"context_line":"                (utils.get_dict_properties("},{"line_number":144,"context_line":"                    s, columns,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_a44958b9","line":141,"updated":"2017-01-23 07:22:41.000000000","message":"No --long option?","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"43b539b327e6119b594e19b474c537095fea65c3","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":139,"context_line":"        data \u003d client.list_port_pair()"},{"line_number":140,"context_line":"        headers \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Ingress Logical Port\u0027, \u0027Egress Logical Port\u0027)"},{"line_number":141,"context_line":"        columns \u003d (\u0027id\u0027, \u0027name\u0027, \u0027ingress\u0027, \u0027egress\u0027)"},{"line_number":142,"context_line":"        return (headers,"},{"line_number":143,"context_line":"                (utils.get_dict_properties("},{"line_number":144,"context_line":"                    s, columns,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_29a8cb8c","line":141,"in_reply_to":"5a3905b3_a44958b9","updated":"2017-01-23 15:25:55.000000000","message":"can add description and service-function-parameter field in long option","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class ShowPortPair(command.ShowOne):"},{"line_number":149,"context_line":"    _description \u003d _(\"Show information of a given port pair\")"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_parser(self, prog_name):"},{"line_number":152,"context_line":"        parser \u003d super(ShowPortPair, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_8491bcf3","line":149,"range":{"start_line":149,"start_character":22,"end_line":149,"end_character":60},"updated":"2017-01-23 07:22:41.000000000","message":"-\u003e Display port pair details","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4ccff31c786932f687cf38a00914fcb1d1267d19","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class ShowPortPair(command.ShowOne):"},{"line_number":149,"context_line":"    _description \u003d _(\"Show information of a given port pair\")"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def get_parser(self, prog_name):"},{"line_number":152,"context_line":"        parser \u003d super(ShowPortPair, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_cf32eff1","line":149,"range":{"start_line":149,"start_character":22,"end_line":149,"end_character":60},"in_reply_to":"5a3905b3_8491bcf3","updated":"2017-01-23 12:18:06.000000000","message":"Done","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"}],"neutronclient/osc/v2/sfc/port_pair_group.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from osc_lib import exceptions"},{"line_number":21,"context_line":"from osc_lib import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutronclient._i18n import _"},{"line_number":25,"context_line":"from neutronclient.common import utils as nc_utils"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_e4c280e8","line":23,"updated":"2017-01-23 07:22:41.000000000","message":"single blank line here","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4ccff31c786932f687cf38a00914fcb1d1267d19","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from osc_lib import exceptions"},{"line_number":21,"context_line":"from osc_lib import utils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from neutronclient._i18n import _"},{"line_number":25,"context_line":"from neutronclient.common import utils as nc_utils"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_b94b3686","line":23,"in_reply_to":"5a3905b3_e4c280e8","updated":"2017-01-23 12:18:06.000000000","message":"Done","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class ShowPortPairGroup(command.ShowOne):"},{"line_number":152,"context_line":"    _description \u003d _(\"Show information of a given port pair groups\")"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_parser(self, prog_name):"},{"line_number":155,"context_line":"        parser \u003d super(ShowPortPairGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_046b0cf2","line":152,"range":{"start_line":152,"start_character":22,"end_line":152,"end_character":66},"updated":"2017-01-23 07:22:41.000000000","message":"-\u003e Display port pair group details\n\ngroups -\u003e group","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4ccff31c786932f687cf38a00914fcb1d1267d19","unresolved":false,"context_lines":[{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class ShowPortPairGroup(command.ShowOne):"},{"line_number":152,"context_line":"    _description \u003d _(\"Show information of a given port pair groups\")"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def get_parser(self, prog_name):"},{"line_number":155,"context_line":"        parser \u003d super(ShowPortPairGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_1947ea77","line":152,"range":{"start_line":152,"start_character":22,"end_line":152,"end_character":66},"in_reply_to":"5a3905b3_046b0cf2","updated":"2017-01-23 12:18:06.000000000","message":"Done","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"}],"neutronclient/osc/v2/sfc/sfc_flow_classifier.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":27,"context_line":"resource \u003d \u0027flow_classifier\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class CreateFlowClassifier(command.ShowOne):"},{"line_number":31,"context_line":"    _description \u003d _(\"Create a flow classifier\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_a743e311","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":26},"updated":"2017-02-08 19:41:17.000000000","message":"CreateSfcFlowClassifier to match the module name","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"70006e535dd69e41792d77e19730c8e31289fd31","unresolved":false,"context_lines":[{"line_number":27,"context_line":"resource \u003d \u0027flow_classifier\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class CreateFlowClassifier(command.ShowOne):"},{"line_number":31,"context_line":"    _description \u003d _(\"Create a flow classifier\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_543d79db","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":26},"in_reply_to":"1a430d35_a743e311","updated":"2017-02-09 05:43:53.000000000","message":"ok","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":110,"context_line":"            help\u003d_(\u0027Description for the flow classifier\u0027))"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":113,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":114,"context_line":"            help\u003d_(\"Flow classifier to modify (name or ID)\")"},{"line_number":115,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_076cb79a","line":112,"range":{"start_line":112,"start_character":13,"end_line":112,"end_character":28},"updated":"2017-02-08 19:41:17.000000000","message":"flow-classifier","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"70006e535dd69e41792d77e19730c8e31289fd31","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":110,"context_line":"            help\u003d_(\u0027Description for the flow classifier\u0027))"},{"line_number":111,"context_line":"        parser.add_argument("},{"line_number":112,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":113,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":114,"context_line":"            help\u003d_(\"Flow classifier to modify (name or ID)\")"},{"line_number":115,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_b405bd14","line":112,"range":{"start_line":112,"start_character":13,"end_line":112,"end_character":28},"in_reply_to":"1a430d35_076cb79a","updated":"2017-02-09 05:43:53.000000000","message":"Hi Abhishek Raut , for positional arguments there won\u0027t be auto conversion , so it should be \"flow_classifier\" , for that have added metavar\n\nPlease check existing openstackclient network code .\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/address_scope.py#L114\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/subnet_pool.py#L343","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def get_parser(self, prog_name):"},{"line_number":136,"context_line":"        parser \u003d super(DeleteFlowClassifier, self).get_parser(prog_name)"},{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":140,"context_line":"            help\u003d_(\"Flow classifier to delete (name or ID)\")"},{"line_number":141,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_071af716","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":28},"updated":"2017-02-08 19:41:17.000000000","message":"flow-classifier","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":195,"context_line":"    def get_parser(self, prog_name):"},{"line_number":196,"context_line":"        parser \u003d super(ShowFlowClassifier, self).get_parser(prog_name)"},{"line_number":197,"context_line":"        parser.add_argument("},{"line_number":198,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":199,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":200,"context_line":"            help\u003d_(\"Flow classifier to display (name or ID)\")"},{"line_number":201,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_87b34709","line":198,"range":{"start_line":198,"start_character":13,"end_line":198,"end_character":28},"updated":"2017-02-08 19:41:17.000000000","message":"ditto","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        parser \u003d super(ShowFlowClassifier, self).get_parser(prog_name)"},{"line_number":197,"context_line":"        parser.add_argument("},{"line_number":198,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":199,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":200,"context_line":"            help\u003d_(\"Flow classifier to display (name or ID)\")"},{"line_number":201,"context_line":"        )"},{"line_number":202,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_07c83773","line":199,"range":{"start_line":199,"start_character":22,"end_line":199,"end_character":37},"updated":"2017-02-08 19:41:17.000000000","message":"ditto","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"10a9519ce31072c2d42454c15e0974efaf3f486e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        parser \u003d super(ShowSfcFlowClassifier, self).get_parser(prog_name)"},{"line_number":197,"context_line":"        parser.add_argument("},{"line_number":198,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":199,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":200,"context_line":"            help\u003d_(\"Flow classifier to display (name or ID)\")"},{"line_number":201,"context_line":"        )"},{"line_number":202,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa31d9ce_5c98f66a","line":199,"range":{"start_line":199,"start_character":22,"end_line":199,"end_character":37},"updated":"2017-02-17 04:49:45.000000000","message":"flow-classifier","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"a9fe232abab2e6bb8dede1ea7f391403e988ec8e","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        parser \u003d super(ShowSfcFlowClassifier, self).get_parser(prog_name)"},{"line_number":197,"context_line":"        parser.add_argument("},{"line_number":198,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":199,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":200,"context_line":"            help\u003d_(\"Flow classifier to display (name or ID)\")"},{"line_number":201,"context_line":"        )"},{"line_number":202,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa31d9ce_0e79d92f","line":199,"range":{"start_line":199,"start_character":22,"end_line":199,"end_character":37},"in_reply_to":"fa31d9ce_5c98f66a","updated":"2017-02-17 10:32:25.000000000","message":"ok","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5f7cd4a437c71b39e190cffc503ac9617439b529","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"_attr_map \u003d ("},{"line_number":31,"context_line":"    (\u0027id\u0027, \u0027ID\u0027, nc_osc_utils.LIST_BOTH),"},{"line_number":32,"context_line":"    (\u0027tenant_id\u0027, \u0027Tenant ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":33,"context_line":"    (\u0027name\u0027, \u0027Name\u0027, nc_osc_utils.LIST_BOTH),"},{"line_number":34,"context_line":"    (\u0027summary\u0027, \u0027Summary\u0027, nc_osc_utils.LIST_SHORT_ONLY),"},{"line_number":35,"context_line":"    (\u0027protocol\u0027, \u0027Protocol\u0027, nc_osc_utils.LIST_LONG_ONLY),"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_81ac88a1","line":32,"range":{"start_line":32,"start_character":19,"end_line":32,"end_character":28},"updated":"2017-03-20 20:52:58.000000000","message":"[General comment]: Project","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5f7cd4a437c71b39e190cffc503ac9617439b529","unresolved":false,"context_lines":[{"line_number":52,"context_line":"     nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":53,"context_line":"    (\u0027l7_parameters\u0027, \u0027L7 Parameters\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":54,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":55,"context_line":"    (\u0027project_id\u0027, \u0027Project ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":56,"context_line":")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_819ac861","line":55,"range":{"start_line":55,"start_character":20,"end_line":55,"end_character":30},"updated":"2017-03-20 20:52:58.000000000","message":"[General Comment]: just Project should be good","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"d5121de617eab6a2825f88c2ac463ab613f3554a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"     nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":53,"context_line":"    (\u0027l7_parameters\u0027, \u0027L7 Parameters\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":54,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":55,"context_line":"    (\u0027project_id\u0027, \u0027Project ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":56,"context_line":")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_e1fb1845","line":55,"range":{"start_line":55,"start_character":20,"end_line":55,"end_character":30},"in_reply_to":"1a1ced50_537a0289","updated":"2017-03-22 18:30:28.000000000","message":"it should be consistent with other commands and be Project. Will fix the one in bgpvn","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b38bb1519669e93a19c48dc738ef0a81114715d8","unresolved":false,"context_lines":[{"line_number":52,"context_line":"     nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":53,"context_line":"    (\u0027l7_parameters\u0027, \u0027L7 Parameters\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":54,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":55,"context_line":"    (\u0027project_id\u0027, \u0027Project ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":56,"context_line":")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_537a0289","line":55,"range":{"start_line":55,"start_character":20,"end_line":55,"end_character":30},"in_reply_to":"1a1ced50_819ac861","updated":"2017-03-22 18:21:13.000000000","message":"some existing repo code represented as Project Id and some as Project.\n\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/osc/v2/networking_bgpvpn/router_association.py#L38\n\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/osc/v2/fwaas/firewallgroup.py#L44","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5f7cd4a437c71b39e190cffc503ac9617439b529","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        ext_data \u003d data[\u0027flow_classifiers\u0027]"},{"line_number":200,"context_line":"        for d in ext_data:"},{"line_number":201,"context_line":"            val \u003d []"},{"line_number":202,"context_line":"            protocol \u003d d[\u0027protocol\u0027].upper() if d[\u0027protocol\u0027] else \u0027Any\u0027"},{"line_number":203,"context_line":"            val.append(\u0027protocol: \u0027 + protocol)"},{"line_number":204,"context_line":"            val.append(self._get_protocol_port_details(d, \u0027source\u0027))"},{"line_number":205,"context_line":"            val.append(self._get_protocol_port_details(d, \u0027destination\u0027))"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_41c8d022","line":202,"range":{"start_line":202,"start_character":68,"end_line":202,"end_character":71},"updated":"2017-03-20 20:52:58.000000000","message":"ANY? since you are storing .upper() in protocol. this may not be necessary .. if you think its fine then let it be as it is","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b38bb1519669e93a19c48dc738ef0a81114715d8","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        ext_data \u003d data[\u0027flow_classifiers\u0027]"},{"line_number":200,"context_line":"        for d in ext_data:"},{"line_number":201,"context_line":"            val \u003d []"},{"line_number":202,"context_line":"            protocol \u003d d[\u0027protocol\u0027].upper() if d[\u0027protocol\u0027] else \u0027Any\u0027"},{"line_number":203,"context_line":"            val.append(\u0027protocol: \u0027 + protocol)"},{"line_number":204,"context_line":"            val.append(self._get_protocol_port_details(d, \u0027source\u0027))"},{"line_number":205,"context_line":"            val.append(self._get_protocol_port_details(d, \u0027destination\u0027))"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_c908082b","line":202,"range":{"start_line":202,"start_character":68,"end_line":202,"end_character":71},"in_reply_to":"1a1ced50_41c8d022","updated":"2017-03-22 18:21:13.000000000","message":"if protocol field not mentioned then it can allow all protocols, So IMO  It\u0027ll better to keep as it is","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5f7cd4a437c71b39e190cffc503ac9617439b529","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            d[\u0027summary\u0027] \u003d \u0027,\\n\u0027.join(val)"},{"line_number":218,"context_line":"        return ext_data"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _get_protocol_port_details(self, data, type):"},{"line_number":221,"context_line":"        type_ip_prefix \u003d type + \u0027_ip_prefix\u0027"},{"line_number":222,"context_line":"        ip_prefix \u003d data.get(type_ip_prefix)"},{"line_number":223,"context_line":"        if not ip_prefix:"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_81b72885","line":220,"range":{"start_line":220,"start_character":47,"end_line":220,"end_character":51},"updated":"2017-03-20 20:52:58.000000000","message":"type is a built in fucniton in python.. if you are using it as a variable.. i would suggest use another non reserved name","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b38bb1519669e93a19c48dc738ef0a81114715d8","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            d[\u0027summary\u0027] \u003d \u0027,\\n\u0027.join(val)"},{"line_number":218,"context_line":"        return ext_data"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    def _get_protocol_port_details(self, data, type):"},{"line_number":221,"context_line":"        type_ip_prefix \u003d type + \u0027_ip_prefix\u0027"},{"line_number":222,"context_line":"        ip_prefix \u003d data.get(type_ip_prefix)"},{"line_number":223,"context_line":"        if not ip_prefix:"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_ee46aa79","line":220,"range":{"start_line":220,"start_character":47,"end_line":220,"end_character":51},"in_reply_to":"1a1ced50_81b72885","updated":"2017-03-22 18:21:13.000000000","message":"ok","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5f7cd4a437c71b39e190cffc503ac9617439b529","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        parser \u003d super(ShowSfcFlowClassifier, self).get_parser(prog_name)"},{"line_number":249,"context_line":"        parser.add_argument("},{"line_number":250,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":251,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":252,"context_line":"            help\u003d_(\"Flow classifier to display (name or ID)\")"},{"line_number":253,"context_line":"        )"},{"line_number":254,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_e15a9c4f","line":251,"range":{"start_line":251,"start_character":22,"end_line":251,"end_character":37},"updated":"2017-03-20 20:52:58.000000000","message":"metavar \u003d flow-classifier","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b38bb1519669e93a19c48dc738ef0a81114715d8","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        parser \u003d super(ShowSfcFlowClassifier, self).get_parser(prog_name)"},{"line_number":249,"context_line":"        parser.add_argument("},{"line_number":250,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":251,"context_line":"            metavar\u003d\u0027\u003cflow_classifier\u003e\u0027,"},{"line_number":252,"context_line":"            help\u003d_(\"Flow classifier to display (name or ID)\")"},{"line_number":253,"context_line":"        )"},{"line_number":254,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_418eac2e","line":251,"range":{"start_line":251,"start_character":22,"end_line":251,"end_character":37},"in_reply_to":"1a1ced50_e15a9c4f","updated":"2017-03-22 18:21:13.000000000","message":"ok","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"5f7cd4a437c71b39e190cffc503ac9617439b529","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def _fill_protocol_port_info(attrs, port_type, port_val):"},{"line_number":304,"context_line":"        min_port, sep, max_port \u003d port_val.partition(\":\")"},{"line_number":305,"context_line":"        if not max_port:"},{"line_number":306,"context_line":"            max_port \u003d min_port"},{"line_number":307,"context_line":"        attrs[port_type + \u0027_port_range_min\u0027] \u003d int(min_port)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_649f9ab4","line":304,"range":{"start_line":304,"start_character":34,"end_line":304,"end_character":57},"updated":"2017-03-20 20:52:58.000000000","message":"what happens if i input port as \":80\" ?\n\nalso add UT for this to verify this method behaves correctly with different values for input","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b38bb1519669e93a19c48dc738ef0a81114715d8","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def _fill_protocol_port_info(attrs, port_type, port_val):"},{"line_number":304,"context_line":"        min_port, sep, max_port \u003d port_val.partition(\":\")"},{"line_number":305,"context_line":"        if not max_port:"},{"line_number":306,"context_line":"            max_port \u003d min_port"},{"line_number":307,"context_line":"        attrs[port_type + \u0027_port_range_min\u0027] \u003d int(min_port)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_ae503233","line":304,"range":{"start_line":304,"start_character":34,"end_line":304,"end_character":57},"in_reply_to":"1a1ced50_649f9ab4","updated":"2017-03-22 18:21:13.000000000","message":"Yes, can add, Since the validation part handled in server part of code .. I haven\u0027t included any check, maybe it good to add checks here, will add","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"d5121de617eab6a2825f88c2ac463ab613f3554a","unresolved":false,"context_lines":[{"line_number":301,"context_line":""},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"def _fill_protocol_port_info(attrs, port_type, port_val):"},{"line_number":304,"context_line":"        min_port, sep, max_port \u003d port_val.partition(\":\")"},{"line_number":305,"context_line":"        if not max_port:"},{"line_number":306,"context_line":"            max_port \u003d min_port"},{"line_number":307,"context_line":"        attrs[port_type + \u0027_port_range_min\u0027] \u003d int(min_port)"}],"source_content_type":"text/x-python","patch_set":27,"id":"1a1ced50_0153d439","line":304,"range":{"start_line":304,"start_character":34,"end_line":304,"end_character":57},"in_reply_to":"1a1ced50_ae503233","updated":"2017-03-22 18:30:28.000000000","message":"It will fail on L307 even before it reaches the server \n\nint(min_port) -\u003e ValueError","commit_id":"7da397381c5c62fafe93bf968e7100f1e3be3832"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":57,"context_line":")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class CreateSfcFlowClassifier(command.ShowOne):"},{"line_number":61,"context_line":"    _description \u003d _(\"Create a flow classifier\")"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_65d1c7cd","line":59,"updated":"2017-03-27 08:25:25.000000000","message":"Could you sort command classes in the alphabetical order? It is the OSC convention.","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":57,"context_line":")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class CreateSfcFlowClassifier(command.ShowOne):"},{"line_number":61,"context_line":"    _description \u003d _(\"Create a flow classifier\")"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_d5c91759","line":59,"in_reply_to":"ffe62b97_65d1c7cd","updated":"2017-03-28 14:43:33.000000000","message":"okay","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":57,"context_line":")"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class CreateSfcFlowClassifier(command.ShowOne):"},{"line_number":61,"context_line":"    _description \u003d _(\"Create a flow classifier\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_e5fdd73a","line":60,"range":{"start_line":60,"start_character":6,"end_line":60,"end_character":30},"updated":"2017-03-27 08:25:25.000000000","message":"I tried to show help message of create command, but nothing was displayed.....\n\n  openstack help sfc flow classifier create\n\nThe same thing happens for all SFC create commands.\n\nwhat\u0027s happening?","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                   \u0027IANA standard\u0027))"},{"line_number":78,"context_line":"        parser.add_argument("},{"line_number":79,"context_line":"            \u0027--ethertype\u0027,"},{"line_number":80,"context_line":"            metavar\u003d\u0027\u003c{IPv4,IPv6}\u003e\u0027,"},{"line_number":81,"context_line":"            default\u003d\u0027IPv4\u0027, choices\u003d[\u0027IPv4\u0027, \u0027IPv6\u0027],"},{"line_number":82,"context_line":"            help\u003d_(\u0027L2 ethertype, default is IPv4\u0027))"},{"line_number":83,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_280ef63a","line":80,"range":{"start_line":80,"start_character":21,"end_line":80,"end_character":34},"updated":"2017-03-27 08:25:25.000000000","message":"In this case you don\u0027t need to use \u003c\u003e. See other commands.","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003ctype\u003dtype[,url\u003durl_path]\u003e\u0027,"},{"line_number":112,"context_line":"            type\u003dnc_utils.str2dict,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":114,"context_line":"                   \u0027supported for this option\u0027))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_430c7b3a","line":113,"range":{"start_line":113,"start_character":34,"end_line":113,"end_character":47},"updated":"2017-03-27 08:25:25.000000000","message":"I think \"Layer 7 parameters\" is more easy to understand.","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003ctype\u003dtype[,url\u003durl_path]\u003e\u0027,"},{"line_number":112,"context_line":"            type\u003dnc_utils.str2dict,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":114,"context_line":"                   \u0027supported for this option\u0027))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_95714f47","line":113,"range":{"start_line":113,"start_character":34,"end_line":113,"end_character":47},"in_reply_to":"ffe62b97_430c7b3a","updated":"2017-03-28 14:43:33.000000000","message":"I tried to use same description followed in current implementation","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \u0027--logical-destination-port\u0027,"},{"line_number":107,"context_line":"            metavar\u003d\u0027\u003clogical-destination-port\u003e\u0027,"},{"line_number":108,"context_line":"            help\u003d_(\u0027Neutron destination port (name or ID)\u0027))"},{"line_number":109,"context_line":"        parser.add_argument("},{"line_number":110,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003ctype\u003dtype[,url\u003durl_path]\u003e\u0027,"},{"line_number":112,"context_line":"            type\u003dnc_utils.str2dict,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":114,"context_line":"                   \u0027supported for this option\u0027))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return parser"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_c343ebae","line":114,"range":{"start_line":109,"start_character":8,"end_line":114,"end_character":48},"updated":"2017-03-27 08:25:25.000000000","message":"Regarding my comment at L.60, if I drop this option, the help message was shown as usual. This might have side effect :-(\n\nIn addition, several comments below:\n\n- \"--l7-parameters\" should be a singular name and this options should be able to be repeated (as most list parameters do)\n- consider using MultiKeyValueAction [1]\n\n[1] https://github.com/openstack/osc-lib/blob/master/osc_lib/cli/parseractions.py","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            \u0027--logical-destination-port\u0027,"},{"line_number":107,"context_line":"            metavar\u003d\u0027\u003clogical-destination-port\u003e\u0027,"},{"line_number":108,"context_line":"            help\u003d_(\u0027Neutron destination port (name or ID)\u0027))"},{"line_number":109,"context_line":"        parser.add_argument("},{"line_number":110,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003ctype\u003dtype[,url\u003durl_path]\u003e\u0027,"},{"line_number":112,"context_line":"            type\u003dnc_utils.str2dict,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":114,"context_line":"                   \u0027supported for this option\u0027))"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"        return parser"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_b5a9f37c","line":114,"range":{"start_line":109,"start_character":8,"end_line":114,"end_character":48},"in_reply_to":"ffe62b97_c343ebae","updated":"2017-03-28 14:43:33.000000000","message":"Thanks lot ! there is some side effect. I\u0027ll use MultiKeyValueAction method","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":266,"context_line":"def _get_common_attrs(client_manager, parsed_args, is_create\u003dTrue):"},{"line_number":267,"context_line":"    attrs \u003d {}"},{"line_number":268,"context_line":"    if parsed_args.name is not None:"},{"line_number":269,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":270,"context_line":"    if parsed_args.description is not None:"},{"line_number":271,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":272,"context_line":"    if is_create is True:"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_e5f037cc","line":269,"range":{"start_line":269,"start_character":24,"end_line":269,"end_character":27},"updated":"2017-03-27 08:25:25.000000000","message":"Unnecessary from the same reason as below.","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":266,"context_line":"def _get_common_attrs(client_manager, parsed_args, is_create\u003dTrue):"},{"line_number":267,"context_line":"    attrs \u003d {}"},{"line_number":268,"context_line":"    if parsed_args.name is not None:"},{"line_number":269,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":270,"context_line":"    if parsed_args.description is not None:"},{"line_number":271,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":272,"context_line":"    if is_create is True:"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_b5d7b3ee","line":269,"range":{"start_line":269,"start_character":24,"end_line":269,"end_character":27},"in_reply_to":"ffe62b97_e5f037cc","updated":"2017-03-28 14:43:33.000000000","message":"yes","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    if parsed_args.name is not None:"},{"line_number":269,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":270,"context_line":"    if parsed_args.description is not None:"},{"line_number":271,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":272,"context_line":"    if is_create is True:"},{"line_number":273,"context_line":"        _get_attrs(client_manager, attrs, parsed_args)"},{"line_number":274,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_25e73f15","line":271,"range":{"start_line":271,"start_character":31,"end_line":271,"end_character":59},"updated":"2017-03-27 08:25:25.000000000","message":"parsed_args.description is already string. str() looks unnecessary.","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"    if parsed_args.name is not None:"},{"line_number":269,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":270,"context_line":"    if parsed_args.description is not None:"},{"line_number":271,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":272,"context_line":"    if is_create is True:"},{"line_number":273,"context_line":"        _get_attrs(client_manager, attrs, parsed_args)"},{"line_number":274,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_7507eb83","line":271,"range":{"start_line":271,"start_character":31,"end_line":271,"end_character":59},"in_reply_to":"ffe62b97_25e73f15","updated":"2017-03-28 14:43:33.000000000","message":"ok","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":270,"context_line":"    if parsed_args.description is not None:"},{"line_number":271,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":272,"context_line":"    if is_create is True:"},{"line_number":273,"context_line":"        _get_attrs(client_manager, attrs, parsed_args)"},{"line_number":274,"context_line":"    return attrs"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_05e2fb01","line":272,"range":{"start_line":272,"start_character":3,"end_line":272,"end_character":24},"updated":"2017-03-27 08:25:25.000000000","message":"Just \"if is_create\"","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":269,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":270,"context_line":"    if parsed_args.description is not None:"},{"line_number":271,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":272,"context_line":"    if is_create is True:"},{"line_number":273,"context_line":"        _get_attrs(client_manager, attrs, parsed_args)"},{"line_number":274,"context_line":"    return attrs"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_35fde36d","line":272,"range":{"start_line":272,"start_character":3,"end_line":272,"end_character":24},"in_reply_to":"ffe62b97_05e2fb01","updated":"2017-03-28 14:43:33.000000000","message":"ok","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"def _fill_protocol_port_info(attrs, port_type, port_val):"},{"line_number":305,"context_line":"        min_port, sep, max_port \u003d port_val.partition(\":\")"},{"line_number":306,"context_line":"        if not min_port:"},{"line_number":307,"context_line":"            msg \u003d (\"Invalid port value \u0027%s\u0027, expected format is \""},{"line_number":308,"context_line":"                   \"min-port:max-port or min-port\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_25229f53","line":305,"range":{"start_line":305,"start_character":8,"end_line":305,"end_character":57},"updated":"2017-03-27 08:25:25.000000000","message":"(Matter of mind) If we use split(), \u0027sep\u0027 will be no longer unnecessary.\n\n min_port, max_port \u003d port_val.split(\":\", 1)","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"24ed7712af924f45fbd92b6037f022c8ff4f8112","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"def _fill_protocol_port_info(attrs, port_type, port_val):"},{"line_number":305,"context_line":"        min_port, sep, max_port \u003d port_val.partition(\":\")"},{"line_number":306,"context_line":"        if not min_port:"},{"line_number":307,"context_line":"            msg \u003d (\"Invalid port value \u0027%s\u0027, expected format is \""},{"line_number":308,"context_line":"                   \"min-port:max-port or min-port\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_44fd536c","line":305,"range":{"start_line":305,"start_character":8,"end_line":305,"end_character":57},"in_reply_to":"ffe62b97_25229f53","updated":"2017-03-28 16:04:16.000000000","message":"but here value can be a or a:b . So IMO partition is better","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"def _fill_protocol_port_info(attrs, port_type, port_val):"},{"line_number":305,"context_line":"        min_port, sep, max_port \u003d port_val.partition(\":\")"},{"line_number":306,"context_line":"        if not min_port:"},{"line_number":307,"context_line":"            msg \u003d (\"Invalid port value \u0027%s\u0027, expected format is \""},{"line_number":308,"context_line":"                   \"min-port:max-port or min-port\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_95edcfb8","line":305,"range":{"start_line":305,"start_character":8,"end_line":305,"end_character":57},"in_reply_to":"ffe62b97_25229f53","updated":"2017-03-28 14:43:33.000000000","message":"yes , can be","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9cb64b0bfd06a7d3c1bd7bbeb64a8542b64e37c","unresolved":false,"context_lines":[{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"def _fill_protocol_port_info(attrs, port_type, port_val):"},{"line_number":305,"context_line":"        min_port, sep, max_port \u003d port_val.partition(\":\")"},{"line_number":306,"context_line":"        if not min_port:"},{"line_number":307,"context_line":"            msg \u003d (\"Invalid port value \u0027%s\u0027, expected format is \""},{"line_number":308,"context_line":"                   \"min-port:max-port or min-port\")"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_5f90804a","line":305,"range":{"start_line":305,"start_character":8,"end_line":305,"end_character":57},"in_reply_to":"ffe62b97_44fd536c","updated":"2017-03-28 16:17:26.000000000","message":"Sound good.","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"337f64b9ac7da8ac4f1167375efa9ba991bc0317","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        try:"},{"line_number":313,"context_line":"            attrs[port_type + \u0027_port_range_min\u0027] \u003d int(min_port)"},{"line_number":314,"context_line":"            attrs[port_type + \u0027_port_range_max\u0027] \u003d int(max_port)"},{"line_number":315,"context_line":"        except Exception:"},{"line_number":316,"context_line":"            message \u003d (_(\u0027Protocol port value: %(val)s must be an integer \u0027"},{"line_number":317,"context_line":"                         \u0027or integer:integer\u0027) %"},{"line_number":318,"context_line":"                       {\u0027val\u0027: port_val})"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_77c0b251","line":315,"range":{"start_line":315,"start_character":15,"end_line":315,"end_character":24},"updated":"2017-03-23 23:09:54.000000000","message":"except ValueError makes it more specific","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        try:"},{"line_number":313,"context_line":"            attrs[port_type + \u0027_port_range_min\u0027] \u003d int(min_port)"},{"line_number":314,"context_line":"            attrs[port_type + \u0027_port_range_max\u0027] \u003d int(max_port)"},{"line_number":315,"context_line":"        except Exception:"},{"line_number":316,"context_line":"            message \u003d (_(\u0027Protocol port value: %(val)s must be an integer \u0027"},{"line_number":317,"context_line":"                         \u0027or integer:integer\u0027) %"},{"line_number":318,"context_line":"                       {\u0027val\u0027: port_val})"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_f53f7b22","line":315,"range":{"start_line":315,"start_character":15,"end_line":315,"end_character":24},"in_reply_to":"ffe62b97_77c0b251","updated":"2017-03-28 14:43:33.000000000","message":"will do","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            attrs[port_type + \u0027_port_range_min\u0027] \u003d int(min_port)"},{"line_number":314,"context_line":"            attrs[port_type + \u0027_port_range_max\u0027] \u003d int(max_port)"},{"line_number":315,"context_line":"        except Exception:"},{"line_number":316,"context_line":"            message \u003d (_(\u0027Protocol port value: %(val)s must be an integer \u0027"},{"line_number":317,"context_line":"                         \u0027or integer:integer\u0027) %"},{"line_number":318,"context_line":"                       {\u0027val\u0027: port_val})"},{"line_number":319,"context_line":"            raise nc_exc.NeutronClientException(message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_05467b22","line":316,"range":{"start_line":316,"start_character":47,"end_line":316,"end_character":55},"updated":"2017-03-27 08:25:25.000000000","message":"-\u003e %s","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            attrs[port_type + \u0027_port_range_min\u0027] \u003d int(min_port)"},{"line_number":314,"context_line":"            attrs[port_type + \u0027_port_range_max\u0027] \u003d int(max_port)"},{"line_number":315,"context_line":"        except Exception:"},{"line_number":316,"context_line":"            message \u003d (_(\u0027Protocol port value: %(val)s must be an integer \u0027"},{"line_number":317,"context_line":"                         \u0027or integer:integer\u0027) %"},{"line_number":318,"context_line":"                       {\u0027val\u0027: port_val})"},{"line_number":319,"context_line":"            raise nc_exc.NeutronClientException(message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_7515ab9b","line":316,"range":{"start_line":316,"start_character":47,"end_line":316,"end_character":55},"in_reply_to":"ffe62b97_05467b22","updated":"2017-03-28 14:43:33.000000000","message":"ok","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"def _get_id(client, id_or_name, resource):"},{"line_number":323,"context_line":"    return client.find_resource(resource, str(id_or_name))[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_c5e1b32c","line":323,"range":{"start_line":323,"start_character":42,"end_line":323,"end_character":57},"updated":"2017-03-27 08:25:25.000000000","message":"Why do we need str()? Doesn\u0027t id_or_name without str() work?","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"858ba81934b66e5ac54d8195e4208ef7bb76589a","unresolved":false,"context_lines":[{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"def _get_id(client, id_or_name, resource):"},{"line_number":323,"context_line":"    return client.find_resource(resource, str(id_or_name))[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_75636b43","line":323,"range":{"start_line":323,"start_character":42,"end_line":323,"end_character":57},"in_reply_to":"ffe62b97_c5e1b32c","updated":"2017-03-28 14:43:33.000000000","message":"should work","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            help\u003d_(\u0027L2 ethertype, default is IPv4\u0027))"},{"line_number":83,"context_line":"        parser.add_argument("},{"line_number":84,"context_line":"            \u0027--source-port\u0027,"},{"line_number":85,"context_line":"            metavar\u003d\u0027\u003csource-port\u003e\u0027,"},{"line_number":86,"context_line":"            help\u003d_(\u0027Source protocol port (allowed range [1,65535]. Must be \u0027"},{"line_number":87,"context_line":"                   \u0027specified as a:b, where a\u003dmin-port and b\u003dmax-port)\u0027))"},{"line_number":88,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_cd2bd592","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":34},"updated":"2017-04-05 07:01:18.000000000","message":"I wonder\n\n  \u003cmin-port\u003e:\u003cmax-port\u003e\n\nwoudl be better.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            help\u003d_(\u0027L2 ethertype, default is IPv4\u0027))"},{"line_number":83,"context_line":"        parser.add_argument("},{"line_number":84,"context_line":"            \u0027--source-port\u0027,"},{"line_number":85,"context_line":"            metavar\u003d\u0027\u003csource-port\u003e\u0027,"},{"line_number":86,"context_line":"            help\u003d_(\u0027Source protocol port (allowed range [1,65535]. Must be \u0027"},{"line_number":87,"context_line":"                   \u0027specified as a:b, where a\u003dmin-port and b\u003dmax-port)\u0027))"},{"line_number":88,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f648aa2d","line":85,"range":{"start_line":85,"start_character":21,"end_line":85,"end_character":34},"in_reply_to":"dfeb2761_cd2bd592","updated":"2017-04-05 09:57:33.000000000","message":"agree","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                   \u0027specified as a:b, where a\u003dmin-port and b\u003dmax-port)\u0027))"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--destination-port\u0027,"},{"line_number":90,"context_line":"            metavar\u003d\u0027\u003cdestination-port\u003e\u0027,"},{"line_number":91,"context_line":"            help\u003d_(\u0027Destination protocol port (allowed range [1,65535]. Must \u0027"},{"line_number":92,"context_line":"                   \u0027be specified as a:b, where a\u003dmin-port and b\u003dmax-port)\u0027))"},{"line_number":93,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_4d11055d","line":90,"range":{"start_line":90,"start_character":21,"end_line":90,"end_character":39},"updated":"2017-04-05 07:01:18.000000000","message":"same as the above","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":87,"context_line":"                   \u0027specified as a:b, where a\u003dmin-port and b\u003dmax-port)\u0027))"},{"line_number":88,"context_line":"        parser.add_argument("},{"line_number":89,"context_line":"            \u0027--destination-port\u0027,"},{"line_number":90,"context_line":"            metavar\u003d\u0027\u003cdestination-port\u003e\u0027,"},{"line_number":91,"context_line":"            help\u003d_(\u0027Destination protocol port (allowed range [1,65535]. Must \u0027"},{"line_number":92,"context_line":"                   \u0027be specified as a:b, where a\u003dmin-port and b\u003dmax-port)\u0027))"},{"line_number":93,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_d65126db","line":90,"range":{"start_line":90,"start_character":21,"end_line":90,"end_character":39},"in_reply_to":"dfeb2761_4d11055d","updated":"2017-04-05 09:57:33.000000000","message":"agree","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        parser.add_argument("},{"line_number":94,"context_line":"            \u0027--source-ip-prefix\u0027,"},{"line_number":95,"context_line":"            metavar\u003d\u0027\u003csource-ip-prefix\u003e\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\u0027Source IP prefix or subnet\u0027))"},{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027--destination-ip-prefix\u0027,"},{"line_number":99,"context_line":"            metavar\u003d\u0027\u003cdestination-ip-prefix\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_d0192e7a","line":96,"range":{"start_line":96,"start_character":20,"end_line":96,"end_character":46},"updated":"2017-04-05 07:01:18.000000000","message":"As a user, I cannot understand what this means. I think \"IP prefix\" and \"subnet\" are same. Do you expect CIDR? IP address or CIDR?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"992ac6495ccb0f63aa8e067a46ae5fe850b0713b","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        parser.add_argument("},{"line_number":94,"context_line":"            \u0027--source-ip-prefix\u0027,"},{"line_number":95,"context_line":"            metavar\u003d\u0027\u003csource-ip-prefix\u003e\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\u0027Source IP prefix or subnet\u0027))"},{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027--destination-ip-prefix\u0027,"},{"line_number":99,"context_line":"            metavar\u003d\u0027\u003cdestination-ip-prefix\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_efc6849a","line":96,"range":{"start_line":96,"start_character":20,"end_line":96,"end_character":46},"in_reply_to":"dfeb2761_d0192e7a","updated":"2017-04-05 10:29:07.000000000","message":"in CIDR notation . I\u0027ll rewrite as \"Source IP address in CIDR notation\" ?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"17bed3620e67090a90f38d37c75953f0cf5f2eb7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        parser.add_argument("},{"line_number":94,"context_line":"            \u0027--source-ip-prefix\u0027,"},{"line_number":95,"context_line":"            metavar\u003d\u0027\u003csource-ip-prefix\u003e\u0027,"},{"line_number":96,"context_line":"            help\u003d_(\u0027Source IP prefix or subnet\u0027))"},{"line_number":97,"context_line":"        parser.add_argument("},{"line_number":98,"context_line":"            \u0027--destination-ip-prefix\u0027,"},{"line_number":99,"context_line":"            metavar\u003d\u0027\u003cdestination-ip-prefix\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"bff0334d_03cb7053","line":96,"range":{"start_line":96,"start_character":20,"end_line":96,"end_character":46},"in_reply_to":"dfeb2761_efc6849a","updated":"2017-04-05 13:39:24.000000000","message":"\"Source ID address in CIDR notation\" looks fine to me.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            help\u003d_(\u0027Neutron destination port (name or ID)\u0027))"},{"line_number":109,"context_line":"        parser.add_argument("},{"line_number":110,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003curl\u003durl_path\u003e\u0027,"},{"line_number":112,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":114,"context_line":"                   \u0027supported for this option\u0027))"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_b02fca86","line":111,"range":{"start_line":111,"start_character":26,"end_line":111,"end_character":34},"updated":"2017-04-05 07:01:18.000000000","message":"-\u003e url-path","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            help\u003d_(\u0027Neutron destination port (name or ID)\u0027))"},{"line_number":109,"context_line":"        parser.add_argument("},{"line_number":110,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003curl\u003durl_path\u003e\u0027,"},{"line_number":112,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":114,"context_line":"                   \u0027supported for this option\u0027))"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_b64ea235","line":111,"range":{"start_line":111,"start_character":26,"end_line":111,"end_character":34},"in_reply_to":"dfeb2761_b02fca86","updated":"2017-04-05 09:57:33.000000000","message":"ok","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003curl\u003durl_path\u003e\u0027,"},{"line_number":112,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":114,"context_line":"                   \u0027supported for this option\u0027))"},{"line_number":115,"context_line":"        return parser"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f039d2d6","line":114,"range":{"start_line":113,"start_character":60,"end_line":114,"end_character":45},"updated":"2017-04-05 07:01:18.000000000","message":"Hmm.... no value is supported, but metavar says \u003curl\u003durl_path\u003e is the expected format.... which is correct?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":110,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":111,"context_line":"            metavar\u003d\u0027\u003curl\u003durl_path\u003e\u0027,"},{"line_number":112,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":113,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":114,"context_line":"                   \u0027supported for this option\u0027))"},{"line_number":115,"context_line":"        return parser"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_76d93a55","line":114,"range":{"start_line":113,"start_character":60,"end_line":114,"end_character":45},"in_reply_to":"dfeb2761_f039d2d6","updated":"2017-04-05 09:57:33.000000000","message":"I should remove the metavar then , the l7-parameter support is yet to add , It\u0027s just the placeholder now","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class DeleteSfcFlowClassifier(command.Command):"},{"line_number":128,"context_line":"    _description \u003d _(\"Delete a given flow classifier\")"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def get_parser(self, prog_name):"},{"line_number":131,"context_line":"        parser \u003d super(DeleteSfcFlowClassifier, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f03e72b6","line":128,"range":{"start_line":128,"start_character":22,"end_line":128,"end_character":54},"updated":"2017-04-05 07:01:18.000000000","message":"Following OSC convention, this needs to be:\n\n  Delete flow classifier(s)","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        parser \u003d super(DeleteSfcFlowClassifier, self).get_parser(prog_name)"},{"line_number":132,"context_line":"        parser.add_argument("},{"line_number":133,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":134,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":135,"context_line":"            help\u003d_(\"Flow classifier to delete (name or ID)\")"},{"line_number":136,"context_line":"        )"},{"line_number":137,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_939cd0c0","line":134,"updated":"2017-04-05 07:01:18.000000000","message":"Could you consider deleting multiple objects following OSC convention?\n\nHowever, it can be deferred in a separate patch. If so, my above comment will be unnecessary.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        parser \u003d super(DeleteSfcFlowClassifier, self).get_parser(prog_name)"},{"line_number":132,"context_line":"        parser.add_argument("},{"line_number":133,"context_line":"            \u0027flow_classifier\u0027,"},{"line_number":134,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":135,"context_line":"            help\u003d_(\"Flow classifier to delete (name or ID)\")"},{"line_number":136,"context_line":"        )"},{"line_number":137,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_b6b90216","line":134,"in_reply_to":"dfeb2761_939cd0c0","updated":"2017-04-05 09:57:33.000000000","message":"yes Akihiro, I\u0027ll take this as the separate patch and same for other sfc delete commands","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        parser.add_argument("},{"line_number":157,"context_line":"            \u0027--long\u0027,"},{"line_number":158,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":159,"context_line":"            default\u003dFalse,"},{"line_number":160,"context_line":"            help\u003d_(\"List additional fields in output\")"},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_30729aae","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":26},"updated":"2017-04-05 07:01:18.000000000","message":"unnecessary. The default value is False if action is store_true.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        parser.add_argument("},{"line_number":157,"context_line":"            \u0027--long\u0027,"},{"line_number":158,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":159,"context_line":"            default\u003dFalse,"},{"line_number":160,"context_line":"            help\u003d_(\"List additional fields in output\")"},{"line_number":161,"context_line":"        )"},{"line_number":162,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_563e368b","line":159,"range":{"start_line":159,"start_character":12,"end_line":159,"end_character":26},"in_reply_to":"dfeb2761_30729aae","updated":"2017-04-05 09:57:33.000000000","message":"ok","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        ext_data \u003d data[\u0027flow_classifiers\u0027]"},{"line_number":166,"context_line":"        for d in ext_data:"},{"line_number":167,"context_line":"            val \u003d []"},{"line_number":168,"context_line":"            protocol \u003d d[\u0027protocol\u0027].upper() if d[\u0027protocol\u0027] else \u0027Any\u0027"},{"line_number":169,"context_line":"            val.append(\u0027protocol: \u0027 + protocol)"},{"line_number":170,"context_line":"            val.append(self._get_protocol_port_details(d, \u0027source\u0027))"},{"line_number":171,"context_line":"            val.append(self._get_protocol_port_details(d, \u0027destination\u0027))"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f0ac32ee","line":168,"range":{"start_line":168,"start_character":67,"end_line":168,"end_character":72},"updated":"2017-04-05 07:01:18.000000000","message":"\"Any\" is used here, but \u0027any\u0027 is used below. Some consistency would be better. Personally +1 for \u0027any\u0027.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        ext_data \u003d data[\u0027flow_classifiers\u0027]"},{"line_number":166,"context_line":"        for d in ext_data:"},{"line_number":167,"context_line":"            val \u003d []"},{"line_number":168,"context_line":"            protocol \u003d d[\u0027protocol\u0027].upper() if d[\u0027protocol\u0027] else \u0027Any\u0027"},{"line_number":169,"context_line":"            val.append(\u0027protocol: \u0027 + protocol)"},{"line_number":170,"context_line":"            val.append(self._get_protocol_port_details(d, \u0027source\u0027))"},{"line_number":171,"context_line":"            val.append(self._get_protocol_port_details(d, \u0027destination\u0027))"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_3643b215","line":168,"range":{"start_line":168,"start_character":67,"end_line":168,"end_character":72},"in_reply_to":"dfeb2761_f0ac32ee","updated":"2017-04-05 09:57:33.000000000","message":"sure","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"7a2019f26d240cbd1b993651ccbed869a827965f","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027--protocol\u0027,"},{"line_number":74,"context_line":"            metavar\u003d\u0027\u003cprotocol\u003e\u0027,"},{"line_number":75,"context_line":"            help\u003d_(\u0027IP protocol name. Protocol name should be as per \u0027"},{"line_number":76,"context_line":"                   \u0027IANA standard\u0027))"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--ethertype\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027{IPv4,IPv6}\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"df140735_f017bd50","line":76,"range":{"start_line":76,"start_character":33,"end_line":76,"end_character":34},"updated":"2017-06-01 08:44:51.000000000","message":"Need a period here Because this help message included more than 1 sentence. Apply for all remaining in this file\nex: https://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/subnet.py#L307","commit_id":"c22acd1e113e5fff6fadd2e8db91d0bf736707b7"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"e3935919953493e65f0b0882413fa90a5d4302d6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027--protocol\u0027,"},{"line_number":74,"context_line":"            metavar\u003d\u0027\u003cprotocol\u003e\u0027,"},{"line_number":75,"context_line":"            help\u003d_(\u0027IP protocol name. Protocol name should be as per \u0027"},{"line_number":76,"context_line":"                   \u0027IANA standard\u0027))"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--ethertype\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027{IPv4,IPv6}\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"df140735_a196794b","line":76,"range":{"start_line":76,"start_character":33,"end_line":76,"end_character":34},"in_reply_to":"df140735_9fc6499a","updated":"2017-06-02 02:33:18.000000000","message":"But  It\u0027s not followed for all  \n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/network.py#L615\n\nThis help message contain only one sentence. So no need period in end of line.\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/subnet.py#L455\n\nSame as above.\n\nhttps://github.com/openstack/python-openstackclient/blob/1686dc54f09b6e77b1de3abc708c297710987a04/openstackclient/network/v2/network_segment.py#L60\n\nThis is one long sentence with 2 comma.\n\n\u003d\u003e There are all used 1 sentence in help message.","commit_id":"c22acd1e113e5fff6fadd2e8db91d0bf736707b7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"34fcda0440f091dd688007ae6a2cde084c2de11d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027--protocol\u0027,"},{"line_number":74,"context_line":"            metavar\u003d\u0027\u003cprotocol\u003e\u0027,"},{"line_number":75,"context_line":"            help\u003d_(\u0027IP protocol name. Protocol name should be as per \u0027"},{"line_number":76,"context_line":"                   \u0027IANA standard\u0027))"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--ethertype\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027{IPv4,IPv6}\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"df140735_9a751bce","line":76,"range":{"start_line":76,"start_character":33,"end_line":76,"end_character":34},"in_reply_to":"df140735_a196794b","updated":"2017-06-02 05:57:11.000000000","message":"Got it. Thanks :)","commit_id":"c22acd1e113e5fff6fadd2e8db91d0bf736707b7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"01e95e889f72548c4b2780000d4b5783c6d7da11","unresolved":false,"context_lines":[{"line_number":73,"context_line":"            \u0027--protocol\u0027,"},{"line_number":74,"context_line":"            metavar\u003d\u0027\u003cprotocol\u003e\u0027,"},{"line_number":75,"context_line":"            help\u003d_(\u0027IP protocol name. Protocol name should be as per \u0027"},{"line_number":76,"context_line":"                   \u0027IANA standard\u0027))"},{"line_number":77,"context_line":"        parser.add_argument("},{"line_number":78,"context_line":"            \u0027--ethertype\u0027,"},{"line_number":79,"context_line":"            metavar\u003d\u0027{IPv4,IPv6}\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"df140735_9fc6499a","line":76,"range":{"start_line":76,"start_character":33,"end_line":76,"end_character":34},"in_reply_to":"df140735_f017bd50","updated":"2017-06-01 12:12:01.000000000","message":"But  It\u0027s not followed for all  \n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/network.py#L615\n\nhttps://github.com/openstack/python-openstackclient/blob/master/openstackclient/network/v2/subnet.py#L455\n\nhttps://github.com/openstack/python-openstackclient/blob/1686dc54f09b6e77b1de3abc708c297710987a04/openstackclient/network/v2/network_segment.py#L60","commit_id":"c22acd1e113e5fff6fadd2e8db91d0bf736707b7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            \u0027--source-port\u0027,"},{"line_number":84,"context_line":"            metavar\u003d\u0027\u003cmin-port\u003e:\u003cmax-port\u003e\u0027,"},{"line_number":85,"context_line":"            help\u003d_(\u0027Source protocol port (allowed range [1,65535]. Must be \u0027"},{"line_number":86,"context_line":"                   \u0027specified as a:b, where a\u003dmin-port and b\u003dmax-port)\u0027))"},{"line_number":87,"context_line":"        parser.add_argument("},{"line_number":88,"context_line":"            \u0027--destination-port\u0027,"},{"line_number":89,"context_line":"            metavar\u003d\u0027\u003cmin-port\u003e:\u003cmax-port\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_bd2695cd","line":86,"updated":"2017-06-15 01:05:41.000000000","message":"it would be nice if a and b are included or excluded in the range.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            \u0027--destination-port\u0027,"},{"line_number":89,"context_line":"            metavar\u003d\u0027\u003cmin-port\u003e:\u003cmax-port\u003e\u0027,"},{"line_number":90,"context_line":"            help\u003d_(\u0027Destination protocol port (allowed range [1,65535]. Must \u0027"},{"line_number":91,"context_line":"                   \u0027be specified as a:b, where a\u003dmin-port and b\u003dmax-port)\u0027))"},{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027--source-ip-prefix\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003csource-ip-prefix\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_9d23d9bd","line":91,"updated":"2017-06-15 01:05:41.000000000","message":"ditto","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            help\u003d_(\u0027Neutron destination port (name or ID)\u0027))"},{"line_number":108,"context_line":"        parser.add_argument("},{"line_number":109,"context_line":"            \u0027--l7-parameters\u0027,"},{"line_number":110,"context_line":"            help\u003d_(\u0027Dictionary of L7-parameters. Currently, no value is \u0027"},{"line_number":111,"context_line":"                   \u0027supported for this option.\u0027))"},{"line_number":112,"context_line":"        return parser"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_7d2c7dab","line":110,"range":{"start_line":110,"start_character":34,"end_line":110,"end_character":47},"updated":"2017-06-15 01:05:41.000000000","message":"-\u003e \"L7 parameters\u0027 (hyphen looks unnecessary)","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        )"},{"line_number":134,"context_line":"        return parser"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def take_action(self, parsed_args):"},{"line_number":137,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":138,"context_line":"        fc_id \u003d _get_id(client, parsed_args.flow_classifier, resource)"},{"line_number":139,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_97f79ff6","line":136,"updated":"2017-06-15 01:05:41.000000000","message":"Most OSC commands support deleting multiple resources at one command like [1]. Could you add TODO here?\n\n[1] https://docs.openstack.org/developer/python-openstackclient/command-objects/network.html#network-delete","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":310,"context_line":"        except ValueError:"},{"line_number":311,"context_line":"            message \u003d (_(\"Protocol port value %s must be an integer \""},{"line_number":312,"context_line":"                         \"or integer:integer.\") % port_val)"},{"line_number":313,"context_line":"            raise nc_exc.NeutronClientException(message\u003dmessage)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"def _get_id(client, id_or_name, resource):"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_28012106","line":313,"range":{"start_line":313,"start_character":18,"end_line":313,"end_character":47},"updated":"2017-06-15 01:05:41.000000000","message":"This is a part of CLI implementation. I think exceptions.CommandError should be raised.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"}],"neutronclient/osc/v2/sfc/sfc_port_chain.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":55,"context_line":"            dest\u003d\u0027flow_classifiers\u0027,"},{"line_number":56,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":57,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID).\u0027"},{"line_number":58,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--chain-parameters\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_07c4b73d","line":57,"updated":"2017-02-08 19:41:17.000000000","message":"add a whitespace here","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"70006e535dd69e41792d77e19730c8e31289fd31","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":55,"context_line":"            dest\u003d\u0027flow_classifiers\u0027,"},{"line_number":56,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":57,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID).\u0027"},{"line_number":58,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":59,"context_line":"        parser.add_argument("},{"line_number":60,"context_line":"            \u0027--chain-parameters\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_8f118c54","line":57,"in_reply_to":"1a430d35_07c4b73d","updated":"2017-02-09 05:43:53.000000000","message":"will add","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":107,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":108,"context_line":"            help\u003d_(\u0027Port pair group (name or ID). \u0027"},{"line_number":109,"context_line":"                    \u0027This option can be repeated\u0027))"},{"line_number":110,"context_line":"        parser.add_argument("},{"line_number":111,"context_line":"            \u0027port_chain\u0027,"},{"line_number":112,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_87e6e7e5","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":20},"updated":"2017-02-08 19:41:17.000000000","message":"seems unaligned","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"70006e535dd69e41792d77e19730c8e31289fd31","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":107,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":108,"context_line":"            help\u003d_(\u0027Port pair group (name or ID). \u0027"},{"line_number":109,"context_line":"                    \u0027This option can be repeated\u0027))"},{"line_number":110,"context_line":"        parser.add_argument("},{"line_number":111,"context_line":"            \u0027port_chain\u0027,"},{"line_number":112,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_4f0b2424","line":109,"range":{"start_line":109,"start_character":0,"end_line":109,"end_character":20},"in_reply_to":"1a430d35_87e6e7e5","updated":"2017-02-09 05:43:53.000000000","message":"will check","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            help\u003d_(\u0027Port pair group (name or ID). \u0027"},{"line_number":109,"context_line":"                    \u0027This option can be repeated\u0027))"},{"line_number":110,"context_line":"        parser.add_argument("},{"line_number":111,"context_line":"            \u0027port_chain\u0027,"},{"line_number":112,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"},{"line_number":113,"context_line":"            help\u003d_(\"Port chain to modify (name or ID)\"))"},{"line_number":114,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_07dbd71b","line":111,"range":{"start_line":111,"start_character":13,"end_line":111,"end_character":23},"updated":"2017-02-08 19:41:17.000000000","message":"port-chain","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":135,"context_line":"    def get_parser(self, prog_name):"},{"line_number":136,"context_line":"        parser \u003d super(DeletePortChain, self).get_parser(prog_name)"},{"line_number":137,"context_line":"        parser.add_argument("},{"line_number":138,"context_line":"            \u0027port_chain\u0027,"},{"line_number":139,"context_line":"            metavar\u003d\"\u003cport-chain\u003e\","},{"line_number":140,"context_line":"            help\u003d_(\"Port chain to delete (name or ID)\")"},{"line_number":141,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_a7004367","line":138,"range":{"start_line":138,"start_character":13,"end_line":138,"end_character":23},"updated":"2017-02-08 19:41:17.000000000","message":"port-chain","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":188,"context_line":"    def get_parser(self, prog_name):"},{"line_number":189,"context_line":"        parser \u003d super(ShowPortChain, self).get_parser(prog_name)"},{"line_number":190,"context_line":"        parser.add_argument("},{"line_number":191,"context_line":"            \u0027port_chain\u0027,"},{"line_number":192,"context_line":"            metavar\u003d\"\u003cport-chain\u003e\","},{"line_number":193,"context_line":"            help\u003d_(\"Port chain to display (name or ID)\")"},{"line_number":194,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_8734274a","line":191,"range":{"start_line":191,"start_character":13,"end_line":191,"end_character":23},"updated":"2017-02-08 19:41:17.000000000","message":"port-chain","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        return columns, data"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"def _get_columns(item):"},{"line_number":207,"context_line":"    return tuple(sorted(list(item.keys())))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_870b477c","line":206,"range":{"start_line":206,"start_character":4,"end_line":206,"end_character":16},"updated":"2017-02-08 19:41:17.000000000","message":"there is a method in neutronclient/osc/utils.py for get_columns. Perhaps that can be used here and in other modules where you do a get_columns","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"10a9519ce31072c2d42454c15e0974efaf3f486e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        return columns, data"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"def _get_columns(item):"},{"line_number":207,"context_line":"    return tuple(sorted(list(item.keys())))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa31d9ce_9c7b4e29","line":206,"range":{"start_line":206,"start_character":4,"end_line":206,"end_character":16},"updated":"2017-02-17 04:49:45.000000000","message":"have you considered method in neutronclient/osc/utils.py for get_columns?","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"a9fe232abab2e6bb8dede1ea7f391403e988ec8e","unresolved":false,"context_lines":[{"line_number":203,"context_line":"        return columns, data"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"def _get_columns(item):"},{"line_number":207,"context_line":"    return tuple(sorted(list(item.keys())))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa31d9ce_6ea095a6","line":206,"range":{"start_line":206,"start_character":4,"end_line":206,"end_character":16},"in_reply_to":"fa31d9ce_9c7b4e29","updated":"2017-02-17 10:32:25.000000000","message":"yes, that can be used. I may check and update","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \u0027--description\u0027,"},{"line_number":55,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":56,"context_line":"            help\u003d_(\u0027Description for the port chain\u0027))"},{"line_number":57,"context_line":"        parser.add_argument("},{"line_number":58,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":59,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":60,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":61,"context_line":"            required\u003dTrue,"},{"line_number":62,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":63,"context_line":"            help\u003d_(\u0027Port pair group (name or ID). \u0027"},{"line_number":64,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--flow-classifier\u0027,"},{"line_number":67,"context_line":"            default\u003d[],"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f0f672d7","line":64,"range":{"start_line":57,"start_character":8,"end_line":64,"end_character":50},"updated":"2017-04-05 07:01:18.000000000","message":"Can you move this option to the last?\n\nAt now, in the help message, we see optional parameters, required parameter and optional parameters again.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            \u0027--description\u0027,"},{"line_number":55,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":56,"context_line":"            help\u003d_(\u0027Description for the port chain\u0027))"},{"line_number":57,"context_line":"        parser.add_argument("},{"line_number":58,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":59,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":60,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":61,"context_line":"            required\u003dTrue,"},{"line_number":62,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":63,"context_line":"            help\u003d_(\u0027Port pair group (name or ID). \u0027"},{"line_number":64,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--flow-classifier\u0027,"},{"line_number":67,"context_line":"            default\u003d[],"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_96bdded9","line":64,"range":{"start_line":57,"start_character":8,"end_line":64,"end_character":50},"in_reply_to":"dfeb2761_f0f672d7","updated":"2017-04-05 09:57:33.000000000","message":"okay","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class DeleteSfcPortChain(command.Command):"},{"line_number":93,"context_line":"    _description \u003d _(\"Delete a given port chain\")"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def get_parser(self, prog_name):"},{"line_number":96,"context_line":"        parser \u003d super(DeleteSfcPortChain, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_7034a293","line":93,"range":{"start_line":93,"start_character":29,"end_line":93,"end_character":47},"updated":"2017-04-05 07:01:18.000000000","message":"-\u003e Delete port chain(s)","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class DeleteSfcPortChain(command.Command):"},{"line_number":93,"context_line":"    _description \u003d _(\"Delete a given port chain\")"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def get_parser(self, prog_name):"},{"line_number":96,"context_line":"        parser \u003d super(DeleteSfcPortChain, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f6cd4a85","line":93,"range":{"start_line":93,"start_character":29,"end_line":93,"end_character":47},"in_reply_to":"dfeb2761_7034a293","updated":"2017-04-05 09:57:33.000000000","message":"will raise separate patch","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            \u0027--description\u0027,"},{"line_number":151,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":152,"context_line":"            help\u003d_(\u0027Description for the port chain\u0027))"},{"line_number":153,"context_line":"        fw_args \u003d parser.add_mutually_exclusive_group()"},{"line_number":154,"context_line":"        fw_args.add_argument("},{"line_number":155,"context_line":"            \u0027--flow-classifier\u0027,"},{"line_number":156,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":157,"context_line":"            dest\u003d\u0027flow_classifiers\u0027,"},{"line_number":158,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":159,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID). \u0027"},{"line_number":160,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":161,"context_line":"        fw_args.add_argument("},{"line_number":162,"context_line":"            \u0027--no-flow-classifier\u0027,"},{"line_number":163,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":164,"context_line":"            help\u003d_(\u0027Associate no flow classifier with the port chain\u0027))"},{"line_number":165,"context_line":"        parser.add_argument("},{"line_number":166,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":167,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_506abeec","line":164,"range":{"start_line":153,"start_character":8,"end_line":164,"end_character":71},"updated":"2017-04-05 07:01:18.000000000","message":"In my understanding, we can replace a set of flow classifiers into a completely other set of flow classifiers. In such case, according to the OSC convention, we specify \"--no-flow-classifier --flow-classifier A --flow-classifier B\". Good example is \u0027router show --route\u0027 option [1]\n\n--flow-classifer option means to ADD a new flow classifier to a existing set of classifiers. When we replace an existing set, both --no-flow-classifier and --flow-classifier need to be specified.\n\nFrom the similarity of router show --route, we need to define UnsetSfcFlowClassifier command --flow-classifier option to remove a specifi flow classifier from the port chain.\n\n[1] https://docs.openstack.org/developer/python-openstackclient/command-objects/router.html#cmdoption-router-set-route","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"992ac6495ccb0f63aa8e067a46ae5fe850b0713b","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            \u0027--description\u0027,"},{"line_number":151,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":152,"context_line":"            help\u003d_(\u0027Description for the port chain\u0027))"},{"line_number":153,"context_line":"        fw_args \u003d parser.add_mutually_exclusive_group()"},{"line_number":154,"context_line":"        fw_args.add_argument("},{"line_number":155,"context_line":"            \u0027--flow-classifier\u0027,"},{"line_number":156,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":157,"context_line":"            dest\u003d\u0027flow_classifiers\u0027,"},{"line_number":158,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":159,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID). \u0027"},{"line_number":160,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":161,"context_line":"        fw_args.add_argument("},{"line_number":162,"context_line":"            \u0027--no-flow-classifier\u0027,"},{"line_number":163,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":164,"context_line":"            help\u003d_(\u0027Associate no flow classifier with the port chain\u0027))"},{"line_number":165,"context_line":"        parser.add_argument("},{"line_number":166,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":167,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_6f9cb4bf","line":164,"range":{"start_line":153,"start_character":8,"end_line":164,"end_character":71},"in_reply_to":"dfeb2761_506abeec","updated":"2017-04-05 10:29:07.000000000","message":"Akihiro,  IMO there is actually no difference if we update flow-classifier from [fc1, fc2] to [fc3,fc4] by parsing simply as[fc3, fc4] or [--no-flow-classifier , fc3, fc4] right ? \n\nhere the --no-flow-classifier flag  is to make the port-chain passive mode , means no traffic will flow to chain \n\nI just tried to stick to existing cli usage, so It\u0027s easy for the user .\n\nPlease suggest it should be okay or not?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"17bed3620e67090a90f38d37c75953f0cf5f2eb7","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            \u0027--description\u0027,"},{"line_number":151,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":152,"context_line":"            help\u003d_(\u0027Description for the port chain\u0027))"},{"line_number":153,"context_line":"        fw_args \u003d parser.add_mutually_exclusive_group()"},{"line_number":154,"context_line":"        fw_args.add_argument("},{"line_number":155,"context_line":"            \u0027--flow-classifier\u0027,"},{"line_number":156,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":157,"context_line":"            dest\u003d\u0027flow_classifiers\u0027,"},{"line_number":158,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":159,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID). \u0027"},{"line_number":160,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":161,"context_line":"        fw_args.add_argument("},{"line_number":162,"context_line":"            \u0027--no-flow-classifier\u0027,"},{"line_number":163,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":164,"context_line":"            help\u003d_(\u0027Associate no flow classifier with the port chain\u0027))"},{"line_number":165,"context_line":"        parser.add_argument("},{"line_number":166,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":167,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"bff0334d_03037044","line":164,"range":{"start_line":153,"start_character":8,"end_line":164,"end_character":71},"in_reply_to":"dfeb2761_6f9cb4bf","updated":"2017-04-05 13:39:24.000000000","message":"Assume we have [fc1, fc2] on port-chain1. What happens if a user specify --flow-classifier fc3? In OSC context, the user expects the new associated flow classifiers are [fc1, fc2, fc3]. In the previous world which neutron folks are familiar with, the new associated flow classifiers would be [fc3]. That is my point and I would like to be consistent.\n\npassing \"--flow-classifier fc3\" will update the FC to [fc1, fc2, fc3],\npassing \"--no-flow-classifier --flow-classifier fc3\" will update the FC to [fc3], and\npassing \"--no-flow-classifier\" will update the FC to [].\n\nIt is different from API behavior, but the consistency in CLI world is also important.\n\nDoes it answer to you?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            \u0027--no-flow-classifier\u0027,"},{"line_number":163,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":164,"context_line":"            help\u003d_(\u0027Associate no flow classifier with the port chain\u0027))"},{"line_number":165,"context_line":"        parser.add_argument("},{"line_number":166,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":167,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":168,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":169,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":170,"context_line":"            help\u003d_(\u0027Port pair group (name or ID). \u0027"},{"line_number":171,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":172,"context_line":"        parser.add_argument("},{"line_number":173,"context_line":"            \u0027port_chain\u0027,"},{"line_number":174,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_904de69b","line":171,"range":{"start_line":165,"start_character":8,"end_line":171,"end_character":50},"updated":"2017-04-05 07:01:18.000000000","message":"I am wondering the same logic as above can be applied to --port-pair-group. Only difference is that a port chain requires at least one port-pair-group, right?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":156,"context_line":"            dest\u003d\u0027flow_classifiers\u0027,"},{"line_number":157,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":158,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID). \u0027"},{"line_number":159,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--no-flow-classifier\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_939d7d5b","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":35},"updated":"2017-04-14 19:06:19.000000000","message":"I think \"Add flow classifier\" is more clear.","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            metavar\u003d\u0027\u003cflow-classifier\u003e\u0027,"},{"line_number":156,"context_line":"            dest\u003d\u0027flow_classifiers\u0027,"},{"line_number":157,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":158,"context_line":"            help\u003d_(\u0027Flow classifier (name or ID). \u0027"},{"line_number":159,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--no-flow-classifier\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_7f7df9af","line":158,"range":{"start_line":158,"start_character":20,"end_line":158,"end_character":35},"in_reply_to":"7ffa3b31_939d7d5b","updated":"2017-04-17 13:33:13.000000000","message":"ok","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b4aa693982d79bbcdac292388bc27b3ca4f87f1e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":163,"context_line":"            help\u003d_(\u0027Associate no flow classifier with the port chain\u0027))"},{"line_number":164,"context_line":"        parser.add_argument("},{"line_number":165,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":166,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":167,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":168,"context_line":"            action\u003d\u0027append\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_f32a81e5","line":165,"range":{"start_line":165,"start_character":12,"end_line":165,"end_character":32},"updated":"2017-04-14 19:14:02.000000000","message":"One question: Do we need ----clear-port-pair-group to replace existing port pair group completely?\n\nAssume a port chain is associated with port group [A] and we want to replace the existing port pair group with [B]. At now, we first run \u0027set --port-pair-group B\u0027 and then \u0027unset --port-pair-group A\u0027. I wonder if \u0027set --port-pair-group B --clear-port-pair-group\u0027 is useful. (--no-port-pair-group seems not to fit to this case since at least one port pair group is required).\n\nI am not sure it is useful. Thought?","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":162,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":163,"context_line":"            help\u003d_(\u0027Associate no flow classifier with the port chain\u0027))"},{"line_number":164,"context_line":"        parser.add_argument("},{"line_number":165,"context_line":"            \u0027--port-pair-group\u0027,"},{"line_number":166,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":167,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":168,"context_line":"            action\u003d\u0027append\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_d9c2ed85","line":165,"range":{"start_line":165,"start_character":12,"end_line":165,"end_character":32},"in_reply_to":"7ffa3b31_f32a81e5","updated":"2017-04-17 13:33:13.000000000","message":"It may be useful to add -clear-port-pair-group  with check to make sure  one port-pair-group value followed by","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":167,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":168,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":169,"context_line":"            help\u003d_(\u0027Port pair group (name or ID). \u0027"},{"line_number":170,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":171,"context_line":"        parser.add_argument("},{"line_number":172,"context_line":"            \u0027port_chain\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_f3b721d8","line":169,"range":{"start_line":169,"start_character":20,"end_line":169,"end_character":35},"updated":"2017-04-14 19:06:19.000000000","message":"I think \"Add port pair group\u0027 is better.","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":167,"context_line":"            dest\u003d\u0027port_pair_groups\u0027,"},{"line_number":168,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":169,"context_line":"            help\u003d_(\u0027Port pair group (name or ID). \u0027"},{"line_number":170,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":171,"context_line":"        parser.add_argument("},{"line_number":172,"context_line":"            \u0027port_chain\u0027,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_bf0a6123","line":169,"range":{"start_line":169,"start_character":20,"end_line":169,"end_character":35},"in_reply_to":"7ffa3b31_f3b721d8","updated":"2017-04-17 13:33:13.000000000","message":"ok","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def take_action(self, parsed_args):"},{"line_number":178,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":179,"context_line":"        pc_id \u003d _get_id(client, parsed_args.port_chain, resource)"},{"line_number":180,"context_line":"        if parsed_args.no_flow_classifier:"},{"line_number":181,"context_line":"            parsed_args[\u0027flow_classifiers\u0027] \u003d []"},{"line_number":182,"context_line":"        if parsed_args.flow_classifiers:"},{"line_number":183,"context_line":"            existing \u003d client.find_resource("},{"line_number":184,"context_line":"                resource, parsed_args.port_chain,"},{"line_number":185,"context_line":"                cmd_resource\u003d\u0027sfc_port_chain\u0027)[\u0027flow_classifiers\u0027]"},{"line_number":186,"context_line":"            for f in set(parsed_args.flow_classifiers):"},{"line_number":187,"context_line":"                existing.append(_get_id(client, f, \u0027flow_classifier\u0027))"},{"line_number":188,"context_line":"            parsed_args[\u0027flow_classifiers\u0027] \u003d list(set(existing))"},{"line_number":189,"context_line":"        if parsed_args.port_pair_groups:"},{"line_number":190,"context_line":"            existing_ppg \u003d client.find_resource("},{"line_number":191,"context_line":"                resource, parsed_args.port_chain,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_737d511b","line":188,"range":{"start_line":180,"start_character":8,"end_line":188,"end_character":65},"updated":"2017-04-14 19:06:19.000000000","message":"See my comment in sfc_port_pair_group. We need to consider a case with both --no-flow-classifier and --flow-classifier.","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":177,"context_line":"    def take_action(self, parsed_args):"},{"line_number":178,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":179,"context_line":"        pc_id \u003d _get_id(client, parsed_args.port_chain, resource)"},{"line_number":180,"context_line":"        if parsed_args.no_flow_classifier:"},{"line_number":181,"context_line":"            parsed_args[\u0027flow_classifiers\u0027] \u003d []"},{"line_number":182,"context_line":"        if parsed_args.flow_classifiers:"},{"line_number":183,"context_line":"            existing \u003d client.find_resource("},{"line_number":184,"context_line":"                resource, parsed_args.port_chain,"},{"line_number":185,"context_line":"                cmd_resource\u003d\u0027sfc_port_chain\u0027)[\u0027flow_classifiers\u0027]"},{"line_number":186,"context_line":"            for f in set(parsed_args.flow_classifiers):"},{"line_number":187,"context_line":"                existing.append(_get_id(client, f, \u0027flow_classifier\u0027))"},{"line_number":188,"context_line":"            parsed_args[\u0027flow_classifiers\u0027] \u003d list(set(existing))"},{"line_number":189,"context_line":"        if parsed_args.port_pair_groups:"},{"line_number":190,"context_line":"            existing_ppg \u003d client.find_resource("},{"line_number":191,"context_line":"                resource, parsed_args.port_chain,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_9f07a51d","line":188,"range":{"start_line":180,"start_character":8,"end_line":188,"end_character":65},"in_reply_to":"7ffa3b31_737d511b","updated":"2017-04-17 13:33:13.000000000","message":"ok","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            help\u003d_(\u0027Remove flow classifier(s) from the port chain \u0027"},{"line_number":244,"context_line":"                   \u0027(name or ID). This option can be repeated\u0027))"},{"line_number":245,"context_line":"        port_chain.add_argument("},{"line_number":246,"context_line":"            \u0027--no-flow-classifier\u0027,"},{"line_number":247,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":248,"context_line":"            help\u003d_(\u0027Remove all flow classifiers from the port chain\u0027))"},{"line_number":249,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_331b491c","line":246,"range":{"start_line":246,"start_character":15,"end_line":246,"end_character":17},"updated":"2017-04-14 19:06:19.000000000","message":"no -\u003e all","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":243,"context_line":"            help\u003d_(\u0027Remove flow classifier(s) from the port chain \u0027"},{"line_number":244,"context_line":"                   \u0027(name or ID). This option can be repeated\u0027))"},{"line_number":245,"context_line":"        port_chain.add_argument("},{"line_number":246,"context_line":"            \u0027--no-flow-classifier\u0027,"},{"line_number":247,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":248,"context_line":"            help\u003d_(\u0027Remove all flow classifiers from the port chain\u0027))"},{"line_number":249,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_4a04b915","line":246,"range":{"start_line":246,"start_character":15,"end_line":246,"end_character":17},"in_reply_to":"7ffa3b31_331b491c","updated":"2017-04-17 13:33:13.000000000","message":"will modify","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            existing \u003d client.find_resource("},{"line_number":263,"context_line":"                resource, parsed_args.port_pair_groups,"},{"line_number":264,"context_line":"                cmd_resource\u003d\u0027sfc_port_chain\u0027)[\u0027flow_classifiers\u0027]"},{"line_number":265,"context_line":"            removed \u003d []"},{"line_number":266,"context_line":"            for f in set(parsed_args.port_pair):"},{"line_number":267,"context_line":"                removed.append(_get_id(client, f, \u0027flow_classifier\u0027))"},{"line_number":268,"context_line":"            attrs[\u0027flow_classifiers\u0027] \u003d [e for e in existing if e not in removed]"},{"line_number":269,"context_line":"        if parsed_args.all_port_pair:"},{"line_number":270,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d []"},{"line_number":271,"context_line":"        if parsed_args.port_pair_groups:"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_139bad72","line":268,"range":{"start_line":265,"start_character":12,"end_line":268,"end_character":81},"updated":"2017-04-14 19:06:19.000000000","message":"nit: Some comment for sfc_port_pair_group.py","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":262,"context_line":"            existing \u003d client.find_resource("},{"line_number":263,"context_line":"                resource, parsed_args.port_pair_groups,"},{"line_number":264,"context_line":"                cmd_resource\u003d\u0027sfc_port_chain\u0027)[\u0027flow_classifiers\u0027]"},{"line_number":265,"context_line":"            removed \u003d []"},{"line_number":266,"context_line":"            for f in set(parsed_args.port_pair):"},{"line_number":267,"context_line":"                removed.append(_get_id(client, f, \u0027flow_classifier\u0027))"},{"line_number":268,"context_line":"            attrs[\u0027flow_classifiers\u0027] \u003d [e for e in existing if e not in removed]"},{"line_number":269,"context_line":"        if parsed_args.all_port_pair:"},{"line_number":270,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d []"},{"line_number":271,"context_line":"        if parsed_args.port_pair_groups:"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_2a096d2b","line":268,"range":{"start_line":265,"start_character":12,"end_line":268,"end_character":81},"in_reply_to":"7ffa3b31_139bad72","updated":"2017-04-17 13:33:13.000000000","message":"ok","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            existing_ppg \u003d client.find_resource("},{"line_number":273,"context_line":"                resource, parsed_args.port_pair_groups,"},{"line_number":274,"context_line":"                cmd_resource\u003d\u0027sfc_port_chain\u0027)[\u0027port_pair_groups\u0027]"},{"line_number":275,"context_line":"            removed \u003d []"},{"line_number":276,"context_line":"            for f in set(parsed_args.port_pair_groups):"},{"line_number":277,"context_line":"                removed.append(_get_id(client, f, \u0027port_pair_group\u0027))"},{"line_number":278,"context_line":"            attrs[\u0027port_pair_groups\u0027] \u003d [e for e in existing_ppg if e not in removed]"},{"line_number":279,"context_line":"        return attrs"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_d38e652d","line":278,"range":{"start_line":275,"start_character":12,"end_line":278,"end_character":85},"updated":"2017-04-14 19:06:19.000000000","message":"nit: Some comment for sfc_port_pair_group.py","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            existing_ppg \u003d client.find_resource("},{"line_number":273,"context_line":"                resource, parsed_args.port_pair_groups,"},{"line_number":274,"context_line":"                cmd_resource\u003d\u0027sfc_port_chain\u0027)[\u0027port_pair_groups\u0027]"},{"line_number":275,"context_line":"            removed \u003d []"},{"line_number":276,"context_line":"            for f in set(parsed_args.port_pair_groups):"},{"line_number":277,"context_line":"                removed.append(_get_id(client, f, \u0027port_pair_group\u0027))"},{"line_number":278,"context_line":"            attrs[\u0027port_pair_groups\u0027] \u003d [e for e in existing_ppg if e not in removed]"},{"line_number":279,"context_line":"        return attrs"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_0a0eb133","line":278,"range":{"start_line":275,"start_character":12,"end_line":278,"end_character":85},"in_reply_to":"7ffa3b31_d38e652d","updated":"2017-04-17 13:33:13.000000000","message":"ok","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"870b8193626fb59f5466a3d253072658a0f10753","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        headers, columns \u003d nc_osc_utils.get_column_definitions("},{"line_number":133,"context_line":"            _attr_map, long_listing\u003dparsed_args.long)"},{"line_number":134,"context_line":"        return (headers,"},{"line_number":135,"context_line":"                (utils.get_dict_properties("},{"line_number":136,"context_line":"                    s, columns,"},{"line_number":137,"context_line":"                ) for s in data[\u0027port_chains\u0027]))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"class SetSfcPortChain(command.Command):"}],"source_content_type":"text/x-python","patch_set":31,"id":"5ff73747_cae989b7","line":137,"range":{"start_line":135,"start_character":42,"end_line":137,"end_character":17},"updated":"2017-04-27 12:12:22.000000000","message":"this looks like a odd indent.\n\n (utils.get_dict_properties(s, columns)\n  for s in data[...]))","commit_id":"ff3f0b47cceadd88a9f0490826a7deda209768c9"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"7a2019f26d240cbd1b993651ccbed869a827965f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            dest\u003d\u0027flow_classifiers\u0027,"},{"line_number":62,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":63,"context_line":"            help\u003d_(\u0027Add flow classifier (name or ID). \u0027"},{"line_number":64,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--chain-parameters\u0027,"},{"line_number":67,"context_line":"            metavar\u003d\u0027\u003ccorrelation\u003dcorrelation_type, symmetric\u003dboolean_type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"df140735_2b3264a8","line":64,"range":{"start_line":64,"start_character":47,"end_line":64,"end_character":48},"updated":"2017-06-01 08:44:51.000000000","message":"Need a period here Because this help message included more than 1 sentence. Apply for all remaining in this file","commit_id":"c22acd1e113e5fff6fadd2e8db91d0bf736707b7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--chain-parameters\u0027,"},{"line_number":67,"context_line":"            metavar\u003d\u0027\u003ccorrelation\u003dcorrelation_type, symmetric\u003dboolean_type\u003e\u0027,"},{"line_number":68,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":69,"context_line":"            optional_keys\u003d[\u0027correlation\u0027, \u0027symmetric\u0027],"},{"line_number":70,"context_line":"            help\u003d_(\u0027Dictionary of chain parameters. Supports \u0027"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_1d6a29ed","line":67,"range":{"start_line":67,"start_character":21,"end_line":67,"end_character":75},"updated":"2017-06-15 01:05:41.000000000","message":"Nit:\n\n correlation\u003d\u003ccorrelation-type\u003e,symmetric\u003d\u003cbootlean\u003e\u0027\n\n- \u003c\u003e is used for a value specified by a user\n- a space before \u0027symmetric\u0027 needs to be removed. Otherwise, the argument is not interpreted as a single parameter.\n- OSC use hyphen as a delimiter","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94652445e1c4da80437a9086fbc0ecd38c388d48","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            help\u003d_(\u0027Add port pair group (name or ID). \u0027"},{"line_number":169,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain. \u0027"},{"line_number":174,"context_line":"                   \u0027At least one port pair group must be specified.\u0027))"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_87decdd7","line":171,"range":{"start_line":171,"start_character":31,"end_line":171,"end_character":36},"updated":"2017-06-15 16:18:10.000000000","message":"groups?","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"d07ad637176c9930ae6c553fc6d4b8d6a28d7653","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            help\u003d_(\u0027Add port pair group (name or ID). \u0027"},{"line_number":169,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain. \u0027"},{"line_number":174,"context_line":"                   \u0027At least one port pair group must be specified.\u0027))"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f1d235d_aa72f4e1","line":171,"range":{"start_line":171,"start_character":31,"end_line":171,"end_character":36},"in_reply_to":"3f1d235d_6640e536","updated":"2017-07-03 15:18:51.000000000","message":"--no-port-pair-group is kinda intuitive to read, even with the complex 2nd example on your comment at L174. But --clear-port-pair-group is very confusing, why is it being used instead of --no-port-pair-group Mohan/Akihiro?","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c4c645d74fb5dc7467ad972bba847cc329dc2397","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            help\u003d_(\u0027Add port pair group (name or ID). \u0027"},{"line_number":169,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain. \u0027"},{"line_number":174,"context_line":"                   \u0027At least one port pair group must be specified.\u0027))"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f1d235d_43cf8255","line":171,"range":{"start_line":171,"start_character":31,"end_line":171,"end_character":36},"in_reply_to":"3f1d235d_aa72f4e1","updated":"2017-07-05 17:23:06.000000000","message":"I am okay with either of --no-port-pair-group and --clear-port-pair-group. IIRC, the reason that --clear-port-pair-group was introduced is because in case of port-pair-group at least one PPG needs to be associated.\n\nIt sounds good to require --port-pair-group when --no-port-pair-group is specified.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dc6479bbf445e837795b74055fc58040faa5662b","unresolved":false,"context_lines":[{"line_number":168,"context_line":"            help\u003d_(\u0027Add port pair group (name or ID). \u0027"},{"line_number":169,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":170,"context_line":"        parser.add_argument("},{"line_number":171,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain. \u0027"},{"line_number":174,"context_line":"                   \u0027At least one port pair group must be specified.\u0027))"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f1d235d_6640e536","line":171,"range":{"start_line":171,"start_character":31,"end_line":171,"end_character":36},"in_reply_to":"7f231b9d_87decdd7","updated":"2017-06-29 19:08:15.000000000","message":"This just follows the convention in OSC like \u0027--no-\u003csingular form\u003e\u0027.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain. \u0027"},{"line_number":174,"context_line":"                   \u0027At least one port pair group must be specified.\u0027))"},{"line_number":175,"context_line":"        parser.add_argument("},{"line_number":176,"context_line":"            \u0027port_chain\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_3d4e0597","line":174,"range":{"start_line":174,"start_character":20,"end_line":174,"end_character":65},"updated":"2017-06-15 01:05:41.000000000","message":"How about the following?\n\n  At least one --port-pair-group must be specified together.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dc6479bbf445e837795b74055fc58040faa5662b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain. \u0027"},{"line_number":174,"context_line":"                   \u0027At least one port pair group must be specified.\u0027))"},{"line_number":175,"context_line":"        parser.add_argument("},{"line_number":176,"context_line":"            \u0027port_chain\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f1d235d_26354ddb","line":174,"range":{"start_line":174,"start_character":20,"end_line":174,"end_character":65},"in_reply_to":"7f231b9d_07a19d46","updated":"2017-06-29 19:08:15.000000000","message":"When a port chain has PPGs [A, B] and \u0027port chain set --port-pair-group C\u0027 is called, the resulting PPGs will [A, B, C].\n\nWhen a port chain has PPGs [A, B] and \u0027port chain set --port-pair-group C --clear-port-pair-group\u0027 is called, the resulting PPGs will [C].\n\nThe guideline of OSC is [1] and an example is [2]. In this example, openstack port set p1 --security-group sg2 --security-group sg3 will add sg2 and sg3 to an existing security groups.\n\n- [1] https://docs.openstack.org/python-openstackclient/latest/contributor/command-options.html#options-with-multiple-values\n- [2] https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/port.html#port-set","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94652445e1c4da80437a9086fbc0ecd38c388d48","unresolved":false,"context_lines":[{"line_number":171,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":172,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":173,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain. \u0027"},{"line_number":174,"context_line":"                   \u0027At least one port pair group must be specified.\u0027))"},{"line_number":175,"context_line":"        parser.add_argument("},{"line_number":176,"context_line":"            \u0027port_chain\u0027,"},{"line_number":177,"context_line":"            metavar\u003d\u0027\u003cport-chain\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_07a19d46","line":174,"range":{"start_line":174,"start_character":20,"end_line":174,"end_character":65},"in_reply_to":"7f231b9d_3d4e0597","updated":"2017-06-15 16:18:10.000000000","message":"So what happens with this OSC CLI when I specify:\nport chain set --port-pair-group ppgx\n\nwhen the port chain already has a set of port pair groups? Does ppgx get added to the existing list?","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ee732a19cff9c7c6972ecdc2c60109ca25731513","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            help\u003d_(\u0027Add port pair group (name or ID). \u0027"},{"line_number":170,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":171,"context_line":"        parser.add_argument("},{"line_number":172,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":173,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":174,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain.\u0027"},{"line_number":175,"context_line":"                   \u0027At least one --port-pair-group must be specified \u0027"}],"source_content_type":"text/x-python","patch_set":41,"id":"1f1a1f67_4b5bc02d","line":172,"updated":"2017-07-12 13:47:55.000000000","message":"Did we agree to use --no-port-pair-group in the discussion in patch set 40?","commit_id":"d205f4488323077db8a20694b877737b1a7822e0"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"6ec65eff43e301429b10861e940fdd383e968b96","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            help\u003d_(\u0027Add port pair group (name or ID). \u0027"},{"line_number":170,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":171,"context_line":"        parser.add_argument("},{"line_number":172,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":173,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":174,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain.\u0027"},{"line_number":175,"context_line":"                   \u0027At least one --port-pair-group must be specified \u0027"}],"source_content_type":"text/x-python","patch_set":41,"id":"1f1a1f67_54eb58af","line":172,"in_reply_to":"1f1a1f67_4b5bc02d","updated":"2017-07-12 17:31:03.000000000","message":"To confirm my position, my preference is equally distributed between --clear-port-pair-groups (plural) or --no-port-pair-group (singular) for this case, as --clear-port-pair-group might confuse users not familiar with the networking-sfc CLI, or induce them to think that this somehow clears one specific port pair group. I won\u0027t -1 based on this though.","commit_id":"d205f4488323077db8a20694b877737b1a7822e0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6a4be338861f86a51304bf0ba3d416de17cadb6b","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            help\u003d_(\u0027Add port pair group (name or ID). \u0027"},{"line_number":170,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":171,"context_line":"        parser.add_argument("},{"line_number":172,"context_line":"            \u0027--clear-port-pair-group\u0027,"},{"line_number":173,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":174,"context_line":"            help\u003d_(\u0027Clear associated port pair group from the port chain.\u0027"},{"line_number":175,"context_line":"                   \u0027At least one --port-pair-group must be specified \u0027"}],"source_content_type":"text/x-python","patch_set":41,"id":"1f1a1f67_f79ffcb1","line":172,"in_reply_to":"1f1a1f67_54eb58af","updated":"2017-07-12 23:59:32.000000000","message":"I think I got your point.\nWhen we use \u0027clear\u0027, it clears existing port pair groups (plural).\nIf we use \u0027no\u0027, it defines a new state with no port pair group.\n\n--no-\u003csingular\u003e is used everywhere in OSC CLI, so my vote is --no-port-pair-group. (I am also okay with --clear-port-pair-groups.)","commit_id":"d205f4488323077db8a20694b877737b1a7822e0"}],"neutronclient/osc/v2/sfc/sfc_port_pair.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":27,"context_line":"resource \u003d \u0027port_pair\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class CreatePortPair(command.ShowOne):"},{"line_number":31,"context_line":"    _description \u003d _(\"Create a port pair\")"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_e7240b0e","line":30,"range":{"start_line":30,"start_character":6,"end_line":30,"end_character":20},"updated":"2017-02-08 19:41:17.000000000","message":"SfcPortPair to match the module name.. same for other methods","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":88,"context_line":"            help\u003d_(\u0027Description for the port pair\u0027))"},{"line_number":89,"context_line":"        parser.add_argument("},{"line_number":90,"context_line":"            \u0027port_pair\u0027,"},{"line_number":91,"context_line":"            metavar\u003d\u0027\u003cport-pair\u003e\u0027,"},{"line_number":92,"context_line":"            help\u003d_(\"Port pair to modify (name or ID)\")"},{"line_number":93,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_27729311","line":90,"range":{"start_line":90,"start_character":13,"end_line":90,"end_character":22},"updated":"2017-02-08 19:41:17.000000000","message":"port-pair","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    def get_parser(self, prog_name):"},{"line_number":114,"context_line":"        parser \u003d super(DeletePortPair, self).get_parser(prog_name)"},{"line_number":115,"context_line":"        parser.add_argument("},{"line_number":116,"context_line":"            \u0027port_pair\u0027,"},{"line_number":117,"context_line":"            metavar\u003d\"\u003cport-pair\u003e\","},{"line_number":118,"context_line":"            help\u003d_(\"Port pair to delete (name or ID)\")"},{"line_number":119,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_a75cc37d","line":116,"range":{"start_line":116,"start_character":13,"end_line":116,"end_character":22},"updated":"2017-02-08 19:41:17.000000000","message":"port-pair","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def get_parser(self, prog_name):"},{"line_number":165,"context_line":"        parser \u003d super(ShowPortPair, self).get_parser(prog_name)"},{"line_number":166,"context_line":"        parser.add_argument("},{"line_number":167,"context_line":"            \u0027port_pair\u0027,"},{"line_number":168,"context_line":"            metavar\u003d\u0027\u003cport-pair\u003e\u0027,"},{"line_number":169,"context_line":"            help\u003d_(\"Port pair to display (name or ID)\")"},{"line_number":170,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_e7d96bf4","line":167,"range":{"start_line":167,"start_character":13,"end_line":167,"end_character":22},"updated":"2017-02-08 19:41:17.000000000","message":"port-pair","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"5168e53f0842bc502758a89dc1bf672988343e20","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                   \u0027is supported. Weight is an integer that influences \u0027"},{"line_number":61,"context_line":"                   \u0027the selection of a port pair within a port pair group \u0027"},{"line_number":62,"context_line":"                   \u0027for a flow. The higher the weight, the more flows will \u0027"},{"line_number":63,"context_line":"                   \u0027hash to the port pair. The default weight is 1\u0027))"},{"line_number":64,"context_line":"        return parser"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":23,"id":"da36d5c6_faa547b5","line":63,"updated":"2017-02-19 11:16:00.000000000","message":".","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fef1a095332d973657431dd0701717a1b8e6a6b9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                   \u0027is supported. Weight is an integer that influences \u0027"},{"line_number":61,"context_line":"                   \u0027the selection of a port pair within a port pair group \u0027"},{"line_number":62,"context_line":"                   \u0027for a flow. The higher the weight, the more flows will \u0027"},{"line_number":63,"context_line":"                   \u0027hash to the port pair. The default weight is 1\u0027))"},{"line_number":64,"context_line":"        return parser"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":23,"id":"da36d5c6_469ef563","line":63,"in_reply_to":"da36d5c6_faa547b5","updated":"2017-02-24 11:26:52.000000000","message":"period at the  end of argument description is not followed in openstack client commands","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027--description\u0027,"},{"line_number":53,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":54,"context_line":"            help\u003d_(\u0027Description for the port pair\u0027))"},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--ingress\u0027,"},{"line_number":57,"context_line":"            metavar\u003d\u0027\u003cingress\u003e\u0027,"},{"line_number":58,"context_line":"            required\u003dTrue,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Ingress neutron port (name or ID)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--egress\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cegress\u003e\u0027,"},{"line_number":63,"context_line":"            required\u003dTrue,"},{"line_number":64,"context_line":"            help\u003d_(\u0027Egress neutron port (name or ID)\u0027))"},{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--service-function-parameters\u0027,"},{"line_number":67,"context_line":"            metavar\u003d\u0027\u003ccorrelation\u003d\u003ccorrelation_type\u003e,weight\u003d\u003cweight\u003e\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_d02b6e92","line":64,"range":{"start_line":55,"start_character":8,"end_line":64,"end_character":55},"updated":"2017-04-05 07:01:18.000000000","message":"Could you move the required parameters to the last (as I commented in port chain create)?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            \u0027--description\u0027,"},{"line_number":53,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":54,"context_line":"            help\u003d_(\u0027Description for the port pair\u0027))"},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--ingress\u0027,"},{"line_number":57,"context_line":"            metavar\u003d\u0027\u003cingress\u003e\u0027,"},{"line_number":58,"context_line":"            required\u003dTrue,"},{"line_number":59,"context_line":"            help\u003d_(\u0027Ingress neutron port (name or ID)\u0027))"},{"line_number":60,"context_line":"        parser.add_argument("},{"line_number":61,"context_line":"            \u0027--egress\u0027,"},{"line_number":62,"context_line":"            metavar\u003d\u0027\u003cegress\u003e\u0027,"},{"line_number":63,"context_line":"            required\u003dTrue,"},{"line_number":64,"context_line":"            help\u003d_(\u0027Egress neutron port (name or ID)\u0027))"},{"line_number":65,"context_line":"        parser.add_argument("},{"line_number":66,"context_line":"            \u0027--service-function-parameters\u0027,"},{"line_number":67,"context_line":"            metavar\u003d\u0027\u003ccorrelation\u003d\u003ccorrelation_type\u003e,weight\u003d\u003cweight\u003e\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f94bf627","line":64,"range":{"start_line":55,"start_character":8,"end_line":64,"end_character":55},"in_reply_to":"dfeb2761_d02b6e92","updated":"2017-04-05 09:57:33.000000000","message":"ok","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class DeleteSfcPortPair(command.Command):"},{"line_number":89,"context_line":"    _description \u003d _(\"Delete a given port pair\")"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_parser(self, prog_name):"},{"line_number":92,"context_line":"        parser \u003d super(DeleteSfcPortPair, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_30161a57","line":89,"range":{"start_line":89,"start_character":22,"end_line":89,"end_character":46},"updated":"2017-04-05 07:01:18.000000000","message":"-\u003e Delete port pair(s)","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"class DeleteSfcPortPair(command.Command):"},{"line_number":89,"context_line":"    _description \u003d _(\"Delete a given port pair\")"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def get_parser(self, prog_name):"},{"line_number":92,"context_line":"        parser \u003d super(DeleteSfcPortPair, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_39571ecd","line":89,"range":{"start_line":89,"start_character":22,"end_line":89,"end_character":46},"in_reply_to":"dfeb2761_30161a57","updated":"2017-04-05 09:57:33.000000000","message":"will raise separate patch","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        parser.add_argument("},{"line_number":118,"context_line":"            \u0027--long\u0027,"},{"line_number":119,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":120,"context_line":"            default\u003dFalse,"},{"line_number":121,"context_line":"            help\u003d_(\"List additional fields in output\")"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_93005003","line":120,"range":{"start_line":120,"start_character":12,"end_line":120,"end_character":26},"updated":"2017-04-05 07:01:18.000000000","message":"Unnecessary. the default is False when action is store_true.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        parser.add_argument("},{"line_number":118,"context_line":"            \u0027--long\u0027,"},{"line_number":119,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":120,"context_line":"            default\u003dFalse,"},{"line_number":121,"context_line":"            help\u003d_(\"List additional fields in output\")"},{"line_number":122,"context_line":"        )"},{"line_number":123,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_195c5aeb","line":120,"range":{"start_line":120,"start_character":12,"end_line":120,"end_character":26},"in_reply_to":"dfeb2761_93005003","updated":"2017-04-05 09:57:33.000000000","message":"ok","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"7a2019f26d240cbd1b993651ccbed869a827965f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"                   \u0027is supported. Weight is an integer that influences \u0027"},{"line_number":63,"context_line":"                   \u0027the selection of a port pair within a port pair group \u0027"},{"line_number":64,"context_line":"                   \u0027for a flow. The higher the weight, the more flows will \u0027"},{"line_number":65,"context_line":"                   \u0027hash to the port pair. The default weight is 1\u0027))"},{"line_number":66,"context_line":"        parser.add_argument("},{"line_number":67,"context_line":"            \u0027--ingress\u0027,"},{"line_number":68,"context_line":"            metavar\u003d\u0027\u003cingress\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":33,"id":"df140735_ebea2caa","line":65,"range":{"start_line":65,"start_character":66,"end_line":65,"end_character":67},"updated":"2017-06-01 08:44:51.000000000","message":"Need a period here Because this help message included more than 1 sentence. Apply for all remaining in this file","commit_id":"c22acd1e113e5fff6fadd2e8db91d0bf736707b7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            help\u003d_(\u0027Description for the port pair\u0027))"},{"line_number":55,"context_line":"        parser.add_argument("},{"line_number":56,"context_line":"            \u0027--service-function-parameters\u0027,"},{"line_number":57,"context_line":"            metavar\u003d\u0027\u003ccorrelation\u003d\u003ccorrelation_type\u003e,weight\u003d\u003cweight\u003e\u003e\u0027,"},{"line_number":58,"context_line":"            action\u003dparseractions.MultiKeyValueAction,"},{"line_number":59,"context_line":"            optional_keys\u003d[\u0027correlation\u0027, \u0027weight\u0027],"},{"line_number":60,"context_line":"            help\u003d_(\u0027Dictionary of service function parameters. \u0027"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_7d1fddb6","line":57,"range":{"start_line":57,"start_character":21,"end_line":57,"end_character":69},"updated":"2017-06-15 01:05:41.000000000","message":"The outer-most \u003c and \u003e are unnecessary. \u003c \u003e is used for a value specified by a user.\n\n  metavar\u003d\u0027correlation\u003d\u003ccorrelation-type\u003e,weight\u003d\u003cweight\u003e\n\nIn addition, \u0027correlation_type\u0027 -\u003e \u0027correlation-type\u0027 (use hyphen as a delimiter)","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"}],"neutronclient/osc/v2/sfc/sfc_port_pair_group.py":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            help\u003d_(\u0027Port pair (name or ID). \u0027"},{"line_number":91,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":92,"context_line":"        parser.add_argument("},{"line_number":93,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":94,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":95,"context_line":"            help\u003d_(\"Port pair group to modify (name or ID)\"))"},{"line_number":96,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_679bbb18","line":93,"range":{"start_line":93,"start_character":13,"end_line":93,"end_character":28},"updated":"2017-02-08 19:41:17.000000000","message":"port-pair-group","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"0694b7c68bf79aad8d709096c2b70124aa6ee363","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    def get_parser(self, prog_name):"},{"line_number":116,"context_line":"        parser \u003d super(DeletePortPairGroup, self).get_parser(prog_name)"},{"line_number":117,"context_line":"        parser.add_argument("},{"line_number":118,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":119,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"},{"line_number":120,"context_line":"            help\u003d_(\"Port pair group to delete (name or ID)\")"},{"line_number":121,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a430d35_879ee704","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":28},"updated":"2017-02-08 19:41:17.000000000","message":"ditto","commit_id":"a515f64e8d2284b574cfdc80206f82199869d7c7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    (\u0027port_pair_group_parameters\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":36,"context_line":"     nc_osc_utils.LIST_BOTH),"},{"line_number":37,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027group_id\u0027, \u0027Group ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_9329708b","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"updated":"2017-04-05 07:01:18.000000000","message":"Why do we need \u0027ID\u0027 only for this field?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"36ab70cc8b87c43884110be252d9bd654f2fda81","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    (\u0027port_pair_group_parameters\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":36,"context_line":"     nc_osc_utils.LIST_BOTH),"},{"line_number":37,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027group_id\u0027, \u0027Group ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"bff0334d_8a642cbb","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"in_reply_to":"bff0334d_433a98e7","updated":"2017-04-05 15:55:52.000000000","message":"I actually don\u0027t see value in showing the group_id to the CLI user at all, so in my opinion it should just be removed. If it can only be renamed, maybe something like \"Number\" would be better.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"17bed3620e67090a90f38d37c75953f0cf5f2eb7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    (\u0027port_pair_group_parameters\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":36,"context_line":"     nc_osc_utils.LIST_BOTH),"},{"line_number":37,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027group_id\u0027, \u0027Group ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"bff0334d_433a98e7","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"in_reply_to":"dfeb2761_7bd35661","updated":"2017-04-05 13:39:24.000000000","message":"Igor, as the baseline of the networking API, we don\u0027t expose an implementation detail to users. We only expose an backend detail to admin users. This is the heart of the API and the provider network API follows this principle.\n\nRegarding the name of \"group id\", what we discuss is not the field name of the API. We are discussing what name should be visible to regular users in \"CLI\".","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    (\u0027port_pair_group_parameters\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":36,"context_line":"     nc_osc_utils.LIST_BOTH),"},{"line_number":37,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027group_id\u0027, \u0027Group ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_99c3ca57","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"in_reply_to":"dfeb2761_9329708b","updated":"2017-04-05 09:57:33.000000000","message":"It\u0027s just naming convention , are you suggesting to have \"Group\" ?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"11d3954d88b3d200642b2ef2a15c60b82c57d21d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    (\u0027port_pair_group_parameters\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":36,"context_line":"     nc_osc_utils.LIST_BOTH),"},{"line_number":37,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027group_id\u0027, \u0027Group ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f97776d3","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"in_reply_to":"dfeb2761_99c3ca57","updated":"2017-04-05 10:11:09.000000000","message":"Honestly I wonder what group_id here means.\n\nAfter looking at the API reference proposed to neutron-lib, I finally found the description of \u0027group_id\u0027. It sounds like a mistake of the API design as it leaks a detail of underlying layer to a regular user and it depends on some specific implementation based on OpenFlow.\n\nApart from this, the title of the column should be more meaningful name. At least \"Group\" or \"Group ID\" looks confusing because the resource name already contains \"(port pair) group\". Two \"groups\" without meaningful prefix looks confusing.\n\nAfter reading the API reference, it sounds reasonable to include a keyword \"ID\" here. It looks similar to \"segmentaiton_id\" in the provider network API.\n\nIs there any idea from SFC team?\n\n\"Underlying Group ID\", \"Raw Group ID\"... hmmm...  no good idea in my side...","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94991cf9ffff5cd9de53106946a1d16d0d3a37da","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    (\u0027port_pair_group_parameters\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":36,"context_line":"     nc_osc_utils.LIST_BOTH),"},{"line_number":37,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027group_id\u0027, \u0027Group ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_7bd35661","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"in_reply_to":"dfeb2761_f97776d3","updated":"2017-04-05 11:58:39.000000000","message":"It\u0027s a numerical index for identifying each port-pair-group. When using the OVS driver, you will see that index when running ovs-ofctl dump-groups. It\u0027s kinda like the segmentation_id indeed. The name shouldn\u0027t be changed as that would require an API extension.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"0828266052794c34c51a65f6eeb80d3c31129ccd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    (\u0027port_pair_group_parameters\u0027, \u0027Port Pair Group Parameters\u0027,"},{"line_number":36,"context_line":"     nc_osc_utils.LIST_BOTH),"},{"line_number":37,"context_line":"    (\u0027description\u0027, \u0027Description\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":38,"context_line":"    (\u0027group_id\u0027, \u0027Group ID\u0027, nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":39,"context_line":"    (\u0027project_id\u0027, \u0027Project\u0027,  nc_osc_utils.LIST_LONG_ONLY),"},{"line_number":40,"context_line":")"},{"line_number":41,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_ef28c4e2","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":26},"in_reply_to":"dfeb2761_f97776d3","updated":"2017-04-05 10:44:07.000000000","message":"Louis ? any suggestion. maybe \"SF ID\" \"Loadbalance ID\" ?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class DeleteSfcPortPairGroup(command.Command):"},{"line_number":84,"context_line":"    _description \u003d _(\"Delete a given port pair group\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def get_parser(self, prog_name):"},{"line_number":87,"context_line":"        parser \u003d super(DeleteSfcPortPairGroup, self).get_parser(prog_name)"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_133d60c3","line":84,"range":{"start_line":84,"start_character":21,"end_line":84,"end_character":54},"updated":"2017-04-05 07:01:18.000000000","message":"-\u003e Delete port pair group(s)","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"69ac0839c118bb9e9fd28d4a9ada353bd10fbbe3","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            \u0027--description\u0027,"},{"line_number":142,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":143,"context_line":"            help\u003d_(\u0027Description for the port pair group\u0027))"},{"line_number":144,"context_line":"        parser.add_argument("},{"line_number":145,"context_line":"            \u0027--port-pair\u0027,"},{"line_number":146,"context_line":"            metavar\u003d\u0027\u003cport-pair\u003e\u0027,"},{"line_number":147,"context_line":"            dest\u003d\u0027port_pairs\u0027,"},{"line_number":148,"context_line":"            default\u003d[],"},{"line_number":149,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":150,"context_line":"            help\u003d_(\u0027Port pair (name or ID). \u0027"},{"line_number":151,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":152,"context_line":"        parser.add_argument("},{"line_number":153,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":154,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_13c7a098","line":151,"range":{"start_line":144,"start_character":7,"end_line":151,"end_character":50},"updated":"2017-04-05 07:01:18.000000000","message":"The same discussion on port-pair-group parameter.\nThis specifies a list of port pairs, so we need to support operations: add a port chain, replace an existing list of port chains, and clear port chains. Considering this, in OSC convention, a combined usage of \"--port-pair\" and \"--no-port-pair\" is also used.","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            \u0027--description\u0027,"},{"line_number":142,"context_line":"            metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":143,"context_line":"            help\u003d_(\u0027Description for the port pair group\u0027))"},{"line_number":144,"context_line":"        parser.add_argument("},{"line_number":145,"context_line":"            \u0027--port-pair\u0027,"},{"line_number":146,"context_line":"            metavar\u003d\u0027\u003cport-pair\u003e\u0027,"},{"line_number":147,"context_line":"            dest\u003d\u0027port_pairs\u0027,"},{"line_number":148,"context_line":"            default\u003d[],"},{"line_number":149,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":150,"context_line":"            help\u003d_(\u0027Port pair (name or ID). \u0027"},{"line_number":151,"context_line":"                   \u0027This option can be repeated\u0027))"},{"line_number":152,"context_line":"        parser.add_argument("},{"line_number":153,"context_line":"            \u0027port_pair_group\u0027,"},{"line_number":154,"context_line":"            metavar\u003d\u0027\u003cport-pair-group\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_b9732e16","line":151,"range":{"start_line":144,"start_character":7,"end_line":151,"end_character":50},"in_reply_to":"dfeb2761_13c7a098","updated":"2017-04-05 09:57:33.000000000","message":"ok","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":164,"context_line":"        ppg_id \u003d _get_id(client, parsed_args.port_pair_group, resource)"},{"line_number":165,"context_line":"        if parsed_args.no_port_pair:"},{"line_number":166,"context_line":"            parsed_args[\u0027port_pairs\u0027] \u003d []"},{"line_number":167,"context_line":"        if parsed_args.port_pair:"},{"line_number":168,"context_line":"            existing \u003d client.find_resource("},{"line_number":169,"context_line":"                resource, parsed_args.port_pair_group,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_93a9fde0","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":37},"updated":"2017-04-14 19:06:19.000000000","message":"It is not recommended to change parsed_args. Instead, could you call _get_common_attrs at L.174 first? If so, this will be: attrs[\u0027port_pairs\u0027] \u003d [].","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":164,"context_line":"        ppg_id \u003d _get_id(client, parsed_args.port_pair_group, resource)"},{"line_number":165,"context_line":"        if parsed_args.no_port_pair:"},{"line_number":166,"context_line":"            parsed_args[\u0027port_pairs\u0027] \u003d []"},{"line_number":167,"context_line":"        if parsed_args.port_pair:"},{"line_number":168,"context_line":"            existing \u003d client.find_resource("},{"line_number":169,"context_line":"                resource, parsed_args.port_pair_group,"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_6a289585","line":166,"range":{"start_line":166,"start_character":12,"end_line":166,"end_character":37},"in_reply_to":"7ffa3b31_93a9fde0","updated":"2017-04-17 13:33:13.000000000","message":"sure will rearrange","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        ppg_id \u003d _get_id(client, parsed_args.port_pair_group, resource)"},{"line_number":165,"context_line":"        if parsed_args.no_port_pair:"},{"line_number":166,"context_line":"            parsed_args[\u0027port_pairs\u0027] \u003d []"},{"line_number":167,"context_line":"        if parsed_args.port_pair:"},{"line_number":168,"context_line":"            existing \u003d client.find_resource("},{"line_number":169,"context_line":"                resource, parsed_args.port_pair_group,"},{"line_number":170,"context_line":"                cmd_resource\u003d\u0027sfc_port_pair_group\u0027)[\u0027port_pairs\u0027]"},{"line_number":171,"context_line":"            for f in set(parsed_args.port_pair):"},{"line_number":172,"context_line":"                existing.append(_get_id(client, f, \u0027port_pair\u0027))"},{"line_number":173,"context_line":"            parsed_args[\u0027port_pairs\u0027] \u003d list(set(existing))"},{"line_number":174,"context_line":"        attrs \u003d _get_common_attrs(self.app.client_manager, parsed_args,"},{"line_number":175,"context_line":"                                  is_create\u003dFalse)"},{"line_number":176,"context_line":"        body \u003d {resource: attrs}"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_13604dce","line":173,"range":{"start_line":167,"start_character":8,"end_line":173,"end_character":59},"updated":"2017-04-14 19:06:19.000000000","message":"Assume the current port pairs are [A, B]. The expected behavior is:\n- If --port-pair C is specified, the new port pair will be [A,B,C]\n- If --no-port-pair is specified, the new port pair will be [].\n- If --no-port-pair and --port-pair C are specified, the new port pair will be [C]. I think the last case is not covered.\n\nI think the L.167-173 can be:\n\n  if parsed_args.port_pair:\n    added \u003d [_get_id(client, pp, \u0027port_pair\u0027)\n             for pp in parsed_args.port_pair]\n    if parsed_args.no_port_pair:\n        existing \u003d []\n    else:\n        existing \u003d client.find_resource(...)[\u0027port_pairs\u0027]\n    attrs[\u0027port_pairs\u0027] \u003d list(set(existing) | set(added))","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        ppg_id \u003d _get_id(client, parsed_args.port_pair_group, resource)"},{"line_number":165,"context_line":"        if parsed_args.no_port_pair:"},{"line_number":166,"context_line":"            parsed_args[\u0027port_pairs\u0027] \u003d []"},{"line_number":167,"context_line":"        if parsed_args.port_pair:"},{"line_number":168,"context_line":"            existing \u003d client.find_resource("},{"line_number":169,"context_line":"                resource, parsed_args.port_pair_group,"},{"line_number":170,"context_line":"                cmd_resource\u003d\u0027sfc_port_pair_group\u0027)[\u0027port_pairs\u0027]"},{"line_number":171,"context_line":"            for f in set(parsed_args.port_pair):"},{"line_number":172,"context_line":"                existing.append(_get_id(client, f, \u0027port_pair\u0027))"},{"line_number":173,"context_line":"            parsed_args[\u0027port_pairs\u0027] \u003d list(set(existing))"},{"line_number":174,"context_line":"        attrs \u003d _get_common_attrs(self.app.client_manager, parsed_args,"},{"line_number":175,"context_line":"                                  is_create\u003dFalse)"},{"line_number":176,"context_line":"        body \u003d {resource: attrs}"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_0a27d1b5","line":173,"range":{"start_line":167,"start_character":8,"end_line":173,"end_character":59},"in_reply_to":"7ffa3b31_13604dce","updated":"2017-04-17 13:33:13.000000000","message":"+1","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            help\u003d_(\u0027Remove all port pairs from the port pair group\u0027))"},{"line_number":227,"context_line":"        return parser"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def _get_attrs(self, client_manager, parsed_args):"},{"line_number":230,"context_line":"        attrs \u003d {}"},{"line_number":231,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_b3cbd9a3","line":229,"range":{"start_line":229,"start_character":4,"end_line":229,"end_character":18},"updated":"2017-04-14 19:06:19.000000000","message":"I don\u0027t think we need a separate method. We already have a _get_attr function as a module level, so it is confusing to have two same name function and method in a same module. take_action is short enough, so all logic in this method can be moved to take_action below.","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            help\u003d_(\u0027Remove all port pairs from the port pair group\u0027))"},{"line_number":227,"context_line":"        return parser"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def _get_attrs(self, client_manager, parsed_args):"},{"line_number":230,"context_line":"        attrs \u003d {}"},{"line_number":231,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_ea3b85ce","line":229,"range":{"start_line":229,"start_character":4,"end_line":229,"end_character":18},"in_reply_to":"7ffa3b31_b3cbd9a3","updated":"2017-04-17 13:33:13.000000000","message":"ok ,will remove","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            existing \u003d client.find_resource("},{"line_number":235,"context_line":"                resource, parsed_args.port_pair_group,"},{"line_number":236,"context_line":"                cmd_resource\u003d\u0027sfc_port_pair_group\u0027)[\u0027port_pairs\u0027]"},{"line_number":237,"context_line":"            removed \u003d []"},{"line_number":238,"context_line":"            for f in set(parsed_args.port_pairs):"},{"line_number":239,"context_line":"                removed.append(_get_id(client, f, \u0027port_pair\u0027))"},{"line_number":240,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d [e for e in existing if e not in removed]"},{"line_number":241,"context_line":"        if parsed_args.all_port_pair:"},{"line_number":242,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_53c25587","line":239,"range":{"start_line":237,"start_character":12,"end_line":239,"end_character":63},"updated":"2017-04-14 19:06:19.000000000","message":"This can be:\n\n  removed \u003d [_get_id(client, pp, \u0027port_pair\u0027)\n             for pp in parsed_args.port_pairs]\n\nI think set() operation is optional. The only difference is we can reduce an extra API call if duplicated port pairs are specified. I think it is minor thing and we don\u0027t need to take care of. I am okay with either.","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":234,"context_line":"            existing \u003d client.find_resource("},{"line_number":235,"context_line":"                resource, parsed_args.port_pair_group,"},{"line_number":236,"context_line":"                cmd_resource\u003d\u0027sfc_port_pair_group\u0027)[\u0027port_pairs\u0027]"},{"line_number":237,"context_line":"            removed \u003d []"},{"line_number":238,"context_line":"            for f in set(parsed_args.port_pairs):"},{"line_number":239,"context_line":"                removed.append(_get_id(client, f, \u0027port_pair\u0027))"},{"line_number":240,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d [e for e in existing if e not in removed]"},{"line_number":241,"context_line":"        if parsed_args.all_port_pair:"},{"line_number":242,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_0a5c7123","line":239,"range":{"start_line":237,"start_character":12,"end_line":239,"end_character":63},"in_reply_to":"7ffa3b31_53c25587","updated":"2017-04-17 13:33:13.000000000","message":"if we take care of duplicate check in L240, this set() can be remove","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"4ebbadb61d3cff6e8b101efbe8771b19fc7259f6","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            removed \u003d []"},{"line_number":238,"context_line":"            for f in set(parsed_args.port_pairs):"},{"line_number":239,"context_line":"                removed.append(_get_id(client, f, \u0027port_pair\u0027))"},{"line_number":240,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d [e for e in existing if e not in removed]"},{"line_number":241,"context_line":"        if parsed_args.all_port_pair:"},{"line_number":242,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d []"},{"line_number":243,"context_line":"        return attrs"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_13bccd03","line":240,"range":{"start_line":240,"start_character":12,"end_line":240,"end_character":75},"updated":"2017-04-14 19:06:19.000000000","message":"This can be:\n\n  attrs[\u0027port_pairs\u0027] \u003d list(set(existing) - set(removed))","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"02d230410248baa36fc0cdfd12732cf700bfe4e0","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            removed \u003d []"},{"line_number":238,"context_line":"            for f in set(parsed_args.port_pairs):"},{"line_number":239,"context_line":"                removed.append(_get_id(client, f, \u0027port_pair\u0027))"},{"line_number":240,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d [e for e in existing if e not in removed]"},{"line_number":241,"context_line":"        if parsed_args.all_port_pair:"},{"line_number":242,"context_line":"            attrs[\u0027port_pairs\u0027] \u003d []"},{"line_number":243,"context_line":"        return attrs"}],"source_content_type":"text/x-python","patch_set":30,"id":"7ffa3b31_ea402538","line":240,"range":{"start_line":240,"start_character":12,"end_line":240,"end_character":75},"in_reply_to":"7ffa3b31_13bccd03","updated":"2017-04-17 13:33:13.000000000","message":"ok","commit_id":"a02d91a85722065a4536ffeedad15de17ee3bdcf"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"7a2019f26d240cbd1b993651ccbed869a827965f","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":69,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":70,"context_line":"                   \u0027are supported\u0027))"},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":33,"id":"df140735_8bdbb019","line":70,"range":{"start_line":70,"start_character":33,"end_line":70,"end_character":34},"updated":"2017-06-01 08:44:51.000000000","message":"Need a period here Because this help message included more than 1 sentence. Apply for all remaining in this file","commit_id":"c22acd1e113e5fff6fadd2e8db91d0bf736707b7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from osc_lib.cli import parseractions"},{"line_number":20,"context_line":"from osc_lib.command import command"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_5d71c10b","line":17,"updated":"2017-06-15 01:05:41.000000000","message":"six is third party module.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94652445e1c4da80437a9086fbc0ecd38c388d48","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import six"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from osc_lib.cli import parseractions"},{"line_number":20,"context_line":"from osc_lib.command import command"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_c70ba527","line":17,"in_reply_to":"7f231b9d_5d71c10b","updated":"2017-06-15 16:18:10.000000000","message":"just remove, seeing as it can be easily replaced by .items()","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                   \u0027This option can be repeated.\u0027))"},{"line_number":64,"context_line":"        parser.add_argument("},{"line_number":65,"context_line":"            \u0027--port-pair-group-parameters\u0027,"},{"line_number":66,"context_line":"            metavar\u003d\u0027\u003clb_fields\u003dlb_fields\u003e\u0027,"},{"line_number":67,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":69,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_dd5ef174","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":42},"updated":"2017-06-15 01:05:41.000000000","message":"This needs to be:\n\n  lb-fields\u003d\u003clb-fields\u003e\n\nWe use hyphen as a delimiter.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027\u003clb_fields\u003dlb_fields\u003e\u0027,"},{"line_number":67,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":69,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":70,"context_line":"                   \u0027are supported.\u0027))"},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_ddecb190","line":69,"range":{"start_line":69,"start_character":31,"end_line":69,"end_character":75},"updated":"2017-06-15 01:05:41.000000000","message":"I cannot understand what kind of parameters are supported.\nDo you mean \u0027lb_fields\u0027 is a list of field name separated by \u0027\u0026\u0027?\n\nI also would like to know how users can know what are valid field names.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"dc6479bbf445e837795b74055fc58040faa5662b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027\u003clb_fields\u003dlb_fields\u003e\u0027,"},{"line_number":67,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":69,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":70,"context_line":"                   \u0027are supported.\u0027))"},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"3f1d235d_e63635b5","line":69,"range":{"start_line":69,"start_character":31,"end_line":69,"end_character":75},"in_reply_to":"7f231b9d_a72b0993","updated":"2017-06-29 19:08:15.000000000","message":"Yeah, I know that. My comment is based on the perspective of regular users. They would like to get some hints from the command line help. \n\nApart from what values are supported, the help text is not easy to understand to me. How about the following?\n\n  Currently only one parameter \u0027lb_fields\u0027 is supported.\n  \u003clb_fields\u003e is a \u0027\u0026\u0027-separated list of load-balancing fields.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94652445e1c4da80437a9086fbc0ecd38c388d48","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            metavar\u003d\u0027\u003clb_fields\u003dlb_fields\u003e\u0027,"},{"line_number":67,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":68,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":69,"context_line":"                   \u0027Currently, only \\\u0027\u0026\\\u0027 separated string of the lb_fields \u0027"},{"line_number":70,"context_line":"                   \u0027are supported.\u0027))"},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_a72b0993","line":69,"range":{"start_line":69,"start_character":31,"end_line":69,"end_character":75},"in_reply_to":"7f231b9d_ddecb190","updated":"2017-06-15 16:18:10.000000000","message":"There\u0027s quite a few possibilities though: https://github.com/openstack/networking-sfc/blob/master/networking_sfc/extensions/sfc.py#L51-L67 should the help list everything?","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":"def _get_ppg_param(attrs, ppg):"},{"line_number":257,"context_line":"    attrs[\u0027port_pair_group_parameters\u0027] \u003d {}"},{"line_number":258,"context_line":"    for key, value in six.iteritems(ppg):"},{"line_number":259,"context_line":"        if key \u003d\u003d \u0027lb_fields\u0027:"},{"line_number":260,"context_line":"            attrs[\u0027port_pair_group_parameters\u0027][key] \u003d (["},{"line_number":261,"context_line":"                field for field in value.split(\u0027\u0026\u0027) if field])"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_bd8a15bc","line":258,"range":{"start_line":258,"start_character":22,"end_line":258,"end_character":40},"updated":"2017-06-15 01:05:41.000000000","message":"Consider using ppg.itmes(). There is no need to use six.iteritems.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"188909dc1d3b07ea22fe55fbac34ba8112bff044","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            metavar\u003d\u0027lb-fields\u003d\u003clb-fields\u003e\u0027,"},{"line_number":66,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":68,"context_line":"                   \u0027Currently only one parameter lb_fields is supported. \u0027"},{"line_number":69,"context_line":"                   \u0027\u003clb-fields\u003e is \u0026 separated list of load-balancing \u0027"},{"line_number":70,"context_line":"                   \u0027fields.\u0027))"},{"line_number":71,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":39,"id":"1f1a1f67_f2c16182","line":68,"range":{"start_line":68,"start_character":51,"end_line":68,"end_character":52},"updated":"2017-07-12 12:35:40.000000000","message":"Nit: one hyphen left to update","commit_id":"543fe076c88025cb85edbe05dfbc632d78296010"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2558749475530de5a5098837d777b6550d1a8ce5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            metavar\u003d\u0027lb-fields\u003d\u003clb-fields\u003e\u0027,"},{"line_number":66,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":68,"context_line":"                   \u0027Currently only one parameter lb_fields is supported. \u0027"},{"line_number":69,"context_line":"                   \u0027\u003clb-fields\u003e is \u0026 separated list of load-balancing \u0027"},{"line_number":70,"context_line":"                   \u0027fields.\u0027))"},{"line_number":71,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":39,"id":"1f1a1f67_52e6d5ea","line":68,"range":{"start_line":68,"start_character":51,"end_line":68,"end_character":52},"in_reply_to":"1f1a1f67_f2c16182","updated":"2017-07-12 12:38:58.000000000","message":"yes","commit_id":"543fe076c88025cb85edbe05dfbc632d78296010"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"188909dc1d3b07ea22fe55fbac34ba8112bff044","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":68,"context_line":"                   \u0027Currently only one parameter lb_fields is supported. \u0027"},{"line_number":69,"context_line":"                   \u0027\u003clb-fields\u003e is \u0026 separated list of load-balancing \u0027"},{"line_number":70,"context_line":"                   \u0027fields.\u0027))"},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"1f1a1f67_925fcde4","line":69,"range":{"start_line":69,"start_character":35,"end_line":69,"end_character":46},"updated":"2017-07-12 12:35:40.000000000","message":"Do you mean \"a \u0027\u0026\u0027 separated\"?","commit_id":"543fe076c88025cb85edbe05dfbc632d78296010"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"b46a272ffaf991257f7c45ef41003f9340c55644","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":68,"context_line":"                   \u0027Currently only one parameter lb_fields is supported. \u0027"},{"line_number":69,"context_line":"                   \u0027\u003clb-fields\u003e is \u0026 separated list of load-balancing \u0027"},{"line_number":70,"context_line":"                   \u0027fields.\u0027))"},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"1f1a1f67_f2516164","line":69,"range":{"start_line":69,"start_character":35,"end_line":69,"end_character":46},"in_reply_to":"1f1a1f67_925fcde4","updated":"2017-07-12 12:43:39.000000000","message":"\"a \u0027\u0026\u0027 separated\" \u003d\u003e single quote is not allowed here, so will write as \"a \u0026 separated\"","commit_id":"543fe076c88025cb85edbe05dfbc632d78296010"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2558749475530de5a5098837d777b6550d1a8ce5","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            action\u003dparseractions.KeyValueAction,"},{"line_number":67,"context_line":"            help\u003d_(\u0027Dictionary of port pair group parameters. \u0027"},{"line_number":68,"context_line":"                   \u0027Currently only one parameter lb_fields is supported. \u0027"},{"line_number":69,"context_line":"                   \u0027\u003clb-fields\u003e is \u0026 separated list of load-balancing \u0027"},{"line_number":70,"context_line":"                   \u0027fields.\u0027))"},{"line_number":71,"context_line":"        return parser"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"1f1a1f67_32eb59b1","line":69,"range":{"start_line":69,"start_character":35,"end_line":69,"end_character":46},"in_reply_to":"1f1a1f67_925fcde4","updated":"2017-07-12 12:38:58.000000000","message":"yes","commit_id":"543fe076c88025cb85edbe05dfbc632d78296010"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"6ec65eff43e301429b10861e940fdd383e968b96","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"def _get_ppg_param(attrs, ppg):"},{"line_number":258,"context_line":"    attrs[\u0027port_pair_group_parameters\u0027] \u003d {}"},{"line_number":259,"context_line":"    for key, value in ppg.itmes():"},{"line_number":260,"context_line":"        if key \u003d\u003d \u0027lb_fields\u0027:"},{"line_number":261,"context_line":"            attrs[\u0027port_pair_group_parameters\u0027][key] \u003d (["},{"line_number":262,"context_line":"                field for field in value.split(\u0027\u0026\u0027) if field])"}],"source_content_type":"text/x-python","patch_set":41,"id":"1f1a1f67_5487d8d8","line":259,"range":{"start_line":259,"start_character":26,"end_line":259,"end_character":31},"updated":"2017-07-12 17:31:03.000000000","message":"items","commit_id":"d205f4488323077db8a20694b877737b1a7822e0"}],"neutronclient/tests/unit/osc/v2/sfc/fakes.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f1bf6b024d52b9e60f1e318bbe03b8dd53ec13aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#   Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_4ada76e9","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2017-01-23 09:53:49.000000000","message":"2017","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"}],"neutronclient/tests/unit/osc/v2/sfc/test_flow_classifier.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f1bf6b024d52b9e60f1e318bbe03b8dd53ec13aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_aaef5a85","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2017-01-23 09:53:49.000000000","message":"2017","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2caa299964cea9479a4765e0d672d042306a1923","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutronclient.osc.v2.sfc import flow_classifier"},{"line_number":19,"context_line":"from neutronclient.tests.unit.osc.v2.sfc import fakes"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"get_id \u003d \u0027neutronclient.osc.v2.sfc.\u0027 \\"},{"line_number":22,"context_line":"         \u0027flow_classifier._get_id\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def _get_id(client, id_or_name, resource):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_871b7e72","line":22,"range":{"start_line":21,"start_character":9,"end_line":22,"end_character":34},"updated":"2017-01-23 07:22:41.000000000","message":"There seems no need to wrap lines.","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"4ccff31c786932f687cf38a00914fcb1d1267d19","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutronclient.osc.v2.sfc import flow_classifier"},{"line_number":19,"context_line":"from neutronclient.tests.unit.osc.v2.sfc import fakes"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"get_id \u003d \u0027neutronclient.osc.v2.sfc.\u0027 \\"},{"line_number":22,"context_line":"         \u0027flow_classifier._get_id\u0027"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def _get_id(client, id_or_name, resource):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_b932560e","line":22,"range":{"start_line":21,"start_character":9,"end_line":22,"end_character":34},"in_reply_to":"5a3905b3_871b7e72","updated":"2017-01-23 12:18:06.000000000","message":"wil modify","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a7ab1a935900c24d8677ca0958546bfac2bf7bf9","unresolved":false,"context_lines":[{"line_number":138,"context_line":"               \u0027Source IP\u0027,"},{"line_number":139,"context_line":"               \u0027Source Port Range Max\u0027,"},{"line_number":140,"context_line":"               \u0027Source Port Range Min\u0027,"},{"line_number":141,"context_line":"               \u0027ethertype\u0027,"},{"line_number":142,"context_line":"               \u0027no_flow_classiifier\u0027,"},{"line_number":143,"context_line":"               \u0027project_id\u0027)"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_2040d733","line":141,"range":{"start_line":141,"start_character":16,"end_line":141,"end_character":25},"updated":"2017-02-24 14:29:33.000000000","message":"Ethertype","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2b94e995fbdf1f5b3fdc7f764b0ee956c0f851ca","unresolved":false,"context_lines":[{"line_number":138,"context_line":"               \u0027Source IP\u0027,"},{"line_number":139,"context_line":"               \u0027Source Port Range Max\u0027,"},{"line_number":140,"context_line":"               \u0027Source Port Range Min\u0027,"},{"line_number":141,"context_line":"               \u0027ethertype\u0027,"},{"line_number":142,"context_line":"               \u0027no_flow_classiifier\u0027,"},{"line_number":143,"context_line":"               \u0027project_id\u0027)"},{"line_number":144,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_1daea3e7","line":141,"range":{"start_line":141,"start_character":16,"end_line":141,"end_character":25},"in_reply_to":"da36d5c6_2040d733","updated":"2017-02-27 15:01:07.000000000","message":"yes","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a7ab1a935900c24d8677ca0958546bfac2bf7bf9","unresolved":false,"context_lines":[{"line_number":139,"context_line":"               \u0027Source Port Range Max\u0027,"},{"line_number":140,"context_line":"               \u0027Source Port Range Min\u0027,"},{"line_number":141,"context_line":"               \u0027ethertype\u0027,"},{"line_number":142,"context_line":"               \u0027no_flow_classiifier\u0027,"},{"line_number":143,"context_line":"               \u0027project_id\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def get_data(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_a07a0786","line":142,"range":{"start_line":142,"start_character":16,"end_line":142,"end_character":35},"updated":"2017-02-24 14:29:33.000000000","message":"I\u0027m not sure what to do about this one, but at least the second \"i\" should be removed.","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2b94e995fbdf1f5b3fdc7f764b0ee956c0f851ca","unresolved":false,"context_lines":[{"line_number":139,"context_line":"               \u0027Source Port Range Max\u0027,"},{"line_number":140,"context_line":"               \u0027Source Port Range Min\u0027,"},{"line_number":141,"context_line":"               \u0027ethertype\u0027,"},{"line_number":142,"context_line":"               \u0027no_flow_classiifier\u0027,"},{"line_number":143,"context_line":"               \u0027project_id\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def get_data(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_bd9e77b6","line":142,"range":{"start_line":142,"start_character":16,"end_line":142,"end_character":35},"in_reply_to":"da36d5c6_9d3d572d","updated":"2017-02-27 15:01:07.000000000","message":"ok will remove","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"d02f043d198bc104444179e55e65e4f55fa9dc73","unresolved":false,"context_lines":[{"line_number":139,"context_line":"               \u0027Source Port Range Max\u0027,"},{"line_number":140,"context_line":"               \u0027Source Port Range Min\u0027,"},{"line_number":141,"context_line":"               \u0027ethertype\u0027,"},{"line_number":142,"context_line":"               \u0027no_flow_classiifier\u0027,"},{"line_number":143,"context_line":"               \u0027project_id\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def get_data(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_9d3d572d","line":142,"range":{"start_line":142,"start_character":16,"end_line":142,"end_character":35},"in_reply_to":"da36d5c6_a07a0786","updated":"2017-02-25 07:11:15.000000000","message":"\u0027no_flow_classifier\u0027 is used for removing classifier configuration from the sfc chain which is previously configure. It\u0027s not required here anyways. Thanks for pointing.","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a7ab1a935900c24d8677ca0958546bfac2bf7bf9","unresolved":false,"context_lines":[{"line_number":140,"context_line":"               \u0027Source Port Range Min\u0027,"},{"line_number":141,"context_line":"               \u0027ethertype\u0027,"},{"line_number":142,"context_line":"               \u0027no_flow_classiifier\u0027,"},{"line_number":143,"context_line":"               \u0027project_id\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def get_data(self):"},{"line_number":146,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_e0707fa6","line":143,"range":{"start_line":143,"start_character":16,"end_line":143,"end_character":26},"updated":"2017-02-24 14:29:33.000000000","message":"Project ID","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2b94e995fbdf1f5b3fdc7f764b0ee956c0f851ca","unresolved":false,"context_lines":[{"line_number":140,"context_line":"               \u0027Source Port Range Min\u0027,"},{"line_number":141,"context_line":"               \u0027ethertype\u0027,"},{"line_number":142,"context_line":"               \u0027no_flow_classiifier\u0027,"},{"line_number":143,"context_line":"               \u0027project_id\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def get_data(self):"},{"line_number":146,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_fda8efdd","line":143,"range":{"start_line":143,"start_character":16,"end_line":143,"end_character":26},"in_reply_to":"da36d5c6_e0707fa6","updated":"2017-02-27 15:01:07.000000000","message":"will change","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a7ab1a935900c24d8677ca0958546bfac2bf7bf9","unresolved":false,"context_lines":[{"line_number":311,"context_line":"               \u0027Source IP\u0027,"},{"line_number":312,"context_line":"               \u0027Source Port Range Max\u0027,"},{"line_number":313,"context_line":"               \u0027Source Port Range Min\u0027,"},{"line_number":314,"context_line":"               \u0027ethertype\u0027,"},{"line_number":315,"context_line":"               \u0027no_flow_classiifier\u0027,"},{"line_number":316,"context_line":"               \u0027project_id\u0027)"},{"line_number":317,"context_line":""},{"line_number":318,"context_line":"    def setUp(self):"},{"line_number":319,"context_line":"        super(TestShowSfcFlowClassifier, self).setUp()"}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_2067f7e9","line":316,"range":{"start_line":314,"start_character":0,"end_line":316,"end_character":28},"updated":"2017-02-24 14:29:33.000000000","message":"Ditto","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":296,"context_line":"    data \u003d []"},{"line_number":297,"context_line":"    data_long \u003d []"},{"line_number":298,"context_line":"    _flow_classifier \u003d _fc[0]"},{"line_number":299,"context_line":"    data.append(("},{"line_number":300,"context_line":"        _flow_classifier[\u0027id\u0027],"},{"line_number":301,"context_line":"        _flow_classifier[\u0027name\u0027],"},{"line_number":302,"context_line":"        _flow_classifier[\u0027protocol\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_087d457e","line":299,"range":{"start_line":299,"start_character":4,"end_line":299,"end_character":17},"updated":"2017-06-15 01:05:41.000000000","message":"Consider assigning data here.\n\n  data \u003d [\n    _flow_classifier[\u0027id\u0027],\n    ...\n  ]","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        _flow_classifier[\u0027destination_ip_prefix\u0027],"},{"line_number":305,"context_line":"        _flow_classifier[\u0027logical_source_port\u0027],"},{"line_number":306,"context_line":"        _flow_classifier[\u0027logical_destination_port\u0027]))"},{"line_number":307,"context_line":"    data_long.append(("},{"line_number":308,"context_line":"        _flow_classifier[\u0027id\u0027],"},{"line_number":309,"context_line":"        _flow_classifier[\u0027name\u0027],"},{"line_number":310,"context_line":"        _flow_classifier[\u0027protocol\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_e86d69cc","line":307,"range":{"start_line":307,"start_character":4,"end_line":307,"end_character":22},"updated":"2017-06-15 01:05:41.000000000","message":"ditto","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        columns \u003d self.cmd.take_action(parsed_args)"},{"line_number":342,"context_line":"        data \u003d []"},{"line_number":343,"context_line":"        fc \u003d self.neutronclient.list_flow_classifier()"},{"line_number":344,"context_line":"        data.append(("},{"line_number":345,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027id\u0027],"},{"line_number":346,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027name\u0027],"},{"line_number":347,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027protocol\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_a86bf1b4","line":344,"range":{"start_line":344,"start_character":8,"end_line":344,"end_character":21},"updated":"2017-06-15 01:05:41.000000000","message":"ditto","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":342,"context_line":"        data \u003d []"},{"line_number":343,"context_line":"        fc \u003d self.neutronclient.list_flow_classifier()"},{"line_number":344,"context_line":"        data.append(("},{"line_number":345,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027id\u0027],"},{"line_number":346,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027name\u0027],"},{"line_number":347,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027protocol\u0027],"},{"line_number":348,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027source_ip_prefix\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_289da1bb","line":345,"range":{"start_line":345,"start_character":12,"end_line":345,"end_character":41},"updated":"2017-06-15 01:05:41.000000000","message":"It is better to assign fc.get(\u0027flow_classifiers\u0027)[0] to a value.\n\n  classifiers \u003d self.neutronclient.list_flow_classifier()[\u0027flow_classifiers\u0027]\n  classifier \u003d classifiers[0]","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        verifylist \u003d [(\u0027long\u0027, True)]"},{"line_number":358,"context_line":"        data \u003d []"},{"line_number":359,"context_line":"        fc \u003d self.neutronclient.list_flow_classifier()"},{"line_number":360,"context_line":"        data.append(("},{"line_number":361,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027id\u0027],"},{"line_number":362,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027name\u0027],"},{"line_number":363,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027protocol\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_886835b9","line":360,"range":{"start_line":360,"start_character":8,"end_line":360,"end_character":21},"updated":"2017-06-15 01:05:41.000000000","message":"ditto","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":358,"context_line":"        data \u003d []"},{"line_number":359,"context_line":"        fc \u003d self.neutronclient.list_flow_classifier()"},{"line_number":360,"context_line":"        data.append(("},{"line_number":361,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027id\u0027],"},{"line_number":362,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027name\u0027],"},{"line_number":363,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027protocol\u0027],"},{"line_number":364,"context_line":"            fc.get(\u0027flow_classifiers\u0027)[0][\u0027ethertype\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_08a2e5fd","line":361,"range":{"start_line":361,"start_character":12,"end_line":361,"end_character":41},"updated":"2017-06-15 01:05:41.000000000","message":"See a comment at L.345","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"}],"neutronclient/tests/unit/osc/v2/sfc/test_port_chain.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f1bf6b024d52b9e60f1e318bbe03b8dd53ec13aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_4a019637","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2017-01-23 09:53:49.000000000","message":"2017","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":156,"context_line":"               \u0027Chain Parameters\u0027, \u0027Chain ID\u0027)"},{"line_number":157,"context_line":"    columns_long \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Port Pair Groups\u0027, \u0027Flow Classifiers\u0027,"},{"line_number":158,"context_line":"                    \u0027Chain Parameters\u0027, \u0027Description\u0027, \u0027Chain ID\u0027, \u0027Project\u0027)"},{"line_number":159,"context_line":"    data \u003d []"},{"line_number":160,"context_line":"    data_long \u003d []"},{"line_number":161,"context_line":"    _port_chain \u003d _port_chains[0]"},{"line_number":162,"context_line":"    data.append(("},{"line_number":163,"context_line":"        _port_chain[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_2886c167","line":160,"range":{"start_line":159,"start_character":4,"end_line":160,"end_character":18},"updated":"2017-06-15 01:05:41.000000000","message":"Same comment for test_flow_classifiers.py","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"}],"neutronclient/tests/unit/osc/v2/sfc/test_port_pair.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f1bf6b024d52b9e60f1e318bbe03b8dd53ec13aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_ea6a42ec","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2017-01-23 09:53:49.000000000","message":"2017","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a7ab1a935900c24d8677ca0958546bfac2bf7bf9","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class TestListSfcPortPair(fakes.TestNeutronClientOSCV2):"},{"line_number":27,"context_line":"    _port_pairs \u003d fakes.FakeSfcPortPair.create_port_pairs()"},{"line_number":28,"context_line":"    columns \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Ingress Logical Port\u0027, \u0027Egress Logical Port\u0027)"},{"line_number":29,"context_line":"    columns_long \u003d (\u0027ID\u0027, \u0027Project ID\u0027, \u0027Name\u0027, \u0027Ingress Logical Port\u0027,"},{"line_number":30,"context_line":"                    \u0027Egress Logical Port\u0027, \u0027Service Function Parameters\u0027,"},{"line_number":31,"context_line":"                    \u0027Description\u0027)"},{"line_number":32,"context_line":"    data \u003d []"}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_e07ebf68","line":29,"range":{"start_line":29,"start_character":57,"end_line":29,"end_character":64},"updated":"2017-02-24 14:29:33.000000000","message":"Is \"Logical\" terminology used anywhere else when relating to ingress/egress sf neutron ports?","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2b94e995fbdf1f5b3fdc7f764b0ee956c0f851ca","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class TestListSfcPortPair(fakes.TestNeutronClientOSCV2):"},{"line_number":27,"context_line":"    _port_pairs \u003d fakes.FakeSfcPortPair.create_port_pairs()"},{"line_number":28,"context_line":"    columns \u003d (\u0027ID\u0027, \u0027Name\u0027, \u0027Ingress Logical Port\u0027, \u0027Egress Logical Port\u0027)"},{"line_number":29,"context_line":"    columns_long \u003d (\u0027ID\u0027, \u0027Project ID\u0027, \u0027Name\u0027, \u0027Ingress Logical Port\u0027,"},{"line_number":30,"context_line":"                    \u0027Egress Logical Port\u0027, \u0027Service Function Parameters\u0027,"},{"line_number":31,"context_line":"                    \u0027Description\u0027)"},{"line_number":32,"context_line":"    data \u003d []"}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_08d3c8d5","line":29,"range":{"start_line":29,"start_character":57,"end_line":29,"end_character":64},"in_reply_to":"da36d5c6_e07ebf68","updated":"2017-02-27 15:01:07.000000000","message":"It\u0027s just the column mapping against \"ingress_port\" for better understanding, while the display in table format. \nRemember in Flow classifier we use logical source port to refer neutron source port.","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a7ab1a935900c24d8677ca0958546bfac2bf7bf9","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        \u0027Ingress Logical Port\u0027,"},{"line_number":235,"context_line":"        \u0027Name\u0027,"},{"line_number":236,"context_line":"        \u0027Service Function Parameters\u0027,"},{"line_number":237,"context_line":"        \u0027project_id\u0027"},{"line_number":238,"context_line":"    )"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_a0ef671c","line":237,"range":{"start_line":237,"start_character":9,"end_line":237,"end_character":19},"updated":"2017-02-24 14:29:33.000000000","message":"Project ID","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2b94e995fbdf1f5b3fdc7f764b0ee956c0f851ca","unresolved":false,"context_lines":[{"line_number":234,"context_line":"        \u0027Ingress Logical Port\u0027,"},{"line_number":235,"context_line":"        \u0027Name\u0027,"},{"line_number":236,"context_line":"        \u0027Service Function Parameters\u0027,"},{"line_number":237,"context_line":"        \u0027project_id\u0027"},{"line_number":238,"context_line":"    )"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_485ce04a","line":237,"range":{"start_line":237,"start_character":9,"end_line":237,"end_character":19},"in_reply_to":"da36d5c6_a0ef671c","updated":"2017-02-27 15:01:07.000000000","message":"ok","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"cf927755f458abb59b314e03d2123c93e72ff855","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \"--service-function-parameters\", \u0027correlation\u003dNone,weight\u003d1\u0027,"},{"line_number":158,"context_line":"        ]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        sfp \u003d [{\u0027correlation\u0027: \u0027None\u0027, \u0027weight\u0027: \u00271\u0027}]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        verifylist \u003d ["},{"line_number":163,"context_line":"            (\u0027ingress\u0027, self._port_pair[\u0027ingress\u0027]),"}],"source_content_type":"text/x-python","patch_set":29,"id":"ffe62b97_36e385db","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":11},"updated":"2017-03-29 09:48:06.000000000","message":"Can you rename this to sfparams?","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"fe0d1b98ee8ca908cb9e1aa176fd78650e16b2de","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            \"--service-function-parameters\", \u0027correlation\u003dNone,weight\u003d1\u0027,"},{"line_number":158,"context_line":"        ]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        sfp \u003d [{\u0027correlation\u0027: \u0027None\u0027, \u0027weight\u0027: \u00271\u0027}]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        verifylist \u003d ["},{"line_number":163,"context_line":"            (\u0027ingress\u0027, self._port_pair[\u0027ingress\u0027]),"}],"source_content_type":"text/x-python","patch_set":29,"id":"dfeb2761_f956565c","line":160,"range":{"start_line":160,"start_character":8,"end_line":160,"end_character":11},"in_reply_to":"ffe62b97_36e385db","updated":"2017-04-05 09:57:33.000000000","message":"ok","commit_id":"87bc3121068c57bdb671caf6788e815a24b57e14"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    data \u003d []"},{"line_number":153,"context_line":"    data_long \u003d []"},{"line_number":154,"context_line":"    _port_pair \u003d _port_pairs[0]"},{"line_number":155,"context_line":"    data.append(("},{"line_number":156,"context_line":"        _port_pair[\u0027id\u0027],"},{"line_number":157,"context_line":"        _port_pair[\u0027name\u0027],"},{"line_number":158,"context_line":"        _port_pair[\u0027ingress\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_088b056e","line":155,"range":{"start_line":155,"start_character":3,"end_line":155,"end_character":17},"updated":"2017-06-15 01:05:41.000000000","message":"Same comment for test_flow_classifiers.py","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"}],"neutronclient/tests/unit/osc/v2/sfc/test_port_pair_group.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"f1bf6b024d52b9e60f1e318bbe03b8dd53ec13aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Huawei Technologies India Pvt.Limited."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a3905b3_0a706edb","line":1,"range":{"start_line":1,"start_character":16,"end_line":1,"end_character":20},"updated":"2017-01-23 09:53:49.000000000","message":"2017","commit_id":"51c5060679239055ea29e7268771cf6f749234cd"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"a7ab1a935900c24d8677ca0958546bfac2bf7bf9","unresolved":false,"context_lines":[{"line_number":101,"context_line":"               \u0027Name\u0027,"},{"line_number":102,"context_line":"               \u0027Port Pair\u0027,"},{"line_number":103,"context_line":"               \u0027Port Pair Group Parameters\u0027,"},{"line_number":104,"context_line":"               \u0027group_id\u0027,"},{"line_number":105,"context_line":"               \u0027project_id\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_data(self):"},{"line_number":108,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_60e2cf30","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":28},"updated":"2017-02-24 14:29:33.000000000","message":"Is this the objective?","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"2b94e995fbdf1f5b3fdc7f764b0ee956c0f851ca","unresolved":false,"context_lines":[{"line_number":101,"context_line":"               \u0027Name\u0027,"},{"line_number":102,"context_line":"               \u0027Port Pair\u0027,"},{"line_number":103,"context_line":"               \u0027Port Pair Group Parameters\u0027,"},{"line_number":104,"context_line":"               \u0027group_id\u0027,"},{"line_number":105,"context_line":"               \u0027project_id\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def get_data(self):"},{"line_number":108,"context_line":"        return ("}],"source_content_type":"text/x-python","patch_set":25,"id":"da36d5c6_e810345b","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":28},"in_reply_to":"da36d5c6_60e2cf30","updated":"2017-02-27 15:01:07.000000000","message":"not really. since these are appended arguments. I didn\u0027t map against user passing arguments. I will change it","commit_id":"194e6a05872ca1409f4583dcfe7fa8ad30483692"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":143,"context_line":"    data \u003d []"},{"line_number":144,"context_line":"    data_long \u003d []"},{"line_number":145,"context_line":"    _port_pair_group \u003d _ppgs[0]"},{"line_number":146,"context_line":"    data.append(("},{"line_number":147,"context_line":"        _port_pair_group[\u0027id\u0027],"},{"line_number":148,"context_line":"        _port_pair_group[\u0027name\u0027],"},{"line_number":149,"context_line":"        _port_pair_group[\u0027port_pairs\u0027],"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_a899b1c4","line":146,"range":{"start_line":146,"start_character":3,"end_line":146,"end_character":17},"updated":"2017-06-15 01:05:41.000000000","message":"Same comment for test_flow_classifiers.py","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        data \u003d []"},{"line_number":179,"context_line":"        ppg \u003d self.neutronclient.list_port_pair_group()"},{"line_number":180,"context_line":"        data.append(("},{"line_number":181,"context_line":"            ppg.get(\u0027port_pair_groups\u0027)[0][\u0027id\u0027],"},{"line_number":182,"context_line":"            ppg.get(\u0027port_pair_groups\u0027)[0][\u0027name\u0027],"},{"line_number":183,"context_line":"            ppg.get(\u0027port_pair_groups\u0027)[0][\u0027port_pairs\u0027],"},{"line_number":184,"context_line":"            ppg.get(\u0027port_pair_groups\u0027)[0][\u0027port_pair_group_parameters\u0027]))"}],"source_content_type":"text/x-python","patch_set":38,"id":"7f231b9d_8896f592","line":181,"range":{"start_line":181,"start_character":12,"end_line":181,"end_character":42},"updated":"2017-06-15 01:05:41.000000000","message":"Same comment for test_flow_classifiers.py","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"79342c1b6c3028381158cfc58bc42fd67af8c9da","unresolved":false,"context_lines":[{"line_number":519,"context_line":"    security_group_rules_path \u003d \"/security-group-rules\""},{"line_number":520,"context_line":"    security_group_rule_path \u003d \"/security-group-rules/%s\""},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    sfc_flow_classifiers_path \u003d \"/sfc/flow_classifiers\""},{"line_number":523,"context_line":"    sfc_flow_classifier_path \u003d \"/sfc/flow_classifiers/%s\""},{"line_number":524,"context_line":"    sfc_port_pairs_path \u003d \"/sfc/port_pairs\""},{"line_number":525,"context_line":"    sfc_port_pair_path \u003d \"/sfc/port_pairs/%s\""},{"line_number":526,"context_line":"    sfc_port_pair_groups_path \u003d \"/sfc/port_pair_groups\""},{"line_number":527,"context_line":"    sfc_port_pair_group_path \u003d \"/sfc/port_pair_groups/%s\""},{"line_number":528,"context_line":"    sfc_port_chains_path \u003d \"/sfc/port_chains\""},{"line_number":529,"context_line":"    sfc_port_chain_path \u003d \"/sfc/port_chains/%s\""},{"line_number":530,"context_line":""},{"line_number":531,"context_line":"    endpoint_groups_path \u003d \"/vpn/endpoint-groups\""},{"line_number":532,"context_line":"    endpoint_group_path \u003d \"/vpn/endpoint-groups/%s\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba5201f7_612e2ba6","line":529,"range":{"start_line":522,"start_character":4,"end_line":529,"end_character":47},"updated":"2017-01-09 07:31:57.000000000","message":"Better to add at the end for avoiding merge conflicts.","commit_id":"690fc2734f09b2180dceff020d25b650d217ad2b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fbfdc834e8c5fa490e0ba101ac396b47e7c52bb9","unresolved":false,"context_lines":[{"line_number":2173,"context_line":"        return self.delete("},{"line_number":2174,"context_line":"            self.bgpvpn_router_association_path % (bgpvpn, router_assoc))"},{"line_number":2175,"context_line":""},{"line_number":2176,"context_line":"    def create_port_pair(self, body\u003dNone):"},{"line_number":2177,"context_line":"        \"\"\"Creates a new Port Pair.\"\"\""},{"line_number":2178,"context_line":"        return self.post(self.sfc_port_pairs_path, body\u003dbody)"},{"line_number":2179,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"ffe62b97_43cfdbaf","line":2176,"updated":"2017-03-27 08:25:25.000000000","message":"Add \"sfc_\" common prefix.\n\n  create_sfc_port_pair()","commit_id":"a25e0f3695196997f25ca00d8297070d104e89a3"}],"releasenotes/notes/add-sfc-commands.yaml":[{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"5168e53f0842bc502758a89dc1bf672988343e20","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    ``sfc flow classifier show``, ``sfc flow classifier set``,"},{"line_number":11,"context_line":"    ``sfc port chain create``, ``sfc port chain delete``,"},{"line_number":12,"context_line":"    ``sfc port chain list``, ``sfc port chain show``, and"},{"line_number":13,"context_line":"    ``sfc port chain set`` OSC commands for networking sfc resource along with"},{"line_number":14,"context_line":"    client bindings."},{"line_number":15,"context_line":"    [Blueprint `openstackclient-cli-porting \u003chttps://blueprints.launchpad.net/networking-sfc/+spec/openstackclient-cli-porting\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":23,"id":"da36d5c6_fabe27d3","line":13,"range":{"start_line":13,"start_character":44,"end_line":13,"end_character":67},"updated":"2017-02-19 11:16:00.000000000","message":"the networking-sfc project\nAlso check if it looks good: http://docs-draft.openstack.org/59/409759/23/check/gate-python-neutronclient-releasenotes/c999975//releasenotes/build/html/unreleased.html","commit_id":"10b41e25e80768a80fb119bcfb1e73550116b606"},{"author":{"_account_id":9396,"name":"igordcard","email":"igordcard@gmail.com","username":"igordcard"},"change_message_id":"94652445e1c4da80437a9086fbc0ecd38c388d48","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add OSC plugin support for the “Networking Service Function Chaining” feature commands along with client bindings."},{"line_number":5,"context_line":"    [Blueprint `openstackclient-cli-porting \u003chttps://blueprints.launchpad.net/networking-sfc/+spec/openstackclient-cli-porting\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"7f231b9d_8ab25448","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":81},"updated":"2017-06-15 16:18:10.000000000","message":"Consider rewriting like \"Add OSC plugin support for Neutron\u0027s Service Function Chaining (networking-sfc) commands, along with client bindings.\".","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Add OSC plugin support for the “Networking Service Function Chaining” feature commands along with client bindings."},{"line_number":5,"context_line":"    [Blueprint `openstackclient-cli-porting \u003chttps://blueprints.launchpad.net/networking-sfc/+spec/openstackclient-cli-porting\u003e`_]"}],"source_content_type":"text/x-yaml","patch_set":38,"id":"7f231b9d_282a417e","line":4,"updated":"2017-06-15 01:05:41.000000000","message":"Could you wrap lines with 80 chars?","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"}],"setup.cfg":[{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    sfc_flow_classifier_create \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:CreateFlowClassifier"},{"line_number":47,"context_line":"    sfc_flow_classifier_delete \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:DeleteFlowClassifier"},{"line_number":48,"context_line":"    sfc_flow_classifier_list \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:ListFlowClassifier"},{"line_number":49,"context_line":"    sfc_flow_classifier_show \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:ShowFlowClassifier"},{"line_number":50,"context_line":"    sfc_flow_classifier_set \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:SetFlowClassifier"},{"line_number":51,"context_line":"    sfc_port_chain_create \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:CreatePortChain"},{"line_number":52,"context_line":"    sfc_port_chain_delete \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:DeletePortChain"},{"line_number":53,"context_line":"    sfc_port_chain_list \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:ListPortChain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"ba5201f7_dc0ab9d1","line":50,"range":{"start_line":49,"start_character":4,"end_line":50,"end_character":27},"updated":"2017-01-12 02:01:42.000000000","message":"alphabetical","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"7cd4d05cd97071eed30626faaaac06bb4c13ce3c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    sfc_flow_classifier_create \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:CreateFlowClassifier"},{"line_number":47,"context_line":"    sfc_flow_classifier_delete \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:DeleteFlowClassifier"},{"line_number":48,"context_line":"    sfc_flow_classifier_list \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:ListFlowClassifier"},{"line_number":49,"context_line":"    sfc_flow_classifier_show \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:ShowFlowClassifier"},{"line_number":50,"context_line":"    sfc_flow_classifier_set \u003d neutronclient.osc.v2.networking_sfc.flow_classifier.flow_classifier:SetFlowClassifier"},{"line_number":51,"context_line":"    sfc_port_chain_create \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:CreatePortChain"},{"line_number":52,"context_line":"    sfc_port_chain_delete \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:DeletePortChain"},{"line_number":53,"context_line":"    sfc_port_chain_list \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:ListPortChain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"7a3c09a3_db749169","line":50,"range":{"start_line":49,"start_character":4,"end_line":50,"end_character":27},"in_reply_to":"ba5201f7_dc0ab9d1","updated":"2017-01-17 07:08:36.000000000","message":"will modify","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    sfc_port_chain_create \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:CreatePortChain"},{"line_number":52,"context_line":"    sfc_port_chain_delete \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:DeletePortChain"},{"line_number":53,"context_line":"    sfc_port_chain_list \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:ListPortChain"},{"line_number":54,"context_line":"    sfc_port_chain_show \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:ShowPortChain"},{"line_number":55,"context_line":"    sfc_port_chain_set \u003d neutronclient.osc.v2.networking_sfc.sfc.port_chain:SetPortChain"},{"line_number":56,"context_line":"    sfc_port_pair_create \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair:CreatePortPair"},{"line_number":57,"context_line":"    sfc_port_pair_delete \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair:DeletePortPair"},{"line_number":58,"context_line":"    sfc_port_pair_list \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair:ListPortPair"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"ba5201f7_fc0bfdd2","line":55,"range":{"start_line":54,"start_character":4,"end_line":55,"end_character":22},"updated":"2017-01-12 02:01:42.000000000","message":"ditto","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    sfc_port_pair_create \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair:CreatePortPair"},{"line_number":57,"context_line":"    sfc_port_pair_delete \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair:DeletePortPair"},{"line_number":58,"context_line":"    sfc_port_pair_list \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair:ListPortPair"},{"line_number":59,"context_line":"    sfc_port_pair_show \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair:ShowPortPair"},{"line_number":60,"context_line":"    sfc_port_pair_set \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair:SetPortPair"},{"line_number":61,"context_line":"    sfc_port_pair_group_create \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair_group:CreatePortPairGroup"},{"line_number":62,"context_line":"    sfc_port_pair_group_delete \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair_group:DeletePortPairGroup"},{"line_number":63,"context_line":"    sfc_port_pair_group_list \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair_group:ListPortPairGroup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"ba5201f7_3cfae5bd","line":60,"range":{"start_line":59,"start_character":4,"end_line":60,"end_character":21},"updated":"2017-01-12 02:01:42.000000000","message":"ditto","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"ef8992732f9d4f8ffcc259d7e1aeb7cb4ab3a891","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    sfc_port_pair_group_create \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair_group:CreatePortPairGroup"},{"line_number":62,"context_line":"    sfc_port_pair_group_delete \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair_group:DeletePortPairGroup"},{"line_number":63,"context_line":"    sfc_port_pair_group_list \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair_group:ListPortPairGroup"},{"line_number":64,"context_line":"    sfc_port_pair_group_show \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair_group:ShowPortPairGroup"},{"line_number":65,"context_line":"    sfc_port_pair_group_set \u003d neutronclient.osc.v2.networking_sfc.sfc.port_pair_group:SetPortPairGroup"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"[build_sphinx]"},{"line_number":68,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":13,"id":"ba5201f7_7c00edab","line":65,"range":{"start_line":64,"start_character":4,"end_line":65,"end_character":27},"updated":"2017-01-12 02:01:42.000000000","message":"ditto","commit_id":"1b2147a3389c784de96c31ae7e73055b1fe92924"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"13f25447f0b3fe3090d3bb4642ce3fe11154016c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    network_trunk_set \u003d neutronclient.osc.v2.trunk.network_trunk:SetNetworkTrunk"},{"line_number":44,"context_line":"    network_trunk_show \u003d neutronclient.osc.v2.trunk.network_trunk:ShowNetworkTrunk"},{"line_number":45,"context_line":"    network_trunk_unset \u003d neutronclient.osc.v2.trunk.network_trunk:UnsetNetworkTrunk"},{"line_number":46,"context_line":"    sfc_flow_classifier_create \u003d neutronclient.osc.v2.sfc.flow_classifier:CreateFlowClassifier"},{"line_number":47,"context_line":"    sfc_flow_classifier_delete \u003d neutronclient.osc.v2.sfc.flow_classifier:DeleteFlowClassifier"},{"line_number":48,"context_line":"    sfc_flow_classifier_list \u003d neutronclient.osc.v2.sfc.flow_classifier:ListFlowClassifier"},{"line_number":49,"context_line":"    sfc_flow_classifier_set \u003d neutronclient.osc.v2.sfc.flow_classifier:SetFlowClassifier"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"3a461143_1e409233","line":46,"range":{"start_line":46,"start_character":58,"end_line":46,"end_character":73},"updated":"2017-01-31 09:08:42.000000000","message":"I think this should be sfc_flow_classifier ...","commit_id":"294be60e225390aba150987a47c50eafea863199"},{"author":{"_account_id":16707,"name":"Mohankumar","email":"nmohankumar1011@gmail.com","username":"mohankumar_n"},"change_message_id":"d228ecf1db51b1bc3de172963ea0354c27ddc46d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    network_trunk_set \u003d neutronclient.osc.v2.trunk.network_trunk:SetNetworkTrunk"},{"line_number":44,"context_line":"    network_trunk_show \u003d neutronclient.osc.v2.trunk.network_trunk:ShowNetworkTrunk"},{"line_number":45,"context_line":"    network_trunk_unset \u003d neutronclient.osc.v2.trunk.network_trunk:UnsetNetworkTrunk"},{"line_number":46,"context_line":"    sfc_flow_classifier_create \u003d neutronclient.osc.v2.sfc.flow_classifier:CreateFlowClassifier"},{"line_number":47,"context_line":"    sfc_flow_classifier_delete \u003d neutronclient.osc.v2.sfc.flow_classifier:DeleteFlowClassifier"},{"line_number":48,"context_line":"    sfc_flow_classifier_list \u003d neutronclient.osc.v2.sfc.flow_classifier:ListFlowClassifier"},{"line_number":49,"context_line":"    sfc_flow_classifier_set \u003d neutronclient.osc.v2.sfc.flow_classifier:SetFlowClassifier"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"3a461143_f96c95d1","line":46,"range":{"start_line":46,"start_character":58,"end_line":46,"end_character":73},"in_reply_to":"3a461143_1e409233","updated":"2017-02-01 06:26:49.000000000","message":"yes ,will add","commit_id":"294be60e225390aba150987a47c50eafea863199"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"13f25447f0b3fe3090d3bb4642ce3fe11154016c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    sfc_flow_classifier_list \u003d neutronclient.osc.v2.sfc.flow_classifier:ListFlowClassifier"},{"line_number":49,"context_line":"    sfc_flow_classifier_set \u003d neutronclient.osc.v2.sfc.flow_classifier:SetFlowClassifier"},{"line_number":50,"context_line":"    sfc_flow_classifier_show \u003d neutronclient.osc.v2.sfc.flow_classifier:ShowFlowClassifier"},{"line_number":51,"context_line":"    sfc_port_chain_create \u003d neutronclient.osc.v2.sfc.port_chain:CreatePortChain"},{"line_number":52,"context_line":"    sfc_port_chain_delete \u003d neutronclient.osc.v2.sfc.port_chain:DeletePortChain"},{"line_number":53,"context_line":"    sfc_port_chain_list \u003d neutronclient.osc.v2.sfc.port_chain:ListPortChain"},{"line_number":54,"context_line":"    sfc_port_chain_set \u003d neutronclient.osc.v2.sfc.port_chain:SetPortChain"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"3a461143_7e9ef6b9","line":51,"range":{"start_line":51,"start_character":53,"end_line":51,"end_character":63},"updated":"2017-01-31 09:08:42.000000000","message":"ditto (Append sfc_)","commit_id":"294be60e225390aba150987a47c50eafea863199"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"13f25447f0b3fe3090d3bb4642ce3fe11154016c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    sfc_port_chain_list \u003d neutronclient.osc.v2.sfc.port_chain:ListPortChain"},{"line_number":54,"context_line":"    sfc_port_chain_set \u003d neutronclient.osc.v2.sfc.port_chain:SetPortChain"},{"line_number":55,"context_line":"    sfc_port_chain_show \u003d neutronclient.osc.v2.sfc.port_chain:ShowPortChain"},{"line_number":56,"context_line":"    sfc_port_pair_create \u003d neutronclient.osc.v2.sfc.port_pair:CreatePortPair"},{"line_number":57,"context_line":"    sfc_port_pair_delete \u003d neutronclient.osc.v2.sfc.port_pair:DeletePortPair"},{"line_number":58,"context_line":"    sfc_port_pair_list \u003d neutronclient.osc.v2.sfc.port_pair:ListPortPair"},{"line_number":59,"context_line":"    sfc_port_pair_set \u003d neutronclient.osc.v2.sfc.port_pair:SetPortPair"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"3a461143_9ea1e2fa","line":56,"range":{"start_line":56,"start_character":52,"end_line":56,"end_character":61},"updated":"2017-01-31 09:08:42.000000000","message":"ditto (Append sfc_)","commit_id":"294be60e225390aba150987a47c50eafea863199"},{"author":{"_account_id":14605,"name":"vikram.choudhary","email":"vikschw@gmail.com","username":"vikram.choudhary"},"change_message_id":"13f25447f0b3fe3090d3bb4642ce3fe11154016c","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    sfc_port_pair_list \u003d neutronclient.osc.v2.sfc.port_pair:ListPortPair"},{"line_number":59,"context_line":"    sfc_port_pair_set \u003d neutronclient.osc.v2.sfc.port_pair:SetPortPair"},{"line_number":60,"context_line":"    sfc_port_pair_show \u003d neutronclient.osc.v2.sfc.port_pair:ShowPortPair"},{"line_number":61,"context_line":"    sfc_port_pair_group_create \u003d neutronclient.osc.v2.sfc.port_pair_group:CreatePortPairGroup"},{"line_number":62,"context_line":"    sfc_port_pair_group_delete \u003d neutronclient.osc.v2.sfc.port_pair_group:DeletePortPairGroup"},{"line_number":63,"context_line":"    sfc_port_pair_group_list \u003d neutronclient.osc.v2.sfc.port_pair_group:ListPortPairGroup"},{"line_number":64,"context_line":"    sfc_port_pair_group_set \u003d neutronclient.osc.v2.sfc.port_pair_group:SetPortPairGroup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"3a461143_1eaed2e5","line":61,"range":{"start_line":61,"start_character":58,"end_line":61,"end_character":73},"updated":"2017-01-31 09:08:42.000000000","message":"ditto (Append sfc_)","commit_id":"294be60e225390aba150987a47c50eafea863199"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"f12773ac0a9b2ed786d1fdc0e6f4eba3835360ed","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    sfc_port_pair_list \u003d neutronclient.osc.v2.sfc.sfc_port_pair:ListSfcPortPair"},{"line_number":59,"context_line":"    sfc_port_pair_set \u003d neutronclient.osc.v2.sfc.sfc_port_pair:SetSfcPortPair"},{"line_number":60,"context_line":"    sfc_port_pair_show \u003d neutronclient.osc.v2.sfc.sfc_port_pair:ShowSfcPortPair"},{"line_number":61,"context_line":"    sfc_port_pair_group_create \u003d neutronclient.osc.v2.sfc_port_pair_group:CreateSfcPortPairGroup"},{"line_number":62,"context_line":"    sfc_port_pair_group_delete \u003d neutronclient.osc.v2.sfc.sfc_port_pair_group:DeleteSfcPortPairGroup"},{"line_number":63,"context_line":"    sfc_port_pair_group_list \u003d neutronclient.osc.v2.sfc.sfc_port_pair_group:ListSfcPortPairGroup"},{"line_number":64,"context_line":"    sfc_port_pair_group_set \u003d neutronclient.osc.v2.sfc.sfc_port_pair_group:SetSfcPortPairGroup"}],"source_content_type":"text/x-ttcn-cfg","patch_set":22,"id":"fa31d9ce_13cce1b9","line":61,"range":{"start_line":61,"start_character":33,"end_line":61,"end_character":96},"updated":"2017-02-16 03:07:26.000000000","message":"incorrect path","commit_id":"ab858ac8178da88bf00de0f9293bc925fd888630"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1a1e0950cbaac29901c7ffb8ef0998db8e092190","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    network_trunk_list \u003d neutronclient.osc.v2.trunk.network_trunk:ListNetworkTrunk"},{"line_number":43,"context_line":"    network_trunk_set \u003d neutronclient.osc.v2.trunk.network_trunk:SetNetworkTrunk"},{"line_number":44,"context_line":"    network_trunk_show \u003d neutronclient.osc.v2.trunk.network_trunk:ShowNetworkTrunk"},{"line_number":45,"context_line":"    network_trunk_unset \u003d neutronclient.osc.v2.trunk.network_trunk:UnsetNetworkTrunk"},{"line_number":46,"context_line":"    sfc_flow_classifier_create \u003d neutronclient.osc.v2.sfc.sfc_flow_classifier:CreateSfcFlowClassifier"},{"line_number":47,"context_line":"    sfc_flow_classifier_delete \u003d neutronclient.osc.v2.sfc.sfc_flow_classifier:DeleteSfcFlowClassifier"},{"line_number":48,"context_line":"    sfc_flow_classifier_list \u003d neutronclient.osc.v2.sfc.sfc_flow_classifier:ListSfcFlowClassifier"}],"source_content_type":"text/x-ttcn-cfg","patch_set":38,"id":"7f231b9d_a83d31c5","line":45,"updated":"2017-06-15 01:05:41.000000000","message":"A blank line here would be nice.","commit_id":"1c204d0639cc36d066945cdfb8942119eb6bda35"}]}
