)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"88251543aa21a7ae29c1aa4fedb8a0d179256244","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: If9a5e0e3958ea32f4c0d3573efcb3ac4101c63a6"},{"line_number":13,"context_line":"Partially-implements: blueprint security-group-logging"},{"line_number":14,"context_line":"Depends-On: Iace31506502de25da9dce5fcfdbfe2c726bea27f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"5f201791_66fb78c0","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":53},"updated":"2017-06-28 08:49:27.000000000","message":"Maybe I was wrong.  This link should be API or DB patch.  Therefore, could you change \u0027Depends-On\u0027 as follows?\n\nDepends-On: I00642f6db650e6f546feb4ea9e394da1d603f6e1\nDepends-On: I3f91b3927c33021facc9eb9238555c0e06a918c0","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"}],"doc/source/cli/osc/v2/network-log.rst":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a3df1a6284e2404282e087b57cdeab7114b69d7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network log** is a container to group security groups or ports for logging."},{"line_number":6,"context_line":"Specified resources can be logged via these event(**ALL**, **ACCEPT** or"},{"line_number":7,"context_line":"**DROP**)."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1f1a1f67_9c75a49b","line":6,"range":{"start_line":6,"start_character":49,"end_line":6,"end_character":50},"updated":"2017-07-12 11:32:14.000000000","message":"Needs a space here.","commit_id":"8611bbe07b59b16ad240dd94a54769d81882af5f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a3df1a6284e2404282e087b57cdeab7114b69d7","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network log** is a container to group security groups or ports for logging."},{"line_number":6,"context_line":"Specified resources can be logged via these event(**ALL**, **ACCEPT** or"},{"line_number":7,"context_line":"**DROP**)."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1f1a1f67_1c6994bd","line":6,"range":{"start_line":6,"start_character":50,"end_line":6,"end_character":57},"updated":"2017-07-12 11:32:14.000000000","message":"``ALL`` is a usual convention.","commit_id":"8611bbe07b59b16ad240dd94a54769d81882af5f"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f9b05121d1999bab8893e76ed4109548f2683688","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network log** is a container to group security groups or ports for logging."},{"line_number":6,"context_line":"Specified resources can be logged via these event(**ALL**, **ACCEPT** or"},{"line_number":7,"context_line":"**DROP**)."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1f1a1f67_332109b6","line":6,"range":{"start_line":6,"start_character":50,"end_line":6,"end_character":57},"in_reply_to":"1f1a1f67_1c6994bd","updated":"2017-07-12 23:48:27.000000000","message":"Done","commit_id":"8611bbe07b59b16ad240dd94a54769d81882af5f"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f9b05121d1999bab8893e76ed4109548f2683688","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network log** is a container to group security groups or ports for logging."},{"line_number":6,"context_line":"Specified resources can be logged via these event(**ALL**, **ACCEPT** or"},{"line_number":7,"context_line":"**DROP**)."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":21,"id":"1f1a1f67_132e0da5","line":6,"range":{"start_line":6,"start_character":49,"end_line":6,"end_character":50},"in_reply_to":"1f1a1f67_9c75a49b","updated":"2017-07-12 23:48:27.000000000","message":"Done","commit_id":"8611bbe07b59b16ad240dd94a54769d81882af5f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"A **network log** is a container to group security groups or ports for logging."},{"line_number":6,"context_line":"Specified resources can be logged via these event (``ALL``, ``ACCEPT`` or"},{"line_number":7,"context_line":"``DROP``)."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Network v2"}],"source_content_type":"text/x-rst","patch_set":25,"id":"ff346bd7_3a0829d8","line":6,"range":{"start_line":6,"start_character":0,"end_line":6,"end_character":50},"updated":"2017-10-13 12:16:12.000000000","message":"How about:\n\n  Specified resources with specified event(s) will be logged.","commit_id":"f9d4502af9639d68aea0b8982e3bb437718ced4f"}],"neutronclient/osc/v2/logging/network_log.py":[{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"fe59ac3b553d4364d8bcc40f862f8956f8789a04","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 FUJTISU LIMITED."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_a793bba2","line":2,"updated":"2016-12-13 03:28:39.000000000","message":"Hi Furukawa-san, \n\nThanks for great works. I think we should change the \u0027file name\u0027 from \u0027network_log\u0027 to \u0027logging_resources\u0027. How do you think?","commit_id":"3b49f9bd71ba5ab8eb3c8dabf946b787a9ebbb36"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"79ba20db9af092cd9083c74a81e5673fb589d738","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 FUJTISU LIMITED."},{"line_number":2,"context_line":"# All Rights Reserved"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a6eadb0_742e2f44","line":2,"in_reply_to":"1a6eadb0_a793bba2","updated":"2016-12-15 08:49:34.000000000","message":"Thanks.  I have 2 reasons about a naming \u0027network_log\u0027.\n\n*  I think \u0027logging_resources\u0027 includes wide meaning.  Our proposing feature is for network resource(sg, fw).\n* I think tt should be aligned with command format and method name.  If we changed \u0027logging_resource\u0027, we have to execute  \u0027openstack logging resource create .....\u0027.   I feel it\u0027s long.  \u0027openstack network log create ..\u0027 is better.\n\nWhat do you think?","commit_id":"3b49f9bd71ba5ab8eb3c8dabf946b787a9ebbb36"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027Description of the network log\u0027))"},{"line_number":54,"context_line":"    parser.add_argument("},{"line_number":55,"context_line":"        \u0027--event\u0027,"},{"line_number":56,"context_line":"        metavar\u003d\u0027\u003cevent\u003e\u0027,"},{"line_number":57,"context_line":"        choices\u003d[\u0027all\u0027, \u0027accept\u0027, \u0027drop\u0027],"},{"line_number":58,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_848ff173","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":16},"updated":"2017-05-23 05:31:36.000000000","message":"This attribute is for create only and not update able (see spec\u0027s data model impact or rest api impact section). Right? If so, We need to move this option to \"CreateNetworkLog\". If not, It will affect to update case.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        metavar\u003d\u0027\u003cdescription\u003e\u0027,"},{"line_number":53,"context_line":"        help\u003d_(\u0027Description of the network log\u0027))"},{"line_number":54,"context_line":"    parser.add_argument("},{"line_number":55,"context_line":"        \u0027--event\u0027,"},{"line_number":56,"context_line":"        metavar\u003d\u0027\u003cevent\u003e\u0027,"},{"line_number":57,"context_line":"        choices\u003d[\u0027all\u0027, \u0027accept\u0027, \u0027drop\u0027],"},{"line_number":58,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_e939e5d6","line":55,"range":{"start_line":55,"start_character":9,"end_line":55,"end_character":16},"in_reply_to":"ff0f0b1f_848ff173","updated":"2017-05-23 07:08:18.000000000","message":"You\u0027re right.  I\u0027ll align with our SPEC.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":59,"context_line":"        help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":60,"context_line":"    # TODO(yushiro) \u0027--resource-type\u0027 is managed by following command:"},{"line_number":61,"context_line":"    # \"openstack network log supported list\".  Therefore, this option shouldn\u0027t"},{"line_number":62,"context_line":"    # have \"choices\" like [\u0027security_group\u0027]"},{"line_number":63,"context_line":"    parser.add_argument("},{"line_number":64,"context_line":"        \u0027--resource-type\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_a9ce507f","line":61,"range":{"start_line":61,"start_character":7,"end_line":61,"end_character":43},"updated":"2017-05-23 05:31:36.000000000","message":"This needs to be updated accordingly.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":59,"context_line":"        help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":60,"context_line":"    # TODO(yushiro) \u0027--resource-type\u0027 is managed by following command:"},{"line_number":61,"context_line":"    # \"openstack network log supported list\".  Therefore, this option shouldn\u0027t"},{"line_number":62,"context_line":"    # have \"choices\" like [\u0027security_group\u0027]"},{"line_number":63,"context_line":"    parser.add_argument("},{"line_number":64,"context_line":"        \u0027--resource-type\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_a92f6d86","line":61,"range":{"start_line":61,"start_character":7,"end_line":61,"end_character":43},"in_reply_to":"ff0f0b1f_a9ce507f","updated":"2017-05-23 07:08:18.000000000","message":"Yes.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # \"openstack network log supported list\".  Therefore, this option shouldn\u0027t"},{"line_number":62,"context_line":"    # have \"choices\" like [\u0027security_group\u0027]"},{"line_number":63,"context_line":"    parser.add_argument("},{"line_number":64,"context_line":"        \u0027--resource-type\u0027,"},{"line_number":65,"context_line":"        metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":66,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":67,"context_line":"        help\u003d_(\u0027Network log type (default is \"security_group\") \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_44eb1912","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":24},"updated":"2017-05-23 05:31:36.000000000","message":"ditto","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    # \"openstack network log supported list\".  Therefore, this option shouldn\u0027t"},{"line_number":62,"context_line":"    # have \"choices\" like [\u0027security_group\u0027]"},{"line_number":63,"context_line":"    parser.add_argument("},{"line_number":64,"context_line":"        \u0027--resource-type\u0027,"},{"line_number":65,"context_line":"        metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":66,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":67,"context_line":"        help\u003d_(\u0027Network log type (default is \"security_group\") \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_894ee96c","line":64,"range":{"start_line":64,"start_character":9,"end_line":64,"end_character":24},"in_reply_to":"ff0f0b1f_44eb1912","updated":"2017-05-23 07:08:18.000000000","message":"I\u0027ll fix it.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027--resource-type\u0027,"},{"line_number":65,"context_line":"        metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":66,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":67,"context_line":"        help\u003d_(\u0027Network log type (default is \"security_group\") \u0027"},{"line_number":68,"context_line":"               \u0027You can see supported types with following command: \u0027"},{"line_number":69,"context_line":"               \u0027openstack network log supported list\u0027))"},{"line_number":70,"context_line":"    enable_group \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_e9ad689b","line":67,"range":{"start_line":67,"start_character":28,"end_line":67,"end_character":32},"updated":"2017-05-23 05:31:36.000000000","message":"I think it should be \"type(s)\"","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        \u0027--resource-type\u0027,"},{"line_number":65,"context_line":"        metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":66,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":67,"context_line":"        help\u003d_(\u0027Network log type (default is \"security_group\") \u0027"},{"line_number":68,"context_line":"               \u0027You can see supported types with following command: \u0027"},{"line_number":69,"context_line":"               \u0027openstack network log supported list\u0027))"},{"line_number":70,"context_line":"    enable_group \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_69539518","line":67,"range":{"start_line":67,"start_character":28,"end_line":67,"end_character":32},"in_reply_to":"ff0f0b1f_e9ad689b","updated":"2017-05-23 07:08:18.000000000","message":"I\u0027ll fix it.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":66,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":67,"context_line":"        help\u003d_(\u0027Network log type (default is \"security_group\") \u0027"},{"line_number":68,"context_line":"               \u0027You can see supported types with following command: \u0027"},{"line_number":69,"context_line":"               \u0027openstack network log supported list\u0027))"},{"line_number":70,"context_line":"    enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":71,"context_line":"    enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_c996244d","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":43},"updated":"2017-05-23 05:31:36.000000000","message":"ditto","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":66,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":67,"context_line":"        help\u003d_(\u0027Network log type (default is \"security_group\") \u0027"},{"line_number":68,"context_line":"               \u0027You can see supported types with following command: \u0027"},{"line_number":69,"context_line":"               \u0027openstack network log supported list\u0027))"},{"line_number":70,"context_line":"    enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":71,"context_line":"    enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_495451fe","line":68,"range":{"start_line":68,"start_character":38,"end_line":68,"end_character":43},"in_reply_to":"ff0f0b1f_c996244d","updated":"2017-05-23 07:08:18.000000000","message":"I\u0027ll fix it.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":67,"context_line":"        help\u003d_(\u0027Network log type (default is \"security_group\") \u0027"},{"line_number":68,"context_line":"               \u0027You can see supported types with following command: \u0027"},{"line_number":69,"context_line":"               \u0027openstack network log supported list\u0027))"},{"line_number":70,"context_line":"    enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":71,"context_line":"    enable_group.add_argument("},{"line_number":72,"context_line":"        \u0027--enable-log\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_09a9bc8e","line":69,"range":{"start_line":69,"start_character":16,"end_line":69,"end_character":52},"updated":"2017-05-23 05:31:36.000000000","message":"ditto","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        type\u003dnc_utils.convert_to_lowercase,"},{"line_number":67,"context_line":"        help\u003d_(\u0027Network log type (default is \"security_group\") \u0027"},{"line_number":68,"context_line":"               \u0027You can see supported types with following command: \u0027"},{"line_number":69,"context_line":"               \u0027openstack network log supported list\u0027))"},{"line_number":70,"context_line":"    enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":71,"context_line":"    enable_group.add_argument("},{"line_number":72,"context_line":"        \u0027--enable-log\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_29591d34","line":69,"range":{"start_line":69,"start_character":16,"end_line":69,"end_character":52},"in_reply_to":"ff0f0b1f_09a9bc8e","updated":"2017-05-23 07:08:18.000000000","message":"I\u0027ll fix it.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        help\u003d_(\u0027Disable this log\u0027))"},{"line_number":79,"context_line":"    resource_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":80,"context_line":"    resource_id_group.add_argument("},{"line_number":81,"context_line":"        \u0027--resource\u0027,"},{"line_number":82,"context_line":"        metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":83,"context_line":"        help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":84,"context_line":"               \u0027If this option is specified, only this resource\\\u0027s event \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_4462f9af","line":81,"range":{"start_line":81,"start_character":9,"end_line":81,"end_character":19},"updated":"2017-05-23 05:31:36.000000000","message":"I\u0027m not sure this option can be update able or not? I see it can\u0027t according to spec.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        help\u003d_(\u0027Disable this log\u0027))"},{"line_number":79,"context_line":"    resource_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":80,"context_line":"    resource_id_group.add_argument("},{"line_number":81,"context_line":"        \u0027--resource\u0027,"},{"line_number":82,"context_line":"        metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":83,"context_line":"        help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":84,"context_line":"               \u0027If this option is specified, only this resource\\\u0027s event \u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_493e918b","line":81,"range":{"start_line":81,"start_character":9,"end_line":81,"end_character":19},"in_reply_to":"ff0f0b1f_4462f9af","updated":"2017-05-23 07:08:18.000000000","message":"I checked it and realized this is create only.  I\u0027ll update it.\n\n* \u0027resource_id\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: False, ...}\n\nhttps://review.openstack.org/#/c/203509/66/specs/pike/logging-API-for-security-group-rules.rst\nLine #413","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        \u0027--resource\u0027,"},{"line_number":82,"context_line":"        metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":83,"context_line":"        help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":84,"context_line":"               \u0027If this option is specified, only this resource\\\u0027s event \u0027"},{"line_number":85,"context_line":"               \u0027will be collected\u0027))"},{"line_number":86,"context_line":"    resource_id_group.add_argument("},{"line_number":87,"context_line":"        \u0027--no-resource\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_8975cc34","line":84,"range":{"start_line":84,"start_character":63,"end_line":84,"end_character":64},"updated":"2017-05-23 05:31:36.000000000","message":"Is this redundant? I\u0027m not sure this slash.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        \u0027--resource\u0027,"},{"line_number":82,"context_line":"        metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":83,"context_line":"        help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":84,"context_line":"               \u0027If this option is specified, only this resource\\\u0027s event \u0027"},{"line_number":85,"context_line":"               \u0027will be collected\u0027))"},{"line_number":86,"context_line":"    resource_id_group.add_argument("},{"line_number":87,"context_line":"        \u0027--no-resource\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_496d71ca","line":84,"range":{"start_line":84,"start_character":63,"end_line":84,"end_character":64},"in_reply_to":"ff0f0b1f_8975cc34","updated":"2017-05-23 07:08:18.000000000","message":"Because I\u0027d like to use \" \u0027 \"  in \u0027\u0027 section.  If there is no constraint to use double quote, I\u0027ll modify as follows:\n\n\"A resource which is enabled to be logged (name or ID). \"\n\"If this option is specified, only this resource\u0027s event \"\n\"will be collected\"","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    resource_id_group.add_argument("},{"line_number":87,"context_line":"        \u0027--no-resource\u0027,"},{"line_number":88,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":89,"context_line":"        help\u003d_(\u0027Detach target resource from logging.\u0027))"},{"line_number":90,"context_line":"    target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":91,"context_line":"    target_id_group.add_argument("},{"line_number":92,"context_line":"        \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_c9a4e4a8","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":52},"updated":"2017-05-23 05:31:36.000000000","message":"No period with only one sentence. It applies for all.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    resource_id_group.add_argument("},{"line_number":87,"context_line":"        \u0027--no-resource\u0027,"},{"line_number":88,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":89,"context_line":"        help\u003d_(\u0027Detach target resource from logging.\u0027))"},{"line_number":90,"context_line":"    target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":91,"context_line":"    target_id_group.add_argument("},{"line_number":92,"context_line":"        \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_2980fd45","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":52},"in_reply_to":"ff0f0b1f_c9a4e4a8","updated":"2017-05-23 07:08:18.000000000","message":"OK. I still confusing whether a period is necessary or not.  In previous review, I got some comment \"add period\" but didn\u0027t know such detail situation.  OK, I\u0027ll reflect all my patch.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"63fde173fa68cd05b1999f2d22166ce1da2b825b","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        help\u003d_(\u0027Detach target resource from logging.\u0027))"},{"line_number":90,"context_line":"    target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":91,"context_line":"    target_id_group.add_argument("},{"line_number":92,"context_line":"        \u0027--target\u0027,"},{"line_number":93,"context_line":"        metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":94,"context_line":"        help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":95,"context_line":"               \u0027Supported target is port\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_045881f7","line":92,"range":{"start_line":92,"start_character":9,"end_line":92,"end_character":17},"updated":"2017-05-23 05:31:36.000000000","message":"I\u0027m not sure this option can be update able or not too? I see it can\u0027t according to spec.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"cf13ef535e9c00643a32a25d505bc243c70d8b45","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        help\u003d_(\u0027Detach target resource from logging.\u0027))"},{"line_number":90,"context_line":"    target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":91,"context_line":"    target_id_group.add_argument("},{"line_number":92,"context_line":"        \u0027--target\u0027,"},{"line_number":93,"context_line":"        metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":94,"context_line":"        help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":95,"context_line":"               \u0027Supported target is port\u0027))"}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_e9da0576","line":92,"range":{"start_line":92,"start_character":9,"end_line":92,"end_character":17},"in_reply_to":"ff0f0b1f_045881f7","updated":"2017-05-23 07:08:18.000000000","message":"This is create only.  I\u0027ll update it.\n\nhttps://review.openstack.org/#/c/203509/66/specs/pike/logging-API-for-security-group-rules.rst\nLine #419","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        help\u003d_(\u0027Description of the network log\u0027))"},{"line_number":54,"context_line":"    enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":55,"context_line":"    enable_group.add_argument("},{"line_number":56,"context_line":"        \u0027--enable-log\u0027,"},{"line_number":57,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":58,"context_line":"        help\u003d_(\u0027Enable this log (default is disabled)\u0027))"},{"line_number":59,"context_line":"    enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_e047b24b","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":21},"updated":"2017-05-23 10:08:52.000000000","message":"According to the spec, This option should be \"enable\"","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e4dd509243097aad448e057074de1262e30fdb58","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        help\u003d_(\u0027Description of the network log\u0027))"},{"line_number":54,"context_line":"    enable_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":55,"context_line":"    enable_group.add_argument("},{"line_number":56,"context_line":"        \u0027--enable-log\u0027,"},{"line_number":57,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":58,"context_line":"        help\u003d_(\u0027Enable this log (default is disabled)\u0027))"},{"line_number":59,"context_line":"    enable_group.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_4353dee2","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":21},"in_reply_to":"ff0f0b1f_e047b24b","updated":"2017-05-24 11:09:52.000000000","message":"Done","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":58,"context_line":"        help\u003d_(\u0027Enable this log (default is disabled)\u0027))"},{"line_number":59,"context_line":"    enable_group.add_argument("},{"line_number":60,"context_line":"        \u0027--disable-log\u0027,"},{"line_number":61,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":62,"context_line":"        help\u003d_(\u0027Disable this log\u0027))"},{"line_number":63,"context_line":"    return parser"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_c05dce15","line":60,"range":{"start_line":60,"start_character":11,"end_line":60,"end_character":22},"updated":"2017-05-23 10:08:52.000000000","message":"According to the spec, This option should be \"disable\"","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e4dd509243097aad448e057074de1262e30fdb58","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":58,"context_line":"        help\u003d_(\u0027Enable this log (default is disabled)\u0027))"},{"line_number":59,"context_line":"    enable_group.add_argument("},{"line_number":60,"context_line":"        \u0027--disable-log\u0027,"},{"line_number":61,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":62,"context_line":"        help\u003d_(\u0027Disable this log\u0027))"},{"line_number":63,"context_line":"    return parser"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_234eaa37","line":60,"range":{"start_line":60,"start_character":11,"end_line":60,"end_character":22},"in_reply_to":"ff0f0b1f_c05dce15","updated":"2017-05-24 11:09:52.000000000","message":"Done","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if parsed_args.no_target:"},{"line_number":87,"context_line":"            attrs[\u0027target_id\u0027] \u003d None"},{"line_number":88,"context_line":"        if parsed_args.event:"},{"line_number":89,"context_line":"            attrs[\u0027security_event\u0027] \u003d str(parsed_args.event)"},{"line_number":90,"context_line":"        if parsed_args.resource_type:"},{"line_number":91,"context_line":"            attrs[\u0027resource_type\u0027] \u003d str(parsed_args.resource_type)"},{"line_number":92,"context_line":"    if parsed_args.enable_log:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_2096ca4d","line":89,"range":{"start_line":89,"start_character":19,"end_line":89,"end_character":33},"updated":"2017-05-23 10:08:52.000000000","message":"According to the spec: This attribute should be \"event\". Right?","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if parsed_args.no_target:"},{"line_number":87,"context_line":"            attrs[\u0027target_id\u0027] \u003d None"},{"line_number":88,"context_line":"        if parsed_args.event:"},{"line_number":89,"context_line":"            attrs[\u0027security_event\u0027] \u003d str(parsed_args.event)"},{"line_number":90,"context_line":"        if parsed_args.resource_type:"},{"line_number":91,"context_line":"            attrs[\u0027resource_type\u0027] \u003d str(parsed_args.resource_type)"},{"line_number":92,"context_line":"    if parsed_args.enable_log:"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_61be01b5","line":89,"range":{"start_line":89,"start_character":19,"end_line":89,"end_character":33},"in_reply_to":"ff0f0b1f_2096ca4d","updated":"2017-05-23 13:31:15.000000000","message":"Yes.  I\u0027ll fix it.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"f85e73ea43b50326e88c4f62faf86289d0c87576","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        _get_common_parser(parser)"},{"line_number":112,"context_line":"        osc_utils.add_project_owner_option_to_parser(parser)"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027name\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":116,"context_line":"            help\u003d_(\u0027Name for the network log\u0027))"},{"line_number":117,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_149c2268","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":18},"updated":"2017-05-23 14:33:13.000000000","message":"According to OSC guideline, this option is required.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"72f96a7ddb012ef26b3e95df555a1fddecbdb398","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        _get_common_parser(parser)"},{"line_number":112,"context_line":"        osc_utils.add_project_owner_option_to_parser(parser)"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027name\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":116,"context_line":"            help\u003d_(\u0027Name for the network log\u0027))"},{"line_number":117,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_770b6023","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":18},"in_reply_to":"ff0f0b1f_149c2268","updated":"2017-05-23 14:42:06.000000000","message":"Ah, this is position argument (already required). Please ignore this comment :-)","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e4dd509243097aad448e057074de1262e30fdb58","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        _get_common_parser(parser)"},{"line_number":112,"context_line":"        osc_utils.add_project_owner_option_to_parser(parser)"},{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027name\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":116,"context_line":"            help\u003d_(\u0027Name for the network log\u0027))"},{"line_number":117,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_19aa0484","line":114,"range":{"start_line":114,"start_character":12,"end_line":114,"end_character":18},"in_reply_to":"ff0f0b1f_770b6023","updated":"2017-05-24 11:09:52.000000000","message":"OK.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"f85e73ea43b50326e88c4f62faf86289d0c87576","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"},{"line_number":125,"context_line":"        # shouldn\u0027t have \"choices\" like [\u0027security_group\u0027]"},{"line_number":126,"context_line":"        parser.add_argument("},{"line_number":127,"context_line":"            \u0027--resource-type\u0027,"},{"line_number":128,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":129,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":130,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\") \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_14754232","line":127,"range":{"start_line":127,"start_character":13,"end_line":127,"end_character":28},"updated":"2017-05-23 14:33:13.000000000","message":"According to OSC guideline, this option is required. Consider for remaining options if I missed.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"72f96a7ddb012ef26b3e95df555a1fddecbdb398","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"},{"line_number":125,"context_line":"        # shouldn\u0027t have \"choices\" like [\u0027security_group\u0027]"},{"line_number":126,"context_line":"        parser.add_argument("},{"line_number":127,"context_line":"            \u0027--resource-type\u0027,"},{"line_number":128,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":129,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":130,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\") \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_f7165049","line":127,"range":{"start_line":127,"start_character":13,"end_line":127,"end_character":28},"in_reply_to":"ff0f0b1f_14754232","updated":"2017-05-23 14:42:06.000000000","message":"s/According to OSC guideline/According to the spec","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e4dd509243097aad448e057074de1262e30fdb58","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"},{"line_number":125,"context_line":"        # shouldn\u0027t have \"choices\" like [\u0027security_group\u0027]"},{"line_number":126,"context_line":"        parser.add_argument("},{"line_number":127,"context_line":"            \u0027--resource-type\u0027,"},{"line_number":128,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":129,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":130,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\") \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_fc429e0e","line":127,"range":{"start_line":127,"start_character":13,"end_line":127,"end_character":28},"in_reply_to":"ff0f0b1f_f7165049","updated":"2017-05-24 11:09:52.000000000","message":"I\u0027ll add required\u003dTrue.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            \u0027--resource-type\u0027,"},{"line_number":128,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":129,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":130,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\") \u0027"},{"line_number":131,"context_line":"                   \u0027You can see supported type(s) with following command: \u0027"},{"line_number":132,"context_line":"                   \u0027openstack network loggable resource list\u0027))"},{"line_number":133,"context_line":"        resource_id_group \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_5a8091bf","line":130,"range":{"start_line":130,"start_character":69,"end_line":130,"end_character":70},"updated":"2017-05-23 10:08:52.000000000","message":"nit: missing period before space here.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            \u0027--resource-type\u0027,"},{"line_number":128,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":129,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":130,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\") \u0027"},{"line_number":131,"context_line":"                   \u0027You can see supported type(s) with following command: \u0027"},{"line_number":132,"context_line":"                   \u0027openstack network loggable resource list\u0027))"},{"line_number":133,"context_line":"        resource_id_group \u003d parser.add_mutually_exclusive_group()"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_e1ce9158","line":130,"range":{"start_line":130,"start_character":69,"end_line":130,"end_character":70},"in_reply_to":"ff0f0b1f_5a8091bf","updated":"2017-05-23 13:31:15.000000000","message":"Done","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                   \u0027openstack network loggable resource list\u0027))"},{"line_number":133,"context_line":"        resource_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":134,"context_line":"        resource_id_group.add_argument("},{"line_number":135,"context_line":"            \u0027--resource\u0027,"},{"line_number":136,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":137,"context_line":"            help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":138,"context_line":"                   \u0027If this option is specified, only this resource\\\u0027s event \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_605722cc","line":135,"range":{"start_line":135,"start_character":13,"end_line":135,"end_character":23},"updated":"2017-05-23 10:08:52.000000000","message":"According to the spec: This option should be \"--resource-id\"","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":132,"context_line":"                   \u0027openstack network loggable resource list\u0027))"},{"line_number":133,"context_line":"        resource_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":134,"context_line":"        resource_id_group.add_argument("},{"line_number":135,"context_line":"            \u0027--resource\u0027,"},{"line_number":136,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":137,"context_line":"            help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":138,"context_line":"                   \u0027If this option is specified, only this resource\\\u0027s event \u0027"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_6131615a","line":135,"range":{"start_line":135,"start_character":13,"end_line":135,"end_character":23},"in_reply_to":"ff0f0b1f_605722cc","updated":"2017-05-23 13:31:15.000000000","message":"--resource is better because CLI can specify both **name** or **ID**.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":138,"context_line":"                   \u0027If this option is specified, only this resource\\\u0027s event \u0027"},{"line_number":139,"context_line":"                   \u0027will be collected.\u0027))"},{"line_number":140,"context_line":"        resource_id_group.add_argument("},{"line_number":141,"context_line":"            \u0027--no-resource\u0027,"},{"line_number":142,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":143,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":144,"context_line":"        target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":145,"context_line":"        target_id_group.add_argument("},{"line_number":146,"context_line":"            \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_c0670eb7","line":143,"range":{"start_line":140,"start_character":8,"end_line":143,"end_character":58},"updated":"2017-05-23 10:08:52.000000000","message":"I don\u0027t understand a purpose of this option? This option isn\u0027t included in spec.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"f85e73ea43b50326e88c4f62faf86289d0c87576","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":138,"context_line":"                   \u0027If this option is specified, only this resource\\\u0027s event \u0027"},{"line_number":139,"context_line":"                   \u0027will be collected.\u0027))"},{"line_number":140,"context_line":"        resource_id_group.add_argument("},{"line_number":141,"context_line":"            \u0027--no-resource\u0027,"},{"line_number":142,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":143,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":144,"context_line":"        target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":145,"context_line":"        target_id_group.add_argument("},{"line_number":146,"context_line":"            \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_b2046919","line":143,"range":{"start_line":140,"start_character":8,"end_line":143,"end_character":58},"in_reply_to":"ff0f0b1f_2116c956","updated":"2017-05-23 14:33:13.000000000","message":"I have just double checked. This option is not required. In case we don\u0027t want to specify resource, we can leave it and don\u0027t need to specify \"--no-resource\" option. As its default value is None. Though? :-)","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e4dd509243097aad448e057074de1262e30fdb58","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":138,"context_line":"                   \u0027If this option is specified, only this resource\\\u0027s event \u0027"},{"line_number":139,"context_line":"                   \u0027will be collected.\u0027))"},{"line_number":140,"context_line":"        resource_id_group.add_argument("},{"line_number":141,"context_line":"            \u0027--no-resource\u0027,"},{"line_number":142,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":143,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":144,"context_line":"        target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":145,"context_line":"        target_id_group.add_argument("},{"line_number":146,"context_line":"            \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_a3de3a3b","line":143,"range":{"start_line":140,"start_character":8,"end_line":143,"end_character":58},"in_reply_to":"ff0f0b1f_b2046919","updated":"2017-05-24 11:09:52.000000000","message":"Sorry. I thought this option was necessary in case of \u0027set\u0027.  I\u0027ll follow your comment.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":138,"context_line":"                   \u0027If this option is specified, only this resource\\\u0027s event \u0027"},{"line_number":139,"context_line":"                   \u0027will be collected.\u0027))"},{"line_number":140,"context_line":"        resource_id_group.add_argument("},{"line_number":141,"context_line":"            \u0027--no-resource\u0027,"},{"line_number":142,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":143,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":144,"context_line":"        target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":145,"context_line":"        target_id_group.add_argument("},{"line_number":146,"context_line":"            \u0027--target\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_2116c956","line":143,"range":{"start_line":140,"start_character":8,"end_line":143,"end_character":58},"in_reply_to":"ff0f0b1f_c0670eb7","updated":"2017-05-23 13:31:15.000000000","message":"AFAIK, this is aligned with OSC guideline.  You should also take OSC guideline into consideration.  Detail implementation of OSC plugin should be discussed/decided in this phase.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":144,"context_line":"        target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":145,"context_line":"        target_id_group.add_argument("},{"line_number":146,"context_line":"            \u0027--target\u0027,"},{"line_number":147,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":148,"context_line":"            help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":149,"context_line":"                   \u0027Supported target is port\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_800b56d4","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":21},"updated":"2017-05-23 10:08:52.000000000","message":"This should be \"--target-id\"","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e4dd509243097aad448e057074de1262e30fdb58","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":144,"context_line":"        target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":145,"context_line":"        target_id_group.add_argument("},{"line_number":146,"context_line":"            \u0027--target\u0027,"},{"line_number":147,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":148,"context_line":"            help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":149,"context_line":"                   \u0027Supported target is port\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_a3b75af5","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":21},"in_reply_to":"ff0f0b1f_5c53e617","updated":"2017-05-24 11:09:52.000000000","message":"What do you think?","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":144,"context_line":"        target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":145,"context_line":"        target_id_group.add_argument("},{"line_number":146,"context_line":"            \u0027--target\u0027,"},{"line_number":147,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":148,"context_line":"            help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":149,"context_line":"                   \u0027Supported target is port\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_5c53e617","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":21},"in_reply_to":"ff0f0b1f_800b56d4","updated":"2017-05-23 13:31:15.000000000","message":"Hmm, I think it\u0027s more useful to specify both name or ID.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"0be90cbba494a4dee33ed0982bab648f3ffea0e0","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":144,"context_line":"        target_id_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":145,"context_line":"        target_id_group.add_argument("},{"line_number":146,"context_line":"            \u0027--target\u0027,"},{"line_number":147,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":148,"context_line":"            help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":149,"context_line":"                   \u0027Supported target is port\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_2e9af8b7","line":146,"range":{"start_line":146,"start_character":13,"end_line":146,"end_character":21},"in_reply_to":"ff0f0b1f_a3b75af5","updated":"2017-05-25 01:36:44.000000000","message":"Yeah. I think That\u0027s reasonable :-)","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            \u0027--target\u0027,"},{"line_number":147,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":148,"context_line":"            help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":149,"context_line":"                   \u0027Supported target is port\u0027))"},{"line_number":150,"context_line":"        target_id_group.add_argument("},{"line_number":151,"context_line":"            \u0027--no-target\u0027,"},{"line_number":152,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_9564ba23","line":149,"range":{"start_line":149,"start_character":44,"end_line":149,"end_character":45},"updated":"2017-05-23 10:08:52.000000000","message":"nit: missing period.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            \u0027--target\u0027,"},{"line_number":147,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":148,"context_line":"            help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":149,"context_line":"                   \u0027Supported target is port\u0027))"},{"line_number":150,"context_line":"        target_id_group.add_argument("},{"line_number":151,"context_line":"            \u0027--no-target\u0027,"},{"line_number":152,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_5c7c0682","line":149,"range":{"start_line":149,"start_character":44,"end_line":149,"end_character":45},"in_reply_to":"ff0f0b1f_9564ba23","updated":"2017-05-23 13:31:15.000000000","message":"I\u0027ll fix it.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":148,"context_line":"            help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":149,"context_line":"                   \u0027Supported target is port\u0027))"},{"line_number":150,"context_line":"        target_id_group.add_argument("},{"line_number":151,"context_line":"            \u0027--no-target\u0027,"},{"line_number":152,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":153,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":154,"context_line":"        return parser"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_00f746d5","line":153,"range":{"start_line":150,"start_character":8,"end_line":153,"end_character":58},"updated":"2017-05-23 10:08:52.000000000","message":"I don\u0027t understand a purpose of this option too? This option isn\u0027t included in spec.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            metavar\u003d\u0027\u003ctarget\u003e\u0027,"},{"line_number":148,"context_line":"            help\u003d_(\u0027Target resource for logging (name or ID). \u0027"},{"line_number":149,"context_line":"                   \u0027Supported target is port\u0027))"},{"line_number":150,"context_line":"        target_id_group.add_argument("},{"line_number":151,"context_line":"            \u0027--no-target\u0027,"},{"line_number":152,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":153,"context_line":"            help\u003d_(\u0027Detach target resource from logging\u0027))"},{"line_number":154,"context_line":"        return parser"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_fc6abab0","line":153,"range":{"start_line":150,"start_character":8,"end_line":153,"end_character":58},"in_reply_to":"ff0f0b1f_00f746d5","updated":"2017-05-23 13:31:15.000000000","message":"Ditto #143.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        data \u003d utils.get_dict_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":281,"context_line":"        return (display_columns, data)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"class UnsetNetworkLog(command.Command):"},{"line_number":285,"context_line":"    _description \u003d _(\"Unset network log properties\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def get_parser(self, prog_name):"},{"line_number":288,"context_line":"        parser \u003d super(UnsetNetworkLog, self).get_parser(prog_name)"},{"line_number":289,"context_line":"        parser.add_argument("},{"line_number":290,"context_line":"            \u0027network_log\u0027,"},{"line_number":291,"context_line":"            metavar\u003d\u0027\u003cnetwork-log\u003e\u0027,"},{"line_number":292,"context_line":"            help\u003d_(\u0027Network log to unset (name or ID)\u0027))"},{"line_number":293,"context_line":"        parser.add_argument("},{"line_number":294,"context_line":"            \u0027--resource\u0027,"},{"line_number":295,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":296,"context_line":"            help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":297,"context_line":"                   \u0027If this option is specified, only this resource\\\u0027s event \u0027"},{"line_number":298,"context_line":"                   \u0027will be collected.\u0027))"},{"line_number":299,"context_line":"        parser.add_argument("},{"line_number":300,"context_line":"            \u0027--target\u0027,"},{"line_number":301,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":302,"context_line":"            help\u003d_(\u0027Detach target resource from the network log\u0027))"},{"line_number":303,"context_line":"        parser.add_argument("},{"line_number":304,"context_line":"            \u0027--enable-log\u0027,"},{"line_number":305,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":306,"context_line":"            help\u003d_(\u0027Disable this log (default is disabled)\u0027))"},{"line_number":307,"context_line":"        return parser"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _get_attrs(self, client_manager, parsed_args):"},{"line_number":310,"context_line":"        attrs \u003d {}"},{"line_number":311,"context_line":"        if parsed_args.resource:"},{"line_number":312,"context_line":"            attrs[\u0027resource_id\u0027] \u003d None"},{"line_number":313,"context_line":"        if parsed_args.target:"},{"line_number":314,"context_line":"            attrs[\u0027target_id\u0027] \u003d None"},{"line_number":315,"context_line":"        if parsed_args.enable_log:"},{"line_number":316,"context_line":"            attrs[\u0027enabled\u0027] \u003d False"},{"line_number":317,"context_line":"        return attrs"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def take_action(self, parsed_args):"},{"line_number":320,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":321,"context_line":"        log_id \u003d client.find_resource("},{"line_number":322,"context_line":"            \u0027log\u0027, parsed_args.network_log)[\u0027id\u0027]"},{"line_number":323,"context_line":"        attrs \u003d self._get_attrs(self.app.client_manager, parsed_args)"},{"line_number":324,"context_line":"        try:"},{"line_number":325,"context_line":"            client.update_network_log(log_id, {\u0027log\u0027: attrs})"},{"line_number":326,"context_line":"        except Exception as e:"},{"line_number":327,"context_line":"            msg \u003d (_(\"Failed to unset network log \u0027%(logging)s\u0027: %(e)s\")"},{"line_number":328,"context_line":"                   % {\u0027logging\u0027: parsed_args.network_log, \u0027e\u0027: e})"},{"line_number":329,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class ListLoggableResource(command.Lister):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_7ac2355b","line":329,"range":{"start_line":283,"start_character":1,"end_line":329,"end_character":47},"updated":"2017-05-23 10:08:52.000000000","message":"Check my comment in setup.cfg","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        data \u003d utils.get_dict_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":281,"context_line":"        return (display_columns, data)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"class UnsetNetworkLog(command.Command):"},{"line_number":285,"context_line":"    _description \u003d _(\"Unset network log properties\")"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def get_parser(self, prog_name):"},{"line_number":288,"context_line":"        parser \u003d super(UnsetNetworkLog, self).get_parser(prog_name)"},{"line_number":289,"context_line":"        parser.add_argument("},{"line_number":290,"context_line":"            \u0027network_log\u0027,"},{"line_number":291,"context_line":"            metavar\u003d\u0027\u003cnetwork-log\u003e\u0027,"},{"line_number":292,"context_line":"            help\u003d_(\u0027Network log to unset (name or ID)\u0027))"},{"line_number":293,"context_line":"        parser.add_argument("},{"line_number":294,"context_line":"            \u0027--resource\u0027,"},{"line_number":295,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":296,"context_line":"            help\u003d_(\u0027A resource which is enabled to be logged (name or ID). \u0027"},{"line_number":297,"context_line":"                   \u0027If this option is specified, only this resource\\\u0027s event \u0027"},{"line_number":298,"context_line":"                   \u0027will be collected.\u0027))"},{"line_number":299,"context_line":"        parser.add_argument("},{"line_number":300,"context_line":"            \u0027--target\u0027,"},{"line_number":301,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":302,"context_line":"            help\u003d_(\u0027Detach target resource from the network log\u0027))"},{"line_number":303,"context_line":"        parser.add_argument("},{"line_number":304,"context_line":"            \u0027--enable-log\u0027,"},{"line_number":305,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":306,"context_line":"            help\u003d_(\u0027Disable this log (default is disabled)\u0027))"},{"line_number":307,"context_line":"        return parser"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _get_attrs(self, client_manager, parsed_args):"},{"line_number":310,"context_line":"        attrs \u003d {}"},{"line_number":311,"context_line":"        if parsed_args.resource:"},{"line_number":312,"context_line":"            attrs[\u0027resource_id\u0027] \u003d None"},{"line_number":313,"context_line":"        if parsed_args.target:"},{"line_number":314,"context_line":"            attrs[\u0027target_id\u0027] \u003d None"},{"line_number":315,"context_line":"        if parsed_args.enable_log:"},{"line_number":316,"context_line":"            attrs[\u0027enabled\u0027] \u003d False"},{"line_number":317,"context_line":"        return attrs"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def take_action(self, parsed_args):"},{"line_number":320,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":321,"context_line":"        log_id \u003d client.find_resource("},{"line_number":322,"context_line":"            \u0027log\u0027, parsed_args.network_log)[\u0027id\u0027]"},{"line_number":323,"context_line":"        attrs \u003d self._get_attrs(self.app.client_manager, parsed_args)"},{"line_number":324,"context_line":"        try:"},{"line_number":325,"context_line":"            client.update_network_log(log_id, {\u0027log\u0027: attrs})"},{"line_number":326,"context_line":"        except Exception as e:"},{"line_number":327,"context_line":"            msg \u003d (_(\"Failed to unset network log \u0027%(logging)s\u0027: %(e)s\")"},{"line_number":328,"context_line":"                   % {\u0027logging\u0027: parsed_args.network_log, \u0027e\u0027: e})"},{"line_number":329,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"class ListLoggableResource(command.Lister):"}],"source_content_type":"text/x-python","patch_set":14,"id":"ff0f0b1f_b7ffbba9","line":329,"range":{"start_line":283,"start_character":1,"end_line":329,"end_character":47},"in_reply_to":"ff0f0b1f_7ac2355b","updated":"2017-05-23 13:31:15.000000000","message":"sure","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8e6736db01b0f234903d0ccbe31158688771b9ae","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--event\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\u0027\u003cevent\u003e\u0027,"},{"line_number":116,"context_line":"            choices\u003d[\u0027all\u0027, \u0027accept\u0027, \u0027drop\u0027],"},{"line_number":117,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":118,"context_line":"            help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":119,"context_line":"        # TODO(yushiro) \u0027--resource-type\u0027 is managed by following command:"},{"line_number":120,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff0f0b1f_2ed31806","line":117,"range":{"start_line":116,"start_character":12,"end_line":117,"end_character":47},"updated":"2017-05-25 02:12:18.000000000","message":"I\u0027m not sure these are required lower or upper cases. Just marked it to check with server side later.","commit_id":"7c3d545fb7b3ed7dfb476469934bb5c094122267"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f852ec065a8f02a2b3066ca458f99e122c107a02","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--event\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\u0027\u003cevent\u003e\u0027,"},{"line_number":116,"context_line":"            choices\u003d[\u0027all\u0027, \u0027accept\u0027, \u0027drop\u0027],"},{"line_number":117,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":118,"context_line":"            help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":119,"context_line":"        # TODO(yushiro) \u0027--resource-type\u0027 is managed by following command:"},{"line_number":120,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_819d2c0c","line":117,"range":{"start_line":116,"start_character":12,"end_line":117,"end_character":47},"in_reply_to":"df140735_d6a76ca7","updated":"2017-06-07 07:55:16.000000000","message":"OK, I\u0027ll fix it.","commit_id":"7c3d545fb7b3ed7dfb476469934bb5c094122267"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"647856f2006906b2394af59342b139906cd61ba7","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--event\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\u0027\u003cevent\u003e\u0027,"},{"line_number":116,"context_line":"            choices\u003d[\u0027all\u0027, \u0027accept\u0027, \u0027drop\u0027],"},{"line_number":117,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":118,"context_line":"            help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":119,"context_line":"        # TODO(yushiro) \u0027--resource-type\u0027 is managed by following command:"},{"line_number":120,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff0f0b1f_59b7edd9","line":117,"range":{"start_line":116,"start_character":12,"end_line":117,"end_character":47},"in_reply_to":"ff0f0b1f_2ed31806","updated":"2017-05-27 08:27:13.000000000","message":"I think lower case is easiler than upper case regarding input.","commit_id":"7c3d545fb7b3ed7dfb476469934bb5c094122267"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"edaeb95d6ab82e74af3fd1ec1944a4ac0130de86","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        parser.add_argument("},{"line_number":114,"context_line":"            \u0027--event\u0027,"},{"line_number":115,"context_line":"            metavar\u003d\u0027\u003cevent\u003e\u0027,"},{"line_number":116,"context_line":"            choices\u003d[\u0027all\u0027, \u0027accept\u0027, \u0027drop\u0027],"},{"line_number":117,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":118,"context_line":"            help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":119,"context_line":"        # TODO(yushiro) \u0027--resource-type\u0027 is managed by following command:"},{"line_number":120,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"}],"source_content_type":"text/x-python","patch_set":15,"id":"df140735_d6a76ca7","line":117,"range":{"start_line":116,"start_character":12,"end_line":117,"end_character":47},"in_reply_to":"ff0f0b1f_59b7edd9","updated":"2017-06-07 07:09:04.000000000","message":"I mean client side need to sync with server side. Currently, I see this field is defined by upper case [1]. If so, we should use \"convert_to_uppercase\" instead.\n\n[1] https://review.openstack.org/#/c/395483/34/neutron/services/logapi/common/constants.py","commit_id":"7c3d545fb7b3ed7dfb476469934bb5c094122267"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8e6736db01b0f234903d0ccbe31158688771b9ae","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        ext_data \u003d copy.deepcopy(data)"},{"line_number":198,"context_line":"        for d in ext_data:"},{"line_number":199,"context_line":"            e_prefix \u003d \u0027Event: \u0027"},{"line_number":200,"context_line":"            if d[\u0027event\u0027]:"},{"line_number":201,"context_line":"                event \u003d e_prefix + d[\u0027event\u0027].upper()"},{"line_number":202,"context_line":"            else:"},{"line_number":203,"context_line":"                event \u003d e_prefix + \u0027ALL\u0027"},{"line_number":204,"context_line":"            child \u003d d[\u0027resource_id\u0027] if d[\u0027resource_id\u0027] else \u0027\u0027"},{"line_number":205,"context_line":"            parent \u003d d[\u0027target_id\u0027] if d[\u0027target_id\u0027] else \u0027\u0027"},{"line_number":206,"context_line":"            t_prefix \u003d \u0027Target: \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff0f0b1f_4e476c78","line":203,"range":{"start_line":200,"start_character":12,"end_line":203,"end_character":40},"updated":"2017-05-25 02:12:18.000000000","message":"d[\u0027event\u0027] will always return one of [\u0027ACCEPT\u0027, \u0027DROP\u0027, \u0027ALL\u0027].","commit_id":"7c3d545fb7b3ed7dfb476469934bb5c094122267"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"647856f2006906b2394af59342b139906cd61ba7","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        ext_data \u003d copy.deepcopy(data)"},{"line_number":198,"context_line":"        for d in ext_data:"},{"line_number":199,"context_line":"            e_prefix \u003d \u0027Event: \u0027"},{"line_number":200,"context_line":"            if d[\u0027event\u0027]:"},{"line_number":201,"context_line":"                event \u003d e_prefix + d[\u0027event\u0027].upper()"},{"line_number":202,"context_line":"            else:"},{"line_number":203,"context_line":"                event \u003d e_prefix + \u0027ALL\u0027"},{"line_number":204,"context_line":"            child \u003d d[\u0027resource_id\u0027] if d[\u0027resource_id\u0027] else \u0027\u0027"},{"line_number":205,"context_line":"            parent \u003d d[\u0027target_id\u0027] if d[\u0027target_id\u0027] else \u0027\u0027"},{"line_number":206,"context_line":"            t_prefix \u003d \u0027Target: \u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff0f0b1f_99c46542","line":203,"range":{"start_line":200,"start_character":12,"end_line":203,"end_character":40},"in_reply_to":"ff0f0b1f_4e476c78","updated":"2017-05-27 08:27:13.000000000","message":"Yes.  In my understanding, If it doesn\u0027t specify \u0027event\u0027, it should be \u0027all\u0027. (I discussed with Annp and decided at that time)","commit_id":"7c3d545fb7b3ed7dfb476469934bb5c094122267"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8e6736db01b0f234903d0ccbe31158688771b9ae","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        data \u003d utils.get_dict_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":268,"context_line":"        return (display_columns, data)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class UnsetNetworkLog(command.Command):"},{"line_number":272,"context_line":"    _description \u003d _(\"Unset network log properties\")"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def get_parser(self, prog_name):"},{"line_number":275,"context_line":"        parser \u003d super(UnsetNetworkLog, self).get_parser(prog_name)"},{"line_number":276,"context_line":"        parser.add_argument("},{"line_number":277,"context_line":"            \u0027network_log\u0027,"},{"line_number":278,"context_line":"            metavar\u003d\u0027\u003cnetwork-log\u003e\u0027,"},{"line_number":279,"context_line":"            help\u003d_(\u0027Network log to unset (name or ID)\u0027))"},{"line_number":280,"context_line":"        parser.add_argument("},{"line_number":281,"context_line":"            \u0027--enable\u0027,"},{"line_number":282,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":283,"context_line":"            help\u003d_(\u0027Disable this log (default is disabled)\u0027))"},{"line_number":284,"context_line":"        return parser"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _get_attrs(self, client_manager, parsed_args):"},{"line_number":287,"context_line":"        attrs \u003d {}"},{"line_number":288,"context_line":"        if parsed_args.enable:"},{"line_number":289,"context_line":"            attrs[\u0027enabled\u0027] \u003d False"},{"line_number":290,"context_line":"        return attrs"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def take_action(self, parsed_args):"},{"line_number":293,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":294,"context_line":"        log_id \u003d client.find_resource("},{"line_number":295,"context_line":"            \u0027log\u0027, parsed_args.network_log)[\u0027id\u0027]"},{"line_number":296,"context_line":"        attrs \u003d self._get_attrs(self.app.client_manager, parsed_args)"},{"line_number":297,"context_line":"        try:"},{"line_number":298,"context_line":"            client.update_network_log(log_id, {\u0027log\u0027: attrs})"},{"line_number":299,"context_line":"        except Exception as e:"},{"line_number":300,"context_line":"            msg \u003d (_(\"Failed to unset network log \u0027%(logging)s\u0027: %(e)s\")"},{"line_number":301,"context_line":"                   % {\u0027logging\u0027: parsed_args.network_log, \u0027e\u0027: e})"},{"line_number":302,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"class ListLoggableResource(command.Lister):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff0f0b1f_6eb470f2","line":302,"range":{"start_line":270,"start_character":1,"end_line":302,"end_character":47},"updated":"2017-05-25 02:12:18.000000000","message":"With this class, I see that you will support unset command with only \"--enable\" option. What is a difference between the following 2 commands: \"openstack network logging set --disable \u003cUUID\u003e\" and \"openstack network logging unset --enable \u003cUUID\u003e\"? I think there is no difference. If so, we don\u0027t need to support unset command at the moment as I commented in previous patch.","commit_id":"7c3d545fb7b3ed7dfb476469934bb5c094122267"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"647856f2006906b2394af59342b139906cd61ba7","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        data \u003d utils.get_dict_properties(obj, columns, formatters\u003d_formatters)"},{"line_number":268,"context_line":"        return (display_columns, data)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"class UnsetNetworkLog(command.Command):"},{"line_number":272,"context_line":"    _description \u003d _(\"Unset network log properties\")"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def get_parser(self, prog_name):"},{"line_number":275,"context_line":"        parser \u003d super(UnsetNetworkLog, self).get_parser(prog_name)"},{"line_number":276,"context_line":"        parser.add_argument("},{"line_number":277,"context_line":"            \u0027network_log\u0027,"},{"line_number":278,"context_line":"            metavar\u003d\u0027\u003cnetwork-log\u003e\u0027,"},{"line_number":279,"context_line":"            help\u003d_(\u0027Network log to unset (name or ID)\u0027))"},{"line_number":280,"context_line":"        parser.add_argument("},{"line_number":281,"context_line":"            \u0027--enable\u0027,"},{"line_number":282,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":283,"context_line":"            help\u003d_(\u0027Disable this log (default is disabled)\u0027))"},{"line_number":284,"context_line":"        return parser"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _get_attrs(self, client_manager, parsed_args):"},{"line_number":287,"context_line":"        attrs \u003d {}"},{"line_number":288,"context_line":"        if parsed_args.enable:"},{"line_number":289,"context_line":"            attrs[\u0027enabled\u0027] \u003d False"},{"line_number":290,"context_line":"        return attrs"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def take_action(self, parsed_args):"},{"line_number":293,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":294,"context_line":"        log_id \u003d client.find_resource("},{"line_number":295,"context_line":"            \u0027log\u0027, parsed_args.network_log)[\u0027id\u0027]"},{"line_number":296,"context_line":"        attrs \u003d self._get_attrs(self.app.client_manager, parsed_args)"},{"line_number":297,"context_line":"        try:"},{"line_number":298,"context_line":"            client.update_network_log(log_id, {\u0027log\u0027: attrs})"},{"line_number":299,"context_line":"        except Exception as e:"},{"line_number":300,"context_line":"            msg \u003d (_(\"Failed to unset network log \u0027%(logging)s\u0027: %(e)s\")"},{"line_number":301,"context_line":"                   % {\u0027logging\u0027: parsed_args.network_log, \u0027e\u0027: e})"},{"line_number":302,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"class ListLoggableResource(command.Lister):"}],"source_content_type":"text/x-python","patch_set":15,"id":"ff0f0b1f_39e1d9d1","line":302,"range":{"start_line":270,"start_character":1,"end_line":302,"end_character":47},"in_reply_to":"ff0f0b1f_6eb470f2","updated":"2017-05-27 08:27:13.000000000","message":"OK, I understood.  I\u0027ll remove \u0027unset\u0027 command in next PS.","commit_id":"7c3d545fb7b3ed7dfb476469934bb5c094122267"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"3fb97d8779a9cb806a1babf9ef87027a1284b700","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        ext_data \u003d copy.deepcopy(data)"},{"line_number":198,"context_line":"        for d in ext_data:"},{"line_number":199,"context_line":"            e_prefix \u003d \u0027Event: \u0027"},{"line_number":200,"context_line":"            if d[\u0027event\u0027]:"},{"line_number":201,"context_line":"                event \u003d e_prefix + d[\u0027event\u0027].upper()"},{"line_number":202,"context_line":"            else:"},{"line_number":203,"context_line":"                event \u003d e_prefix + \u0027ALL\u0027"},{"line_number":204,"context_line":"            child \u003d d[\u0027resource_id\u0027] if d[\u0027resource_id\u0027] else \u0027\u0027"},{"line_number":205,"context_line":"            parent \u003d d[\u0027target_id\u0027] if d[\u0027target_id\u0027] else \u0027\u0027"},{"line_number":206,"context_line":"            t_prefix \u003d \u0027Target: \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"df140735_36cfc858","line":203,"range":{"start_line":200,"start_character":12,"end_line":203,"end_character":40},"updated":"2017-06-07 07:12:47.000000000","message":"No update?\n\nIt should be: \"event \u003d e_prefix + d[\u0027event\u0027]\". Right?","commit_id":"9120de8d39f93a163bbebd7c71851d1311e89eb6"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"9187825c28e51320b19b2893f2d81e2e4c6595a2","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        ext_data \u003d copy.deepcopy(data)"},{"line_number":198,"context_line":"        for d in ext_data:"},{"line_number":199,"context_line":"            e_prefix \u003d \u0027Event: \u0027"},{"line_number":200,"context_line":"            if d[\u0027event\u0027]:"},{"line_number":201,"context_line":"                event \u003d e_prefix + d[\u0027event\u0027].upper()"},{"line_number":202,"context_line":"            else:"},{"line_number":203,"context_line":"                event \u003d e_prefix + \u0027ALL\u0027"},{"line_number":204,"context_line":"            child \u003d d[\u0027resource_id\u0027] if d[\u0027resource_id\u0027] else \u0027\u0027"},{"line_number":205,"context_line":"            parent \u003d d[\u0027target_id\u0027] if d[\u0027target_id\u0027] else \u0027\u0027"},{"line_number":206,"context_line":"            t_prefix \u003d \u0027Target: \u0027"}],"source_content_type":"text/x-python","patch_set":16,"id":"df140735_e154e823","line":203,"range":{"start_line":200,"start_character":12,"end_line":203,"end_character":40},"in_reply_to":"df140735_36cfc858","updated":"2017-06-07 07:55:06.000000000","message":"oops. You\u0027re right.  \u0027else\u0027 is not necessary.","commit_id":"9120de8d39f93a163bbebd7c71851d1311e89eb6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if parsed_args.event:"},{"line_number":85,"context_line":"            attrs[\u0027event\u0027] \u003d str(parsed_args.event)"},{"line_number":86,"context_line":"        if parsed_args.resource_type:"},{"line_number":87,"context_line":"            attrs[\u0027resource_type\u0027] \u003d str(parsed_args.resource_type)"},{"line_number":88,"context_line":"    if parsed_args.enable:"},{"line_number":89,"context_line":"        attrs[\u0027enabled\u0027] \u003d True"},{"line_number":90,"context_line":"    if parsed_args.disable:"}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_d92b9392","line":87,"range":{"start_line":87,"start_character":37,"end_line":87,"end_character":67},"updated":"2017-06-15 14:21:20.000000000","message":"Isn\u0027t \u0027resource_type\u0027 a string? Is there any reason you need str()?","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        if parsed_args.event:"},{"line_number":85,"context_line":"            attrs[\u0027event\u0027] \u003d str(parsed_args.event)"},{"line_number":86,"context_line":"        if parsed_args.resource_type:"},{"line_number":87,"context_line":"            attrs[\u0027resource_type\u0027] \u003d str(parsed_args.resource_type)"},{"line_number":88,"context_line":"    if parsed_args.enable:"},{"line_number":89,"context_line":"        attrs[\u0027enabled\u0027] \u003d True"},{"line_number":90,"context_line":"    if parsed_args.disable:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_14c4f63e","line":87,"range":{"start_line":87,"start_character":37,"end_line":87,"end_character":67},"in_reply_to":"7f231b9d_d92b9392","updated":"2017-06-28 07:17:28.000000000","message":"If invalid value is inserted like integer value, I thought to cast to string.  But it\u0027s not necessary because users can refer help message and got an error in server-side.\n\nI\u0027ll remove str().","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    if parsed_args.disable:"},{"line_number":91,"context_line":"        attrs[\u0027enabled\u0027] \u003d False"},{"line_number":92,"context_line":"    if parsed_args.name:"},{"line_number":93,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":94,"context_line":"    if parsed_args.description:"},{"line_number":95,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":96,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_393de7dc","line":93,"range":{"start_line":93,"start_character":24,"end_line":93,"end_character":45},"updated":"2017-06-15 14:21:20.000000000","message":"why is str() needed?","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    if parsed_args.disable:"},{"line_number":91,"context_line":"        attrs[\u0027enabled\u0027] \u003d False"},{"line_number":92,"context_line":"    if parsed_args.name:"},{"line_number":93,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":94,"context_line":"    if parsed_args.description:"},{"line_number":95,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":96,"context_line":"    return attrs"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_34ced259","line":93,"range":{"start_line":93,"start_character":24,"end_line":93,"end_character":45},"in_reply_to":"7f231b9d_393de7dc","updated":"2017-06-28 07:17:28.000000000","message":"ditto #87","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    if parsed_args.name:"},{"line_number":93,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":94,"context_line":"    if parsed_args.description:"},{"line_number":95,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":96,"context_line":"    return attrs"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_5938a3ec","line":95,"range":{"start_line":95,"start_character":31,"end_line":95,"end_character":59},"updated":"2017-06-15 14:21:20.000000000","message":"why is str() needed?","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    if parsed_args.name:"},{"line_number":93,"context_line":"        attrs[\u0027name\u0027] \u003d str(parsed_args.name)"},{"line_number":94,"context_line":"    if parsed_args.description:"},{"line_number":95,"context_line":"        attrs[\u0027description\u0027] \u003d str(parsed_args.description)"},{"line_number":96,"context_line":"    return attrs"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_14d99620","line":95,"range":{"start_line":95,"start_character":31,"end_line":95,"end_character":59},"in_reply_to":"7f231b9d_5938a3ec","updated":"2017-06-28 07:17:28.000000000","message":"ditto #87","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            choices\u003d[\u0027ALL\u0027, \u0027ACCEPT\u0027, \u0027DROP\u0027],"},{"line_number":117,"context_line":"            type\u003dnc_utils.convert_to_uppercase,"},{"line_number":118,"context_line":"            help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":119,"context_line":"        # TODO(yushiro) \u0027--resource-type\u0027 is managed by following command:"},{"line_number":120,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"},{"line_number":121,"context_line":"        # shouldn\u0027t have \"choices\" like [\u0027security_group\u0027]"},{"line_number":122,"context_line":"        parser.add_argument("},{"line_number":123,"context_line":"            \u0027--resource-type\u0027,"},{"line_number":124,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_8405ae13","line":121,"range":{"start_line":119,"start_character":8,"end_line":121,"end_character":58},"updated":"2017-06-15 14:21:20.000000000","message":"Why is this a TODO?","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"            choices\u003d[\u0027ALL\u0027, \u0027ACCEPT\u0027, \u0027DROP\u0027],"},{"line_number":117,"context_line":"            type\u003dnc_utils.convert_to_uppercase,"},{"line_number":118,"context_line":"            help\u003d_(\u0027An event to store with log\u0027))"},{"line_number":119,"context_line":"        # TODO(yushiro) \u0027--resource-type\u0027 is managed by following command:"},{"line_number":120,"context_line":"        # \"openstack network loggable resource list\". Therefore, this option"},{"line_number":121,"context_line":"        # shouldn\u0027t have \"choices\" like [\u0027security_group\u0027]"},{"line_number":122,"context_line":"        parser.add_argument("},{"line_number":123,"context_line":"            \u0027--resource-type\u0027,"},{"line_number":124,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_343c922d","line":121,"range":{"start_line":119,"start_character":8,"end_line":121,"end_character":58},"in_reply_to":"7f231b9d_8405ae13","updated":"2017-06-28 07:17:28.000000000","message":"This logging API will expand to handle firewall as well as security_group.  So, I just wrote \"Why\" I didn\u0027t use \u0027choices\u0027 option.  But I think it\u0027s enough to NOTE.  Is it enough?","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":125,"context_line":"            required\u003dTrue,"},{"line_number":126,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":127,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\"). \u0027"},{"line_number":128,"context_line":"                   \u0027You can see supported type(s) with following command: \u0027"},{"line_number":129,"context_line":"                   \u0027openstack network loggable resource list\u0027))"},{"line_number":130,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_b9533739","line":127,"range":{"start_line":127,"start_character":40,"end_line":127,"end_character":70},"updated":"2017-06-15 14:21:20.000000000","message":"Looks like there is no default value. Is it correct?","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"63eb39ac218904997f784143ac269335023b9412","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":125,"context_line":"            required\u003dTrue,"},{"line_number":126,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":127,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\"). \u0027"},{"line_number":128,"context_line":"                   \u0027You can see supported type(s) with following command: \u0027"},{"line_number":129,"context_line":"                   \u0027openstack network loggable resource list\u0027))"},{"line_number":130,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_ff1e1eb9","line":127,"range":{"start_line":127,"start_character":40,"end_line":127,"end_character":70},"in_reply_to":"7f231b9d_b9533739","updated":"2017-06-16 01:34:03.000000000","message":"+1. IMO, there is no default value.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":125,"context_line":"            required\u003dTrue,"},{"line_number":126,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":127,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\"). \u0027"},{"line_number":128,"context_line":"                   \u0027You can see supported type(s) with following command: \u0027"},{"line_number":129,"context_line":"                   \u0027openstack network loggable resource list\u0027))"},{"line_number":130,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_940c8694","line":127,"range":{"start_line":127,"start_character":40,"end_line":127,"end_character":70},"in_reply_to":"7f231b9d_b9533739","updated":"2017-06-28 07:17:28.000000000","message":"Yes correct.  I\u0027ll remove it.  Thank you.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            metavar\u003d\u0027\u003cresource-type\u003e\u0027,"},{"line_number":125,"context_line":"            required\u003dTrue,"},{"line_number":126,"context_line":"            type\u003dnc_utils.convert_to_lowercase,"},{"line_number":127,"context_line":"            help\u003d_(\u0027Network log type(s) (default is \"security_group\"). \u0027"},{"line_number":128,"context_line":"                   \u0027You can see supported type(s) with following command: \u0027"},{"line_number":129,"context_line":"                   \u0027openstack network loggable resource list\u0027))"},{"line_number":130,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_740faa87","line":127,"range":{"start_line":127,"start_character":40,"end_line":127,"end_character":70},"in_reply_to":"7f231b9d_ff1e1eb9","updated":"2017-06-28 07:17:28.000000000","message":"Done","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"73af4dcfaea5e663ba3b241c8905ac9ce88e4c0b","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        result \u003d 0"},{"line_number":167,"context_line":"        for log_res in parsed_args.network_log:"},{"line_number":168,"context_line":"            try:"},{"line_number":169,"context_line":"                log_id \u003d client.find_resource(\u0027log\u0027, log_res)[\u0027id\u0027]"},{"line_number":170,"context_line":"                client.delete_network_log(log_id)"},{"line_number":171,"context_line":"            except Exception as e:"},{"line_number":172,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_36d9fb82","line":169,"range":{"start_line":169,"start_character":16,"end_line":169,"end_character":67},"updated":"2017-06-21 09:47:21.000000000","message":"log_id \u003d client.find_resource(\u0027log\u0027, log_res, cmd_resource\u003d\u0027network_log\u0027)[\u0027id\u0027]","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        result \u003d 0"},{"line_number":167,"context_line":"        for log_res in parsed_args.network_log:"},{"line_number":168,"context_line":"            try:"},{"line_number":169,"context_line":"                log_id \u003d client.find_resource(\u0027log\u0027, log_res)[\u0027id\u0027]"},{"line_number":170,"context_line":"                client.delete_network_log(log_id)"},{"line_number":171,"context_line":"            except Exception as e:"},{"line_number":172,"context_line":"                result +\u003d 1"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_546f0e2a","line":169,"range":{"start_line":169,"start_character":16,"end_line":169,"end_character":67},"in_reply_to":"5f201791_36d9fb82","updated":"2017-06-28 07:17:28.000000000","message":"wow, thank you. I\u0027ll fix and check it again.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"73af4dcfaea5e663ba3b241c8905ac9ce88e4c0b","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def take_action(self, parsed_args):"},{"line_number":237,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":238,"context_line":"        log_id \u003d client.find_resource(\u0027log\u0027, parsed_args.network_log)[\u0027id\u0027]"},{"line_number":239,"context_line":"        attrs \u003d _get_common_attrs(self.app.client_manager, parsed_args,"},{"line_number":240,"context_line":"                                  is_create\u003dFalse)"},{"line_number":241,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_36c21b87","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":75},"updated":"2017-06-21 09:47:21.000000000","message":"log_id \u003d client.find_resource(\u0027log\u0027, parsed_args.network_log, cmd_resource\u003d\u0027network_log\u0027)[\u0027id\u0027]","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    def take_action(self, parsed_args):"},{"line_number":237,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":238,"context_line":"        log_id \u003d client.find_resource(\u0027log\u0027, parsed_args.network_log)[\u0027id\u0027]"},{"line_number":239,"context_line":"        attrs \u003d _get_common_attrs(self.app.client_manager, parsed_args,"},{"line_number":240,"context_line":"                                  is_create\u003dFalse)"},{"line_number":241,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_3453726d","line":238,"range":{"start_line":238,"start_character":8,"end_line":238,"end_character":75},"in_reply_to":"5f201791_36c21b87","updated":"2017-06-28 07:17:28.000000000","message":"Done","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"73af4dcfaea5e663ba3b241c8905ac9ce88e4c0b","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def take_action(self, parsed_args):"},{"line_number":261,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":262,"context_line":"        log_id \u003d client.find_resource(\u0027log\u0027, parsed_args.network_log)[\u0027id\u0027]"},{"line_number":263,"context_line":"        obj \u003d client.show_network_log(log_id)[\u0027log\u0027]"},{"line_number":264,"context_line":"        columns, display_columns \u003d osc_utils.get_columns(obj, _attr_map)"},{"line_number":265,"context_line":"        data \u003d utils.get_dict_properties(obj, columns, formatters\u003d_formatters)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_f6bb830b","line":262,"range":{"start_line":262,"start_character":8,"end_line":262,"end_character":75},"updated":"2017-06-21 09:47:21.000000000","message":"log_id \u003d client.find_resource(\u0027log\u0027, parsed_args.network_log, cmd_resource\u003d\u0027network_log\u0027)[\u0027id\u0027]","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def take_action(self, parsed_args):"},{"line_number":261,"context_line":"        client \u003d self.app.client_manager.neutronclient"},{"line_number":262,"context_line":"        log_id \u003d client.find_resource(\u0027log\u0027, parsed_args.network_log)[\u0027id\u0027]"},{"line_number":263,"context_line":"        obj \u003d client.show_network_log(log_id)[\u0027log\u0027]"},{"line_number":264,"context_line":"        columns, display_columns \u003d osc_utils.get_columns(obj, _attr_map)"},{"line_number":265,"context_line":"        data \u003d utils.get_dict_properties(obj, columns, formatters\u003d_formatters)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_f4485ab3","line":262,"range":{"start_line":262,"start_character":8,"end_line":262,"end_character":75},"in_reply_to":"5f201791_f6bb830b","updated":"2017-06-28 07:17:28.000000000","message":"Done","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        return (display_columns, data)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"class ListLoggableResource(command.Lister):"},{"line_number":270,"context_line":"    _description \u003d _(\"List supported loggable resources\")"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_243dbac3","line":269,"updated":"2017-06-15 14:21:20.000000000","message":"Classes should be sorted in the alphabetical order. This is the convention is OSC commands.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":266,"context_line":"        return (display_columns, data)"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"class ListLoggableResource(command.Lister):"},{"line_number":270,"context_line":"    _description \u003d _(\"List supported loggable resources\")"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_54ddcedd","line":269,"in_reply_to":"7f231b9d_243dbac3","updated":"2017-06-28 07:17:28.000000000","message":"OK, I\u0027ll sort with it.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":277,"context_line":"            help\u003d_(\"List additional fields in output\")"},{"line_number":278,"context_line":"        )"},{"line_number":279,"context_line":"        return parser"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def take_action(self, parsed_args):"},{"line_number":282,"context_line":"        client \u003d self.app.client_manager.neutronclient"}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_4459d632","line":279,"updated":"2017-06-15 14:21:20.000000000","message":"No filtering by attributes?","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":276,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":277,"context_line":"            help\u003d_(\"List additional fields in output\")"},{"line_number":278,"context_line":"        )"},{"line_number":279,"context_line":"        return parser"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def take_action(self, parsed_args):"},{"line_number":282,"context_line":"        client \u003d self.app.client_manager.neutronclient"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_b4c302ed","line":279,"in_reply_to":"7f231b9d_4459d632","updated":"2017-06-28 07:17:28.000000000","message":"\u0027filter\u0027 means column selection?  Current impl can filter by colomn:\n\n  $ openstack network logging list -c ID -c Name\n  +--------------------------------------+--------+\n  | ID                                   | Name   |\n  +--------------------------------------+--------+\n  | 0f789b8a-bce0-405c-8d53-8bb23131f42c | my-log |\n  | 5e24b97b-fb73-409a-8a88-b95e7b038cce | my-log |\n  +--------------------------------------+--------+","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f9033b4232648ae8867e4a7c318e4b16c637a1d1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    return attrs"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"_formatters \u003d {}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class CreateNetworkLog(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_894ae224","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":16},"updated":"2017-06-30 08:56:38.000000000","message":"If _formatters is always empty, it looks unnecessary.","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"00d7e588e2979bc387db1e4bf6e217bf78e49242","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    return attrs"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"_formatters \u003d {}"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"class CreateNetworkLog(command.ShowOne):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_26ddf413","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":16},"in_reply_to":"3f1d235d_894ae224","updated":"2017-07-12 06:57:30.000000000","message":"Done","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"88251543aa21a7ae29c1aa4fedb8a0d179256244","unresolved":false,"context_lines":[{"line_number":218,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":219,"context_line":"        ext_data \u003d copy.deepcopy(data)"},{"line_number":220,"context_line":"        for d in ext_data:"},{"line_number":221,"context_line":"            e_prefix \u003d \u0027Event: \u0027"},{"line_number":222,"context_line":"            if d[\u0027event\u0027]:"},{"line_number":223,"context_line":"                event \u003d e_prefix + d[\u0027event\u0027].upper()"},{"line_number":224,"context_line":"            child \u003d \u0027(port) \u0027 + d[\u0027target_id\u0027] if d[\u0027target_id\u0027] else \u0027\u0027"},{"line_number":225,"context_line":"            parent \u003d (\u0027(security_group) \u0027 + d[\u0027resource_id\u0027]"},{"line_number":226,"context_line":"                      if d[\u0027resource_id\u0027] else \u0027\u0027)"},{"line_number":227,"context_line":"            t_prefix \u003d \u0027Logged: \u0027"},{"line_number":228,"context_line":"            t \u003d parent + \u0027 on \u0027 + child if child and parent else parent + child"},{"line_number":229,"context_line":"            target \u003d t_prefix + t if t else t_prefix + \u0027(None specified)\u0027"},{"line_number":230,"context_line":"            d[\u0027summary\u0027] \u003d \u0027,\\n\u0027.join([event, target])"},{"line_number":231,"context_line":"        return ext_data"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5f201791_e6a308b1","line":229,"range":{"start_line":221,"start_character":0,"end_line":229,"end_character":73},"updated":"2017-06-28 08:49:27.000000000","message":"I just improved \u0027summary\u0027 section in order to understand more easily.  Please feel free to comment.\n\n* Previous\n\n  +--------------------------------------+---------+--------+----------------+--------------------------------------------------------------------------------------+\n  | ID                                   | Enabled | Name   | Type           | Summary                                                                              |\n  +--------------------------------------+---------+--------+----------------+--------------------------------------------------------------------------------------+\n  | 0f789b8a-bce0-405c-8d53-8bb23131f42c | True    | my-log | security_group | Event: ALL,                                                                          |\n  |                                      |         |        |                |  Target: (None specified)                                                            |\n  | 30ce2248-1fd9-4aab-8355-9a87437ab58c | True    | my-log | security_group | Event: ACCEPT,                                                                       |\n  |                                      |         |        |                |  Target: acbe67b7-8ed7-4e76-be97-84461da0293don 7cfdcead-9ccd-4063-8ef1-ffe31773c3cc |\n  | 5e24b97b-fb73-409a-8a88-b95e7b038cce | True    | my-log | security_group | Event: DROP,                                                                         |\n  |                                      |         |        |                |  Target: (None specified)                                                            |\n  | 8be4a276-6db8-49b9-8991-7e58a8386af3 | True    | my-log | security_group | Event: ACCEPT,                                                                       |\n  |                                      |         |        |                |  Target: 5087737f-6dac-484f-9beb-750da09bd520                                        |\n  | efa7b95e-423b-4475-9666-89ea8a0dd618 | True    | my-log | security_group | Event: ACCEPT,                                                                       |\n  |                                      |         |        |                |  Target: 47f2c36a-7461-4c1a-a23e-931d5aee3f9c                                        |\n  +--------------------------------------+---------+--------+----------------+--------------------------------------------------------------------------------------+\n\n\n\n* Now\n\n  +--------------------------------------+---------+--------+----------------+-------------------------------------------------------------------------------------------------------------+\n  | ID                                   | Enabled | Name   | Type           | Summary                                                                                                     |\n  +--------------------------------------+---------+--------+----------------+-------------------------------------------------------------------------------------------------------------+\n  | 0f789b8a-bce0-405c-8d53-8bb23131f42c | True    | my-log | security_group | Event: ALL,                                                                                                 |\n  |                                      |         |        |                |  Logged: (None specified)                                                                                   |\n  | 30ce2248-1fd9-4aab-8355-9a87437ab58c | True    | my-log | security_group | Event: ACCEPT,                                                                                              |\n  |                                      |         |        |                |  Logged: (port)acbe67b7-8ed7-4e76-be97-84461da0293d on (security-group)7cfdcead-9ccd-4063-8ef1-ffe31773c3cc |\n  | 5e24b97b-fb73-409a-8a88-b95e7b038cce | True    | my-log | security_group | Event: DROP,                                                                                                |\n  |                                      |         |        |                |  Logged: (None specified)                                                                                   |\n  | 8be4a276-6db8-49b9-8991-7e58a8386af3 | True    | my-log | security_group | Event: ACCEPT,                                                                                              |\n  |                                      |         |        |                |  Logged: (port)5087737f-6dac-484f-9beb-750da09bd520                                                         |\n  | efa7b95e-423b-4475-9666-89ea8a0dd618 | True    | my-log | security_group | Event: ACCEPT,                                                                                              |\n  |                                      |         |        |                |  Logged: (security-group)47f2c36a-7461-4c1a-a23e-931d5aee3f9c                                               |\n  +--------------------------------------+---------+--------+----------------+-------------------------------------------------------------------------------------------------------------+","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"902e556a41b7daed6bb33d6304ad778eb8396fbf","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class ListLoggableResource(command.Lister):"},{"line_number":184,"context_line":"    _description \u003d _(\"List supported loggable resources\")"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f1a1f67_5bca85a0","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":26},"updated":"2017-07-19 19:36:45.000000000","message":"not sure if this class belongs here or warrants a separate module for itself..akihiro?","commit_id":"ef40bb7e91cc8ca06f5409d278bf4959b95ae1dd"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"43a7d53bbac6af0af955b9225e9cb4a7fb862f26","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class ListLoggableResource(command.Lister):"},{"line_number":184,"context_line":"    _description \u003d _(\"List supported loggable resources\")"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f1a1f67_dc220102","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":26},"in_reply_to":"1f1a1f67_1ccf59b1","updated":"2017-07-20 06:35:45.000000000","message":"You\u0027re welcome :)","commit_id":"ef40bb7e91cc8ca06f5409d278bf4959b95ae1dd"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b325531d95ca644896a2d76454a088d6604ef4b1","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class ListLoggableResource(command.Lister):"},{"line_number":184,"context_line":"    _description \u003d _(\"List supported loggable resources\")"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f1a1f67_792f7fa7","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":26},"in_reply_to":"1f1a1f67_5bca85a0","updated":"2017-07-20 06:02:26.000000000","message":"Hi Abhishek and Akihiro, I followed \u0027network_trunk\u0027 implementation.  Though \u0027network trunk\u0027 includes following commands[1], all class is written in network_trunk.py:\n\n* network_subport_list\n* network_trunk_create\n* network_trunk_delete\n* network_trunk_list\n* network_trunk_set\n* network_trunk_show\n* network_trunk_unset\n\n[1]https://github.com/openstack/python-neutronclient/blob/master/setup.cfg#L38-L44","commit_id":"ef40bb7e91cc8ca06f5409d278bf4959b95ae1dd"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"35e298cafbc9af7896356a5fee4b04adcd388f5a","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"class ListLoggableResource(command.Lister):"},{"line_number":184,"context_line":"    _description \u003d _(\"List supported loggable resources\")"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def get_parser(self, prog_name):"}],"source_content_type":"text/x-python","patch_set":22,"id":"1f1a1f67_1ccf59b1","line":183,"range":{"start_line":183,"start_character":6,"end_line":183,"end_character":26},"in_reply_to":"1f1a1f67_792f7fa7","updated":"2017-07-20 06:13:02.000000000","message":"you make a fair point.. i will give it another round of review in the morning .. thanks","commit_id":"ef40bb7e91cc8ca06f5409d278bf4959b95ae1dd"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":211,"context_line":"            help\u003d_(\"List additional fields in output\")"},{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        return parser"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":216,"context_line":"        ext_data \u003d copy.deepcopy(data)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_ad5ae6ef","line":213,"updated":"2017-10-13 12:16:12.000000000","message":"Is there any filtering support with resource-id or target-id, event and so on?","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":210,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":211,"context_line":"            help\u003d_(\"List additional fields in output\")"},{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        return parser"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":216,"context_line":"        ext_data \u003d copy.deepcopy(data)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_a9ce477f","line":213,"in_reply_to":"5f4e5783_ad5ae6ef","updated":"2017-10-14 12:40:04.000000000","message":"Currently, not implement yet.  As discussed with you yesterday, please let me retrieve as \u0027future improvement\u0027.  I\u0027ll store it as TODO.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        return parser"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":216,"context_line":"        ext_data \u003d copy.deepcopy(data)"},{"line_number":217,"context_line":"        for d in ext_data:"},{"line_number":218,"context_line":"            e_prefix \u003d \u0027Event: \u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_4d6ff291","line":215,"range":{"start_line":215,"start_character":8,"end_line":215,"end_character":19},"updated":"2017-10-13 12:16:12.000000000","message":"It is better to use a private method name: _extend_list","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":212,"context_line":"        )"},{"line_number":213,"context_line":"        return parser"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    def extend_list(self, data, parsed_args):"},{"line_number":216,"context_line":"        ext_data \u003d copy.deepcopy(data)"},{"line_number":217,"context_line":"        for d in ext_data:"},{"line_number":218,"context_line":"            e_prefix \u003d \u0027Event: \u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_29a8178b","line":215,"range":{"start_line":215,"start_character":8,"end_line":215,"end_character":19},"in_reply_to":"5f4e5783_4d6ff291","updated":"2017-10-14 12:40:04.000000000","message":"Oh, I didn\u0027t notice about that.  Yeah, I\u0027ll rename it.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        parser.add_argument("},{"line_number":251,"context_line":"            \u0027--name\u0027,"},{"line_number":252,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":253,"context_line":"            help\u003d_(\u0027Name of the network log\u0027))"},{"line_number":254,"context_line":"        return parser"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_8d128a08","line":253,"updated":"2017-10-13 12:16:12.000000000","message":"No update for description?","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        parser.add_argument("},{"line_number":251,"context_line":"            \u0027--name\u0027,"},{"line_number":252,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":253,"context_line":"            help\u003d_(\u0027Name of the network log\u0027))"},{"line_number":254,"context_line":"        return parser"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_c9a4e3a8","line":253,"in_reply_to":"5f4e5783_8d128a08","updated":"2017-10-14 12:40:04.000000000","message":"We can update description and other attributes.  Could you check _get_common_parser() in Line#51 ?","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"f64f9e720ccec75fddbb6197c68725a769c72c24","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        parser.add_argument("},{"line_number":251,"context_line":"            \u0027--name\u0027,"},{"line_number":252,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":253,"context_line":"            help\u003d_(\u0027Name of the network log\u0027))"},{"line_number":254,"context_line":"        return parser"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_02a2cd4b","line":253,"in_reply_to":"5f4e5783_b829efe6","updated":"2017-10-15 01:13:18.000000000","message":"Thanks for your check.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1fb67ef0cf5503c8f5cc12c56246e3c492fd0c59","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        parser.add_argument("},{"line_number":251,"context_line":"            \u0027--name\u0027,"},{"line_number":252,"context_line":"            metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":253,"context_line":"            help\u003d_(\u0027Name of the network log\u0027))"},{"line_number":254,"context_line":"        return parser"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_b829efe6","line":253,"in_reply_to":"5f4e5783_c9a4e3a8","updated":"2017-10-14 16:06:52.000000000","message":"I missed that. The current version looks good.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"}],"neutronclient/tests/unit/osc/v2/logging/fakes.py":[{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8997b5b68fcf6056eb97edc72957fabfe7615c00","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import copy"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import uuid"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_67ac068c","line":19,"updated":"2017-07-12 07:41:25.000000000","message":"I think this is redundant, you can delete this line.\n\nIt should be:\n\"\"\"\nimport collections\nimport copy\nimport uuid\n\nimport mock\n\"\"\"","commit_id":"9feb5cbe78cd1bcdf0df542e78d9d28719dd5723"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"021ca5d26365e3493bedce3ab5f0ff4b8560e1c7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import collections"},{"line_number":18,"context_line":"import copy"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import uuid"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_6707661e","line":19,"in_reply_to":"3f1d235d_67ac068c","updated":"2017-07-12 08:31:44.000000000","message":"Done","commit_id":"9feb5cbe78cd1bcdf0df542e78d9d28719dd5723"}],"neutronclient/tests/unit/osc/v2/logging/test_network_log.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from osc_lib import exceptions"},{"line_number":23,"context_line":"from osc_lib.tests import utils"}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_24deda6c","line":20,"updated":"2017-06-15 14:21:20.000000000","message":"testtoosl is third party. mock is gray zone.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from osc_lib import exceptions"},{"line_number":23,"context_line":"from osc_lib.tests import utils"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_6524925e","line":20,"in_reply_to":"7f231b9d_24deda6c","updated":"2017-06-28 07:17:28.000000000","message":"OK.  I\u0027ll fix it.  BTW, should we also fix following part?\n\nhttps://github.com/openstack/python-neutronclient/blob/master/neutronclient/tests/unit/osc/v2/trunk/test_network_trunk.py#L16-L20","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f9033b4232648ae8867e4a7c318e4b16c637a1d1","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from osc_lib import exceptions"},{"line_number":23,"context_line":"from osc_lib.tests import utils"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_a9f7def5","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"updated":"2017-06-30 08:56:38.000000000","message":"testtools is third party","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"00d7e588e2979bc387db1e4bf6e217bf78e49242","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import re"},{"line_number":20,"context_line":"import testtools"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from osc_lib import exceptions"},{"line_number":23,"context_line":"from osc_lib.tests import utils"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_6c774d3c","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":16},"in_reply_to":"3f1d235d_a9f7def5","updated":"2017-07-12 06:57:30.000000000","message":"Done","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f9033b4232648ae8867e4a7c318e4b16c637a1d1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    for key, val in verifylist:"},{"line_number":54,"context_line":"        converted \u003d CONVERT_MAP.get(key, key)"},{"line_number":55,"context_line":"        del request[key]"},{"line_number":56,"context_line":"        if re.match(\u0027^no_\u0027, key) and val is True:"},{"line_number":57,"context_line":"            new_value \u003d None"},{"line_number":58,"context_line":"        elif (key \u003d\u003d \u0027enable\u0027) and val:"},{"line_number":59,"context_line":"            new_value \u003d True"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_e99f16b2","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":32},"updated":"2017-06-30 08:56:38.000000000","message":"key.startswith(\u0027no_\u0027)","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"00d7e588e2979bc387db1e4bf6e217bf78e49242","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    for key, val in verifylist:"},{"line_number":54,"context_line":"        converted \u003d CONVERT_MAP.get(key, key)"},{"line_number":55,"context_line":"        del request[key]"},{"line_number":56,"context_line":"        if re.match(\u0027^no_\u0027, key) and val is True:"},{"line_number":57,"context_line":"            new_value \u003d None"},{"line_number":58,"context_line":"        elif (key \u003d\u003d \u0027enable\u0027) and val:"},{"line_number":59,"context_line":"            new_value \u003d True"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_ec823dc8","line":56,"range":{"start_line":56,"start_character":11,"end_line":56,"end_character":32},"in_reply_to":"3f1d235d_e99f16b2","updated":"2017-07-12 06:57:30.000000000","message":"Done","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f9033b4232648ae8867e4a7c318e4b16c637a1d1","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        del request[key]"},{"line_number":56,"context_line":"        if re.match(\u0027^no_\u0027, key) and val is True:"},{"line_number":57,"context_line":"            new_value \u003d None"},{"line_number":58,"context_line":"        elif (key \u003d\u003d \u0027enable\u0027) and val:"},{"line_number":59,"context_line":"            new_value \u003d True"},{"line_number":60,"context_line":"        elif (key \u003d\u003d \u0027disable\u0027) and val:"},{"line_number":61,"context_line":"            new_value \u003d False"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_49b84a29","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":30},"updated":"2017-06-30 08:56:38.000000000","message":"Parentheses are unnecessary.","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"00d7e588e2979bc387db1e4bf6e217bf78e49242","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        del request[key]"},{"line_number":56,"context_line":"        if re.match(\u0027^no_\u0027, key) and val is True:"},{"line_number":57,"context_line":"            new_value \u003d None"},{"line_number":58,"context_line":"        elif (key \u003d\u003d \u0027enable\u0027) and val:"},{"line_number":59,"context_line":"            new_value \u003d True"},{"line_number":60,"context_line":"        elif (key \u003d\u003d \u0027disable\u0027) and val:"},{"line_number":61,"context_line":"            new_value \u003d False"}],"source_content_type":"text/x-python","patch_set":18,"id":"3f1d235d_ac6c4536","line":58,"range":{"start_line":58,"start_character":12,"end_line":58,"end_character":30},"in_reply_to":"3f1d235d_49b84a29","updated":"2017-07-12 06:57:30.000000000","message":"I fixed here and #60","commit_id":"16c72edd977b3a81bb5155fb9e825c99824e9146"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8997b5b68fcf6056eb97edc72957fabfe7615c00","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":19,"id":"3f1d235d_47a7caa8","line":18,"updated":"2017-07-12 07:41:25.000000000","message":"These should be:\n\n\"\"\"\nimport copy\n\nimport mock\nfrom osc_lib import exceptions\nfrom osc_lib.tests import utils\nimport testtools\n\nfrom neutronclient.osc import utils as osc_utils\nfrom neutronclient.osc.v2.logging import network_log\nfrom neutronclient.tests.unit.osc.v2 import fakes as test_fakes\nfrom neutronclient.tests.unit.osc.v2.logging import fakes\n\"\"\"","commit_id":"9feb5cbe78cd1bcdf0df542e78d9d28719dd5723"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"021ca5d26365e3493bedce3ab5f0ff4b8560e1c7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import copy"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import mock"}],"source_content_type":"text/x-python","patch_set":19,"id":"1f1a1f67_b6be46fd","line":18,"in_reply_to":"3f1d235d_47a7caa8","updated":"2017-07-12 08:31:44.000000000","message":"Done","commit_id":"9feb5cbe78cd1bcdf0df542e78d9d28719dd5723"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    for key, val in verifylist:"},{"line_number":53,"context_line":"        converted \u003d CONVERT_MAP.get(key, key)"},{"line_number":54,"context_line":"        del request[key]"},{"line_number":55,"context_line":"        if key.startswith(\u0027no_\u0027) and val is True:"},{"line_number":56,"context_line":"            new_value \u003d None"},{"line_number":57,"context_line":"        elif key \u003d\u003d \u0027enable\u0027 and val:"},{"line_number":58,"context_line":"            new_value \u003d True"},{"line_number":59,"context_line":"        elif key \u003d\u003d \u0027disable\u0027 and val:"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_addd4643","line":56,"range":{"start_line":55,"start_character":8,"end_line":56,"end_character":28},"updated":"2017-10-13 12:16:12.000000000","message":"I cannot find an option name starting with \u0027no-\u0027. When is it used?","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    for key, val in verifylist:"},{"line_number":53,"context_line":"        converted \u003d CONVERT_MAP.get(key, key)"},{"line_number":54,"context_line":"        del request[key]"},{"line_number":55,"context_line":"        if key.startswith(\u0027no_\u0027) and val is True:"},{"line_number":56,"context_line":"            new_value \u003d None"},{"line_number":57,"context_line":"        elif key \u003d\u003d \u0027enable\u0027 and val:"},{"line_number":58,"context_line":"            new_value \u003d True"},{"line_number":59,"context_line":"        elif key \u003d\u003d \u0027disable\u0027 and val:"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_4c3921a2","line":56,"range":{"start_line":55,"start_character":8,"end_line":56,"end_character":28},"in_reply_to":"5f4e5783_addd4643","updated":"2017-10-14 12:40:04.000000000","message":"Ah, yes.  This is not used at all so I\u0027ll remove it.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        arglist \u003d ["},{"line_number":258,"context_line":"            name,"},{"line_number":259,"context_line":"            \u0027--resource\u0027, resource_id,"},{"line_number":260,"context_line":"            \u0027--no-resource\u0027,"},{"line_number":261,"context_line":"        ]"},{"line_number":262,"context_line":"        verifylist \u003d ["},{"line_number":263,"context_line":"            (\u0027name\u0027, name),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_adb666f9","line":260,"range":{"start_line":260,"start_character":12,"end_line":260,"end_character":27},"updated":"2017-10-13 12:16:12.000000000","message":"I cannot find --no-resource option defined. Am I missing something?","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        arglist \u003d ["},{"line_number":258,"context_line":"            name,"},{"line_number":259,"context_line":"            \u0027--resource\u0027, resource_id,"},{"line_number":260,"context_line":"            \u0027--no-resource\u0027,"},{"line_number":261,"context_line":"        ]"},{"line_number":262,"context_line":"        verifylist \u003d ["},{"line_number":263,"context_line":"            (\u0027name\u0027, name),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_17c576f1","line":260,"range":{"start_line":260,"start_character":12,"end_line":260,"end_character":27},"in_reply_to":"5f4e5783_adb666f9","updated":"2017-10-14 12:40:04.000000000","message":"I forgot to removing this test method after decided not to have \u0027--no-xxx\u0027 option.  I\u0027ll remove it.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        arglist \u003d ["},{"line_number":276,"context_line":"            name,"},{"line_number":277,"context_line":"            \u0027--target\u0027, target,"},{"line_number":278,"context_line":"            \u0027--no-target\u0027,"},{"line_number":279,"context_line":"        ]"},{"line_number":280,"context_line":"        verifylist \u003d ["},{"line_number":281,"context_line":"            (\u0027name\u0027, name),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_8db96aea","line":278,"range":{"start_line":278,"start_character":12,"end_line":278,"end_character":26},"updated":"2017-10-13 12:16:12.000000000","message":"Same as above","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        arglist \u003d ["},{"line_number":276,"context_line":"            name,"},{"line_number":277,"context_line":"            \u0027--target\u0027, target,"},{"line_number":278,"context_line":"            \u0027--no-target\u0027,"},{"line_number":279,"context_line":"        ]"},{"line_number":280,"context_line":"        verifylist \u003d ["},{"line_number":281,"context_line":"            (\u0027name\u0027, name),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_d7ba3e6c","line":278,"range":{"start_line":278,"start_character":12,"end_line":278,"end_character":26},"in_reply_to":"5f4e5783_8db96aea","updated":"2017-10-14 12:40:04.000000000","message":"ditto","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            utils.ParserException,"},{"line_number":563,"context_line":"            self.check_parser, self.cmd, arglist, verifylist)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def test_illegal_set_no_target_id(self):"},{"line_number":566,"context_line":"        target \u003d self.res[\u0027id\u0027]"},{"line_number":567,"context_line":"        arglist \u003d [target, \u0027--no-target\u0027]"},{"line_number":568,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_2dca766c","line":565,"range":{"start_line":565,"start_character":4,"end_line":565,"end_character":44},"updated":"2017-10-13 12:16:12.000000000","message":"I am not sure this test is required.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":562,"context_line":"            utils.ParserException,"},{"line_number":563,"context_line":"            self.check_parser, self.cmd, arglist, verifylist)"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"    def test_illegal_set_no_target_id(self):"},{"line_number":566,"context_line":"        target \u003d self.res[\u0027id\u0027]"},{"line_number":567,"context_line":"        arglist \u003d [target, \u0027--no-target\u0027]"},{"line_number":568,"context_line":"        verifylist \u003d ["}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_77a94a22","line":565,"range":{"start_line":565,"start_character":4,"end_line":565,"end_character":44},"in_reply_to":"5f4e5783_2dca766c","updated":"2017-10-14 12:40:04.000000000","message":"This test is not necessary so I\u0027ll remove it.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        arglist \u003d ["},{"line_number":609,"context_line":"            target,"},{"line_number":610,"context_line":"            \u0027--resource\u0027, resource_id,"},{"line_number":611,"context_line":"            \u0027--no-resource\u0027,"},{"line_number":612,"context_line":"        ]"},{"line_number":613,"context_line":"        verifylist \u003d ["},{"line_number":614,"context_line":"            (\u0027network_log\u0027, target),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_eda1feaa","line":611,"updated":"2017-10-13 12:16:12.000000000","message":"--no-resource option is defined, so what does this test try to check?","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        arglist \u003d ["},{"line_number":609,"context_line":"            target,"},{"line_number":610,"context_line":"            \u0027--resource\u0027, resource_id,"},{"line_number":611,"context_line":"            \u0027--no-resource\u0027,"},{"line_number":612,"context_line":"        ]"},{"line_number":613,"context_line":"        verifylist \u003d ["},{"line_number":614,"context_line":"            (\u0027network_log\u0027, target),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_7dd8091d","line":611,"in_reply_to":"5f4e5783_eda1feaa","updated":"2017-10-14 12:40:04.000000000","message":"ditto.  It is not necessary.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        arglist \u003d ["},{"line_number":626,"context_line":"            target,"},{"line_number":627,"context_line":"            \u0027--target\u0027, resource_id,"},{"line_number":628,"context_line":"            \u0027--no-target\u0027,"},{"line_number":629,"context_line":"        ]"},{"line_number":630,"context_line":"        verifylist \u003d ["},{"line_number":631,"context_line":"            (\u0027network_log\u0027, target),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_cda402bc","line":628,"updated":"2017-10-13 12:16:12.000000000","message":"ditto","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":625,"context_line":"        arglist \u003d ["},{"line_number":626,"context_line":"            target,"},{"line_number":627,"context_line":"            \u0027--target\u0027, resource_id,"},{"line_number":628,"context_line":"            \u0027--no-target\u0027,"},{"line_number":629,"context_line":"        ]"},{"line_number":630,"context_line":"        verifylist \u003d ["},{"line_number":631,"context_line":"            (\u0027network_log\u0027, target),"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_57a64e55","line":628,"in_reply_to":"5f4e5783_cda402bc","updated":"2017-10-14 12:40:04.000000000","message":"ditto!","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"}],"neutronclient/v2_0/client.py":[{"author":{"_account_id":19778,"name":"Takao Indoh","email":"indou.takao@jp.fujitsu.com","username":"tindoh"},"change_message_id":"ce8c8eb5c8c881a9b6e16095eaa92f906dcd59ae","unresolved":false,"context_lines":[{"line_number":2113,"context_line":"        \"\"\"Fetch a list of supported resource types for network log.\"\"\""},{"line_number":2114,"context_line":"        return self.list("},{"line_number":2115,"context_line":"            \u0027loggable_resources\u0027, self.loggables_path, retrieve_all, **_params)"},{"line_number":2116,"context_line":""},{"line_number":2117,"context_line":"    def __init__(self, **kwargs):"},{"line_number":2118,"context_line":"        \"\"\"Initialize a new client for the Neutron v2.0 API.\"\"\""},{"line_number":2119,"context_line":"        super(Client, self).__init__(**kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_7be7a240","line":2116,"updated":"2017-01-19 09:11:59.000000000","message":"Need update_network_log here.","commit_id":"5ed312e7a47e4a3a517153ba49be139288fa93bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"0cb6124ede07def3855d46544668db3c8bea9bc1","unresolved":false,"context_lines":[{"line_number":2113,"context_line":"        \"\"\"Fetch a list of supported resource types for network log.\"\"\""},{"line_number":2114,"context_line":"        return self.list("},{"line_number":2115,"context_line":"            \u0027loggable_resources\u0027, self.loggables_path, retrieve_all, **_params)"},{"line_number":2116,"context_line":""},{"line_number":2117,"context_line":"    def __init__(self, **kwargs):"},{"line_number":2118,"context_line":"        \"\"\"Initialize a new client for the Neutron v2.0 API.\"\"\""},{"line_number":2119,"context_line":"        super(Client, self).__init__(**kwargs)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a3905b3_db033575","line":2116,"in_reply_to":"5a3905b3_7be7a240","updated":"2017-01-19 09:32:08.000000000","message":"I\u0027ll merge set_network_log and unset_network_log with update_network_log. Thank you.","commit_id":"5ed312e7a47e4a3a517153ba49be139288fa93bc"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3a01ffe6a452ac98a0437efc4a35cbd03240c3a2","unresolved":false,"context_lines":[{"line_number":2165,"context_line":""},{"line_number":2166,"context_line":"    def create_network_log(self, body\u003dNone):"},{"line_number":2167,"context_line":"        \"\"\"Create a network log.\"\"\""},{"line_number":2168,"context_line":"        return self.post(self.trunks_path, body\u003dbody)"},{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"    def delete_network_log(self, trunk):"},{"line_number":2171,"context_line":"        \"\"\"Delete a network log.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff0f0b1f_bd7eae68","line":2168,"range":{"start_line":2168,"start_character":29,"end_line":2168,"end_character":41},"updated":"2017-05-22 09:54:24.000000000","message":"network_log_path?","commit_id":"86b6dfbb52f3776bd4f59d00ca6241ac002213f4"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"76b5fc97bd395b8d0b1715c9bb14002469f5ec83","unresolved":false,"context_lines":[{"line_number":2165,"context_line":""},{"line_number":2166,"context_line":"    def create_network_log(self, body\u003dNone):"},{"line_number":2167,"context_line":"        \"\"\"Create a network log.\"\"\""},{"line_number":2168,"context_line":"        return self.post(self.trunks_path, body\u003dbody)"},{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"    def delete_network_log(self, trunk):"},{"line_number":2171,"context_line":"        \"\"\"Delete a network log.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff0f0b1f_6945d842","line":2168,"range":{"start_line":2168,"start_character":29,"end_line":2168,"end_character":41},"in_reply_to":"ff0f0b1f_bd7eae68","updated":"2017-05-23 04:19:16.000000000","message":"Done","commit_id":"86b6dfbb52f3776bd4f59d00ca6241ac002213f4"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3a01ffe6a452ac98a0437efc4a35cbd03240c3a2","unresolved":false,"context_lines":[{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"    def delete_network_log(self, trunk):"},{"line_number":2171,"context_line":"        \"\"\"Delete a network log.\"\"\""},{"line_number":2172,"context_line":"        return self.delete(self.trunk_path % (trunk))"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"    def list_network_logs(self, retrieve_all\u003dTrue, **_params):"},{"line_number":2175,"context_line":"        \"\"\"Fetch a list of all network logs.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff0f0b1f_9d81aa4d","line":2172,"range":{"start_line":2172,"start_character":32,"end_line":2172,"end_character":42},"updated":"2017-05-22 09:54:24.000000000","message":"network_log_path?","commit_id":"86b6dfbb52f3776bd4f59d00ca6241ac002213f4"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"76b5fc97bd395b8d0b1715c9bb14002469f5ec83","unresolved":false,"context_lines":[{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"    def delete_network_log(self, trunk):"},{"line_number":2171,"context_line":"        \"\"\"Delete a network log.\"\"\""},{"line_number":2172,"context_line":"        return self.delete(self.trunk_path % (trunk))"},{"line_number":2173,"context_line":""},{"line_number":2174,"context_line":"    def list_network_logs(self, retrieve_all\u003dTrue, **_params):"},{"line_number":2175,"context_line":"        \"\"\"Fetch a list of all network logs.\"\"\""}],"source_content_type":"text/x-python","patch_set":11,"id":"ff0f0b1f_4978d48e","line":2172,"range":{"start_line":2172,"start_character":32,"end_line":2172,"end_character":42},"in_reply_to":"ff0f0b1f_9d81aa4d","updated":"2017-05-23 04:19:16.000000000","message":"Done","commit_id":"86b6dfbb52f3776bd4f59d00ca6241ac002213f4"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d8037a153405e43f0af30657d16d9ab8c24440a6","unresolved":false,"context_lines":[{"line_number":2165,"context_line":""},{"line_number":2166,"context_line":"    def create_network_log(self, body\u003dNone):"},{"line_number":2167,"context_line":"        \"\"\"Create a network log.\"\"\""},{"line_number":2168,"context_line":"        return self.post(self.network_log_path, body\u003dbody)"},{"line_number":2169,"context_line":""},{"line_number":2170,"context_line":"    def delete_network_log(self, net_log):"},{"line_number":2171,"context_line":"        \"\"\"Delete a network log.\"\"\""}],"source_content_type":"text/x-python","patch_set":12,"id":"ff0f0b1f_2991204f","line":2168,"range":{"start_line":2168,"start_character":30,"end_line":2168,"end_character":46},"updated":"2017-05-23 04:42:58.000000000","message":"Not \u0027network_log_path\u0027 but \u0027network_logs_path\u0027.","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"63eb39ac218904997f784143ac269335023b9412","unresolved":false,"context_lines":[{"line_number":638,"context_line":"    bgpvpn_router_associations_path \u003d \"/bgpvpn/bgpvpns/%s/router_associations\""},{"line_number":639,"context_line":"    bgpvpn_router_association_path \u003d\\"},{"line_number":640,"context_line":"        \"/bgpvpn/bgpvpns/%s/router_associations/%s\""},{"line_number":641,"context_line":"    network_logs_path \u003d \"/logging/logs\""},{"line_number":642,"context_line":"    network_log_path \u003d \"/logging/logs/%s\""},{"line_number":643,"context_line":"    loggables_path \u003d \"/logging/loggable-resources\""},{"line_number":644,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_ff8f3eca","line":641,"range":{"start_line":641,"start_character":25,"end_line":641,"end_character":37},"updated":"2017-06-16 01:34:03.000000000","message":"Please change it to /log/logs as we discussed at https://review.openstack.org/#/c/415817/","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":638,"context_line":"    bgpvpn_router_associations_path \u003d \"/bgpvpn/bgpvpns/%s/router_associations\""},{"line_number":639,"context_line":"    bgpvpn_router_association_path \u003d\\"},{"line_number":640,"context_line":"        \"/bgpvpn/bgpvpns/%s/router_associations/%s\""},{"line_number":641,"context_line":"    network_logs_path \u003d \"/logging/logs\""},{"line_number":642,"context_line":"    network_log_path \u003d \"/logging/logs/%s\""},{"line_number":643,"context_line":"    loggables_path \u003d \"/logging/loggable-resources\""},{"line_number":644,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_947c8672","line":641,"range":{"start_line":641,"start_character":25,"end_line":641,"end_character":37},"in_reply_to":"7f231b9d_ff8f3eca","updated":"2017-06-28 07:17:28.000000000","message":"Done","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"63eb39ac218904997f784143ac269335023b9412","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        \"/bgpvpn/bgpvpns/%s/router_associations/%s\""},{"line_number":641,"context_line":"    network_logs_path \u003d \"/logging/logs\""},{"line_number":642,"context_line":"    network_log_path \u003d \"/logging/logs/%s\""},{"line_number":643,"context_line":"    loggables_path \u003d \"/logging/loggable-resources\""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":646,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_df8c82d8","line":643,"range":{"start_line":643,"start_character":22,"end_line":643,"end_character":49},"updated":"2017-06-16 01:34:03.000000000","message":"/log/loggable-resources","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        \"/bgpvpn/bgpvpns/%s/router_associations/%s\""},{"line_number":641,"context_line":"    network_logs_path \u003d \"/logging/logs\""},{"line_number":642,"context_line":"    network_log_path \u003d \"/logging/logs/%s\""},{"line_number":643,"context_line":"    loggables_path \u003d \"/logging/loggable-resources\""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":646,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_246b7ab7","line":643,"updated":"2017-06-15 14:21:20.000000000","message":"network_log(s) and just loggable look inconsistent.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        \"/bgpvpn/bgpvpns/%s/router_associations/%s\""},{"line_number":641,"context_line":"    network_logs_path \u003d \"/logging/logs\""},{"line_number":642,"context_line":"    network_log_path \u003d \"/logging/logs/%s\""},{"line_number":643,"context_line":"    loggables_path \u003d \"/logging/loggable-resources\""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":646,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_f48a9a61","line":643,"in_reply_to":"7f231b9d_246b7ab7","updated":"2017-06-28 07:17:28.000000000","message":"I\u0027ll fix /log/loggable-resource","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":640,"context_line":"        \"/bgpvpn/bgpvpns/%s/router_associations/%s\""},{"line_number":641,"context_line":"    network_logs_path \u003d \"/logging/logs\""},{"line_number":642,"context_line":"    network_log_path \u003d \"/logging/logs/%s\""},{"line_number":643,"context_line":"    loggables_path \u003d \"/logging/loggable-resources\""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":646,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_d4eb1e10","line":643,"range":{"start_line":643,"start_character":22,"end_line":643,"end_character":49},"in_reply_to":"7f231b9d_df8c82d8","updated":"2017-06-28 07:17:28.000000000","message":"Done","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"73af4dcfaea5e663ba3b241c8905ac9ce88e4c0b","unresolved":false,"context_lines":[{"line_number":641,"context_line":"    network_logs_path \u003d \"/logging/logs\""},{"line_number":642,"context_line":"    network_log_path \u003d \"/logging/logs/%s\""},{"line_number":643,"context_line":"    loggables_path \u003d \"/logging/loggable-resources\""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":646,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"},{"line_number":647,"context_line":"                     \u0027floatingips\u0027: \u0027floatingip\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_f65023d7","line":644,"updated":"2017-06-21 09:47:21.000000000","message":"network_logs_path \u003d \"/log/logs\"\nnetwork_log_path \u003d \"/log/logs/%s\"\nloggables_path \u003d \"/log/loggable-resources\"","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":641,"context_line":"    network_logs_path \u003d \"/logging/logs\""},{"line_number":642,"context_line":"    network_log_path \u003d \"/logging/logs/%s\""},{"line_number":643,"context_line":"    loggables_path \u003d \"/logging/loggable-resources\""},{"line_number":644,"context_line":""},{"line_number":645,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":646,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"},{"line_number":647,"context_line":"                     \u0027floatingips\u0027: \u0027floatingip\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_b4ee621f","line":644,"in_reply_to":"5f201791_f65023d7","updated":"2017-06-28 07:17:28.000000000","message":"Done","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":2176,"context_line":"        return self.list("},{"line_number":2177,"context_line":"            \u0027logs\u0027, self.network_logs_path, retrieve_all, **_params)"},{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"    def set_network_log(self, net_log, body\u003dNone):"},{"line_number":2180,"context_line":"        \"\"\"Set a network log.\"\"\""},{"line_number":2181,"context_line":"        return self.put(self.network_log_path % net_log, body\u003dbody)"},{"line_number":2182,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_a4854a5c","line":2179,"range":{"start_line":2179,"start_character":8,"end_line":2179,"end_character":23},"updated":"2017-06-15 14:21:20.000000000","message":"update_network_log is a consistent name. set/unset is a naming convention in OSC. neutronclient API binding uses update_xxxx as the convention. There is no need to have two same methods set/unset.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":2176,"context_line":"        return self.list("},{"line_number":2177,"context_line":"            \u0027logs\u0027, self.network_logs_path, retrieve_all, **_params)"},{"line_number":2178,"context_line":""},{"line_number":2179,"context_line":"    def set_network_log(self, net_log, body\u003dNone):"},{"line_number":2180,"context_line":"        \"\"\"Set a network log.\"\"\""},{"line_number":2181,"context_line":"        return self.put(self.network_log_path % net_log, body\u003dbody)"},{"line_number":2182,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_74ac4a9e","line":2179,"range":{"start_line":2179,"start_character":8,"end_line":2179,"end_character":23},"in_reply_to":"7f231b9d_a4854a5c","updated":"2017-06-28 07:17:28.000000000","message":"OK. I\u0027ll revert from set/unset to update with 1 method.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"25c10fdd391b54ff2342ccb3bdd5f2f3e73252ef","unresolved":false,"context_lines":[{"line_number":2184,"context_line":"        \"\"\"Fetch information for a certain network log.\"\"\""},{"line_number":2185,"context_line":"        return self.get(self.network_log_path % net_log, params\u003d_params)"},{"line_number":2186,"context_line":""},{"line_number":2187,"context_line":"    def unset_network_log(self, net_log, body\u003dNone):"},{"line_number":2188,"context_line":"        \"\"\"Unset a network log.\"\"\""},{"line_number":2189,"context_line":"        return self.put(self.network_log_path % net_log, body\u003dbody)"},{"line_number":2190,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7f231b9d_84a12efb","line":2187,"range":{"start_line":2187,"start_character":8,"end_line":2187,"end_character":25},"updated":"2017-06-15 14:21:20.000000000","message":"why is unset_xxx needed?","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"e111fb3ccd4eae4f4f34fa909ba1607d6411bfa3","unresolved":false,"context_lines":[{"line_number":2184,"context_line":"        \"\"\"Fetch information for a certain network log.\"\"\""},{"line_number":2185,"context_line":"        return self.get(self.network_log_path % net_log, params\u003d_params)"},{"line_number":2186,"context_line":""},{"line_number":2187,"context_line":"    def unset_network_log(self, net_log, body\u003dNone):"},{"line_number":2188,"context_line":"        \"\"\"Unset a network log.\"\"\""},{"line_number":2189,"context_line":"        return self.put(self.network_log_path % net_log, body\u003dbody)"},{"line_number":2190,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f201791_f4705a42","line":2187,"range":{"start_line":2187,"start_character":8,"end_line":2187,"end_character":25},"in_reply_to":"7f231b9d_84a12efb","updated":"2017-06-28 07:17:28.000000000","message":"ah!  I forgot to remove this method.","commit_id":"0dd94ae2319773d195cf24782392797f3059ba08"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        \"/bgpvpn/bgpvpns/%s/router_associations/%s\""},{"line_number":651,"context_line":"    network_logs_path \u003d \"/log/logs\""},{"line_number":652,"context_line":"    network_log_path \u003d \"/log/logs/%s\""},{"line_number":653,"context_line":"    loggables_path \u003d \"/log/loggable-resources\""},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":656,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_3c498ecf","line":653,"updated":"2017-10-13 12:16:12.000000000","message":"The variable names looks inconsistent. How about using \u0027network_\u0027 for all variables?","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":650,"context_line":"        \"/bgpvpn/bgpvpns/%s/router_associations/%s\""},{"line_number":651,"context_line":"    network_logs_path \u003d \"/log/logs\""},{"line_number":652,"context_line":"    network_log_path \u003d \"/log/logs/%s\""},{"line_number":653,"context_line":"    loggables_path \u003d \"/log/loggable-resources\""},{"line_number":654,"context_line":""},{"line_number":655,"context_line":"    # API has no way to report plurals, so we have to hard code them"},{"line_number":656,"context_line":"    EXTED_PLURALS \u003d {\u0027routers\u0027: \u0027router\u0027,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_577beebc","line":653,"in_reply_to":"5f4e5783_3c498ecf","updated":"2017-10-14 12:40:04.000000000","message":"Good point!  I\u0027ll align with \u0027network_\u0027 for each path.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":2287,"context_line":"        \"\"\"Update a network log.\"\"\""},{"line_number":2288,"context_line":"        return self.put(self.network_log_path % net_log, body\u003dbody)"},{"line_number":2289,"context_line":""},{"line_number":2290,"context_line":"    def list_loggable_resources(self, retrieve_all\u003dTrue, **_params):"},{"line_number":2291,"context_line":"        \"\"\"Fetch a list of supported resource types for network log.\"\"\""},{"line_number":2292,"context_line":"        return self.list("},{"line_number":2293,"context_line":"            \u0027loggable_resources\u0027, self.loggables_path, retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_5c232a06","line":2290,"range":{"start_line":2290,"start_character":8,"end_line":2290,"end_character":31},"updated":"2017-10-13 12:16:12.000000000","message":"I wonder why \u0027log\u0027 has \u0027network_\u0027 prefix and \u0027loggable_resource\u0027 has no \u0027network_\u0027 prefix. Looks incosistent.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":2287,"context_line":"        \"\"\"Update a network log.\"\"\""},{"line_number":2288,"context_line":"        return self.put(self.network_log_path % net_log, body\u003dbody)"},{"line_number":2289,"context_line":""},{"line_number":2290,"context_line":"    def list_loggable_resources(self, retrieve_all\u003dTrue, **_params):"},{"line_number":2291,"context_line":"        \"\"\"Fetch a list of supported resource types for network log.\"\"\""},{"line_number":2292,"context_line":"        return self.list("},{"line_number":2293,"context_line":"            \u0027loggable_resources\u0027, self.loggables_path, retrieve_all, **_params)"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f4e5783_374e3297","line":2290,"range":{"start_line":2290,"start_character":8,"end_line":2290,"end_character":31},"in_reply_to":"5f4e5783_5c232a06","updated":"2017-10-14 12:40:04.000000000","message":"Yeah, \u0027list_network_loggable_resources\u0027 is much more better.  I\u0027ll update it.","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"}],"releasenotes/notes/support-logging-cli-cd02d3bb03367106.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"fb1214dbd26dc910bf29780716c0c3ca8151a51e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for \u0027Logging\u0027 feature, which enable to collect packet logs"},{"line_number":5,"context_line":"    for specified resource.  Currently, only security-group can be logged."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f4e5783_3cf4ee85","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":29},"updated":"2017-10-13 12:16:12.000000000","message":"Two spaces","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"d85e65c7ef805882bb0ed5a4b9a356f2a2abf9ae","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    CLI support for \u0027Logging\u0027 feature, which enable to collect packet logs"},{"line_number":5,"context_line":"    for specified resource.  Currently, only security-group can be logged."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f4e5783_975e0642","line":5,"range":{"start_line":5,"start_character":27,"end_line":5,"end_character":29},"in_reply_to":"5f4e5783_3cf4ee85","updated":"2017-10-14 12:40:04.000000000","message":"ouch!","commit_id":"b4ba3b0ae30079d882cc33f2370b1e992a86d5bc"}],"setup.cfg":[{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"ecfa426fef130045da191bbb21f880d63fa78c97","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    bgpvpn_router_association_list \u003d neutronclient.osc.v2.networking_bgpvpn.router_association:ListBgpvpnRouterAssoc"},{"line_number":80,"context_line":"    bgpvpn_router_association_show \u003d neutronclient.osc.v2.networking_bgpvpn.router_association:ShowBgpvpnRouterAssoc"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    network_log_create \u003d neutronclient.osc.v2.logging.network_log:CreateNetworkLog"},{"line_number":83,"context_line":"    network_log_delete \u003d neutronclient.osc.v2.logging.network_log:DeleteNetworkLog"},{"line_number":84,"context_line":"    network_log_list \u003d neutronclient.osc.v2.logging.network_log:ListNetworkLog"},{"line_number":85,"context_line":"    network_log_supported_list \u003d neutronclient.osc.v2.logging.network_log:ListLoggableResource"},{"line_number":86,"context_line":"    network_log_set \u003d neutronclient.osc.v2.logging.network_log:SetNetworkLog"},{"line_number":87,"context_line":"    network_log_show \u003d neutronclient.osc.v2.logging.network_log:ShowNetworkLog"},{"line_number":88,"context_line":"    network_log_unset \u003d neutronclient.osc.v2.logging.network_log:UnsetNetworkLog"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"[build_sphinx]"},{"line_number":91,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"ff0f0b1f_62c75147","line":88,"range":{"start_line":82,"start_character":4,"end_line":88,"end_character":80},"updated":"2017-05-22 09:36:08.000000000","message":"Are these correct?\nI think it need to update corresponding to the latest spec.","commit_id":"86b6dfbb52f3776bd4f59d00ca6241ac002213f4"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"76b5fc97bd395b8d0b1715c9bb14002469f5ec83","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    bgpvpn_router_association_list \u003d neutronclient.osc.v2.networking_bgpvpn.router_association:ListBgpvpnRouterAssoc"},{"line_number":80,"context_line":"    bgpvpn_router_association_show \u003d neutronclient.osc.v2.networking_bgpvpn.router_association:ShowBgpvpnRouterAssoc"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    network_log_create \u003d neutronclient.osc.v2.logging.network_log:CreateNetworkLog"},{"line_number":83,"context_line":"    network_log_delete \u003d neutronclient.osc.v2.logging.network_log:DeleteNetworkLog"},{"line_number":84,"context_line":"    network_log_list \u003d neutronclient.osc.v2.logging.network_log:ListNetworkLog"},{"line_number":85,"context_line":"    network_log_supported_list \u003d neutronclient.osc.v2.logging.network_log:ListLoggableResource"},{"line_number":86,"context_line":"    network_log_set \u003d neutronclient.osc.v2.logging.network_log:SetNetworkLog"},{"line_number":87,"context_line":"    network_log_show \u003d neutronclient.osc.v2.logging.network_log:ShowNetworkLog"},{"line_number":88,"context_line":"    network_log_unset \u003d neutronclient.osc.v2.logging.network_log:UnsetNetworkLog"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"[build_sphinx]"},{"line_number":91,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"ff0f0b1f_a93f70b2","line":88,"range":{"start_line":82,"start_character":4,"end_line":88,"end_character":80},"in_reply_to":"ff0f0b1f_62c75147","updated":"2017-05-23 04:19:16.000000000","message":"In my understanding, CLI format has not discussed so much.  Therefore, it worth to discuss here.  Anyway, I\u0027ll align with latest our SPEC.  Let\u0027t start discussing CLI format from next PS.","commit_id":"86b6dfbb52f3776bd4f59d00ca6241ac002213f4"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"53c0b78c622721a8dd390c7e51ccd683a013951c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    bgpvpn_router_association_list \u003d neutronclient.osc.v2.networking_bgpvpn.router_association:ListBgpvpnRouterAssoc"},{"line_number":80,"context_line":"    bgpvpn_router_association_show \u003d neutronclient.osc.v2.networking_bgpvpn.router_association:ShowBgpvpnRouterAssoc"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    network_loggable_resources_list \u003d neutronclient.osc.v2.logging.network_log:ListLoggableResource"},{"line_number":83,"context_line":"    network_logging_create \u003d neutronclient.osc.v2.logging.network_log:CreateNetworkLog"},{"line_number":84,"context_line":"    network_logging_delete \u003d neutronclient.osc.v2.logging.network_log:DeleteNetworkLog"},{"line_number":85,"context_line":"    network_logging_list \u003d neutronclient.osc.v2.logging.network_log:ListNetworkLog"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"ff0f0b1f_e9ce88b2","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":35},"updated":"2017-05-23 04:27:37.000000000","message":"I think it should be aligned other resource format like QoS[1]  It\u0027s better as following format.  Please give your opinion..\n\n* network loggable resource list\n* network logging type list\n\n\n[1]https://github.com/openstack/python-openstackclient/blob/master/setup.cfg#L418","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15471,"name":"Nguyen Phuong An","email":"annp.cs51@gmail.com","username":"An-FVL"},"change_message_id":"3d3e999c53b9b79cadd27f928097aef2b2931043","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    bgpvpn_router_association_list \u003d neutronclient.osc.v2.networking_bgpvpn.router_association:ListBgpvpnRouterAssoc"},{"line_number":80,"context_line":"    bgpvpn_router_association_show \u003d neutronclient.osc.v2.networking_bgpvpn.router_association:ShowBgpvpnRouterAssoc"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    network_loggable_resources_list \u003d neutronclient.osc.v2.logging.network_log:ListLoggableResource"},{"line_number":83,"context_line":"    network_logging_create \u003d neutronclient.osc.v2.logging.network_log:CreateNetworkLog"},{"line_number":84,"context_line":"    network_logging_delete \u003d neutronclient.osc.v2.logging.network_log:DeleteNetworkLog"},{"line_number":85,"context_line":"    network_logging_list \u003d neutronclient.osc.v2.logging.network_log:ListNetworkLog"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"ff0f0b1f_290da0a0","line":82,"range":{"start_line":82,"start_character":4,"end_line":82,"end_character":35},"in_reply_to":"ff0f0b1f_e9ce88b2","updated":"2017-05-23 04:50:55.000000000","message":"From my opinion, I\u0027d prefer `network loggable resource list` because it reflexes the ability of logging API. What do you think?","commit_id":"56f776160057fe69dab0beab23c18e934e0b6d34"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"62bfeaaf8704a2bd69df54cd837e6be14440e39c","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    network_logging_list \u003d neutronclient.osc.v2.logging.network_log:ListNetworkLog"},{"line_number":86,"context_line":"    network_logging_set \u003d neutronclient.osc.v2.logging.network_log:SetNetworkLog"},{"line_number":87,"context_line":"    network_logging_show \u003d neutronclient.osc.v2.logging.network_log:ShowNetworkLog"},{"line_number":88,"context_line":"    network_logging_unset \u003d neutronclient.osc.v2.logging.network_log:UnsetNetworkLog"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"[build_sphinx]"},{"line_number":91,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"ff0f0b1f_1ae8d9df","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":84},"updated":"2017-05-23 10:08:52.000000000","message":"According to the spec: We don\u0027t support *unset* command.\nIt is reasonable. Because we can just update \"name\", \"description\" and \"enabled/disabled\" options. So supporting *set* command is enough.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"c445296ae607b11aaecf637a798babea532d2801","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    network_logging_list \u003d neutronclient.osc.v2.logging.network_log:ListNetworkLog"},{"line_number":86,"context_line":"    network_logging_set \u003d neutronclient.osc.v2.logging.network_log:SetNetworkLog"},{"line_number":87,"context_line":"    network_logging_show \u003d neutronclient.osc.v2.logging.network_log:ShowNetworkLog"},{"line_number":88,"context_line":"    network_logging_unset \u003d neutronclient.osc.v2.logging.network_log:UnsetNetworkLog"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"[build_sphinx]"},{"line_number":91,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"ff0f0b1f_1711c704","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":84},"in_reply_to":"ff0f0b1f_1ae8d9df","updated":"2017-05-23 13:31:15.000000000","message":"I thought that \u0027update\u0027 is \u0027set\u0027 and \u0027unset\u0027.  Let\u0027s wait OSC reviewer\u0027s comment.","commit_id":"c75c4ebc447cab4845af8cdf97a22e66fd248d18"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"8997b5b68fcf6056eb97edc72957fabfe7615c00","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    vpn-ikepolicy-update \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:UpdateIKEPolicy"},{"line_number":364,"context_line":"    vpn-ikepolicy-delete \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:DeleteIKEPolicy"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    network_loggable_resources_list \u003d neutronclient.osc.v2.logging.network_log:ListLoggableResource"},{"line_number":367,"context_line":"    network_log_create \u003d neutronclient.osc.v2.logging.network_log:CreateNetworkLog"},{"line_number":368,"context_line":"    network_log_delete \u003d neutronclient.osc.v2.logging.network_log:DeleteNetworkLog"},{"line_number":369,"context_line":"    network_log_list \u003d neutronclient.osc.v2.logging.network_log:ListNetworkLog"},{"line_number":370,"context_line":"    network_log_set \u003d neutronclient.osc.v2.logging.network_log:SetNetworkLog"},{"line_number":371,"context_line":"    network_log_show \u003d neutronclient.osc.v2.logging.network_log:ShowNetworkLog"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"[build_sphinx]"},{"line_number":374,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":19,"id":"3f1d235d_a7557e52","line":371,"range":{"start_line":366,"start_character":0,"end_line":371,"end_character":78},"updated":"2017-07-12 07:41:25.000000000","message":"I think these should be moved to above L82.","commit_id":"9feb5cbe78cd1bcdf0df542e78d9d28719dd5723"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"021ca5d26365e3493bedce3ab5f0ff4b8560e1c7","unresolved":false,"context_lines":[{"line_number":363,"context_line":"    vpn-ikepolicy-update \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:UpdateIKEPolicy"},{"line_number":364,"context_line":"    vpn-ikepolicy-delete \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:DeleteIKEPolicy"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    network_loggable_resources_list \u003d neutronclient.osc.v2.logging.network_log:ListLoggableResource"},{"line_number":367,"context_line":"    network_log_create \u003d neutronclient.osc.v2.logging.network_log:CreateNetworkLog"},{"line_number":368,"context_line":"    network_log_delete \u003d neutronclient.osc.v2.logging.network_log:DeleteNetworkLog"},{"line_number":369,"context_line":"    network_log_list \u003d neutronclient.osc.v2.logging.network_log:ListNetworkLog"},{"line_number":370,"context_line":"    network_log_set \u003d neutronclient.osc.v2.logging.network_log:SetNetworkLog"},{"line_number":371,"context_line":"    network_log_show \u003d neutronclient.osc.v2.logging.network_log:ShowNetworkLog"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"[build_sphinx]"},{"line_number":374,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":19,"id":"1f1a1f67_d6cb0270","line":371,"range":{"start_line":366,"start_character":0,"end_line":371,"end_character":78},"in_reply_to":"3f1d235d_a7557e52","updated":"2017-07-12 08:31:44.000000000","message":"Done","commit_id":"9feb5cbe78cd1bcdf0df542e78d9d28719dd5723"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"68182114b872a0234400de2b8b67e5b15f6fde98","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    vpn-ikepolicy-show \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:ShowIKEPolicy"},{"line_number":384,"context_line":"    vpn-ikepolicy-create \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:CreateIKEPolicy"},{"line_number":385,"context_line":"    vpn-ikepolicy-update \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:UpdateIKEPolicy"},{"line_number":386,"context_line":"    vpn-ikepolicy-delete \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:DeleteIKEPolicy"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"[build_sphinx]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":29,"id":"5f4e5783_7bfdacaf","side":"PARENT","line":386,"updated":"2017-10-15 12:21:42.000000000","message":"This is actually unrelated but I am okay as there is no need for two blank lines.","commit_id":"58426543cab23c891dc3eaba43ce2d0d4ebe22a3"},{"author":{"_account_id":13702,"name":"yushiro","username":"yushiro","inactive":true},"change_message_id":"b8341864bcd94f250fdbeeb346e199c053bba66b","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    vpn-ikepolicy-show \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:ShowIKEPolicy"},{"line_number":384,"context_line":"    vpn-ikepolicy-create \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:CreateIKEPolicy"},{"line_number":385,"context_line":"    vpn-ikepolicy-update \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:UpdateIKEPolicy"},{"line_number":386,"context_line":"    vpn-ikepolicy-delete \u003d neutronclient.neutron.v2_0.vpn.ikepolicy:DeleteIKEPolicy"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"[build_sphinx]"}],"source_content_type":"text/x-ttcn-cfg","patch_set":29,"id":"5f4e5783_73326c60","side":"PARENT","line":386,"in_reply_to":"5f4e5783_7bfdacaf","updated":"2017-10-16 04:24:47.000000000","message":"Aha, thanks Akihiro.  Maybe I did it while rebasing this patch.","commit_id":"58426543cab23c891dc3eaba43ce2d0d4ebe22a3"}]}
