)]}'
{"id":"openstack%2Fpython-neutronclient~4301","triplet_id":"openstack%2Fpython-neutronclient~master~I230657de1621ddf08573bbeaceeb26cafbee1a00","project":"openstack/python-neutronclient","branch":"master","topic":"bp/quantum-client-1.1","hashtags":[],"change_id":"I230657de1621ddf08573bbeaceeb26cafbee1a00","subject":"bp/quantum-client-1.1","status":"MERGED","created":"2012-02-28 01:14:05.000000000","updated":"2012-02-28 01:14:05.000000000","submitted":"2012-02-28 01:14:05.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":54,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"76b92598795af2571d50b8d151369200bf83d014","_number":4301,"virtual_id_number":4301,"owner":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"value":0,"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":1,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"all":[{"value":2,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"value":1,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},{"value":0,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"permitted_voting_range":{"min":0,"max":1},"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":1,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"permitted_voting_range":{"min":1,"max":1},"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"all":[{"value":1,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"value":0,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},{"value":0,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"date":"2012-02-28 01:14:05.000000000","post_submit":true,"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-02-28 01:14:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2012-02-28 01:14:05.000000000","updated_by":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"reviewer":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"state":"REVIEWER"},{"updated":"2012-02-28 01:14:05.000000000","updated_by":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"reviewer":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"state":"REVIEWER"},{"updated":"2012-02-28 01:14:05.000000000","updated_by":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"reviewer":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"state":"REVIEWER"},{"updated":"2012-02-28 01:14:05.000000000","updated_by":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"reviewer":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"state":"REVIEWER"}],"messages":[{"id":"f52573ac453de093c7ba62810cfa22ca5d8e3d69","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 01:14:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1},{"id":"bdfa724e5e32711f253b8a4f70127d3ae6799908","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-merge/15/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-pep8/16/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"dbfe07a38bb2ddee4ed4653ea41bba7e370f37bf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 2: Fails\n\nBuild Failed \n \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-merge/19/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-pep8/20/ : FAILURE","accounts_in_message":[],"_revision_number":2},{"id":"6ebcc10ce003650746fa5389aff1f6edabfdff31","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 2: (14 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"c2a7a2659779781e5d8f11cbc1d515e904842e44","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2e43eab090e1355cf0b613d52d0e79657796ac1c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-merge/20/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-pep8/21/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"998afead0f1f7bd8cb3d18d5d1e27c6c3f75c1db","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"67327b0fa9f639394b0047a551582724c3fc876f","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 3:\n\nDan, thanks for review!\nPatchset 3 contains only pep8 fixes (I pushed it without checking your review). I will update another patch set soon.","accounts_in_message":[],"_revision_number":3},{"id":"f7b16d4ba1438516412763b13b9e535708792a4c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-merge/21/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-pep8/22/ : SUCCESS","accounts_in_message":[],"_revision_number":4},{"id":"2be5255733419ac8aa6c17fedfcae9d3530602d4","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"2af7057111c70e6e614f572082b5db2e2cc74569","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4: (8 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"c73506f9c3f22b722a0ceddb7680b001a5f998d8","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4:\n\nThanks for spotting the issue with unit tests.\nMaru, we are already aware of the problem with unit tests, as they are actually run by Quantum, and not python-QuantumClient.\n\nI understand your concern; I would like to hear other contributors\u0027 opinions too, because if that is the case we should refrain from pushing any change into python-quantumclient until the unit test suite is moved from quantum to python-quantumclient.","accounts_in_message":[],"_revision_number":4},{"id":"8f5e4b891fe5707bd57d71a7032131d0a5611171","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4:\n\nRe Issue spotted with unit tests.\n\nI am running CLI unit tests against patchset #4 on my dev machine, I cannot reproduce the failure observed by Edgar.\n\nI\u0027ve pasted the output for the test here:http://paste.openstack.org/show/4980/","accounts_in_message":[],"_revision_number":4},{"id":"a1176dc2b5181aaceeaf3dbdd771bd68281692b4","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4:\n\nForget about my last comment. I checked out the wrong branch.","accounts_in_message":[],"_revision_number":4},{"id":"6104d8085e4373423649c5ff75f59c61866bfc87","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-merge/24/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-pep8/25/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"ba769a8c06f61a0cb4254c3d80219c131ecb621c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5:\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-python26/12/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-python27/12/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-merge/25/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-python-quantumclient-pep8/26/ : SUCCESS","accounts_in_message":[],"_revision_number":5},{"id":"b21defd758ad7a458b1f75798753e3d0ac25d09f","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5:\n\nApart from unit tests, I have only addressed comments from Maru, mainly on dict get operations and if conditions.","accounts_in_message":[],"_revision_number":5},{"id":"8fc72343546df7ed4eb0a80d072de0fbaa6393e9","author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"date":"2012-02-28 01:14:05.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"f68eec5f495e2b9a38e02ab76e244e0634cc7b41","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 2: (21 inline comments)\n\nOverall, looks good, thanks for doing this.  A fair number of minor comments just from looking through the code.  Next round I\u0027ll do full testing, etc.  If we don\u0027t get this done for tuesday, I\u0027m fine letting this review continue a bit late, especially since most people in the US have today off.","accounts_in_message":[],"_revision_number":2},{"id":"42efb80204bae41d60a83ac5c329bb7acd8af307","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4:\n\nHi Maru,\n\nTo clarify, neither of the Quantum repos currently automatically gate based on jenkins automatically running the unit tests.  Generally, it is the responsibility of a submitter to run the tests before they post a change, and for a reviewer to run the tests as a confirmation before the \"approve\" a commit.  Assuming reviewers manually run the tests before approving on this patch, I think it is OK to accept it.  I sent an email to the openstack CI folks to ask them to increase the automated checks performed by Jenkins now that Quantum is on the path to being a \"core\" project (up until now, the CI folks have been doing Quantum work only on an adhoc basis, as their primary focus is on core projects).","accounts_in_message":[],"_revision_number":4},{"id":"ce50a26384a749115f2dd2f0ba977c88379e4e37","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5:\n\nLet\u0027s hang on for a few more hours to see if Maru wants to comment.  He mentioned he may do a few re-reviews friday afternoon.","accounts_in_message":[],"_revision_number":5},{"id":"5bd922992b379ff40021131441f1992af547e0a9","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n(1 inline comment)\n\nOk, I think all of my comments have been addressed.  \n\nUnit tests are clean.  We have two core reviews, so if anyone else is planning on re-reviewing this, please do so fairly soon.","accounts_in_message":[],"_revision_number":5},{"id":"cb2160d6e7428bf6706e167e6737e971319df2e9","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5: Approved\n\nLooks like no more reviews are coming.  Let\u0027s merge this.","accounts_in_message":[],"_revision_number":5},{"id":"2046ad743ceb9876c0f765255824e2b31289a683","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5:\n\nUnit tests look good.  Salvatore, were there other changes to the code other than unit tests, or is the rest of the code the same as I reviewed originally?","accounts_in_message":[],"_revision_number":5},{"id":"d766a3e98ad6f8b0893f20921192d53b0edbfa5f","author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4:\n\nHi Salvatore, If I understand correctly, there are two separate issues here:\n1. CLI unit tests are not running for this repo\n2. The CLI unit tests need to be tweaked to work with the new cli_lib.py\n\nIf the later is correct, one approach would be to fix the tests and check them in. Issue 1 can then be fixed independently.\n\nI am able to run the CLI and confirm that it works. So in that sense I would support pushing it in.","accounts_in_message":[],"_revision_number":4},{"id":"2511651a4b98d14811add893c4672d9d8dc133d0","author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4:\n\nDo the tests under /quantum/client/tests/unit/test_cli.py need to be changed? I am seeing errors due to missing version numbers (or am I not running the tests properly):\n\nERROR:quantum.tests.test_cli:Exception caught: (\u003ctype \u0027exceptions.ValueError\u0027\u003e, ValueError(\u0027need more than 2 values to unpack\u0027,), \u003ctraceback object at 0x3674320\u003e)\nTraceback (most recent call last):\n  File \"/root/sw/openstack/src/old-repos/reviews/quantum/quantum/client/tests/unit/test_cli.py\", line 233, in test_create_network\n    cli.create_net(self.client, self.tenant_id, \"test\")\n  File \"/root/sw/openstack/src/old-repos/reviews/quantum/quantum/client/cli_lib.py\", line 209, in create_net\n    tenant_id, name, version \u003d args\nValueError: need more than 2 values to unpack","accounts_in_message":[],"_revision_number":4},{"id":"b3c8e317ca4a127195549ca2d8401c6557ae03d7","author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"4cf165215974156621bbc8b44b10850649366f66","author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4:\n\nI confirmed the issue with the unit tests. This is a section of the logs:\n\n\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\nFAIL: test_update_port (quantum.client.tests.unit.test_cli.CLITest)\n----------------------------------------------------------------------\nTraceback (most recent call last):\n  File \"/python-quantumclient/quantum/client/tests/unit/test_cli.py\", line 342, in test_update_port\n    self.fail(\"test_update_port failed due to an exception\")\nAssertionError: test_update_port failed due to an exception\n-------------------- \u003e\u003e begin captured logging \u003c\u003c --------------------\nroutes.middleware: DEBUG: Initialized with method overriding \u003d True, and path info altering \u003d True\nquantum.tests.test_cli: ERROR: Exception caught: (\u003ctype \u0027exceptions.ValueError\u0027\u003e, ValueError(\u0027need more than 4 values to unpack\u0027,), \u003ctraceback object at 0x33d3f80\u003e)\nTraceback (most recent call last):\n  File \"/python-quantumclient/quantum/client/tests/unit/test_cli.py\", line 339, in test_update_port\n    port_id, \u0027state\u003dACTIVE\u0027)\n  File \"/python-quantumclient/quantum/client/cli_lib.py\", line 358, in update_port\n    tenant_id, network_id, port_id, param_data, version \u003d args\nValueError: need more than 4 values to unpack","accounts_in_message":[],"_revision_number":4},{"id":"a51bf347ee2c2e92a4f0deef27cd2ca0a689f295","author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\nNo more comments! I\u0027ll let Salvatore to make the honors!","accounts_in_message":[],"_revision_number":5},{"id":"7571c5882fdc1370ee5c72281ed577421e08c59a","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 4: I would prefer that you didn\u0027t submit this\n\n(8 inline comments)\n\nIt does not appear that the unit tests are being run by Jenkins.  Until they are configured to run automatically, I\u0027m not any change to this repo should be approved.\n\nLooks pretty good, but there is a bug in exception_handler_v11 that needs to be fixed, and there should be a test against it and the other new code to prevent regressions.","accounts_in_message":[],"_revision_number":4},{"id":"f2f032f7f9b9812bb00a1c2b7ec0d173af8025ea","author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"date":"2012-02-28 01:14:05.000000000","message":"Patch Set 5: (2 inline comments)\n\n+1","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"f6d50876985ed9a392fa49dda9c0fc4108a2ac8d","revisions":{"96eec66d29601f5c790bf109b60af894d27b4908":{"kind":"REWORK","_number":1,"created":"2012-02-28 01:14:05.000000000","uploader":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"ref":"refs/changes/01/4301/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/01/4301/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/1"}}},"commit":{"parents":[{"commit":"caca89aed092cb1624a0e4d6e0945090746b0d6c","subject":"bug 933125 ensure cli.py executes from the shell","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/caca89aed092cb1624a0e4d6e0945090746b0d6c"}]}],"author":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-13 14:38:17.000000000","tz":0},"committer":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-19 00:41:01.000000000","tz":0},"subject":"bp/quantum-client-1.1","message":"bp/quantum-client-1.1\n\nPatch set made available for preview.\nPlease do not approve.\nSalvatore\n\nChange-Id: I230657de1621ddf08573bbeaceeb26cafbee1a00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/96eec66d29601f5c790bf109b60af894d27b4908"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/96eec66d29601f5c790bf109b60af894d27b4908"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"caca89aed092cb1624a0e4d6e0945090746b0d6c","is_merged_in_target_branch":true,"change_id":"I48e6478c5c38a76ef44182b741106fb3a69543e9","change_number":4216,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"68d0c8520505263a4ba2cce2aa535e5cf7e7143e":{"kind":"REWORK","_number":2,"created":"2012-02-28 01:14:05.000000000","uploader":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"ref":"refs/changes/01/4301/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/01/4301/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/2"}}},"commit":{"parents":[{"commit":"55547ca785587ddc810119f3eb15ff009200fa86","subject":"Merge \"Enable log output to syslog.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/55547ca785587ddc810119f3eb15ff009200fa86"}]}],"author":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-13 14:38:17.000000000","tz":0},"committer":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-19 23:31:44.000000000","tz":0},"subject":"bp/quantum-client-1.1","message":"bp/quantum-client-1.1\n\n- Adds supports for 1.1 API\n- Handles new error codes\n- Support filters for 1.1 API\n\nChange-Id: I230657de1621ddf08573bbeaceeb26cafbee1a00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/68d0c8520505263a4ba2cce2aa535e5cf7e7143e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/68d0c8520505263a4ba2cce2aa535e5cf7e7143e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"55547ca785587ddc810119f3eb15ff009200fa86","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"9bfebd124651e30cfe9a68a2088219c21be0f300":{"kind":"REWORK","_number":3,"created":"2012-02-28 01:14:05.000000000","uploader":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"ref":"refs/changes/01/4301/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/01/4301/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/3"}}},"commit":{"parents":[{"commit":"55547ca785587ddc810119f3eb15ff009200fa86","subject":"Merge \"Enable log output to syslog.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/55547ca785587ddc810119f3eb15ff009200fa86"}]}],"author":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-13 14:38:17.000000000","tz":0},"committer":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-20 19:34:14.000000000","tz":0},"subject":"bp/quantum-client-1.1","message":"bp/quantum-client-1.1\n\n- Adds supports for 1.1 API\n- Handles new error codes\n- Support filters for 1.1 API\n\nNow without pep8 errors\n\nChange-Id: I230657de1621ddf08573bbeaceeb26cafbee1a00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9bfebd124651e30cfe9a68a2088219c21be0f300"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/9bfebd124651e30cfe9a68a2088219c21be0f300"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"55547ca785587ddc810119f3eb15ff009200fa86","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"03434c8fea2413590fc6715aa196dd69d0fda457":{"kind":"REWORK","_number":4,"created":"2012-02-28 01:14:05.000000000","uploader":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"ref":"refs/changes/01/4301/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/01/4301/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/4"}}},"commit":{"parents":[{"commit":"55547ca785587ddc810119f3eb15ff009200fa86","subject":"Merge \"Enable log output to syslog.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/55547ca785587ddc810119f3eb15ff009200fa86"}]}],"author":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-13 14:38:17.000000000","tz":0},"committer":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-21 00:02:18.000000000","tz":0},"subject":"bp/quantum-client-1.1","message":"bp/quantum-client-1.1\n\n- Adds supports for 1.1 API\n- Handles new error codes\n- Support filters for 1.1 API\n\nAddressing Dan\u0027s comments\n\nChange-Id: I230657de1621ddf08573bbeaceeb26cafbee1a00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/03434c8fea2413590fc6715aa196dd69d0fda457"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/03434c8fea2413590fc6715aa196dd69d0fda457"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"55547ca785587ddc810119f3eb15ff009200fa86","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"f6d50876985ed9a392fa49dda9c0fc4108a2ac8d":{"kind":"REWORK","_number":5,"created":"2012-02-28 01:14:05.000000000","uploader":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"ref":"refs/changes/01/4301/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/01/4301/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/01/4301/5"}}},"commit":{"parents":[{"commit":"880cde716e673a829b6e352116a039588f42d2b9","subject":"Bug 921930 remove depedency on webob from python-quantumclient","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/880cde716e673a829b6e352116a039588f42d2b9"}]}],"author":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-13 14:38:17.000000000","tz":0},"committer":{"name":"Salvatore Orlando","email":"salvatore.orlando@eu.citrix.com","date":"2012-02-23 22:53:08.000000000","tz":0},"subject":"bp/quantum-client-1.1","message":"bp/quantum-client-1.1\n\n- Adds supports for 1.1 API\n- Handles new error codes\n- Support filters for 1.1 API\n\nAddressing Dan\u0027s comments\n\nChange-Id: I230657de1621ddf08573bbeaceeb26cafbee1a00\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/f6d50876985ed9a392fa49dda9c0fc4108a2ac8d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/f6d50876985ed9a392fa49dda9c0fc4108a2ac8d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"880cde716e673a829b6e352116a039588f42d2b9","is_merged_in_target_branch":true,"change_id":"I7dc3840018f3496116d30c2684bc44f64fa2752b","change_number":4337,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}