)]}'
{"doc/source/usage/osc/v2/firewall-group.rst":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"34bb9bf4ed4fb5d2bad28a9fb914ffc853bd919b","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. option:: --shared"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Make the firewall group shared, which allows it to be used in all projects"},{"line_number":37,"context_line":"    (as opposed to the default, which is to restrict its use to the current"},{"line_number":38,"context_line":"    project)."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_6878408f","line":36,"range":{"start_line":36,"start_character":36,"end_line":36,"end_character":78},"updated":"2017-04-04 22:54:55.000000000","message":"I think it would be much more clearer if we change this to something like \"which allows it to be used in all projects with which the firewall resources are shared\" instead of \"which allows it to be used in all projects\"","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"277a0a2d96c12c38f5f345f8fe25825788c0fc26","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":".. option:: --shared"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    Make the firewall group shared, which allows it to be used in all projects"},{"line_number":37,"context_line":"    (as opposed to the default, which is to restrict its use to the current"},{"line_number":38,"context_line":"    project)."},{"line_number":39,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_f33e7cb6","line":36,"range":{"start_line":36,"start_character":36,"end_line":36,"end_character":78},"in_reply_to":"dfeb2761_6878408f","updated":"2017-04-05 07:02:58.000000000","message":"Hi Anindita, \nthis is similar to the --shared option for the network.","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"34bb9bf4ed4fb5d2bad28a9fb914ffc853bd919b","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":".. option:: --shared"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    Make the firewall group shared, which allows it to be used in all projects"},{"line_number":142,"context_line":"    (as opposed to the default, which is to restrict its use to the current"},{"line_number":143,"context_line":"    project)."},{"line_number":144,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_286eb8c8","line":141,"range":{"start_line":141,"start_character":36,"end_line":141,"end_character":78},"updated":"2017-04-04 22:54:55.000000000","message":"ditto","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1eae398c4cb7630f079babea3b39b7f3ca4b92db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1f1a1f67_f51f3969","updated":"2017-07-19 08:26:39.000000000","message":"This is incorrect now. we have cli/osc/v2/firewall-group.rst.","commit_id":"54fbd912c33c00703edad962840a1f54cd4145ed"}],"doc/source/usage/osc/v2/firewall-policy.rst":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"34bb9bf4ed4fb5d2bad28a9fb914ffc853bd919b","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":".. option:: --shared"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    Make the firewall policy shared, which allows it to be used in all projects"},{"line_number":39,"context_line":"    (as opposed to the default, which is to restrict its use to the current"},{"line_number":40,"context_line":"    project)."},{"line_number":41,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_48f0dcfe","line":38,"range":{"start_line":38,"start_character":67,"end_line":38,"end_character":79},"updated":"2017-04-04 22:54:55.000000000","message":"ditto as in line 36 of firewall-group.rst","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"34bb9bf4ed4fb5d2bad28a9fb914ffc853bd919b","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":".. option:: --shared"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    Make the firewall policy shared, which allows it to be used in all projects"},{"line_number":137,"context_line":"    (as opposed to the default, which is to restrict its use to the current"},{"line_number":138,"context_line":"    project)."},{"line_number":139,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"dfeb2761_28f11802","line":136,"range":{"start_line":136,"start_character":67,"end_line":136,"end_character":79},"updated":"2017-04-04 22:54:55.000000000","message":"ditto","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"}],"neutronclient/osc/v2/fwaas/firewallgroup.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"34bb9bf4ed4fb5d2bad28a9fb914ffc853bd919b","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            dest\u003d\u0027egress_firewall_policy\u0027,"},{"line_number":335,"context_line":"            help\u003d_(\u0027Egress firewall policy (name or ID) to delete\u0027))"},{"line_number":336,"context_line":"        parser.add_argument("},{"line_number":337,"context_line":"            \u0027--shared\u0027,"},{"line_number":338,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":339,"context_line":"            help\u003d_(\u0027Restrict use of the firewall group to the \u0027"},{"line_number":340,"context_line":"                   \u0027current project\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_c8206c4b","line":337,"range":{"start_line":337,"start_character":15,"end_line":337,"end_character":21},"updated":"2017-04-04 22:54:55.000000000","message":"Shouldn\u0027t we change this to private and parse it accordingly?","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"277a0a2d96c12c38f5f345f8fe25825788c0fc26","unresolved":false,"context_lines":[{"line_number":334,"context_line":"            dest\u003d\u0027egress_firewall_policy\u0027,"},{"line_number":335,"context_line":"            help\u003d_(\u0027Egress firewall policy (name or ID) to delete\u0027))"},{"line_number":336,"context_line":"        parser.add_argument("},{"line_number":337,"context_line":"            \u0027--shared\u0027,"},{"line_number":338,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":339,"context_line":"            help\u003d_(\u0027Restrict use of the firewall group to the \u0027"},{"line_number":340,"context_line":"                   \u0027current project\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_13756064","line":337,"range":{"start_line":337,"start_character":15,"end_line":337,"end_character":21},"in_reply_to":"dfeb2761_c8206c4b","updated":"2017-04-05 07:02:58.000000000","message":"This is the Unset command, and we are trying to remove the shared option ...\nPutting it as --private in the unset would seem like removing the Private attribute  :) ( Catching the nose by the longer route :D )","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"327058a04d9b6567cd4979df72082a7247ca3490","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    shared_group.add_argument("},{"line_number":80,"context_line":"        \u0027--shared\u0027,"},{"line_number":81,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":82,"context_line":"        help\u003d_(\u0027Make the firewall group shared, which allows it to be \u0027"},{"line_number":83,"context_line":"               \u0027used in all projects (as opposed to the default, \u0027"},{"line_number":84,"context_line":"               \u0027which is to restrict its use to the current project)\u0027))"},{"line_number":85,"context_line":"    shared_group.add_argument("},{"line_number":86,"context_line":"        \u0027--private\u0027,"},{"line_number":87,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_4394bb8b","line":84,"range":{"start_line":82,"start_character":16,"end_line":84,"end_character":68},"updated":"2017-04-06 02:02:01.000000000","message":"I think this needs to be updated with the same text as in the *.rst\u0027s\n\n\"Share the firewall group to be used in all projects\n    (By default, it is restricted to be used to the current project)\"","commit_id":"bf5e172782e3a3cd48d52ce95a421a3c45418d95"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a0629a2dc92a9fd9bf5177316016250d56972ff","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        help\u003d_(\u0027Detach egress firewall policy from the firewall group\u0027))"},{"line_number":78,"context_line":"    public_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":79,"context_line":"    public_group.add_argument("},{"line_number":80,"context_line":"        \u0027--public\u0027,"},{"line_number":81,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":82,"context_line":"        help\u003d_(\u0027Make the firewall group public, which allows it to be \u0027"},{"line_number":83,"context_line":"               \u0027used in all projects (as opposed to the default, \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_1095a240","side":"PARENT","line":80,"updated":"2017-04-07 05:23:12.000000000","message":"Hmm... the release note says --public option is just deprecated. Deprecation means it will be dropped in the future and discouraged to be used, but you drops it directly.\nIt is not called \"deprecation\". It is \"removal\".\n\nI think FWaaS v2 API is experimental(?) and backward-incompatible change may happen for experimental APIs. If FWaaS team wants to replace the option without deprecation, I am okay with it if it is in the experimental phase. (If so, \u0027deprecation\u0027 section should be changed to \u0027upgrade\u0027 section.)","commit_id":"ef93a52c2bef642e21644b232890706ef090503d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c1f75edfddc4d767de685cfad5c1e47552cefdb7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        help\u003d_(\u0027Detach egress firewall policy from the firewall group\u0027))"},{"line_number":78,"context_line":"    public_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":79,"context_line":"    public_group.add_argument("},{"line_number":80,"context_line":"        \u0027--public\u0027,"},{"line_number":81,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":82,"context_line":"        help\u003d_(\u0027Make the firewall group public, which allows it to be \u0027"},{"line_number":83,"context_line":"               \u0027used in all projects (as opposed to the default, \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_63d41821","side":"PARENT","line":80,"in_reply_to":"bff0334d_1095a240","updated":"2017-04-07 13:21:55.000000000","message":"I agree with you. Let me discuss the same in the weekly meeting and rehash this patch","commit_id":"ef93a52c2bef642e21644b232890706ef090503d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e8e6a0484900dd62b66830dfc1c3dc24afb9be2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    (\u0027status\u0027, \u0027Status\u0027, osc_utils.LIST_LONG_ONLY),"},{"line_number":41,"context_line":"    (\u0027ports\u0027, \u0027Ports\u0027, osc_utils.LIST_LONG_ONLY),"},{"line_number":42,"context_line":"    (\u0027admin_state_up\u0027, \u0027State\u0027, osc_utils.LIST_LONG_ONLY),"},{"line_number":43,"context_line":"    (\u0027shared\u0027, \u0027Shared\u0027, osc_utils.LIST_LONG_ONLY),"},{"line_number":44,"context_line":"    (\u0027tenant_id\u0027, \u0027Project\u0027, osc_utils.LIST_LONG_ONLY),"},{"line_number":45,"context_line":")"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_bcee1b89","line":43,"updated":"2017-05-26 03:46:28.000000000","message":"Don\u0027t we need to handle older releases of FWaaS v2? Or FWaaS team decides not to keep backward compatibility for FWaaS v2 at now?\n\nIf we keep backward compatibility, it is better to handle \u0027public\u0027 as same as for \u0027shared\u0027. That is, if a return data contains only \u0027public\u0027, it is shown in \u0027Shared\u0027 column.","commit_id":"24f8e00b7eb8a076ccd531c8951db34084d4c0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e8e6a0484900dd62b66830dfc1c3dc24afb9be2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        help\u003d_(\u0027Make the firewall group public, which allows it to be \u0027"},{"line_number":83,"context_line":"               \u0027used in all projects (as opposed to the default, \u0027"},{"line_number":84,"context_line":"               \u0027which is to restrict its use to the current project).\u0027"},{"line_number":85,"context_line":"               \u0027 This option is deprecated and would be removed in R release\u0027))"},{"line_number":86,"context_line":"    shared_group.add_argument("},{"line_number":87,"context_line":"        \u0027--shared\u0027,"},{"line_number":88,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_dc1c2fc3","line":85,"range":{"start_line":85,"start_character":16,"end_line":85,"end_character":17},"updated":"2017-05-26 03:46:28.000000000","message":"For consistency, move a space to the end of the previous line.","commit_id":"24f8e00b7eb8a076ccd531c8951db34084d4c0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e8e6a0484900dd62b66830dfc1c3dc24afb9be2","unresolved":false,"context_lines":[{"line_number":84,"context_line":"               \u0027which is to restrict its use to the current project).\u0027"},{"line_number":85,"context_line":"               \u0027 This option is deprecated and would be removed in R release\u0027))"},{"line_number":86,"context_line":"    shared_group.add_argument("},{"line_number":87,"context_line":"        \u0027--shared\u0027,"},{"line_number":88,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":89,"context_line":"        help\u003d_(\u0027Share the firewall group to be used in all projects \u0027"},{"line_number":90,"context_line":"               \u0027(by default, it is restricted to be used by the \u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_5c5fff71","line":87,"range":{"start_line":87,"start_character":11,"end_line":87,"end_character":17},"updated":"2017-05-26 03:46:28.000000000","message":"Use --share instead of --shared.\nIt is consistent with \"openstack network create\".","commit_id":"24f8e00b7eb8a076ccd531c8951db34084d4c0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e8e6a0484900dd62b66830dfc1c3dc24afb9be2","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        attrs[\u0027egress_firewall_policy_id\u0027] \u003d None"},{"line_number":142,"context_line":"    if parsed_args.shared or parsed_args.public:"},{"line_number":143,"context_line":"        attrs[\u0027shared\u0027] \u003d True"},{"line_number":144,"context_line":"    if parsed_args.private:"},{"line_number":145,"context_line":"        attrs[\u0027shared\u0027] \u003d False"},{"line_number":146,"context_line":"    if parsed_args.enable:"},{"line_number":147,"context_line":"        attrs[\u0027admin_state_up\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_1c518763","line":144,"range":{"start_line":144,"start_character":19,"end_line":144,"end_character":26},"updated":"2017-05-26 03:46:28.000000000","message":"--private/--public is good, but --private/--shared looks odd.\n--share/--no-share looks better.","commit_id":"24f8e00b7eb8a076ccd531c8951db34084d4c0be"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c8ad6ab065373549ad6c01a0ba091a14024da1be","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \u0027--no-share\u0027,"},{"line_number":94,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":95,"context_line":"        help\u003d_(\u0027Restrict use of the firewall group to the \u0027"},{"line_number":96,"context_line":"               \u0027current project\u0027))"},{"line_number":97,"context_line":"    admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":98,"context_line":"    admin_group.add_argument("},{"line_number":99,"context_line":"        \u0027--enable\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_e35e27e8","line":96,"updated":"2017-05-26 09:39:34.000000000","message":"No backward compatibility for --private? No deprecation message?","commit_id":"01c9afd82d32219af71c01d8eb509f61a0f3cc7f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"e1812fbd647c217916b625977c1c43e0dc70ebc9","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        \u0027--no-share\u0027,"},{"line_number":94,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":95,"context_line":"        help\u003d_(\u0027Restrict use of the firewall group to the \u0027"},{"line_number":96,"context_line":"               \u0027current project\u0027))"},{"line_number":97,"context_line":"    admin_group \u003d parser.add_mutually_exclusive_group()"},{"line_number":98,"context_line":"    admin_group.add_argument("},{"line_number":99,"context_line":"        \u0027--enable\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"df140735_2cc53e8f","line":96,"in_reply_to":"ff0f0b1f_e35e27e8","updated":"2017-05-29 06:12:18.000000000","message":"+1. I think we should support backward compatibility instead deprecate it. Thought?","commit_id":"01c9afd82d32219af71c01d8eb509f61a0f3cc7f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"03ebce9787a07f8ead32b5c129b0c6dbeb2c8a0f","unresolved":false,"context_lines":[{"line_number":354,"context_line":"            help\u003d_(\u0027Make the firewall group public, which allows it to be \u0027"},{"line_number":355,"context_line":"                   \u0027used in all projects (as opposed to the default, \u0027"},{"line_number":356,"context_line":"                   \u0027which is to restrict its use to the current project). \u0027"},{"line_number":357,"context_line":"                   \u0027This option is deprecated and would be removed in R release.\u0027))"},{"line_number":358,"context_line":"        shared_group.add_argument("},{"line_number":359,"context_line":"            \u0027--share\u0027,"},{"line_number":360,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_cf2ede8a","line":357,"range":{"start_line":357,"start_character":19,"end_line":357,"end_character":83},"updated":"2017-06-19 06:51:56.000000000","message":"http://logs.openstack.org/04/453204/13/check/gate-python-neutronclient-pep8-ubuntu-xenial/f5c4324/console.html#_2017-06-19_05_26_39_161880","commit_id":"d1bb0fca467100a30292d85fafef3d4dbc05039a"}],"neutronclient/osc/v2/fwaas/firewallpolicy.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"34bb9bf4ed4fb5d2bad28a9fb914ffc853bd919b","unresolved":false,"context_lines":[{"line_number":385,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":386,"context_line":"            help\u003d_(\u0027Disable auditing for the policy\u0027))"},{"line_number":387,"context_line":"        parser.add_argument("},{"line_number":388,"context_line":"            \u0027--shared\u0027,"},{"line_number":389,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":390,"context_line":"            help\u003d_(\u0027Restrict use of the firewall policy to the \u0027"},{"line_number":391,"context_line":"                   \u0027current project\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_68d5e01b","line":388,"range":{"start_line":388,"start_character":15,"end_line":388,"end_character":21},"updated":"2017-04-04 22:54:55.000000000","message":"ditto","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"327058a04d9b6567cd4979df72082a7247ca3490","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    shared_group.add_argument("},{"line_number":104,"context_line":"        \u0027--shared\u0027,"},{"line_number":105,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":106,"context_line":"        help\u003d_(\u0027Make the firewall policy shared, which allows it to be \u0027"},{"line_number":107,"context_line":"               \u0027used in all projects (as opposed to the default, \u0027"},{"line_number":108,"context_line":"               \u0027which is to restrict its use to the current project)\u0027))"},{"line_number":109,"context_line":"    shared_group.add_argument("},{"line_number":110,"context_line":"        \u0027--private\u0027,"},{"line_number":111,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_83f763f6","line":108,"range":{"start_line":106,"start_character":16,"end_line":108,"end_character":68},"updated":"2017-04-06 02:02:01.000000000","message":"ditto","commit_id":"bf5e172782e3a3cd48d52ce95a421a3c45418d95"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e8e6a0484900dd62b66830dfc1c3dc24afb9be2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff0f0b1f_dcf8af4a","updated":"2017-05-26 03:46:28.000000000","message":"Comments in firewallgroup.py apply to here too.","commit_id":"24f8e00b7eb8a076ccd531c8951db34084d4c0be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"570068140fc3a8b98c613993f1eb35fb76cf944b","unresolved":false,"context_lines":[{"line_number":401,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":402,"context_line":"            help\u003d_(\u0027Restrict use of the firewall policy to the \u0027"},{"line_number":403,"context_line":"                   \u0027current project. This option is deprecated \u0027"},{"line_number":404,"context_line":"                   \u0027and would be removed in R release\u0027))"},{"line_number":405,"context_line":"        return parser"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def _get_attrs(self, client_manager, parsed_args):"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_12e04b96","line":404,"range":{"start_line":404,"start_character":53,"end_line":404,"end_character":54},"updated":"2017-05-26 08:11:22.000000000","message":"nit: missing periof here","commit_id":"01c9afd82d32219af71c01d8eb509f61a0f3cc7f"}],"neutronclient/osc/v2/fwaas/firewallrule.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"34bb9bf4ed4fb5d2bad28a9fb914ffc853bd919b","unresolved":false,"context_lines":[{"line_number":361,"context_line":"            help\u003d_(\u0027Destination port number or range\u0027"},{"line_number":362,"context_line":"                   \u0027(integer in [1, 65535] or range like 123:456)\u0027))"},{"line_number":363,"context_line":"        parser.add_argument("},{"line_number":364,"context_line":"            \u0027--shared\u0027,"},{"line_number":365,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":366,"context_line":"            help\u003d_(\u0027Restrict use of the firewall rule to the current project\u0027))"},{"line_number":367,"context_line":"        parser.add_argument("}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_08e094f9","line":364,"range":{"start_line":364,"start_character":15,"end_line":364,"end_character":21},"updated":"2017-04-04 22:54:55.000000000","message":"ditto","commit_id":"2cb8ba3123634c75ec1530a5c10cebbb0c183394"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"327058a04d9b6567cd4979df72082a7247ca3490","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    shared_group.add_argument("},{"line_number":115,"context_line":"        \u0027--shared\u0027,"},{"line_number":116,"context_line":"        action\u003d\u0027store_true\u0027,"},{"line_number":117,"context_line":"        help\u003d_(\u0027Make the firewall rule shared, which allows it to be \u0027"},{"line_number":118,"context_line":"               \u0027used in all projects (as opposed to the default, \u0027"},{"line_number":119,"context_line":"               \u0027which is to restrict its use to the current project)\u0027))"},{"line_number":120,"context_line":"    shared_group.add_argument("},{"line_number":121,"context_line":"        \u0027--private\u0027,"},{"line_number":122,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_43d95b81","line":119,"range":{"start_line":117,"start_character":16,"end_line":119,"end_character":68},"updated":"2017-04-06 02:02:01.000000000","message":"ditto","commit_id":"bf5e172782e3a3cd48d52ce95a421a3c45418d95"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a0629a2dc92a9fd9bf5177316016250d56972ff","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":361,"context_line":"            help\u003d_(\u0027Destination port number or range\u0027"},{"line_number":362,"context_line":"                   \u0027(integer in [1, 65535] or range like 123:456)\u0027))"},{"line_number":363,"context_line":"        parser.add_argument("},{"line_number":364,"context_line":"            \u0027--shared\u0027,"},{"line_number":365,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":366,"context_line":"            help\u003d_(\u0027Restrict use of the firewall rule to the current project\u0027))"},{"line_number":367,"context_line":"        parser.add_argument("},{"line_number":368,"context_line":"            \u0027--enable-rule\u0027,"},{"line_number":369,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_30878612","line":366,"range":{"start_line":363,"start_character":8,"end_line":366,"end_character":79},"updated":"2017-04-07 05:23:12.000000000","message":"While this is not directly scope of this patch, this usage does not fit into \u0027unset\u0027 command in OSC convention. \u0027set\u0027 command can cover this and in such case we don\u0027t have such option in \u0027unset\u0027. This can be improved later.","commit_id":"7c9c58ce7904ff06dcfbdc55f0ea573e3531e6dc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c1f75edfddc4d767de685cfad5c1e47552cefdb7","unresolved":false,"context_lines":[{"line_number":360,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":361,"context_line":"            help\u003d_(\u0027Destination port number or range\u0027"},{"line_number":362,"context_line":"                   \u0027(integer in [1, 65535] or range like 123:456)\u0027))"},{"line_number":363,"context_line":"        parser.add_argument("},{"line_number":364,"context_line":"            \u0027--shared\u0027,"},{"line_number":365,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":366,"context_line":"            help\u003d_(\u0027Restrict use of the firewall rule to the current project\u0027))"},{"line_number":367,"context_line":"        parser.add_argument("},{"line_number":368,"context_line":"            \u0027--enable-rule\u0027,"},{"line_number":369,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bff0334d_a3ad8089","line":366,"range":{"start_line":363,"start_character":8,"end_line":366,"end_character":79},"in_reply_to":"bff0334d_30878612","updated":"2017-04-07 13:21:55.000000000","message":"Though  I agree set command can cover this and this is an nunnecessary usage of Share attribute in Unset command, but when considered from a different point of view, a user basically wants to \"Unset\" the shared attribute. Unset command was brought in to remove attributes which are already existing/defined in the Resource attribute( firewall in our case), so yes, its kind of overlaps with any \"clearing\" option in Set commands.\nI am not exactly in favor of removing it, but I do understand your point as it was the same point going through my had when I took this up with Yushiro San","commit_id":"7c9c58ce7904ff06dcfbdc55f0ea573e3531e6dc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e8e6a0484900dd62b66830dfc1c3dc24afb9be2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff0f0b1f_bc93bb00","updated":"2017-05-26 03:46:28.000000000","message":"Comments in firewallgroup.py apply to here too.","commit_id":"24f8e00b7eb8a076ccd531c8951db34084d4c0be"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"570068140fc3a8b98c613993f1eb35fb76cf944b","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        help\u003d_(\u0027Make the firewall policy public, which allows it to be \u0027"},{"line_number":119,"context_line":"               \u0027used in all projects (as opposed to the default, \u0027"},{"line_number":120,"context_line":"               \u0027which is to restrict its use to the current project). \u0027"},{"line_number":121,"context_line":"               \u0027This option is deprecated and would be removed in R Release\u0027))"},{"line_number":122,"context_line":"    shared_group.add_argument("},{"line_number":123,"context_line":"        \u0027--share\u0027,"},{"line_number":124,"context_line":"        action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_52ffe333","line":121,"range":{"start_line":121,"start_character":75,"end_line":121,"end_character":76},"updated":"2017-05-26 08:11:22.000000000","message":"nit: missing period here","commit_id":"01c9afd82d32219af71c01d8eb509f61a0f3cc7f"},{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"570068140fc3a8b98c613993f1eb35fb76cf944b","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            action\u003d\u0027store_true\u0027,"},{"line_number":380,"context_line":"            help\u003d_(\u0027Restrict use of the firewall rule to the current project. \u0027"},{"line_number":381,"context_line":"                   \u0027This option is deprecated and would be removed in \u0027"},{"line_number":382,"context_line":"                   \u0027R Release\u0027))"},{"line_number":383,"context_line":"        parser.add_argument("},{"line_number":384,"context_line":"            \u0027--enable-rule\u0027,"},{"line_number":385,"context_line":"            action\u003d\u0027store_true\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_b29d1f0c","line":382,"range":{"start_line":382,"start_character":29,"end_line":382,"end_character":30},"updated":"2017-05-26 08:11:22.000000000","message":"ditto","commit_id":"01c9afd82d32219af71c01d8eb509f61a0f3cc7f"}],"neutronclient/tests/unit/osc/v2/fwaas/common.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7e8e6a0484900dd62b66830dfc1c3dc24afb9be2","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        self.mocked.assert_called_once_with("},{"line_number":106,"context_line":"            target, {self.res: {\u0027description\u0027: update}})"},{"line_number":107,"context_line":"        self.assertIsNone(result)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    def test_set_shared(self):"},{"line_number":110,"context_line":"        target \u003d self.resource[\u0027id\u0027]"},{"line_number":111,"context_line":"        arglist \u003d [target, \u0027--shared\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff0f0b1f_1c84e7b0","line":108,"updated":"2017-05-26 03:46:28.000000000","message":"No test for --public? --public option still exists, so it should be tested.","commit_id":"24f8e00b7eb8a076ccd531c8951db34084d4c0be"}],"neutronclient/tests/unit/osc/v2/fwaas/test_firewallgroup.py":[{"author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"change_message_id":"03ebce9787a07f8ead32b5c129b0c6dbeb2c8a0f","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        verifylist \u003d []"},{"line_number":181,"context_line":"        parsed_args \u003d self.check_parser(self.cmd, arglist, verifylist)"},{"line_number":182,"context_line":"        headers, data \u003d self.cmd.take_action(parsed_args)"},{"line_number":183,"context_line":"        print(headers) "},{"line_number":184,"context_line":"        print(data)"},{"line_number":185,"context_line":"        print(self.ordered_headers)"},{"line_number":186,"context_line":"        print(self.ordered_data)"},{"line_number":187,"context_line":"        self.assertEqual(self.ordered_headers, headers)"},{"line_number":188,"context_line":"        self.assertItemEqual(self.ordered_data, data)"},{"line_number":189,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"7f231b9d_af2a827b","line":186,"range":{"start_line":183,"start_character":0,"end_line":186,"end_character":32},"updated":"2017-06-19 06:51:56.000000000","message":"Debug?","commit_id":"d1bb0fca467100a30292d85fafef3d4dbc05039a"}],"releasenotes/notes/bug-1676922-81341b70bc6f055a.yaml":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a0629a2dc92a9fd9bf5177316016250d56972ff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - This deprecation changes the \u0027public\u0027 attribute of Firewall-as-a-Service v2"},{"line_number":4,"context_line":"    to \u0027shared\u0027. This is because of the similarity between the behavior of \u0027public\u0027"},{"line_number":5,"context_line":"    attribute in Firewall-as-a-Service and the \u0027shared\u0027 attribute used in Openstack."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_70318ea2","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":16},"updated":"2017-04-07 05:23:12.000000000","message":"This sentence is rendered in \"Deprecation\" section in the release note, so \"This deprecation ....\" sounds a bit odd.\nFor example, \u0027public\u0027 attribute of Firewall-as-a-Service v2 is now deprecated in favor of \u0027shared\u0027 attribute.\n\nIt is also better to mention which resource of FWaaS v2 is under deprecation.","commit_id":"7c9c58ce7904ff06dcfbdc55f0ea573e3531e6dc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c1f75edfddc4d767de685cfad5c1e47552cefdb7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - This deprecation changes the \u0027public\u0027 attribute of Firewall-as-a-Service v2"},{"line_number":4,"context_line":"    to \u0027shared\u0027. This is because of the similarity between the behavior of \u0027public\u0027"},{"line_number":5,"context_line":"    attribute in Firewall-as-a-Service and the \u0027shared\u0027 attribute used in Openstack."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_43e114d0","line":4,"range":{"start_line":3,"start_character":4,"end_line":4,"end_character":16},"in_reply_to":"bff0334d_70318ea2","updated":"2017-04-07 13:21:55.000000000","message":"Considering your earlier comment, I will fix this based upon inputs from FWaaS team if we need to deprecate this or simply remove this and move this to the Upgrade section","commit_id":"7c9c58ce7904ff06dcfbdc55f0ea573e3531e6dc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0a0629a2dc92a9fd9bf5177316016250d56972ff","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - This deprecation changes the \u0027public\u0027 attribute of Firewall-as-a-Service v2"},{"line_number":4,"context_line":"    to \u0027shared\u0027. This is because of the similarity between the behavior of \u0027public\u0027"},{"line_number":5,"context_line":"    attribute in Firewall-as-a-Service and the \u0027shared\u0027 attribute used in Openstack."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_10224253","line":5,"range":{"start_line":5,"start_character":74,"end_line":5,"end_character":82},"updated":"2017-04-07 05:23:12.000000000","message":"-\u003e OpenStack","commit_id":"7c9c58ce7904ff06dcfbdc55f0ea573e3531e6dc"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"c1f75edfddc4d767de685cfad5c1e47552cefdb7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - This deprecation changes the \u0027public\u0027 attribute of Firewall-as-a-Service v2"},{"line_number":4,"context_line":"    to \u0027shared\u0027. This is because of the similarity between the behavior of \u0027public\u0027"},{"line_number":5,"context_line":"    attribute in Firewall-as-a-Service and the \u0027shared\u0027 attribute used in Openstack."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bff0334d_83d6fcf0","line":5,"range":{"start_line":5,"start_character":74,"end_line":5,"end_character":82},"in_reply_to":"bff0334d_10224253","updated":"2017-04-07 13:21:55.000000000","message":"Will do the change together with other changes","commit_id":"7c9c58ce7904ff06dcfbdc55f0ea573e3531e6dc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c8ad6ab065373549ad6c01a0ba091a14024da1be","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - This deprecation changes the \u0027public\u0027 attribute of Firewall-as-a-Service v2"},{"line_number":4,"context_line":"    to \u0027share\u0027. This is because of the similarity between the behavior of \u0027public\u0027"},{"line_number":5,"context_line":"    attribute in FireWall-as-a-Service and the \u0027share\u0027 attribute used in OpenStack."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"ff0f0b1f_03691b8a","line":5,"updated":"2017-05-26 09:39:34.000000000","message":"Missing description on --private and --no-share","commit_id":"01c9afd82d32219af71c01d8eb509f61a0f3cc7f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8ea4af6e27b24c2226de0c02049211c0ca495353","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - This deprecation changes the \u0027public\u0027 attribute of Firewall-as-a-Service v2"},{"line_number":4,"context_line":"    to \u0027share\u0027 and the \u0027private\u0027 attribute to \u0027no-share\u0027."},{"line_number":5,"context_line":"    This is because of the similarity between the behavior of \u0027public\u0027"},{"line_number":6,"context_line":"    attribute in FireWall-as-a-Service and the \u0027share\u0027 attribute used in OpenStack."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"ff346bd7_083c9791","line":6,"updated":"2017-07-24 10:32:24.000000000","message":"Looking at [1], \"This deprecation\" is confusing. Readers cannot understand what is \"this\". Could you reconsider the sentence taking into account the context?\n\nIn addition, you need to mention what commands of what CLI (OSC plugin commands in this case) are affected.\n\nThe current version is not friendly to readers.\n\n[1] http://docs-draft.openstack.org/04/453204/16/check/gate-python-neutronclient-releasenotes/12a4667//releasenotes/build/html/unreleased.html#deprecation-notes","commit_id":"19505f5878f1b115953629745a0f433b99d4444e"}]}
