)]}'
{"neutronclient/client.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"82532e7fdd97a75c7b4b16ffaf4f123e697f67b5","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if kwargs.get(\u0027data\u0027):"},{"line_number":334,"context_line":"            headers.setdefault(\u0027Content-Type\u0027, content_type)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        _logger.error(\"Kwargs for request: %s\" % kwargs)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        resp \u003d super(SessionClient, self).request(*args, **kwargs)"},{"line_number":339,"context_line":"        return resp, resp.text"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_caa01a45","line":336,"updated":"2017-05-24 15:21:56.000000000","message":"This is a debugging artifact presumably?","commit_id":"6ae50d4c362fc2aaee2b4a7ddcb2c2a1f3255fdc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ef24cfcf72a1fbca46f4a820ac2e6947ff7a0e55","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if kwargs.get(\u0027data\u0027):"},{"line_number":334,"context_line":"            headers.setdefault(\u0027Content-Type\u0027, content_type)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        _logger.error(\"Kwargs for request: %s\" % kwargs)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        resp \u003d super(SessionClient, self).request(*args, **kwargs)"},{"line_number":339,"context_line":"        return resp, resp.text"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_bd7f7264","line":336,"in_reply_to":"ff0f0b1f_caa01a45","updated":"2017-05-24 15:31:25.000000000","message":"yep, my bad","commit_id":"6ae50d4c362fc2aaee2b4a7ddcb2c2a1f3255fdc"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8350994aeb287859f6cbaefbad84e50536d7eec7","unresolved":false,"context_lines":[{"line_number":304,"context_line":""},{"line_number":305,"context_line":""},{"line_number":306,"context_line":"class SessionClient(adapter.Adapter):"},{"line_number":307,"context_line":"    global_request_id \u003d None"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":310,"context_line":"        self.global_request_id \u003d kwargs.pop(\"global_request_id\", None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_aebe08d2","line":307,"range":{"start_line":307,"start_character":3,"end_line":307,"end_character":28},"updated":"2017-05-25 01:57:15.000000000","message":"Is it required? self.global_request_id is always set in __init__, so it looks unnecessary.","commit_id":"2e4fc6e4c221614b5951895576a5d5c457125098"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8350994aeb287859f6cbaefbad84e50536d7eec7","unresolved":false,"context_lines":[{"line_number":307,"context_line":"    global_request_id \u003d None"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":310,"context_line":"        self.global_request_id \u003d kwargs.pop(\"global_request_id\", None)"},{"line_number":311,"context_line":"        super(SessionClient, self).__init__(*args, **kwargs)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def request(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_aeba88bd","line":310,"updated":"2017-05-25 01:57:15.000000000","message":"Does this mean a user should not share a single Client object if he wants to specify a global request ID? I originally thought it is per-request. In most cases, a single global request ID is used across multiple requests, this proposed version is easy to use, but a user needs to be careful.","commit_id":"2e4fc6e4c221614b5951895576a5d5c457125098"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8350994aeb287859f6cbaefbad84e50536d7eec7","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":310,"context_line":"        self.global_request_id \u003d kwargs.pop(\"global_request_id\", None)"},{"line_number":311,"context_line":"        super(SessionClient, self).__init__(*args, **kwargs)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def request(self, *args, **kwargs):"},{"line_number":314,"context_line":"        kwargs.setdefault(\u0027authenticated\u0027, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_2e80b8f4","line":311,"updated":"2017-05-25 01:57:15.000000000","message":"For SessionClient, why don\u0027t we change keystoneauth Adapter to accept global_request_id?","commit_id":"2e4fc6e4c221614b5951895576a5d5c457125098"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"48c45e1cad77fb28fa49cdeae27aa0f9a66c9960","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":310,"context_line":"        self.global_request_id \u003d kwargs.pop(\"global_request_id\", None)"},{"line_number":311,"context_line":"        super(SessionClient, self).__init__(*args, **kwargs)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def request(self, *args, **kwargs):"},{"line_number":314,"context_line":"        kwargs.setdefault(\u0027authenticated\u0027, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_56cffa27","line":311,"in_reply_to":"ff0f0b1f_2e80b8f4","updated":"2017-05-25 09:56:36.000000000","message":"That\u0027s on the futures map, but for Pike I\u0027d like to just get this enabled in the IaaS base services and demonstrate it. If we get that added later, that will let us delete a couple of things here.","commit_id":"2e4fc6e4c221614b5951895576a5d5c457125098"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1c2e1792b3d465d76d656a554729e7e2c21e7a4e","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":310,"context_line":"        self.global_request_id \u003d kwargs.pop(\"global_request_id\", None)"},{"line_number":311,"context_line":"        super(SessionClient, self).__init__(*args, **kwargs)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def request(self, *args, **kwargs):"},{"line_number":314,"context_line":"        kwargs.setdefault(\u0027authenticated\u0027, False)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_a1e71d47","line":311,"in_reply_to":"ff0f0b1f_56cffa27","updated":"2017-05-25 19:14:11.000000000","message":"Thanks for clarification. Sounds a reasonable step.","commit_id":"2e4fc6e4c221614b5951895576a5d5c457125098"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8350994aeb287859f6cbaefbad84e50536d7eec7","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        headers \u003d kwargs.setdefault(\u0027headers\u0027, {})"},{"line_number":320,"context_line":"        headers.setdefault(\u0027Accept\u0027, content_type)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        headers.setdefault(REQ_ID_HEADER, self.global_request_id)"},{"line_number":323,"context_line":"        # NOTE(dbelova): osprofiler_web.get_trace_id_headers does not add any"},{"line_number":324,"context_line":"        # headers in case if osprofiler is not initialized."},{"line_number":325,"context_line":"        if osprofiler_web:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_0ec97457","line":322,"updated":"2017-05-25 01:57:15.000000000","message":"Do we need if like L.158?","commit_id":"2e4fc6e4c221614b5951895576a5d5c457125098"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"48c45e1cad77fb28fa49cdeae27aa0f9a66c9960","unresolved":false,"context_lines":[{"line_number":319,"context_line":"        headers \u003d kwargs.setdefault(\u0027headers\u0027, {})"},{"line_number":320,"context_line":"        headers.setdefault(\u0027Accept\u0027, content_type)"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        headers.setdefault(REQ_ID_HEADER, self.global_request_id)"},{"line_number":323,"context_line":"        # NOTE(dbelova): osprofiler_web.get_trace_id_headers does not add any"},{"line_number":324,"context_line":"        # headers in case if osprofiler is not initialized."},{"line_number":325,"context_line":"        if osprofiler_web:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_565a5a82","line":322,"in_reply_to":"ff0f0b1f_0ec97457","updated":"2017-05-25 09:56:36.000000000","message":"Yeh, good call.","commit_id":"2e4fc6e4c221614b5951895576a5d5c457125098"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"8350994aeb287859f6cbaefbad84e50536d7eec7","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        if kwargs.get(\u0027data\u0027):"},{"line_number":334,"context_line":"            headers.setdefault(\u0027Content-Type\u0027, content_type)"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        _logger.error(\"Kwargs for request: %s\" % kwargs)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"        resp \u003d super(SessionClient, self).request(*args, **kwargs)"},{"line_number":339,"context_line":"        return resp, resp.text"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_0ecdf483","line":336,"updated":"2017-05-25 01:57:15.000000000","message":"Is it just for debugging?","commit_id":"2e4fc6e4c221614b5951895576a5d5c457125098"}]}
