)]}'
{"neutronclient/neutron/v2_0/router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a86c0b457fd42cc58491deef4d25f5e90ffdaf05","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            \u0027router\u0027, metavar\u003d\u0027ROUTER\u0027,"},{"line_number":168,"context_line":"            help\u003d_(\u0027ID or name of the router.\u0027))"},{"line_number":169,"context_line":"        parser.add_argument("},{"line_number":170,"context_line":"            \u0027subnet\u0027, metavar\u003d\u0027SUBNET\u0027,"},{"line_number":171,"context_line":"            help\u003d_(\u0027The format is \"SUBNET|subnet\u003dSUBNET|port\u003dPORT\". \u0027"},{"line_number":172,"context_line":"                   \u0027Either a subnet or port must be specified. \u0027"},{"line_number":173,"context_line":"                   \u0027Both ID and name are accepted as SUBNET or PORT. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_a026efb9","line":170,"updated":"2017-07-07 20:07:38.000000000","message":"This simple word change triggers the changes on L181,2,5,8 - I didn\u0027t want to touch the wording of anything else (and didn\u0027t!) so I don\u0027t see how it\u0027s making it more confusing?","commit_id":"8b404f4e1b86162492a61c627a2cbbd41ddf8dcf"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"94756a82c322b2c4eda81ce12a2a63ff084f501d","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            \u0027router\u0027, metavar\u003d\u0027ROUTER\u0027,"},{"line_number":168,"context_line":"            help\u003d_(\u0027ID or name of the router.\u0027))"},{"line_number":169,"context_line":"        parser.add_argument("},{"line_number":170,"context_line":"            \u0027subnet\u0027, metavar\u003d\u0027SUBNET\u0027,"},{"line_number":171,"context_line":"            help\u003d_(\u0027The format is \"SUBNET|subnet\u003dSUBNET|port\u003dPORT\". \u0027"},{"line_number":172,"context_line":"                   \u0027Either a subnet or port must be specified. \u0027"},{"line_number":173,"context_line":"                   \u0027Both ID and name are accepted as SUBNET or PORT. \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_7b07611a","line":170,"in_reply_to":"3f1d235d_a026efb9","updated":"2017-07-08 06:51:03.000000000","message":"One idea is to change metavar to (subnet\u003dSUBNET|port\u003dPORT). I think this addresses the point reported in the bug.\nBut I tend to agree the command is deprecated and I don\u0027t think we need to fix it.","commit_id":"8b404f4e1b86162492a61c627a2cbbd41ddf8dcf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"fad7972a7f5d7b02fe967c46427d7a474e6bbd35","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                   \u0027Either a subnet or port must be specified. \u0027"},{"line_number":173,"context_line":"                   \u0027Both ID and name are accepted as SUBNET or PORT. \u0027"},{"line_number":174,"context_line":"                   \u0027Note that \"subnet\u003d\" can be omitted when specifying a \u0027"},{"line_number":175,"context_line":"                   \u0027subnet.\u0027))"},{"line_number":176,"context_line":"        return parser"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def take_action(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_65fea96c","line":175,"updated":"2017-07-07 19:44:39.000000000","message":"The bug says \u0027router-interface-delete command has incorrect help\u0027, but this change goes deeper than that, and IMO making other error messages more confusing. The issue stems from the fact that we have a command that can do too many things and the help message already make that clear, IMO. We could revise the last phrase with:\n\nNote that \"subnet\u003d\" can be omitted when specifying a subnet, but port\u003d must be specified when using ports.\n\nBut again, this is deprecated so why are we fixing low priority cosmetic issues?","commit_id":"8b404f4e1b86162492a61c627a2cbbd41ddf8dcf"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"553bdd52c94ed5dd701660a85bb53d5f1a933b72","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            resource, value \u003d parsed_args.subnet.split(\u0027\u003d\u0027, 1)"},{"line_number":183,"context_line":"            if resource not in [\u0027subnet\u0027, \u0027port\u0027]:"},{"line_number":184,"context_line":"                exceptions.CommandError(_(\u0027You must specify either subnet or \u0027"},{"line_number":185,"context_line":"                                          \u0027port for SUBNET parameter.\u0027))"},{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            resource \u003d \u0027subnet\u0027"},{"line_number":188,"context_line":"            value \u003d parsed_args.subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_a5b601dc","line":185,"updated":"2017-07-07 19:40:11.000000000","message":"Does this comment makes sense to you now?","commit_id":"8b404f4e1b86162492a61c627a2cbbd41ddf8dcf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f5b6a63711685c892f2f697b2343f95167cabfaf","unresolved":false,"context_lines":[{"line_number":182,"context_line":"            resource, value \u003d parsed_args.subnet.split(\u0027\u003d\u0027, 1)"},{"line_number":183,"context_line":"            if resource not in [\u0027subnet\u0027, \u0027port\u0027]:"},{"line_number":184,"context_line":"                exceptions.CommandError(_(\u0027You must specify either subnet or \u0027"},{"line_number":185,"context_line":"                                          \u0027port for SUBNET parameter.\u0027))"},{"line_number":186,"context_line":"        else:"},{"line_number":187,"context_line":"            resource \u003d \u0027subnet\u0027"},{"line_number":188,"context_line":"            value \u003d parsed_args.subnet"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_86266c68","line":185,"in_reply_to":"3f1d235d_a5b601dc","updated":"2017-07-07 20:54:24.000000000","message":"I will admit this doesn\u0027t make as much sense, but can\u0027t say INTERFACE is perfect.  You typically only see the above help message though, as reflected in the docs.","commit_id":"8b404f4e1b86162492a61c627a2cbbd41ddf8dcf"}]}
