)]}'
{"id":"openstack%2Fpython-neutronclient~481658","triplet_id":"openstack%2Fpython-neutronclient~master~I79ab6be6453f48856793839fde50227604e15516","project":"openstack/python-neutronclient","branch":"master","topic":"bug/1702876","hashtags":[],"change_id":"I79ab6be6453f48856793839fde50227604e15516","subject":"Fix router-interface-delete help message","status":"ABANDONED","created":"2017-07-07 14:57:58.000000000","updated":"2017-07-08 06:51:03.000000000","total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0ee095da04313f23970429fc65b09f91d6aa1739","_number":481658,"virtual_id_number":481658,"owner":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-07-07 16:25:49.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2017-07-08 06:51:03.000000000","_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"date":"2017-07-07 19:27:48.000000000","_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"date":"2017-07-07 16:57:30.000000000","_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"value":-1,"date":"2017-07-07 16:58:03.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-07-07 16:25:49.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-07-07 16:57:30.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2017-07-08 06:51:03.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"}],"messages":[{"id":"92ea0a5fe0114ab427946dadb4c0b6db428c5859","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-07-07 14:57:58.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e7e098375720c16ccfbbca857d5a62946deb87b1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-07 16:25:49.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-neutronclient-docs-ubuntu-xenial http://docs-draft.openstack.org/58/481658/1/check/gate-python-neutronclient-docs-ubuntu-xenial/c9b381a//doc/build/html/ : SUCCESS in 3m 35s\n- gate-python-neutronclient-pep8-ubuntu-xenial http://logs.openstack.org/58/481658/1/check/gate-python-neutronclient-pep8-ubuntu-xenial/860275a/ : SUCCESS in 5m 40s\n- gate-python-neutronclient-python27-ubuntu-xenial http://logs.openstack.org/58/481658/1/check/gate-python-neutronclient-python27-ubuntu-xenial/8bf84f1/ : SUCCESS in 5m 03s\n- gate-python-neutronclient-python35 http://logs.openstack.org/58/481658/1/check/gate-python-neutronclient-python35/01ecfaf/ : SUCCESS in 4m 01s\n- gate-python-neutronclient-pypy http://logs.openstack.org/58/481658/1/check/gate-python-neutronclient-pypy/5ff6c2c/ : FAILURE in 2m 16s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-neutronclient-ubuntu-xenial http://logs.openstack.org/58/481658/1/check/gate-tempest-dsvm-neutron-src-python-neutronclient-ubuntu-xenial/acc934d/ : SUCCESS in 1h 27m 38s\n- check-osc-plugins http://logs.openstack.org/58/481658/1/check/check-osc-plugins/8ad5bc4/ : SUCCESS in 5m 41s (non-voting)\n- gate-neutronclient-test-dsvm-functional-ubuntu-xenial http://logs.openstack.org/58/481658/1/check/gate-neutronclient-test-dsvm-functional-ubuntu-xenial/ca52ef7/ : SUCCESS in 29m 26s\n- gate-neutronclient-test-dsvm-functional-adv-svcs-ubuntu-xenial http://logs.openstack.org/58/481658/1/check/gate-neutronclient-test-dsvm-functional-adv-svcs-ubuntu-xenial/0730489/ : SUCCESS in 30m 48s\n- gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv http://logs.openstack.org/58/481658/1/check/gate-tripleo-ci-centos-7-nonha-multinode-oooq-nv/755fcc9/ : FAILURE in 13m 48s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"41cc119a0d3764425c1c1daa994c7efea6a975dc","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 16:57:30.000000000","message":"Patch Set 1:\n\nbear in mind that the neutronclient is deprecated, though this CLI fix is  a low hanging fruit.","accounts_in_message":[],"_revision_number":1},{"id":"344e1fdbef4a7f03e41c8c532b628873b65e93a1","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 16:58:03.000000000","message":"Patch Set 1: Code-Review-1","accounts_in_message":[],"_revision_number":1},{"id":"9bed1762a2344432b15e749b947cab78c4c5f84d","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 16:58:19.000000000","message":"Patch Set 1:\n\nthis looks cosmetic to me.","accounts_in_message":[],"_revision_number":1},{"id":"57a45e3714d91e0ac2ac4e78408fcd3b21644eba","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-07-07 19:27:48.000000000","message":"Patch Set 1:\n\nYes, it\u0027s cosmetic, but from what it seems, this text is used to build https://docs.openstack.org/cli-reference/neutron.html which has the same typo...","accounts_in_message":[],"_revision_number":1},{"id":"b286ddb9673d52208d4630fc4face7ad01ae0323","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 19:38:39.000000000","message":"Patch Set 1:\n\n\u003e Yes, it\u0027s cosmetic, but from what it seems, this text is used to\n \u003e build https://docs.openstack.org/cli-reference/neutron.html which\n \u003e has the same typo...\n\nI don\u0027t understand where the problem is really. The help message says:\n\nThe format is \"SUBNET|subnet\u003dSUBNET|port\u003dPORT\". Either a subnet or port must be specified. Both ID and name are accepted as SUBNET or PORT. Note that \"subnet\u003d\" can be omitted when specifying a subnet.\n\nSo this means that these are acceptable CLI commands:\n\nrouter-interface delete foo-router foo-subnet-name-or-uuid\nrouter-interface delete foo-router subnet\u003dfoo-subnet-name-or-uuid\nrouter-interface delete foo-router port\u003dfoo-port-name-or-uuid\n\nrouter-interface delete foo-router foo-port-name-or-uuid \u003c-- expect an error","accounts_in_message":[],"_revision_number":1},{"id":"553bdd52c94ed5dd701660a85bb53d5f1a933b72","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 19:40:11.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"fad7972a7f5d7b02fe967c46427d7a474e6bbd35","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 19:44:39.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"962b499b46f4739c116104cc2f61d5e422177784","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-07-07 19:47:18.000000000","message":"Patch Set 1:\n\nI\u0027m fixing it because it\u0027s reflected in the online docs that everyone gets when they google \u0027neutron router-interface-delete\u0027","accounts_in_message":[],"_revision_number":1},{"id":"b33413cc2e1ca8fa61c602c9d3451da45381e698","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 19:58:36.000000000","message":"Patch Set 1:\n\n\u003e I\u0027m fixing it because it\u0027s reflected in the online docs that\n \u003e everyone gets when they google \u0027neutron router-interface-delete\u0027\n\nI think what\u0027s worth fixing is to add a warning to that landing page that says: \u0027Go use the OSC client as neutronclient is deprecated as Ocata and only security and critical fixes are going to be addressed until OSC is fully functional.\u0027\n\nThat said, I still believe the change proposed made it worse.","accounts_in_message":[],"_revision_number":1},{"id":"a86c0b457fd42cc58491deef4d25f5e90ffdaf05","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-07-07 20:07:38.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nI don\u0027t see how this change makes it worse, it fixes a typo, the current text is wrong.\n\nAnd as far as deprecation, just look at the commits over the past couple of months, even another typo change was added!  Do I need to put Trivialfix in the commit message ? :)","accounts_in_message":[],"_revision_number":1},{"id":"d949f83465f5f237b6536db03bf8a1c029effddb","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 20:13:21.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e I don\u0027t see how this change makes it worse, it fixes a typo, the\n \u003e current text is wrong.\n \u003e \n \u003e And as far as deprecation, just look at the commits over the past\n \u003e couple of months, even another typo change was added!  Do I need to\n \u003e put Trivialfix in the commit message ? :)\n\nread message at line 183, which now is: \n\nYou must specify either subnet or port for SUBNET parameter. SUBNET parameter for a port? That hardly makes any sense. INTERFACE was used for a reason, and it was so that it could be polymorph.\n\nAs for your comments on the commits over the past few months, I can\u0027t say much else than regrettably I haven\u0027t been around, otherwise I would have pushed back on those too. Just because others jump down a cliff so do you?\n\nRelease notes [1] state that the client is deprecated, if reviews have not taken that into account I can only express disappointment.\n\n[1] https://docs.openstack.org/releasenotes/python-neutronclient/ocata.html","accounts_in_message":[],"_revision_number":1},{"id":"f5b6a63711685c892f2f697b2343f95167cabfaf","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-07-07 20:54:24.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nBTW, the deprecation page does say \"fixes to the CLI will be assessed on a case by case basis\" so it\u0027s not dead yet.\n\nBut I will abandon this since I have no more fight on a Friday afternoon.","accounts_in_message":[],"_revision_number":1},{"id":"6d56d4c1a730d27e2e588bcefed106a5a0b98fc6","author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"date":"2017-07-07 20:54:32.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1},{"id":"73007dde89e1ff85e0e9a93075ee6f0ceeb9a131","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2017-07-07 21:06:30.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e BTW, the deprecation page does say \"fixes to the CLI will be\n \u003e assessed on a case by case basis\" so it\u0027s not dead yet.\n \u003e \n \u003e But I will abandon this since I have no more fight on a Friday\n \u003e afternoon.\n\nToo bad you see mine as a fight rather than constructive feedback (which went unacknowledged on [1], btw). That said, I think we\u0027re better off as is, as the proposed change was another cosmetic bug in the making where people would have complained about message on line 184.\n\n[1] https://review.openstack.org/#/c/481658/1/neutronclient/neutron/v2_0/router.py@175","accounts_in_message":[],"_revision_number":1},{"id":"94756a82c322b2c4eda81ce12a2a63ff084f501d","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2017-07-08 06:51:03.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"8b404f4e1b86162492a61c627a2cbbd41ddf8dcf","revisions":{"8b404f4e1b86162492a61c627a2cbbd41ddf8dcf":{"kind":"REWORK","_number":1,"created":"2017-07-07 14:57:58.000000000","uploader":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"ref":"refs/changes/58/481658/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-neutronclient","ref":"refs/changes/58/481658/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/58/481658/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/58/481658/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-neutronclient refs/changes/58/481658/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-neutronclient refs/changes/58/481658/1"}}},"commit":{"parents":[{"commit":"27cdd7d84d16921c93c5c8d05ae6b0b0c3075b68","subject":"Enable warning-is-error in doc build","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/27cdd7d84d16921c93c5c8d05ae6b0b0c3075b68"}]}],"author":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2017-07-07 14:55:53.000000000","tz":-240},"committer":{"name":"Brian Haley","email":"bhaley@redhat.com","date":"2017-07-07 14:55:53.000000000","tz":-240},"subject":"Fix router-interface-delete help message","message":"Fix router-interface-delete help message\n\nrouter-interface-delete takes SUBNET, subnet\u003dSUBNET\nor port\u003dPORT, not INTERFACE.\n\nChange-Id: I79ab6be6453f48856793839fde50227604e15516\nCloses-bug: #1702876\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8b404f4e1b86162492a61c627a2cbbd41ddf8dcf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-neutronclient/commit/8b404f4e1b86162492a61c627a2cbbd41ddf8dcf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
